B.A.T.M.A.N January 2025

b.a.t.m.a.n@lists.open-mesh.org

12 participants
21 discussions

[PATCH net-next v7 00/11] net: Improve netns handling in rtnetlink
by Xiao Liang 08 Jan '25

08 Jan '25

This patch series includes some netns-related improvements and fixes for rtnetlink, to make link creation more intuitive: 1) Creating link in another net namespace doesn't conflict with link names in current one. 2) Refector rtnetlink link creation. Create link in target namespace directly. So that # ip link add netns ns1 link-netns ns2 tun0 type gre ... will create tun0 in ns1, rather than create it in ns2 and move to ns1. And don't conflict with another interface named "tun0" in current netns. Patch 01 serves for 1) to avoids link name conflict in different netns. To achieve 2), there're mainly 3 steps: - Patch 02 packs newlink() parameters into a struct, including the original "src_net" along with more netns context. No semantic changes are introduced. - Patch 03 ~ 07 converts device drivers to use the explicit netns extracted from params. - Patch 08 ~ 09 removes the old netns parameter, and converts rtnetlink to create device in target netns directly. Patch 10 ~ 11 adds some tests for link name and link netns. BTW please note there're some issues found in current code: - In amt_newlink() drivers/net/amt.c: amt->net = net; ... amt->stream_dev = dev_get_by_index(net, ... Uses net, but amt_lookup_upper_dev() only searches in dev_net. So the AMT device may not be properly deleted if it's in a different netns from lower dev. - In gtp_newlink() in drivers/net/gtp.c: gtp->net = src_net; ... gn = net_generic(dev_net(dev), gtp_net_id); list_add_rcu(&gtp->list, &gn->gtp_dev_list); Uses src_net, but priv is linked to list in dev_net. So it may not be properly deleted on removal of link netns. - In pfcp_newlink() in drivers/net/pfcp.c: pfcp->net = net; ... pn = net_generic(dev_net(dev), pfcp_net_id); list_add_rcu(&pfcp->list, &pn->pfcp_dev_list); Same as above. - In lowpan_newlink() in net/ieee802154/6lowpan/core.c: wdev = dev_get_by_index(dev_net(ldev), nla_get_u32(tb[IFLA_LINK])); Looks for IFLA_LINK in dev_net, but in theory the ifindex is defined in link netns. --- v7: - Add selftest kconfig. - Remove a duplicated test of ip6gre. v6: link: https://lore.kernel.org/all/20241218130909.2173-1-shaw.leon@gmail.com/ - Split prototype, driver and rtnetlink changes. - Add more tests for link netns. - Fix IPv6 tunnel net overwriten in ndo_init(). - Reorder variable declarations. - Exclude a ip_tunnel-specific patch. v5: link: https://lore.kernel.org/all/20241209140151.231257-1-shaw.leon@gmail.com/ - Fix function doc in batman-adv. - Include peer_net in rtnl newlink parameters. v4: link: https://lore.kernel.org/all/20241118143244.1773-1-shaw.leon@gmail.com/ - Pack newlink() parameters to a single struct. - Use ynl async_msg_queue.empty() in selftest. v3: link: https://lore.kernel.org/all/20241113125715.150201-1-shaw.leon@gmail.com/ - Drop "netns_atomic" flag and module parameter. Add netns parameter to newlink() instead, and convert drivers accordingly. - Move python NetNSEnter helper to net selftest lib. v2: link: https://lore.kernel.org/all/20241107133004.7469-1-shaw.leon@gmail.com/ - Check NLM_F_EXCL to ensure only link creation is affected. - Add self tests for link name/ifindex conflict and notifications in different netns. - Changes in dummy driver and ynl in order to add the test case. v1: link: https://lore.kernel.org/all/20241023023146.372653-1-shaw.leon@gmail.com/ Xiao Liang (11): rtnetlink: Lookup device in target netns when creating link rtnetlink: Pack newlink() params into struct net: Use link netns in newlink() of rtnl_link_ops ieee802154: 6lowpan: Use link netns in newlink() of rtnl_link_ops net: ip_tunnel: Use link netns in newlink() of rtnl_link_ops net: ipv6: Use link netns in newlink() of rtnl_link_ops net: xfrm: Use link netns in newlink() of rtnl_link_ops rtnetlink: Remove "net" from newlink params rtnetlink: Create link directly in target net namespace selftests: net: Add python context manager for netns entering selftests: net: Add test cases for link and peer netns drivers/infiniband/ulp/ipoib/ipoib_netlink.c | 11 +- drivers/net/amt.c | 16 +- drivers/net/bareudp.c | 11 +- drivers/net/bonding/bond_netlink.c | 8 +- drivers/net/can/dev/netlink.c | 4 +- drivers/net/can/vxcan.c | 9 +- .../ethernet/qualcomm/rmnet/rmnet_config.c | 11 +- drivers/net/geneve.c | 11 +- drivers/net/gtp.c | 9 +- drivers/net/ipvlan/ipvlan.h | 4 +- drivers/net/ipvlan/ipvlan_main.c | 15 +- drivers/net/ipvlan/ipvtap.c | 10 +- drivers/net/macsec.c | 15 +- drivers/net/macvlan.c | 8 +- drivers/net/macvtap.c | 11 +- drivers/net/netkit.c | 9 +- drivers/net/pfcp.c | 11 +- drivers/net/ppp/ppp_generic.c | 10 +- drivers/net/team/team_core.c | 7 +- drivers/net/veth.c | 9 +- drivers/net/vrf.c | 11 +- drivers/net/vxlan/vxlan_core.c | 11 +- drivers/net/wireguard/device.c | 11 +- drivers/net/wireless/virtual/virt_wifi.c | 14 +- drivers/net/wwan/wwan_core.c | 25 +++- include/net/ip_tunnels.h | 5 +- include/net/rtnetlink.h | 44 +++++- net/8021q/vlan_netlink.c | 15 +- net/batman-adv/soft-interface.c | 16 +- net/bridge/br_netlink.c | 12 +- net/caif/chnl_net.c | 6 +- net/core/rtnetlink.c | 35 +++-- net/hsr/hsr_netlink.c | 14 +- net/ieee802154/6lowpan/core.c | 9 +- net/ipv4/ip_gre.c | 27 ++-- net/ipv4/ip_tunnel.c | 10 +- net/ipv4/ip_vti.c | 10 +- net/ipv4/ipip.c | 14 +- net/ipv6/ip6_gre.c | 42 ++++-- net/ipv6/ip6_tunnel.c | 20 ++- net/ipv6/ip6_vti.c | 16 +- net/ipv6/sit.c | 18 ++- net/xfrm/xfrm_interface_core.c | 15 +- tools/testing/selftests/net/Makefile | 1 + tools/testing/selftests/net/config | 5 + .../testing/selftests/net/lib/py/__init__.py | 2 +- tools/testing/selftests/net/lib/py/netns.py | 18 +++ tools/testing/selftests/net/link_netns.py | 141 ++++++++++++++++++ tools/testing/selftests/net/netns-name.sh | 10 ++ 49 files changed, 550 insertions(+), 226 deletions(-) create mode 100755 tools/testing/selftests/net/link_netns.py -- 2.47.1

3 18

[PATCH v3] batman-adv: Use mailmap to fix old e-mail addresses
by Sven Eckelmann 08 Jan '25

08 Jan '25

The .mailmap is used by git-(short)log to fix some botchered names and to map contributions from old e-mail addresses to new ones. It is also used by some tools to get the correct e-mail address for reviewers based on old contributions. The list was generated using old e-mail address changes in the source code. Also relevant entries for other contributors from the v6.13-rc5 release were added. Signed-off-by: Sven Eckelmann <sven(a)narfation.org> --- Changes in v3: - Drop duplicated mail mapping for linus.luessing(a)web.de - Link to v2: https://lore.kernel.org/r/20250107-mailmap-v2-1-12d85da0b8e7@narfation.org Changes in v2: - Switched to Antonio's preferred e-mail address - Link to v1: https://lore.kernel.org/r/20241231-mailmap-v1-1-1494110b69e7@narfation.org --- .mailmap | 74 ++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++ 1 file changed, 74 insertions(+) diff --git a/.mailmap b/.mailmap new file mode 100644 index 0000000000000000000000000000000000000000..97888b9b34d21bf0b641051c8e256a88394348f4 --- /dev/null +++ b/.mailmap @@ -0,0 +1,74 @@ +# +# This list is used by git-shortlog to fix a few botched name translations +# in the git archive, either because the author's full name was messed up +# and/or not always written the same way, making contributions from the +# same person appearing not to be so or badly displayed. Also allows for +# old email addresses to map to new email addresses. +# +# For format details, see "man gitmailmap" or "MAPPING AUTHORS" in +# "man git-shortlog" on older systems. +# +# Please keep this list dictionary sorted. +# +Andreas Langer <an.langer(a)gmx.de> <a.langer(a)q-dsl.de> +Andreas Langer <an.langer(a)gmx.de> <an.langer at gmx.de> +Andrew Lunn <andrew(a)lunn.ch> <andrew.lunn(a)ascom.ch> +Antonio Quartulli <antonio(a)mandelbit.com> <antonio(a)meshcoding.com> +Antonio Quartulli <antonio(a)mandelbit.com> <antonio(a)open-mesh.com> +Antonio Quartulli <antonio(a)mandelbit.com> <antonio.quartulli(a)open-mesh.com> +Antonio Quartulli <antonio(a)mandelbit.com> <ordex(a)autistici.org> +Antonio Quartulli <antonio(a)mandelbit.com> <ordex(a)ritirata.org> +Antonio Quartulli <antonio(a)mandelbit.com> <antonio(a)openvpn.net> +Antonio Quartulli <antonio(a)mandelbit.com> <a(a)unstable.cc> +Colin Ian King <colin.i.king(a)gmail.com> <colin.king(a)canonical.com> +Dan Carpenter <error27(a)gmail.com> <dan.carpenter(a)oracle.com> +Geliang Tang <geliang(a)kernel.org> <geliang.tang(a)linux.dev> +Geliang Tang <geliang(a)kernel.org> <geliang.tang(a)suse.com> +Geliang Tang <geliang(a)kernel.org> <geliangtang(a)xiaomi.com> +Geliang Tang <geliang(a)kernel.org> <geliangtang(a)gmail.com> +Geliang Tang <geliang(a)kernel.org> <geliangtang(a)163.com> +Geliang Tang <geliang(a)kernel.org> <tanggeliang(a)kylinos.cn> +Jiri Pirko <jiri(a)resnulli.us> <jiri(a)nvidia.com> +Jiri Pirko <jiri(a)resnulli.us> <jiri(a)mellanox.com> +Jiri Pirko <jiri(a)resnulli.us> <jpirko(a)redhat.com> +Kees Cook <kees(a)kernel.org> <kees.cook(a)canonical.com> +Kees Cook <kees(a)kernel.org> <keescook(a)chromium.org> +Kees Cook <kees(a)kernel.org> <keescook(a)google.com> +Kees Cook <kees(a)kernel.org> <kees(a)outflux.net> +Kees Cook <kees(a)kernel.org> <kees(a)ubuntu.com> +Leon Romanovsky <leon(a)kernel.org> <leon(a)leon.nu> +Leon Romanovsky <leon(a)kernel.org> <leonro(a)mellanox.com> +Leon Romanovsky <leon(a)kernel.org> <leonro(a)nvidia.com> +Linus Lüssing <linus.luessing(a)c0d3.blue> <linus.luessing(a)acsom.ch> +Linus Lüssing <linus.luessing(a)c0d3.blue> <linus.luessing(a)ascom.ch> +Linus Lüssing <linus.luessing(a)c0d3.blue> <linus.luessing(a)web.de> +Linus Lüssing <linus.luessing(a)c0d3.blue> <ll(a)simonwunderlich.de> +Marek Lindner <marek.lindner(a)mailbox.org> <lindner_marek(a)yahoo.de> +Marek Lindner <marek.lindner(a)mailbox.org> <mareklindner(a)neomailbox.ch> +Markus Schneider-Pargmann <msp(a)baylibre.com> <mpa(a)pengutronix.de> +Nikolay Aleksandrov <razor(a)blackwall.org> <naleksan(a)redhat.com> +Nikolay Aleksandrov <razor(a)blackwall.org> <nikolay(a)redhat.com> +Nikolay Aleksandrov <razor(a)blackwall.org> <nikolay(a)cumulusnetworks.com> +Nikolay Aleksandrov <razor(a)blackwall.org> <nikolay(a)nvidia.com> +Nikolay Aleksandrov <razor(a)blackwall.org> <nikolay(a)isovalent.com> +Oleksij Rempel <linux(a)rempel-privat.de> <bug-track(a)fisher-privat.net> +Oleksij Rempel <linux(a)rempel-privat.de> <external.Oleksij.Rempel(a)de.bosch.com> +Oleksij Rempel <linux(a)rempel-privat.de> <fixed-term.Oleksij.Rempel(a)de.bosch.com> +Oleksij Rempel <o.rempel(a)pengutronix.de> +Oleksij Rempel <o.rempel(a)pengutronix.de> <ore(a)pengutronix.de> +Paul E. McKenney <paulmck(a)kernel.org> <paul.mckenney(a)linaro.org> +Paul E. McKenney <paulmck(a)kernel.org> <paulmck(a)linux.ibm.com> +Paul E. McKenney <paulmck(a)kernel.org> <paulmck(a)linux.vnet.ibm.com> +Paul E. McKenney <paulmck(a)kernel.org> <paulmck(a)us.ibm.com> +Randy Dunlap <rdunlap(a)infradead.org> <rdunlap(a)xenotime.net> +Randy Dunlap <rdunlap(a)infradead.org> <randy.dunlap(a)oracle.com> +Randy Dunlap <rdunlap(a)infradead.org> <rddunlap(a)osdl.org> +Randy Dunlap <rdunlap(a)infradead.org> <randy.dunlap(a)intel.com> +Simon Wunderlich <sw(a)simonwunderlich.de> <simon(a)open-mesh.com> +Simon Wunderlich <sw(a)simonwunderlich.de> <simon.wunderlich(a)open-mesh.com> +Simon Wunderlich <sw(a)simonwunderlich.de> <simon.wunderlich(a)s2003.tu-chemnitz.de> +Simon Wunderlich <sw(a)simonwunderlich.de> <siwu(a)hrz.tu-chemnitz.de> +Sven Eckelmann <sven(a)narfation.org> <sven.eckelmann(a)gmx.de> +Sven Eckelmann <sven(a)narfation.org> <sven.eckelmann(a)open-mesh.com> +Sven Eckelmann <sven(a)narfation.org> <sven.eckelmann(a)openmesh.com> +Sven Eckelmann <sven(a)narfation.org> <sven(a)open-mesh.com> --- base-commit: c37dff40d07fbceb9d8b5d872f971ecc54da7fcc change-id: 20250107-mailmap-d61a1fc2db80 Best regards, -- Sven Eckelmann <sven(a)narfation.org>

1 0

[PATCH v3] batctl: Use mailmap to fix old e-mail addresses
by Sven Eckelmann 08 Jan '25

08 Jan '25

1 0

[PATCH v2] batman-adv: Use mailmap to fix old e-mail addresses
by Sven Eckelmann 08 Jan '25

08 Jan '25

The .mailmap is used by git-(short)log to fix some botchered names and to map contributions from old e-mail addresses to new ones. It is also used by some tools to get the correct e-mail address for reviewers based on old contributions. The list was generated using old e-mail address changes in the source code. Also relevant entries for other contributors from the v6.13-rc5 release were added. Signed-off-by: Sven Eckelmann <sven(a)narfation.org> --- Changes in v2: - Switched to Antonio's preferred e-mail address - Link to v1: https://lore.kernel.org/r/20241231-mailmap-v1-1-1494110b69e7@narfation.org --- .mailmap | 75 ++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++ 1 file changed, 75 insertions(+) diff --git a/.mailmap b/.mailmap new file mode 100644 index 0000000000000000000000000000000000000000..85a8ba762dde10a696970dd5eb3f5ae9e4e6dafa --- /dev/null +++ b/.mailmap @@ -0,0 +1,75 @@ +# +# This list is used by git-shortlog to fix a few botched name translations +# in the git archive, either because the author's full name was messed up +# and/or not always written the same way, making contributions from the +# same person appearing not to be so or badly displayed. Also allows for +# old email addresses to map to new email addresses. +# +# For format details, see "man gitmailmap" or "MAPPING AUTHORS" in +# "man git-shortlog" on older systems. +# +# Please keep this list dictionary sorted. +# +Andreas Langer <an.langer(a)gmx.de> <a.langer(a)q-dsl.de> +Andreas Langer <an.langer(a)gmx.de> <an.langer at gmx.de> +Andrew Lunn <andrew(a)lunn.ch> <andrew.lunn(a)ascom.ch> +Antonio Quartulli <antonio(a)mandelbit.com> <antonio(a)meshcoding.com> +Antonio Quartulli <antonio(a)mandelbit.com> <antonio(a)open-mesh.com> +Antonio Quartulli <antonio(a)mandelbit.com> <antonio.quartulli(a)open-mesh.com> +Antonio Quartulli <antonio(a)mandelbit.com> <ordex(a)autistici.org> +Antonio Quartulli <antonio(a)mandelbit.com> <ordex(a)ritirata.org> +Antonio Quartulli <antonio(a)mandelbit.com> <antonio(a)openvpn.net> +Antonio Quartulli <antonio(a)mandelbit.com> <a(a)unstable.cc> +Colin Ian King <colin.i.king(a)gmail.com> <colin.king(a)canonical.com> +Dan Carpenter <error27(a)gmail.com> <dan.carpenter(a)oracle.com> +Geliang Tang <geliang(a)kernel.org> <geliang.tang(a)linux.dev> +Geliang Tang <geliang(a)kernel.org> <geliang.tang(a)suse.com> +Geliang Tang <geliang(a)kernel.org> <geliangtang(a)xiaomi.com> +Geliang Tang <geliang(a)kernel.org> <geliangtang(a)gmail.com> +Geliang Tang <geliang(a)kernel.org> <geliangtang(a)163.com> +Geliang Tang <geliang(a)kernel.org> <tanggeliang(a)kylinos.cn> +Jiri Pirko <jiri(a)resnulli.us> <jiri(a)nvidia.com> +Jiri Pirko <jiri(a)resnulli.us> <jiri(a)mellanox.com> +Jiri Pirko <jiri(a)resnulli.us> <jpirko(a)redhat.com> +Kees Cook <kees(a)kernel.org> <kees.cook(a)canonical.com> +Kees Cook <kees(a)kernel.org> <keescook(a)chromium.org> +Kees Cook <kees(a)kernel.org> <keescook(a)google.com> +Kees Cook <kees(a)kernel.org> <kees(a)outflux.net> +Kees Cook <kees(a)kernel.org> <kees(a)ubuntu.com> +Leon Romanovsky <leon(a)kernel.org> <leon(a)leon.nu> +Leon Romanovsky <leon(a)kernel.org> <leonro(a)mellanox.com> +Leon Romanovsky <leon(a)kernel.org> <leonro(a)nvidia.com> +Linus Lüssing <linus.luessing(a)c0d3.blue> <linus.luessing(a)acsom.ch> +Linus Lüssing <linus.luessing(a)c0d3.blue> <linus.luessing(a)ascom.ch> +Linus Lüssing <linus.luessing(a)c0d3.blue> <linus.luessing(a)web.de> +Linus Lüssing <linus.luessing(a)c0d3.blue> <ll(a)simonwunderlich.de> +Linus Lüssing <linus.luessing(a)c0d3.blue> <linus.luessing(a)web.de> +Marek Lindner <marek.lindner(a)mailbox.org> <lindner_marek(a)yahoo.de> +Marek Lindner <marek.lindner(a)mailbox.org> <mareklindner(a)neomailbox.ch> +Markus Schneider-Pargmann <msp(a)baylibre.com> <mpa(a)pengutronix.de> +Nikolay Aleksandrov <razor(a)blackwall.org> <naleksan(a)redhat.com> +Nikolay Aleksandrov <razor(a)blackwall.org> <nikolay(a)redhat.com> +Nikolay Aleksandrov <razor(a)blackwall.org> <nikolay(a)cumulusnetworks.com> +Nikolay Aleksandrov <razor(a)blackwall.org> <nikolay(a)nvidia.com> +Nikolay Aleksandrov <razor(a)blackwall.org> <nikolay(a)isovalent.com> +Oleksij Rempel <linux(a)rempel-privat.de> <bug-track(a)fisher-privat.net> +Oleksij Rempel <linux(a)rempel-privat.de> <external.Oleksij.Rempel(a)de.bosch.com> +Oleksij Rempel <linux(a)rempel-privat.de> <fixed-term.Oleksij.Rempel(a)de.bosch.com> +Oleksij Rempel <o.rempel(a)pengutronix.de> +Oleksij Rempel <o.rempel(a)pengutronix.de> <ore(a)pengutronix.de> +Paul E. McKenney <paulmck(a)kernel.org> <paul.mckenney(a)linaro.org> +Paul E. McKenney <paulmck(a)kernel.org> <paulmck(a)linux.ibm.com> +Paul E. McKenney <paulmck(a)kernel.org> <paulmck(a)linux.vnet.ibm.com> +Paul E. McKenney <paulmck(a)kernel.org> <paulmck(a)us.ibm.com> +Randy Dunlap <rdunlap(a)infradead.org> <rdunlap(a)xenotime.net> +Randy Dunlap <rdunlap(a)infradead.org> <randy.dunlap(a)oracle.com> +Randy Dunlap <rdunlap(a)infradead.org> <rddunlap(a)osdl.org> +Randy Dunlap <rdunlap(a)infradead.org> <randy.dunlap(a)intel.com> +Simon Wunderlich <sw(a)simonwunderlich.de> <simon(a)open-mesh.com> +Simon Wunderlich <sw(a)simonwunderlich.de> <simon.wunderlich(a)open-mesh.com> +Simon Wunderlich <sw(a)simonwunderlich.de> <simon.wunderlich(a)s2003.tu-chemnitz.de> +Simon Wunderlich <sw(a)simonwunderlich.de> <siwu(a)hrz.tu-chemnitz.de> +Sven Eckelmann <sven(a)narfation.org> <sven.eckelmann(a)gmx.de> +Sven Eckelmann <sven(a)narfation.org> <sven.eckelmann(a)open-mesh.com> +Sven Eckelmann <sven(a)narfation.org> <sven.eckelmann(a)openmesh.com> +Sven Eckelmann <sven(a)narfation.org> <sven(a)open-mesh.com> --- base-commit: c37dff40d07fbceb9d8b5d872f971ecc54da7fcc change-id: 20250107-mailmap-d61a1fc2db80 Best regards, -- Sven Eckelmann <sven(a)narfation.org>

2 2

[PATCH v2] batctl: Use mailmap to fix old e-mail addresses
by Sven Eckelmann 07 Jan '25

07 Jan '25

1 0

[PATCH v2] alfred: Use mailmap to fix old e-mail addresses
by Sven Eckelmann 07 Jan '25

07 Jan '25

1 0

[PATCH v5 0/1] batctl: ping: Add subsecond precision to ping interval
by Noah Peterson 06 Jan '25

06 Jan '25

Apologies for the prior errors. My text editor was showing all differences except for the added whitespace. I also failed to compile and test the code, but this version has been tested, and I can confirm it both compiles and runs as expected. Noah Peterson (1): batctl: ping: Add subsecond precision to ping interval ping.c | 27 ++++++++++++++++++++------- 1 file changed, 20 insertions(+), 7 deletions(-) -- 2.39.5 (Apple Git-154)

3 4

[PATCH v3 0/3] add dynamic, bridged-in TT VID detection support
by Linus Lüssing 05 Jan '25

05 Jan '25

For one thing the following patchest is supposed to mitigate the regression of extra OGM overhead that we accidentally introduced with the introduction of the compatibility version 15, the TVLV support it provided, together with TT VLAN support. The addition of these TVLVs roughly doubled the OGM overhead back then, also/mainly because the 8021q and Linux bridge modules would add TT VLAN IDs 0 and 1, even if no one is actually using them. PATCH 3/3 tries to avoid this and will only add these two VLAN IDs if they were detected on actual traffic. In preparation of this the internal VLAN creation was overhauled in PATCH 1/3. This also in theory allows detecting new VLAN IDs dynamically from traffic from bridged-in traffic. So far, VLAN IDs could only be used which were anticipated and configured on top of bat0 by the administrator. However the detection of VLANs from bridged-in clients is by default disabled for now through PATCH 2/3. This patch adds a configurable limit for such snooped VLAN IDs, defaulting to zero for now. The issue is that each added VLAN still increases the OGM size considerably in the current protocol, so it is not advised to add many VLANs at the moment, without a bigger upgrade of the protocol. Also there is still an outstanding issue with temporarily broken broadcast traffic upon adding a new VLAN if BLA is enabled at the same time. Therefore defaulting to zero snooped VLANs from bridged-in clients for now. Regards, Linus --- v3: * fixing refcounting, removing an unnecessary kref_get() in PATCH 1/3 * adding PATCH 2/3 + PATCH 3/3 * resubmitting without the RFC tag v2: fix a typo, a missing "to" in the commit message

2 5

[PATCH v7 0/3] batman-adv: increase DAT DHT timeout
by Linus Lüssing 04 Jan '25

04 Jan '25

This patchset increases the DAT DHT timeout to reduce the amount of broadcasted ARP Replies. To increase the timeout only for DAT DHT entries added via DHT-PUT but not for any other entry in the DAT cache the DAT cache and DAT DHT concepts are split into two separate hash tables (PATCH 2/3). PATCH 3/3 then increases the timeout for DAT DHT entries from 5 to 30 minutes. The motivation for this patchset is based on the observations made here: https://www.open-mesh.org/projects/batman-adv/wiki/DAT_DHCP_Snooping In tests this year at Freifunk Lübeck with ~180 mesh nodes and Gluon this reduced the ARP broadcast overhead, measured over 7 days, as follows: - Total: 6677.66 bits/s -> 677.26 bits/s => -89.86% 11.92 pkts/s -> 1.21 pkts/s => -89.85% - from gateways: 5618.02 bits/s -> 212.28 => -96.22% 10.03 pkts/s -> 0.38 pkts/s => -96.21% Also see graphics and a few more test details here: - https://www.open-mesh.org/projects/batman-adv/wiki/DAT_DHCP_Snooping#Result… These patches (v5) have been applied in this mesh network without issues for 3 months now. Regards, Linus --- Changelog v7: - adding PATCH 1/3 to add the batadv_netlink_get_softif() wrapper to reduce the amount of duplicate code, both in the current code base but also for the next PATCH 2/3 Changelog v6: - removed renaming+deprecation of BATADV_P_DAT_CACHE_REPLY in PATCH 1/2 - small commit message rewording in PATCH 1/2 Changelog v5: - rebased to current main branch -> removed now obsolete debugfs code Changelog v4: - rebased to: acfc9a214d01695 ("batman-adv: genetlink: make policy common to family") Changelog v3: formerly: "batman-adv: Increase purge timeout on DAT DHT candidates" https://patchwork.open-mesh.org/patch/17728/ - fixed the potential jiffies overflow and jiffies initialization issues by replacing the last_dht_update timeout variable with a split of DAT cache and DAT DHT into two separate hash tables -> instead of maintaining two timeouts in one DAT entry two DAT entries are created and maintained in their respective DAT cache and DAT DHT hash tables Changelog v2: formerly: "batman-adv: Increase DHCP snooped DAT entry purge timeout in DHT" (https://patchwork.open-mesh.org/patch/17364/) - removed the extended timeouts flag in the DHT-PUT messages introduced in v1 again - removed DHCP dependency

2 4

[PATCH] batctl: ping: Add subsecond precision to ping interval
by Noah Peterson 04 Jan '25

04 Jan '25

Modify the batctl ping utility to accept both integer and floating-point values for the interval between sending pings. This enhancement allows specifying intervals with subsecond precision. For example: `sudo batctl ping aa:bb:cc:dd:ee:ff -i 0.5` Signed-off-by: Noah Peterson <noahbpeterson1997(a)gmail.com> --- v4: Rebasing on latest commit, reformatting into reverse X-mas tree order based on feedback from Sven <sven(a)narfation.org> v3: Rebasing on latest commit, reformatting code based on comments by Sven <sven(a)narfation.org> v2: Fixing use-after-free, adding a missing header file, noted by Sven <sven(a)narfation.org> --- ping.c | 41 +++++++++++++++++++++++++++-------------- 1 file changed, 27 insertions(+), 14 deletions(-) diff --git a/ping.c b/ping.c index 14d9c21..f7ef210 100644 --- a/ping.c +++ b/ping.c @@ -19,6 +19,7 @@ #include <stdint.h> #include <sys/select.h> #include <sys/time.h> +#include <time.h> #include <netinet/if_ether.h> #include "batadv_packet_compat.h" @@ -58,12 +59,16 @@ static int ping(struct state *state, int argc, char **argv) struct batadv_icmp_packet_rr icmp_packet_out; struct batadv_icmp_packet_rr icmp_packet_in; uint8_t last_rr[BATADV_RR_LEN][ETH_ALEN]; + struct timespec loop_interval = {0, 0}; struct ether_addr *dst_mac = NULL; struct ether_addr *rr_mac = NULL; int disable_translate_mac = 0; + double fractional_part = 0.0; unsigned int seq_counter = 0; unsigned int packets_out = 0; unsigned int packets_in = 0; + double ping_interval = 0.0; + double integral_part = 0.0; unsigned int packets_loss; struct bat_host *bat_host; struct bat_host *rr_host; @@ -101,10 +106,18 @@ static int ping(struct state *state, int argc, char **argv) ping_usage(); return EXIT_SUCCESS; case 'i': - loop_interval = strtol(optarg, NULL, 10); - if (loop_interval < 1) - loop_interval = 1; - found_args += ((*((char *)(optarg - 1)) == optchar) ? 1 : 2); + errno = 0; + ping_interval = strtod(optarg, &end); + if (errno) { + fprintf(stderr, "Error - invalid ping interval '%s'\n", optarg); + goto out; + } else { + ping_interval = fmax(ping_interval, 0.001); + } + fractional_part = modf(ping_interval, &integral_part); + loop_interval.tv_sec = (time_t)integral_part; + loop_interval.tv_nsec = (long)(fractional_part * 1000000000l); + found_args += ((*((char*)(optarg - 1)) == optchar ) ? 1 : 2); break; case 't': timeout = strtol(optarg, NULL, 10); @@ -178,7 +191,7 @@ static int ping(struct state *state, int argc, char **argv) } printf("PING %s (%s) %zu(%zu) bytes of data\n", dst_string, mac_string, - packet_len, packet_len + 28); + packet_len, packet_len + 28); while (!is_aborted) { tv.tv_sec = timeout; @@ -224,7 +237,7 @@ static int ping(struct state *state, int argc, char **argv) if ((size_t)read_len < packet_len) { printf("Warning - dropping received packet as it is smaller than expected (%zu): %zd\n", - packet_len, read_len); + packet_len, read_len); goto sleep; } @@ -236,10 +249,10 @@ static int ping(struct state *state, int argc, char **argv) case BATADV_ECHO_REPLY: time_delta = end_timer(); printf("%zd bytes from %s icmp_seq=%hu ttl=%d time=%.2f ms", - read_len, dst_string, - ntohs(icmp_packet_in.seqno), - icmp_packet_in.ttl, - time_delta); + read_len, dst_string, + ntohs(icmp_packet_in.seqno), + icmp_packet_in.ttl, + time_delta); if (read_len == sizeof(struct batadv_icmp_packet_rr)) { if (last_rr_cur == icmp_packet_in.rr_cur && @@ -302,8 +315,8 @@ static int ping(struct state *state, int argc, char **argv) if (loop_count == 0) continue; - if (loop_interval > 0) - sleep(loop_interval); + if (loop_interval.tv_sec > 0 || loop_interval.tv_nsec > 0) + nanosleep(&loop_interval, NULL); else if ((tv.tv_sec != 0) || (tv.tv_usec != 0)) select(0, NULL, NULL, NULL, &tv); } @@ -328,9 +341,9 @@ static int ping(struct state *state, int argc, char **argv) printf("--- %s ping statistics ---\n", dst_string); printf("%u packets transmitted, %u received, %u%% packet loss\n", - packets_out, packets_in, packets_loss); + packets_out, packets_in, packets_loss); printf("rtt min/avg/max/mdev = %.3f/%.3f/%.3f/%.3f ms\n", - min, avg, max, mdev); + min, avg, max, mdev); if (packets_in) ret = EXIT_SUCCESS; -- 2.39.5 (Apple Git-154)

2 2

2025

2024

2023

2022

2021

2020

2019

2018

2017

2016

2015

2014

2013

2012

2011

2010

2009

2008

2007

B.A.T.M.A.N January 2025