B.A.T.M.A.N December 2024

b.a.t.m.a.n@lists.open-mesh.org

11 participants
14 discussions

[PATCH v3 0/3] add dynamic, bridged-in TT VID detection support
by Linus Lüssing 05 Jan '25

05 Jan '25

For one thing the following patchest is supposed to mitigate the regression of extra OGM overhead that we accidentally introduced with the introduction of the compatibility version 15, the TVLV support it provided, together with TT VLAN support. The addition of these TVLVs roughly doubled the OGM overhead back then, also/mainly because the 8021q and Linux bridge modules would add TT VLAN IDs 0 and 1, even if no one is actually using them. PATCH 3/3 tries to avoid this and will only add these two VLAN IDs if they were detected on actual traffic. In preparation of this the internal VLAN creation was overhauled in PATCH 1/3. This also in theory allows detecting new VLAN IDs dynamically from traffic from bridged-in traffic. So far, VLAN IDs could only be used which were anticipated and configured on top of bat0 by the administrator. However the detection of VLANs from bridged-in clients is by default disabled for now through PATCH 2/3. This patch adds a configurable limit for such snooped VLAN IDs, defaulting to zero for now. The issue is that each added VLAN still increases the OGM size considerably in the current protocol, so it is not advised to add many VLANs at the moment, without a bigger upgrade of the protocol. Also there is still an outstanding issue with temporarily broken broadcast traffic upon adding a new VLAN if BLA is enabled at the same time. Therefore defaulting to zero snooped VLANs from bridged-in clients for now. Regards, Linus --- v3: * fixing refcounting, removing an unnecessary kref_get() in PATCH 1/3 * adding PATCH 2/3 + PATCH 3/3 * resubmitting without the RFC tag v2: fix a typo, a missing "to" in the commit message

2 5

[PATCH v7 0/3] batman-adv: increase DAT DHT timeout
by Linus Lüssing 04 Jan '25

04 Jan '25

This patchset increases the DAT DHT timeout to reduce the amount of broadcasted ARP Replies. To increase the timeout only for DAT DHT entries added via DHT-PUT but not for any other entry in the DAT cache the DAT cache and DAT DHT concepts are split into two separate hash tables (PATCH 2/3). PATCH 3/3 then increases the timeout for DAT DHT entries from 5 to 30 minutes. The motivation for this patchset is based on the observations made here: https://www.open-mesh.org/projects/batman-adv/wiki/DAT_DHCP_Snooping In tests this year at Freifunk Lübeck with ~180 mesh nodes and Gluon this reduced the ARP broadcast overhead, measured over 7 days, as follows: - Total: 6677.66 bits/s -> 677.26 bits/s => -89.86% 11.92 pkts/s -> 1.21 pkts/s => -89.85% - from gateways: 5618.02 bits/s -> 212.28 => -96.22% 10.03 pkts/s -> 0.38 pkts/s => -96.21% Also see graphics and a few more test details here: - https://www.open-mesh.org/projects/batman-adv/wiki/DAT_DHCP_Snooping#Result… These patches (v5) have been applied in this mesh network without issues for 3 months now. Regards, Linus --- Changelog v7: - adding PATCH 1/3 to add the batadv_netlink_get_softif() wrapper to reduce the amount of duplicate code, both in the current code base but also for the next PATCH 2/3 Changelog v6: - removed renaming+deprecation of BATADV_P_DAT_CACHE_REPLY in PATCH 1/2 - small commit message rewording in PATCH 1/2 Changelog v5: - rebased to current main branch -> removed now obsolete debugfs code Changelog v4: - rebased to: acfc9a214d01695 ("batman-adv: genetlink: make policy common to family") Changelog v3: formerly: "batman-adv: Increase purge timeout on DAT DHT candidates" https://patchwork.open-mesh.org/patch/17728/ - fixed the potential jiffies overflow and jiffies initialization issues by replacing the last_dht_update timeout variable with a split of DAT cache and DAT DHT into two separate hash tables -> instead of maintaining two timeouts in one DAT entry two DAT entries are created and maintained in their respective DAT cache and DAT DHT hash tables Changelog v2: formerly: "batman-adv: Increase DHCP snooped DAT entry purge timeout in DHT" (https://patchwork.open-mesh.org/patch/17364/) - removed the extended timeouts flag in the DHT-PUT messages introduced in v1 again - removed DHCP dependency

2 4

[PATCH v2] batctl: ping: Add subsecond precision to ping interval
by Noah Peterson 31 Dec '24

31 Dec '24

Modify the batctl ping utility to accept both integer and floating-point values for the interval between sending pings. This enhancement allows specifying intervals with subsecond precision. For example: `sudo batctl ping aa:bb:cc:dd:ee:ff -i 0.5` Signed-off-by: Noah Peterson <noahbpeterson1997(a)gmail.com> --- v2: Fixing use-after-free, adding a missing header file, noted by Sven <sven(a)narfation.org> --- ping.c | 27 ++++++++++++++++++--------- 1 file changed, 18 insertions(+), 9 deletions(-) diff --git a/ping.c b/ping.c index 52bce4d..a69b6ac 100644 --- a/ping.c +++ b/ping.c @@ -21,6 +21,7 @@ #include <stdint.h> #include <sys/select.h> #include <sys/time.h> +#include <time.h> #include <netinet/if_ether.h> #include "batadv_packet_compat.h" @@ -65,14 +66,15 @@ static int ping(struct state *state, int argc, char **argv) struct bat_host *bat_host, *rr_host; ssize_t read_len; int ret = EXIT_FAILURE, res, optchar, found_args = 1; - int loop_count = -1, loop_interval = 0, timeout = 1, rr = 0, i; + int loop_count = -1, timeout = 1, rr = 0, i; unsigned int seq_counter = 0, packets_out = 0, packets_in = 0, packets_loss; - char *dst_string, *mac_string, *rr_string; - double time_delta; + char *dst_string, *mac_string, *rr_string, *end = NULL; + double time_delta, ping_interval, integral_part, fractional_part = 0.0; float min = 0.0, max = 0.0, avg = 0.0, mdev = 0.0; uint8_t last_rr_cur = 0, last_rr[BATADV_RR_LEN][ETH_ALEN]; size_t packet_len; int disable_translate_mac = 0; + struct timespec loop_interval = {0, 0}; while ((optchar = getopt(argc, argv, "hc:i:t:RT")) != -1) { switch (optchar) { @@ -86,9 +88,17 @@ static int ping(struct state *state, int argc, char **argv) ping_usage(); return EXIT_SUCCESS; case 'i': - loop_interval = strtol(optarg, NULL , 10); - if (loop_interval < 1) - loop_interval = 1; + errno = 0; + ping_interval = strtod(optarg, &end); + if (errno) { + fprintf(stderr, "Error - invalid ping interval '%s'\n", optarg); + goto out; + } else { + ping_interval = fmax(ping_interval, 0.001); + } + fractional_part = modf(ping_interval, &integral_part); + loop_interval.tv_sec = (time_t)integral_part; + loop_interval.tv_nsec = (long)(fractional_part * 1000000000l); found_args += ((*((char*)(optarg - 1)) == optchar ) ? 1 : 2); break; case 't': @@ -285,9 +295,8 @@ static int ping(struct state *state, int argc, char **argv) /* skip last sleep in case no more packets will be sent out */ if (loop_count == 0) continue; - - if (loop_interval > 0) - sleep(loop_interval); + if (loop_interval.tv_sec > 0 || loop_interval.tv_nsec > 0) + nanosleep(&loop_interval, NULL); else if ((tv.tv_sec != 0) || (tv.tv_usec != 0)) select(0, NULL, NULL, NULL, &tv); } -- 2.39.5 (Apple Git-154)

2 1

[PATCH] batman-adv: Use mailmap to fix old e-mail addresses
by Sven Eckelmann 31 Dec '24

31 Dec '24

The .mailmap is used by git-(short)log to fix some botchered names and to map contributions from old e-mail addresses to new ones. It is also used by some tools to get the correct e-mail address for reviewers based on old contributions. The list was generated using old e-mail address changes in the source code. Also relevant entries for other contributors from the v6.13-rc5 release were added. Signed-off-by: Sven Eckelmann <sven(a)narfation.org> --- .mailmap | 73 ++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++ 1 file changed, 73 insertions(+) diff --git a/.mailmap b/.mailmap new file mode 100644 index 0000000000000000000000000000000000000000..baea0dfef6112e5bcb2144cadd04781e58fe63c4 --- /dev/null +++ b/.mailmap @@ -0,0 +1,73 @@ +# +# This list is used by git-shortlog to fix a few botched name translations +# in the git archive, either because the author's full name was messed up +# and/or not always written the same way, making contributions from the +# same person appearing not to be so or badly displayed. Also allows for +# old email addresses to map to new email addresses. +# +# For format details, see "man gitmailmap" or "MAPPING AUTHORS" in +# "man git-shortlog" on older systems. +# +# Please keep this list dictionary sorted. +# +Andreas Langer <an.langer(a)gmx.de> <a.langer(a)q-dsl.de> +Andreas Langer <an.langer(a)gmx.de> <an.langer at gmx.de> +Andrew Lunn <andrew(a)lunn.ch> <andrew.lunn(a)ascom.ch> +Antonio Quartulli <a(a)unstable.cc> <antonio(a)meshcoding.com> +Antonio Quartulli <a(a)unstable.cc> <antonio(a)open-mesh.com> +Antonio Quartulli <a(a)unstable.cc> <antonio.quartulli(a)open-mesh.com> +Antonio Quartulli <a(a)unstable.cc> <ordex(a)autistici.org> +Antonio Quartulli <a(a)unstable.cc> <ordex(a)ritirata.org> +Colin Ian King <colin.i.king(a)gmail.com> <colin.king(a)canonical.com> +Dan Carpenter <error27(a)gmail.com> <dan.carpenter(a)oracle.com> +Geliang Tang <geliang(a)kernel.org> <geliang.tang(a)linux.dev> +Geliang Tang <geliang(a)kernel.org> <geliang.tang(a)suse.com> +Geliang Tang <geliang(a)kernel.org> <geliangtang(a)xiaomi.com> +Geliang Tang <geliang(a)kernel.org> <geliangtang(a)gmail.com> +Geliang Tang <geliang(a)kernel.org> <geliangtang(a)163.com> +Geliang Tang <geliang(a)kernel.org> <tanggeliang(a)kylinos.cn> +Jiri Pirko <jiri(a)resnulli.us> <jiri(a)nvidia.com> +Jiri Pirko <jiri(a)resnulli.us> <jiri(a)mellanox.com> +Jiri Pirko <jiri(a)resnulli.us> <jpirko(a)redhat.com> +Kees Cook <kees(a)kernel.org> <kees.cook(a)canonical.com> +Kees Cook <kees(a)kernel.org> <keescook(a)chromium.org> +Kees Cook <kees(a)kernel.org> <keescook(a)google.com> +Kees Cook <kees(a)kernel.org> <kees(a)outflux.net> +Kees Cook <kees(a)kernel.org> <kees(a)ubuntu.com> +Leon Romanovsky <leon(a)kernel.org> <leon(a)leon.nu> +Leon Romanovsky <leon(a)kernel.org> <leonro(a)mellanox.com> +Leon Romanovsky <leon(a)kernel.org> <leonro(a)nvidia.com> +Linus Lüssing <linus.luessing(a)c0d3.blue> <linus.luessing(a)acsom.ch> +Linus Lüssing <linus.luessing(a)c0d3.blue> <linus.luessing(a)ascom.ch> +Linus Lüssing <linus.luessing(a)c0d3.blue> <linus.luessing(a)web.de> +Linus Lüssing <linus.luessing(a)c0d3.blue> <ll(a)simonwunderlich.de> +Linus Lüssing <linus.luessing(a)c0d3.blue> <linus.luessing(a)web.de> +Marek Lindner <marek.lindner(a)mailbox.org> <lindner_marek(a)yahoo.de> +Marek Lindner <marek.lindner(a)mailbox.org> <mareklindner(a)neomailbox.ch> +Markus Schneider-Pargmann <msp(a)baylibre.com> <mpa(a)pengutronix.de> +Nikolay Aleksandrov <razor(a)blackwall.org> <naleksan(a)redhat.com> +Nikolay Aleksandrov <razor(a)blackwall.org> <nikolay(a)redhat.com> +Nikolay Aleksandrov <razor(a)blackwall.org> <nikolay(a)cumulusnetworks.com> +Nikolay Aleksandrov <razor(a)blackwall.org> <nikolay(a)nvidia.com> +Nikolay Aleksandrov <razor(a)blackwall.org> <nikolay(a)isovalent.com> +Oleksij Rempel <linux(a)rempel-privat.de> <bug-track(a)fisher-privat.net> +Oleksij Rempel <linux(a)rempel-privat.de> <external.Oleksij.Rempel(a)de.bosch.com> +Oleksij Rempel <linux(a)rempel-privat.de> <fixed-term.Oleksij.Rempel(a)de.bosch.com> +Oleksij Rempel <o.rempel(a)pengutronix.de> +Oleksij Rempel <o.rempel(a)pengutronix.de> <ore(a)pengutronix.de> +Paul E. McKenney <paulmck(a)kernel.org> <paul.mckenney(a)linaro.org> +Paul E. McKenney <paulmck(a)kernel.org> <paulmck(a)linux.ibm.com> +Paul E. McKenney <paulmck(a)kernel.org> <paulmck(a)linux.vnet.ibm.com> +Paul E. McKenney <paulmck(a)kernel.org> <paulmck(a)us.ibm.com> +Randy Dunlap <rdunlap(a)infradead.org> <rdunlap(a)xenotime.net> +Randy Dunlap <rdunlap(a)infradead.org> <randy.dunlap(a)oracle.com> +Randy Dunlap <rdunlap(a)infradead.org> <rddunlap(a)osdl.org> +Randy Dunlap <rdunlap(a)infradead.org> <randy.dunlap(a)intel.com> +Simon Wunderlich <sw(a)simonwunderlich.de> <simon(a)open-mesh.com> +Simon Wunderlich <sw(a)simonwunderlich.de> <simon.wunderlich(a)open-mesh.com> +Simon Wunderlich <sw(a)simonwunderlich.de> <simon.wunderlich(a)s2003.tu-chemnitz.de> +Simon Wunderlich <sw(a)simonwunderlich.de> <siwu(a)hrz.tu-chemnitz.de> +Sven Eckelmann <sven(a)narfation.org> <sven.eckelmann(a)gmx.de> +Sven Eckelmann <sven(a)narfation.org> <sven.eckelmann(a)open-mesh.com> +Sven Eckelmann <sven(a)narfation.org> <sven.eckelmann(a)openmesh.com> +Sven Eckelmann <sven(a)narfation.org> <sven(a)open-mesh.com> --- base-commit: 50715dc9f4b72f390a24d485fbd235d01e96f988 change-id: 20241231-mailmap-3ba9f111e7a9 Best regards, -- Sven Eckelmann <sven(a)narfation.org>

1 1

[PATCH] batctl: Use mailmap to fix old e-mail addresses
by Sven Eckelmann 31 Dec '24

31 Dec '24

The .mailmap is used by git-shortlog to fix some botchered names and to map contributions from old e-mail addresses to new ones. It is also used by some tools to get the correct e-mail address for reviewers based on old contributions. The list was generated using old e-mail address changes in the source code. Also relevant entries for other contributors from the v6.13-rc5 release were added. Signed-off-by: Sven Eckelmann <sven(a)narfation.org> --- .mailmap | 35 +++++++++++++++++++++++++++++++++++ 1 file changed, 35 insertions(+) diff --git a/.mailmap b/.mailmap new file mode 100644 index 0000000000000000000000000000000000000000..79b29af883289c09124a88df6b34d64633ebdac3 --- /dev/null +++ b/.mailmap @@ -0,0 +1,35 @@ +# +# This list is used by git-shortlog to fix a few botched name translations +# in the git archive, either because the author's full name was messed up +# and/or not always written the same way, making contributions from the +# same person appearing not to be so or badly displayed. Also allows for +# old email addresses to map to new email addresses. +# +# For format details, see "man gitmailmap" or "MAPPING AUTHORS" in +# "man git-shortlog" on older systems. +# +# Please keep this list dictionary sorted. +# +Andreas Langer <an.langer(a)gmx.de> <a.langer(a)q-dsl.de> +Andreas Langer <an.langer(a)gmx.de> <an.langer at gmx.de> +Andrew Lunn <andrew(a)lunn.ch> <andrew.lunn(a)ascom.ch> +Antonio Quartulli <a(a)unstable.cc> <antonio(a)meshcoding.com> +Antonio Quartulli <a(a)unstable.cc> <antonio(a)open-mesh.com> +Antonio Quartulli <a(a)unstable.cc> <antonio.quartulli(a)open-mesh.com> +Antonio Quartulli <a(a)unstable.cc> <ordex(a)autistici.org> +Antonio Quartulli <a(a)unstable.cc> <ordex(a)ritirata.org> +Linus Lüssing <linus.luessing(a)c0d3.blue> <linus.luessing(a)acsom.ch> +Linus Lüssing <linus.luessing(a)c0d3.blue> <linus.luessing(a)ascom.ch> +Linus Lüssing <linus.luessing(a)c0d3.blue> <linus.luessing(a)web.de> +Linus Lüssing <linus.luessing(a)c0d3.blue> <ll(a)simonwunderlich.de> +Linus Lüssing <linus.luessing(a)c0d3.blue> <linus.luessing(a)web.de> +Marek Lindner <marek.lindner(a)mailbox.org> <lindner_marek(a)yahoo.de> +Marek Lindner <marek.lindner(a)mailbox.org> <mareklindner(a)neomailbox.ch> +Simon Wunderlich <sw(a)simonwunderlich.de> <simon(a)open-mesh.com> +Simon Wunderlich <sw(a)simonwunderlich.de> <simon.wunderlich(a)open-mesh.com> +Simon Wunderlich <sw(a)simonwunderlich.de> <simon.wunderlich(a)s2003.tu-chemnitz.de> +Simon Wunderlich <sw(a)simonwunderlich.de> <siwu(a)hrz.tu-chemnitz.de> +Sven Eckelmann <sven(a)narfation.org> <sven.eckelmann(a)gmx.de> +Sven Eckelmann <sven(a)narfation.org> <sven.eckelmann(a)open-mesh.com> +Sven Eckelmann <sven(a)narfation.org> <sven.eckelmann(a)openmesh.com> +Sven Eckelmann <sven(a)narfation.org> <sven(a)open-mesh.com> --- base-commit: 60ff59118fd7f007adae1cc77ce9b268e3c977ce change-id: 20241231-mailmap-41d467f0db72 Best regards, -- Sven Eckelmann <sven(a)narfation.org>

1 0

[PATCH] alfred: Add mapping of old e-mail addresses
by Sven Eckelmann 31 Dec '24

31 Dec '24

The .mailmap is used by git-shortlog to fix some botchered names and to map contributions from old e-mail addresses to new ones. It is also used by some tools to get the correct e-mail address for reviewers based on old contributions. The list was generated using old e-mail address changes in the source code. Signed-off-by: Sven Eckelmann <sven(a)narfation.org> --- .mailmap | 27 +++++++++++++++++++++++++++ 1 file changed, 27 insertions(+) diff --git a/.mailmap b/.mailmap new file mode 100644 index 0000000000000000000000000000000000000000..dac1793fa4f6e931155882f26d3df5a9b83f8fe6 --- /dev/null +++ b/.mailmap @@ -0,0 +1,27 @@ +# +# This list is used by git-shortlog to fix a few botched name translations +# in the git archive, either because the author's full name was messed up +# and/or not always written the same way, making contributions from the +# same person appearing not to be so or badly displayed. Also allows for +# old email addresses to map to new email addresses. +# +# For format details, see "man gitmailmap" or "MAPPING AUTHORS" in +# "man git-shortlog" on older systems. +# +# Please keep this list dictionary sorted. +# +Antonio Quartulli <a(a)unstable.cc> <antonio(a)meshcoding.com> +Antonio Quartulli <a(a)unstable.cc> <antonio(a)open-mesh.com> +Antonio Quartulli <a(a)unstable.cc> <antonio.quartulli(a)open-mesh.com> +Antonio Quartulli <a(a)unstable.cc> <ordex(a)autistici.org> +Antonio Quartulli <a(a)unstable.cc> <ordex(a)ritirata.org> +Marek Lindner <marek.lindner(a)mailbox.org> <lindner_marek(a)yahoo.de> +Marek Lindner <marek.lindner(a)mailbox.org> <mareklindner(a)neomailbox.ch> +Simon Wunderlich <sw(a)simonwunderlich.de> <simon(a)open-mesh.com> +Simon Wunderlich <sw(a)simonwunderlich.de> <simon.wunderlich(a)open-mesh.com> +Simon Wunderlich <sw(a)simonwunderlich.de> <simon.wunderlich(a)s2003.tu-chemnitz.de> +Simon Wunderlich <sw(a)simonwunderlich.de> <siwu(a)hrz.tu-chemnitz.de> +Sven Eckelmann <sven(a)narfation.org> <sven.eckelmann(a)gmx.de> +Sven Eckelmann <sven(a)narfation.org> <sven.eckelmann(a)open-mesh.com> +Sven Eckelmann <sven(a)narfation.org> <sven.eckelmann(a)openmesh.com> +Sven Eckelmann <sven(a)narfation.org> <sven(a)open-mesh.com> --- base-commit: afcd2daa79a87b217773bdc8a27d90fb81723c80 change-id: 20241231-mailmap-db79ce9da822 Best regards, -- Sven Eckelmann <sven(a)narfation.org>

1 0

[PATCH] batman-adv: Map VID 0 to untagged TT VLAN
by Sven Eckelmann 30 Dec '24

30 Dec '24

VID 0 is not a valid VLAN according to "802.1Q-2011" "Table 9-2—Reserved VID values". It is only used to indicate "priority tag" frames which only contain priority information and no VID. The 8021q is also redirecting the priority tagged frames to the underlying interface since commit ad1afb003939 ("vlan_dev: VLAN 0 should be treated as "no vlan tag" (802.1p packet)"). But at the same time, it automatically adds the VID 0 to all devices to ensure that VID 0 is in the allowed list of the HW filter. This resulted in a VLAN 0 which was always announced in OGM messages. batman-adv should therefore not create a new batadv_softif_vlan for VID 0 and handle all VID 0 related frames using the "untagged" global/local translation tables. Signed-off-by: Sven Eckelmann <sven(a)narfation.org> --- net/batman-adv/main.c | 7 +++++++ net/batman-adv/soft-interface.c | 14 ++++++++++++++ 2 files changed, 21 insertions(+) diff --git a/net/batman-adv/main.c b/net/batman-adv/main.c index 8e0f44c71696f642d80304ec2724e8b5e56a5d93..333e947afcce7ca4128be8406f23295df723515c 100644 --- a/net/batman-adv/main.c +++ b/net/batman-adv/main.c @@ -637,6 +637,13 @@ unsigned short batadv_get_vid(struct sk_buff *skb, size_t header_len) vhdr = (struct vlan_ethhdr *)(skb->data + header_len); vid = ntohs(vhdr->h_vlan_TCI) & VLAN_VID_MASK; + + /* VID 0 is only used to indicate "priority tag" frames which only + * contain priority information and no VID. + */ + if (vid == 0) + return BATADV_NO_FLAGS; + vid |= BATADV_VLAN_HAS_TAG; return vid; diff --git a/net/batman-adv/soft-interface.c b/net/batman-adv/soft-interface.c index 1f06861bc86a7d23c48d91e61298f48f6ec6b3f9..282a8f9b144471b12f62a547b3e57666cbb22c6d 100644 --- a/net/batman-adv/soft-interface.c +++ b/net/batman-adv/soft-interface.c @@ -637,6 +637,14 @@ static int batadv_interface_add_vid(struct net_device *dev, __be16 proto, if (proto != htons(ETH_P_8021Q)) return -EINVAL; + /* VID 0 is only used to indicate "priority tag" frames which only + * contain priority information and no VID. No management structures + * should be created for this VID and it should be handled like an + * untagged frame. + */ + if (vid == 0) + return 0; + vid |= BATADV_VLAN_HAS_TAG; /* if a new vlan is getting created and it already exists, it means that @@ -684,6 +692,12 @@ static int batadv_interface_kill_vid(struct net_device *dev, __be16 proto, if (proto != htons(ETH_P_8021Q)) return -EINVAL; + /* "priority tag" frames are handled like "untagged" frames + * and no softif_vlan needs to be destroyed + */ + if (vid == 0) + return 0; + vlan = batadv_softif_vlan_get(bat_priv, vid | BATADV_VLAN_HAS_TAG); if (!vlan) return -ENOENT; --- base-commit: 4e395d4d6908da373f00752c363c82ccf99a427e change-id: 20241216-no-vlan-0-5855407b9c6c Best regards, -- Sven Eckelmann <sven(a)narfation.org>

3 5

[PATCH] MAINTAINERS: update email address of Marek Linnder
by Marek Lindner 30 Dec '24

30 Dec '24

Signed-off-by: Marek Lindner <marek.lindner(a)mailbox.org> --- MAINTAINERS | 2 +- net/batman-adv/main.h | 2 +- 2 files changed, 2 insertions(+), 2 deletions(-) diff --git a/MAINTAINERS b/MAINTAINERS index 1120a7d8..9ea7a1e4 100644 --- a/MAINTAINERS +++ b/MAINTAINERS @@ -1,5 +1,5 @@ BATMAN ADVANCED -M: Marek Lindner <mareklindner(a)neomailbox.ch> +M: Marek Lindner <marek.lindner(a)mailbox.org> M: Simon Wunderlich <sw(a)simonwunderlich.de> M: Antonio Quartulli <a(a)unstable.cc> M: Sven Eckelmann <sven(a)narfation.org> diff --git a/net/batman-adv/main.h b/net/batman-adv/main.h index 7d0e25ce..276e9421 100644 --- a/net/batman-adv/main.h +++ b/net/batman-adv/main.h @@ -7,7 +7,7 @@ #ifndef _NET_BATMAN_ADV_MAIN_H_ #define _NET_BATMAN_ADV_MAIN_H_ -#define BATADV_DRIVER_AUTHOR "Marek Lindner <mareklindner(a)neomailbox.ch>, " \ +#define BATADV_DRIVER_AUTHOR "Marek Lindner <marek.lindner(a)mailbox.org>, " \ "Simon Wunderlich <sw(a)simonwunderlich.de>" #define BATADV_DRIVER_DESC "B.A.T.M.A.N. advanced" #define BATADV_DRIVER_DEVICE "batman-adv" -- 2.45.2

2 1

[PATCH] batctl: update email address of Marek Lindner
by Marek Lindner 27 Dec '24

27 Dec '24

--- aggregation.c | 2 +- bat-hosts.c | 2 +- bat-hosts.h | 2 +- batadv_packet_compat.h | 2 +- bisect_iv.c | 2 +- bisect_iv.h | 2 +- bonding.c | 2 +- dat_cache.c | 2 +- debug.c | 2 +- debug.h | 2 +- elp_interval.c | 2 +- fragmentation.c | 2 +- functions.c | 2 +- functions.h | 2 +- genl.h | 2 +- gw_mode.c | 2 +- hop_penalty.c | 2 +- icmp_helper.c | 2 +- icmp_helper.h | 2 +- interface.c | 2 +- loglevel.c | 2 +- main.c | 2 +- main.h | 2 +- man/batctl.8 | 4 ++-- mcast_flags.c | 2 +- netlink.c | 2 +- netlink.h | 2 +- orig_interval.c | 2 +- ping.c | 2 +- routing_algo.c | 2 +- statistics.c | 2 +- sys.c | 2 +- sys.h | 2 +- tcpdump.h | 2 +- throughput_override.c | 2 +- traceroute.c | 2 +- translate.c | 2 +- 37 files changed, 38 insertions(+), 38 deletions(-) diff --git a/aggregation.c b/aggregation.c index 47802ed..245b0d3 100644 --- a/aggregation.c +++ b/aggregation.c @@ -1,7 +1,7 @@ // SPDX-License-Identifier: GPL-2.0 /* Copyright (C) B.A.T.M.A.N. contributors: * - * Marek Lindner <mareklindner(a)neomailbox.ch> + * Marek Lindner <marek.lindner(a)mailbox.org> * * License-Filename: LICENSES/preferred/GPL-2.0 */ diff --git a/bat-hosts.c b/bat-hosts.c index 7a3d712..57e7d69 100644 --- a/bat-hosts.c +++ b/bat-hosts.c @@ -1,7 +1,7 @@ // SPDX-License-Identifier: GPL-2.0 /* Copyright (C) B.A.T.M.A.N. contributors: * - * Andreas Langer <an.langer(a)gmx.de>, Marek Lindner <mareklindner(a)neomailbox.ch> + * Andreas Langer <an.langer(a)gmx.de>, Marek Lindner <marek.lindner(a)mailbox.org> * * License-Filename: LICENSES/preferred/GPL-2.0 */ diff --git a/bat-hosts.h b/bat-hosts.h index 3cfec66..660b184 100644 --- a/bat-hosts.h +++ b/bat-hosts.h @@ -1,7 +1,7 @@ /* SPDX-License-Identifier: GPL-2.0 */ /* Copyright (C) B.A.T.M.A.N. contributors: * - * Marek Lindner <mareklindner(a)neomailbox.ch> + * Marek Lindner <marek.lindner(a)mailbox.org> * * License-Filename: LICENSES/preferred/GPL-2.0 */ diff --git a/batadv_packet_compat.h b/batadv_packet_compat.h index ee99fb0..58b9c01 100644 --- a/batadv_packet_compat.h +++ b/batadv_packet_compat.h @@ -1,7 +1,7 @@ /* SPDX-License-Identifier: GPL-2.0 */ /* Copyright (C) B.A.T.M.A.N. contributors: * - * Andreas Langer <an.langer(a)gmx.de>, Marek Lindner <mareklindner(a)neomailbox.ch> + * Andreas Langer <an.langer(a)gmx.de>, Marek Lindner <marek.lindner(a)mailbox.org> * * License-Filename: LICENSES/preferred/GPL-2.0 */ diff --git a/bisect_iv.c b/bisect_iv.c index d2dd8cf..1cb11b8 100644 --- a/bisect_iv.c +++ b/bisect_iv.c @@ -1,7 +1,7 @@ // SPDX-License-Identifier: GPL-2.0 /* Copyright (C) B.A.T.M.A.N. contributors: * - * Marek Lindner <mareklindner(a)neomailbox.ch> + * Marek Lindner <marek.lindner(a)mailbox.org> * * License-Filename: LICENSES/preferred/GPL-2.0 */ diff --git a/bisect_iv.h b/bisect_iv.h index 40424ea..ea39177 100644 --- a/bisect_iv.h +++ b/bisect_iv.h @@ -1,7 +1,7 @@ /* SPDX-License-Identifier: GPL-2.0 */ /* Copyright (C) B.A.T.M.A.N. contributors: * - * Marek Lindner <mareklindner(a)neomailbox.ch> + * Marek Lindner <marek.lindner(a)mailbox.org> * * License-Filename: LICENSES/preferred/GPL-2.0 */ diff --git a/bonding.c b/bonding.c index 5407d28..947f22b 100644 --- a/bonding.c +++ b/bonding.c @@ -1,7 +1,7 @@ // SPDX-License-Identifier: GPL-2.0 /* Copyright (C) B.A.T.M.A.N. contributors: * - * Marek Lindner <mareklindner(a)neomailbox.ch> + * Marek Lindner <marek.lindner(a)mailbox.org> * * License-Filename: LICENSES/preferred/GPL-2.0 */ diff --git a/dat_cache.c b/dat_cache.c index b666a43..4c72360 100644 --- a/dat_cache.c +++ b/dat_cache.c @@ -1,7 +1,7 @@ // SPDX-License-Identifier: GPL-2.0 /* Copyright (C) B.A.T.M.A.N. contributors: * - * Marek Lindner <mareklindner(a)neomailbox.ch> + * Marek Lindner <marek.lindner(a)mailbox.org> * * License-Filename: LICENSES/preferred/GPL-2.0 */ diff --git a/debug.c b/debug.c index 5629e1f..b715885 100644 --- a/debug.c +++ b/debug.c @@ -1,7 +1,7 @@ // SPDX-License-Identifier: GPL-2.0 /* Copyright (C) B.A.T.M.A.N. contributors: * - * Marek Lindner <mareklindner(a)neomailbox.ch> + * Marek Lindner <marek.lindner(a)mailbox.org> * * License-Filename: LICENSES/preferred/GPL-2.0 */ diff --git a/debug.h b/debug.h index ac208fe..1e97a5a 100644 --- a/debug.h +++ b/debug.h @@ -1,7 +1,7 @@ /* SPDX-License-Identifier: GPL-2.0 */ /* Copyright (C) B.A.T.M.A.N. contributors: * - * Marek Lindner <mareklindner(a)neomailbox.ch> + * Marek Lindner <marek.lindner(a)mailbox.org> * * License-Filename: LICENSES/preferred/GPL-2.0 */ diff --git a/elp_interval.c b/elp_interval.c index a951528..b294eaf 100644 --- a/elp_interval.c +++ b/elp_interval.c @@ -1,7 +1,7 @@ // SPDX-License-Identifier: GPL-2.0 /* Copyright (C) B.A.T.M.A.N. contributors: * - * Marek Lindner <mareklindner(a)neomailbox.ch> + * Marek Lindner <marek.lindner(a)mailbox.org> * * License-Filename: LICENSES/preferred/GPL-2.0 */ diff --git a/fragmentation.c b/fragmentation.c index 974345a..2f3d3b9 100644 --- a/fragmentation.c +++ b/fragmentation.c @@ -1,7 +1,7 @@ // SPDX-License-Identifier: GPL-2.0 /* Copyright (C) B.A.T.M.A.N. contributors: * - * Marek Lindner <mareklindner(a)neomailbox.ch> + * Marek Lindner <marek.lindner(a)mailbox.org> * * License-Filename: LICENSES/preferred/GPL-2.0 */ diff --git a/functions.c b/functions.c index bf6057c..f7a3080 100644 --- a/functions.c +++ b/functions.c @@ -1,7 +1,7 @@ // SPDX-License-Identifier: GPL-2.0 /* Copyright (C) B.A.T.M.A.N. contributors: * - * Andreas Langer <an.langer(a)gmx.de>, Marek Lindner <mareklindner(a)neomailbox.ch> + * Andreas Langer <an.langer(a)gmx.de>, Marek Lindner <marek.lindner(a)mailbox.org> * * License-Filename: LICENSES/preferred/GPL-2.0 */ diff --git a/functions.h b/functions.h index b85bbf1..33b57da 100644 --- a/functions.h +++ b/functions.h @@ -1,7 +1,7 @@ /* SPDX-License-Identifier: GPL-2.0 */ /* Copyright (C) B.A.T.M.A.N. contributors: * - * Andreas Langer <an.langer(a)gmx.de>, Marek Lindner <mareklindner(a)neomailbox.ch> + * Andreas Langer <an.langer(a)gmx.de>, Marek Lindner <marek.lindner(a)mailbox.org> * * License-Filename: LICENSES/preferred/GPL-2.0 */ diff --git a/genl.h b/genl.h index cab6ad3..7177ce9 100644 --- a/genl.h +++ b/genl.h @@ -1,7 +1,7 @@ /* SPDX-License-Identifier: GPL-2.0 */ /* Copyright (C) B.A.T.M.A.N. contributors: * - * Marek Lindner <mareklindner(a)neomailbox.ch> + * Marek Lindner <marek.lindner(a)mailbox.org> * * License-Filename: LICENSES/preferred/GPL-2.0 */ diff --git a/gw_mode.c b/gw_mode.c index 1b102a3..996ca08 100644 --- a/gw_mode.c +++ b/gw_mode.c @@ -1,7 +1,7 @@ // SPDX-License-Identifier: GPL-2.0 /* Copyright (C) B.A.T.M.A.N. contributors: * - * Marek Lindner <mareklindner(a)neomailbox.ch> + * Marek Lindner <marek.lindner(a)mailbox.org> * * License-Filename: LICENSES/preferred/GPL-2.0 */ diff --git a/hop_penalty.c b/hop_penalty.c index e43595b..11f30ae 100644 --- a/hop_penalty.c +++ b/hop_penalty.c @@ -1,7 +1,7 @@ // SPDX-License-Identifier: GPL-2.0 /* Copyright (C) B.A.T.M.A.N. contributors: * - * Marek Lindner <mareklindner(a)neomailbox.ch> + * Marek Lindner <marek.lindner(a)mailbox.org> * * License-Filename: LICENSES/preferred/GPL-2.0 */ diff --git a/icmp_helper.c b/icmp_helper.c index a523f23..459ea63 100644 --- a/icmp_helper.c +++ b/icmp_helper.c @@ -1,7 +1,7 @@ // SPDX-License-Identifier: GPL-2.0 /* Copyright (C) B.A.T.M.A.N. contributors: * - * Marek Lindner <mareklindner(a)neomailbox.ch>, Simon Wunderlich + * Marek Lindner <marek.lindner(a)mailbox.org>, Simon Wunderlich * * License-Filename: LICENSES/preferred/GPL-2.0 */ diff --git a/icmp_helper.h b/icmp_helper.h index d117993..f8dbaa9 100644 --- a/icmp_helper.h +++ b/icmp_helper.h @@ -1,7 +1,7 @@ /* SPDX-License-Identifier: GPL-2.0 */ /* Copyright (C) B.A.T.M.A.N. contributors: * - * Andreas Langer <an.langer(a)gmx.de>, Marek Lindner <mareklindner(a)neomailbox.ch> + * Andreas Langer <an.langer(a)gmx.de>, Marek Lindner <marek.lindner(a)mailbox.org> * * License-Filename: LICENSES/preferred/GPL-2.0 */ diff --git a/interface.c b/interface.c index 6f70468..dfe5ad4 100644 --- a/interface.c +++ b/interface.c @@ -1,7 +1,7 @@ // SPDX-License-Identifier: GPL-2.0 /* Copyright (C) B.A.T.M.A.N. contributors: * - * Marek Lindner <mareklindner(a)neomailbox.ch> + * Marek Lindner <marek.lindner(a)mailbox.org> * * License-Filename: LICENSES/preferred/GPL-2.0 */ diff --git a/loglevel.c b/loglevel.c index ab6f033..a26559a 100644 --- a/loglevel.c +++ b/loglevel.c @@ -1,7 +1,7 @@ // SPDX-License-Identifier: GPL-2.0 /* Copyright (C) B.A.T.M.A.N. contributors: * - * Marek Lindner <mareklindner(a)neomailbox.ch> + * Marek Lindner <marek.lindner(a)mailbox.org> * * License-Filename: LICENSES/preferred/GPL-2.0 */ diff --git a/main.c b/main.c index 45038d3..9516dee 100644 --- a/main.c +++ b/main.c @@ -1,7 +1,7 @@ // SPDX-License-Identifier: GPL-2.0 /* Copyright (C) B.A.T.M.A.N. contributors: * - * Andreas Langer <an.langer(a)gmx.de>, Marek Lindner <mareklindner(a)neomailbox.ch> + * Andreas Langer <an.langer(a)gmx.de>, Marek Lindner <marek.lindner(a)mailbox.org> * * License-Filename: LICENSES/preferred/GPL-2.0 */ diff --git a/main.h b/main.h index 555af07..646ef5d 100644 --- a/main.h +++ b/main.h @@ -1,7 +1,7 @@ /* SPDX-License-Identifier: GPL-2.0 */ /* Copyright (C) B.A.T.M.A.N. contributors: * - * Andreas Langer <an.langer(a)gmx.de>, Marek Lindner <mareklindner(a)neomailbox.ch> + * Andreas Langer <an.langer(a)gmx.de>, Marek Lindner <marek.lindner(a)mailbox.org> * * License-Filename: LICENSES/preferred/GPL-2.0 */ diff --git a/man/batctl.8 b/man/batctl.8 index b5be0b8..f7522b4 100644 --- a/man/batctl.8 +++ b/man/batctl.8 @@ -515,7 +515,7 @@ addresses. .BR traceroute (1), .BR trace-cmd (1) .SH AUTHOR -batctl was written by Andreas Langer <an.langer(a)gmx.de> and Marek Lindner <mareklindner(a)neomailbox.ch>. +batctl was written by Andreas Langer <an.langer(a)gmx.de> and Marek Lindner <marek.lindner(a)mailbox.org>. .PP -This manual page was written by Simon Wunderlich <sw(a)simonwunderlich.de>, Marek Lindner <mareklindner(a)neomailbox.ch> and +This manual page was written by Simon Wunderlich <sw(a)simonwunderlich.de>, Marek Lindner <marek.lindner(a)mailbox.org> and Andrew Lunn <andrew(a)lunn.ch> diff --git a/mcast_flags.c b/mcast_flags.c index 9535981..9dcb90c 100644 --- a/mcast_flags.c +++ b/mcast_flags.c @@ -1,7 +1,7 @@ // SPDX-License-Identifier: GPL-2.0 /* Copyright (C) B.A.T.M.A.N. contributors: * - * Marek Lindner <mareklindner(a)neomailbox.ch> + * Marek Lindner <marek.lindner(a)mailbox.org> * * License-Filename: LICENSES/preferred/GPL-2.0 */ diff --git a/netlink.c b/netlink.c index a41548d..31aec5e 100644 --- a/netlink.c +++ b/netlink.c @@ -1,7 +1,7 @@ // SPDX-License-Identifier: GPL-2.0 /* Copyright (C) B.A.T.M.A.N. contributors: * - * Marek Lindner <mareklindner(a)neomailbox.ch>, Andrew Lunn <andrew(a)lunn.ch> + * Marek Lindner <marek.lindner(a)mailbox.org>, Andrew Lunn <andrew(a)lunn.ch> * * License-Filename: LICENSES/preferred/GPL-2.0 */ diff --git a/netlink.h b/netlink.h index 237f760..03da947 100644 --- a/netlink.h +++ b/netlink.h @@ -1,7 +1,7 @@ /* SPDX-License-Identifier: GPL-2.0 */ /* Copyright (C) B.A.T.M.A.N. contributors: * - * Marek Lindner <mareklindner(a)neomailbox.ch>, Andrew Lunn <andrew(a)lunn.ch> + * Marek Lindner <marek.lindner(a)mailbox.org>, Andrew Lunn <andrew(a)lunn.ch> * * License-Filename: LICENSES/preferred/GPL-2.0 */ diff --git a/orig_interval.c b/orig_interval.c index 0201b15..4e13016 100644 --- a/orig_interval.c +++ b/orig_interval.c @@ -1,7 +1,7 @@ // SPDX-License-Identifier: GPL-2.0 /* Copyright (C) B.A.T.M.A.N. contributors: * - * Marek Lindner <mareklindner(a)neomailbox.ch> + * Marek Lindner <marek.lindner(a)mailbox.org> * * License-Filename: LICENSES/preferred/GPL-2.0 */ diff --git a/ping.c b/ping.c index f2f6c41..14d9c21 100644 --- a/ping.c +++ b/ping.c @@ -1,7 +1,7 @@ // SPDX-License-Identifier: GPL-2.0 /* Copyright (C) B.A.T.M.A.N. contributors: * - * Andreas Langer <an.langer(a)gmx.de>, Marek Lindner <mareklindner(a)neomailbox.ch> + * Andreas Langer <an.langer(a)gmx.de>, Marek Lindner <marek.lindner(a)mailbox.org> * * License-Filename: LICENSES/preferred/GPL-2.0 */ diff --git a/routing_algo.c b/routing_algo.c index 8d1b63e..5aa4597 100644 --- a/routing_algo.c +++ b/routing_algo.c @@ -1,7 +1,7 @@ // SPDX-License-Identifier: GPL-2.0 /* Copyright (C) B.A.T.M.A.N. contributors: * - * Marek Lindner <mareklindner(a)neomailbox.ch> + * Marek Lindner <marek.lindner(a)mailbox.org> * * License-Filename: LICENSES/preferred/GPL-2.0 */ diff --git a/statistics.c b/statistics.c index 134a8cd..9506308 100644 --- a/statistics.c +++ b/statistics.c @@ -1,7 +1,7 @@ // SPDX-License-Identifier: GPL-2.0 /* Copyright (C) B.A.T.M.A.N. contributors: * - * Marek Lindner <mareklindner(a)neomailbox.ch> + * Marek Lindner <marek.lindner(a)mailbox.org> * * License-Filename: LICENSES/preferred/GPL-2.0 */ diff --git a/sys.c b/sys.c index dcef51f..0b38677 100644 --- a/sys.c +++ b/sys.c @@ -1,7 +1,7 @@ // SPDX-License-Identifier: GPL-2.0 /* Copyright (C) B.A.T.M.A.N. contributors: * - * Marek Lindner <mareklindner(a)neomailbox.ch> + * Marek Lindner <marek.lindner(a)mailbox.org> * * License-Filename: LICENSES/preferred/GPL-2.0 */ diff --git a/sys.h b/sys.h index 1f27347..493f41f 100644 --- a/sys.h +++ b/sys.h @@ -1,7 +1,7 @@ /* SPDX-License-Identifier: GPL-2.0 */ /* Copyright (C) B.A.T.M.A.N. contributors: * - * Marek Lindner <mareklindner(a)neomailbox.ch> + * Marek Lindner <marek.lindner(a)mailbox.org> * * License-Filename: LICENSES/preferred/GPL-2.0 */ diff --git a/tcpdump.h b/tcpdump.h index be64aeb..91f9242 100644 --- a/tcpdump.h +++ b/tcpdump.h @@ -1,7 +1,7 @@ /* SPDX-License-Identifier: GPL-2.0 */ /* Copyright (C) B.A.T.M.A.N. contributors: * - * Andreas Langer <an.langer(a)gmx.de>, Marek Lindner <mareklindner(a)neomailbox.ch> + * Andreas Langer <an.langer(a)gmx.de>, Marek Lindner <marek.lindner(a)mailbox.org> * * License-Filename: LICENSES/preferred/GPL-2.0 */ diff --git a/throughput_override.c b/throughput_override.c index 9767d9e..6c316ff 100644 --- a/throughput_override.c +++ b/throughput_override.c @@ -1,7 +1,7 @@ // SPDX-License-Identifier: GPL-2.0 /* Copyright (C) B.A.T.M.A.N. contributors: * - * Marek Lindner <mareklindner(a)neomailbox.ch> + * Marek Lindner <marek.lindner(a)mailbox.org> * * License-Filename: LICENSES/preferred/GPL-2.0 */ diff --git a/traceroute.c b/traceroute.c index 2409c30..a0fb925 100644 --- a/traceroute.c +++ b/traceroute.c @@ -1,7 +1,7 @@ // SPDX-License-Identifier: GPL-2.0 /* Copyright (C) B.A.T.M.A.N. contributors: * - * Andreas Langer <an.langer(a)gmx.de>, Marek Lindner <mareklindner(a)neomailbox.ch> + * Andreas Langer <an.langer(a)gmx.de>, Marek Lindner <marek.lindner(a)mailbox.org> * * License-Filename: LICENSES/preferred/GPL-2.0 */ diff --git a/translate.c b/translate.c index 0101724..73510ea 100644 --- a/translate.c +++ b/translate.c @@ -1,7 +1,7 @@ // SPDX-License-Identifier: GPL-2.0 /* Copyright (C) B.A.T.M.A.N. contributors: * - * Andreas Langer <an.langer(a)gmx.de>, Marek Lindner <mareklindner(a)neomailbox.ch> + * Andreas Langer <an.langer(a)gmx.de>, Marek Lindner <marek.lindner(a)mailbox.org> * * License-Filename: LICENSES/preferred/GPL-2.0 */ -- 2.45.2

1 0

[PATCH net-next v6 00/11] net: Improve netns handling in rtnetlink
by Xiao Liang 19 Dec '24

19 Dec '24

This patch series includes some netns-related improvements and fixes for rtnetlink, to make link creation more intuitive: 1) Creating link in another net namespace doesn't conflict with link names in current one. 2) Refector rtnetlink link creation. Create link in target namespace directly. So that # ip link add netns ns1 link-netns ns2 tun0 type gre ... will create tun0 in ns1, rather than create it in ns2 and move to ns1. And don't conflict with another interface named "tun0" in current netns. Patch 01 servers for 1) to avoids link name conflict in different netns. To achieve 2), there're mainly 3 steps: - Patch 02 packs newlink() parameters into a struct, including the original "src_net" along with more netns context. - Patch 03 ~ 07 converts device drivers to use the explicit netns extracted from params. - Patch 08 ~ 09 removes the old netns parameter, and converts rtnetlink to create device in target netns directly. Patch 10 ~ 11 adds some tests for link name and link netns. BTW please note there're some issues found in current code: - In amt_newlink() drivers/net/amt.c: amt->net = net; ... amt->stream_dev = dev_get_by_index(net, ... Uses net, but amt_lookup_upper_dev() only searches in dev_net. So the AMT device may not be properly deleted if it's in a different netns from lower dev. - In gtp_newlink() in drivers/net/gtp.c: gtp->net = src_net; ... gn = net_generic(dev_net(dev), gtp_net_id); list_add_rcu(&gtp->list, &gn->gtp_dev_list); Uses src_net, but priv is linked to list in dev_net. So it may not be properly deleted on removal of link netns. - In pfcp_newlink() in drivers/net/pfcp.c: pfcp->net = net; ... pn = net_generic(dev_net(dev), pfcp_net_id); list_add_rcu(&pfcp->list, &pn->pfcp_dev_list); Same as above. - In lowpan_newlink() in net/ieee802154/6lowpan/core.c: wdev = dev_get_by_index(dev_net(ldev), nla_get_u32(tb[IFLA_LINK])); Looks for IFLA_LINK in dev_net, but in theory the ifindex is defined in link netns. --- v6: - Split prototype, driver and rtnetlink changes. - Add more tests for link netns. - Fix IPv6 tunnel net overwriten in ndo_init(). - Reorder variable declarations. - Exclude a ip_tunnel-specific patch. v5: link: https://lore.kernel.org/all/20241209140151.231257-1-shaw.leon@gmail.com/ - Fix function doc in batman-adv. - Include peer_net in rtnl newlink parameters. v4: link: https://lore.kernel.org/all/20241118143244.1773-1-shaw.leon@gmail.com/ - Pack newlink() parameters to a single struct. - Use ynl async_msg_queue.empty() in selftest. v3: link: https://lore.kernel.org/all/20241113125715.150201-1-shaw.leon@gmail.com/ - Drop "netns_atomic" flag and module parameter. Add netns parameter to newlink() instead, and convert drivers accordingly. - Move python NetNSEnter helper to net selftest lib. v2: link: https://lore.kernel.org/all/20241107133004.7469-1-shaw.leon@gmail.com/ - Check NLM_F_EXCL to ensure only link creation is affected. - Add self tests for link name/ifindex conflict and notifications in different netns. - Changes in dummy driver and ynl in order to add the test case. v1: link: https://lore.kernel.org/all/20241023023146.372653-1-shaw.leon@gmail.com/ Xiao Liang (11): rtnetlink: Lookup device in target netns when creating link rtnetlink: Pack newlink() params into struct net: Use link netns in newlink() of rtnl_link_ops ieee802154: 6lowpan: Use link netns in newlink() of rtnl_link_ops net: ip_tunnel: Use link netns in newlink() of rtnl_link_ops net: ipv6: Use link netns in newlink() of rtnl_link_ops net: xfrm: Use link netns in newlink() of rtnl_link_ops rtnetlink: Remove "net" from newlink params rtnetlink: Create link directly in target net namespace selftests: net: Add python context manager for netns entering selftests: net: Add test cases for link and peer netns drivers/infiniband/ulp/ipoib/ipoib_netlink.c | 11 +- drivers/net/amt.c | 16 +- drivers/net/bareudp.c | 11 +- drivers/net/bonding/bond_netlink.c | 8 +- drivers/net/can/dev/netlink.c | 4 +- drivers/net/can/vxcan.c | 9 +- .../ethernet/qualcomm/rmnet/rmnet_config.c | 11 +- drivers/net/geneve.c | 11 +- drivers/net/gtp.c | 9 +- drivers/net/ipvlan/ipvlan.h | 4 +- drivers/net/ipvlan/ipvlan_main.c | 15 +- drivers/net/ipvlan/ipvtap.c | 10 +- drivers/net/macsec.c | 15 +- drivers/net/macvlan.c | 8 +- drivers/net/macvtap.c | 11 +- drivers/net/netkit.c | 9 +- drivers/net/pfcp.c | 11 +- drivers/net/ppp/ppp_generic.c | 10 +- drivers/net/team/team_core.c | 7 +- drivers/net/veth.c | 9 +- drivers/net/vrf.c | 11 +- drivers/net/vxlan/vxlan_core.c | 11 +- drivers/net/wireguard/device.c | 11 +- drivers/net/wireless/virtual/virt_wifi.c | 14 +- drivers/net/wwan/wwan_core.c | 25 ++- include/net/ip_tunnels.h | 5 +- include/net/rtnetlink.h | 44 +++++- net/8021q/vlan_netlink.c | 15 +- net/batman-adv/soft-interface.c | 16 +- net/bridge/br_netlink.c | 12 +- net/caif/chnl_net.c | 6 +- net/core/rtnetlink.c | 35 +++-- net/hsr/hsr_netlink.c | 14 +- net/ieee802154/6lowpan/core.c | 9 +- net/ipv4/ip_gre.c | 27 ++-- net/ipv4/ip_tunnel.c | 10 +- net/ipv4/ip_vti.c | 10 +- net/ipv4/ipip.c | 14 +- net/ipv6/ip6_gre.c | 42 ++++-- net/ipv6/ip6_tunnel.c | 20 ++- net/ipv6/ip6_vti.c | 16 +- net/ipv6/sit.c | 18 ++- net/xfrm/xfrm_interface_core.c | 15 +- tools/testing/selftests/net/Makefile | 1 + .../testing/selftests/net/lib/py/__init__.py | 2 +- tools/testing/selftests/net/lib/py/netns.py | 18 +++ tools/testing/selftests/net/link_netns.py | 142 ++++++++++++++++++ tools/testing/selftests/net/netns-name.sh | 10 ++ 48 files changed, 546 insertions(+), 226 deletions(-) create mode 100755 tools/testing/selftests/net/link_netns.py -- 2.47.1

2 13

2025

2024

2023

2022

2021

2020

2019

2018

2017

2016

2015

2014

2013

2012

2011

2010

2009

2008

2007

B.A.T.M.A.N December 2024