B.A.T.M.A.N November 2024

b.a.t.m.a.n@lists.open-mesh.org

15 participants
20 discussions

Re: IP connectivity issue at openwrt nodes
by Sven Eckelmann 19 Nov '24

19 Nov '24

On Tuesday, 19 November 2024 15:17:28 CET Mu De wrote: > Dear Sven, > > I would like to ask generic system and topology questions: Sorry about the "hijack part". Looked at first glance like another person + topic. Simply because you've used a different from + signature and suddenly added other persons in Cc. > 1-)Generic System Question > According to info at the " > https://www.kernel.org/doc/Documentation/networking/batman-adv.txt" , if > following "batman-adv" folder do not exist, your interface might not be > supported. > If those folder does NOT exist in a system but interfaces can be > add/removed via "batctl if" command, and outputs indicates interface > active, can we consider this system works properly? > > "/sys/class/net/eth0/batman_adv/" This is an outdated document. See https://www.kernel.org/doc/html/latest/networking/batman-adv.html for the correct one > 2-)Generic Topology Question > Consider multiple batman nodes, each have 1 bridge interface, bridge have > two ports, one "bat0" and "eth0", Ok, ethernet bridge to mesh > and IP is assigned to the bridge node. Ok > At > each node, multiple wired/wireless interfaces which have stable connections > to other nodes are assigned to "bat0" and these interfaces are indicated as > "active" via batctl. Ok, the underlying interfaces for bat0 have "redundancy"? > Can local process of batman nodes and external non-batman nodes connected > to "eth0" port of the bridge, have IP connectivity to each other via IP > addresses assigned to bridges? Yes. The bridge is handling this part - not batman-adv. Just make sure that you don't have any IP conflicts. So, for example eth0 + bat0 + underlying interfaces for bat0 should most likely have no IP address assigned - unless you know what you are doing and need it for debugging (or similar things). Kind regards, Sven

2 1

IP connectivity issue at openwrt nodes
by soanican＠gmail.com 19 Nov '24

19 Nov '24

Hi, Im new to batman-adv and this is my first attempt to make it work. Im having connectivity issue, couldnt complete the configuration. topology: PC1---eth0(Openwrt1)phy1sta0----------phy1ap0(openwrt2)eth0--PC2 openwrt1 has bridge(br-lan), with members of eth0 and bat0. PC1 is connected to eth0 bat0 has interface phy1-ap0 and interface is active openwrt1 br1 ip is 192.168.1.11 openwrt2 has bridge(br-lan), with members of eth0 and bat0 PC2 is connected to eth0 bat0 has interface phy1-sta0 and interface is active openwrt2 br1 ip is 192.168.1.12 openwrt2 phy1-sta0 is connected to openwrt1 phy1-ap0 I can not ping 192.168.1.11 from openwrt2 and can not 192.168.1.12 from openwrt1 (from console/ssh interfaces) My final aim is to be able to ping from PC1 connected to eth0 of openwrt1, to openwrt1, openwrt2 and PC2 connected to eth0 of openwrt2. What I am missing here? some logs from batman-adv: version: batctl 2024.3-openwrt-1 [batman-adv: 2024.3-openwrt-2] [ 188.360147] phy1-sta0: associated [ 188.379399] batman_adv: bat0: Adding interface: phy1-sta0 [ 188.384849] batman_adv: bat0: The MTU of interface phy1-sta0 is too small (1532) to handle the transport of batman-adv packets. Packets going over this interface will be fragmented on layer2 which could impact the performance. Setting the MTU to 1560 would solve the problem. [ 188.409162] batman_adv: bat0: Interface activated: phy1-sta0 root@dasal-01:~# brctl show bridge name bridge id STP enabled interfaces br-lan 7fff.16acd96f6f78 no eth0 bat0 root@owrt-01:~# batctl if phy1-sta0: active

2 2

Re: IP connectivity issue at openwrt nodes
by Sven Eckelmann 19 Nov '24

19 Nov '24

On Tuesday, 19 November 2024 15:17:28 CET Mu De wrote: > Dear Sven, > > I would like to ask generic system and topology questions: Don't hijack other persons threads. Kind regards, Sven

1 0

Please unsubscribe me from the mailing list. thank you.
by Mike Evans 19 Nov '24

19 Nov '24

Please unsubscribe me from the mailing list. thank you. -- GPG Key ID: DB8F7CF1C67BBC0F Keyserver: https://keys.openpgp.org

2 1

[PATCH 00/17] replace call_rcu by kfree_rcu for simple kmem_cache_free callback
by Julia Lawall 17 Nov '24

17 Nov '24

Since SLOB was removed and since commit 6c6c47b063b5 ("mm, slab: call kvfree_rcu_barrier() from kmem_cache_destroy()"), it is not necessary to use call_rcu when the callback only performs kmem_cache_free. Use kfree_rcu() directly. The changes were done using the following Coccinelle semantic patch. This semantic patch is designed to ignore cases where the callback function is used in another way. // <smpl> #spatch --all-includes --include-headers @r@ expression e; local idexpression e2; identifier cb,f,g; position p; @@ ( call_rcu(...,e2) | call_rcu(&e->f,cb@p) | call_rcu(&e->f.g,cb@p) ) @r1@ type T,T1; identifier x,r.cb; @@ cb(...) { ( kmem_cache_free(...); | T x = ...; kmem_cache_free(...,(T1)x); | T x; x = ...; kmem_cache_free(...,(T1)x); ) } @s depends on r1@ position p != r.p; identifier r.cb; @@ cb@p @script:ocaml@ cb << r.cb; p << s.p; @@ Printf.eprintf "Other use of %s at %s:%d\n" cb (List.hd p).file (List.hd p).line @depends on r1 && !s@ expression e; identifier r.cb,f,g; position r.p; @@ ( - call_rcu(&e->f,cb@p) + kfree_rcu(e,f) | - call_rcu(&e->f.g,cb@p) + kfree_rcu(e,f.g) ) @r1a depends on !s@ type T,T1; identifier x,r.cb; @@ - cb(...) { ( - kmem_cache_free(...); | - T x = ...; - kmem_cache_free(...,(T1)x); | - T x; - x = ...; - kmem_cache_free(...,(T1)x); ) - } @r2 depends on !r1@ identifier r.cb; @@ cb(...) { ... } @script:ocaml depends on !r1 && !r2@ cb << r.cb; @@ Printf.eprintf "need definition for %s\n" cb // </smpl> --- arch/powerpc/kvm/book3s_mmu_hpte.c | 8 ------ block/blk-ioc.c | 9 ------ drivers/net/wireguard/allowedips.c | 9 +----- fs/ecryptfs/dentry.c | 8 ------ fs/nfsd/nfs4state.c | 9 ------ kernel/time/posix-timers.c | 9 ------ net/batman-adv/translation-table.c | 47 ++---------------------------------- net/bridge/br_fdb.c | 9 ------ net/can/gw.c | 13 ++------- net/ipv4/fib_trie.c | 8 ------ net/ipv4/inetpeer.c | 9 +----- net/ipv6/ip6_fib.c | 9 ------ net/ipv6/xfrm6_tunnel.c | 8 ------ net/kcm/kcmsock.c | 10 ------- net/netfilter/nf_conncount.c | 10 ------- net/netfilter/nf_conntrack_expect.c | 10 ------- net/netfilter/xt_hashlimit.c | 9 ------ 17 files changed, 23 insertions(+), 171 deletions(-)

9 12

[PATCH v2 0/5] batman-adv: TT change events fixes and improvements
by Remi Pommarel 17 Nov '24

17 Nov '24

The first three patches are actual fixes. The first two try to avoid sending uninitialized data that could be interpreted as invalid TT change events in both TT change response and OGM. Following invalid entries could be seen when that happen with batctl o: * 00:00:00:00:00:00 -1 [....] ( 0) 88:12:4e:ad:7e:ba (179) (0x45845380) * 00:00:00:00:78:79 4092 [.W..] ( 0) 88:12:4e:ad:7e:3c (145) (0x8ebadb8b) The third one fixes an issue that happened when a TT change event list is too big for the MTU, the list was never actually sent nor free and continued to grow indefinitely from this point. That also caused the OGM TTVN to increase at each OGM interval without any changes being ever visible to other nodes. This ever growing TT change event list could be observed by looking at /sys/kernel/slab/batadv_tt_change_cache/objects that sometimes showed unusal high value even after issuing a memcache shrink. The next two patches are more cleanup / potential slight improvements. While patch 4 is mainly cosmetic (having negative tt.local_changes values is not exactly an issue), patch 5 is here to keep the TT changes list as short as possible (reducing network overhead). V2: - This has been tested enough to not be in RFC state anymore - Add one more uninitialize TT change fix for full table TT responses Remi Pommarel (5): batman-adv: Do not send uninitialized TT changes batman-adv: Remove uninitialized data in full table TT response batman-adv: Do not let TT changes list grows indefinitely batman-adv: Remove atomic usage for tt.local_changes batman-adv: Don't keep redundant TT change events net/batman-adv/soft-interface.c | 2 +- net/batman-adv/translation-table.c | 85 +++++++++++++++++++----------- net/batman-adv/types.h | 4 +- 3 files changed, 56 insertions(+), 35 deletions(-) -- 2.40.0

2 7

[PATCH net-next v3 0/6] net: Improve netns handling in RTNL and ip_tunnel
by Xiao Liang 15 Nov '24

15 Nov '24

This patch series includes some netns-related improvements and fixes for RTNL and ip_tunnel, to make link creation more intuitive: - Creating link in another net namespace doesn't conflict with link names in current one. - Refector rtnetlink link creation. Create link in target namespace directly. Pass both source and link netns to drivers via newlink() callback. So that # ip link add netns ns1 link-netns ns2 tun0 type gre ... will create tun0 in ns1, rather than create it in ns2 and move to ns1. And don't conflict with another interface named "tun0" in current netns. Patch 1 from Donald is included just as a dependency. --- v3: - Drop "netns_atomic" flag and module parameter. Add netns parameter to newlink() instead, and convert drivers accordingly. - Move python NetNSEnter helper to net selftest lib. v2: link: https://lore.kernel.org/all/20241107133004.7469-1-shaw.leon@gmail.com/ - Check NLM_F_EXCL to ensure only link creation is affected. - Add self tests for link name/ifindex conflict and notifications in different netns. - Changes in dummy driver and ynl in order to add the test case. v1: link: https://lore.kernel.org/all/20241023023146.372653-1-shaw.leon@gmail.com/ Donald Hunter (1): Revert "tools/net/ynl: improve async notification handling" Xiao Liang (5): net: ip_tunnel: Build flow in underlay net namespace rtnetlink: Lookup device in target netns when creating link rtnetlink: Decouple net namespaces in rtnl_newlink_create() selftests: net: Add python context manager for netns entering selftests: net: Add two test cases for link netns drivers/infiniband/ulp/ipoib/ipoib_netlink.c | 6 ++- drivers/net/amt.c | 6 +-- drivers/net/bareudp.c | 4 +- drivers/net/bonding/bond_netlink.c | 3 +- drivers/net/can/dev/netlink.c | 2 +- drivers/net/can/vxcan.c | 4 +- .../ethernet/qualcomm/rmnet/rmnet_config.c | 5 +- drivers/net/geneve.c | 4 +- drivers/net/gtp.c | 4 +- drivers/net/ipvlan/ipvlan.h | 2 +- drivers/net/ipvlan/ipvlan_main.c | 5 +- drivers/net/ipvlan/ipvtap.c | 4 +- drivers/net/macsec.c | 5 +- drivers/net/macvlan.c | 5 +- drivers/net/macvtap.c | 5 +- drivers/net/netkit.c | 4 +- drivers/net/pfcp.c | 4 +- drivers/net/ppp/ppp_generic.c | 4 +- drivers/net/team/team_core.c | 2 +- drivers/net/veth.c | 4 +- drivers/net/vrf.c | 2 +- drivers/net/vxlan/vxlan_core.c | 4 +- drivers/net/wireguard/device.c | 4 +- drivers/net/wireless/virtual/virt_wifi.c | 5 +- drivers/net/wwan/wwan_core.c | 6 ++- include/net/ip_tunnels.h | 5 +- include/net/rtnetlink.h | 22 ++++++++- net/8021q/vlan_netlink.c | 5 +- net/batman-adv/soft-interface.c | 5 +- net/bridge/br_netlink.c | 2 +- net/caif/chnl_net.c | 2 +- net/core/rtnetlink.c | 25 ++++++---- net/hsr/hsr_netlink.c | 8 +-- net/ieee802154/6lowpan/core.c | 5 +- net/ipv4/ip_gre.c | 13 +++-- net/ipv4/ip_tunnel.c | 16 +++--- net/ipv4/ip_vti.c | 5 +- net/ipv4/ipip.c | 5 +- net/ipv6/ip6_gre.c | 17 ++++--- net/ipv6/ip6_tunnel.c | 11 ++--- net/ipv6/ip6_vti.c | 11 ++--- net/ipv6/sit.c | 11 ++--- net/xfrm/xfrm_interface_core.c | 13 +++-- tools/net/ynl/cli.py | 10 ++-- tools/net/ynl/lib/ynl.py | 49 ++++++++----------- tools/testing/selftests/net/Makefile | 1 + .../testing/selftests/net/lib/py/__init__.py | 2 +- tools/testing/selftests/net/lib/py/netns.py | 18 +++++++ tools/testing/selftests/net/netns-name.sh | 10 ++++ tools/testing/selftests/net/netns_atomic.py | 38 ++++++++++++++ 50 files changed, 255 insertions(+), 157 deletions(-) create mode 100755 tools/testing/selftests/net/netns_atomic.py -- 2.47.0

2 7

[PATCH-net] batman-adv: Fix "Arguments in wrong order" issue
by Dheeraj Reddy Jonnalagadda 15 Nov '24

15 Nov '24

This commit fixes an "Arguments in wrong order" issue detected by Coverity (CID 1376875). Signed-off-by: Dheeraj Reddy Jonnalagadda <dheeraj.linuxdev(a)gmail.com> --- net/batman-adv/distributed-arp-table.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/net/batman-adv/distributed-arp-table.c b/net/batman-adv/distributed-arp-table.c index 801eff8a40e5..781a5118d441 100644 --- a/net/batman-adv/distributed-arp-table.c +++ b/net/batman-adv/distributed-arp-table.c @@ -1195,7 +1195,7 @@ bool batadv_dat_snoop_outgoing_arp_request(struct batadv_priv *bat_priv, goto out; } - skb_new = batadv_dat_arp_create_reply(bat_priv, ip_dst, ip_src, + skb_new = batadv_dat_arp_create_reply(bat_priv, ip_src, ip_dst, dat_entry->mac_addr, hw_src, vid); if (!skb_new) -- 2.34.1

2 1

[RFC PATCH 0/4] batman-adv: TT change events fixes and improvements
by Remi Pommarel 01 Nov '24

01 Nov '24

The first two patches are actual fixes. The first one tries to avoid sending uninitialized data that could be interpreted as invalid TT change events in both TT request and OGM. Following invalid entries could be seen when that happen with batctl o: * 00:00:00:00:00:00 -1 [....] ( 0) 88:12:4e:ad:7e:ba (179) (0x45845380) * 00:00:00:00:78:79 4092 [.W..] ( 0) 88:12:4e:ad:7e:3c (145) (0x8ebadb8b) The second one fixes an issue that happened when a TT change event list is too big for the MTU, the list was never actually sent nor free and continued to grow indefinitely from this point. That also caused the OGM TTVN to increase at each OGM interval without any changes being ever visible to other nodes. This ever growing TT change event list could be observed by looking at /sys/kernel/slab/batadv_tt_change_cache/objects that sometimes showed unusal high value even after issuing a memcache shrink. The next two patches are potential slight improvements. While patch 3 is mainly cosmetic (having negative tt.local_changes value is not exactly an issue), patch 4 is here to keep the TT changes list as short as possible. Remi Pommarel (4): batman-adv: Do not send uninitialized TT changes batman-adv: Do not let TT changes list grows indefinitely batman-adv: Remove atomic usage for tt.local_changes batman-adv: Don't keep redundant TT change events net/batman-adv/soft-interface.c | 2 +- net/batman-adv/translation-table.c | 48 +++++++++++++++++++----------- net/batman-adv/types.h | 4 +-- 3 files changed, 34 insertions(+), 20 deletions(-) -- 2.40.0

1 4

[syzbot] [batman?] BUG: soft lockup in batadv_iv_send_outstanding_bat_ogm_packet
by syzbot 01 Nov '24

01 Nov '24

Hello, syzbot found the following issue on: HEAD commit: 795c58e4c7fc Merge tag 'trace-v6.10-rc6' of git://git.kern.. git tree: upstream console output: https://syzkaller.appspot.com/x/log.txt?x=11bf7976980000 kernel config: https://syzkaller.appspot.com/x/.config?x=c950e46ec3ea637a dashboard link: https://syzkaller.appspot.com/bug?extid=572f6e36bc6ee6f16762 compiler: gcc (Debian 12.2.0-14) 12.2.0, GNU ld (GNU Binutils for Debian) 2.40 Unfortunately, I don't have any reproducer for this issue yet. Downloadable assets: disk image: https://storage.googleapis.com/syzbot-assets/393fdf1d08dd/disk-795c58e4.raw… vmlinux: https://storage.googleapis.com/syzbot-assets/724001a1b4be/vmlinux-795c58e4.… kernel image: https://storage.googleapis.com/syzbot-assets/1ede352392b0/bzImage-795c58e4.… IMPORTANT: if you fix the issue, please add the following tag to the commit: Reported-by: syzbot+572f6e36bc6ee6f16762(a)syzkaller.appspotmail.com watchdog: BUG: soft lockup - CPU#0 stuck for 143s! [kworker/u8:8:2833] Modules linked in: irq event stamp: 1708674 hardirqs last enabled at (1708673): [<ffffffff81e178c0>] ___slab_alloc+0x870/0x1870 mm/slub.c:3577 hardirqs last disabled at (1708674): [<ffffffff8ae84a1e>] sysvec_apic_timer_interrupt+0xe/0xb0 arch/x86/kernel/apic/apic.c:1043 softirqs last enabled at (1708660): [<ffffffff8aa82f2d>] spin_unlock_bh include/linux/spinlock.h:396 [inline] softirqs last enabled at (1708660): [<ffffffff8aa82f2d>] batadv_iv_ogm_queue_add net/batman-adv/bat_iv_ogm.c:661 [inline] softirqs last enabled at (1708660): [<ffffffff8aa82f2d>] batadv_iv_ogm_schedule_buff+0x97d/0x1500 net/batman-adv/bat_iv_ogm.c:833 softirqs last disabled at (1708658): [<ffffffff8aa82ee3>] spin_lock_bh include/linux/spinlock.h:356 [inline] softirqs last disabled at (1708658): [<ffffffff8aa82ee3>] batadv_iv_ogm_queue_add net/batman-adv/bat_iv_ogm.c:639 [inline] softirqs last disabled at (1708658): [<ffffffff8aa82ee3>] batadv_iv_ogm_schedule_buff+0x933/0x1500 net/batman-adv/bat_iv_ogm.c:833 CPU: 0 PID: 2833 Comm: kworker/u8:8 Not tainted 6.10.0-rc6-syzkaller-00069-g795c58e4c7fc #0 Hardware name: Google Google Compute Engine/Google Compute Engine, BIOS Google 06/07/2024 Workqueue: bat_events batadv_iv_send_outstanding_bat_ogm_packet RIP: 0010:arch_atomic_read arch/x86/include/asm/atomic.h:23 [inline] RIP: 0010:raw_atomic_read include/linux/atomic/atomic-arch-fallback.h:457 [inline] RIP: 0010:atomic_read include/linux/atomic/atomic-instrumented.h:33 [inline] RIP: 0010:kfence_alloc include/linux/kfence.h:127 [inline] RIP: 0010:slab_alloc_node mm/slub.c:3986 [inline] RIP: 0010:kmem_cache_alloc_noprof+0x1bd/0x2f0 mm/slub.c:4009 Code: 5d 41 5e 41 5f 5d e9 2d aa 2e 09 31 c9 e9 71 ff ff ff 41 8b 44 24 08 a8 82 0f 84 5b ff ff ff a8 08 41 0f 45 de e9 50 ff ff ff <8b> 05 fd b8 f4 0b 85 c0 0f 85 c0 fe ff ff 4c 89 e7 44 89 f6 44 89 RSP: 0018:ffffc90009717840 EFLAGS: 00000246 RAX: 0000000000000000 RBX: 0000000000002120 RCX: 0000000000000000 RDX: 1ffffffff1bace70 RSI: 0000000000000028 RDI: ffff88802ba3b3c4 RBP: ffffc90009717888 R08: 00000000ffffffff R09: ffff8880250de500 R10: 0000000000000000 R11: 0000000000000004 R12: ffff88801544f8c0 R13: 0000000000002120 R14: 0000000000000028 R15: 00000000250de500 FS: 0000000000000000(0000) GS:ffff8880b9200000(0000) knlGS:0000000000000000 CS: 0010 DS: 0000 ES: 0000 CR0: 0000000080050033 CR2: 00007f64bd0ce2d8 CR3: 000000006623e000 CR4: 0000000000350ef0 Call Trace: <IRQ> </IRQ> <TASK> fill_pool+0x26b/0x5d0 lib/debugobjects.c:168 debug_objects_fill_pool lib/debugobjects.c:615 [inline] __debug_object_init+0xf7/0x480 lib/debugobjects.c:627 __init_work+0x4c/0x60 kernel/workqueue.c:678 batadv_iv_ogm_aggregate_new+0x2dd/0x4a0 net/batman-adv/bat_iv_ogm.c:584 batadv_iv_ogm_queue_add net/batman-adv/bat_iv_ogm.c:670 [inline] batadv_iv_ogm_schedule_buff+0x99b/0x1500 net/batman-adv/bat_iv_ogm.c:833 batadv_iv_ogm_schedule net/batman-adv/bat_iv_ogm.c:868 [inline] batadv_iv_ogm_schedule net/batman-adv/bat_iv_ogm.c:861 [inline] batadv_iv_send_outstanding_bat_ogm_packet+0x31e/0x8d0 net/batman-adv/bat_iv_ogm.c:1712 process_one_work+0x9c8/0x1b40 kernel/workqueue.c:3248 process_scheduled_works kernel/workqueue.c:3329 [inline] worker_thread+0x6c8/0xf30 kernel/workqueue.c:3409 kthread+0x2c4/0x3a0 kernel/kthread.c:389 ret_from_fork+0x48/0x80 arch/x86/kernel/process.c:147 ret_from_fork_asm+0x1a/0x30 arch/x86/entry/entry_64.S:244 </TASK> Sending NMI from CPU 0 to CPUs 1: NMI backtrace for cpu 1 skipped: idling at native_safe_halt arch/x86/include/asm/irqflags.h:48 [inline] NMI backtrace for cpu 1 skipped: idling at arch_safe_halt arch/x86/include/asm/irqflags.h:86 [inline] NMI backtrace for cpu 1 skipped: idling at acpi_safe_halt+0x1a/0x20 drivers/acpi/processor_idle.c:112 --- This report is generated by a bot. It may contain errors. See https://goo.gl/tpsmEJ for more information about syzbot. syzbot engineers can be reached at syzkaller(a)googlegroups.com. syzbot will keep track of this issue. See: https://goo.gl/tpsmEJ#status for how to communicate with syzbot. If the report is already addressed, let syzbot know by replying with: #syz fix: exact-commit-title If you want to overwrite report's subsystems, reply with: #syz set subsystems: new-subsystem (See the list of subsystem names on the web dashboard) If the report is a duplicate of another one, reply with: #syz dup: exact-subject-of-another-report If you want to undo deduplication, reply with: #syz undup

1 2

2025

2024

2023

2022

2021

2020

2019

2018

2017

2016

2015

2014

2013

2012

2011

2010

2009

2008

2007

B.A.T.M.A.N November 2024