B.A.T.M.A.N March 2020

b.a.t.m.a.n@lists.open-mesh.org

21 participants
21 discussions

[PATCH AUTOSEL 5.5 05/84] batman-adv: Don't schedule OGM for disabled interface
by Sasha Levin 18 Mar '20

18 Mar '20

From: Sven Eckelmann <sven(a)narfation.org> [ Upstream commit 8e8ce08198de193e3d21d42e96945216e3d9ac7f ] A transmission scheduling for an interface which is currently dropped by batadv_iv_ogm_iface_disable could still be in progress. The B.A.T.M.A.N. V is simply cancelling the workqueue item in an synchronous way but this is not possible with B.A.T.M.A.N. IV because the OGM submissions are intertwined. Instead it has to stop submitting the OGM when it detect that the buffer pointer is set to NULL. Reported-by: syzbot+a98f2016f40b9cd3818a(a)syzkaller.appspotmail.com Reported-by: syzbot+ac36b6a33c28a491e929(a)syzkaller.appspotmail.com Fixes: c6c8fea29769 ("net: Add batman-adv meshing protocol") Signed-off-by: Sven Eckelmann <sven(a)narfation.org> Cc: Hillf Danton <hdanton(a)sina.com> Signed-off-by: Simon Wunderlich <sw(a)simonwunderlich.de> Signed-off-by: Sasha Levin <sashal(a)kernel.org> --- net/batman-adv/bat_iv_ogm.c | 4 ++++ 1 file changed, 4 insertions(+) diff --git a/net/batman-adv/bat_iv_ogm.c b/net/batman-adv/bat_iv_ogm.c index 5b0b20e6da956..d88a4de022372 100644 --- a/net/batman-adv/bat_iv_ogm.c +++ b/net/batman-adv/bat_iv_ogm.c @@ -789,6 +789,10 @@ static void batadv_iv_ogm_schedule_buff(struct batadv_hard_iface *hard_iface) lockdep_assert_held(&hard_iface->bat_iv.ogm_buff_mutex); + /* interface already disabled by batadv_iv_ogm_iface_disable */ + if (!*ogm_buff) + return; + /* the interface gets activated here to avoid race conditions between * the moment of activating the interface in * hardif_activate_interface() where the originator mac is set and -- 2.20.1

1 0

batman-adv gateway issue
by Maksim Iushchenko 16 Mar '20

16 Mar '20

Hello, I use batman-adv to create a mesh network and recently I faced an issue related to batman-adv gateways. I have a mesh network based on batman-adv. Each node in my network has certain coordinates. Each node uses these coordinates to generate it's own IPv6 address and sets it to bat0 interface. Therefore, network's node has a static IPv6 address contains encoded coordinates. The purpose is to provide an Internet access to all mesh network nodes via gateway node. I already configured gateway node as gateway server and all rest nodes as gateway client. But in my case each gateway client wants to know default route to the gateway node and, in particular, it's IP-address. Please, suggest me how can I distribute default route to all nodes in the mesh network in the case where nodes have static IPv6-addresses (and also it is necessary to maintain the actual default gateway on the nodes). Or, please, suggest me how is better to provide an Internet access to all nodes and distribute their coordinates in the network. Thanks in advance

2 1

Re: KASAN: slab-out-of-bounds Read in bitmap_ipmac_gc
by syzbot 16 Mar '20

16 Mar '20

syzbot suspects this bug was fixed by commit: commit 32c72165dbd0e246e69d16a3ad348a4851afd415 Author: Kadlecsik József <kadlec(a)blackhole.kfki.hu> Date: Sun Jan 19 21:06:49 2020 +0000 netfilter: ipset: use bitmap infrastructure completely bisection log: https://syzkaller.appspot.com/x/bisect.txt?x=1074c2a9e00000 start commit: d96d875e Merge tag 'fixes_for_v5.5-rc8' of git://git.kerne.. git tree: upstream kernel config: https://syzkaller.appspot.com/x/.config?x=cf8e288883e40aba dashboard link: https://syzkaller.appspot.com/bug?extid=c1a1fb435465986efe35 syz repro: https://syzkaller.appspot.com/x/repro.syz?x=14e36185e00000 C reproducer: https://syzkaller.appspot.com/x/repro.c?x=104a7a11e00000 If the result looks correct, please mark the bug fixed by replying with: #syz fix: netfilter: ipset: use bitmap infrastructure completely For information about bisection process see: https://goo.gl/tpsmEJ#bisection

1 0

Re: KASAN: slab-out-of-bounds Read in bitmap_ip_ext_cleanup
by syzbot 16 Mar '20

16 Mar '20

syzbot suspects this bug was fixed by commit: commit 32c72165dbd0e246e69d16a3ad348a4851afd415 Author: Kadlecsik József <kadlec(a)blackhole.kfki.hu> Date: Sun Jan 19 21:06:49 2020 +0000 netfilter: ipset: use bitmap infrastructure completely bisection log: https://syzkaller.appspot.com/x/bisect.txt?x=16b8e545e00000 start commit: d96d875e Merge tag 'fixes_for_v5.5-rc8' of git://git.kerne.. git tree: upstream kernel config: https://syzkaller.appspot.com/x/.config?x=cf8e288883e40aba dashboard link: https://syzkaller.appspot.com/bug?extid=6491ea8f6dddbf04930e syz repro: https://syzkaller.appspot.com/x/repro.syz?x=126748d6e00000 C reproducer: https://syzkaller.appspot.com/x/repro.c?x=1385f959e00000 If the result looks correct, please mark the bug fixed by replying with: #syz fix: netfilter: ipset: use bitmap infrastructure completely For information about bisection process see: https://goo.gl/tpsmEJ#bisection

1 0

Re: KASAN: slab-out-of-bounds Read in bitmap_port_ext_cleanup
by syzbot 15 Mar '20

15 Mar '20

syzbot suspects this bug was fixed by commit: commit 32c72165dbd0e246e69d16a3ad348a4851afd415 Author: Kadlecsik József <kadlec(a)blackhole.kfki.hu> Date: Sun Jan 19 21:06:49 2020 +0000 netfilter: ipset: use bitmap infrastructure completely bisection log: https://syzkaller.appspot.com/x/bisect.txt?x=122e7c1de00000 start commit: d5d359b0 Merge branch 'for-linus' of git://git.kernel.org/.. git tree: upstream kernel config: https://syzkaller.appspot.com/x/.config?x=cf8e288883e40aba dashboard link: https://syzkaller.appspot.com/bug?extid=7b6206fb525c1f5ec3f8 syz repro: https://syzkaller.appspot.com/x/repro.syz?x=15909f21e00000 C reproducer: https://syzkaller.appspot.com/x/repro.c?x=141a1611e00000 If the result looks correct, please mark the bug fixed by replying with: #syz fix: netfilter: ipset: use bitmap infrastructure completely For information about bisection process see: https://goo.gl/tpsmEJ#bisection

1 0

Re: KASAN: slab-out-of-bounds Read in bitmap_ipmac_destroy
by syzbot 14 Mar '20

14 Mar '20

syzbot suspects this bug was fixed by commit: commit 32c72165dbd0e246e69d16a3ad348a4851afd415 Author: Kadlecsik József <kadlec(a)blackhole.kfki.hu> Date: Sun Jan 19 21:06:49 2020 +0000 netfilter: ipset: use bitmap infrastructure completely bisection log: https://syzkaller.appspot.com/x/bisect.txt?x=10aef753e00000 start commit: 4703d911 Merge tag 'xarray-5.5' of git://git.infradead.org.. git tree: upstream kernel config: https://syzkaller.appspot.com/x/.config?x=83c00afca9cf5153 dashboard link: https://syzkaller.appspot.com/bug?extid=a85062dec5d65617cc1c syz repro: https://syzkaller.appspot.com/x/repro.syz?x=1301ed85e00000 C reproducer: https://syzkaller.appspot.com/x/repro.c?x=14b7b79ee00000 If the result looks correct, please mark the bug fixed by replying with: #syz fix: netfilter: ipset: use bitmap infrastructure completely For information about bisection process see: https://goo.gl/tpsmEJ#bisection

1 0

Re: general protection fault in j1939_netdev_start
by syzbot 11 Mar '20

11 Mar '20

syzbot has bisected this bug to: commit 8330f73fe9742f201f467639f8356cf58756fb9f Author: Jiri Pirko <jiri(a)mellanox.com> Date: Wed Sep 4 07:40:47 2019 +0000 rocker: add missing init_net check in FIB notifier bisection log: https://syzkaller.appspot.com/x/bisect.txt?x=165cdcb1e00000 start commit: 63623fd4 Merge tag 'for-linus' of git://git.kernel.org/pub.. git tree: upstream final crash: https://syzkaller.appspot.com/x/report.txt?x=155cdcb1e00000 console output: https://syzkaller.appspot.com/x/log.txt?x=115cdcb1e00000 kernel config: https://syzkaller.appspot.com/x/.config?x=9833e26bab355358 dashboard link: https://syzkaller.appspot.com/bug?extid=f03d384f3455d28833eb syz repro: https://syzkaller.appspot.com/x/repro.syz?x=162b8331e00000 C reproducer: https://syzkaller.appspot.com/x/repro.c?x=10f10a2de00000 Reported-by: syzbot+f03d384f3455d28833eb(a)syzkaller.appspotmail.com Fixes: 8330f73fe974 ("rocker: add missing init_net check in FIB notifier") For information about bisection process see: https://goo.gl/tpsmEJ#bisection

1 0

Re: WARNING in idr_destroy
by syzbot 11 Mar '20

11 Mar '20

syzbot has bisected this bug to: commit 5b3709793d151e6e12eb6a38a5da3f7fc2923d3a Author: Thomas Zimmermann <tzimmermann(a)suse.de> Date: Wed May 8 08:26:19 2019 +0000 drm/ast: Convert AST driver to |struct drm_gem_vram_object| bisection log: https://syzkaller.appspot.com/x/bisect.txt?x=15a66fb5e00000 start commit: 63623fd4 Merge tag 'for-linus' of git://git.kernel.org/pub.. git tree: upstream final crash: https://syzkaller.appspot.com/x/report.txt?x=17a66fb5e00000 console output: https://syzkaller.appspot.com/x/log.txt?x=13a66fb5e00000 kernel config: https://syzkaller.appspot.com/x/.config?x=5d2e033af114153f dashboard link: https://syzkaller.appspot.com/bug?extid=05835159fe322770fe3d syz repro: https://syzkaller.appspot.com/x/repro.syz?x=14e978e3e00000 C reproducer: https://syzkaller.appspot.com/x/repro.c?x=10b1a819e00000 Reported-by: syzbot+05835159fe322770fe3d(a)syzkaller.appspotmail.com Fixes: 5b3709793d15 ("drm/ast: Convert AST driver to |struct drm_gem_vram_object|") For information about bisection process see: https://goo.gl/tpsmEJ#bisection

1 0

[PATCH 0/1] pull request for net: batman-adv 2020-03-06
by Simon Wunderlich 10 Mar '20

10 Mar '20

Hi David, here is a bugfix which we would like to have integrated into net. Please pull or let me know of any problem! Thank you, Simon The following changes since commit bb6d3fb354c5ee8d6bde2d576eb7220ea09862b9: Linux 5.6-rc1 (2020-02-09 16:08:48 -0800) are available in the Git repository at: git://git.open-mesh.org/linux-merge.git tags/batadv-net-for-davem-20200306 for you to fetch changes up to 8e8ce08198de193e3d21d42e96945216e3d9ac7f: batman-adv: Don't schedule OGM for disabled interface (2020-02-18 09:07:55 +0100) ---------------------------------------------------------------- Here is a batman-adv bugfix: - Don't schedule OGM for disabled interface, by Sven Eckelmann ---------------------------------------------------------------- Sven Eckelmann (1): batman-adv: Don't schedule OGM for disabled interface net/batman-adv/bat_iv_ogm.c | 4 ++++ 1 file changed, 4 insertions(+)

2 2

[PATCH 0/3] pull request for net-next: batman-adv 2020-03-06
by Simon Wunderlich 06 Mar '20

06 Mar '20

Hi David, here is a small cleanup pull request of batman-adv to go into net-next. Please pull or let me know of any problem! Thank you, Simon The following changes since commit bb6d3fb354c5ee8d6bde2d576eb7220ea09862b9: Linux 5.6-rc1 (2020-02-09 16:08:48 -0800) are available in the Git repository at: git://git.open-mesh.org/linux-merge.git tags/batadv-next-for-davem-20200306 for you to fetch changes up to 5f27eb055d5c5814785fb9cf0ae4a4c150a8f334: batman-adv: Replace zero-length array with flexible-array member (2020-02-17 22:43:42 +0100) ---------------------------------------------------------------- This cleanup patchset includes the following patches: - bump version strings, by Simon Wunderlich - Avoid RCU list-traversal in spinlock, by Sven Eckelmann - Replace zero-length array with flexible-array member, by Gustavo A. R. Silva ---------------------------------------------------------------- Gustavo A. R. Silva (1): batman-adv: Replace zero-length array with flexible-array member Simon Wunderlich (1): batman-adv: Start new development cycle Sven Eckelmann (1): batman-adv: Avoid RCU list-traversal in spinlock net/batman-adv/distributed-arp-table.c | 2 +- net/batman-adv/main.h | 2 +- net/batman-adv/translation-table.c | 8 ++++---- 3 files changed, 6 insertions(+), 6 deletions(-)

1 3

2024

2023

2022

2021

2020

2019

2018

2017

2016

2015

2014

2013

2012

2011

2010

2009

2008

2007

B.A.T.M.A.N March 2020