B.A.T.M.A.N January 2020

b.a.t.m.a.n@lists.open-mesh.org

23 participants
27 discussions

[PATCH 0/7] pull request for net-next: batman-adv 2020-01-14
by Simon Wunderlich 15 Jan '20

15 Jan '20

Hi David, here is a small feature/cleanup pull request of batman-adv to go into net-next. Please pull or let me know of any problem! Thank you, Simon The following changes since commit 5759af0682b3395e64cf615e062d6ecad01428dc: batman-adv: Drop lockdep.h include for soft-interface.c (2019-11-03 08:30:58 +0100) are available in the Git repository at: git://git.open-mesh.org/linux-merge.git tags/batadv-next-for-davem-20200114 for you to fetch changes up to b2e55ca89245fccd459a2d56850822a69a6f91da: batman-adv: Disable CONFIG_BATMAN_ADV_SYSFS by default (2020-01-01 00:57:07 +0100) ---------------------------------------------------------------- This feature/cleanup patchset includes the following patches: - bump version strings, by Simon Wunderlich - fix typo and kerneldocs, by Sven Eckelmann - use WiFi txbitrate for B.A.T.M.A.N. V as fallback, by René Treffer - silence some endian sparse warnings by adding annotations, by Sven Eckelmann - Update copyright years to 2020, by Sven Eckelmann - Disable deprecated sysfs configuration by default, by Sven Eckelmann ---------------------------------------------------------------- René Treffer (1): batman-adv: ELP - use wifi tx bitrate as fallback throughput Simon Wunderlich (1): batman-adv: Start new development cycle Sven Eckelmann (5): batman-adv: Strip dots from variable macro kerneldoc batman-adv: Fix typo metAdata batman-adv: Annotate bitwise integer pointer casts batman-adv: Update copyright years for 2020 batman-adv: Disable CONFIG_BATMAN_ADV_SYSFS by default include/uapi/linux/batadv_packet.h | 2 +- include/uapi/linux/batman_adv.h | 2 +- net/batman-adv/Kconfig | 3 +-- net/batman-adv/Makefile | 2 +- net/batman-adv/bat_algo.c | 2 +- net/batman-adv/bat_algo.h | 2 +- net/batman-adv/bat_iv_ogm.c | 2 +- net/batman-adv/bat_iv_ogm.h | 2 +- net/batman-adv/bat_v.c | 2 +- net/batman-adv/bat_v.h | 2 +- net/batman-adv/bat_v_elp.c | 15 +++++++++++---- net/batman-adv/bat_v_elp.h | 2 +- net/batman-adv/bat_v_ogm.c | 2 +- net/batman-adv/bat_v_ogm.h | 2 +- net/batman-adv/bitarray.c | 2 +- net/batman-adv/bitarray.h | 2 +- net/batman-adv/bridge_loop_avoidance.c | 4 ++-- net/batman-adv/bridge_loop_avoidance.h | 2 +- net/batman-adv/debugfs.c | 2 +- net/batman-adv/debugfs.h | 2 +- net/batman-adv/distributed-arp-table.c | 10 ++++++---- net/batman-adv/distributed-arp-table.h | 2 +- net/batman-adv/fragmentation.c | 2 +- net/batman-adv/fragmentation.h | 2 +- net/batman-adv/gateway_client.c | 2 +- net/batman-adv/gateway_client.h | 2 +- net/batman-adv/gateway_common.c | 2 +- net/batman-adv/gateway_common.h | 2 +- net/batman-adv/hard-interface.c | 2 +- net/batman-adv/hard-interface.h | 2 +- net/batman-adv/hash.c | 2 +- net/batman-adv/hash.h | 2 +- net/batman-adv/icmp_socket.c | 2 +- net/batman-adv/icmp_socket.h | 2 +- net/batman-adv/log.c | 2 +- net/batman-adv/log.h | 12 ++++++------ net/batman-adv/main.c | 2 +- net/batman-adv/main.h | 4 ++-- net/batman-adv/multicast.c | 2 +- net/batman-adv/multicast.h | 2 +- net/batman-adv/netlink.c | 2 +- net/batman-adv/netlink.h | 2 +- net/batman-adv/network-coding.c | 2 +- net/batman-adv/network-coding.h | 2 +- net/batman-adv/originator.c | 2 +- net/batman-adv/originator.h | 2 +- net/batman-adv/routing.c | 2 +- net/batman-adv/routing.h | 2 +- net/batman-adv/send.c | 2 +- net/batman-adv/send.h | 2 +- net/batman-adv/soft-interface.c | 2 +- net/batman-adv/soft-interface.h | 2 +- net/batman-adv/sysfs.c | 2 +- net/batman-adv/sysfs.h | 2 +- net/batman-adv/tp_meter.c | 2 +- net/batman-adv/tp_meter.h | 2 +- net/batman-adv/trace.c | 2 +- net/batman-adv/trace.h | 2 +- net/batman-adv/translation-table.c | 2 +- net/batman-adv/translation-table.h | 2 +- net/batman-adv/tvlv.c | 2 +- net/batman-adv/tvlv.h | 2 +- net/batman-adv/types.h | 6 +++--- 63 files changed, 87 insertions(+), 79 deletions(-)

2 8

[PATCH 0/1] pull request for net: batman-adv 2020-01-14
by Simon Wunderlich 15 Jan '20

15 Jan '20

Hi David, here is a bugfix which we would like to have integrated into net. Please pull or let me know of any problem! Thank you, Simon The following changes since commit 40e220b4218bb3d278e5e8cc04ccdfd1c7ff8307: batman-adv: Avoid free/alloc race when handling OGM buffer (2019-10-13 21:00:07 +0200) are available in the Git repository at: git://git.open-mesh.org/linux-merge.git tags/batadv-net-for-davem-20200114 for you to fetch changes up to 4cc4a1708903f404d2ca0dfde30e71e052c6cbc9: batman-adv: Fix DAT candidate selection on little endian systems (2019-11-28 12:48:59 +0100) ---------------------------------------------------------------- Here is a batman-adv bugfix: - Fix DAT candidate selection on little endian systems, by Sven Eckelmann ---------------------------------------------------------------- Sven Eckelmann (1): batman-adv: Fix DAT candidate selection on little endian systems net/batman-adv/distributed-arp-table.c | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-)

2 2

[PATCH] alfred-gpsd: Fix build against gpsd ABI 9.0
by Sven Eckelmann 15 Jan '20

15 Jan '20

libgpsd 3.20 removed the timestamp_t type and the function unix_to_iso8601(). The same release introduced the timespec_t based function timespec_to_iso8601(). Signed-off-by: Sven Eckelmann <sven(a)narfation.org> --- gpsd/alfred-gpsd.c | 20 +++++++++++++++++--- 1 file changed, 17 insertions(+), 3 deletions(-) diff --git a/gpsd/alfred-gpsd.c b/gpsd/alfred-gpsd.c index 884bdbf..47d6a64 100644 --- a/gpsd/alfred-gpsd.c +++ b/gpsd/alfred-gpsd.c @@ -8,6 +8,8 @@ #include "alfred-gpsd.h" +#include <time.h> + static struct globals gpsd_globals; static int alfred_open_sock(struct globals *globals) @@ -64,19 +66,31 @@ static int gpsd_publish_data(struct globals *globals) return 0; } +static void gpsd_now_to_iso8601(char *tbuf, size_t len) +{ +#if GPSD_API_MAJOR_VERSION >= 9 + timespec_t now; + + clock_gettime(CLOCK_REALTIME, &now); + timespec_to_iso8601(now, tbuf, len); +#else + timestamp_t now = timestamp(); + unix_to_iso8601(now, tbuf, len); +#endif +} + static void gpsd_get_location(struct globals *globals) { if (globals->source == SOURCE_CMDLINE) { char tbuf[JSON_DATE_MAX+1]; - timestamp_t now = timestamp(); + gpsd_now_to_iso8601(tbuf, sizeof(tbuf)); sprintf(globals->gpsd_data->tpv, "{\"class\":\"TPV\",\"device\":\"command line\"," "\"time\":\"%s\"," "\"lat\":%f,\"lon\":%f,\"alt\":%f," "\"mode\":3}", - unix_to_iso8601(now, tbuf, sizeof(tbuf)), - globals->lat, globals->lon, globals->alt); + tbuf, globals->lat, globals->lon, globals->alt); globals->gpsd_data->tpv_len = htonl(strlen(globals->gpsd_data->tpv) + 1); } -- 2.20.1

1 0

WARNING: bad unlock balance in __dev_queue_xmit
by syzbot 11 Jan '20

11 Jan '20

Hello, syzbot found the following crash on: HEAD commit: ae608821 Merge tag 'trace-v5.5-rc5' of git://git.kernel.or.. git tree: upstream console output: https://syzkaller.appspot.com/x/log.txt?x=12abc515e00000 kernel config: https://syzkaller.appspot.com/x/.config?x=18698c0c240ba616 dashboard link: https://syzkaller.appspot.com/bug?extid=ad4ea1dd5d26131a58a6 compiler: gcc (GCC) 9.0.0 20181231 (experimental) syz repro: https://syzkaller.appspot.com/x/repro.syz?x=141051b9e00000 C reproducer: https://syzkaller.appspot.com/x/repro.c?x=125e5876e00000 The bug was bisected to: commit ab92d68fc22f9afab480153bd82a20f6e2533769 Author: Taehee Yoo <ap420073(a)gmail.com> Date: Mon Oct 21 18:47:51 2019 +0000 net: core: add generic lockdep keys bisection log: https://syzkaller.appspot.com/x/bisect.txt?x=107f969ee00000 final crash: https://syzkaller.appspot.com/x/report.txt?x=127f969ee00000 console output: https://syzkaller.appspot.com/x/log.txt?x=147f969ee00000 IMPORTANT: if you fix the bug, please add the following tag to the commit: Reported-by: syzbot+ad4ea1dd5d26131a58a6(a)syzkaller.appspotmail.com Fixes: ab92d68fc22f ("net: core: add generic lockdep keys") ===================================== WARNING: bad unlock balance detected! 5.5.0-rc5-syzkaller #0 Not tainted ------------------------------------- swapper/0/0 is trying to release lock (&dev->qdisc_xmit_lock_key) at: [<ffffffff8625890d>] spin_unlock include/linux/spinlock.h:378 [inline] [<ffffffff8625890d>] __netif_tx_unlock include/linux/netdevice.h:3966 [inline] [<ffffffff8625890d>] __dev_queue_xmit+0x2bbd/0x35c0 net/core/dev.c:4016 but there are no more locks to release! other info that might help us debug this: 4 locks held by swapper/0/0: #0: ffffc90000007d50 ((&ndev->rs_timer)){+.-.}, at: lockdep_copy_map include/linux/lockdep.h:172 [inline] #0: ffffc90000007d50 ((&ndev->rs_timer)){+.-.}, at: call_timer_fn+0xe0/0x780 kernel/time/timer.c:1394 #1: ffffffff899a5340 (rcu_read_lock){....}, at: ip6_nd_hdr net/ipv6/ndisc.c:463 [inline] #1: ffffffff899a5340 (rcu_read_lock){....}, at: ndisc_send_skb+0x7fe/0x1490 net/ipv6/ndisc.c:499 #2: ffffffff899a5300 (rcu_read_lock_bh){....}, at: lwtunnel_xmit_redirect include/net/lwtunnel.h:92 [inline] #2: ffffffff899a5300 (rcu_read_lock_bh){....}, at: ip6_finish_output2+0x214/0x25c0 net/ipv6/ip6_output.c:102 #3: ffffffff899a5300 (rcu_read_lock_bh){....}, at: __dev_queue_xmit+0x20a/0x35c0 net/core/dev.c:3948 stack backtrace: CPU: 0 PID: 0 Comm: swapper/0 Not tainted 5.5.0-rc5-syzkaller #0 Hardware name: Google Google Compute Engine/Google Compute Engine, BIOS Google 01/01/2011 Call Trace: <IRQ> __dump_stack lib/dump_stack.c:77 [inline] dump_stack+0x197/0x210 lib/dump_stack.c:118 print_unlock_imbalance_bug kernel/locking/lockdep.c:4008 [inline] print_unlock_imbalance_bug.cold+0x114/0x123 kernel/locking/lockdep.c:3984 __lock_release kernel/locking/lockdep.c:4242 [inline] lock_release+0x5f2/0x960 kernel/locking/lockdep.c:4503 __raw_spin_unlock include/linux/spinlock_api_smp.h:150 [inline] _raw_spin_unlock+0x16/0x40 kernel/locking/spinlock.c:183 spin_unlock include/linux/spinlock.h:378 [inline] __netif_tx_unlock include/linux/netdevice.h:3966 [inline] __dev_queue_xmit+0x2bbd/0x35c0 net/core/dev.c:4016 dev_queue_xmit+0x18/0x20 net/core/dev.c:4046 neigh_hh_output include/net/neighbour.h:499 [inline] neigh_output include/net/neighbour.h:508 [inline] ip6_finish_output2+0xfbe/0x25c0 net/ipv6/ip6_output.c:116 __ip6_finish_output+0x444/0xaa0 net/ipv6/ip6_output.c:142 ip6_finish_output+0x38/0x1f0 net/ipv6/ip6_output.c:152 NF_HOOK_COND include/linux/netfilter.h:296 [inline] ip6_output+0x25e/0x880 net/ipv6/ip6_output.c:175 dst_output include/net/dst.h:436 [inline] NF_HOOK include/linux/netfilter.h:307 [inline] ndisc_send_skb+0xf1f/0x1490 net/ipv6/ndisc.c:505 ndisc_send_rs+0x134/0x720 net/ipv6/ndisc.c:699 addrconf_rs_timer+0x30f/0x6e0 net/ipv6/addrconf.c:3879 call_timer_fn+0x1ac/0x780 kernel/time/timer.c:1404 expire_timers kernel/time/timer.c:1449 [inline] __run_timers kernel/time/timer.c:1773 [inline] __run_timers kernel/time/timer.c:1740 [inline] run_timer_softirq+0x6c3/0x1790 kernel/time/timer.c:1786 __do_softirq+0x262/0x98c kernel/softirq.c:292 invoke_softirq kernel/softirq.c:373 [inline] irq_exit+0x19b/0x1e0 kernel/softirq.c:413 exiting_irq arch/x86/include/asm/apic.h:536 [inline] smp_apic_timer_interrupt+0x1a3/0x610 arch/x86/kernel/apic/apic.c:1137 apic_timer_interrupt+0xf/0x20 arch/x86/entry/entry_64.S:829 </IRQ> RIP: 0010:native_safe_halt+0xe/0x10 arch/x86/include/asm/irqflags.h:61 Code: 38 be db f9 eb 8a cc cc cc cc cc cc e9 07 00 00 00 0f 00 2d c4 54 51 00 f4 c3 66 90 e9 07 00 00 00 0f 00 2d b4 54 51 00 fb f4 <c3> cc 55 48 89 e5 41 57 41 56 41 55 41 54 53 e8 5e 92 8b f9 e8 c9 RSP: 0018:ffffffff89807ce8 EFLAGS: 00000286 ORIG_RAX: ffffffffffffff13 RAX: 1ffffffff132669e RBX: ffffffff8987a140 RCX: 0000000000000000 RDX: dffffc0000000000 RSI: 0000000000000006 RDI: ffffffff8987a9d4 RBP: ffffffff89807d18 R08: ffffffff8987a140 R09: 0000000000000000 R10: 0000000000000000 R11: 0000000000000000 R12: dffffc0000000000 R13: ffffffff8a7b8600 R14: 0000000000000000 R15: 0000000000000000 arch_cpu_idle+0xa/0x10 arch/x86/kernel/process.c:690 default_idle_call+0x84/0xb0 kernel/sched/idle.c:94 cpuidle_idle_call kernel/sched/idle.c:154 [inline] do_idle+0x3c8/0x6e0 kernel/sched/idle.c:269 cpu_startup_entry+0x1b/0x20 kernel/sched/idle.c:361 rest_init+0x23b/0x371 init/main.c:451 arch_call_rest_init+0xe/0x1b start_kernel+0x904/0x943 init/main.c:784 x86_64_start_reservations+0x29/0x2b arch/x86/kernel/head64.c:490 x86_64_start_kernel+0x77/0x7b arch/x86/kernel/head64.c:471 secondary_startup_64+0xa4/0xb0 arch/x86/kernel/head_64.S:242 kobject: 'brport' (0000000015306f5c): kobject_cleanup, parent 00000000835b0c7d kobject: 'brport' (0000000015306f5c): calling ktype release kobject: 'brport': free name kobject: 'brport' (00000000f618ced7): kobject_cleanup, parent 00000000835b0c7d kobject: 'brport' (00000000f618ced7): calling ktype release kobject: 'brport': free name kobject: 'brport' (0000000090c32451): kobject_cleanup, parent 00000000835b0c7d kobject: 'brport' (0000000090c32451): calling ktype release kobject: 'brport': free name kobject: 'brport' (000000009b39b612): kobject_cleanup, parent 00000000835b0c7d kobject: 'brport' (000000009b39b612): calling ktype release kobject: 'brport': free name kobject: 'brport' (00000000fa23c3a6): kobject_cleanup, parent 00000000835b0c7d kobject: 'brport' (00000000fa23c3a6): calling ktype release kobject: 'brport': free name kobject: 'brport' (0000000059be53cf): kobject_cleanup, parent 00000000835b0c7d kobject: 'brport' (0000000059be53cf): calling ktype release kobject: 'brport': free name kobject: 'brport' (00000000afda9faa): kobject_cleanup, parent 00000000835b0c7d kobject: 'brport' (00000000afda9faa): calling ktype release kobject: 'brport': free name kobject: 'brport' (000000001b8d397b): kobject_cleanup, parent 00000000835b0c7d kobject: 'brport' (000000001b8d397b): calling ktype release kobject: 'brport': free name kobject: 'brport' (00000000c95708c8): kobject_cleanup, parent 00000000835b0c7d kobject: 'brport' (00000000c95708c8): calling ktype release kobject: 'brport': free name kobject: 'brport' (0000000021fa4c47): kobject_cleanup, parent 00000000835b0c7d kobject: 'brport' (0000000021fa4c47): calling ktype release kobject: 'brport': free name kobject: 'brport' (00000000e55a6ea3): kobject_cleanup, parent 00000000835b0c7d kobject: 'brport' (00000000e55a6ea3): calling ktype release kobject: 'brport': free name kobject: 'brport' (000000005f707c44): kobject_cleanup, parent 00000000835b0c7d kobject: 'brport' (000000005f707c44): calling ktype release kobject: 'brport': free name --- This bug is generated by a bot. It may contain errors. See https://goo.gl/tpsmEJ for more information about syzbot. syzbot engineers can be reached at syzkaller(a)googlegroups.com. syzbot will keep track of this bug report. See: https://goo.gl/tpsmEJ#status for how to communicate with syzbot. For information about bisection process see: https://goo.gl/tpsmEJ#bisection syzbot can test patches for this bug, for details see: https://goo.gl/tpsmEJ#testing-patches

2 2

Extracting topology information from batman adv
by Julian Schlenker 10 Jan '20

10 Jan '20

Hello there, for a project I have to start different processes on different nodes within an ad-hoc network. Besides CPU load and other factors I would like to use the network information in my decision making. For example having a hop count would be great. I did have a look into the alfred man page, especially the "batadv-vis -f jsondoc" command. This one seems to do the job although I am not sure what the "metric" stands for exactly. Or is maybe using batman, not batman adv a better fit, as I do not rely on any additional Layer3 services? In addition the remapping of mac to ip bothers me a bit. Thanks in advance! Best regards Julian

1 0

Re: WARNING: bad unlock balance in sch_direct_xmit
by syzbot 05 Jan '20

05 Jan '20

syzbot has bisected this bug to: commit ab92d68fc22f9afab480153bd82a20f6e2533769 Author: Taehee Yoo <ap420073(a)gmail.com> Date: Mon Oct 21 18:47:51 2019 +0000 net: core: add generic lockdep keys bisection log: https://syzkaller.appspot.com/x/bisect.txt?x=15e88ec6e00000 start commit: 36487907 Merge branch 'akpm' (patches from Andrew) git tree: upstream final crash: https://syzkaller.appspot.com/x/report.txt?x=17e88ec6e00000 console output: https://syzkaller.appspot.com/x/log.txt?x=13e88ec6e00000 kernel config: https://syzkaller.appspot.com/x/.config?x=f2f3ef188b7e16cf dashboard link: https://syzkaller.appspot.com/bug?extid=4ec99438ed7450da6272 syz repro: https://syzkaller.appspot.com/x/repro.syz?x=1722c5c1e00000 C reproducer: https://syzkaller.appspot.com/x/repro.c?x=167aee3ee00000 Reported-by: syzbot+4ec99438ed7450da6272(a)syzkaller.appspotmail.com Fixes: ab92d68fc22f ("net: core: add generic lockdep keys") For information about bisection process see: https://goo.gl/tpsmEJ#bisection

1 0

Re: [PATCH 3/8] net: batman-adv: remove unneeded MODULE_VERSION() usage
by Sven Eckelmann 04 Jan '20

04 Jan '20

On Saturday, 4 January 2020 20:51:26 CET Enrico Weigelt, metux IT consult wrote: > Remove MODULE_VERSION(), as it isn't needed at all: the only version > making sense is the kernel version. > > Signed-off-by: Enrico Weigelt, metux IT consult <info(a)metux.net> > --- While it is not strictly required, there are still some consumers that need this information to detect the version when installing various modules via backports. Kind regards, Sven

1 0

2024

2023

2022

2021

2020

2019

2018

2017

2016

2015

2014

2013

2012

2011

2010

2009

2008

2007

B.A.T.M.A.N January 2020