B.A.T.M.A.N August 2019

b.a.t.m.a.n@lists.open-mesh.org

10 participants
23 discussions

[PATCH 0/2] batman-adv: BATMAN_V: OGMv2 packet aggregation
by Linus Lüssing 04 Aug '19

04 Aug '19

Hi, This small patchset implements the transmission side for the OGMv2 packet aggregation in BATMAN_V. The receiver part was already implemented and seems to work nicely. The first patch implements the necessary queueing mechanism, utilizing skb queues. The second patch then implements the actual OGMv2 packet aggregation for the queued packets. Opportunities for later improvements (left out on purpose, to keep this patchset simple): * Reset queue timer on full queue / if flushing in batadv_v_ogm_queue_on_if(): -> to avoid sending small aggregates in the worker afterwards * Remove BATADV_MAX_AGGREGATION_BYTES (512 bytes) limitation: -> not needed for BATMAN_V, would break compatibility though... (* Increase BATADV_MAX_AGGREGATION_MS (100ms): -> BATMAN_V has less averaging, therefore could use slower OGM intervals and therefore slightly larger aggregtion time window) Regards, Linus Ref./obsolete: Previous, generic aggregation patchset: https://patchwork.open-mesh.org/patch/17013/

2 4

[PATCH] alfred: vis: Fix ifindex check when registering interface
by Sven Eckelmann 02 Aug '19

02 Aug '19

The return value of if_nametoindex should be checked before the rtnl query is send to the kernel. Otherwise we might try to operate on an ifindex which doesn't exist in the kernel - which will never register any interface. Fixes: a34f044de561 ("alfred: vis: Use rtnl to query list of hardifs of meshif") Signed-off-by: Sven Eckelmann <sven(a)narfation.org> --- vis/vis.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/vis/vis.c b/vis/vis.c index 8df3056..cdc5524 100644 --- a/vis/vis.c +++ b/vis/vis.c @@ -617,7 +617,7 @@ static int register_interfaces(struct globals *globals) }; register_arg.ifindex = if_nametoindex(globals->interface); - if (!globals->interface) + if (!register_arg.ifindex) return EXIT_FAILURE; -- 2.20.1

1 0

[PATCH] alfred: vis: Add missing include for ifinfomsg
by Sven Eckelmann 01 Aug '19

01 Aug '19

Fixes: 0fc6e6674428 ("alfred: vis: Retrieve hardif status via generic netlink") Signed-off-by: Sven Eckelmann <sven(a)narfation.org> --- vis/vis.c | 1 + 1 file changed, 1 insertion(+) diff --git a/vis/vis.c b/vis/vis.c index 9474563..8df3056 100644 --- a/vis/vis.c +++ b/vis/vis.c @@ -10,6 +10,7 @@ #include <dirent.h> #include <errno.h> #include <getopt.h> +#include <linux/rtnetlink.h> #include <net/if.h> #include <netinet/in.h> #include <signal.h> -- 2.20.1

1 0

2024

2023

2022

2021

2020

2019

2018

2017

2016

2015

2014

2013

2012

2011

2010

2009

2008

2007

B.A.T.M.A.N August 2019