B.A.T.M.A.N May 2019

b.a.t.m.a.n@lists.open-mesh.org

9 participants
19 discussions

[PATCH 1/3] batman-adv: Fix includes for *_MAX constants
by Sven Eckelmann 24 May '19

24 May '19

The commit 54d50897d544 ("linux/kernel.h: split *_MAX and *_MIN macros into <linux/limits.h>") moved the U32_MAX/INT_MAX/ULONG_MAX from linux/kernel.h to linux/limits.h. Adjust the includes accordingly. Signed-off-by: Sven Eckelmann <sven(a)narfation.org> --- net/batman-adv/gateway_common.c | 1 + net/batman-adv/hard-interface.c | 1 + net/batman-adv/netlink.c | 1 + net/batman-adv/sysfs.c | 1 + net/batman-adv/tp_meter.c | 1 + 5 files changed, 5 insertions(+) diff --git a/net/batman-adv/gateway_common.c b/net/batman-adv/gateway_common.c index dac097f9..fc557505 100644 --- a/net/batman-adv/gateway_common.c +++ b/net/batman-adv/gateway_common.c @@ -11,6 +11,7 @@ #include <linux/byteorder/generic.h> #include <linux/errno.h> #include <linux/kernel.h> +#include <linux/limits.h> #include <linux/math64.h> #include <linux/netdevice.h> #include <linux/stddef.h> diff --git a/net/batman-adv/hard-interface.c b/net/batman-adv/hard-interface.c index 79d1731b..89948764 100644 --- a/net/batman-adv/hard-interface.c +++ b/net/batman-adv/hard-interface.c @@ -16,6 +16,7 @@ #include <linux/if_ether.h> #include <linux/kernel.h> #include <linux/kref.h> +#include <linux/limits.h> #include <linux/list.h> #include <linux/netdevice.h> #include <linux/printk.h> diff --git a/net/batman-adv/netlink.c b/net/batman-adv/netlink.c index a67720fa..7253699c 100644 --- a/net/batman-adv/netlink.c +++ b/net/batman-adv/netlink.c @@ -21,6 +21,7 @@ #include <linux/if_vlan.h> #include <linux/init.h> #include <linux/kernel.h> +#include <linux/limits.h> #include <linux/list.h> #include <linux/netdevice.h> #include <linux/netlink.h> diff --git a/net/batman-adv/sysfs.c b/net/batman-adv/sysfs.c index 80fc3253..1efcb970 100644 --- a/net/batman-adv/sysfs.c +++ b/net/batman-adv/sysfs.c @@ -18,6 +18,7 @@ #include <linux/kernel.h> #include <linux/kobject.h> #include <linux/kref.h> +#include <linux/limits.h> #include <linux/netdevice.h> #include <linux/printk.h> #include <linux/rculist.h> diff --git a/net/batman-adv/tp_meter.c b/net/batman-adv/tp_meter.c index 82039214..dd6a9a40 100644 --- a/net/batman-adv/tp_meter.c +++ b/net/batman-adv/tp_meter.c @@ -21,6 +21,7 @@ #include <linux/kernel.h> #include <linux/kref.h> #include <linux/kthread.h> +#include <linux/limits.h> #include <linux/list.h> #include <linux/netdevice.h> #include <linux/param.h> -- 2.20.1

1 2

memory leak in batadv_tvlv_handler_register
by syzbot 24 May '19

24 May '19

Hello, syzbot found the following crash on: HEAD commit: f49aa1de Merge tag 'for-5.2-rc1-tag' of git://git.kernel.o.. git tree: upstream console output: https://syzkaller.appspot.com/x/log.txt?x=16ca4654a00000 kernel config: https://syzkaller.appspot.com/x/.config?x=61dd9e15a761691d dashboard link: https://syzkaller.appspot.com/bug?extid=d454a826e670502484b8 compiler: gcc (GCC) 9.0.0 20181231 (experimental) syz repro: https://syzkaller.appspot.com/x/repro.syz?x=17b81d9ca00000 C reproducer: https://syzkaller.appspot.com/x/repro.c?x=1500bd9ca00000 IMPORTANT: if you fix the bug, please add the following tag to the commit: Reported-by: syzbot+d454a826e670502484b8(a)syzkaller.appspotmail.com 57.000820][ T7044] team0 (unregistering): Port device team_slave_0 removed BUG: memory leak unreferenced object 0xffff888113c48bc0 (size 64): comm "softirq", pid 0, jiffies 4294942488 (age 34.850s) hex dump (first 32 bytes): 00 00 00 00 00 00 00 00 e0 cc 4c 13 81 88 ff ff ..........L..... 00 00 00 00 00 00 00 00 a0 81 15 83 ff ff ff ff ................ backtrace: [<00000000e8f47afd>] kmemleak_alloc_recursive include/linux/kmemleak.h:55 [inline] [<00000000e8f47afd>] slab_post_alloc_hook mm/slab.h:439 [inline] [<00000000e8f47afd>] slab_alloc mm/slab.c:3326 [inline] [<00000000e8f47afd>] kmem_cache_alloc_trace+0x13d/0x280 mm/slab.c:3553 [<000000004b89e436>] kmalloc include/linux/slab.h:547 [inline] [<000000004b89e436>] kzalloc include/linux/slab.h:742 [inline] [<000000004b89e436>] batadv_tvlv_handler_register+0xae/0x140 net/batman-adv/tvlv.c:529 [<00000000b3d9e02d>] batadv_tt_init+0x78/0x180 net/batman-adv/translation-table.c:4411 [<000000009ae2cc39>] batadv_mesh_init+0x196/0x230 net/batman-adv/main.c:208 [<000000005fc0d64d>] batadv_softif_init_late+0x1ca/0x220 net/batman-adv/soft-interface.c:861 [<00000000ecdf3bd4>] register_netdevice+0xbf/0x600 net/core/dev.c:8673 [<00000000f14c9819>] __rtnl_newlink+0xaca/0xb30 net/core/rtnetlink.c:3203 [<000000008fd2d6fa>] rtnl_newlink+0x4e/0x80 net/core/rtnetlink.c:3249 [<0000000029fa04eb>] rtnetlink_rcv_msg+0x178/0x4b0 net/core/rtnetlink.c:5218 [<0000000092499169>] netlink_rcv_skb+0x61/0x170 net/netlink/af_netlink.c:2486 [<0000000072c4499d>] rtnetlink_rcv+0x1d/0x30 net/core/rtnetlink.c:5236 [<00000000f89d63a1>] netlink_unicast_kernel net/netlink/af_netlink.c:1311 [inline] [<00000000f89d63a1>] netlink_unicast+0x1ec/0x2d0 net/netlink/af_netlink.c:1337 [<000000006e2fb165>] netlink_sendmsg+0x26a/0x480 net/netlink/af_netlink.c:1926 [<0000000068f29576>] sock_sendmsg_nosec net/socket.c:652 [inline] [<0000000068f29576>] sock_sendmsg+0x54/0x70 net/socket.c:671 [<00000000707b1f6b>] __sys_sendto+0x148/0x1f0 net/socket.c:1964 [<0000000015b6ba89>] __do_sys_sendto net/socket.c:1976 [inline] [<0000000015b6ba89>] __se_sys_sendto net/socket.c:1972 [inline] [<0000000015b6ba89>] __x64_sys_sendto+0x2a/0x30 net/socket.c:1972 BUG: memory leak unreferenced object 0xffff888114921200 (size 128): comm "syz-executor123", pid 7016, jiffies 4294942583 (age 33.900s) hex dump (first 32 bytes): f0 a8 c1 12 81 88 ff ff f0 a8 c1 12 81 88 ff ff ................ 0a 57 ac 57 c4 a5 6e 00 af d0 6c 97 81 88 ff ff .W.W..n...l..... backtrace: [<00000000e8f47afd>] kmemleak_alloc_recursive include/linux/kmemleak.h:55 [inline] [<00000000e8f47afd>] slab_post_alloc_hook mm/slab.h:439 [inline] [<00000000e8f47afd>] slab_alloc mm/slab.c:3326 [inline] [<00000000e8f47afd>] kmem_cache_alloc_trace+0x13d/0x280 mm/slab.c:3553 [<000000004cc7ff0e>] kmalloc include/linux/slab.h:547 [inline] [<000000004cc7ff0e>] hsr_create_self_node+0x42/0x150 net/hsr/hsr_framereg.c:84 [<0000000015dc75a8>] hsr_dev_finalize+0xa4/0x233 net/hsr/hsr_device.c:441 [<00000000cb1acb7e>] hsr_newlink+0xf3/0x140 net/hsr/hsr_netlink.c:69 [<00000000e468583b>] __rtnl_newlink+0x892/0xb30 net/core/rtnetlink.c:3191 [<000000008fd2d6fa>] rtnl_newlink+0x4e/0x80 net/core/rtnetlink.c:3249 [<0000000029fa04eb>] rtnetlink_rcv_msg+0x178/0x4b0 net/core/rtnetlink.c:5218 [<0000000092499169>] netlink_rcv_skb+0x61/0x170 net/netlink/af_netlink.c:2486 [<0000000072c4499d>] rtnetlink_rcv+0x1d/0x30 net/core/rtnetlink.c:5236 [<00000000f89d63a1>] netlink_unicast_kernel net/netlink/af_netlink.c:1311 [inline] [<00000000f89d63a1>] netlink_unicast+0x1ec/0x2d0 net/netlink/af_netlink.c:1337 [<000000006e2fb165>] netlink_sendmsg+0x26a/0x480 net/netlink/af_netlink.c:1926 [<0000000068f29576>] sock_sendmsg_nosec net/socket.c:652 [inline] [<0000000068f29576>] sock_sendmsg+0x54/0x70 net/socket.c:671 [<00000000707b1f6b>] __sys_sendto+0x148/0x1f0 net/socket.c:1964 [<0000000015b6ba89>] __do_sys_sendto net/socket.c:1976 [inline] [<0000000015b6ba89>] __se_sys_sendto net/socket.c:1972 [inline] [<0000000015b6ba89>] __x64_sys_sendto+0x2a/0x30 net/socket.c:1972 [<00000000b8ae154c>] do_syscall_64+0x76/0x1a0 arch/x86/entry/common.c:301 [<000000002d5a7be6>] entry_SYSCALL_64_after_hwframe+0x44/0xa9 BUG: memory leak unreferenced object 0xffff88811483f940 (size 64): comm "syz-executor123", pid 7016, jiffies 4294942583 (age 33.900s) hex dump (first 32 bytes): c0 e3 11 16 81 88 ff ff 00 02 00 00 00 00 ad de ................ 00 a0 c1 12 81 88 ff ff c0 a8 c1 12 81 88 ff ff ................ backtrace: [<00000000e8f47afd>] kmemleak_alloc_recursive include/linux/kmemleak.h:55 [inline] [<00000000e8f47afd>] slab_post_alloc_hook mm/slab.h:439 [inline] [<00000000e8f47afd>] slab_alloc mm/slab.c:3326 [inline] [<00000000e8f47afd>] kmem_cache_alloc_trace+0x13d/0x280 mm/slab.c:3553 [<00000000fda8b63f>] kmalloc include/linux/slab.h:547 [inline] [<00000000fda8b63f>] kzalloc include/linux/slab.h:742 [inline] [<00000000fda8b63f>] hsr_add_port+0xe7/0x220 net/hsr/hsr_slave.c:142 [<000000009bd8bf70>] hsr_dev_finalize+0x14f/0x233 net/hsr/hsr_device.c:472 [<00000000cb1acb7e>] hsr_newlink+0xf3/0x140 net/hsr/hsr_netlink.c:69 [<00000000e468583b>] __rtnl_newlink+0x892/0xb30 net/core/rtnetlink.c:3191 [<000000008fd2d6fa>] rtnl_newlink+0x4e/0x80 net/core/rtnetlink.c:3249 [<0000000029fa04eb>] rtnetlink_rcv_msg+0x178/0x4b0 net/core/rtnetlink.c:5218 [<0000000092499169>] netlink_rcv_skb+0x61/0x170 net/netlink/af_netlink.c:2486 [<0000000072c4499d>] rtnetlink_rcv+0x1d/0x30 net/core/rtnetlink.c:5236 [<00000000f89d63a1>] netlink_unicast_kernel net/netlink/af_netlink.c:1311 [inline] [<00000000f89d63a1>] netlink_unicast+0x1ec/0x2d0 net/netlink/af_netlink.c:1337 [<000000006e2fb165>] netlink_sendmsg+0x26a/0x480 net/netlink/af_netlink.c:1926 [<0000000068f29576>] sock_sendmsg_nosec net/socket.c:652 [inline] [<0000000068f29576>] sock_sendmsg+0x54/0x70 net/socket.c:671 [<00000000707b1f6b>] __sys_sendto+0x148/0x1f0 net/socket.c:1964 [<0000000015b6ba89>] __do_sys_sendto net/socket.c:1976 [inline] [<0000000015b6ba89>] __se_sys_sendto net/socket.c:1972 [inline] [<0000000015b6ba89>] __x64_sys_sendto+0x2a/0x30 net/socket.c:1972 [<00000000b8ae154c>] do_syscall_64+0x76/0x1a0 arch/x86/entry/common.c:301 [<000000002d5a7be6>] entry_SYSCALL_64_after_hwframe+0x44/0xa9 BUG: memory leak unreferenced object 0xffff888113c48bc0 (size 64): comm "softirq", pid 0, jiffies 4294942488 (age 36.440s) hex dump (first 32 bytes): 00 00 00 00 00 00 00 00 e0 cc 4c 13 81 88 ff ff ..........L..... 00 00 00 00 00 00 00 00 a0 81 15 83 ff ff ff ff ................ backtrace: [<00000000e8f47afd>] kmemleak_alloc_recursive include/linux/kmemleak.h:55 [inline] [<00000000e8f47afd>] slab_post_alloc_hook mm/slab.h:439 [inline] [<00000000e8f47afd>] slab_alloc mm/slab.c:3326 [inline] [<00000000e8f47afd>] kmem_cache_alloc_trace+0x13d/0x280 mm/slab.c:3553 [<000000004b89e436>] kmalloc include/linux/slab.h:547 [inline] [<000000004b89e436>] kzalloc include/linux/slab.h:742 [inline] [<000000004b89e436>] batadv_tvlv_handler_register+0xae/0x140 net/batman-adv/tvlv.c:529 [<00000000b3d9e02d>] batadv_tt_init+0x78/0x180 net/batman-adv/translation-table.c:4411 [<000000009ae2cc39>] batadv_mesh_init+0x196/0x230 net/batman-adv/main.c:208 [<000000005fc0d64d>] batadv_softif_init_late+0x1ca/0x220 net/batman-adv/soft-interface.c:861 [<00000000ecdf3bd4>] register_netdevice+0xbf/0x600 net/core/dev.c:8673 [<00000000f14c9819>] __rtnl_newlink+0xaca/0xb30 net/core/rtnetlink.c:3203 [<000000008fd2d6fa>] rtnl_newlink+0x4e/0x80 net/core/rtnetlink.c:3249 [<0000000029fa04eb>] rtnetlink_rcv_msg+0x178/0x4b0 net/core/rtnetlink.c:5218 [<0000000092499169>] netlink_rcv_skb+0x61/0x170 net/netlink/af_netlink.c:2486 [<0000000072c4499d>] rtnetlink_rcv+0x1d/0x30 net/core/rtnetlink.c:5236 [<00000000f89d63a1>] netlink_unicast_kernel net/netlink/af_netlink.c:1311 [inline] [<00000000f89d63a1>] netlink_unicast+0x1ec/0x2d0 net/netlink/af_netlink.c:1337 [<000000006e2fb165>] netlink_sendmsg+0x26a/0x480 net/netlink/af_netlink.c:1926 [<0000000068f29576>] sock_sendmsg_nosec net/socket.c:652 [inline] [<0000000068f29576>] sock_sendmsg+0x54/0x70 net/socket.c:671 [<00000000707b1f6b>] __sys_sendto+0x148/0x1f0 net/socket.c:1964 [<0000000015b6ba89>] __do_sys_sendto net/socket.c:1976 [inline] [<0000000015b6ba89>] __se_sys_sendto net/socket.c:1972 [inline] [<0000000015b6ba89>] __x64_sys_sendto+0x2a/0x30 net/socket.c:1972 BUG: memory leak unreferenced object 0xffff888114921200 (size 128): comm "syz-executor123", pid 7016, jiffies 4294942583 (age 35.490s) hex dump (first 32 bytes): f0 a8 c1 12 81 88 ff ff f0 a8 c1 12 81 88 ff ff ................ 0a 57 ac 57 c4 a5 6e 00 af d0 6c 97 81 88 ff ff .W.W..n...l..... backtrace: [<00000000e8f47afd>] kmemleak_alloc_recursive include/linux/kmemleak.h:55 [inline] [<00000000e8f47afd>] slab_post_alloc_hook mm/slab.h:439 [inline] [<00000000e8f47afd>] slab_alloc mm/slab.c:3326 [inline] [<00000000e8f47afd>] kmem_cache_alloc_trace+0x13d/0x280 mm/slab.c:3553 [<000000004cc7ff0e>] kmalloc include/linux/slab.h:547 [inline] [<000000004cc7ff0e>] hsr_create_self_node+0x42/0x150 net/hsr/hsr_framereg.c:84 [<0000000015dc75a8>] hsr_dev_finalize+0xa4/0x233 net/hsr/hsr_device.c:441 [<00000000cb1acb7e>] hsr_newlink+0xf3/0x140 net/hsr/hsr_netlink.c:69 [<00000000e468583b>] __rtnl_newlink+0x892/0xb30 net/core/rtnetlink.c:3191 [<000000008fd2d6fa>] rtnl_newlink+0x4e/0x80 net/core/rtnetlink.c:3249 [<0000000029fa04eb>] rtnetlink_rcv_msg+0x178/0x4b0 net/core/rtnetlink.c:5218 [<0000000092499169>] netlink_rcv_skb+0x61/0x170 net/netlink/af_netlink.c:2486 [<0000000072c4499d>] rtnetlink_rcv+0x1d/0x30 net/core/rtnetlink.c:5236 [<00000000f89d63a1>] netlink_unicast_kernel net/netlink/af_netlink.c:1311 [inline] [<00000000f89d63a1>] netlink_unicast+0x1ec/0x2d0 net/netlink/af_netlink.c:1337 [<000000006e2fb165>] netlink_sendmsg+0x26a/0x480 net/netlink/af_netlink.c:1926 [<0000000068f29576>] sock_sendmsg_nosec net/socket.c:652 [inline] [<0000000068f29576>] sock_sendmsg+0x54/0x70 net/socket.c:671 [<00000000707b1f6b>] __sys_sendto+0x148/0x1f0 net/socket.c:1964 [<0000000015b6ba89>] __do_sys_sendto net/socket.c:1976 [inline] [<0000000015b6ba89>] __se_sys_sendto net/socket.c:1972 [inline] [<0000000015b6ba89>] __x64_sys_sendto+0x2a/0x30 net/socket.c:1972 [<00000000b8ae154c>] do_syscall_64+0x76/0x1a0 arch/x86/entry/common.c:301 [<000000002d5a7be6>] entry_SYSCALL_64_after_hwframe+0x44/0xa9 BUG: memory leak unreferenced object 0xffff88811483f940 (size 64): comm "syz-executor123", pid 7016, jiffies 4294942583 (age 35.490s) hex dump (first 32 bytes): c0 e3 11 16 81 88 ff ff 00 02 00 00 00 00 ad de ................ 00 a0 c1 12 81 88 ff ff c0 a8 c1 12 81 88 ff ff ................ backtrace: [<00000000e8f47afd>] kmemleak_alloc_recursive include/linux/kmemleak.h:55 [inline] [<00000000e8f47afd>] slab_post_alloc_hook mm/slab.h:439 [inline] [<00000000e8f47afd>] slab_alloc mm/slab.c:3326 [inline] [<00000000e8f47afd>] kmem_cache_alloc_trace+0x13d/0x280 mm/slab.c:3553 [<00000000fda8b63f>] kmalloc include/linux/slab.h:547 [inline] [<00000000fda8b63f>] kzalloc include/linux/slab.h:742 [inline] [<00000000fda8b63f>] hsr_add_port+0xe7/0x220 net/hsr/hsr_slave.c:142 [<000000009bd8bf70>] hsr_dev_finalize+0x14f/0x233 net/hsr/hsr_device.c:472 [<00000000cb1acb7e>] hsr_newlink+0xf3/0x140 net/hsr/hsr_netlink.c:69 [<00000000e468583b>] __rtnl_newlink+0x892/0xb30 net/core/rtnetlink.c:3191 [<000000008fd2d6fa>] rtnl_newlink+0x4e/0x80 net/core/rtnetlink.c:3249 [<0000000029fa04eb>] rtnetlink_rcv_msg+0x178/0x4b0 net/core/rtnetlink.c:5218 [<0000000092499169>] netlink_rcv_skb+0x61/0x170 net/netlink/af_netlink.c:2486 [<0000000072c4499d>] rtnetlink_rcv+0x1d/0x30 net/core/rtnetlink.c:5236 [<00000000f89d63a1>] netlink_unicast_kernel net/netlink/af_netlink.c:1311 [inline] [<00000000f89d63a1>] netlink_unicast+0x1ec/0x2d0 net/netlink/af_netlink.c:1337 [<000000006e2fb165>] netlink_sendmsg+0x26a/0x480 net/netlink/af_netlink.c:1926 [<0000000068f29576>] sock_sendmsg_nosec net/socket.c:652 [inline] [<0000000068f29576>] sock_sendmsg+0x54/0x70 net/socket.c:671 [<00000000707b1f6b>] __sys_sendto+0x148/0x1f0 net/socket.c:1964 [<0000000015b6ba89>] __do_sys_sendto net/socket.c:1976 [inline] [<0000000015b6ba89>] __se_sys_sendto net/socket.c:1972 [inline] [<0000000015b6ba89>] __x64_sys_sendto+0x2a/0x30 net/socket.c:1972 [<00000000b8ae154c>] do_syscall_64+0x76/0x1a0 arch/x86/entry/common.c:301 [<000000002d5a7be6>] entry_SYSCALL_64_after_hwframe+0x44/0xa9 BUG: memory leak unreferenced object 0xffff888113c48bc0 (size 64): comm "softirq", pid 0, jiffies 4294942488 (age 38.040s) hex dump (first 32 bytes): 00 00 00 00 00 00 00 00 e0 cc 4c 13 81 88 ff ff ..........L..... 00 00 00 00 00 00 00 00 a0 81 15 83 ff ff ff ff ................ backtrace: [<00000000e8f47afd>] kmemleak_alloc_recursive include/linux/kmemleak.h:55 [inline] [<00000000e8f47afd>] slab_post_alloc_hook mm/slab.h:439 [inline] [<00000000e8f47afd>] slab_alloc mm/slab.c:3326 [inline] [<00000000e8f47afd>] kmem_cache_alloc_trace+0x13d/0x280 mm/slab.c:3553 [<000000004b89e436>] kmalloc include/linux/slab.h:547 [inline] [<000000004b89e436>] kzalloc include/linux/slab.h:742 [inline] [<000000004b89e436>] batadv_tvlv_handler_register+0xae/0x140 net/batman-adv/tvlv.c:529 [<00000000b3d9e02d>] batadv_tt_init+0x78/0x180 net/batman-adv/translation-table.c:4411 [<000000009ae2cc39>] batadv_mesh_init+0x196/0x230 net/batman-adv/main.c:208 [<000000005fc0d64d>] batadv_softif_init_late+0x1ca/0x220 net/batman-adv/soft-interface.c:861 [<00000000ecdf3bd4>] register_netdevice+0xbf/0x600 net/core/dev.c:8673 [<00000000f14c9819>] __rtnl_newlink+0xaca/0xb30 net/core/rtnetlink.c:3203 [<000000008fd2d6fa>] rtnl_newlink+0x4e/0x80 net/core/rtnetlink.c:3249 [<0000000029fa04eb>] rtnetlink_rcv_msg+0x178/0x4b0 net/core/rtnetlink.c:5218 [<0000000092499169>] netlink_rcv_skb+0x61/0x170 net/netlink/af_netlink.c:2486 [<0000000072c4499d>] rtnetlink_rcv+0x1d/0x30 net/core/rtnetlink.c:5236 [<00000000f89d63a1>] netlink_unicast_kernel net/netlink/af_netlink.c:1311 [inline] [<00000000f89d63a1>] netlink_unicast+0x1ec/0x2d0 net/netlink/af_netlink.c:1337 [<000000006e2fb165>] netlink_sendmsg+0x26a/0x480 net/netlink/af_netlink.c:1926 [<0000000068f29576>] sock_sendmsg_nosec net/socket.c:652 [inline] [<0000000068f29576>] sock_sendmsg+0x54/0x70 net/socket.c:671 [<00000000707b1f6b>] __sys_sendto+0x148/0x1f0 net/socket.c:1964 [<0000000015b6ba89>] __do_sys_sendto net/socket.c:1976 [inline] [<0000000015b6ba89>] __se_sys_sendto net/socket.c:1972 [inline] [<0000000015b6ba89>] __x64_sys_sendto+0x2a/0x30 net/socket.c:1972 BUG: memory leak unreferenced object 0xffff888114921200 (size 128): comm "syz-executor123", pid 7016, jiffies 4294942583 (age 37.090s) hex dump (first 32 bytes): f0 a8 c1 12 81 88 ff ff f0 a8 c1 12 81 88 ff ff ................ 0a 57 ac 57 c4 a5 6e 00 af d0 6c 97 81 88 ff ff .W.W..n...l..... backtrace: [<00000000e8f47afd>] kmemleak_alloc_recursive include/linux/kmemleak.h:55 [inline] [<00000000e8f47afd>] slab_post_alloc_hook mm/slab.h:439 [inline] [<00000000e8f47afd>] slab_alloc mm/slab.c:3326 [inline] [<00000000e8f47afd>] kmem_cache_alloc_trace+0x13d/0x280 mm/slab.c:3553 [<000000004cc7ff0e>] kmalloc include/linux/slab.h:547 [inline] [<000000004cc7ff0e>] hsr_create_self_node+0x42/0x150 net/hsr/hsr_framereg.c:84 [<0000000015dc75a8>] hsr_dev_finalize+0xa4/0x233 net/hsr/hsr_device.c:441 [<00000000cb1acb7e>] hsr_newlink+0xf3/0x140 net/hsr/hsr_netlink.c:69 [<00000000e468583b>] __rtnl_newlink+0x892/0xb30 net/core/rtnetlink.c:3191 [<000000008fd2d6fa>] rtnl_newlink+0x4e/0x80 net/core/rtnetlink.c:3249 [<0000000029fa04eb>] rtnetlink_rcv_msg+0x178/0x4b0 net/core/rtnetlink.c:5218 [<0000000092499169>] netlink_rcv_skb+0x61/0x170 net/netlink/af_netlink.c:2486 [<0000000072c4499d>] rtnetlink_rcv+0x1d/0x30 net/core/rtnetlink.c:5236 [<00000000f89d63a1>] netlink_unicast_kernel net/netlink/af_netlink.c:1311 [inline] [<00000000f89d63a1>] netlink_unicast+0x1ec/0x2d0 net/netlink/af_netlink.c:1337 [<000000006e2fb165>] netlink_sendmsg+0x26a/0x480 net/netlink/af_netlink.c:1926 [<0000000068f29576>] sock_sendmsg_nosec net/socket.c:652 [inline] [<0000000068f29576>] sock_sendmsg+0x54/0x70 net/socket.c:671 [<00000000707b1f6b>] __sys_sendto+0x148/0x1f0 net/socket.c:1964 [<0000000015b6ba89>] __do_sys_sendto net/socket.c:1976 [inline] [<0000000015b6ba89>] __se_sys_sendto net/socket.c:1972 [inline] [<0000000015b6ba89>] __x64_sys_sendto+0x2a/0x30 net/socket.c:1972 [<00000000b8ae154c>] do_syscall_64+0x76/0x1a0 arch/x86/entry/common.c:301 [<000000002d5a7be6>] entry_SYSCALL_64_after_hwframe+0x44/0xa9 BUG: memory leak unreferenced object 0xffff88811483f940 (size 64): comm "syz-executor123", pid 7016, jiffies 4294942583 (age 37.090s) hex dump (first 32 bytes): c0 e3 11 16 81 88 ff ff 00 02 00 00 00 00 ad de ................ 00 a0 c1 12 81 88 ff ff c0 a8 c1 12 81 88 ff ff ................ backtrace: [<00000000e8f47afd>] kmemleak_alloc_recursive include/linux/kmemleak.h:55 [inline] [<00000000e8f47afd>] slab_post_alloc_hook mm/slab.h:439 [inline] [<00000000e8f47afd>] slab_alloc mm/slab.c:3326 [inline] [<00000000e8f47afd>] kmem_cache_alloc_trace+0x13d/0x280 mm/slab.c:3553 [<00000000fda8b63f>] kmalloc include/linux/slab.h:547 [inline] [<00000000fda8b63f>] kzalloc include/linux/slab.h:742 [inline] [<00000000fda8b63f>] hsr_add_port+0xe7/0x220 net/hsr/hsr_slave.c:142 [<000000009bd8bf70>] hsr_dev_finalize+0x14f/0x233 net/hsr/hsr_device.c:472 [<00000000cb1acb7e>] hsr_newlink+0xf3/0x140 net/hsr/hsr_netlink.c:69 [<00000000e468583b>] __rtnl_newlink+0x892/0xb30 net/core/rtnetlink.c:3191 [<000000008fd2d6fa>] rtnl_newlink+0x4e/0x80 net/core/rtnetlink.c:3249 [<0000000029fa04eb>] rtnetlink_rcv_msg+0x178/0x4b0 net/core/rtnetlink.c:5218 [<0000000092499169>] netlink_rcv_skb+0x61/0x170 net/netlink/af_netlink.c:2486 [<0000000072c4499d>] rtnetlink_rcv+0x1d/0x30 net/core/rtnetlink.c:5236 [<00000000f89d63a1>] netlink_unicast_kernel net/netlink/af_netlink.c:1311 [inline] [<00000000f89d63a1>] netlink_unicast+0x1ec/0x2d0 net/netlink/af_netlink.c:1337 [<000000006e2fb165>] netlink_sendmsg+0x26a/0x480 net/netlink/af_netlink.c:1926 [<0000000068f29576>] sock_sendmsg_nosec net/socket.c:652 [inline] [<0000000068f29576>] sock_sendmsg+0x54/0x70 net/socket.c:671 [<00000000707b1f6b>] __sys_sendto+0x148/0x1f0 net/socket.c:1964 [<0000000015b6ba89>] __do_sys_sendto net/socket.c:1976 [inline] [<0000000015b6ba89>] __se_sys_sendto net/socket.c:1972 [inline] [<0000000015b6ba89>] __x64_sys_sendto+0x2a/0x30 net/socket.c:1972 [<00000000b8ae154c>] do_syscall_64+0x76/0x1a0 arch/x86/entry/common.c:301 [<000000002d5a7be6>] entry_SYSCALL_64_after_hwframe+0x44/0xa9 BUG: memory leak unreferenced object 0xffff888113c48bc0 (size 64): comm "softirq", pid 0, jiffies 4294942488 (age 38.130s) hex dump (first 32 bytes): 00 00 00 00 00 00 00 00 e0 cc 4c 13 81 88 ff ff ..........L..... 00 00 00 00 00 00 00 00 a0 81 15 83 ff ff ff ff ................ backtrace: [<00000000e8f47afd>] kmemleak_alloc_recursive include/linux/kmemleak.h:55 [inline] [<00000000e8f47afd>] slab_post_alloc_hook mm/slab.h:439 [inline] [<00000000e8f47afd>] slab_alloc mm/slab.c:3326 [inline] [<00000000e8f47afd>] kmem_cache_alloc_trace+0x13d/0x280 mm/slab.c:3553 [<000000004b89e436>] kmalloc include/linux/slab.h:547 [inline] [<000000004b89e436>] kzalloc include/linux/slab.h:742 [inline] [<000000004b89e436>] batadv_tvlv_handler_register+0xae/0x140 net/batman-adv/tvlv.c:529 [<00000000b3d9e02d>] batadv_tt_init+0x78/0x180 net/batman-adv/translation-table.c:4411 [<000000009ae2cc39>] batadv_mesh_init+0x196/0x230 net/batman-adv/main.c:208 [<000000005fc0d64d>] batadv_softif_init_late+0x1ca/0x220 net/batman-adv/soft-interface.c:861 [<00000000ecdf3bd4>] register_netdevice+0xbf/0x600 net/core/dev.c:8673 [<00000000f14c9819>] __rtnl_newlink+0xaca/0xb30 net/core/rtnetlink.c:3203 [<000000008fd2d6fa>] rtnl_newlink+0x4e/0x80 net/core/rtnetlink.c:3249 [<0000000029fa04eb>] rtnetlink_rcv_msg+0x178/0x4b0 net/core/rtnetlink.c:5218 [<0000000092499169>] netlink_rcv_skb+0x61/0x170 net/netlink/af_netlink.c:2486 [<0000000072c4499d>] rtnetlink_rcv+0x1d/0x30 net/core/rtnetlink.c:5236 [<00000000f89d63a1>] netlink_unicast_kernel net/netlink/af_netlink.c:1311 [inline] [<00000000f89d63a1>] netlink_unicast+0x1ec/0x2d0 net/netlink/af_netlink.c:1337 [<000000006e2fb165>] netlink_sendmsg+0x26a/0x480 net/netlink/af_netlink.c:1926 [<0000000068f29576>] sock_sendmsg_nosec net/socket.c:652 [inline] [<0000000068f29576>] sock_sendmsg+0x54/0x70 net/socket.c:671 [<00000000707b1f6b>] __sys_sendto+0x148/0x1f0 net/socket.c:1964 [<0000000015b6ba89>] __do_sys_sendto net/socket.c:1976 [inline] [<0000000015b6ba89>] __se_sys_sendto net/socket.c:1972 [inline] [<0000000015b6ba89>] __x64_sys_sendto+0x2a/0x30 net/socket.c:1972 BUG: memory leak unreferenced object 0xffff888114921200 (size 128): comm "syz-executor123", pid 7016, jiffies 4294942583 (age 37.180s) hex dump (first 32 bytes): f0 a8 c1 12 81 88 ff ff f0 a8 c1 12 81 88 ff ff ................ 0a 57 ac 57 c4 a5 6e 00 af d0 6c 97 81 88 ff ff .W.W..n...l..... backtrace: [<00000000e8f47afd>] kmemleak_alloc_recursive include/linux/kmemleak.h:55 [inline] [<00000000e8f47afd>] slab_post_alloc_hook mm/slab.h:439 [inline] [<00000000e8f47afd>] slab_alloc mm/slab.c:3326 [inline] [<00000000e8f47afd>] kmem_cache_alloc_trace+0x13d/0x280 mm/slab.c:3553 [<000000004cc7ff0e>] kmalloc include/linux/slab.h:547 [inline] [<000000004cc7ff0e>] hsr_create_self_node+0x42/0x150 net/hsr/hsr_framereg.c:84 [<0000000015dc75a8>] hsr_dev_finalize+0xa4/0x233 net/hsr/hsr_device.c:441 [<00000000cb1acb7e>] hsr_newlink+0xf3/0x140 net/hsr/hsr_netlink.c:69 [<00000000e468583b>] __rtnl_newlink+0x892/0xb30 net/core/rtnetlink.c:3191 [<000000008fd2d6fa>] rtnl_newlink+0x4e/0x80 net/core/rtnetlink.c:3249 [<0000000029fa04eb>] rtnetlink_rcv_msg+0x178/0x4b0 net/core/rtnetlink.c:5218 [<0000000092499169>] netlink_rcv_skb+0x61/0x170 net/netlink/af_netlink.c:2486 [<0000000072c4499d>] rtnetlink_rcv+0x1d/0x30 net/core/rtnetlink.c:5236 [<00000000f89d63a1>] netlink_unicast_kernel net/netlink/af_netlink.c:1311 [inline] [<00000000f89d63a1>] netlink_unicast+0x1ec/0x2d0 net/netlink/af_netlink.c:1337 [<000000006e2fb165>] netlink_sendmsg+0x26a/0x480 net/netlink/af_netlink.c:1926 [<0000000068f29576>] sock_sendmsg_nosec net/socket.c:652 [inline] [<0000000068f29576>] sock_sendmsg+0x54/0x70 net/socket.c:671 [<00000000707b1f6b>] __sys_sendto+0x148/0x1f0 net/socket.c:1964 [<0000000015b6ba89>] __do_sys_sendto net/socket.c:1976 [inline] [<0000000015b6ba89>] __se_sys_sendto net/socket.c:1972 [inline] [<0000000015b6ba89>] __x64_sys_sendto+0x2a/0x30 net/socket.c:1972 [<00000000b8ae154c>] do_syscall_64+0x76/0x1a0 arch/x86/entry/common.c:301 [<000000002d5a7be6>] entry_SYSCALL_64_after_hwframe+0x44/0xa9 BUG: memory leak unreferenced object 0xffff88811483f940 (size 64): comm "syz-executor123", pid 7016, jiffies 4294942583 (age 37.180s) hex dump (first 32 bytes): c0 e3 11 16 81 88 ff ff 00 02 00 00 00 00 ad de ................ 00 a0 c1 12 81 88 ff ff c0 a8 c1 12 81 88 ff ff ................ backtrace: [<00000000e8f47afd>] kmemleak_alloc_recursive include/linux/kmemleak.h:55 [inline] [<00000000e8f47afd>] slab_post_alloc_hook mm/slab.h:439 [inline] [<00000000e8f47afd>] slab_alloc mm/slab.c:3326 [inline] [<00000000e8f47afd>] kmem_cache_alloc_trace+0x13d/0x280 mm/slab.c:3553 [<00000000fda8b63f>] kmalloc include/linux/slab.h:547 [inline] [<00000000fda8b63f>] kzalloc include/linux/slab.h:742 [inline] [<00000000fda8b63f>] hsr_add_port+0xe7/0x220 net/hsr/hsr_slave.c:142 [<000000009bd8bf70>] hsr_dev_finalize+0x14f/0x233 net/hsr/hsr_device.c:472 [<00000000cb1acb7e>] hsr_newlink+0xf3/0x140 net/hsr/hsr_netlink.c:69 [<00000000e468583b>] __rtnl_newlink+0x892/0xb30 net/core/rtnetlink.c:3191 [<000000008fd2d6fa>] rtnl_newlink+0x4e/0x80 net/core/rtnetlink.c:3249 [<0000000029fa04eb>] rtnetlink_rcv_msg+0x178/0x4b0 net/core/rtnetlink.c:5218 [<0000000092499169>] netlink_rcv_skb+0x61/0x170 net/netlink/af_netlink.c:2486 [<0000000072c4499d>] rtnetlink_rcv+0x1d/0x30 net/core/rtnetlink.c:5236 [<00000000f89d63a1>] netlink_unicast_kernel net/netlink/af_netlink.c:1311 [inline] [<00000000f89d63a1>] netlink_unicast+0x1ec/0x2d0 net/netlink/af_netlink.c:1337 [<000000006e2fb165>] netlink_sendmsg+0x26a/0x480 net/netlink/af_netlink.c:1926 [<0000000068f29576>] sock_sendmsg_nosec net/socket.c:652 [inline] [<0000000068f29576>] sock_sendmsg+0x54/0x70 net/socket.c:671 [<00000000707b1f6b>] __sys_sendto+0x148/0x1f0 net/socket.c:1964 [<0000000015b6ba89>] __do_sys_sendto net/socket.c:1976 [inline] [<0000000015b6ba89>] __se_sys_sendto net/socket.c:1972 [inline] [<0000000015b6ba89>] __x64_sys_sendto+0x2a/0x30 net/socket.c:1972 [<00000000b8ae154c>] do_syscall_64+0x76/0x1a0 arch/x86/entry/common.c:301 [<000000002d5a7be6>] entry_SYSCALL_64_after_hwframe+0x44/0xa9 BUG: memory leak unreferenced object 0xffff888113c48bc0 (size 64): comm "softirq", pid 0, jiffies 4294942488 (age 38.210s) hex dump (first 32 bytes): 00 00 00 00 00 00 00 00 e0 cc 4c 13 81 88 ff ff ..........L..... 00 00 00 00 00 00 00 00 a0 81 15 83 ff ff ff ff ................ backtrace: [<00000000e8f47afd>] kmemleak_alloc_recursive include/linux/kmemleak.h:55 [inline] [<00000000e8f47afd>] slab_post_alloc_hook mm/slab.h:439 [inline] [<00000000e8f47afd>] slab_alloc mm/slab.c:3326 [inline] [<00000000e8f47afd>] kmem_cache_alloc_trace+0x13d/0x280 mm/slab.c:3553 [<000000004b89e436>] kmalloc include/linux/slab.h:547 [inline] [<000000004b89e436>] kzalloc include/linux/slab.h:742 [inline] [<000000004b89e436>] batadv_tvlv_handler_register+0xae/0x140 net/batman-adv/tvlv.c:529 [<00000000b3d9e02d>] batadv_tt_init+0x78/0x180 net/batman-adv/translation-table.c:4411 [<000000009ae2cc39>] batadv_mesh_init+0x196/0x230 net/batman-adv/main.c:208 [<000000005fc0d64d>] batadv_softif_init_late+0x1ca/0x220 net/batman-adv/soft-interface.c:861 [<00000000ecdf3bd4>] register_netdevice+0xbf/0x600 net/core/dev.c:8673 [<00000000f14c9819>] __rtnl_newlink+0xaca/0xb30 net/core/rtnetlink.c:3203 [<000000008fd2d6fa>] rtnl_newlink+0x4e/0x80 net/core/rtnetlink.c:3249 [<0000000029fa04eb>] rtnetlink_rcv_msg+0x178/0x4b0 net/core/rtnetlink.c:5218 [<0000000092499169>] netlink_rcv_skb+0x61/0x170 net/netlink/af_netlink.c:2486 [<0000000072c4499d>] rtnetlink_rcv+0x1d/0x30 net/core/rtnetlink.c:5236 [<00000000f89d63a1>] netlink_unicast_kernel net/netlink/af_netlink.c:1311 [inline] [<00000000f89d63a1>] netlink_unicast+0x1ec/0x2d0 net/netlink/af_netlink.c:1337 [<000000006e2fb165>] netlink_sendmsg+0x26a/0x480 net/netlink/af_netlink.c:1926 [<0000000068f29576>] sock_sendmsg_nosec net/socket.c:652 [inline] [<0000000068f29576>] sock_sendmsg+0x54/0x70 net/socket.c:671 [<00000000707b1f6b>] __sys_sendto+0x148/0x1f0 net/socket.c:1964 [<0000000015b6ba89>] __do_sys_sendto net/socket.c:1976 [inline] [<0000000015b6ba89>] __se_sys_sendto net/socket.c:1972 [inline] [<0000000015b6ba89>] __x64_sys_sendto+0x2a/0x30 net/socket.c:1972 BUG: memory leak unreferenced object 0xffff888114921200 (size 128): comm "syz-executor123", pid 7016, jiffies 4294942583 (age 37.260s) hex dump (first 32 bytes): f0 a8 c1 12 81 88 ff ff f0 a8 c1 12 81 88 ff ff ................ 0a 57 ac 57 c4 a5 6e 00 af d0 6c 97 81 88 ff ff .W.W..n...l..... backtrace: [<00000000e8f47afd>] kmemleak_alloc_recursive include/linux/kmemleak.h:55 [inline] [<00000000e8f47afd>] slab_post_alloc_hook mm/slab.h:439 [inline] [<00000000e8f47afd>] slab_alloc mm/slab.c:3326 [inline] [<00000000e8f47afd>] kmem_cache_alloc_trace+0x13d/0x280 mm/slab.c:3553 [<000000004cc7ff0e>] kmalloc include/linux/slab.h:547 [inline] [<000000004cc7ff0e>] hsr_create_self_node+0x42/0x150 net/hsr/hsr_framereg.c:84 [<0000000015dc75a8>] hsr_dev_finalize+0xa4/0x233 net/hsr/hsr_device.c:441 [<00000000cb1acb7e>] hsr_newlink+0xf3/0x140 net/hsr/hsr_netlink.c:69 [<00000000e468583b>] __rtnl_newlink+0x892/0xb30 net/core/rtnetlink.c:3191 [<000000008fd2d6fa>] rtnl_newlink+0x4e/0x80 net/core/rtnetlink.c:3249 [<0000000029fa04eb>] rtnetlink_rcv_msg+0x178/0x4b0 net/core/rtnetlink.c:5218 [<0000000092499169>] netlink_rcv_skb+0x61/0x170 net/netlink/af_netlink.c:2486 [<0000000072c4499d>] rtnetlink_rcv+0x1d/0x30 net/core/rtnetlink.c:5236 [<00000000f89d63a1>] netlink_unicast_kernel net/netlink/af_netlink.c:1311 [inline] [<00000000f89d63a1>] netlink_unicast+0x1ec/0x2d0 net/netlink/af_netlink.c:1337 [<000000006e2fb165>] netlink_sendmsg+0x26a/0x480 net/netlink/af_netlink.c:1926 [<0000000068f29576>] sock_sendmsg_nosec net/socket.c:652 [inline] [<0000000068f29576>] sock_sendmsg+0x54/0x70 net/socket.c:671 [<00000000707b1f6b>] __sys_sendto+0x148/0x1f0 net/socket.c:1964 [<0000000015b6ba89>] __do_sys_sendto net/socket.c:1976 [inline] [<0000000015b6ba89>] __se_sys_sendto net/socket.c:1972 [inline] [<0000000015b6ba89>] __x64_sys_sendto+0x2a/0x30 net/socket.c:1972 [<00000000b8ae154c>] do_syscall_64+0x76/0x1a0 arch/x86/entry/common.c:301 [<000000002d5a7be6>] entry_SYSCALL_64_after_hwframe+0x44/0xa9 BUG: memory leak unreferenced object 0xffff88811483f940 (size 64): comm "syz-executor123", pid 7016, jiffies 4294942583 (age 37.260s) hex dump (first 32 bytes): c0 e3 11 16 81 88 ff ff 00 02 00 00 00 00 ad de ................ 00 a0 c1 12 81 88 ff ff c0 a8 c1 12 81 88 ff ff ................ backtrace: [<00000000e8f47afd>] kmemleak_alloc_recursive include/linux/kmemleak.h:55 [inline] [<00000000e8f47afd>] slab_post_alloc_hook mm/slab.h:439 [inline] [<00000000e8f47afd>] slab_alloc mm/slab.c:3326 [inline] [<00000000e8f47afd>] kmem_cache_alloc_trace+0x13d/0x280 mm/slab.c:3553 [<00000000fda8b63f>] kmalloc include/linux/slab.h:547 [inline] [<00000000fda8b63f>] kzalloc include/linux/slab.h:742 [inline] [<00000000fda8b63f>] hsr_add_port+0xe7/0x220 net/hsr/hsr_slave.c:142 [<000000009bd8bf70>] hsr_dev_finalize+0x14f/0x233 net/hsr/hsr_device.c:472 [<00000000cb1acb7e>] hsr_newlink+0xf3/0x140 net/hsr/hsr_netlink.c:69 [<00000000e468583b>] __rtnl_newlink+0x892/0xb30 net/core/rtnetlink.c:3191 [<000000008fd2d6fa>] rtnl_newlink+0x4e/0x80 net/core/rtnetlink.c:3249 [<0000000029fa04eb>] rtnetlink_rcv_msg+0x178/0x4b0 net/core/rtnetlink.c:5218 [<0000000092499169>] netlink_rcv_skb+0x61/0x170 net/netlink/af_netlink.c:2486 [<0000000072c4499d>] rtnetlink_rcv+0x1d/0x30 net/core/rtnetlink.c:5236 [<00000000f89d63a1>] netlink_unicast_kernel net/netlink/af_netlink.c:1311 [inline] [<00000000f89d63a1>] netlink_unicast+0x1ec/0x2d0 net/netlink/af_netlink.c:1337 [<000000006e2fb165>] netlink_sendmsg+0x26a/0x480 net/netlink/af_netlink.c:1926 [<0000000068f29576>] sock_sendmsg_nosec net/socket.c:652 [inline] [<0000000068f29576>] sock_sendmsg+0x54/0x70 net/socket.c:671 [<00000000707b1f6b>] __sys_sendto+0x148/0x1f0 net/socket.c:1964 [<0000000015b6ba89>] __do_sys_sendto net/socket.c:1976 [inline] [<0000000015b6ba89>] __se_sys_sendto net/socket.c:1972 [inline] [<0000000015b6ba89>] __x64_sys_sendto+0x2a/0x30 net/socket.c:1972 [<00000000b8ae154c>] do_syscall_64+0x76/0x1a0 arch/x86/entry/common.c:301 [<000000002d5a7be6>] entry_SYSCALL_64_after_hwframe+0x44/0xa9 BUG: memory leak unreferenced object 0xffff888113c48bc0 (size 64): comm "softirq", pid 0, jiffies 4294942488 (age 38.290s) hex dump (first 32 bytes): 00 00 00 00 00 00 00 00 e0 cc 4c 13 81 88 ff ff ..........L..... 00 00 00 00 00 00 00 00 a0 81 15 83 ff ff ff ff ................ backtrace: [<00000000e8f47afd>] kmemleak_alloc_recursive include/linux/kmemleak.h:55 [inline] [<00000000e8f47afd>] slab_post_alloc_hook mm/slab.h:439 [inline] [<00000000e8f47afd>] slab_alloc mm/slab.c:3326 [inline] [<00000000e8f47afd>] kmem_cache_alloc_trace+0x13d/0x280 mm/slab.c:3553 [<000000004b89e436>] kmalloc include/linux/slab.h:547 [inline] [<000000004b89e436>] kzalloc include/linux/slab.h:742 [inline] [<000000004b89e436>] batadv_tvlv_handler_register+0xae/0x140 net/batman-adv/tvlv.c:529 [<00000000b3d9e02d>] batadv_tt_init+0x78/0x180 net/batman-adv/translation-table.c:4411 [<000000009ae2cc39>] batadv_mesh_init+0x196/0x230 net/batman-adv/main.c:208 [<000000005fc0d64d>] batadv_softif_init_late+0x1ca/0x220 net/batman-adv/soft-interface.c:861 [<00000000ecdf3bd4>] register_netdevice+0xbf/0x600 net/core/dev.c:8673 [<00000000f14c9819>] __rtnl_newlink+0xaca/0xb30 net/core/rtnetlink.c:3203 [<000000008fd2d6fa>] rtnl_newlink+0x4e/0x80 net/core/rtnetlink.c:3249 [<0000000029fa04eb>] rtnetlink_rcv_msg+0x178/0x4b0 net/core/rtnetlink.c:5218 [<0000000092499169>] netlink_rcv_skb+0x61/0x170 net/netlink/af_netlink.c:2486 [<0000000072c4499d>] rtnetlink_rcv+0x1d/0x30 net/core/rtnetlink.c:5236 [<00000000f89d63a1>] netlink_unicast_kernel net/netlink/af_netlink.c:1311 [inline] [<00000000f89d63a1>] netlink_unicast+0x1ec/0x2d0 net/netlink/af_netlink.c:1337 [<000000006e2fb165>] netlink_sendmsg+0x26a/0x480 net/netlink/af_netlink.c:1926 [<0000000068f29576>] sock_sendmsg_nosec net/socket.c:652 [inline] [<0000000068f29576>] sock_sendmsg+0x54/0x70 net/socket.c:671 [<00000000707b1f6b>] __sys_sendto+0x148/0x1f0 net/socket.c:1964 [<0000000015b6ba89>] __do_sys_sendto net/socket.c:1976 [inline] [<0000000015b6ba89>] __se_sys_sendto net/socket.c:1972 [inline] [<0000000015b6ba89>] __x64_sys_sendto+0x2a/0x30 net/socket.c:1972 BUG: memory leak unreferenced object 0xffff888114921200 (size 128): comm "syz-executor123", pid 7016, jiffies 4294942583 (age 37.350s) hex dump (first 32 bytes): f0 a8 c1 12 81 88 ff ff f0 a8 c1 12 81 88 ff ff ................ 0a 57 ac 57 c4 a5 6e 00 af d0 6c 97 81 88 ff ff .W.W..n...l..... backtrace: [<00000000e8f47afd>] kmemleak_alloc_recursive include/linux/kmemleak.h:55 [inline] [<00000000e8f47afd>] slab_post_alloc_hook mm/slab.h:439 [inline] [<00000000e8f47afd>] slab_alloc mm/slab.c:3326 [inline] [<00000000e8f47afd>] kmem_cache_alloc_trace+0x13d/0x280 mm/slab.c:3553 [<000000004cc7ff0e>] kmalloc include/linux/slab.h:547 [inline] [<000000004cc7ff0e>] hsr_create_self_node+0x42/0x150 net/hsr/hsr_framereg.c:84 [<0000000015dc75a8>] hsr_dev_finalize+0xa4/0x233 net/hsr/hsr_device.c:441 [<00000000cb1acb7e>] hsr_newlink+0xf3/0x140 net/hsr/hsr_netlink.c:69 [<00000000e468583b>] __rtnl_newlink+0x892/0xb30 net/core/rtnetlink.c:3191 [<000000008fd2d6fa>] rtnl_newlink+0x4e/0x80 net/core/rtnetlink.c:3249 [<0000000029fa04eb>] rtnetlink_rcv_msg+0x178/0x4b0 net/core/rtnetlink.c:5218 [<0000000092499169>] netlink_rcv_skb+0x61/0x170 net/netlink/af_netlink.c:2486 [<0000000072c4499d>] rtnetlink_rcv+0x1d/0x30 net/core/rtnetlink.c:5236 [<00000000f89d63a1>] netlink_unicast_kernel net/netlink/af_netlink.c:1311 [inline] [<00000000f89d63a1>] netlink_unicast+0x1ec/0x2d0 net/netlink/af_netlink.c:1337 [<000000006e2fb165>] netlink_sendmsg+0x26a/0x480 net/netlink/af_netlink.c:1926 [<0000000068f29576>] sock_sendmsg_nosec net/socket.c:652 [inline] [<0000000068f29576>] sock_sendmsg+0x54/0x70 net/socket.c:671 [<00000000707b1f6b>] __sys_sendto+0x148/0x1f0 net/socket.c:1964 [<0000000015b6ba89>] __do_sys_sendto net/socket.c:1976 [inline] [<0000000015b6ba89>] __se_sys_sendto net/socket.c:1972 [inline] [<0000000015b6ba89>] __x64_sys_sendto+0x2a/0x30 net/socket.c:1972 [<00000000b8ae154c>] do_syscall_64+0x76/0x1a0 arch/x86/entry/common.c:301 [<000000002d5a7be6>] entry_SYSCALL_64_after_hwframe+0x44/0xa9 BUG: memory leak unreferenced object 0xffff88811483f940 (size 64): comm "syz-executor123", pid 7016, jiffies 4294942583 (age 37.350s) hex dump (first 32 bytes): c0 e3 11 16 81 88 ff ff 00 02 00 00 00 00 ad de ................ 00 a0 c1 12 81 88 ff ff c0 a8 c1 12 81 88 ff ff ................ backtrace: [<00000000e8f47afd>] kmemleak_alloc_recursive include/linux/kmemleak.h:55 [inline] [<00000000e8f47afd>] slab_post_alloc_hook mm/slab.h:439 [inline] [<00000000e8f47afd>] slab_alloc mm/slab.c:3326 [inline] [<00000000e8f47afd>] kmem_cache_alloc_trace+0x13d/0x280 mm/slab.c:3553 [<00000000fda8b63f>] kmalloc include/linux/slab.h:547 [inline] [<00000000fda8b63f>] kzalloc include/linux/slab.h:742 [inline] [<00000000fda8b63f>] hsr_add_port+0xe7/0x220 net/hsr/hsr_slave.c:142 [<000000009bd8bf70>] hsr_dev_finalize+0x14f/0x233 net/hsr/hsr_device.c:472 [<00000000cb1acb7e>] hsr_newlink+0xf3/0x140 net/hsr/hsr_netlink.c:69 [<00000000e468583b>] __rtnl_newlink+0x892/0xb30 net/core/rtnetlink.c:3191 [<000000008fd2d6fa>] rtnl_newlink+0x4e/0x80 net/core/rtnetlink.c:3249 [<0000000029fa04eb>] rtnetlink_rcv_msg+0x178/0x4b0 net/core/rtnetlink.c:5218 [<0000000092499169>] netlink_rcv_skb+0x61/0x170 net/netlink/af_netlink.c:2486 [<0000000072c4499d>] rtnetlink_rcv+0x1d/0x30 net/core/rtnetlink.c:5236 [<00000000f89d63a1>] netlink_unicast_kernel net/netlink/af_netlink.c:1311 [inline] [<00000000f89d63a1>] netlink_unicast+0x1ec/0x2d0 net/netlink/af_netlink.c:1337 [<000000006e2fb165>] netlink_sendmsg+0x26a/0x480 net/netlink/af_netlink.c:1926 [<0000000068f29576>] sock_sendmsg_nosec net/socket.c:652 [inline] [<0000000068f29576>] sock_sendmsg+0x54/0x70 net/socket.c:671 [<00000000707b1f6b>] __sys_sendto+0x148/0x1f0 net/socket.c:1964 [<0000000015b6ba89>] __do_sys_sendto net/socket.c:1976 [inline] [<0000000015b6ba89>] __se_sys_sendto net/socket.c:1972 [inline] [<0000000015b6ba89>] __x64_sys_sendto+0x2a/0x30 net/socket.c:1972 [<00000000b8ae154c>] do_syscall_64+0x76/0x1a0 arch/x86/entry/common.c:301 [<000000002d5a7be6>] entry_SYSCALL_64_after_hwframe+0x44/0xa9 executing program executing program executing program executing program executing program executing program executing program --- This bug is generated by a bot. It may contain errors. See https://goo.gl/tpsmEJ for more information about syzbot. syzbot engineers can be reached at syzkaller(a)googlegroups.com. syzbot will keep track of this bug report. See: https://goo.gl/tpsmEJ#status for how to communicate with syzbot. syzbot can test patches for this bug, for details see: https://goo.gl/tpsmEJ#testing-patches

3 4

[PATCH v2] batman-adv: Introduce no noflood mark
by Linus Lüssing 14 May '19

14 May '19

This mark prevents a multicast packet being flooded through the whole mesh. The advantage of marking certain multicast packets via e.g. ebtables instead of dropping is then the following: This allows an administrator to let specific multicast packets pass as long as they are forwarded to a limited number of nodes only and are therefore creating no burdon to unrelated nodes. Signed-off-by: Linus Lüssing <linus.luessing(a)c0d3.blue> --- https://www.open-mesh.org/projects/batman-adv/wiki/Noflood-broadcast-preven… Changelog v2: * rebased to master * sysfs -> netlink --- include/uapi/linux/batman_adv.h | 12 ++++++++++++ net/batman-adv/netlink.c | 22 ++++++++++++++++++++++ net/batman-adv/soft-interface.c | 20 ++++++++++++++++++++ net/batman-adv/types.h | 12 ++++++++++++ 4 files changed, 66 insertions(+) diff --git a/include/uapi/linux/batman_adv.h b/include/uapi/linux/batman_adv.h index 67f46367..6fabb7aa 100644 --- a/include/uapi/linux/batman_adv.h +++ b/include/uapi/linux/batman_adv.h @@ -480,6 +480,18 @@ enum batadv_nl_attrs { */ BATADV_ATTR_MULTICAST_FANOUT, + /** + * @BATADV_ATTR_NOFLOOD_MARK: the noflood mark which allows to tag + * frames which should never be broadcast flooded through the mesh. + */ + BATADV_ATTR_NOFLOOD_MARK, + + /** + * @BATADV_ATTR_NOFLOOD_MASK: the noflood (bit)mask which allows to tag + * frames which should never be broadcast flooded through the mesh. + */ + BATADV_ATTR_NOFLOOD_MASK, + /* add attributes above here, update the policy in netlink.c */ /** diff --git a/net/batman-adv/netlink.c b/net/batman-adv/netlink.c index a67720fa..a08a67af 100644 --- a/net/batman-adv/netlink.c +++ b/net/batman-adv/netlink.c @@ -134,6 +134,8 @@ static const struct nla_policy batadv_netlink_policy[NUM_BATADV_ATTR] = { [BATADV_ATTR_AP_ISOLATION_ENABLED] = { .type = NLA_U8 }, [BATADV_ATTR_ISOLATION_MARK] = { .type = NLA_U32 }, [BATADV_ATTR_ISOLATION_MASK] = { .type = NLA_U32 }, + [BATADV_ATTR_NOFLOOD_MARK] = { .type = NLA_U32 }, + [BATADV_ATTR_NOFLOOD_MASK] = { .type = NLA_U32 }, [BATADV_ATTR_BONDING_ENABLED] = { .type = NLA_U8 }, [BATADV_ATTR_BRIDGE_LOOP_AVOIDANCE_ENABLED] = { .type = NLA_U8 }, [BATADV_ATTR_DISTRIBUTED_ARP_TABLE_ENABLED] = { .type = NLA_U8 }, @@ -286,6 +288,14 @@ static int batadv_netlink_mesh_fill(struct sk_buff *msg, bat_priv->isolation_mark_mask)) goto nla_put_failure; + if (nla_put_u32(msg, BATADV_ATTR_NOFLOOD_MARK, + bat_priv->noflood_mark)) + goto nla_put_failure; + + if (nla_put_u32(msg, BATADV_ATTR_NOFLOOD_MASK, + bat_priv->noflood_mark_mask)) + goto nla_put_failure; + if (nla_put_u8(msg, BATADV_ATTR_BONDING_ENABLED, !!atomic_read(&bat_priv->bonding))) goto nla_put_failure; @@ -466,6 +476,18 @@ static int batadv_netlink_set_mesh(struct sk_buff *skb, struct genl_info *info) bat_priv->isolation_mark_mask = nla_get_u32(attr); } + if (info->attrs[BATADV_ATTR_NOFLOOD_MARK]) { + attr = info->attrs[BATADV_ATTR_NOFLOOD_MARK]; + + bat_priv->noflood_mark = nla_get_u32(attr); + } + + if (info->attrs[BATADV_ATTR_NOFLOOD_MASK]) { + attr = info->attrs[BATADV_ATTR_NOFLOOD_MASK]; + + bat_priv->noflood_mark_mask = nla_get_u32(attr); + } + if (info->attrs[BATADV_ATTR_BONDING_ENABLED]) { attr = info->attrs[BATADV_ATTR_BONDING_ENABLED]; diff --git a/net/batman-adv/soft-interface.c b/net/batman-adv/soft-interface.c index a7677e1d..6912f651 100644 --- a/net/batman-adv/soft-interface.c +++ b/net/batman-adv/soft-interface.c @@ -176,6 +176,23 @@ static void batadv_interface_set_rx_mode(struct net_device *dev) { } +/** + * batadv_send_skb_has_noflood_mark() - check if packet has a noflood mark + * @bat_priv: the bat priv with all the soft interface information + * @skb: the packet to check + * + * Return: True if the skb's mark matches a configured noflood mark and + * noflood mark mask. False otherwise. + */ +static bool +batadv_skb_has_noflood_mark(struct batadv_priv *bat_priv, struct sk_buff *skb) +{ + u32 match_mark = skb->mark & bat_priv->noflood_mark_mask; + + return bat_priv->noflood_mark_mask && + match_mark == bat_priv->noflood_mark; +} + static netdev_tx_t batadv_interface_tx(struct sk_buff *skb, struct net_device *soft_iface) { @@ -326,6 +343,9 @@ static netdev_tx_t batadv_interface_tx(struct sk_buff *skb, if (batadv_dat_snoop_outgoing_arp_request(bat_priv, skb)) brd_delay = msecs_to_jiffies(ARP_REQ_DELAY); + if (batadv_skb_has_noflood_mark(bat_priv, skb)) + goto dropped; + if (batadv_skb_head_push(skb, sizeof(*bcast_packet)) < 0) goto dropped; diff --git a/net/batman-adv/types.h b/net/batman-adv/types.h index 74b64473..325a41a8 100644 --- a/net/batman-adv/types.h +++ b/net/batman-adv/types.h @@ -1592,6 +1592,18 @@ struct batadv_priv { */ u32 isolation_mark_mask; + /** + * @noflood_mark: the skb->mark value used to allow directed targeting + * only + */ + u32 noflood_mark; + + /** + * @noflood_mark_mask: bitmask identifying the bits in skb->mark to be + * used for the noflood mark + */ + u32 noflood_mark_mask; + /** @bcast_seqno: last sent broadcast packet sequence number */ atomic_t bcast_seqno; -- 2.20.1

3 7

[PATCH] batman-adv: convert stream-like files from nonseekable_open -> stream_open
by Sven Eckelmann 11 May '19

11 May '19

From: Kirill Smelkov <kirr(a)nexedi.com> Using scripts/coccinelle/api/stream_open.cocci added in 10dce8af3422 ("fs: stream_open - opener for stream-like files so that read and write can run simultaneously without deadlock"), search and convert to stream_open all in-kernel nonseekable_open users for which read and write actually do not depend on ppos and where there is no other methods in file_operations which assume @offset access. I've verified each generated change manually - that it is correct to convert - and each other nonseekable_open instance left - that it is either not correct to convert there, or that it is not converted due to current stream_open.cocci limitations. One can also recheck/review the patch via generating it with explanation comments included via $ make coccicheck MODE=patch COCCI=scripts/coccinelle/api/stream_open.cocci SPFLAGS="-D explain" Signed-off-by: Kirill Smelkov <kirr(a)nexedi.com> [sven(a)narfation.org: added compat code] Signed-off-by: Sven Eckelmann <sven(a)narfation.org> --- This change is already upstream https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git/patch/?i… --- compat-include/linux/fs.h | 11 +++++++++++ net/batman-adv/icmp_socket.c | 2 +- net/batman-adv/log.c | 2 +- 3 files changed, 13 insertions(+), 2 deletions(-) diff --git a/compat-include/linux/fs.h b/compat-include/linux/fs.h index c52e0e8e..480722f0 100644 --- a/compat-include/linux/fs.h +++ b/compat-include/linux/fs.h @@ -31,4 +31,15 @@ static inline struct dentry *batadv_file_dentry(const struct file *file) #endif /* < KERNEL_VERSION(4, 6, 0) */ +#if LINUX_VERSION_CODE < KERNEL_VERSION(5, 2, 0) + +static inline int batadv_stream_open(struct inode *inode, struct file *filp) +{ + return nonseekable_open(inode, filp); +} + +#define stream_open batadv_stream_open + +#endif /* < KERNEL_VERSION(5, 2, 0) */ + #endif /* _NET_BATMAN_ADV_COMPAT_LINUX_FS_H_ */ diff --git a/net/batman-adv/icmp_socket.c b/net/batman-adv/icmp_socket.c index de81b5ec..0a91c866 100644 --- a/net/batman-adv/icmp_socket.c +++ b/net/batman-adv/icmp_socket.c @@ -65,7 +65,7 @@ static int batadv_socket_open(struct inode *inode, struct file *file) batadv_debugfs_deprecated(file, ""); - nonseekable_open(inode, file); + stream_open(inode, file); socket_client = kmalloc(sizeof(*socket_client), GFP_KERNEL); if (!socket_client) { diff --git a/net/batman-adv/log.c b/net/batman-adv/log.c index 60ce11e1..f79ebd5b 100644 --- a/net/batman-adv/log.c +++ b/net/batman-adv/log.c @@ -90,7 +90,7 @@ static int batadv_log_open(struct inode *inode, struct file *file) batadv_debugfs_deprecated(file, "Use tracepoint batadv:batadv_dbg instead\n"); - nonseekable_open(inode, file); + stream_open(inode, file); file->private_data = inode->i_private; return 0; } -- 2.20.1

1 0

[PATCH 0/2] pull request for net: batman-adv 2019-05-09
by Simon Wunderlich 09 May '19

09 May '19

Hi David, here are some bugfixes which we would like to have integrated into net. Please pull or let me know of any problem! Thank you, Simon The following changes since commit 438b3d3fae4346a49fe12fa7cc1dc9327f006a91: batman-adv: Fix genl notification for throughput_override (2019-03-25 09:31:19 +0100) are available in the git repository at: git://git.open-mesh.org/linux-merge.git tags/batadv-net-for-davem-20190509 for you to fetch changes up to a3c7cd0cdf1107f891aff847ad481e34df727055: batman-adv: mcast: fix multicast tt/tvlv worker locking (2019-05-06 11:40:46 +0200) ---------------------------------------------------------------- This feature/cleanup patchset includes the following patches: - bump version strings, by Simon Wunderlich (we forgot to include this patch previously ...) - fix multicast tt/tvlv worker locking, by Linus Lüssing ---------------------------------------------------------------- Linus Lüssing (1): batman-adv: mcast: fix multicast tt/tvlv worker locking Simon Wunderlich (1): batman-adv: Start new development cycle net/batman-adv/main.c | 1 + net/batman-adv/main.h | 2 +- net/batman-adv/multicast.c | 11 +++-------- net/batman-adv/types.h | 5 +++++ 4 files changed, 10 insertions(+), 9 deletions(-)

2 3

[PATCH v3] batctl: Add noflood_mark command
by Linus Lüssing 07 May '19

07 May '19

Adds support for the new 'noflood_mark' setting in batman-adv. Signed-off-by: Linus Lüssing <linus.luessing(a)c0d3.blue> --- Changelog v3: * changed command from a noflood tri-state option to a value/mask one similar to the isolation mark * noflood.c -> noflood_mark.c Changelog v2: * added noflood.c --- Makefile | 1 + README.rst | 15 ++++++ batman_adv.h | 12 +++++ man/batctl.8 | 23 ++++++++ noflood_mark.c | 141 +++++++++++++++++++++++++++++++++++++++++++++++++ 5 files changed, 192 insertions(+) create mode 100644 noflood_mark.c diff --git a/Makefile b/Makefile index b7bd545..18f874c 100755 --- a/Makefile +++ b/Makefile @@ -60,6 +60,7 @@ $(eval $(call add_command,multicast_mode,y)) $(eval $(call add_command,nc_nodes,y)) $(eval $(call add_command,neighbors,y)) $(eval $(call add_command,network_coding,y)) +$(eval $(call add_command,noflood_mark,y)) $(eval $(call add_command,orig_interval,y)) $(eval $(call add_command,originators,y)) $(eval $(call add_command,ping,y)) diff --git a/README.rst b/README.rst index bc54412..c025c30 100644 --- a/README.rst +++ b/README.rst @@ -549,6 +549,21 @@ Usage:: * Example 4: ``batctl mark 0x0f`` +batctl noflood_mark +======================= + +display or modify noflood_mark setting + +Usage:: + + batctl noflood_mark|nf $value[/0x$mask] + +* Example 1: ``batctl nf 0x00000001/0xffffffff`` +* Example 2: ``batctl nf 0x00040000/0xffff0000`` +* Example 3: ``batctl nf 16`` +* Example 4: ``batctl nf 0x0f`` + + batctl translocal ================= diff --git a/batman_adv.h b/batman_adv.h index 67f4636..6fabb7a 100644 --- a/batman_adv.h +++ b/batman_adv.h @@ -480,6 +480,18 @@ enum batadv_nl_attrs { */ BATADV_ATTR_MULTICAST_FANOUT, + /** + * @BATADV_ATTR_NOFLOOD_MARK: the noflood mark which allows to tag + * frames which should never be broadcast flooded through the mesh. + */ + BATADV_ATTR_NOFLOOD_MARK, + + /** + * @BATADV_ATTR_NOFLOOD_MASK: the noflood (bit)mask which allows to tag + * frames which should never be broadcast flooded through the mesh. + */ + BATADV_ATTR_NOFLOOD_MASK, + /* add attributes above here, update the policy in netlink.c */ /** diff --git a/man/batctl.8 b/man/batctl.8 index 0b43031..4173137 100644 --- a/man/batctl.8 +++ b/man/batctl.8 @@ -116,6 +116,29 @@ If no parameter is given the current multicast fanout setting is displayed. Othe the multicast fanout. The multicast fanout defines the maximum number of packet copies that may be generated for a multicast-to-unicast conversion. Once this limit is exceeded distribution will fall back to broadcast. .br +.IP "\fBnoflood_mark\fP|\fBnf\fP" +If no parameter is given the current noflood mark value is displayed. +Otherwise the parameter is used to set or unset the noflood mark. The +noflood mark allows to prevent broadcast flooding of a frame which +was previously tagged via netfilter for instance. batman-adv will +then only forward a frame into the mesh if destined to a limited +number of destination nodes and drop the frame otherwise. +.br +The input is supposed to be of the form $value/$mask, where $value can be any +32bit long integer (expressed in decimal or hex base) and $mask is a generic +bitmask (expressed in hex base) that selects the bits to take into consideration +from $value. It is also possible to enter the input using only $value and in +this case the full bitmask is used by default. + +.br +.br +Example 1: 0x00000001/0xffffffff +.br +Example 2: 0x00040000/0xffff0000 +.br +Example 3: 16 or 0x0F +.br +.br .IP "\fBloglevel\fP|\fBll\fP [\fBlevel\fP[ \fBlevel\fP[ \fBlevel\fP]] \fB...\fP]" If no parameter is given the current log level settings are displayed otherwise the parameter(s) is/are used to set the log level. Level 'none' disables all verbose logging. Level 'batman' enables messages related to routing / flooding / broadcasting. diff --git a/noflood_mark.c b/noflood_mark.c new file mode 100644 index 0000000..e89205c --- /dev/null +++ b/noflood_mark.c @@ -0,0 +1,141 @@ +// SPDX-License-Identifier: GPL-2.0 +/* Copyright (C) 2009-2019 B.A.T.M.A.N. contributors: + * + * Antonio Quartulli <a(a)unstable.cc> + * Linus Lüssing <linus.luessing(a)c0d3.blue> + * + * License-Filename: LICENSES/preferred/GPL-2.0 + */ + +#include <errno.h> +#include <stddef.h> +#include <stdint.h> +#include <string.h> + +#include "main.h" +#include "sys.h" + +static struct noflood_mark_data { + uint32_t noflood_mark; + uint32_t noflood_mask; +} noflood_mark; + +static int parse_noflood_mark(struct state *state, int argc, char *argv[]) +{ + struct settings_data *settings = state->cmd->arg; + struct noflood_mark_data *data = settings->data; + char *mask_ptr; + char buff[256]; + uint32_t mark; + uint32_t mask; + char *endptr; + + if (argc != 2) { + fprintf(stderr, "Error - incorrect number of arguments (expected 1)\n"); + return -EINVAL; + } + + strncpy(buff, argv[1], sizeof(buff)); + buff[sizeof(buff) - 1] = '\0'; + + /* parse the mask if it has been specified, otherwise assume the mask is + * the biggest possible + */ + mask = 0xFFFFFFFF; + mask_ptr = strchr(buff, '/'); + if (mask_ptr) { + *mask_ptr = '\0'; + mask_ptr++; + + /* the mask must be entered in hex base as it is going to be a + * bitmask and not a prefix length + */ + mask = strtoul(mask_ptr, &endptr, 16); + if (!endptr || *endptr != '\0') + goto inval_format; + } + + /* the mark can be entered in any base */ + mark = strtoul(buff, &endptr, 0); + if (!endptr || *endptr != '\0') + goto inval_format; + + data->noflood_mask = mask; + /* erase bits not covered by the mask */ + data->noflood_mark = mark & mask; + + return 0; + +inval_format: + fprintf(stderr, "Error - incorrect number of arguments (expected 1)\n"); + fprintf(stderr, "The following formats for mark(/mask) are allowed:\n"); + fprintf(stderr, " * 0x12345678\n"); + fprintf(stderr, " * 0x12345678/0xabcdef09\n"); + return -EINVAL; +} + +static int print_noflood_mark(struct nl_msg *msg, void *arg) +{ + struct nlattr *attrs[BATADV_ATTR_MAX + 1]; + struct nlmsghdr *nlh = nlmsg_hdr(msg); + struct genlmsghdr *ghdr; + int *result = arg; + + if (!genlmsg_valid_hdr(nlh, 0)) + return NL_OK; + + ghdr = nlmsg_data(nlh); + + if (nla_parse(attrs, BATADV_ATTR_MAX, genlmsg_attrdata(ghdr, 0), + genlmsg_len(ghdr), batadv_netlink_policy)) { + return NL_OK; + } + + if (!attrs[BATADV_ATTR_NOFLOOD_MARK] || + !attrs[BATADV_ATTR_NOFLOOD_MASK]) + return NL_OK; + + printf("0x%08x/0x%08x\n", + nla_get_u32(attrs[BATADV_ATTR_NOFLOOD_MARK]), + nla_get_u32(attrs[BATADV_ATTR_NOFLOOD_MASK])); + + *result = 0; + return NL_STOP; +} + +static int get_noflood_mark(struct state *state) +{ + return sys_simple_nlquery(state, BATADV_CMD_GET_MESH, + NULL, print_noflood_mark); +} + +static int set_attrs_noflood_mark(struct nl_msg *msg, void *arg) +{ + struct state *state = arg; + struct settings_data *settings = state->cmd->arg; + struct noflood_mark_data *data = settings->data; + + nla_put_u32(msg, BATADV_ATTR_NOFLOOD_MARK, data->noflood_mark); + nla_put_u32(msg, BATADV_ATTR_NOFLOOD_MASK, data->noflood_mask); + + return 0; +} + +static int set_noflood_mark(struct state *state) +{ + return sys_simple_nlquery(state, BATADV_CMD_SET_MESH, + set_attrs_noflood_mark, NULL); +} + +static struct settings_data batctl_settings_noflood_mark = { + .sysfs_name = NULL, + .data = &noflood_mark, + .parse = parse_noflood_mark, + .netlink_get = get_noflood_mark, + .netlink_set = set_noflood_mark, +}; + +COMMAND_NAMED(SUBCOMMAND, noflood_mark, "nf", handle_sys_setting, + COMMAND_FLAG_MESH_IFACE | COMMAND_FLAG_NETLINK, + &batctl_settings_noflood_mark, + "[mark] \tdisplay or modify noflood_mark setting"); -- 2.20.1

1 0

[B.A.T.M.A.N.] [PATCH 0/6] batman-adv: Add routeable multicast optimizations
by Linus Lüssing 07 May '19

07 May '19

The following patchset fills the next gaps in the multicast address rules page by adding support for group-aware optimizations for multicast addresses of scope greater than link-local. So far, only link-local addresses were optimized as packets with routeable addresses not only need to be forwarded to local multicast listeners but also multicast routers. "Handling rules depending on multicast address:" [0] Before: * Ipv4, link-local: supported without bridges * IPv6, link-local: supported * IPv4, routeable: support planned. * IPv6, routeable: support planned. After: * Ipv4, link-local: supported without bridges * IPv6, link-local: supported * IPv4, routeable: supported without bridges. * IPv6, routeable: supported. The first patch is a fix for the maint branch addressing tickets #369 and #370. Then patches 2 to 4 are basically some cleanups and restructuring of the current code. Patch 5 adds the detection of multicast routers and announces that via two new flags in its multicast TVLV. TVLV receivers will memorize this and fill lists similar to how we already do for the WANT_ALL_IPV4/IPV6 flags. Currently the detection for bridged-in IPv6 multicast routers is not quite what the RFC for multicast router discovery suggests. But once the MRD implementation in the Linux bridge has matured a bit, I'm going to swap this simplified approach with tapping into the bridge once more, asking the bridge for the presence of multicast routers on the link. (This will then also add support for "IPv4, routeable, with bridges") Finally, patch 6 implements the changes to the forwarding plane, utilizing the new information we have gathered with patch 5. Regards, Linus [0]: https://www.open-mesh.org/projects/batman-adv/wiki/Multicast-optimizations-…

2 8

[PATCH v3 0/3] batman-adv: routeable multicast preparations
by Linus Lüssing 07 May '19

07 May '19

This patchset provides some code restructuring in preparation for the support of routeable multicast addresses. The first one adds a slightly cleaner separation of fetching and updating. And by that allows shortening the newly introduced spin-lock. The second one swaps the kernel MAC multicast list with the equivalent IPv4 and IPv6 ones: This allows an easier filtering later. Finally patch 3 is a first application of such filtering and allows omitting some redundant address additions to the TT. Later, the same will be necessary for routeable multicast addresses. --- Changelog v3: * fixed "From:" address in mail header Changelog v2: * rebased to master * removed already applied patch ("batman-adv: mcast: fix multicast tt/tvlv worker locking") * split patchset in two with the intention to ease reviewing (no code changes, just omitted the last two patches) * kerneldoc: alignment for batadv_mcast_mla_flags_update() [PATCH 2/6] / [PATCH v2 1/3] * fixed compile issues due to a duplicated member in struct * batadv_priv_mcast [PATCH 2/6] / [PATCH v2 1/3] * kerneldoc: added missing @flags for batadv_mcast_mla_flags_update() [PATCH 2/6] / [PATCH v2 1/3] * kerneldoc: @flags -> @tvlv_flags in struct batadv_mcast_mla_flags [PATCH 2/6] / [PATCH v2 1/3]

1 3

[B.A.T.M.A.N.] [PATCH] batman-adv: introduce "noflood" broadcast flood prevention option
by Linus Lüssing 02 May '19

02 May '19

With DAT DHCP snooping, the gateway feature and multicast optimizations in place in some scenarios broadcast flooding might not be strictly necessary anymore to be able to establish IPv4/IPv6 communication. Therefore this patch adds an option to disable broadcast flooding. Larger mesh networks typically filter a variety of multicast packets via ebtables/netfilter to clamp on overhead. With this option such firewall rules can be relaxed so that such multicast packets are only dropped if they cannot be handled by multicast-to-unicast, for instance. "noflood" comes in two flavours: If set to 1 then flood prevention is enabled for all multicast/broadcast packets except ICMPv6 and IGMP (cautious mode). Or, if set to 2 then flood prevention is enabled for all multicast/broadcast packets (aggressive mode). If set to 0 then flood prevention is disabled. "noflood" is disabled by default as there are still some things to take care of to avoid breaking things (especially for the "aggressive mode"). Signed-off-by: Linus Lüssing <linus.luessing(a)c0d3.blue> --- The initial approach was a "noflood"-mark which worked similar to the isolation mark. Which allowed more flexibility so that the user could mark specific packets to be excluded from broadcast flooding via ebtables/netfilter. However, in practice skb-marking is not that easy to configure and if misconfigured will break a network horribly. Which was also a downside noted and discussed at BattleMesh v11. This version now is a less flexible but therefore also simpler to use variant. [0]: https://git.open-mesh.org/batman-adv.git/shortlog/refs/heads/linus/noflood-… [1]: https://github.com/freifunk-gluon/gluon/pull/1357 --- include/uapi/linux/batman_adv.h | 10 ++++ net/batman-adv/netlink.c | 10 ++++ net/batman-adv/soft-interface.c | 85 +++++++++++++++++++++++++++++++++ net/batman-adv/types.h | 6 +++ 4 files changed, 111 insertions(+) diff --git a/include/uapi/linux/batman_adv.h b/include/uapi/linux/batman_adv.h index 67f46367..d68f8868 100644 --- a/include/uapi/linux/batman_adv.h +++ b/include/uapi/linux/batman_adv.h @@ -480,6 +480,16 @@ enum batadv_nl_attrs { */ BATADV_ATTR_MULTICAST_FANOUT, + /** + * @BATADV_ATTR_NOFLOOD: defines if and how strictly flooding prevention + * is configured. If the value is 0 then flood prevention is disabled. + * If the value is 1 then flood prevention is enabled for all multicast + * /broadcast packets excluding ICMPv6 and IGMP (cautious mode). If set + * to 2 then flood prevention is enabled for all multicast/broadcast + * packets (aggressive mode). + */ + BATADV_ATTR_NOFLOOD, + /* add attributes above here, update the policy in netlink.c */ /** diff --git a/net/batman-adv/netlink.c b/net/batman-adv/netlink.c index e7907308..940a9c37 100644 --- a/net/batman-adv/netlink.c +++ b/net/batman-adv/netlink.c @@ -358,6 +358,10 @@ static int batadv_netlink_mesh_fill(struct sk_buff *msg, atomic_read(&bat_priv->orig_interval))) goto nla_put_failure; + if (nla_put_u8(msg, BATADV_ATTR_NOFLOOD, + atomic_read(&bat_priv->noflood))) + goto nla_put_failure; + if (primary_if) batadv_hardif_put(primary_if); @@ -614,6 +618,12 @@ static int batadv_netlink_set_mesh(struct sk_buff *skb, struct genl_info *info) atomic_set(&bat_priv->orig_interval, orig_interval); } + if (info->attrs[BATADV_ATTR_NOFLOOD]) { + attr = info->attrs[BATADV_ATTR_NOFLOOD]; + + atomic_set(&bat_priv->noflood, nla_get_u8(attr)); + } + batadv_netlink_notify_mesh(bat_priv); return 0; diff --git a/net/batman-adv/soft-interface.c b/net/batman-adv/soft-interface.c index a7677e1d..680e3b03 100644 --- a/net/batman-adv/soft-interface.c +++ b/net/batman-adv/soft-interface.c @@ -18,6 +18,11 @@ #include <linux/gfp.h> #include <linux/if_ether.h> #include <linux/if_vlan.h> +#include <linux/igmp.h> +#include <linux/in.h> +#include <linux/in6.h> +#include <linux/ip.h> +#include <linux/ipv6.h> #include <linux/jiffies.h> #include <linux/kernel.h> #include <linux/kref.h> @@ -37,6 +42,7 @@ #include <linux/stddef.h> #include <linux/string.h> #include <linux/types.h> +#include <net/addrconf.h> #include <uapi/linux/batadv_packet.h> #include <uapi/linux/batman_adv.h> @@ -176,6 +182,81 @@ static void batadv_interface_set_rx_mode(struct net_device *dev) { } +/** + * batadv_softif_noflood_is_igmp() - check if a packet is IGMP + * @bat_priv: the bat priv with all the soft interface information + * @skb: the multicast/broadcast packet to check + * + * Return: True if the given skb is an IGMP packet, false otherwise. + */ +static bool batadv_softif_noflood_is_igmp(struct sk_buff *skb) +{ + int ret = ip_mc_check_igmp(skb); + + if (ret == -ENOMEM || ret == -EINVAL) + return false; + + /* ret == -ENOMSG => valid IPv6 header */ + if (ret == -ENOMSG && ip_hdr(skb)->protocol != IPPROTO_IGMP) + return false; + + /* it's IGMP */ + return true; +} + +/** + * batadv_softif_noflood_is_icmpv6() - check if a packet is ICMPv6 + * @bat_priv: the bat priv with all the soft interface information + * @skb: the multicast/broadcast packet to check + * + * Return: True if the given skb is an ICMPv6 packet, false otherwise. + */ +static bool batadv_softif_noflood_is_icmpv6(struct sk_buff *skb) +{ + int ret = ipv6_mc_check_mld(skb); + + if (ret == -ENOMEM || ret == -EINVAL) + return false; + + /* ret == -ENOMSG => valid IPv6 header */ + if (ret == -ENOMSG && ipv6_hdr(skb)->nexthdr != IPPROTO_ICMPV6) + return false; + + /* it's ICMPv6 */ + return true; +} + +/** + * batadv_softif_check_noflood() - check if flood-prevention is enabled + * @bat_priv: the bat priv with all the soft interface information + * @skb: the multicast/broadcast packet to check + * + * Return: True if flood prevention is enabled for this packet type, false + * otherwise. + */ +static bool +batadv_softif_check_noflood(struct batadv_priv *bat_priv, struct sk_buff *skb) +{ + int ret = atomic_read(&bat_priv->noflood); + + /* disabled */ + if (!ret) + return false; + /* aggressive mode */ + else if (ret == 2) + return true; + + /* exclude ICMPv6 and IGMP from "noflood" */ + switch (ntohs(eth_hdr(skb)->h_proto)) { + case ETH_P_IP: + return !batadv_softif_noflood_is_igmp(skb); + case ETH_P_IPV6: + return !batadv_softif_noflood_is_icmpv6(skb); + default: + return true; + } +} + static netdev_tx_t batadv_interface_tx(struct sk_buff *skb, struct net_device *soft_iface) { @@ -326,6 +407,9 @@ static netdev_tx_t batadv_interface_tx(struct sk_buff *skb, if (batadv_dat_snoop_outgoing_arp_request(bat_priv, skb)) brd_delay = msecs_to_jiffies(ARP_REQ_DELAY); + if (batadv_softif_check_noflood(bat_priv, skb)) + goto dropped; + if (batadv_skb_head_push(skb, sizeof(*bcast_packet)) < 0) goto dropped; @@ -823,6 +907,7 @@ static int batadv_softif_init_late(struct net_device *dev) atomic_set(&bat_priv->log_level, 0); #endif atomic_set(&bat_priv->fragmentation, 1); + atomic_set(&bat_priv->noflood, 0); atomic_set(&bat_priv->packet_size_max, ETH_DATA_LEN); atomic_set(&bat_priv->bcast_queue_left, BATADV_BCAST_QUEUE_LEN); atomic_set(&bat_priv->batman_queue_left, BATADV_BATMAN_QUEUE_LEN); diff --git a/net/batman-adv/types.h b/net/batman-adv/types.h index 357ca119..f3f96f02 100644 --- a/net/batman-adv/types.h +++ b/net/batman-adv/types.h @@ -1575,6 +1575,12 @@ struct batadv_priv { atomic_t log_level; #endif + /** + * @noflood: option indicating whether to drop packets that would + * be flooded through the mesh otherwise + */ + atomic_t noflood; + /** * @isolation_mark: the skb->mark value used to match packets for AP * isolation -- 2.20.1

4 8

2024

2023

2022

2021

2020

2019

2018

2017

2016

2015

2014

2013

2012

2011

2010

2009

2008

2007

B.A.T.M.A.N May 2019