B.A.T.M.A.N April 2017

b.a.t.m.a.n@lists.open-mesh.org

13 participants
21 discussions

[B.A.T.M.A.N.] (no subject)
by Linus Lüssing 25 Apr '17

25 Apr '17

Hi, This patchset introduces aggregation support for BATMAN V - as well as any other packet type with a broadcast destination. Branch: * https://git.open-mesh.org/batman-adv.git/shortlog/refs/heads/linus/aggregat… Regards, Linus --- Changelog: v3: * moved "Introduce packet type independent TVLV ..." from linus/neighhash to this patchset (this patchset is more important, therefore swapping their order) * removed the two already applied patches * rebased to master v2: * reset skb->cb on the soft-iface reception path, too [PATCH 5/6] (thanks Sven!) RFC->v1: * removed tvlv (un)pack ctx wrappers * fixed a crash when deaggregating ARP packets * now compile tested down to 3.2, too (no issues found) * now stress tested with multicast traffic of a larger, public mesh setup

1 6

[B.A.T.M.A.N.] [PATCH v4 0/4] Broadcast Avoidances, Neighborhood Hash
by Linus Lüssing 25 Apr '17

25 Apr '17

Hi, Here's the second broadcast avoidance patchset. Hopefully, those two patchsets together should be an automatic approach and replacement for the (non-upstream) no-rebroadcast flag patch and the cases it is currently used for. Documentation: * https://www.open-mesh.org/projects/batman-adv/wiki/Broadcast-Avoidances Branch: * https://git.open-mesh.org/batman-adv.git/shortlog/refs/heads/linus/neighhash Regards, Linus ----- Known limitations: Avoidance potential is not fully detected in a setup with a mix of 100MBit/s and 1000MBit/s capable, wired nodes. If rebroadcast avoidance is strictly needed in such mixed, wired setups, too, then people could consider setting the throughput_override option of BATMAN V.

2 7

[B.A.T.M.A.N.] Duplicate #include guards with make-kpkg / out-of-tree compile errors
by Linus Lüssing 24 Apr '17

24 Apr '17

Hi Ben and others, Recently we stumbled upon some compile errors when trying to build a backport version of the batman-adv kernel module for a 4.5 kernel [0]: "implicit declaration of function ‘G_TC_AT’" It seems VirtualBox has stumbled over this issue, too [1]. When trying to find the cause of these errors we noticed that the headers directory created via "$ make-kpkg kernel_headers" for 4.5 kernel resulted in two differing header files with the same guard, namely __LINUX_PKT_CLS_H: https://metameute.de/~tux/batman-adv/net-sched-issues/linux-headers-4.5.0%2… https://metameute.de/~tux/batman-adv/net-sched-issues/linux-headers-4.5.0%2… The latter, the non-uapi version, has the "#ifdef __KERNEL__" section stripped, causing the compile issue if it is included before the uapi variant. Removing this non-uapi version from the unpacked linux-headers .deb package manually afterwards lets a batman-adv compilation succeed again. Daniel (CC) has helped a lot with debugging so far and he expressed the suspicion that maybe make-kpkg might install "$ make headers_install" into the wrong directory? Regards, Linus [0]: https://www.open-mesh.org/issues/322 [1]: https://www.virtualbox.org/ticket/15327 PS: make-kpkg was invoked on a Debian Jessie (kernel-package 13.014+nmu1).

3 3

[B.A.T.M.A.N.] [batman-adv] Deaf hang happens quite often for a distant node (ar9331 + openwrt)
by Xuebing Wang 23 Apr '17

23 Apr '17

Hi Simon and Sven, Thank you very much for your help. I hope I correctly took the deaf state and 0xdeadbeef patches: [1] https://patchwork.kernel.org/patch/9433619/ [2] https://patchwork.kernel.org/patch/9433621/ Also, I use software encryption, in the hope to avoid key cache corruption. [3] https://patchwork.kernel.org/patch/9381651/ Are there other patches I need to apply for ar9331? I use ath_warn() before some cases of ath9k_queue_reset(). For a distant node, I saw below. deaf hang comes quite often, did you observe this too? ----------------- [ 985.520000] ath: phy0: RX deaf hang is detected. Schedule chip reset [ 1166.000000] ath: phy0: RX deaf hang is detected. Schedule chip reset [ 1617.200000] ath: phy0: RX deaf hang is detected. Schedule chip reset [ 2399.280000] ath: phy0: RX deaf hang is detected. Schedule chip reset [ 4023.600000] ath: phy0: RX deaf hang is detected. Schedule chip reset [ 4648.610000] ath: phy0: tx hung, resetting the chip [ 4802.610000] ath: phy0: tx hung, resetting the chip [ 5103.360000] ath: phy0: RX deaf hang is detected. Schedule chip reset [ 5975.680000] ath: phy0: RX deaf hang is detected. Schedule chip reset [ 6998.400000] ath: phy0: RX deaf hang is detected. Schedule chip reset ----------------- Thanks. Xuebing Wang

1 0

[B.A.T.M.A.N.] [ath10k] [batman-adv] Robustness of batman-adv or IBSS/802.11s on ath9k (AR9331 chip)
by Xuebing Wang 22 Apr '17

22 Apr '17

Hi ath10k community, Does anyone use ath9k driver + 802.11s (or IBSS/adhoc) on commercial products? Our setup is AR9331 + ath9k driver + OpenWRT 15.05 + batman-adv 2016.1 (PKG_RELEASE:=3) We are very serious about robustness of running batman-adv on AR9331, because we have 20+ commercial sites running, each site is with about 20 nodes. - batman-adv + ar9331 work almost (well almost) perfectly. - Sometimes, one node drops off the mesh, occurrence rate is very low. - For one time, when Node drops off the mesh, "rmmod ath9k" then "modprobe ath9k" can get both batman-adv (and ibss/adhoc on top of ath9k) recover. This seemingly points to that the issue is with ath9k driver (ibss/adhoc mode). As this email is mainly addressed to ath10k community (rather than batman-adv or openwrt), does anyone commercially use 802.11s (or ibss/adhoc)+ ath9k/ath10k? Does 802.11s (or ibss/adhoc) + ath9k/ath10k work perfectly? Thanks. Xuebing Wang

2 2

[B.A.T.M.A.N.] batman-adv route selection parameters
by Harms, Hannes 20 Apr '17

20 Apr '17

Hi community, consider the following wireless network: A <-- 60Mbit --> B <-- 60Mbit --> C A < ----------5Mbit-------------------> C Node A can talk to Node C via Node B Node A can talk to C directly, but with a significant lower throughput. All links have a relative low package loss. I run into the problem that batman-adv sometimes routes traffic directly from Node A to C. with gives me 5 Mbit throughput, and sometimes route A-B-C is chosen, resulting in 25 Mbit throughput. I have adjusted the originator interval to 200 ms, and the hop penalty to 1 without significant improvements. Are the other ways to force batman-adv to chose route A-B-C ? Thanks, Hannes -- Dipl.-Ing. Hannes Harms Technische Universität Braunschweig Institut für mobile Maschinen und Nutzfahrzeuge Langer Kamp 19a D-38106 Braunschweig Durchwahl: +49 (0)531 391-7197 E-Mail: hannes.harms(a)tu-braunschweig.de http://www.tu-braunschweig.de/imn

2 1

Re: [B.A.T.M.A.N.] [batman-adv] Does batman-adv works perfectly?
by Simon Wunderlich 18 Apr '17

18 Apr '17

Hi Xuebing, I didn't try the QSDK on those devices, mainly because of its poor upstream support/community involvement. We tried it on other devices, with "mixed" results. Cheers, Simon On Monday, April 17, 2017 10:19:02 PM CEST Xuebing Wang wrote: > Hi Sven and Simon, > > Thank you very much for your help. I am curious that did you try QCA-WiFi > driver for ath9k device (like AR9331) + OpenWRT, instead of trying to > improve ath9k driver? > > QCA-WiFi driver included in QSDK: > https://www.codeaurora.org/projects/all-active-projects/qsdk > > Thanks. > Xuebing Wang > > On Thu, Apr 6, 2017 at 3:13 PM, Sven Eckelmann <sven(a)narfation.org> wrote: > > On Donnerstag, 6. April 2017 09:04:50 CEST Simon Wunderlich wrote: > > > Hello Xuebing, > > > > > > it sounds like you have WiFi driver issues. There are some effects like > > > > key > > > > > cache corruption, deafness, and other effects known for the AR93xx > > > > series. > > > > Correct, completely forgot about the deaf and 0xdeadbeef issues. There > > were > > also two workarounds for them [1,2] from Simon. > > > > Kind regards, > > > > Sven > > > > [1] https://patchwork.kernel.org/patch/9433619/ > > [2] https://patchwork.kernel.org/patch/9433621/

1 0

[B.A.T.M.A.N.] [PATCH 00/19] pull request for net-next: batman-adv 2017-04-06
by Simon Wunderlich 06 Apr '17

06 Apr '17

Hi David, here is our feature/cleanup pull request of batman-adv to go into net-next. Please pull or let me know of any problem! Thank you, Simon The following changes since commit 4495c08e84729385774601b5146d51d9e5849f81: Linux 4.11-rc2 (2017-03-12 14:47:08 -0700) are available in the git repository at: git://git.open-mesh.org/linux-merge.git tags/batadv-next-for-davem-20170406 for you to fetch changes up to ab044f8e3eaf84c4cc95d7606fadfdfa006dc8ec: batman-adv: Use net_device_stats from struct net_device (2017-04-05 15:41:24 +0200) ---------------------------------------------------------------- This feature/cleanup patchset includes the following patches: - bump version strings, by Simon Wunderlich - Code and Style cleanups, by Sven Eckelmann (5 patches) - Remove an unneccessary memset, by Tobias Klauser - DAT and BLA optimizations for various corner cases, by Andreas Pape (5 patches) - forward/rebroadcast packet restructuring, by Linus Luessing (2 patches) - ethtool cleanup and remove unncessary code, by Sven Eckelmann (4 patches) - use net_device_stats from net_device instead of private copy, by Tobias Klauser ---------------------------------------------------------------- Andreas Pape (5): batman-adv: prevent multiple ARP replies sent by gateways if dat enabled batman-adv: prevent duplication of ARP replies when DAT is used batman-adv: drop unicast packets from other backbone gw batman-adv: changed debug messages for easier bla debugging batman-adv: handle race condition for claims between gateways Linus Lüssing (2): batman-adv: privatize forw_packet skb assignment batman-adv: restructure rebroadcast counter into forw_packet API Simon Wunderlich (1): batman-adv: Start new development cycle Sven Eckelmann (9): batman-adv: Reduce preprocessor checks in multicast.c batman-adv: Fix unbalanced braces around else statement batman-adv: Fix possible side-effects in _batadv_dbg batman-adv: Convert BATADV_PRINT_VID macro to function batman-adv: Use __func__ to add function names to messages batman-adv: Use ethtool helper to get link status batman-adv: Remove ethtool msglevel functions batman-adv: Remove ethtool .get_settings stub batman-adv: Group ethtool related code together Tobias Klauser (2): batman-adv: Omit unnecessary memset of netdev private data batman-adv: Use net_device_stats from struct net_device net/batman-adv/bat_iv_ogm.c | 17 +-- net/batman-adv/bridge_loop_avoidance.c | 123 +++++++++++++---- net/batman-adv/bridge_loop_avoidance.h | 11 ++ net/batman-adv/distributed-arp-table.c | 64 +++++++-- net/batman-adv/log.h | 5 +- net/batman-adv/main.c | 3 + net/batman-adv/main.h | 18 ++- net/batman-adv/multicast.c | 12 +- net/batman-adv/routing.c | 25 +++- net/batman-adv/send.c | 76 +++++++++-- net/batman-adv/send.h | 4 +- net/batman-adv/soft-interface.c | 238 +++++++++++++-------------------- net/batman-adv/tp_meter.c | 7 +- net/batman-adv/translation-table.c | 42 +++--- net/batman-adv/types.h | 6 +- 15 files changed, 413 insertions(+), 238 deletions(-)

2 20

[B.A.T.M.A.N.] [PATCH] batman-adv: Use net_device_stats from struct net_device
by Tobias Klauser 05 Apr '17

05 Apr '17

Instead of using a private copy of struct net_device_stats in struct batadv_priv, use stats from struct net_device. Signed-off-by: Tobias Klauser <tklauser(a)distanz.ch> --- net/batman-adv/distributed-arp-table.c | 9 +++++---- net/batman-adv/soft-interface.c | 2 +- net/batman-adv/types.h | 2 -- 3 files changed, 6 insertions(+), 7 deletions(-) diff --git a/net/batman-adv/distributed-arp-table.c b/net/batman-adv/distributed-arp-table.c index 1bfd1dbc2feb..936b08ee5b45 100644 --- a/net/batman-adv/distributed-arp-table.c +++ b/net/batman-adv/distributed-arp-table.c @@ -1002,6 +1002,7 @@ bool batadv_dat_snoop_outgoing_arp_request(struct batadv_priv *bat_priv, bool ret = false; struct batadv_dat_entry *dat_entry = NULL; struct sk_buff *skb_new; + struct net_device *soft_iface = bat_priv->soft_iface; int hdr_size = 0; unsigned short vid; @@ -1046,10 +1047,10 @@ bool batadv_dat_snoop_outgoing_arp_request(struct batadv_priv *bat_priv, if (!skb_new) goto out; - skb_new->protocol = eth_type_trans(skb_new, - bat_priv->soft_iface); - bat_priv->stats.rx_packets++; - bat_priv->stats.rx_bytes += skb->len + ETH_HLEN + hdr_size; + skb_new->protocol = eth_type_trans(skb_new, soft_iface); + + soft_iface->stats.rx_packets++; + soft_iface->stats.rx_bytes += skb->len + ETH_HLEN + hdr_size; netif_rx(skb_new); batadv_dbg(BATADV_DBG_DAT, bat_priv, "ARP request replied locally\n"); diff --git a/net/batman-adv/soft-interface.c b/net/batman-adv/soft-interface.c index d042c99af028..71895c58e6d8 100644 --- a/net/batman-adv/soft-interface.c +++ b/net/batman-adv/soft-interface.c @@ -140,7 +140,7 @@ static u64 batadv_sum_counter(struct batadv_priv *bat_priv, size_t idx) static struct net_device_stats *batadv_interface_stats(struct net_device *dev) { struct batadv_priv *bat_priv = netdev_priv(dev); - struct net_device_stats *stats = &bat_priv->stats; + struct net_device_stats *stats = &dev->stats; stats->tx_packets = batadv_sum_counter(bat_priv, BATADV_CNT_TX); stats->tx_bytes = batadv_sum_counter(bat_priv, BATADV_CNT_TX_BYTES); diff --git a/net/batman-adv/types.h b/net/batman-adv/types.h index 246f21b4973b..5c55e48d8941 100644 --- a/net/batman-adv/types.h +++ b/net/batman-adv/types.h @@ -1000,7 +1000,6 @@ struct batadv_priv_bat_v { * struct batadv_priv - per mesh interface data * @mesh_state: current status of the mesh (inactive/active/deactivating) * @soft_iface: net device which holds this struct as private data - * @stats: structure holding the data for the ndo_get_stats() call * @bat_counters: mesh internal traffic statistic counters (see batadv_counters) * @aggregated_ogms: bool indicating whether OGM aggregation is enabled * @bonding: bool indicating whether traffic bonding is enabled @@ -1055,7 +1054,6 @@ struct batadv_priv_bat_v { struct batadv_priv { atomic_t mesh_state; struct net_device *soft_iface; - struct net_device_stats stats; u64 __percpu *bat_counters; /* Per cpu counters */ atomic_t aggregated_ogms; atomic_t bonding; -- 2.12.2.399.g034667a45805

2 1

[B.A.T.M.A.N.] [PATCH] net: batman-adv: use new api ethtool_{get|set}_link_ksettings
by Philippe Reynes 03 Apr '17

03 Apr '17

The ethtool api {get|set}_settings is deprecated. We move this driver to new api {get|set}_link_ksettings. I've only compiled this change. If someone may test it, it would be very nice. Signed-off-by: Philippe Reynes <tremyfr(a)gmail.com> --- net/batman-adv/soft-interface.c | 25 ++++++++++++------------- 1 files changed, 12 insertions(+), 13 deletions(-) diff --git a/net/batman-adv/soft-interface.c b/net/batman-adv/soft-interface.c index d042c99..07f6627 100644 --- a/net/batman-adv/soft-interface.c +++ b/net/batman-adv/soft-interface.c @@ -64,7 +64,8 @@ #include "sysfs.h" #include "translation-table.h" -static int batadv_get_settings(struct net_device *dev, struct ethtool_cmd *cmd); +static int batadv_get_link_ksettings(struct net_device *dev, + struct ethtool_link_ksettings *cmd); static void batadv_get_drvinfo(struct net_device *dev, struct ethtool_drvinfo *info); static u32 batadv_get_msglevel(struct net_device *dev); @@ -76,7 +77,6 @@ static void batadv_get_ethtool_stats(struct net_device *dev, static int batadv_get_sset_count(struct net_device *dev, int stringset); static const struct ethtool_ops batadv_ethtool_ops = { - .get_settings = batadv_get_settings, .get_drvinfo = batadv_get_drvinfo, .get_msglevel = batadv_get_msglevel, .set_msglevel = batadv_set_msglevel, @@ -84,6 +84,7 @@ static void batadv_get_ethtool_stats(struct net_device *dev, .get_strings = batadv_get_strings, .get_ethtool_stats = batadv_get_ethtool_stats, .get_sset_count = batadv_get_sset_count, + .get_link_ksettings = batadv_get_link_ksettings, }; int batadv_skb_head_push(struct sk_buff *skb, unsigned int len) @@ -1085,18 +1086,16 @@ struct rtnl_link_ops batadv_link_ops __read_mostly = { }; /* ethtool */ -static int batadv_get_settings(struct net_device *dev, struct ethtool_cmd *cmd) +static int batadv_get_link_ksettings(struct net_device *dev, + struct ethtool_link_ksettings *cmd) { - cmd->supported = 0; - cmd->advertising = 0; - ethtool_cmd_speed_set(cmd, SPEED_10); - cmd->duplex = DUPLEX_FULL; - cmd->port = PORT_TP; - cmd->phy_address = 0; - cmd->transceiver = XCVR_INTERNAL; - cmd->autoneg = AUTONEG_DISABLE; - cmd->maxtxpkt = 0; - cmd->maxrxpkt = 0; + ethtool_link_ksettings_zero_link_mode(cmd, supported); + ethtool_link_ksettings_zero_link_mode(cmd, advertising); + cmd->base.speed = SPEED_10; + cmd->base.duplex = DUPLEX_FULL; + cmd->base.port = PORT_TP; + cmd->base.phy_address = 0; + cmd->base.autoneg = AUTONEG_DISABLE; return 0; } -- 1.7.4.4

2 4

2024

2023

2022

2021

2020

2019

2018

2017

2016

2015

2014

2013

2012

2011

2010

2009

2008

2007

B.A.T.M.A.N April 2017