B.A.T.M.A.N February 2017

b.a.t.m.a.n@lists.open-mesh.org

12 participants
28 discussions

[B.A.T.M.A.N.] [PATCH 00/17] pull request for net-next: batman-adv 2016-10-27
by Simon Wunderlich 04 Aug '18

04 Aug '18

Hi David, this is our first feature pull request for batman-adv (mostly containing code cleanup stuff), there are at least two more to come. Please pull or let me know of any problem! Thank you, Simon The following changes since commit 29fbff8698fc0ac1a1d74584b258e0bf18b469f9: Merge git://git.kernel.org/pub/scm/linux/kernel/git/davem/net (2016-10-13 21:40:23 -0700) are available in the git repository at: git://git.open-mesh.org/linux-merge.git tags/batadv-next-for-davem-20161027 for you to fetch changes up to 4c7da0f6dbcde2431d773ce03cde5e7abede54e0: batman-adv: Avoid precedence issues in macros (2016-10-19 08:37:54 +0200) ---------------------------------------------------------------- This code cleanup patchset includes the following changes (chronological order): - bump version strings, by Simon Wunderlich - README updates/clean up, by Sven Eckelmann (4 patches) - Code clean up and restructuring by Sven Eckelmann (2 patches) - Kerneldoc fix in forw_packet structure, by Linus Luessing - Remove unused argument in dbg_arp, by Antonio Quartulli - Add support to build batman-adv without wireless, by Linus Luessing - Restructure error handling for is_ap_isolated, by Markus Elfring - Remove unused initialization in various functions, by Sven Eckelmann - Use better names for fragment and gateway list heads, by Sven Eckelmann (2 patches) - Convert to octal permissions for files, by Sven Eckelmann - Avoid precedence issues for some macros, by Sven Eckelmann ---------------------------------------------------------------- Antonio Quartulli (1): batman-adv: remove unsed argument from batadv_dbg_arp() function Linus Lüssing (2): batman-adv: fix batadv_forw_packet kerneldoc for list attribute batman-adv: Allow selecting BATMAN V if CFG80211 is not built Markus Elfring (1): batman-adv: Less function calls in batadv_is_ap_isolated() after error detection Simon Wunderlich (1): batman-adv: Start new development cycle Sven Eckelmann (12): batman-adv: Add B.A.T.M.A.N. V sysfs files to README batman-adv: Add network_coding and mcast sysfs files to README batman-adv: Add dat, mcast, nc and neighbor debugfs files to README batman-adv: Document new nc, mcast and tpmeter log levels batman-adv: Remove unused function batadv_hash_delete batman-adv: Move batadv_sum_counter to soft-interface.c batman-adv: Remove unused batadv_icmp_user_cmd_type batman-adv: Remove needless init of variables on stack batman-adv: Use proper name for fragments list head batman-adv: Use proper name for gateway list head batman-adv: Use octal permissions instead of macros batman-adv: Avoid precedence issues in macros Documentation/networking/batman-adv.txt | 35 ++++++++++++---------- net/batman-adv/Kconfig | 2 +- net/batman-adv/bat_iv_ogm.c | 6 ++-- net/batman-adv/bat_v.c | 8 ++--- net/batman-adv/bat_v_ogm.c | 4 +-- net/batman-adv/debugfs.c | 26 ++++++++-------- net/batman-adv/distributed-arp-table.c | 17 ++++------- net/batman-adv/fragmentation.c | 18 +++++------ net/batman-adv/fragmentation.h | 2 +- net/batman-adv/gateway_client.c | 9 +++--- net/batman-adv/hash.h | 30 ------------------- net/batman-adv/icmp_socket.c | 5 ++-- net/batman-adv/log.c | 4 +-- net/batman-adv/log.h | 12 ++++---- net/batman-adv/main.c | 2 +- net/batman-adv/main.h | 27 ++--------------- net/batman-adv/network-coding.c | 8 ++--- net/batman-adv/originator.c | 10 +++---- net/batman-adv/packet.h | 12 +------- net/batman-adv/send.c | 2 +- net/batman-adv/soft-interface.c | 21 +++++++++++++ net/batman-adv/sysfs.c | 53 ++++++++++++++------------------- net/batman-adv/translation-table.c | 25 +++++++--------- net/batman-adv/types.h | 16 +++++----- 24 files changed, 149 insertions(+), 205 deletions(-)

7 35

Re: [B.A.T.M.A.N.] limit of if per batman
by Sven Eckelmann 03 Feb '18

03 Feb '18

On Mittwoch, 25. Januar 2017 03:18:10 CET jens wrote: > On 24.01.2017 14:39, Sven Eckelmann wrote: > > There is no artificial limit added by batman-adv. But transmitting a lot of > > broadcasts over 255 virtual links sharing the same physical link > > might get interesting (independent of batman-adv). > > this made me curious , and i modified your script a bit - turns out > after the 127. IF you add to batman-adv you get an Error - > all 510 gretap links was succesfully build ... > # ifconfig |grep gre| wc -l > 515 > # batctl if|sort|wc -l > 127 > the error is mainly > *Error - can't write to file > '/sys/class/net/gre128/batman_adv/mesh_iface': Cannot allocate memory [...] > [113990.684947] [<ffffffff8107c16e>] ? __warn+0xbe/0xe0 [113990.684955] > [<ffffffffc017a804>] ? batadv_orig_hash_add_if+0x94/0x140 [batman_adv] > [113990.684961] [<ffffffff811a7b10>] ? kmalloc_slab+0x90/0xa0 > [113990.684966] [<ffffffff811e08c5>] ? __kmalloc+0x25/0x580 > [113990.684971] [<ffffffff815ef9d7>] ? _raw_spin_lock_irqsave+0x17/0x39 > [113990.684977] [<ffffffff81432c11>] ? _crng_backtrack_protect+0x31/0x70 > [113990.684981] [<ffffffff811e0ebc>] ? kmem_cache_alloc_trace+0x9c/0x540 > [113990.684986] [<ffffffff814340b7>] ? get_random_bytes+0xe7/0x1c0 > [113990.684991] [<ffffffffc017a804>] ? [...] I would guess that your system mostly fails becauseit cannot handle the allocation of the "large" arrays which store: * @bcast_own: set of bitfields (one per hard-interface) where each one counts * the number of our OGMs this orig_node rebroadcasted "back" to us (relative * to last_real_seqno). Every bitfield is BATADV_TQ_LOCAL_WINDOW_SIZE bits long. * @bcast_own_sum: sum of bcast_own Kind regards, Sven

1 3

[B.A.T.M.A.N.] [PATCH] batman-adv: Deinline batadv_orig_hash_find, save 9024 bytes
by Denys Vlasenko 23 Oct '17

23 Oct '17

This function compiles to 473 bytes of machine code. 21 callsites. text data bss dec hex filename 95903266 20860288 35991552 152755106 91adba2 vmlinux_before 95894242 20860288 35991552 152746082 91ab862 vmlinux Signed-off-by: Denys Vlasenko <dvlasenk(a)redhat.com> CC: Marek Lindner <mareklindner(a)neomailbox.ch> CC: Simon Wunderlich <sw(a)simonwunderlich.de> CC: Antonio Quartulli <a(a)unstable.cc> CC: Sven Eckelmann <sven(a)narfation.org> CC: b.a.t.m.a.n(a)lists.open-mesh.org CC: linux-kernel(a)vger.kernel.org --- net/batman-adv/originator.c | 29 +++++++++++++++++++++++++++++ net/batman-adv/originator.h | 31 ++----------------------------- 2 files changed, 31 insertions(+), 29 deletions(-) diff --git a/net/batman-adv/originator.c b/net/batman-adv/originator.c index e4cbb07..bcf78f1 100644 --- a/net/batman-adv/originator.c +++ b/net/batman-adv/originator.c @@ -47,6 +47,36 @@ /* hash class keys */ static struct lock_class_key batadv_orig_hash_lock_class_key; +struct batadv_orig_node * +batadv_orig_hash_find(struct batadv_priv *bat_priv, const void *data) +{ + struct batadv_hashtable *hash = bat_priv->orig_hash; + struct hlist_head *head; + struct batadv_orig_node *orig_node, *orig_node_tmp = NULL; + int index; + + if (!hash) + return NULL; + + index = batadv_choose_orig(data, hash->size); + head = &hash->table[index]; + + rcu_read_lock(); + hlist_for_each_entry_rcu(orig_node, head, hash_entry) { + if (!batadv_compare_eth(orig_node, data)) + continue; + + if (!kref_get_unless_zero(&orig_node->refcount)) + continue; + + orig_node_tmp = orig_node; + break; + } + rcu_read_unlock(); + + return orig_node_tmp; +} + static void batadv_purge_orig(struct work_struct *work); /** diff --git a/net/batman-adv/originator.h b/net/batman-adv/originator.h index 4e8b67f..db7a87d 100644 --- a/net/batman-adv/originator.h +++ b/net/batman-adv/originator.h @@ -96,34 +96,7 @@ static inline u32 batadv_choose_orig(const void *data, u32 size) return hash % size; } -static inline struct batadv_orig_node * -batadv_orig_hash_find(struct batadv_priv *bat_priv, const void *data) -{ - struct batadv_hashtable *hash = bat_priv->orig_hash; - struct hlist_head *head; - struct batadv_orig_node *orig_node, *orig_node_tmp = NULL; - int index; - - if (!hash) - return NULL; - - index = batadv_choose_orig(data, hash->size); - head = &hash->table[index]; - - rcu_read_lock(); - hlist_for_each_entry_rcu(orig_node, head, hash_entry) { - if (!batadv_compare_eth(orig_node, data)) - continue; - - if (!kref_get_unless_zero(&orig_node->refcount)) - continue; - - orig_node_tmp = orig_node; - break; - } - rcu_read_unlock(); - - return orig_node_tmp; -} +struct batadv_orig_node * +batadv_orig_hash_find(struct batadv_priv *bat_priv, const void *data); #endif /* _NET_BATMAN_ADV_ORIGINATOR_H_ */ -- 1.8.1.4

3 5

[B.A.T.M.A.N.] [PATCH v2 0/6] batman-adv: broadcast packet aggregation
by Linus Lüssing 13 Jun '17

13 Jun '17

Hi, Here is a first patchset to reintroduce aggregation support for BATMAN V, too - as well as any other packet type with a broadcast destination. Branch: * https://git.open-mesh.org/batman-adv.git/shortlog/refs/heads/linus/aggregat… Regards, Linus PS: Requires: "batman-adv: Introduce packet type independent TVLV handler API" (40e5c9e798ec, available on patchwork or linus/aggregation branch) --- Changelog: v2: * reset skb->cb on the soft-iface reception path, too [PATCH 5/6] (thanks Sven!) RFC->v1: * removed tvlv (un)pack ctx wrappers * fixed a crash when deaggregating ARP packets * now compile tested down to 3.2, too (no issues found) * now stress tested with multicast traffic of a larger, public mesh setup

2 9

[B.A.T.M.A.N.] [PATCH v4 0/4] Broadcast Avoidances, Neighborhood Hash
by Linus Lüssing 25 Apr '17

25 Apr '17

Hi, Here's the second broadcast avoidance patchset. Hopefully, those two patchsets together should be an automatic approach and replacement for the (non-upstream) no-rebroadcast flag patch and the cases it is currently used for. Documentation: * https://www.open-mesh.org/projects/batman-adv/wiki/Broadcast-Avoidances Branch: * https://git.open-mesh.org/batman-adv.git/shortlog/refs/heads/linus/neighhash Regards, Linus ----- Known limitations: Avoidance potential is not fully detected in a setup with a mix of 100MBit/s and 1000MBit/s capable, wired nodes. If rebroadcast avoidance is strictly needed in such mixed, wired setups, too, then people could consider setting the throughput_override option of BATMAN V.

2 7

[B.A.T.M.A.N.] Duplicate #include guards with make-kpkg / out-of-tree compile errors
by Linus Lüssing 24 Apr '17

24 Apr '17

Hi Ben and others, Recently we stumbled upon some compile errors when trying to build a backport version of the batman-adv kernel module for a 4.5 kernel [0]: "implicit declaration of function ‘G_TC_AT’" It seems VirtualBox has stumbled over this issue, too [1]. When trying to find the cause of these errors we noticed that the headers directory created via "$ make-kpkg kernel_headers" for 4.5 kernel resulted in two differing header files with the same guard, namely __LINUX_PKT_CLS_H: https://metameute.de/~tux/batman-adv/net-sched-issues/linux-headers-4.5.0%2… https://metameute.de/~tux/batman-adv/net-sched-issues/linux-headers-4.5.0%2… The latter, the non-uapi version, has the "#ifdef __KERNEL__" section stripped, causing the compile issue if it is included before the uapi variant. Removing this non-uapi version from the unpacked linux-headers .deb package manually afterwards lets a batman-adv compilation succeed again. Daniel (CC) has helped a lot with debugging so far and he expressed the suspicion that maybe make-kpkg might install "$ make headers_install" into the wrong directory? Regards, Linus [0]: https://www.open-mesh.org/issues/322 [1]: https://www.virtualbox.org/ticket/15327 PS: make-kpkg was invoked on a Debian Jessie (kernel-package 13.014+nmu1).

3 3

[B.A.T.M.A.N.] [PATCH v2 0/4] batman-adv: cleanups patches for Linux 4.12
by Sven Eckelmann 28 Feb '17

28 Feb '17

Hi, here is the second version of cleanup patches. It addresses a couple of new checks from checkpatch.pl: * CHECK: Macro argument reuse '%s' - possible side-effects? * CHECK: Unbalanced braces around else statement The last check currently creates a lot of false positives but a fix for it was already submitted to Andrew Morton (+ accepted). It also contains a patch which converts the preprocessor blocks in multicast.c to simple inline checks. The compiler can directly take care of removing the unused code when some CONFIG_* option disabled. changes in v2: * rebased on top of master * split "Fix possible side-effects in macros" in two patches * converted BATADV_PRINT_VID to an inline function Kind regards, Sven Sven Eckelmann (4): batman-adv: Remove preprocessor checks in multicast.c batman-adv: Fix unbalanced braces around else statement batman-adv: Fix possible side-effects in _batadv_dbg batman-adv: Convert BATADV_PRINT_VID macro to function net/batman-adv/bridge_loop_avoidance.c | 38 +++++++++++++++--------------- net/batman-adv/distributed-arp-table.c | 6 ++--- net/batman-adv/log.h | 5 ++-- net/batman-adv/main.h | 16 +++++++++++-- net/batman-adv/multicast.c | 16 +++++-------- net/batman-adv/translation-table.c | 42 ++++++++++++++++++---------------- 6 files changed, 67 insertions(+), 56 deletions(-)

1 5

[B.A.T.M.A.N.] [PATCH v2 0/2] batman-adv: fragment size adjustments
by Sven Eckelmann 28 Feb '17

28 Feb '17

Hi, here is the second version of both fragment size patches. There is no actual change - just rebased on top of master. I'll recommend the commit message (from Linus!) of the first patch for more details. v2: * rebased on top of master Kind regards, Sven Matthias Schiffer (1): batman-adv: decrease maximum fragment size Sven Eckelmann (1): batman-adv: Keep fragments equally sized net/batman-adv/fragmentation.c | 20 +++++++++++++------- net/batman-adv/main.h | 2 +- 2 files changed, 14 insertions(+), 8 deletions(-)

1 3

Re: [B.A.T.M.A.N.] Node freezes but still alive
by Derick Roman De Leon Leal 25 Feb '17

25 Feb '17

Thanks Linus and Antonio for your replies. I guess is a driver issue, the thing is that I have been using this exact same configuration in other 10 locations without a problem. It sure is strange. I don't know if this helps, but I saw this in the log. Sat Feb 25 17:23:52 2017 kern.info kernel: [21168.652823] batman_adv: bat0: IGMP Querier disappeared - multicast optimizations disabled Sat Feb 25 17:24:02 2017 kern.info kernel: [21178.691583] batman_adv: bat0: IGMP Querier appeared A quick google search showed that this has to do with multicast, which is disabled in my configuration. Should I enable it? Also, I have noticed that the node with the issue is constantly requesting who-has the gateway. I ran this command from the gateway. batctl td -x257 adhoc0 18:23:44.134458 BAT ae:86:74:47:8b:02: BCAST, orig ae:86:74:47:8b:02, seq 1933, ARP, Request who-has 10.10.0.1 tell 10.10.0.142 (ac:86:74:47:8b:00), length 28 18:23:44.145748 BAT ae:86:74:47:8b:02: BCAST, orig ae:86:74:47:8b:02, seq 1933, ARP, Request who-has 10.10.0.1 tell 10.10.0.142 (ac:86:74:47:8b:00), length 28 18:23:45.124692 BAT ae:86:74:47:8b:02: BCAST, orig ae:86:74:47:8b:02, seq 1934, ARP, Request who-has 10.10.0.1 tell 10.10.0.142 (ac:86:74:47:8b:00), length 28 18:23:45.125725 BAT 60:e3:27:f2:71:1c > ae:86:74:47:8b:02: UCAST, ttvn 2, ttl 50, ARP, Reply 10.10.0.1 is-at 6a:64:42:e7:bf:cb, length 28 18:23:45.139625 BAT ae:86:74:47:8b:02: BCAST, orig ae:86:74:47:8b:02, seq 1934, ARP, Request who-has 10.10.0.1 tell 10.10.0.142 (ac:86:74:47:8b:00), length 28 18:23:45.144519 BAT ae:86:74:47:8b:02: BCAST, orig ae:86:74:47:8b:02, seq 1934, ARP, Request who-has 10.10.0.1 tell 10.10.0.142 (ac:86:74:47:8b:00), length 28 Does this means that there is IPv4 transmission? Is there a way to make sure this is a driver problem? In the meanwhile I will try a LEDE and a newer Openwrt. Thanks again for all your help, any comment is welcome. Best Regards, Derick

1 0

Re: [B.A.T.M.A.N.] Node freezes but still alive
by Derick Roman De Leon Leal 25 Feb '17

25 Feb '17

Thanks for the quick reply Linus, No transmission on IPv4, haven't tried on IPv6 but I assume is going to be the same. Someone suggested that I should use a bssid that starts with 02 (eg. 02:12:34:56:78:9A). Is this a requirement for the mesh to work? Should I share a batman-adv log? which packet type should be more useful? Thanks a lot!! Kind Regards, Derick > ---------- Forwarded message ---------- > From: "Linus Lüssing" <linus.luessing(a)c0d3.blue> > To: The list for a Better Approach To Mobile Ad-hoc Networking <b.a.t.m.a.n(a)lists.open-mesh.org> > Cc: > Bcc: > Date: Fri, 24 Feb 2017 09:28:11 +0100 > Subject: Re: [B.A.T.M.A.N.] Node freezes but still alive > Hi Derick, > > On Thu, Feb 23, 2017 at 05:37:55PM -0600, Derick Roman De Leon Leal wrote: > > I have a little setup with two nodes and one gateway, from time to > > time one of the nodes just stops transmitting data. > > Very odd indeed. Can you check whether transmitting IPv4 or > IPv6 packets on adhoc0 directly still works when this happens? > > Cheers, Linus > > > _______________________________________________ > B.A.T.M.A.N mailing list > B.A.T.M.A.N(a)lists.open-mesh.org > https://lists.open-mesh.org/mm/listinfo/b.a.t.m.a.n >

3 2

2024

2023

2022

2021

2020

2019

2018

2017

2016

2015

2014

2013

2012

2011

2010

2009

2008

2007

B.A.T.M.A.N February 2017