B.A.T.M.A.N February 2016

b.a.t.m.a.n@lists.open-mesh.org

21 participants
73 discussions

[B.A.T.M.A.N.] pull request: batman-adv 20160203

by Antonio Quartulli

Hello David, Here you have our first pull request intended for net-next. This batch of patches includes a number of corrections and improvements for our kernel-doc. These changes also make sure that our doc is now properly processed by the kernel-doc parsing tool. Other than that you have a patch updating all the copyright lines to 2016 and another patch switching the URLs in our readme, Kconfig and MAINTAINERS file from "http" to "https". Both by Sven Eckelmann. Please pull or let me know of any problem! Thanks a lot, Antonio P.S. as you requested I wrote the message above also in the git tag so that you get it when pulling from our tree. this is our first pull request intended for net-next. The following changes since commit b45efa30a626e915192a6c548cd8642379cd47cc: Merge git://git.kernel.org/pub/scm/linux/kernel/git/davem/net (2016-02-01 18:44:07 -0800) are available in the git repository at: git://git.open-mesh.org/linux-merge.git tags/batman-adv-for-davem for you to fetch changes up to 7b5e73961915438d623cb80eea97868b3a66cc48: batman-adv: Switch to HTTPS version of links (2016-02-03 09:54:39 +0800) ---------------------------------------------------------------- This batch of patches includes a number of corrections and improvements for our kernel-doc. These changes also make sure that our doc is now properly processed by the kernel-doc parsing tool. Other than that you have a patch updating all the copyright lines to 2016 and another patch switching the URLs in our readme, Kconfig and MAINTAINERS file from "http" to "https". Both by Sven Eckelmann. ---------------------------------------------------------------- Antonio Quartulli (3): batman-adv: fix kerneldoc for DAT functions batman-adv: fix kerneldoc for TT functions batman-adv: add kernel doc for AP isolation attributes in bat_priv Marek Lindner (1): batman-adv: kernel doc readability updates Simon Wunderlich (2): batman-adv: Update/repair bridge loop avoidance kerneldoc batman-adv: add kerneldoc for batadv_iv_ogm_aggr_packet Sven Eckelmann (10): batman-adv: Fix kerneldoc parsing of structs/enums batman-adv: Remove kerneldoc for missing parameters batman-adv: Fix names in kerneldoc of functions batman-adv: Drop invalid kerneldoc for variable batadv_vlan_attrs batman-adv: Fix kerneldoc parsing of return description batman-adv: Fix kerneldoc of main functions batman-adv: Fix kerneldoc of network-coding functions batman-adv: Fix kernel-doc for batadv_claim_free_ref batman-adv: update copyright years for 2016 batman-adv: Switch to HTTPS version of links Documentation/networking/batman-adv.txt | 2 +- MAINTAINERS | 2 +- net/batman-adv/Kconfig | 2 +- net/batman-adv/Makefile | 2 +- net/batman-adv/bat_algo.h | 2 +- net/batman-adv/bat_iv_ogm.c | 29 ++-- net/batman-adv/bitarray.c | 14 +- net/batman-adv/bitarray.h | 14 +- net/batman-adv/bridge_loop_avoidance.c | 231 +++++++++++++++++++++++--------- net/batman-adv/bridge_loop_avoidance.h | 2 +- net/batman-adv/debugfs.c | 8 +- net/batman-adv/debugfs.h | 2 +- net/batman-adv/distributed-arp-table.c | 43 +++--- net/batman-adv/distributed-arp-table.h | 2 +- net/batman-adv/fragmentation.c | 20 +-- net/batman-adv/fragmentation.h | 4 +- net/batman-adv/gateway_client.c | 16 +-- net/batman-adv/gateway_client.h | 2 +- net/batman-adv/gateway_common.c | 4 +- net/batman-adv/gateway_common.h | 2 +- net/batman-adv/hard-interface.c | 9 +- net/batman-adv/hard-interface.h | 2 +- net/batman-adv/hash.c | 2 +- net/batman-adv/hash.h | 24 ++-- net/batman-adv/icmp_socket.c | 2 +- net/batman-adv/icmp_socket.h | 2 +- net/batman-adv/main.c | 30 +++-- net/batman-adv/main.h | 19 ++- net/batman-adv/multicast.c | 37 +++-- net/batman-adv/multicast.h | 4 +- net/batman-adv/network-coding.c | 57 +++++--- net/batman-adv/network-coding.h | 2 +- net/batman-adv/originator.c | 56 ++++---- net/batman-adv/originator.h | 2 +- net/batman-adv/packet.h | 19 ++- net/batman-adv/routing.c | 38 +++--- net/batman-adv/routing.h | 2 +- net/batman-adv/send.c | 31 +++-- net/batman-adv/send.h | 6 +- net/batman-adv/soft-interface.c | 20 +-- net/batman-adv/soft-interface.h | 2 +- net/batman-adv/sysfs.c | 17 ++- net/batman-adv/sysfs.h | 2 +- net/batman-adv/translation-table.c | 119 +++++++++------- net/batman-adv/translation-table.h | 2 +- net/batman-adv/types.h | 30 +++-- 46 files changed, 584 insertions(+), 355 deletions(-)

7 years, 1 month

[B.A.T.M.A.N.] ibss.c backtrace when batman-adv adds wireless interface

by Josh Boyer

Hi All, We've had a user report the backtrace below when loading batman-adv on his machine. It looks like the cfg80211 layer is complaining about a null bss returned, but I cannot tell if the rtlwifi driver or batman-adv is in error here. Thoughts? josh Jan 28 22:29:21 melissa.gathman.org kernel: batman_adv: B.A.T.M.A.N. advanced 2015.2 (compatibility version 15) loaded Jan 28 22:29:21 melissa.gathman.org kernel: wlp0s26u1u4: Selected IBSS BSSID 02:1a:a0:3a:a6:ff based on configured SSID Jan 28 22:29:21 melissa.gathman.org kernel: ------------[ cut here ]------------ Jan 28 22:29:21 melissa.gathman.org kernel: WARNING: CPU: 1 PID: 111 at net/wireless/ibss.c:35 __cfg80211_ibss_joined+0x166/0x190 [cfg80211]() Jan 28 22:29:21 melissa.gathman.org kernel: Modules linked in: batman_adv libcrc32c xt_CHECKSUM ipt_MASQUERADE nf_nat_masquerade_ipv4 nf_conntrack_netbios_ns nf_conntrack_broadcast ip6t_rpfilter ip6t_REJECT nf_reject_ipv6 xt_conntrack tun ebtable_filter ebtable_nat ebtable_broute bridge stp llc ebtables ip6table_mangle ip6table_nat nf_conntrack_ipv6 nf_defrag_ipv6 nf_nat_ipv6 ip6table_raw ip6table_security ip6table_filter ip6_tables iptable_mangle iptable_nat nf_conntrack_ipv4 nf_defrag_ipv4 nf_nat_ipv4 nf_nat nf_conntrack iptable_raw iptable_security arc4 rtl8192cu rtl_usb rtl8192c_common rtlwifi mac80211 cfg80211 rfkill uvcvideo videobuf2_vmalloc videobuf2_core videobuf2_memops v4l2_common intel_rapl snd_hda_codec_hdmi snd_usb_audio joydev snd_usbmidi_lib snd_hda_codec_realtek iosf_mbi x86_pkg_temp_thermal videodev coretemp kvm_intel Jan 28 22:29:21 melissa.gathman.org kernel: media snd_rawmidi cm109 snd_hda_codec_generic kvm snd_hda_intel iTCO_wdt snd_hda_codec iTCO_vendor_support crct10dif_pclmul snd_hda_core ppdev snd_hwdep snd_seq snd_seq_device snd_pcm crc32_pclmul crc32c_intel snd_timer snd dcdbas lpc_ich mei_me parport_pc parport shpchp i2c_i801 mei tpm_tis tpm soundcore nfsd auth_rpcgss nfs_acl lockd grace sunrpc hid_microsoft i915 i2c_algo_bit drm_kms_helper drm e1000e serio_raw ptp pps_core fjes video Jan 28 22:29:21 melissa.gathman.org kernel: CPU: 1 PID: 111 Comm: kworker/u32:5 Not tainted 4.3.3-301.fc23.x86_64 #1 Jan 28 22:29:21 melissa.gathman.org kernel: Hardware name: Dell Inc. OptiPlex 790/0HY9JP, BIOS A06 07/25/2011 Jan 28 22:29:21 melissa.gathman.org kernel: Workqueue: cfg80211 cfg80211_event_work [cfg80211] Jan 28 22:29:21 melissa.gathman.org kernel: 0000000000000000 000000008beeeb5f ffff8800368bfce0 ffffffff813a626f Jan 28 22:29:21 melissa.gathman.org kernel: 0000000000000000 ffff8800368bfd18 ffffffff810a07c2 ffff8800c2bc8850 Jan 28 22:29:21 melissa.gathman.org kernel: ffff8800c2bc8000 ffff8801275bd558 0000000000000000 0000000000000286 Jan 28 22:29:21 melissa.gathman.org kernel: Call Trace: Jan 28 22:29:21 melissa.gathman.org kernel: [<ffffffff813a626f>] dump_stack+0x44/0x55 Jan 28 22:29:21 melissa.gathman.org kernel: [<ffffffff810a07c2>] warn_slowpath_common+0x82/0xc0 Jan 28 22:29:21 melissa.gathman.org kernel: [<ffffffff810a090a>] warn_slowpath_null+0x1a/0x20 Jan 28 22:29:21 melissa.gathman.org kernel: [<ffffffffa05dfcd6>] __cfg80211_ibss_joined+0x166/0x190 [cfg80211] Jan 28 22:29:21 melissa.gathman.org kernel: [<ffffffffa05bb02c>] cfg80211_process_wdev_events+0x8c/0x190 [cfg80211] Jan 28 22:29:21 melissa.gathman.org kernel: [<ffffffffa05bb162>] cfg80211_process_rdev_events+0x32/0x70 [cfg80211] Jan 28 22:29:21 melissa.gathman.org kernel: [<ffffffffa05b601e>] cfg80211_event_work+0x1e/0x30 [cfg80211] Jan 28 22:29:21 melissa.gathman.org kernel: [<ffffffff810b8cde>] process_one_work+0x19e/0x3f0 Jan 28 22:29:21 melissa.gathman.org kernel: [<ffffffff810b8f7e>] worker_thread+0x4e/0x450 Jan 28 22:29:21 melissa.gathman.org kernel: [<ffffffff810b8f30>] ? process_one_work+0x3f0/0x3f0 Jan 28 22:29:21 melissa.gathman.org kernel: [<ffffffff810bede8>] kthread+0xd8/0xf0 Jan 28 22:29:21 melissa.gathman.org kernel: [<ffffffff810bed10>] ? kthread_worker_fn+0x160/0x160 Jan 28 22:29:21 melissa.gathman.org kernel: [<ffffffff8178195f>] ret_from_fork+0x3f/0x70 Jan 28 22:29:21 melissa.gathman.org kernel: [<ffffffff810bed10>] ? kthread_worker_fn+0x160/0x160 Jan 28 22:29:21 melissa.gathman.org kernel: ---[ end trace 04ee7067960ce525 ]--- Jan 28 22:29:21 melissa.gathman.org kernel: batman_adv: bat0: Adding interface: wlp0s26u1u4

7 years, 1 month

[B.A.T.M.A.N.] [PATCH next 1/3] batman-adv: add missing kernel doc

by Marek Lindner

Fixes: 5c324517 ("ELP - compute the metric based on the estimated throughput") Signed-off-by: Marek Lindner <mareklindner(a)neomailbox.ch> --- net/batman-adv/bat_v_elp.c | 3 ++- net/batman-adv/main.h | 2 +- 2 files changed, 3 insertions(+), 2 deletions(-) diff --git a/net/batman-adv/bat_v_elp.c b/net/batman-adv/bat_v_elp.c index f257897..46c6a00 100644 --- a/net/batman-adv/bat_v_elp.c +++ b/net/batman-adv/bat_v_elp.c @@ -67,7 +67,8 @@ static void batadv_v_elp_start_timer(struct batadv_hard_iface *hard_iface) * batadv_v_elp_get_throughput - get the throughput towards a neighbour * @neigh: the neighbour for which the throughput has to be obtained * - * Return: the throughput towards the given neighbour. + * Return: The throughput towards the given neighbour in multiples of 100kpbs + * (a value of '10' equals to 1Mbps). */ static u32 batadv_v_elp_get_throughput(struct batadv_hardif_neigh_node *neigh) { diff --git a/net/batman-adv/main.h b/net/batman-adv/main.h index 7b05f68..db45336 100644 --- a/net/batman-adv/main.h +++ b/net/batman-adv/main.h @@ -62,7 +62,7 @@ #define BATADV_TQ_TOTAL_BIDRECT_LIMIT 1 /* B.A.T.M.A.N. V */ -#define BATADV_THROUGHPUT_DEFAULT_VALUE 10 +#define BATADV_THROUGHPUT_DEFAULT_VALUE 10 /* 1 Mbps */ #define BATADV_ELP_PROBES_PER_NODE 2 #define BATADV_ELP_MIN_PROBE_SIZE 200 /* bytes */ #define BATADV_ELP_PROBE_MAX_TX_DIFF 100 /* milliseconds */ -- 2.7.0

7 years, 1 month

2023

2022

2021

2020

2019

2018

2017

2016

2015

2014

2013

2012

2011

2010

2009

2008

2007

B.A.T.M.A.N February 2016