B.A.T.M.A.N October 2016

b.a.t.m.a.n@lists.open-mesh.org

17 participants
57 discussions

[B.A.T.M.A.N.] [PATCH v3 0/8] batman-adv: Support for complex compat patches
by Sven Eckelmann 24 Oct '16

24 Oct '16

Hi, here is the updated patchset to get complex compat patches support in batman- adv. The initial three patches of the last patchset [1] are already part of batman-adv.git next. This part is mostly about getting coccinelle/spatch to work. Changes in v3: - rebased to get it working on top of current master - use __genl_const for batadv_netlink_ops to keep it in ro memory for kernel >= 3.13 Kind regards, Sven [1] https://lists.open-mesh.org/pipermail/b.a.t.m.a.n/2016-October/016375.html

2 9

[B.A.T.M.A.N.] [PATCH v2 0/7] batman-adv: wifi interface detection on
by Sven Eckelmann 24 Oct '16

24 Oct '16

Hi, Marek created some patches a while ago to automatically detect the wifi interface under virtual interfaces like VLANs. These patches had some problems because they failed to correctly set the num_bcasts in these situations and also had some locking problems. The following patches try to address these by introducing a cache for the detected wifi configuration (wifi_flags which make taking the rtnl lock in critical section unnecessary) and by updating the num_bcast and wifi_flags when the interface behind iflink changes. * added patch "batman-adv: Return non-const ptr in batadv_getlink_net" * added patch "batman-adv: Close two alignment holes in batadv_hard_iface" * added patch "batman-adv: Cache the type of wifi device for each hardif" * added patch "batman-adv: Update wifi flags on upper link change" * introduced batadv_get_real_netdevice which can be used inside rtnl locked contexts * replaced wifi check functions with ones that use the wifi_flags cache * use batadv_getlink_net to get the iflink net_namespace * force rtnl_lock in batadv_get_real_netdev Kind regards, Sven Marek Lindner (3): batman-adv: refactor wifi interface detection batman-adv: additional checks for virtual interfaces on top of WiFi batman-adv: retrieve B.A.T.M.A.N. V WiFi neighbor stats from real interface Sven Eckelmann (4): batman-adv: Return non-const ptr in batadv_getlink_net batman-adv: Close two alignment holes in batadv_hard_iface batman-adv: Cache the type of wifi device for each hardif batman-adv: Update wifi flags on upper link change net/batman-adv/bat_iv_ogm.c | 2 +- net/batman-adv/bat_v_elp.c | 41 +++++---- net/batman-adv/hard-interface.c | 173 ++++++++++++++++++++++++++++++++++--- net/batman-adv/hard-interface.h | 5 +- net/batman-adv/translation-table.c | 10 ++- net/batman-adv/types.h | 21 ++++- 6 files changed, 217 insertions(+), 35 deletions(-)

2 8

[B.A.T.M.A.N.] [PATCH v3 1/3] batman-adv: Disallow mcast src address for data frames
by Sven Eckelmann 24 Oct '16

24 Oct '16

The routing checks are validating the source mac address of the outer ethernet header. They reject every source mac address which is a broadcast address. But they also have to reject and multicast mac addresses. Signed-off-by: Sven Eckelmann <sven(a)narfation.org> --- v3: - Fix patch subject v2: - clarify in commit message that only the outer ethernet header is affected (thanks Linus) - split in patch 1/2 - Allow zero mac address as source address in outer header as requested by Linus --- net/batman-adv/routing.c | 12 ++++++------ 1 file changed, 6 insertions(+), 6 deletions(-) diff --git a/net/batman-adv/routing.c b/net/batman-adv/routing.c index 610f2c4..913ab51 100644 --- a/net/batman-adv/routing.c +++ b/net/batman-adv/routing.c @@ -357,8 +357,8 @@ int batadv_recv_icmp_packet(struct sk_buff *skb, if (is_broadcast_ether_addr(ethhdr->h_dest)) goto out; - /* packet with broadcast sender address */ - if (is_broadcast_ether_addr(ethhdr->h_source)) + /* packet with broadcast/multicast sender address */ + if (is_multicast_ether_addr(ethhdr->h_source)) goto out; /* not for me */ @@ -449,8 +449,8 @@ static int batadv_check_unicast_packet(struct batadv_priv *bat_priv, if (is_broadcast_ether_addr(ethhdr->h_dest)) return -EBADR; - /* packet with broadcast sender address */ - if (is_broadcast_ether_addr(ethhdr->h_source)) + /* packet with broadcast/multicast sender address */ + if (is_multicast_ether_addr(ethhdr->h_source)) return -EBADR; /* not for me */ @@ -1091,8 +1091,8 @@ int batadv_recv_bcast_packet(struct sk_buff *skb, if (!is_broadcast_ether_addr(ethhdr->h_dest)) goto out; - /* packet with broadcast sender address */ - if (is_broadcast_ether_addr(ethhdr->h_source)) + /* packet with broadcast/multicast sender address */ + if (is_multicast_ether_addr(ethhdr->h_source)) goto out; /* ignore broadcasts sent by myself */ -- 2.8.1

2 3

i found time delay is very high and there are more caution info , if possible , please give me some advisement
by johnzeng 24 Oct '16

24 Oct '16

----------------------------- archlinux hostA _____________________________ ip link set mtu 1532 dev eth0 batctl if add eth0 ip link set up dev eth0 ip link set up dev bat0 ifconfig bat0 10.10.130.88 netmask 255.255.255.0 up ----------------------------- archlinux hostB _____________________________ ip link set mtu 1532 dev eth0 batctl if add eth0 ip link set up dev eth0 ip link set up dev bat0 ifconfig bat0 10.10.130.66 netmask 255.255.255.0 up my problem is : when i try to ping hostB from hostA i found time delay is very high and there are more caution info because i tested between ethernet network port ( i don't test in wifi port ) , whether it will master reason ? ethernet network use csma/cd ,but wifi use csma/ca , and ethernet network haven't mode ad-hoc . if possible , please give some advisement . Thanks again

3 10

Re: [B.A.T.M.A.N.] i found time delay is very high and there are more caution info , if possible , please give me some advisement
by Linus Lüssing 21 Oct '16

21 Oct '16

On Fri, Oct 21, 2016 at 04:31:20PM +0200, johnzeng via B.A.T.M.A.N wrote: > Date: Fri, 21 Oct 2016 22:31:00 +0800 > From: johnzeng <johnzeng2013(a)yahoo.com> > To: b.a.t.m.a.n(a)lists.open-mesh.org > Subject: i found time delay is very high and there are more caution info , > if possible , please give me some advisement If I remember correctly, then one typical issue for Arch Linux users was, that Arch compiles batman-adv with network-coding, even though it is marked as "Experimental". And that introduces high latency and/or packetloss. johnzeug, can you check whether network coding is enabled or disabled and if it is enabled, whether disabling helps? (batctl nc disable) And like Sven asked, what batman-adv version are you using. Not that long ago the network coding default was changed to disabled by default even if the module is compiled with NC. Maybe you run an older batman-adv release? Regards, Linus

1 0

Re: [B.A.T.M.A.N.] Add VLAN tag size to MTU recommendation?
by Linus Lüssing 21 Oct '16

21 Oct '16

On Fri, Oct 21, 2016 at 11:53:44AM +0800, Marek Lindner wrote: > > Hi, > > On Thursday, October 20, 2016 11:56:14 PM HKT Linus Lüssing wrote: > > First of all, just wanted to forward this awesome diagram > > regarding MTUs in Gluon-Setups which Freifunk Hamburg created > > > > :D : > > https://twitter.com/ohrensesselnet/status/789176399655350272 > > this link leads to a router pic ? > Found the diagram you were (probably) referring to by searching in his/her > tweetface history. Urgh, I'm very, very sorry, yes, I ment this one instead :( : https://twitter.com/ffhhnoc/status/787771192853798915 > > While checking the calculations Freifunk Hamburg did, I was > > wondering whether the batadv_hardif_min_mtu() function should add > > an extra 4 bytes for VLAN tagged, encapsulated payload to the MTU > > calculations and the kmesg recommendations > I am wondering whether we are trying to solve a problem that isn't a batman > problem. You could have any number of encapsulation interfaces on top of bat0 > (QinQ, GRE, etc) adding overhead. Do we reserve space for all these headers > too ? Hm, not quite sure whether it is 100% the same. While the problem is the same, for VLANs and GRE etc., in practice they behave a little different: When you have a network card with an MTU of 1500 bytes, then it usually works both with or without VLANs. And without fragmentation. GRE or other tunneling protocols don't have that property. And I'm wondering whether we should try to preserve such VLAN properties.

1 0

[B.A.T.M.A.N.] Add VLAN tag size to MTU recommendation?
by Linus Lüssing 20 Oct '16

20 Oct '16

Hi, First of all, just wanted to forward this awesome diagram regarding MTUs in Gluon-Setups which Freifunk Hamburg created :D : https://twitter.com/ohrensesselnet/status/789176399655350272 Which might be helpful for anyone new to understand how the encapsulation in batman-adv works and how the MTU recommendations of the underlying hard interfaces are calculated. (I need to ask Leo for the sources, maybe a version without the fastd overhead might be interesting for an MTU-explained page in the open-mesh.org wiki :)?) While checking the calculations Freifunk Hamburg did, I was wondering whether the batadv_hardif_min_mtu() function should add an extra 4 bytes for VLAN tagged, encapsulated payload to the MTU calculations and the kmesg recommendations, especially since Antonio's great work made TT fully VLAN-aware? Open-Mesh.com/Cloudtrax routers are using the VLAN awareness, right? Is the wifi interface MTU there just set to +4 bytes over the kmesg recommedation? Regards, Linus

1 0

[B.A.T.M.A.N.] [PATCH] batman-adv: compat: Substitute compat code for netlink constification
by Linus Lüssing 20 Oct '16

20 Oct '16

Substitutes the compat-patches approach for the netlink const changes to the prefered way of using compat-includes. Signed-off-by: Linus Lüssing <linus.luessing(a)c0d3.blue> --- compat-include/net/genetlink.h | 15 +++++++++++++-- 1 file changed, 13 insertions(+), 2 deletions(-) diff --git a/compat-include/net/genetlink.h b/compat-include/net/genetlink.h index 72a8991..b195b47 100644 --- a/compat-include/net/genetlink.h +++ b/compat-include/net/genetlink.h @@ -28,6 +28,15 @@ #include <linux/export.h> +/* multicast groups */ +enum __batadv_netlink_multicast_groups { + __BATADV_NL_MCGRP_TPMETER, +}; + +static struct genl_multicast_group __batadv_netlink_mcgrps[] = { + [__BATADV_NL_MCGRP_TPMETER] = { .name = BATADV_NL_MCAST_GROUP_TPMETER }, +}; + struct batadv_genl_family { /* data handled by the actual kernel */ struct genl_family family; @@ -140,12 +149,14 @@ static inline int batadv_genl_register_family(struct genl_family *family) static inline int batadv_genl_register_family_with_ops_grps(struct genl_family *family, struct genl_ops *ops, size_t n_ops, - struct genl_multicast_group *mcgrps, + const struct genl_multicast_group *mcgrps, size_t n_mcgrps) { + BUILD_BUG_ON(ARRAY_SIZE(__batadv_netlink_mcgrps) != n_mcgrps); + family->ops = ops; family->n_ops = n_ops; - family->mcgrps = mcgrps; + family->mcgrps = __batadv_netlink_mcgrps; family->n_mcgrps = n_mcgrps; family->module = THIS_MODULE; -- 2.1.4

2 5

[B.A.T.M.A.N.] [PATCH v5 1/2] batman-adv: Remove unused skb_reset_mac_header()
by Linus Lüssing 20 Oct '16

20 Oct '16

During broadcast queueing, the skb_reset_mac_header() sets the skb to a place invalid for a MAC header, pointing right into the batman-adv broadcast packet. Luckily, no one seems to actually use eth_hdr(skb) afterwards until batadv_send_skb_packet() resets the header to a valid position again. Therefore removing this unnecessary, weird skb_reset_mac_header() call. Reviewed-by: Sven Eckelmann <sven(a)narfation.org> Signed-off-by: Linus Lüssing <linus.luessing(a)c0d3.blue> --- Changes in v2-v5: * none net/batman-adv/send.c | 2 -- 1 file changed, 2 deletions(-) diff --git a/net/batman-adv/send.c b/net/batman-adv/send.c index 8d4e1f5..97bdb0c 100644 --- a/net/batman-adv/send.c +++ b/net/batman-adv/send.c @@ -586,8 +586,6 @@ int batadv_add_bcast_packet_to_list(struct batadv_priv *bat_priv, bcast_packet = (struct batadv_bcast_packet *)newskb->data; bcast_packet->ttl--; - skb_reset_mac_header(newskb); - forw_packet->skb = newskb; INIT_DELAYED_WORK(&forw_packet->delayed_work, -- 2.1.4

2 5

[B.A.T.M.A.N.] [PATCH v3 1/2] batman-adv: Remove unnecessary lockdep in batadv_mcast_mla_list_free
by Linus Lüssing 19 Oct '16

19 Oct '16

batadv_mcast_mla_list_free() just frees some leftovers of a local feast in batadv_mcast_mla_update(). No lockdep needed as it has nothing to do with bat_priv->mcast.mla_list. Fixes: 5b95c427d187 ("batman-adv: Annotate deleting functions with external lock via lockdep") Signed-off-by: Linus Lüssing <linus.luessing(a)c0d3.blue> Reviewed-by: Sven Eckelmann <sven(a)narfation.org> --- Changes in v3: * none Changes in v2: * none net/batman-adv/multicast.c | 8 ++------ 1 file changed, 2 insertions(+), 6 deletions(-) diff --git a/net/batman-adv/multicast.c b/net/batman-adv/multicast.c index 13661f4..45757fa 100644 --- a/net/batman-adv/multicast.c +++ b/net/batman-adv/multicast.c @@ -231,19 +231,15 @@ out: /** * batadv_mcast_mla_list_free - free a list of multicast addresses - * @bat_priv: the bat priv with all the soft interface information * @mcast_list: the list to free * * Removes and frees all items in the given mcast_list. */ -static void batadv_mcast_mla_list_free(struct batadv_priv *bat_priv, - struct hlist_head *mcast_list) +static void batadv_mcast_mla_list_free(struct hlist_head *mcast_list) { struct batadv_hw_addr *mcast_entry; struct hlist_node *tmp; - lockdep_assert_held(&bat_priv->tt.commit_lock); - hlist_for_each_entry_safe(mcast_entry, tmp, mcast_list, list) { hlist_del(&mcast_entry->list); kfree(mcast_entry); @@ -560,7 +556,7 @@ update: batadv_mcast_mla_tt_add(bat_priv, &mcast_list); out: - batadv_mcast_mla_list_free(bat_priv, &mcast_list); + batadv_mcast_mla_list_free(&mcast_list); } /** -- 2.1.4

2 4

2024

2023

2022

2021

2020

2019

2018

2017

2016

2015

2014

2013

2012

2011

2010

2009

2008

2007

B.A.T.M.A.N October 2016