B.A.T.M.A.N September 2014

b.a.t.m.a.n@lists.open-mesh.org

10 participants
33 discussions

[B.A.T.M.A.N.] new alfred packet type *3* for solar tracer charging units
by Ufo 10 Oct '14

10 Oct '14

at Solarfestival in Germany we were reverse engineering some solar tracer charge controllers. so they were part of the local wifi mesh https://twitter.com/rundfreifunk/status/502788487549288448 https://twitter.com/rundfreifunk/status/503888938973802496 https://twitter.com/rundfreifunk/status/503942726292103168 best way for distributing the detailed data (about local sun impact..) was alfred. we used nr. 160 but now simon choosed nr. 3 for that. https://twitter.com/rundfreifunk/status/503548243452899328 so, plug your solar systems into your mesh-nodes! https://twitter.com/rundfreifunk/status/503875891735560192 https://twitter.com/rundfreifunk/status/504575102965792768 greetings, ufo p.s. code: https://gitorious.org/tracertools/pages/Home p.p.s. anyone with CRC expierence?? please! we need help with that dump CRC, please have a look if there is a new idea about used crc http://pad.freifunk.net/p/solartracer -- --- Freifunk Leipzig http://leipzig.freifunk.net

3 4

[B.A.T.M.A.N.] QoS in BATMAN-adv
by Krishnathiepan Rasanayagam 02 Oct '14

02 Oct '14

Hi All, We are currently doing research on QoS services provided in MANETs using batman-adv protocol. We want to know are there any similar projects had been done before this in this area. And does any one have knows is there an alternative in batman-adv for nbar of Cisco. -- Best regards, Krishna.

3 5

[B.A.T.M.A.N.] traceroute help
by Krishnathiepan Rasanayagam 28 Sep '14

28 Sep '14

dear all, do we have to follow different way than batctl 2012 version when we are using batctl traceroute 2014 ? I'm getting an error when trying to use batctl commands. -- Best regards, Krishna.

3 3

[B.A.T.M.A.N.] Publishing on official page of batman-adv
by Krishnathiepan Rasanayagam 23 Sep '14

23 Sep '14

hello all, Does any of you know post a research paper regarding batman-adv in their official page. we are currently working on QOS in batman-adv and will be publishing our paper soon and we think and helpful for others who wanna continue our research it'll be nice if we can post our statistics along with software details on official page. How can you do it, whom we have to contact.. -- cheers routing, Krishna.

2 1

[B.A.T.M.A.N.] [PATCH maint] batman-adv: avoid NULL dereferences and clarify if check
by Antonio Quartulli 20 Sep '14

20 Sep '14

Due to a typ0 in an if-condition used in the gateway-client code it is possible to run in a NULL pointer dereference. At the same type the same if-condition is not clear. Fix this by rewriting the if-condition properly. Introduced by 0853ec7fafe0a195754454832993c6b35e22b842 ("batman-adv: tvlv - gateway download/upload bandwidth container") Signed-off-by: Antonio Quartulli <antonio(a)meshcoding.com> Reported-by: David Binderman <dcb314(a)hotmail.com> --- gateway_client.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/gateway_client.c b/gateway_client.c index bcc3e0c..5f09536 100644 --- a/gateway_client.c +++ b/gateway_client.c @@ -811,7 +811,7 @@ bool batadv_gw_out_of_range(struct batadv_priv *bat_priv, goto out; gw_node = batadv_gw_node_get(bat_priv, orig_dst_node); - if (!gw_node->bandwidth_down == 0) + if (!gw_node || (gw_node->bandwidth_down == 0)) goto out; switch (atomic_read(&bat_priv->gw_mode)) { -- 1.8.5.5

1 1

[B.A.T.M.A.N.] IBSS key in batman-adv
by Zaki 17 Sep '14

17 Sep '14

Hi, I have a short question. I am using IBSS to create batman-adv mesh network. To secure the IBSS, i am using the IBSS key. I noticed that when i am on the mesh network, any device that is not having the key also can ping and iperf to me. I thought IBSS key is supposed to allow only legitimate device. Does anybody know where i do wrong here?. Rgds, Zack.

2 2

[B.A.T.M.A.N.] [PATCH] batman-adv: clear control block of received socket buffers
by Martin Hundebøll 17 Sep '14

17 Sep '14

Since other network components (and some drivers) uses the control block provided in skb's, the network coding feature might wrongly assume that an SKB has been decoded, and thus not try to code it with another packet again. This happens for instance when batman-adv is running on a bridge device. Fix this by clearing the control block for every received SKB. Signed-off-by: Martin Hundebøll <martin(a)hundeboll.net> --- main.c | 3 +++ 1 file changed, 3 insertions(+) diff --git a/main.c b/main.c index 2cdd25a..61e3ffd 100644 --- a/main.c +++ b/main.c @@ -403,6 +403,9 @@ int batadv_batman_skb_recv(struct sk_buff *skb, struct net_device *dev, goto err_free; } + /* reset control block to avoid left overs from previous users */ + memset(skb->cb, 0, sizeof(struct batadv_skb_cb)); + /* all receive handlers return whether they received or reused * the supplied skb. if not, we have to free the skb. */ -- 2.1.0

2 1

[B.A.T.M.A.N.] [PATCH 09/22] batman-adv: Replace strnicmp with strncasecmp
by Rasmus Villemoes 17 Sep '14

17 Sep '14

The kernel used to contain two functions for length-delimited, case-insensitive string comparison, strnicmp with correct semantics and a slightly buggy strncasecmp. The latter is the POSIX name, so strnicmp was renamed to strncasecmp, and strnicmp made into a wrapper for the new strncasecmp to avoid breaking existing users. To allow the compat wrapper strnicmp to be removed at some point in the future, and to avoid the extra indirection cost, do s/strnicmp/strncasecmp/g. Cc: Marek Lindner <mareklindner(a)neomailbox.ch> Cc: b.a.t.m.a.n(a)lists.open-mesh.org Cc: netdev(a)vger.kernel.org Signed-off-by: Rasmus Villemoes <linux(a)rasmusvillemoes.dk> --- net/batman-adv/gateway_common.c | 8 ++++---- 1 file changed, 4 insertions(+), 4 deletions(-) diff --git a/net/batman-adv/gateway_common.c b/net/batman-adv/gateway_common.c index 6f5e621..88a1bc3 100644 --- a/net/batman-adv/gateway_common.c +++ b/net/batman-adv/gateway_common.c @@ -44,10 +44,10 @@ static bool batadv_parse_gw_bandwidth(struct net_device *net_dev, char *buff, if (strlen(buff) > 4) { tmp_ptr = buff + strlen(buff) - 4; - if (strnicmp(tmp_ptr, "mbit", 4) == 0) + if (strncasecmp(tmp_ptr, "mbit", 4) == 0) bw_unit_type = BATADV_BW_UNIT_MBIT; - if ((strnicmp(tmp_ptr, "kbit", 4) == 0) || + if ((strncasecmp(tmp_ptr, "kbit", 4) == 0) || (bw_unit_type == BATADV_BW_UNIT_MBIT)) *tmp_ptr = '\0'; } @@ -77,10 +77,10 @@ static bool batadv_parse_gw_bandwidth(struct net_device *net_dev, char *buff, if (strlen(slash_ptr + 1) > 4) { tmp_ptr = slash_ptr + 1 - 4 + strlen(slash_ptr + 1); - if (strnicmp(tmp_ptr, "mbit", 4) == 0) + if (strncasecmp(tmp_ptr, "mbit", 4) == 0) bw_unit_type = BATADV_BW_UNIT_MBIT; - if ((strnicmp(tmp_ptr, "kbit", 4) == 0) || + if ((strncasecmp(tmp_ptr, "kbit", 4) == 0) || (bw_unit_type == BATADV_BW_UNIT_MBIT)) *tmp_ptr = '\0'; } -- 2.0.4

2 1

[B.A.T.M.A.N.] Creating route in batman
by Krishnathiepan Rasanayagam 16 Sep '14

16 Sep '14

hi all, Is there any way to crate a static route in batman-adv algorithm. Like telling other nodes to avoid a certain node. -- Best regards, Krishna.

3 2

Re: [B.A.T.M.A.N.] Fw: [Bug 84061] New: net/batman-adv/gateway_client.c:813: missing sanity check and dodgy coding ?
by Antonio Quartulli 09 Sep '14

09 Sep '14

forwarding to the batman-adv mailing list and commenting inline. On 09/09/14 02:30, Stephen Hemminger wrote: > > > Begin forwarded message: > > Date: Mon, 8 Sep 2014 00:04:40 -0700 > From: "bugzilla-daemon(a)bugzilla.kernel.org" <bugzilla-daemon(a)bugzilla.kernel.org> > To: "stephen(a)networkplumber.org" <stephen(a)networkplumber.org> > Subject: [Bug 84061] New: net/batman-adv/gateway_client.c:813: missing sanity check and dodgy coding ? > > > https://bugzilla.kernel.org/show_bug.cgi?id=84061 > > Bug ID: 84061 > Summary: net/batman-adv/gateway_client.c:813: missing sanity > check and dodgy coding ? > Product: Networking > Version: 2.5 > Kernel Version: 3.17-rc4 > Hardware: All > OS: Linux > Tree: Mainline > Status: NEW > Severity: normal > Priority: P1 > Component: Other > Assignee: shemminger(a)linux-foundation.org > Reporter: dcb314(a)hotmail.com > Regression: No > > net/batman-adv/gateway_client.c:813:31: warning: logical not is only applied to > the left hand side of comparison [-Wlogical-not-parentheses] > > gw_node = batadv_gw_node_get(bat_priv, orig_dst_node); > if (!gw_node->bandwidth_down == 0) > goto out; I think this was meant to be: if (!gw_node || (gw_node->bandwidth_down == 0)) > > Function batadv_gw_node_get can return NULL, so there's > a missing sanity check there and maybe the if condition > can be reworked for clarity. > -- Antonio Quartulli

1 0

2024

2023

2022

2021

2020

2019

2018

2017

2016

2015

2014

2013

2012

2011

2010

2009

2008

2007

B.A.T.M.A.N September 2014