B.A.T.M.A.N August 2014

b.a.t.m.a.n@lists.open-mesh.org

13 participants
43 discussions

[B.A.T.M.A.N.] [PATCH] batman-adv: remove obsolete variable primary_iface from orig_node
by Simon Wunderlich 11 Aug '14

11 Aug '14

This variable became obsolete when changing to the new bonding mechanism based on the multi interface optimization. Since its not used anywhere, remove it. Reported-by: Linus Lüssing <linus.luessing(a)web.de> Signed-off-by: Simon Wunderlich <sw(a)simonwunderlich.de> --- types.h | 2 -- 1 file changed, 2 deletions(-) diff --git a/types.h b/types.h index 8854c05..462a70c 100644 --- a/types.h +++ b/types.h @@ -199,7 +199,6 @@ struct batadv_orig_bat_iv { /** * struct batadv_orig_node - structure for orig_list maintaining nodes of mesh * @orig: originator ethernet address - * @primary_addr: hosts primary interface address * @ifinfo_list: list for routers per outgoing interface * @last_bonding_candidate: pointer to last ifinfo of last used router * @batadv_dat_addr_t: address of the orig node in the distributed hash @@ -244,7 +243,6 @@ struct batadv_orig_bat_iv { */ struct batadv_orig_node { uint8_t orig[ETH_ALEN]; - uint8_t primary_addr[ETH_ALEN]; struct hlist_head ifinfo_list; struct batadv_orig_ifinfo *last_bonding_candidate; #ifdef CONFIG_BATMAN_ADV_DAT -- 1.9.1

2 1

[B.A.T.M.A.N.] [PATCH] batman-adv: avoid useless return in void functions
by Antonio Quartulli 11 Aug '14

11 Aug '14

Cc: Linus Lüssing <linus.luessing(a)web.de> Signed-off-by: Antonio Quartulli <antonio(a)meshcoding.com> --- multicast.h | 3 --- 1 file changed, 3 deletions(-) diff --git a/multicast.h b/multicast.h index 73b5d45..3a44ebd 100644 --- a/multicast.h +++ b/multicast.h @@ -50,7 +50,6 @@ void batadv_mcast_purge_orig(struct batadv_orig_node *orig_node); static inline void batadv_mcast_mla_update(struct batadv_priv *bat_priv) { - return; } static inline enum batadv_forw_mode @@ -67,12 +66,10 @@ static inline int batadv_mcast_init(struct batadv_priv *bat_priv) static inline void batadv_mcast_free(struct batadv_priv *bat_priv) { - return; } static inline void batadv_mcast_purge_orig(struct batadv_orig_node *orig_node) { - return; } #endif /* CONFIG_BATMAN_ADV_MCAST */ -- 1.8.5.5

2 1

[B.A.T.M.A.N.] [PATCH] batctl: Don't use hyphen for parameter in manpage
by Sven Eckelmann 11 Aug '14

11 Aug '14

By default, "-" chars are interpreted as hyphens (U+2010) by groff, not as minus signs (U+002D). Since options to programs use minus signs (U+002D), this means for example in UTF-8 locales that you cannot cut and paste options, nor search for them easily. Signed-off-by: Sven Eckelmann <sven(a)narfation.org> --- man/batctl.8 | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/man/batctl.8 b/man/batctl.8 index 110020e..bbe888c 100644 --- a/man/batctl.8 +++ b/man/batctl.8 @@ -61,7 +61,7 @@ originator interval. The interval is in units of milliseconds. .br .IP "\fBap_isolation\fP|\fBap\fP [\fB0\fP|\fB1\fP]" If no parameter is given the current ap isolation setting is displayed. Otherwise the parameter is used to enable or -disable ap isolation. This command can be used in conjunction with "-m" option to target per VLAN configurations. +disable ap isolation. This command can be used in conjunction with "\-m" option to target per VLAN configurations. .br .IP "\fBbridge_loop_avoidance\fP|\fBbl\fP [\fB0\fP|\fB1\fP]" If no parameter is given the current bridge loop avoidance setting is displayed. Otherwise the parameter is used to enable -- 2.0.1

2 1

[B.A.T.M.A.N.] [PATCH] batctl: fix backbone address in tcpdump for bla request frames
by Simon Wunderlich 11 Aug '14

11 Aug '14

From: Simon Wunderlich <simon(a)open-mesh.com> hw_src just contains another copy of the destination. The backbone sending the request is setting its mac address into Ethernet source, so print that instead. For reference, see the documentation: http://www.open-mesh.org/projects/batman-adv/wiki/Bridge-loop-avoidance-Pro… Signed-off-by: Simon Wunderlich <simon(a)open-mesh.com> --- tcpdump.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/tcpdump.c b/tcpdump.c index e84617e..ada8938 100644 --- a/tcpdump.c +++ b/tcpdump.c @@ -148,7 +148,7 @@ static int dump_bla2_claim(struct ether_header *eth_hdr, break; case BATADV_CLAIM_TYPE_REQUEST: printf("BLA REQUEST, src backbone %s, ", - get_name_by_macaddr((struct ether_addr *)hw_src, read_opt)); + get_name_by_macaddr((struct ether_addr *)eth_hdr->ether_shost, read_opt)); printf("dst backbone %s\n", get_name_by_macaddr((struct ether_addr *)eth_hdr->ether_dhost, read_opt)); break; -- 1.9.1

2 1

[B.A.T.M.A.N.] how to make IP layer handle the change of network topology
by liudows 08 Aug '14

08 Aug '14

Hello, eveyone, I am learning the batman.adv recently. We know that batman.adv works on layer 2. When the network topology change, batman.adv can know this change and handle it. But the IP layer doesn't know that. How to make IP layer handle the change of network topology? For example, I have 3 mesh nodes, client node A, gateway node B and geteway node C. A connects to internet via B. Then I shutdown B. I guess A will switch to C as it's gateway node automatically. But it's not so. A continuously send the ARP request packet to search the MAC address of B. The default gateway is still B, not C. So, how should I do to make the IP layer be aware of that the gateway has swithed to another one? Thanks! Best regards. liu

4 6

[B.A.T.M.A.N.] [PATCHv6 0/3] Multicast optimizations for bridges
by Linus Lüssing 07 Aug '14

07 Aug '14

This patchset enables the usage of the batman-adv multicast optimizations for scenarios involving bridges on top of e.g. bat0, too. Along come two more patches adding according debugging facilities to make it possible for the user to check why the multicast optimizations might not work ideally to give hints about what they might change about their topology. Cheers, Linus Changes in v6: * New PATCH 2/3 inserted, moving logging to separate patch * More verbose logging added to PATCH 2/3: Bridge and querier state changes are logged too * upper case to lower case for kernel doc of batadv_mcast_flags_open (PATCH 2/3) * Adding note to kernel doc of batadv_mcast_get_bridge about increased refcount (PATCH 1/3) * Printing some lines about current bridge and querier state to debugfs too (PATCH 3/3) Changes in v5 (PATCH 2/2 only): * s/dat_cache/mcast_flags/ in kerneldoc (copy&paste error) Changes in v4 (PATCH 2/2 only): * initial {ad,e}dition of this patch Changes in v3 (PATCH 1/2 only): * Removed "RFC" tag in title again: The stubs and new export are upstream in net-next and therefore going to be included in 3.17 * Added some debug output: * Two warning messages: -> Old kernel version or no bridge IGMP/MLD snooping compiled * New batman-adv log-level "mcast": -> Logging mcast flag changes (a third debugging facility, a new table for debugfs for a global mcast flag overview will be added in a separate patch later as discussed with Simon) Changes in v2 (PATCH 1/2 only): * fetching local (= on this same kernel) multicast listeners from the bridge instead of the bat0 interface if a bridge is present - just like ip addresses and routes should be used from br0, the same goes for multicast listeners * beautification of batadv_mcast_mla_br_addr_cpy(), now using already present functions from the kernel instead of own, hackish approach * changed names of some goto-labels (not using "skip" anymore) * using new, third bridge multicast export (because this export is not upstream yet, I've added the "RFC" in the title): br_multicast_has_querier_anywhere() * adding compat stubs for two bridge multicast exports, to make batman-adv compile- and usable even if a 3.16 kernel was compiled without bridge code - the stubs are supposed to be upstream in the bridge code in 3.17 (therefore just 'compat') * updated kerneldocs for batadv_mcast_mla_bridge_get() and batadv_mcast_mla_softif_get() * The two sentences in the commit message starting with "Queriers: ..." were slightly modified to include the third bridge multicast export

2 5

[B.A.T.M.A.N.] Running alfred as non-root user?
by Jan Lühr 07 Aug '14

07 Aug '14

Hello, everytime I try to start alfred 2014.3.0 using a dedicated non-root user it fails with: can't bind unix socket: Address already in use Running as root is successful. Is it possible to start alfred as non-root? Thanks, Jan

2 1

[B.A.T.M.A.N.] alfred: IPC issues
by Jan Lühr 07 Aug '14

07 Aug '14

Hei folks, I'm using alfred 2014.0.0 on OpenWRT Barrier Breaker. Alfred is running: root@6466b34ffcac:~# ps -w | grep alfred 1718 root 1100 S /usr/sbin/alfred -i br-freifunk -b bat0 But cannot be queried using the client: root@6466b34ffcac:~# alfred -r 94 can't connect to unix socket: Connection refused What's wrong here? Configuration is config 'alfred' 'alfred' option interface 'br-freifunk' option mode 'server' option batmanif 'bat0' option start_vis '0' option run_facters '0' Thanks, Keep smiling yanosz

3 4

[B.A.T.M.A.N.] [PATCH net 2/3] batman: fix duplicate #include of multicast.h
by Jean Sacren 07 Aug '14

07 Aug '14

The header multicast.h was included twice, so delete one of them. Signed-off-by: Jean Sacren <sakiwit(a)gmail.com> Cc: Marek Lindner <mareklindner(a)neomailbox.ch> Cc: Simon Wunderlich <sw(a)simonwunderlich.de> Cc: Antonio Quartulli <antonio(a)meshcoding.com> Cc: b.a.t.m.a.n(a)lists.open-mesh.org --- net/batman-adv/multicast.c | 1 - 1 file changed, 1 deletion(-) diff --git a/net/batman-adv/multicast.c b/net/batman-adv/multicast.c index 96b66fd30f96..ab6bb2af1d45 100644 --- a/net/batman-adv/multicast.c +++ b/net/batman-adv/multicast.c @@ -19,9 +19,8 @@ #include "multicast.h" #include "originator.h" #include "hard-interface.h" #include "translation-table.h" -#include "multicast.h" /** * batadv_mcast_mla_softif_get - get softif multicast listeners * @dev: the device to collect multicast addresses from

1 0

[B.A.T.M.A.N.] pull request: batman-adv 2014-08-05
by Antonio Quartulli 05 Aug '14

05 Aug '14

Hello David, this is a pull request intended for net-next/linux-3.17 (yeah..it's really late). Patches 1, 2 and 4 are really minor changes: - kmalloc_array is substituted to kmalloc when possible (as suggested by checkpatch); - net_ratelimited() is now used properly and the "suppressed" message is not printed anymore if not needed; - the internal version number has been increased to reflect our current version. Patch 3 instead is introducing a change in the metric computation function by changing the penalty applied at each mesh hop from 15/255 (~6%) to 30/255 (~11%). This change is introduced by Simon Wunderlich after having observed a performance improvement in several networks when using the new value. Please pull or let me know of any problem! Thanks a lot, Antonio The following changes since commit e6b92c25d20c64c271ef429bba8febeefb848b5b: cxgb4i : remove spurious use of rcu (2014-08-02 20:34:33 -0700) are available in the git repository at: git://git.open-mesh.org/linux-merge.git tags/batman-adv-for-davem for you to fetch changes up to 0028c72ec4300997f2d0b73594f391983090463b: batman-adv: Start new development cycle (2014-08-04 16:03:13 +0200) ---------------------------------------------------------------- Included changes: - kmalloc_array instead of kmalloc when possible - avoid log spam due to useless net_ratelimit() invocations - increase default metric hop penalty from 15 to 30 - update internal version number ---------------------------------------------------------------- André Gaul (1): batman-adv: remove unnecessary logspam Antonio Quartulli (1): batman-adv: prefer kmalloc_array to kmalloc when possible Simon Wunderlich (2): batman-adv: increase default hop penalty batman-adv: Start new development cycle net/batman-adv/bat_iv_ogm.c | 13 +++++++------ net/batman-adv/distributed-arp-table.c | 3 ++- net/batman-adv/hash.c | 6 +++--- net/batman-adv/main.h | 22 +++++++++++++++------- net/batman-adv/routing.c | 18 +++++++++--------- net/batman-adv/soft-interface.c | 2 +- 6 files changed, 37 insertions(+), 27 deletions(-)

2 5

2024

2023

2022

2021

2020

2019

2018

2017

2016

2015

2014

2013

2012

2011

2010

2009

2008

2007

B.A.T.M.A.N August 2014