B.A.T.M.A.N February 2014

b.a.t.m.a.n@lists.open-mesh.org

25 participants
68 discussions

[B.A.T.M.A.N.] How to send message/execute script on clients from Gateway?
by Le Tran Dat 06 Feb '14

06 Feb '14

Hi, I would like to know if batman adv [2013.2.0] supports a way to send/receive message between gateway and client? I have setup a mesh network which has 1 gateway and several clients. I want to broadcast a message to all the clients from the gateway. The message might contain one more many parameters that I want all clients will use these parameters for their configuration. It would be very convenience if I could execute a script remotely on clients from the gateway via batman adv without knowing their IP address. Thanks, Dat

1 0

[B.A.T.M.A.N.] [PATCH] batman-adv: fix potential orig_node reference leak
by Simon Wunderlich 05 Feb '14

05 Feb '14

Since batadv_orig_node_new() does not add the originator into the orig hash, it should only return the created orig_node object with a refcount of one (for the object return). Otherwise batadv_iv_ogm_orig_get() will not free the orig_node correctly when allocating its private structures or adding to the hash fails (refcount will just be decreased to one) and eventually leak it. Reported-by: Antonio Quartulli <antonio(a)meshcoding.com> Signed-off-by: Simon Wunderlich <sw(a)simonwunderlich.de> --- bat_iv_ogm.c | 8 +++++++- originator.c | 3 +-- 2 files changed, 8 insertions(+), 3 deletions(-) diff --git a/bat_iv_ogm.c b/bat_iv_ogm.c index 7cf26bc..10acd39 100644 --- a/bat_iv_ogm.c +++ b/bat_iv_ogm.c @@ -243,11 +243,17 @@ batadv_iv_ogm_orig_get(struct batadv_priv *bat_priv, const uint8_t *addr) if (!orig_node->bat_iv.bcast_own_sum) goto free_bcast_own; + /* increase refcount for the hash reference */ + if (atomic_inc_not_zero(&orig_node->refcount)) + goto free_bcast_own; + hash_added = batadv_hash_add(bat_priv->orig_hash, batadv_compare_orig, batadv_choose_orig, orig_node, &orig_node->hash_entry); - if (hash_added != 0) + if (hash_added != 0) { + batadv_orig_node_free_ref(orig_node); goto free_bcast_own; + } return orig_node; diff --git a/originator.c b/originator.c index c4d16e5..c308367 100644 --- a/originator.c +++ b/originator.c @@ -625,8 +625,7 @@ struct batadv_orig_node *batadv_orig_node_new(struct batadv_priv *bat_priv, batadv_nc_init_orig(orig_node); - /* extra reference for return */ - atomic_set(&orig_node->refcount, 2); + atomic_set(&orig_node->refcount, 1); orig_node->tt_initialised = false; orig_node->bat_priv = bat_priv; -- 1.7.10.4

1 0

[B.A.T.M.A.N.] When will BATMAN be available on stock android devices?
by crocket 05 Feb '14

05 Feb '14

If people have to root android, not many people will use BATMAN. When do you guys think it will be available on off-the-shelf android devices?

4 5

[B.A.T.M.A.N.] Basic Multicast Optimizations
by Linus Lüssing 04 Feb '14

04 Feb '14

This is the twelfth revision of the basic multicast optimization patches. Changes in v12 include (thanks for the feedback again, Marek and Simon): * added three reserved bytes to the mcast TVLV container to have a four bytes alignment (thanks Simon) * Return value description in kernel docs for batadv_mcast_mla_tvlv_update added (thanks Marek) * Using eth_hdr() instead of skb->data in various places (thanks Marek) * Switched order of function parameters bat_priv and skb in various places for style consistency reasons (thanks Marek) * renamed one occurence of "BATMAN_IV" to "BATMAN" (thanks Marek) * kerneldoc for multicast_mode added (thanks Marek) * rebased on top of master * now that batadv_tt_local_add() has a potential failure case, a check for its return value was added For Marek's question on gateway code interoperability, I reread that part and couldn't find any issues with it either. Moreover, any additional dhcp_rcp variable check seemed redundant to me, so I left that part as is. Cheers, Linus

3 9

[B.A.T.M.A.N.] question about min_t() casting in batadv_hardif_min_mtu()
by Dan Carpenter 03 Feb '14

03 Feb '14

Hello Batman devs, I always worry when I see people do min_t(int, foo, bar) and there are a couple cases which concern me in batman. Changing the mtu is allowed for people who have admin rights in their namespace. In other words we check: if (!ns_capable(net->user_ns, CAP_NET_ADMIN)) as opposed to: if (!capable(net->user_ns, CAP_NET_ADMIN)) So mtu has security implications. net/batman-adv/hard-interface.c 240 int batadv_hardif_min_mtu(struct net_device *soft_iface) 241 { 242 struct batadv_priv *bat_priv = netdev_priv(soft_iface); 243 const struct batadv_hard_iface *hard_iface; 244 int min_mtu = ETH_DATA_LEN; 245 246 rcu_read_lock(); 247 list_for_each_entry_rcu(hard_iface, &batadv_hardif_list, list) { 248 if ((hard_iface->if_status != BATADV_IF_ACTIVE) && 249 (hard_iface->if_status != BATADV_IF_TO_BE_ACTIVATED)) 250 continue; 251 252 if (hard_iface->soft_iface != soft_iface) 253 continue; 254 255 min_mtu = min_t(int, hard_iface->net_dev->mtu, min_mtu); ^^^ Ok. This is fine because dev_set_mtu() will not allow negative mtus. 256 } 257 rcu_read_unlock(); 258 259 atomic_set(&bat_priv->packet_size_max, min_mtu); 260 261 if (atomic_read(&bat_priv->fragmentation) == 0) 262 goto out; 263 264 /* with fragmentation enabled the maximum size of internally generated 265 * packets such as translation table exchanges or tvlv containers, etc 266 * has to be calculated 267 */ 268 min_mtu = min_t(int, min_mtu, BATADV_FRAG_MAX_FRAG_SIZE); ^^^ Still fine. 269 min_mtu -= sizeof(struct batadv_frag_packet); ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ I worry that this could be negative. 270 min_mtu *= BATADV_FRAG_MAX_FRAGMENTS; 271 atomic_set(&bat_priv->packet_size_max, min_mtu); ^^^^^^^ Could a negative cause problems here? 272 273 /* with fragmentation enabled we can fragment external packets easily */ 274 min_mtu = min_t(int, min_mtu, ETH_DATA_LEN); ^^^^^^^ min_mtu would still be negative here. 275 276 out: 277 return min_mtu - batadv_max_header_len(); 278 } regards, dan carpenter

2 2

[B.A.T.M.A.N.] [PATCH maint] batman-adv: remove useless assignment
by Antonio Quartulli 02 Feb '14

02 Feb '14

Introduced by 41b38727749a94c1a65cf0f4be9bfe1cbaf0adeb ("batman-adv: fix potential kernel paging error for unicast transmissions") Signed-off-by: Antonio Quartulli <antonio(a)meshcoding.com> --- send.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/send.c b/send.c index 2035bd9..75be770 100644 --- a/send.c +++ b/send.c @@ -256,7 +256,7 @@ static int batadv_send_skb_unicast(struct batadv_priv *bat_priv, struct batadv_orig_node *orig_node, unsigned short vid) { - struct ethhdr *ethhdr = (struct ethhdr *)skb->data; + struct ethhdr *ethhdr; struct batadv_unicast_packet *unicast_packet; int ret = NET_XMIT_DROP; -- 1.8.5.3

2 1

[B.A.T.M.A.N.] [PATCH maint] batman-adv: properly check pskb_may_pull return value
by Antonio Quartulli 02 Feb '14

02 Feb '14

pskb_may_pull() returns 1 on success and 0 in case of failure, therefore checking for the return value being negative does not make sense at all. Fix this by doing the proper check. Signed-off-by: Antonio Quartulli <antonio(a)meshcoding.com> --- routing.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/routing.c b/routing.c index f28920f..f7579d0 100644 --- a/routing.c +++ b/routing.c @@ -833,7 +833,7 @@ static int batadv_check_unicast_ttvn(struct batadv_priv *bat_priv, int is_old_ttvn; /* check if there is enough data before accessing it */ - if (pskb_may_pull(skb, hdr_len + ETH_HLEN) < 0) + if (!pskb_may_pull(skb, hdr_len + ETH_HLEN)) return 0; /* create a copy of the skb (in case of for re-routing) to modify it. */ -- 1.8.5.3

2 2

[B.A.T.M.A.N.] [PATCH next] batctl: switch to net/if.h include to make OpenWrt build happy
by Marek Lindner 02 Feb '14

02 Feb '14

Signed-off-by: Sven Eckelmann <sven(a)narfation.org> Signed-off-by: Marek Lindner <mareklindner(a)neomailbox.ch> --- ioctl.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/ioctl.c b/ioctl.c index eccac66..1f827e8 100644 --- a/ioctl.c +++ b/ioctl.c @@ -25,10 +25,10 @@ #include <stdlib.h> #include <string.h> #include <unistd.h> +#include <net/if.h> #include <sys/ioctl.h> #include <sys/types.h> #include <sys/socket.h> -#include <linux/if.h> #include <linux/sockios.h> #include <linux/ethtool.h> #include <stdint.h> -- 1.8.5.3

1 1

2024

2023

2022

2021

2020

2019

2018

2017

2016

2015

2014

2013

2012

2011

2010

2009

2008

2007

B.A.T.M.A.N February 2014