Name in declaration does not reflect the one reporte din the kernel doc.
Moreover a variable storing an enum should be of type enum rather than
int (this helps the compiler to spott possible mistakes)
Introduced by 0853ec7fafe0a195754454832993c6b35e22b842
("batman-adv: tvlv - gateway download/upload bandwidth container")
Signed-off-by: Antonio Quartulli <antonio(a)meshcoding.com>
---
gateway_common.c | 3 ++-
gateway_common.h | 2 +-
2 files changed, 3 insertions(+), 2 deletions(-)
diff --git a/gateway_common.c b/gateway_common.c
index ab9a5ac..b211b0f 100644
--- a/gateway_common.c
+++ b/gateway_common.c
@@ -34,9 +34,10 @@
static bool batadv_parse_gw_bandwidth(struct net_device *net_dev, char *buff,
uint32_t *down, uint32_t *up)
{
- int ret, bw_unit_type = BATADV_BW_UNIT_KBIT;
+ enum batadv_bandwidth_units bw_unit_type = BATADV_BW_UNIT_KBIT;
char *slash_ptr, *tmp_ptr;
long ldown, lup;
+ int ret;
slash_ptr = strchr(buff, '/');
if (slash_ptr)
diff --git a/gateway_common.h b/gateway_common.h
index 368d50e..56384a4 100644
--- a/gateway_common.h
+++ b/gateway_common.h
@@ -31,7 +31,7 @@ enum batadv_gw_modes {
* @BATADV_BW_UNIT_KBIT: unit type kbit
* @BATADV_BW_UNIT_MBIT: unit type mbit
*/
-enum batadv_bandwidth_types {
+enum batadv_bandwidth_units {
BATADV_BW_UNIT_KBIT,
BATADV_BW_UNIT_MBIT,
};
--
1.8.1.5
Only network-coding.h is using "return;" inside void stub
functions. This is not a consistent with the rest of the code,
therefore don't continue to do as such.
(Other stub functions will be cleaned later)
Introduced by 7dd9d8992b0c197ba656a6d9a70966cea10fc2d9
("batman-adv: tvlv - add network coding container")
Signed-off-by: Antonio Quartulli <antonio(a)meshcoding.com>
---
network-coding.h | 1 -
1 file changed, 1 deletion(-)
diff --git a/network-coding.h b/network-coding.h
index 8a97b40..d2f110c 100644
--- a/network-coding.h
+++ b/network-coding.h
@@ -49,7 +49,6 @@ int batadv_nc_init_debugfs(struct batadv_priv *bat_priv);
static inline void batadv_nc_status_update(struct net_device *net_dev)
{
- return;
}
static inline int batadv_nc_init(struct batadv_priv *bat_priv)
--
1.8.1.5
The name of the function does not match the kernel doc. Fix it.
Introduced by 6228419df3a53d09a2ba1f3e7b32bcd7cd59c968
("batman-adv: tvlv - convert tt query packet to use tvlv unicast packets")
Signed-off-by: Antonio Quartulli <antonio(a)meshcoding.com>
---
translation-table.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/translation-table.c b/translation-table.c
index 1198aea..d1840dd 100644
--- a/translation-table.c
+++ b/translation-table.c
@@ -2729,7 +2729,7 @@ out:
}
/**
- * batadv_dat_status_update - process incoming tt reply
+ * batadv_handle_tt_response - process incoming tt reply
* @bat_priv: the bat priv with all the soft interface information
* @tt_data: tt data containing the tt request information
* @resp_src: mac address of tt reply sender
--
1.8.1.5
Introduced by: 0b6aa0d43767889eeda43a132cf5e73df4e63bf2
("batman-adv: tvlv - basic infrastructure")
Signed-off-by: Antonio Quartulli <antonio(a)meshcoding.com>
---
main.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/main.c b/main.c
index 5c5e64b..7cf6ccd 100644
--- a/main.c
+++ b/main.c
@@ -1015,7 +1015,7 @@ void batadv_tvlv_ogm_receive(struct batadv_priv *bat_priv,
* @bat_priv: the bat priv with all the soft interface information
* @optr: ogm tvlv handler callback function. This function receives the orig
* node, flags and the tvlv content as argument to process.
- * uptr: unicast tvlv handler callback function. This function receives the
+ * @uptr: unicast tvlv handler callback function. This function receives the
* source & destination of the unicast packet as well as the tvlv content
* to process.
* @type: tvlv handler type to be registered
--
1.8.1.5
Hello David,
this is a very small (but important) fix intended for net/linux-3.{11,12} (since
3.12-rc1 is out I guess this patch needs to be enqueued for stable in order to
reach 3.11?)
This change fixes a regression introduced in 3.11 that prevents the Bridge Loop
Avoidance component from correctly operate on VLANs.
Please pull or let me know of any problem.
Thank you,
Antonio
The following changes since commit 1ef68ec462571955f2a667ddf1ffe279848709d7:
Merge branch 'sfc-3.12' of git://git.kernel.org/pub/scm/linux/kernel/git/bwh/sfc (2013-09-16 21:43:54 -0400)
are available in the git repository at:
git://git.open-mesh.org/linux-merge.git tags/batman-adv-fix-for-davem
for you to fetch changes up to 4c18c425b2d228415b635e97a64737d7f27c5536:
batman-adv: set the TAG flag for the vid passed to BLA (2013-09-17 21:15:16 +0200)
----------------------------------------------------------------
Included change:
- fix the Bridge Loop Avoidance component by marking the variables containing
the VLAN ID with the HAS_TAG flag when needed.
----------------------------------------------------------------
Antonio Quartulli (1):
batman-adv: set the TAG flag for the vid passed to BLA
net/batman-adv/soft-interface.c | 2 ++
1 file changed, 2 insertions(+)
Hello everybody,
first of all, i want to excuse myself, if i write something wrong for
my horrible english. I am writing my thesis of Information Engineering
about your protocol. So, as i wrote in the object of the
message, i want to see where BATMAN-adv save the last sequence number
saved for a generic originator, and also
where it puts all the information act to evaluate the TQ toward each
originator of the mesh.
Thanks you for attenction
--
Eugenio Carocci