B.A.T.M.A.N April 2012

b.a.t.m.a.n@lists.open-mesh.org

25 participants
63 discussions

[B.A.T.M.A.N.] Question howto build batman-adv Openwrt Kamikaze 8.09 rev 2012 build
by 3zl Trizonelabs 08 Apr '12

08 Apr '12

How could i build a newer release of batman-adv (2012) for Openwrt 8.09 or devel ? Or maybe i did something wrong here ? Started with fresh build enviroment & setup : feeds.conf.default src-svn packages svn://svn.openwrt.org/openwrt/branches/packages_8.09 svn://svn.openwrt.org/openwrt/packages src-svn batman http://downloads.open-mesh.org/svn/openwrt-feed/ 3zl@debian6esxi:~/OpenWRT/8.09tr$ ./scripts/feeds update Updating feed 'packages' from 'svn://svn.openwrt.org/openwrt/branches/packages_8.09' ... A net/batman-advanced A net/batman-advanced/files A net/batman-advanced/files/etc A net/batman-advanced/files/etc/config A net/batman-advanced/files/etc/config/batmand-adv A net/batman-advanced/files/etc/init.d A net/batman-advanced/files/etc/init.d/batmand-adv A net/batman-advanced/patches A net/batman-advanced/Makefile Updated to revision 31216. make menuconfig : Kernel Module Network select batman-adv (*) make.. results in : /build_dir/mips/batman-adv-r1176 with folders : /batman /batman-adv-kernelland /batman-adv-userspace /batman-experimental / battool cat /feeds/packages/net/batman-advanced/makefile KG_NAME:=batmand-adv PKG_REV:=1176 PKG_VERSION:=r$(PKG_REV) PKG_RELEASE:=1 PKG_BRANCH:=batman-adv-userspace PKG_SOURCE_PROTO:=svn PKG_SOURCE_VERSION:=$(PKG_REV) PKG_SOURCE_SUBDIR:=batman-adv-$(PKG_VERSION) PKG_SOURCE_URL:=http://downloads.open-mesh.net/svn/batman/trunk/ PKG_SOURCE:=$(PKG_SOURCE_SUBDIR).tar.gz PKG_BUILD_DIR:=$(BUILD_DIR)/$(PKG_SOURCE_SUBDIR) PKG_KMOD_BUILD_DIR:=$(PKG_BUILD_DIR)/batman-adv-kernelland PKG_TOOL_INSTALL_DIR:=$(PKG_BUILD_DIR)/ipkg-battool-install PKG_TOOL_BUILD_DIR:=$(PKG_BUILD_DIR)/battool on DIR-300 router : uname -a 2.6.26.8 mips atheros 23xx DIR-300 A1 batman-adv : 01. rv1176 (cpmpatibility version 6) loaded is it possible to get rel 2012.x build on Kamikaze ? thanks 3zl

2 1

[B.A.T.M.A.N.] Subject: batman-adv Openwrt Kamikaze / 8.09 problem
by 3zl Trizonelabs 08 Apr '12

08 Apr '12

Seeking for hep to get batman-adv running on Openwrt Kamikaze 8.09 build Kernel 2.6.30 Build runs ok, but module not loaded. .... batctl -v ...batman-adv module not loaded Try to load manually : insmod /lib/modules/2.6.30.10/batman-adv.ko ......... unknown symbol in module or unknown parameter Any hint how to setup the build for 8.09 trunk highly appreciated regards 3zl

2 1

[B.A.T.M.A.N.] [RFC] ELP
by Marek Lindner 06 Apr '12

06 Apr '12

Hi, after numerous infrastructure changes in the past weeks ELP[1] slowly approaches the state in which it can be tested and later merged into the master branch. Since its initial implementation by Linus Luessing last summer a lot has happened: * the internal protocol name (NDP) was renamed to ELP * the old code was rebased on top of the master branch * the ELP code was adjusted to the many changes in our code base * several patches were squashed together * brought the code in sync with the spec * numerous bugs were fixed (buffer overflow, writing into random memory sections, memory corruptions, locking issues, elp packet length checks, printing the neighbors of the requested mesh only and many more) The ELP code is the first to use the recently introduced routing protocol abstraction. It is not compiled into batman-adv by default, therefore you need to compile with CONFIG_BATMAN_ADV_BATMAN_V=y or modify the makefile. Once the batman-adv kernel module has been loaded you can check for the existence of the new routing protocol: cat /sys/kernel/debug/batman_adv/routing_algos Available routing algorithms: BATMAN IV BATMAN V To activate B.A.T.M.A.N. V (ELP) you should run the following command *before* adding any interface via batctl: echo -n "BATMAN V" > /sys/module/batman_adv/parameters/routing_algo Caveats: * ELP alone (without OGMv2) isn't very useful because ELP handles single hop neighbors only. So don't expect to convert your entire mesh network to B.A.T.M.A.N. V just yet. * The batman-adv routing protocol abstraction still lacks the translation table integration which is why the following patches will lead to a kernel crash. The ELP repository[2] contains a patch to disable the TT propagation partially to mitigate the problem until a proper solution has been implemented. Any comments and suggestions are appreciated. Regards, Marek [1] http://www.open-mesh.org/wiki/batman-adv/ELP [2] http://git.open-mesh.org/?p=marek/batman-adv.git;a=shortlog;h=refs/heads/elp Linus Luessing (5): batman-adv: ELP - adding basic infrastructure batman-adv: ELP - creating neighbor structures, updating LQs batman-adv: ELP - exporting neighbor list via debugfs batman-adv: ELP - adding sysfs parameter for elp interval batman-adv: ELP - add configurable minimum ELP packet length (def: 300B) Makefile | 2 + Makefile.kbuild | 1 + README.external | 1 + bat_algo.h | 6 + bat_debugfs.c | 16 ++ bat_sysfs.c | 8 + bat_v_elp.c | 500 ++++++++++++++++++++++++++++++++++++++++++++ gen-compat-autoconf.sh | 1 + hard-interface.c | 7 + main.c | 1 + packet.h | 20 ++- sysfs-class-net-batman-adv | 13 ++ types.h | 15 ++ 13 files changed, 590 insertions(+), 1 deletions(-)

4 29

[B.A.T.M.A.N.] [batman-adv] - remote access
by xjodoin＠gmail.com 06 Apr '12

06 Apr '12

I searched on the wiki and I didn't find. How I can have remote access on batman-adv mesh node. Thank you Xavier

2 1

[B.A.T.M.A.N.] pull request: batman-adv 2012-04-05
by Antonio Quartulli 05 Apr '12

05 Apr '12

Hello, This is my first pull-request, so I hope I've done everything in the right way, but please, fell free to blame me so that I can learn more :-) I would like to propose the following changes for net-next/3.5. The first patch just adds a new maintainer for batman-adv; patches from 2 to 5 are cleanups and little fixes to make batman-adv re-use kernel defines/structures (ETH_ALEN and bitmap); patch 6 increases the default value of the "hop_penalty" parameter in order to encourage batman-adv to choose shorter routes; patches from 7 to 16 consist in the renewal of the bridge loop avoidance mechanism (aka BLA2). BLA2 faces the same problem that STP tries to solve in classical switched networks, but in a layer 2 mesh. In this case the problem shows up when the user connects two nodes belonging to the same mesh by means of an ethernet bridge. It is possible to find much more details about BLA2 in our wiki [1,2,3]. As you can see its compile option is set to 'y' by default, but simply because this mechanism (actually its old version) was already part of the batman-adv core, but we decided to possibly let the users choose to remove it whether the network permits it and so reduce the binary size. Thank you, Antonio [1] http://www.open-mesh.org/wiki/batman-adv/Bridge-loop-avoidance-II [2] http://www.open-mesh.org/wiki/batman-adv/Bridge-loop-avoidance-Protocol [3] http://www.open-mesh.org/wiki/batman-adv/Bridge-loop-avoidance-Testcases The following changes since commit dd775ae2549217d3ae09363e3edb305d0fa19928: Linux 3.4-rc1 (2012-03-31 16:24:09 -0700) are available in the git repository at: git://git.open-mesh.org/linux-merge.git tags/batman-adv-for-davem for you to fetch changes up to 039c70589f5428682e2af706ad0affcfab83c55b: batman-adv: add bridge loop avoidance compile option (2012-04-05 11:08:13 +0200) ---------------------------------------------------------------- Included changes: * add my name to the maintainers list of batman-adv * some clean up fixes * increases the default hop-penalty in order to encourage the routing protocol to choose shorter routes * renew the bridge loop avoidance mechanism The latter mechanism was already present in batman-adv but recently the concept has been discussed again and here comes the new implementation. Moreover we added a compile option in order to let expert people, which think that this mechanism is not helpful at all, disable it and save some space. ---------------------------------------------------------------- Antonio Quartulli (3): MAINTAINERS: add additional maintainer for net/batman-adv batman-adv: clean up Kconfig batman-adv: use ETH_ALEN instead of hardcoded numeric constants Marek Lindner (1): batman-adv: encourage batman to take shorter routes by changing the default hop penalty Simon Wunderlich (10): batman-adv: remove old bridge loop avoidance code batman-adv: add basic bridge loop avoidance code batman-adv: make bridge loop avoidance switchable batman-adv: export claim tables through debugfs batman-adv: allow multiple entries in tt_global_entries batman-adv: don't let backbone gateways exchange tt entries batman-adv: add broadcast duplicate check batman-adv: drop STP over batman batman-adv: form groups in the bridge loop avoidance batman-adv: add bridge loop avoidance compile option Sven Eckelmann (2): batman-adv: Replace bitarray operations with bitmap batman-adv: Remove declaration of only locally used functions Documentation/ABI/testing/sysfs-class-net-mesh | 9 + Documentation/networking/batman-adv.txt | 19 +- MAINTAINERS | 1 + net/batman-adv/Kconfig | 27 +- net/batman-adv/Makefile | 1 + net/batman-adv/bat_debugfs.c | 19 +- net/batman-adv/bat_iv_ogm.c | 15 +- net/batman-adv/bat_sysfs.c | 8 +- net/batman-adv/bitarray.c | 118 +- net/batman-adv/bitarray.h | 26 +- net/batman-adv/bridge_loop_avoidance.c | 1576 ++++++++++++++++++++++++ net/batman-adv/bridge_loop_avoidance.h | 56 + net/batman-adv/hard-interface.c | 18 +- net/batman-adv/main.c | 9 +- net/batman-adv/main.h | 11 +- net/batman-adv/originator.c | 3 +- net/batman-adv/packet.h | 42 +- net/batman-adv/routing.c | 27 +- net/batman-adv/routing.h | 1 - net/batman-adv/soft-interface.c | 495 +------- net/batman-adv/soft-interface.h | 2 - net/batman-adv/translation-table.c | 431 +++++-- net/batman-adv/translation-table.h | 8 - net/batman-adv/types.h | 77 +- 24 files changed, 2204 insertions(+), 795 deletions(-) create mode 100644 net/batman-adv/bridge_loop_avoidance.c create mode 100644 net/batman-adv/bridge_loop_avoidance.h

2 17

[B.A.T.M.A.N.] [PATCH 0/5] batman-adv: tt code fixes and temporary client detection
by Antonio Quartulli 04 Apr '12

04 Apr '12

This set of patches aims to first clean & fix the code a little bit in order to prepare it for the temporary client recognition (patch 5/5). Temporary client recognition: In the current implementation, whenever a client joins the network it has to wait the next OGM in order to be announced to the whole network (by means of the known TT mechanism). Before that time, the client will be unable to communicate to whichever else client, so generating some delay that usually leads to DHCP (or any other service) timeout. This problem is amplified is for large originator interval. Patch 5/5 add a temporary recognition mechanism which make every node in the network "autodetect" the location (namely the node serving) the node yet announced client Known issues: right now, multiple temporary announcement of the same client is not supported; roaming of temporary client is not supported. Support for this two features will be added soon.

1 6

[B.A.T.M.A.N.] [PATCH] batman-adv: Initialize lockdep class keys for hashes
by Sven Eckelmann 04 Apr '12

04 Apr '12

The hash for claim and backbone hash in the bridge loop avoidance code receive the same key because they are getting initialized by hash_new with the same key. Lockdep will create a backtrace when they are used recursively. This can be avoided by reinitializing the key directly after the hash_new. Signed-off-by: Sven Eckelmann <sven(a)narfation.org> --- bridge_loop_avoidance.c | 11 +++++++++++ hash.c | 9 +++++++++ hash.h | 3 +++ 3 files changed, 23 insertions(+), 0 deletions(-) diff --git a/bridge_loop_avoidance.c b/bridge_loop_avoidance.c index 8a17a78..c74d8a2 100644 --- a/bridge_loop_avoidance.c +++ b/bridge_loop_avoidance.c @@ -1124,6 +1124,14 @@ out: bla_start_timer(bat_priv); } +/* The hash for claim and backbone hash receive the same key because they + * are getting initialized by hash_new with the same key. Reinitializing + * them with to different keys to allow nested locking without generating + * lockdep warnings + */ +static struct lock_class_key claim_hash_lock_class_key; +static struct lock_class_key backbone_hash_lock_class_key; + /* initialize all bla structures */ int bla_init(struct bat_priv *bat_priv) { @@ -1158,6 +1166,9 @@ int bla_init(struct bat_priv *bat_priv) bat_priv->claim_hash = hash_new(128); bat_priv->backbone_hash = hash_new(32); + hash_set_lock_class(bat_priv->claim_hash, &claim_hash_lock_class_key); + hash_set_lock_class(bat_priv->backbone_hash, &backbone_hash_lock_class_key); + if (!bat_priv->claim_hash || !bat_priv->backbone_hash) return -1; diff --git a/hash.c b/hash.c index 117687b..13d4597 100644 --- a/hash.c +++ b/hash.c @@ -69,3 +69,12 @@ free_hash: kfree(hash); return NULL; } + +void hash_set_lock_class(struct hashtable_t *hash, struct lock_class_key *key) +{ + uint32_t i; + + for (i = 0 ; i < hash->size; i++) { + lockdep_set_class(&hash->list_locks[i], key); + } +} diff --git a/hash.h b/hash.h index d4bd786..7bcb98f 100644 --- a/hash.h +++ b/hash.h @@ -45,6 +45,9 @@ struct hashtable_t { /* allocates and clears the hash */ struct hashtable_t *hash_new(uint32_t size); +/* set class key for all locks */ +void hash_set_lock_class(struct hashtable_t *hash, struct lock_class_key *key); + /* free only the hashtable and the hash itself. */ void hash_destroy(struct hashtable_t *hash); -- 1.7.9.1

2 2

[B.A.T.M.A.N.] [PATCH] batman-adv: unset the TT_CLIENT_PENDING flag if the new local entry already exists
by Antonio Quartulli 04 Apr '12

04 Apr '12

When trying to add a new tt_local_entry, if such entry already exists, we have to ensure that the TT_CLIENT_PENDING flag is not set, otherwise the entry will be deleted soon. Reported-by: Simon Wunderlich <siwu(a)hrz.tu-chemnitz.de> Signed-off-by: Antonio Quartulli <ordex(a)autistici.org> --- translation-table.c | 2 ++ 1 files changed, 2 insertions(+), 0 deletions(-) diff --git a/translation-table.c b/translation-table.c index 27753a0..65de6b7 100644 --- a/translation-table.c +++ b/translation-table.c @@ -188,6 +188,8 @@ void tt_local_add(struct net_device *soft_iface, const uint8_t *addr, if (tt_local_entry) { tt_local_entry->last_seen = jiffies; + /* possibly unset the TT_CLIENT_PENDING flag */ + tt_local_entry->common.flags &= ~TT_CLIENT_PENDING; goto out; } -- 1.7.3.4

2 1

[B.A.T.M.A.N.] [PATCH] batman-adv: put long strings on a dedicated line
by Antonio Quartulli 04 Apr '12

04 Apr '12

Strings that make the line exceed 80 chars should be put on a dedicated line to avoid making it even longer Signed-off-by: Antonio Quartulli <ordex(a)autistici.org> --- bridge_loop_avoidance.c | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/bridge_loop_avoidance.c b/bridge_loop_avoidance.c index 8a17a78..aaa4b9f 100644 --- a/bridge_loop_avoidance.c +++ b/bridge_loop_avoidance.c @@ -697,7 +697,8 @@ static int handle_unclaim(struct bat_priv *bat_priv, return 1; /* this must be an UNCLAIM frame */ - bat_dbg(DBG_BLA, bat_priv, "handle_unclaim(): UNCLAIM %pM on vid %d (sent by %pM)...\n", + bat_dbg(DBG_BLA, bat_priv, + "handle_unclaim(): UNCLAIM %pM on vid %d (sent by %pM)...\n", claim_addr, vid, backbone_gw->orig); bla_del_claim(bat_priv, claim_addr, vid); -- 1.7.9.4

2 1

[B.A.T.M.A.N.] [PATCH] batman-adv: Add routing_algo to README
by Sven Eckelmann 04 Apr '12

04 Apr '12

Signed-off-by: Sven Eckelmann <sven(a)narfation.org> --- Please apply directly to next and merge into master. Thx README | 9 +++++---- 1 files changed, 5 insertions(+), 4 deletions(-) diff --git a/README b/README index 4ee2f54..82c075f 100644 --- a/README +++ b/README @@ -66,10 +66,11 @@ All mesh wide settings can be found in batman's own interface folder: # ls /sys/class/net/bat0/mesh/ -# aggregated_ogms fragmentation hop_penalty -# ap_isolation gw_bandwidth log_level -# bonding gw_mode orig_interval -# bridge_loop_avoidance gw_sel_class vis_mode +# aggregated_ogms gw_bandwidth log_level +# ap_isolation gw_mode orig_interval +# bonding gw_sel_class routing_algo +# bridge_loop_avoidance hop_penalty vis_mode +# fragmentation There is a special folder for debugging information: -- 1.7.9.1

2 1

2024

2023

2022

2021

2020

2019

2018

2017

2016

2015

2014

2013

2012

2011

2010

2009

2008

2007

B.A.T.M.A.N April 2012