B.A.T.M.A.N February 2012

b.a.t.m.a.n@lists.open-mesh.org

14 participants
44 discussions

[B.A.T.M.A.N.] [PATCH] batctl: use ETH_ALEN instead of hardcoded numeric constants
by Antonio Quartulli 05 Feb '12

05 Feb '12

In tcpdump.h the numeric constants 6 is usedinstead of the more portable (and readable) define ETH_ALEN. This patch substitute any hardcoded value with such define. Reported-by: Sven Eckelmann <sven(a)narfation.org> Signed-off-by: Antonio Quartulli <ordex(a)autistici.org> --- tcpdump.h | 9 +++++---- 1 files changed, 5 insertions(+), 4 deletions(-) diff --git a/tcpdump.h b/tcpdump.h index 2a2cc0a..96989b4 100644 --- a/tcpdump.h +++ b/tcpdump.h @@ -21,6 +21,7 @@ #include <netpacket/packet.h> +#include <net/ethernet.h> #include "list-batman.h" #ifndef ARPHRD_IEEE80211_PRISM @@ -65,11 +66,11 @@ struct vlanhdr { struct ieee80211_hdr { u_int16_t frame_control; u_int16_t duration_id; - u_int8_t addr1[6]; - u_int8_t addr2[6]; - u_int8_t addr3[6]; + u_int8_t addr1[ETH_ALEN]; + u_int8_t addr2[ETH_ALEN]; + u_int8_t addr3[ETH_ALEN]; u_int16_t seq_ctrl; - u_int8_t addr4[6]; + u_int8_t addr4[ETH_ALEN]; } __attribute__ ((packed)); struct radiotap_header { -- 1.7.3.4

2 1

[B.A.T.M.A.N.] batman-adv 2012.0.0 released
by Marek Lindner 05 Feb '12

05 Feb '12

Today the B.A.T.M.A.N. team releases its latest edition, 2012.0.0, containing a series of stabilization changes and bug fixes. This release does not introduce any new features and uniquely focuses on stability. As the kernel module always depends on the Linux kernel it was compiled against, it does not make sense to provide binaries on our website. As usual, you will find the signed tarballs in our download section: http://downloads.open-mesh.org/batman/releases/batman-adv-2012.0.0/ as well as prepackaged binaries in your distribution. Thanks ------ Thanks to all people sending in patches: * Antonio Quartulli <ordex(a)autistici.org> * Dan Carpenter <dan.carpenter(a)oracle.com> * Marek Lindner <lindner_marek(a)yahoo.de> * Paul Kot <pawlkt(a)gmail.com> * Simon Wunderlich <siwu(a)hrz.tu-chemnitz.de> * Sven Eckelmann <sven(a)narfation.org> batman-adv ---------- The gateway handling code was refactored as it became nearly impossible to understand the various gateway handling cases that were added over time. Also refactored was the TT handling code and a common subtype for locally and globally announced mac addresses was introduced. All told, the TT code was thoroughly reviewed leading to numerous fixes: When adding a tt entry to the hash failed its memory is properly freed. Globally roaming clients are now clearly marked as such. The length of a TT packet is compared with the length the packet claims to have, thereby avoiding memory corruptions. The expensive packet linearize function is called only when absolutely necessary. We also were in the lucky position of getting a security audit from Paul Kot who did find a possible memory corruption in the batman socket reading code. However, since there is no way to exploit it, according to him, we judged the risk to be low. Obviously, the fix for this corruption is part of the release. Also fixed was a kernel freeze when the bat0 interface could not be created. batctl ------ The log level parameter parser was fixed, so that it now correctly exits after receiving an invalid option as well as correctly handles the 'all' log level option. Happy routing, The B.A.T.M.A.N. team

1 0

[B.A.T.M.A.N.] some basic questions
by Perazim 04 Feb '12

04 Feb '12

I am trying batman-adv on trunk openwrt for ubiquiti bullet2. I am using trunk because I want 2011.4.0. In menuconfig I select Kernel Modules/Network Support/Kmod-batgat + kmod-batman-adv + enable batctl. Now I see that in Network/Routing and redirection/Batmand is auto selected (I cannot deselect it) Is this normal behavior? I see that besides the kmods, I also have batmand installed on the router. I thought that this would have not been included after the introduction of batman-adv. Is this normal behavior or is there something wrong with menuconfig that is causing batmand to be included? Thanks, Perazim

3 3

[B.A.T.M.A.N.] [PATCH] batman-adv: pass the correct header size to interface_rx
by Antonio Quartulli 01 Feb '12

01 Feb '12

in recv_unicast_frag(), the third parameter of the interface_rx() invocation, which is the size of the current header, is wrongly computed. Signed-off-by: Antonio Quartulli <ordex(a)autistici.org> --- routing.c | 2 +- 1 files changed, 1 insertions(+), 1 deletions(-) diff --git a/routing.c b/routing.c index f961cc5..cf8fe0a 100644 --- a/routing.c +++ b/routing.c @@ -990,7 +990,7 @@ int recv_ucast_frag_packet(struct sk_buff *skb, struct hard_iface *recv_if) return NET_RX_SUCCESS; interface_rx(recv_if->soft_iface, new_skb, recv_if, - sizeof(struct unicast_packet)); + sizeof(*unicast_packet)); return NET_RX_SUCCESS; } -- 1.7.3.4

2 3

2024

2023

2022

2021

2020

2019

2018

2017

2016

2015

2014

2013

2012

2011

2010

2009

2008

2007

B.A.T.M.A.N February 2012