B.A.T.M.A.N August 2011

b.a.t.m.a.n@lists.open-mesh.org

30 participants
27 discussions

[B.A.T.M.A.N.] Multiple DHCP Gateways
by gtolon＠inti.gob.ar 14 Aug '11

14 Aug '11

Hi I´m testing the Gateway roaming capabilities of Batman-adv (using 2011.1.0 version). I setted two computers as Gateway servers with DHCP servers running on them and other as Gateway client, configured as class 3. Then i stressed individually the Gateway server´s links to make the client choose the not stressed one. I confirmed that when te client sends a layer 3 broadcast DHCP request, Batman redirects that request only to the best gateway. However, when the original gateway becomes worse than the alternative, and the client chooses the new one as preferred (observed with batctl gwl) i noticed that the subsequent request DHCP messages are sent to the original server, even if it doesn´t have the best link. I guess that´s because these subsequent DHCP requests are made as Unicast to the original server and so Batman doesn´t redirect them, but i wonder how this behavior affects the network balance, because the computers would get tied always to the original DHCP and IP default gateway even if they moved, right? Thank you very much

4 3

[B.A.T.M.A.N.] Battlemesh-like experiment in Washington, DC
by Juliusz Chroboczek 10 Aug '11

10 Aug '11

Hi, It looks like the folks at HacDC, a hackerspace in Washington, DC, have done their own battlemesh: http://drwho.virtadpt.net/archive/2011/03/15/project-byzantium-sprint-1 http://drwho.virtadpt.net/archive/2011/04/14/project-byzantium-development-… They've got a few minor misunderstandings (for example, they're trying to get ordinary DHCP to work over a mesh), but they've managed to get both Babel and BATMAN-Adv to work with no help from us -- well done. -- Juliusz

5 16

Re: [B.A.T.M.A.N.] [Battlemesh] Battlemesh-like experiment in Washington, DC
by The Doctor 10 Aug '11

10 Aug '11

-----BEGIN PGP SIGNED MESSAGE----- Hash: SHA1 On 08/09/2011 01:40 PM, Glen Duncan wrote: > Doesn't RFC-1918 and supporting protocols check to see if the address > chosen is already in use and back off/retry if it fails? That is an excellent question, but to answer it I will have to do some research and get back to you. - -- The Doctor [412/724/301/703] PGP: 0x807B17C1 / 7960 1CDC 85C9 0B63 8D9F DD89 3BD8 FF2B 807B 17C1 WWW: http://drwho.virtadpt.net/ "And the flowers are still standing!" --Peter Venkman, _Ghostbusters_ -----BEGIN PGP SIGNATURE----- Version: GnuPG v1.4.10 (GNU/Linux) Comment: Using GnuPG with Mozilla - http://enigmail.mozdev.org/ iEYEARECAAYFAk5Ct4MACgkQO9j/K4B7F8F0sQCghfe67YYb3ESxCrL3myyRB0Ke jKEAoLzkWeyMu1mN4qg975um5XN9Ldoe =qRJY -----END PGP SIGNATURE-----

1 0

[B.A.T.M.A.N.] [PATCH] batctl: fix a memory leak in bat_hosts_init
by Jonathan Neuschäfer 03 Aug '11

03 Aug '11

normalized was not being free'd when hash_new failed, now it is. Signed-off-by: Jonathan Neuschäfer <j.neuschaefer(a)gmx.net> --- bat-hosts.c | 3 ++- 1 files changed, 2 insertions(+), 1 deletions(-) diff --git a/bat-hosts.c b/bat-hosts.c index 0ea4134..179e733 100644 --- a/bat-hosts.c +++ b/bat-hosts.c @@ -179,7 +179,7 @@ void bat_hosts_init(int read_opt) if (!host_hash) { if (read_opt & USE_BAT_HOSTS) printf("Warning - could not create bat hosts hash table\n"); - return; + goto out; } homedir = getenv("HOME"); @@ -216,6 +216,7 @@ void bat_hosts_init(int read_opt) parse_hosts_file(&host_hash, normalized + (i * PATH_MAX), read_opt); } +out: free(normalized); } -- 1.7.5.4

2 1

[B.A.T.M.A.N.] [PATCH] batman-adv: merge update_transtable() into tt related code
by Marek Lindner 03 Aug '11

03 Aug '11

Signed-off-by: Marek Lindner <lindner_marek(a)yahoo.de> --- routing.c | 66 ++---------------------------------------------- translation-table.c | 69 +++++++++++++++++++++++++++++++++++++++++++++++--- translation-table.h | 9 ++---- 3 files changed, 70 insertions(+), 74 deletions(-) diff --git a/routing.c b/routing.c index 91a7860..1949928 100644 --- a/routing.c +++ b/routing.c @@ -64,65 +64,6 @@ void slide_own_bcast_window(struct hard_iface *hard_iface) } } -static void update_transtable(struct bat_priv *bat_priv, - struct orig_node *orig_node, - const unsigned char *tt_buff, - uint8_t tt_num_changes, uint8_t ttvn, - uint16_t tt_crc) -{ - uint8_t orig_ttvn = (uint8_t)atomic_read(&orig_node->last_ttvn); - bool full_table = true; - - /* the ttvn increased by one -> we can apply the attached changes */ - if (ttvn - orig_ttvn == 1) { - /* the OGM could not contain the changes due to their size or - * because they have already been sent TT_OGM_APPEND_MAX times. - * In this case send a tt request */ - if (!tt_num_changes) { - full_table = false; - goto request_table; - } - - tt_update_changes(bat_priv, orig_node, tt_num_changes, ttvn, - (struct tt_change *)tt_buff); - - /* Even if we received the precomputed crc with the OGM, we - * prefer to recompute it to spot any possible inconsistency - * in the global table */ - orig_node->tt_crc = tt_global_crc(bat_priv, orig_node); - - /* The ttvn alone is not enough to guarantee consistency - * because a single value could represent different states - * (due to the wrap around). Thus a node has to check whether - * the resulting table (after applying the changes) is still - * consistent or not. E.g. a node could disconnect while its - * ttvn is X and reconnect on ttvn = X + TTVN_MAX: in this case - * checking the CRC value is mandatory to detect the - * inconsistency */ - if (orig_node->tt_crc != tt_crc) - goto request_table; - - /* Roaming phase is over: tables are in sync again. I can - * unset the flag */ - orig_node->tt_poss_change = false; - } else { - /* if we missed more than one change or our tables are not - * in sync anymore -> request fresh tt data */ - if (ttvn != orig_ttvn || orig_node->tt_crc != tt_crc) { -request_table: - bat_dbg(DBG_TT, bat_priv, "TT inconsistency for %pM. " - "Need to retrieve the correct information " - "(ttvn: %u last_ttvn: %u crc: %u last_crc: " - "%u num_changes: %u)\n", orig_node->orig, ttvn, - orig_ttvn, tt_crc, orig_node->tt_crc, - tt_num_changes); - send_tt_request(bat_priv, orig_node, ttvn, tt_crc, - full_table); - return; - } - } -} - static void update_route(struct bat_priv *bat_priv, struct orig_node *orig_node, struct neigh_node *neigh_node) @@ -499,10 +440,9 @@ update_tt: if (((batman_packet->orig != ethhdr->h_source) && (batman_packet->ttl > 2)) || (batman_packet->flags & PRIMARIES_FIRST_HOP)) - update_transtable(bat_priv, orig_node, tt_buff, - batman_packet->tt_num_changes, - batman_packet->ttvn, - batman_packet->tt_crc); + tt_update_orig(bat_priv, orig_node, tt_buff, + batman_packet->tt_num_changes, + batman_packet->ttvn, batman_packet->tt_crc); if (orig_node->gw_flags != batman_packet->gw_flags) gw_node_update(bat_priv, orig_node, batman_packet->gw_flags); diff --git a/translation-table.c b/translation-table.c index e8f849f..cc53f78 100644 --- a/translation-table.c +++ b/translation-table.c @@ -1079,8 +1079,9 @@ out: return skb; } -int send_tt_request(struct bat_priv *bat_priv, struct orig_node *dst_orig_node, - uint8_t ttvn, uint16_t tt_crc, bool full_table) +static int send_tt_request(struct bat_priv *bat_priv, + struct orig_node *dst_orig_node, + uint8_t ttvn, uint16_t tt_crc, bool full_table) { struct sk_buff *skb = NULL; struct tt_query_packet *tt_request; @@ -1455,9 +1456,10 @@ out: orig_node_free_ref(orig_node); } -void tt_update_changes(struct bat_priv *bat_priv, struct orig_node *orig_node, - uint16_t tt_num_changes, uint8_t ttvn, - struct tt_change *tt_change) +static void tt_update_changes(struct bat_priv *bat_priv, + struct orig_node *orig_node, + uint16_t tt_num_changes, uint8_t ttvn, + struct tt_change *tt_change) { _tt_update_changes(bat_priv, orig_node, tt_change, tt_num_changes, ttvn); @@ -1802,3 +1804,60 @@ out: tt_local_entry_free_ref(tt_local_entry); return ret; } + +void tt_update_orig(struct bat_priv *bat_priv, struct orig_node *orig_node, + const unsigned char *tt_buff, uint8_t tt_num_changes, + uint8_t ttvn, uint16_t tt_crc) +{ + uint8_t orig_ttvn = (uint8_t)atomic_read(&orig_node->last_ttvn); + bool full_table = true; + + /* the ttvn increased by one -> we can apply the attached changes */ + if (ttvn - orig_ttvn == 1) { + /* the OGM could not contain the changes due to their size or + * because they have already been sent TT_OGM_APPEND_MAX times. + * In this case send a tt request */ + if (!tt_num_changes) { + full_table = false; + goto request_table; + } + + tt_update_changes(bat_priv, orig_node, tt_num_changes, ttvn, + (struct tt_change *)tt_buff); + + /* Even if we received the precomputed crc with the OGM, we + * prefer to recompute it to spot any possible inconsistency + * in the global table */ + orig_node->tt_crc = tt_global_crc(bat_priv, orig_node); + + /* The ttvn alone is not enough to guarantee consistency + * because a single value could represent different states + * (due to the wrap around). Thus a node has to check whether + * the resulting table (after applying the changes) is still + * consistent or not. E.g. a node could disconnect while its + * ttvn is X and reconnect on ttvn = X + TTVN_MAX: in this case + * checking the CRC value is mandatory to detect the + * inconsistency */ + if (orig_node->tt_crc != tt_crc) + goto request_table; + + /* Roaming phase is over: tables are in sync again. I can + * unset the flag */ + orig_node->tt_poss_change = false; + } else { + /* if we missed more than one change or our tables are not + * in sync anymore -> request fresh tt data */ + if (ttvn != orig_ttvn || orig_node->tt_crc != tt_crc) { +request_table: + bat_dbg(DBG_TT, bat_priv, "TT inconsistency for %pM. " + "Need to retrieve the correct information " + "(ttvn: %u last_ttvn: %u crc: %u last_crc: " + "%u num_changes: %u)\n", orig_node->orig, ttvn, + orig_ttvn, tt_crc, orig_node->tt_crc, + tt_num_changes); + send_tt_request(bat_priv, orig_node, ttvn, tt_crc, + full_table); + return; + } + } +} diff --git a/translation-table.h b/translation-table.h index b47e876..30efd49 100644 --- a/translation-table.h +++ b/translation-table.h @@ -49,14 +49,8 @@ void tt_save_orig_buffer(struct bat_priv *bat_priv, struct orig_node *orig_node, uint16_t tt_local_crc(struct bat_priv *bat_priv); uint16_t tt_global_crc(struct bat_priv *bat_priv, struct orig_node *orig_node); void tt_free(struct bat_priv *bat_priv); -int send_tt_request(struct bat_priv *bat_priv, - struct orig_node *dst_orig_node, uint8_t ttvn, - uint16_t tt_crc, bool full_table); bool send_tt_response(struct bat_priv *bat_priv, struct tt_query_packet *tt_request); -void tt_update_changes(struct bat_priv *bat_priv, struct orig_node *orig_node, - uint16_t tt_num_changes, uint8_t ttvn, - struct tt_change *tt_change); bool is_my_client(struct bat_priv *bat_priv, const uint8_t *addr); void handle_tt_response(struct bat_priv *bat_priv, struct tt_query_packet *tt_response); @@ -64,5 +58,8 @@ void send_roam_adv(struct bat_priv *bat_priv, uint8_t *client, struct orig_node *orig_node); void tt_commit_changes(struct bat_priv *bat_priv); bool is_ap_isolated(struct bat_priv *bat_priv, uint8_t *src, uint8_t *dst); +void tt_update_orig(struct bat_priv *bat_priv, struct orig_node *orig_node, + const unsigned char *tt_buff, uint8_t tt_num_changes, + uint8_t ttvn, uint16_t tt_crc); #endif /* _NET_BATMAN_ADV_TRANSLATION_TABLE_H_ */ -- 1.7.5.3

1 1

[B.A.T.M.A.N.] [PATCH] batman-adv: handle hash_add() return value in the TT code
by Antonio Quartulli 03 Aug '11

03 Aug '11

hash_add() can fail and for this reason its return value has to be correctly interpreted to avoid memory leaks. Signed-off-by: Antonio Quartulli <ordex(a)autistici.org> --- This patch needs "[PATCH] batman-adv: hash_add() has to discriminate on the return value" to work translation-table.c | 27 +++++++++++++++++++++------ 1 files changed, 21 insertions(+), 6 deletions(-) diff --git a/translation-table.c b/translation-table.c index fb6931d..267a287 100644 --- a/translation-table.c +++ b/translation-table.c @@ -188,6 +188,7 @@ void tt_local_add(struct net_device *soft_iface, const uint8_t *addr) struct bat_priv *bat_priv = netdev_priv(soft_iface); struct tt_local_entry *tt_local_entry = NULL; struct tt_global_entry *tt_global_entry = NULL; + int hash_added; tt_local_entry = tt_local_hash_find(bat_priv, addr); @@ -220,8 +221,14 @@ void tt_local_add(struct net_device *soft_iface, const uint8_t *addr) * (consistency check) */ tt_local_entry->flags |= TT_CLIENT_NEW; - hash_add(bat_priv->tt_local_hash, compare_ltt, choose_orig, - tt_local_entry, &tt_local_entry->hash_entry); + hash_added = hash_add(bat_priv->tt_local_hash, compare_ltt, + choose_orig, tt_local_entry, + &tt_local_entry->hash_entry); + if (hash_added != 0) + tt_local_entry_free_ref(tt_local_entry); + + if (hash_added < 0) + goto out; /* remove address from global hash if present */ tt_global_entry = tt_global_hash_find(bat_priv, addr); @@ -500,6 +507,7 @@ int tt_global_add(struct bat_priv *bat_priv, struct orig_node *orig_node, struct tt_global_entry *tt_global_entry; struct orig_node *orig_node_tmp; int ret = 0; + int hash_added; tt_global_entry = tt_global_hash_find(bat_priv, tt_addr); @@ -519,10 +527,17 @@ int tt_global_add(struct bat_priv *bat_priv, struct orig_node *orig_node, tt_global_entry->roam_at = 0; atomic_set(&tt_global_entry->refcount, 2); - hash_add(bat_priv->tt_global_hash, compare_gtt, - choose_orig, tt_global_entry, - &tt_global_entry->hash_entry); - atomic_inc(&orig_node->tt_size); + hash_added = hash_add(bat_priv->tt_global_hash, compare_gtt, + choose_orig, tt_global_entry, + &tt_global_entry->hash_entry); + if (hash_added != 0) + tt_global_entry_free_ref(tt_global_entry); + + if (hash_added < 0) + goto out; + + if (!hash_added) + atomic_inc(&orig_node->tt_size); } else { if (tt_global_entry->orig_node != orig_node) { atomic_dec(&tt_global_entry->orig_node->tt_size); -- 1.7.3.4

2 3

[B.A.T.M.A.N.] DNS Batmand
by Camila Troncoso 02 Aug '11

02 Aug '11

Hi, I´m working for some time with a wireless mesh. I have several devices with a basic linux inside (Openwrt) and they are running Batmand protocol. One of the mesh nodes acts as a gateway to internet, obtaining IP and DNS trough pppoe. The other nodes act as clients and connect to internet trough this gateway. The only problem that I’m facing , is that even when the gateway creates the tunnel ( gate0) with the client node and gave it internet connectivity , it doesn’t modify the /etc/resolv.conf file, and the client node isn’t capable of resolving names (DNS). I don’t understand why the gateway node is not giving the client node all the necessary information of the internet connection. I suppose by protocol , if the gateway makes a tunnel , gives IP and route to the clients nodes, It also has to give them a way to resolve names (DNS). Hope someone can help me in this matter, I spend a lot of time in this. Regards, Camila Troncoso | Ingeniero de Desarrollo VoissNet S.A. |ctroncoso(a)redvoiss.net Santiago - Chile | +56 2 2408535 www.redvoiss.net

2 1

2024

2023

2022

2021

2020

2019

2018

2017

2016

2015

2014

2013

2012

2011

2010

2009

2008

2007

B.A.T.M.A.N August 2011