B.A.T.M.A.N May 2011

b.a.t.m.a.n@lists.open-mesh.org

14 participants
59 discussions

[B.A.T.M.A.N.] batman-adv bug 149: odd broadcast behavior -- generated CRC errors
by Sven Eckelmann 20 May '11

20 May '11

Hi, I would assume that you don't monitor the bug as you didn't answer the questions on irc. So here the part of the IRC communication which needs comments/answers from your side. <T_X> dbeberman-away: hmm, weird. could be a batman specific bug. the first thing I'd have in mind to narrow things down would be to try changing that line: http://git.open-mesh.org/?p=batman- adv.git;a=blob;f=send.c;h=33779278f1b2bfe49155bb9dfadc421305c0c8d7;hb=refs/heads/master#l485 <T_X> from skb_clone to skb_copy <T_X> from looking at the kernel code it seems like skb_clone() is only copying the skb-header, but not the skb-headroom (which we are modifying in send_skb_packet() ) --> jn_ (~jonathan(a)dslb-084-060-236-250.pools.arcor-ip.net) has joined #batman <ecsv_> T_X: and that is a problem.... why? <ecsv_> i don't see which crc is the problem <T_X> ecsv_: you mean it should not be a problem because we for clones we are writing the exact same data in the headroom again? <ecsv_> we should... but yes, it might be a good idea to implement it differently and to test it with skb_copy <ecsv_> it didn't checked the bug report... just assumed that you guessed :) <ecsv_> but still don't see what happened to which crc <ecsv_> we only modify stuff which is related to us.... and not to the encapsulated data <ecsv_> but maybe he meant the ethernet header/wifi stuff before the batman-adv header <ecsv_> but why does he see them? <ecsv_> and why are udp broadcasts fragmented? <ecsv_> we should only have fragmentation for unicast <T_X> ecsv_: I think he's talking about the wifi fragmentation <T_X> not the fragmentation in batman <ecsv_> dbeberman-away: and the only reason why we reject mails on the list is either that you are a known spammer or that you try to send html mails <ecsv_> did you get a reply? <T_X> and I suppose he's doing the sniffing on another interface in monitor mode <T_X> ah, and missed that the "my_skb_head_push()" is in fact making the headroom of the (cloned) skb writeable Kind regards, Sven

1 1

[B.A.T.M.A.N.] port to omnet++
by alfonso ariza quintana 19 May '11

19 May '11

I have adapted the code of the version 0.3.2 to omnet. If some one is interested to check the code, it's possible to download from https://github.com/inetmanet/inetmanet/tree/master/src/networklayer/manetro…

1 0

[B.A.T.M.A.N.] [PATCH 1/9] batman-adv: Annotate functions with format strings
by Sven Eckelmann 19 May '11

19 May '11

Signed-off-by: Sven Eckelmann <sven(a)narfation.org> --- bat_debugfs.c | 1 + main.h | 3 ++- 2 files changed, 3 insertions(+), 1 deletions(-) diff --git a/bat_debugfs.c b/bat_debugfs.c index abaeec5..4577d3f 100644 --- a/bat_debugfs.c +++ b/bat_debugfs.c @@ -50,6 +50,7 @@ static void emit_log_char(struct debug_log *debug_log, char c) debug_log->log_start = debug_log->log_end - log_buff_len; } +__printf(2, 3) static int fdebug_log(struct debug_log *debug_log, char *fmt, ...) { va_list args; diff --git a/main.h b/main.h index 3ca3941..f80954b 100644 --- a/main.h +++ b/main.h @@ -138,7 +138,7 @@ void dec_module_count(void); int is_my_mac(uint8_t *addr); #ifdef CONFIG_BATMAN_ADV_DEBUG -int debug_log(struct bat_priv *bat_priv, char *fmt, ...); +int debug_log(struct bat_priv *bat_priv, char *fmt, ...) __printf(2, 3); #define bat_dbg(type, bat_priv, fmt, arg...) \ do { \ @@ -147,6 +147,7 @@ int debug_log(struct bat_priv *bat_priv, char *fmt, ...); } \ while (0) #else /* !CONFIG_BATMAN_ADV_DEBUG */ +__printf(3, 4) static inline void bat_dbg(char type __always_unused, struct bat_priv *bat_priv __always_unused, char *fmt __always_unused, ...) -- 1.7.5.1

3 22

[B.A.T.M.A.N.] Extending the Exporter
by Elmo 18 May '11

18 May '11

Hello, I'm trying to extend the Exporter of OpenMesh to put another float stored at each Vertex to an off or obj file. But the Tutorial on your website dosn't make it clear i think. Do I have to extend the the BaseExporter by a Iterator for my float like: virtual PVertexIter const_myFloat_begin() = 0; virtual PVertexIter const_myFloat_end() = 0; Where do i have to add the code to get these iterators called? Is there anything else to add? Thanks in advance Malte

2 1

[B.A.T.M.A.N.] [PATCH] batman-adv: reset broadcast flood protection on error
by Marek Lindner 15 May '11

15 May '11

The broadcast flood protection should be reset to its original value if the primary interface could not be retrieved. Signed-off-by: Marek Lindner <lindner_marek(a)yahoo.de> --- send.c | 2 +- 1 files changed, 1 insertions(+), 1 deletions(-) diff --git a/send.c b/send.c index 76daa46..3377927 100644 --- a/send.c +++ b/send.c @@ -421,7 +421,7 @@ int add_bcast_packet_to_list(struct bat_priv *bat_priv, struct sk_buff *skb) primary_if = primary_if_get_selected(bat_priv); if (!primary_if) - goto out; + goto out_and_inc; forw_packet = kmalloc(sizeof(struct forw_packet), GFP_ATOMIC); -- 1.7.2.3

2 2

[B.A.T.M.A.N.] pull request: batman-adv 2011-05-14
by Sven Eckelmann 15 May '11

15 May '11

Hi, I would like tp propose following corrections for net-next-2.6/2.6.40. Both are bug fixes. The first one fixes the regression introduced by "batman-adv: Make bat_priv->primary_if an rcu protected pointer" which prevented that the attached net_devices could be destroyed because the references to them were incorrectly counted. The second one is a bug which may "filled" the broadcast queue when at the same time primary_if got changed and a broadcast was initiated. The queue counter were never reduced because there were no actual packets attached to the the queue. thanks, Sven The following changes since commit 27aea2128ec09924dfe08e97739b2bf8b15c8619: batman-adv: remove duplicate code from function is_bidirectional_neigh() (2011-05-08 16:10:42 +0200) are available in the git repository at: git://git.open-mesh.org/ecsv/linux-merge.git batman-adv/next Marek Lindner (1): batman-adv: reset broadcast flood protection on error Sven Eckelmann (1): batman-adv: Add missing hardif_free_ref in forw_packet_free net/batman-adv/aggregation.c | 14 +++++++++++--- net/batman-adv/send.c | 19 ++++++++++++++++--- 2 files changed, 27 insertions(+), 6 deletions(-)

2 3

[B.A.T.M.A.N.] bug - unregister_netdevice: usage_count = 1
by Antonio Quartulli 14 May '11

14 May '11

Hi all, I found a bug playing with my interfaces while bat0 was active. The bug is described here: http://www.open-mesh.org/issues/148 The steps to reproduce it are reported too. In a few words, when trying to unregister a device by unloading its module, the modprobe hangs and in the dmesg I can see this message: unregister_netdevice: waiting for wlan0 to become free. Usage count = 1 I tried to do some tests and what I observed is that hard_iface->refcount doesn't reach 0. This means that hard_iface_free_rcu() is never invoked and dev_put() too. I hope the information are enough.. Regards, -- Antonio Quartulli ..each of us alone is worth nothing.. Ernesto "Che" Guevara

3 4

[B.A.T.M.A.N.] [PATCH] batman-adv: Use kzalloc rather than kmalloc followed by memset with 0
by Sven Eckelmann 10 May '11

10 May '11

Signed-off-by: Sven Eckelmann <sven(a)narfation.org> --- gateway_client.c | 3 +-- 1 files changed, 1 insertions(+), 2 deletions(-) diff --git a/gateway_client.c b/gateway_client.c index 65f3953..e638841 100644 --- a/gateway_client.c +++ b/gateway_client.c @@ -281,11 +281,10 @@ static void gw_node_add(struct bat_priv *bat_priv, struct gw_node *gw_node; int down, up; - gw_node = kmalloc(sizeof(struct gw_node), GFP_ATOMIC); + gw_node = kzalloc(sizeof(struct gw_node), GFP_ATOMIC); if (!gw_node) return; - memset(gw_node, 0, sizeof(struct gw_node)); INIT_HLIST_NODE(&gw_node->list); gw_node->orig_node = orig_node; atomic_set(&gw_node->refcount, 1); -- 1.7.5.1

2 1

[B.A.T.M.A.N.] [PATCH] batman-adv: move neigh_node->if_incoming->if_status check in find_router()
by Antonio Quartulli 09 May '11

09 May '11

Every time that find_router() is invoked, if_status has to be compared with IF_ACTIVE. Moving this comparison inside find_router() will avoid to write it each time. Signed-off-by: Antonio Quartulli <ordex(a)autistici.org> --- routing.c | 4 +++- unicast.c | 3 --- 2 files changed, 3 insertions(+), 4 deletions(-) diff --git a/routing.c b/routing.c index 49f5715..c875164 100644 --- a/routing.c +++ b/routing.c @@ -1237,7 +1237,6 @@ struct neigh_node *find_router(struct bat_priv *bat_priv, /* find the orig_node which has the primary interface. might * even be the same as our router_orig in many cases */ - if (compare_eth(router_orig->primary_addr, router_orig->orig)) { primary_orig_node = router_orig; } else { @@ -1266,6 +1265,9 @@ struct neigh_node *find_router(struct bat_priv *bat_priv, router = find_ifalter_router(primary_orig_node, recv_if); return_router: + if (router && router->if_incoming->if_status != IF_ACTIVE) + router = NULL; + rcu_read_unlock(); return router; } diff --git a/unicast.c b/unicast.c index b46cbf1..1be53d7 100644 --- a/unicast.c +++ b/unicast.c @@ -314,9 +314,6 @@ find_router: if (!neigh_node) goto out; - if (neigh_node->if_incoming->if_status != IF_ACTIVE) - goto out; - if (my_skb_head_push(skb, sizeof(struct unicast_packet)) < 0) goto out; -- 1.7.3.4

2 4

[B.A.T.M.A.N.] [PATCH] batman-adv: Fix build with linux 2.6.25-2.6.27
by Sven Eckelmann 09 May '11

09 May '11

We must prevent that IPPROTO_UDP gets redefined using compat.h. Otherwise the build will fail when including things like net/addrconf.h Signed-off-by: Sven Eckelmann <sven(a)narfation.org> --- compat.c | 1 + 1 files changed, 1 insertions(+), 0 deletions(-) diff --git a/compat.c b/compat.c index 70de376..586898f 100644 --- a/compat.c +++ b/compat.c @@ -1,3 +1,4 @@ +#include <linux/in.h> #include <linux/version.h> #include "main.h" -- 1.7.5.1

2 1

2024

2023

2022

2021

2020

2019

2018

2017

2016

2015

2014

2013

2012

2011

2010

2009

2008

2007

B.A.T.M.A.N May 2011