the last patchset sent by Andrew contained a few errors regarding the
authorship due to incorrect handling on our side. We did not notice these
issues until the patches went out to get included by you.
Here is the complete list of incorrect assignments:
* should be Linus instead of Simon
=> [PATCH 07/26] staging:batman-adv: Remove dead max addr and obsolete
=> [PATCH 09/26] staging:batman-adv: Update README about vis raw output
* should be Luis instead of Marek
=> [PATCH 12/26] staging:batman-adv: fix whitespace style issues
* should be Sven instead of Marek
=> [PATCH 24/26] staging:batman-adv: Fix whitespace problems criticized by
=> [PATCH 25/26] staging:batman-adv: Reduce max characters on a line to 80
Is there any way to correct the authors of the patches in question ? I know
that modifying the git history to fix the author will change all following
hashes and everyone has to rebase its tree.
Personally, I'm not so worried about Linus & Sven, since they are longterm
contributors and somewhat close to the project. I'm sure a beer or two can
compensate them for the loss of fame. Luis on the other hand seemed to be
quite thrilled about getting his patch in and I'd rather not leave him with
the impression we don't want to credit him for his work.
Greg asked us to provide an ABI documentation for the files creates in the
sysfs tree. Since I am respsonsible for the sysfs stuff, I felt it was my turn
to draft something. Please check the attachments and let me know whether you
think we can send it or not.
Here are the patches again, this time with the right authorship. Sorry
we messed it up and caused you extra work.
Signed-off-by: Andrew Lunn <andrew(a)lunn.ch>
Andrew Lunn (2):
Staging: batman-adv: Update TODO file to reflect current state.
Staging: batman-adv: updating README
Dan Carpenter (1):
Staging: batman-adv: cleanup: change test for end of array
Linus L?ssing (4):
Staging: batman-adv: only modify hna-table on active module
Staging: batman-adv: Fix aggregation direct-link bug
Staging: batman-adv: Remove dead max addr and obsolete VIS_FORMAT strings
Staging: batman-adv: Update README about vis raw output
Luis de Bethencourt (1):
Staging: batman-adv: fix whitespace style issues
Marek Lindner (6):
Staging: batman-adv: fix aggregation timing bug
Staging: batman-adv: convert multiple /proc files to use sysfs
Staging: batman-adv: convert more files from /proc to /sys
Staging: batman-adv: move originator interval setting from /proc to /sys
Staging: batman-adv: remove redundant pointer to originator interface
Staging: batman-adv: move /proc interface handling to /sys
Simon Wunderlich (7):
Staging: batman-adv: Update copyright years
Staging: batman-adv: remove the beta from main.h for release
Staging: batman-adv: Add 0.2.1 changes to the CHANGELOG
Staging: batman-adv: Changing version to 0.2.2-beta
Staging: batman-adv: Reorganize sequence number handling
Staging: batman-adv: Limit queue lengths for batman and broadcast packets
Staging: batman-adv: kfree_skb() in interface_tx() in error case
Sven Eckelmann (5):
Staging: batman-adv: Clone shared bat packets before modifying them
Staging: batman-adv: fix whitespace style issues
Staging: batman-adv: Update pointer to ethhdr after skb_copy
Staging: batman-adv: Fix whitespace problems criticized by checkpatch.pl
Staging: batman-adv: Reduce max characters on a line to 80
the current trunk contains some code which breaks our backward compatibility,
especially the sysfs API seem to be troublesome. I made 2 patches that address
the issue on my 2.6.21 test system. It would be nice if you could test them on
your system as well. I'd be particularly interested in kernels older than
2.6.25. Does someone have a 2.6.20 system ?
At some point we have to start thinking about how many versions we want to
support. Each new kernel brings more changes which need to be dealt with.
Right now, the required effort is still at a sustainable level but the gap is
growing. On one hand it is a nice playground to expand our knowledge about
macros and demonstrate what nasty things you can do (see the second patch as
an example). ;-)
On the other hand it always requires a serious amount of time and effort. It
only makes sense if at least some people are using it. Opinions ?
Andrew pointed out that our README would need a little bit of love. I spent
some time to get the text into a decent shape. I attached the full file for a
review. Let me know if you find anything. :)
I worked today on a small project  to recreated all current features for
0.3 on top of the current changeset in maint. This would be handy when Andrew
Lunn will send them to the kernel folks.
I discovered several small differences between maint and master which results
in slightly different content in the rebase branch. This comes from the
missing merged README and CHANGELOG and some inconsistent changes in my "80
chars per line" patch. I would like to encourage to merge that changes even if
the README has currently some outdated information.
I would also want to ask Daniel Seither, Simon Wunderlich and Marek Lindner to
check if I accidentally changed their patches in a way they don't want to
support. I know that the commit messages aren't up to date, but would like to
receive any kind of corrections for them.
I'm preparing a set of patches for GregKH for linux-next. I compared
the resulting mainline tree to maint and found a few
differences. These patches bring maint into line with linux-next.
I've no idea if these patches affect backwards compatibility with old
kernels. The last one might...
Andrew Lunn (4):
batman-adv: Update README to match mainline README.
batman-adv: Import sparse fixes from mainline.
batman-adv: whitespace fixes from mainline.
batman-adv: include cleanup: Update gfp.h and slab.h includes to
prepare for breaking implicit...
README | 35 +++++++++--------------------------
bat_sysfs.c | 9 ++++++---
bitarray.c | 2 +-
device.c | 3 +--
main.h | 5 +++--
routing.c | 3 ++-
send.c | 3 ++-
soft-interface.c | 2 +-
vis.c | 14 +++++++-------
9 files changed, 32 insertions(+), 44 deletions(-)