linux-merge

linux-merge@lists.open-mesh.org

3 participants
7433 discussions

Failed check next routing.c
by postmaster＠open-mesh.org 09 Mar '12

09 Mar '12

CHECK: Coalesced strings are easier to grep and less error prone #87: FILE: routing.c:87: + "Changing route towards: %pM " + "(now via %pM - was via %pM)\n", CHECK: braces {} should be used on all arms of this statement #234: FILE: routing.c:234: + if (has_timed_out(*last_reset, RESET_PROTECTION_MS)) { [...] + } else [...] CHECK: Coalesced strings are easier to grep and less error prone #349: FILE: routing.c:349: + pr_debug("Warning - can't forward icmp packet from %pM to " + "%pM: ttl exceeded\n", icmp_packet->orig, CHECK: Coalesced strings are easier to grep and less error prone #678: FILE: routing.c:678: + bat_dbg(DBG_TT, bat_priv, "Received ROAMING_ADV from %pM " + "(client %pM)\n", roam_adv_packet->src, CHECK: Coalesced strings are easier to grep and less error prone #817: FILE: routing.c:817: + pr_debug("Warning - can't forward unicast packet from %pM to " + "%pM: ttl exceeded\n", ethhdr->h_source, CHECK: Coalesced strings are easier to grep and less error prone #938: FILE: routing.c:938: + bat_dbg(DBG_ROUTES, bat_priv, "TTVN mismatch (old_ttvn %u " + "new_ttvn %u)! Rerouting unicast packet (for %pM) to " CHECK: Coalesced strings are easier to grep and less error prone #939: FILE: routing.c:939: + "new_ttvn %u)! Rerouting unicast packet (for %pM) to " + "%pM\n", unicast_packet->ttvn, curr_ttvn, total: 0 errors, 0 warnings, 7 checks, 1132 lines checked NOTE: Ignored message types: COMPLEX_MACRO routing.c has style problems, please review. If any of these errors are false positives, please report them to the maintainer, see CHECKPATCH in MAINTAINERS.

1 0

Failed check next originator.c
by postmaster＠open-mesh.org 09 Mar '12

09 Mar '12

CHECK: Coalesced strings are easier to grep and less error prone #298: FILE: originator.c:298: + "neighbor purge: originator %pM, " + "neighbor: %pM, iface: %s\n", CHECK: Coalesced strings are easier to grep and less error prone #304: FILE: originator.c:304: + "neighbor timeout: originator %pM, " + "neighbor: %pM, last_valid: %lu\n", CHECK: Coalesced strings are easier to grep and less error prone #420: FILE: originator.c:420: + ret = seq_printf(seq, "BATMAN mesh %s disabled - " + "please specify interfaces to enable it\n", CHECK: Coalesced strings are easier to grep and less error prone #427: FILE: originator.c:427: + ret = seq_printf(seq, "BATMAN mesh %s " + "disabled - primary interface not active\n", total: 0 errors, 0 warnings, 4 checks, 647 lines checked NOTE: Ignored message types: COMPLEX_MACRO originator.c has style problems, please review. If any of these errors are false positives, please report them to the maintainer, see CHECKPATCH in MAINTAINERS.

1 0

Failed check next main.h
by postmaster＠open-mesh.org 09 Mar '12

09 Mar '12

CHECK: Don't begin block comments with only a /* line, use /* comment... #110: FILE: main.h:110: + +/* CHECK: Don't begin block comments with only a /* line, use /* comment... #128: FILE: main.h:128: + +/* CHECK: Don't begin block comments with only a /* line, use /* comment... #132: FILE: main.h:132: + +/* total: 0 errors, 0 warnings, 3 checks, 245 lines checked NOTE: Ignored message types: COMPLEX_MACRO main.h has style problems, please review. If any of these errors are false positives, please report them to the maintainer, see CHECKPATCH in MAINTAINERS.

1 0

Failed check next main.c
by postmaster＠open-mesh.org 09 Mar '12

09 Mar '12

CHECK: Coalesced strings are easier to grep and less error prone #68: FILE: main.c:68: + pr_info("B.A.T.M.A.N. advanced %s (compatibility version %i) " + "loaded\n", SOURCE_VERSION, COMPAT_VERSION); CHECK: Coalesced strings are easier to grep and less error prone #205: FILE: main.c:205: + pr_info("Trying to register already registered routing " + "algorithm: %s\n", bat_algo_ops->name); total: 0 errors, 0 warnings, 2 checks, 291 lines checked NOTE: Ignored message types: COMPLEX_MACRO main.c has style problems, please review. If any of these errors are false positives, please report them to the maintainer, see CHECKPATCH in MAINTAINERS.

1 0

Failed check next icmp_socket.c
by postmaster＠open-mesh.org 09 Mar '12

09 Mar '12

CHECK: Coalesced strings are easier to grep and less error prone #63: FILE: icmp_socket.c:63: + pr_err("Error - can't add another packet client: " + "maximum number of clients reached\n"); CHECK: Coalesced strings are easier to grep and less error prone #166: FILE: icmp_socket.c:166: + "Error - can't send packet from char device: " + "invalid packet size\n"); CHECK: Coalesced strings are easier to grep and less error prone #197: FILE: icmp_socket.c:197: + "Error - can't send packet from char device: " + "got bogus packet type (expected: BAT_ICMP)\n"); CHECK: Coalesced strings are easier to grep and less error prone #205: FILE: icmp_socket.c:205: + "Error - can't send packet from char device: " + "got bogus message type (expected: ECHO_REQUEST)\n"); total: 0 errors, 0 warnings, 4 checks, 350 lines checked NOTE: Ignored message types: COMPLEX_MACRO icmp_socket.c has style problems, please review. If any of these errors are false positives, please report them to the maintainer, see CHECKPATCH in MAINTAINERS.

1 0

Failed check next hard-interface.c
by postmaster＠open-mesh.org 09 Mar '12

09 Mar '12

CHECK: Coalesced strings are easier to grep and less error prone #179: FILE: hard-interface.c:179: + pr_warning("The newly added mac address (%pM) already exists " + "on: %s\n", net_dev->dev_addr, CHECK: Coalesced strings are easier to grep and less error prone #182: FILE: hard-interface.c:182: + pr_warning("It is strongly recommended to keep mac addresses " + "unique to avoid problems!\n"); CHECK: Coalesced strings are easier to grep and less error prone #286: FILE: hard-interface.c:286: + pr_err("You are about to enable batman-adv on '%s' which " + "already is part of a bridge. Unless you know exactly " CHECK: Coalesced strings are easier to grep and less error prone #287: FILE: hard-interface.c:287: + "already is part of a bridge. Unless you know exactly " + "what you are doing this is probably wrong and won't " CHECK: Coalesced strings are easier to grep and less error prone #288: FILE: hard-interface.c:288: + "what you are doing this is probably wrong and won't " + "work the way you think it would.\n", CHECK: Coalesced strings are easier to grep and less error prone #307: FILE: hard-interface.c:307: + pr_err("Can't create batman mesh interface %s: " + "already exists as regular interface\n", CHECK: Coalesced strings are easier to grep and less error prone #321: FILE: hard-interface.c:321: + bat_err(hard_iface->soft_iface, "Can't add interface packet " + "(%s): out of memory\n", hard_iface->net_dev->name); CHECK: Coalesced strings are easier to grep and less error prone #345: FILE: hard-interface.c:345: + "The MTU of interface %s is too small (%i) to handle " + "the transport of batman-adv packets. Packets going " CHECK: Coalesced strings are easier to grep and less error prone #346: FILE: hard-interface.c:346: + "the transport of batman-adv packets. Packets going " + "over this interface will be fragmented on layer2 " CHECK: Coalesced strings are easier to grep and less error prone #347: FILE: hard-interface.c:347: + "over this interface will be fragmented on layer2 " + "which could impact the performance. Setting the MTU " CHECK: Coalesced strings are easier to grep and less error prone #348: FILE: hard-interface.c:348: + "which could impact the performance. Setting the MTU " + "to %zi would solve the problem.\n", CHECK: Coalesced strings are easier to grep and less error prone #356: FILE: hard-interface.c:356: + "The MTU of interface %s is too small (%i) to handle " + "the transport of batman-adv packets. If you " CHECK: Coalesced strings are easier to grep and less error prone #357: FILE: hard-interface.c:357: + "the transport of batman-adv packets. If you " + "experience problems getting traffic through try " CHECK: Coalesced strings are easier to grep and less error prone #358: FILE: hard-interface.c:358: + "experience problems getting traffic through try " + "increasing the MTU to %zi.\n", CHECK: Coalesced strings are easier to grep and less error prone #366: FILE: hard-interface.c:366: + bat_err(hard_iface->soft_iface, "Not using interface %s " + "(retrying later): interface not active\n", total: 0 errors, 0 warnings, 15 checks, 700 lines checked NOTE: Ignored message types: COMPLEX_MACRO hard-interface.c has style problems, please review. If any of these errors are false positives, please report them to the maintainer, see CHECKPATCH in MAINTAINERS.

1 0

Failed check next gateway_client.c
by postmaster＠open-mesh.org 09 Mar '12

09 Mar '12

CHECK: Coalesced strings are easier to grep and less error prone #234: FILE: gateway_client.c:234: + "Changing route to gateway %pM " + "(gw_flags: %i, tq: %i)\n", CHECK: Coalesced strings are easier to grep and less error prone #291: FILE: gateway_client.c:291: + "Restarting gateway selection: better gateway found (tq curr: " + "%i, tq new: %i)\n", CHECK: Coalesced strings are easier to grep and less error prone #356: FILE: gateway_client.c:356: + "Gateway class of originator %pM changed from " + "%i to %i\n", CHECK: Coalesced strings are easier to grep and less error prone #478: FILE: gateway_client.c:478: + ret = seq_printf(seq, "BATMAN mesh %s disabled - please " + "specify interfaces to enable it\n", CHECK: Coalesced strings are easier to grep and less error prone #485: FILE: gateway_client.c:485: + ret = seq_printf(seq, "BATMAN mesh %s disabled - " + "primary interface not active\n", CHECK: Coalesced strings are easier to grep and less error prone #491: FILE: gateway_client.c:491: + seq_printf(seq, " %-12s (%s/%i) %17s [%10s]: gw_class ... " + "[B.A.T.M.A.N. adv %s, MainIF/MAC: %s/%pM (%s)]\n", total: 0 errors, 0 warnings, 6 checks, 714 lines checked NOTE: Ignored message types: COMPLEX_MACRO gateway_client.c has style problems, please review. If any of these errors are false positives, please report them to the maintainer, see CHECKPATCH in MAINTAINERS.

1 0

Failed check next gateway_common.c
by postmaster＠open-mesh.org 09 Mar '12

09 Mar '12

CHECK: Coalesced strings are easier to grep and less error prone #129: FILE: gateway_common.c:129: + "Upload speed of gateway mode invalid: " + "%s\n", slash_ptr + 1); CHECK: Coalesced strings are easier to grep and less error prone #167: FILE: gateway_common.c:167: + bat_info(net_dev, "Changing gateway bandwidth from: '%i' to: '%ld' " + "(propagating: %d%s/%d%s)\n", total: 0 errors, 0 warnings, 2 checks, 178 lines checked NOTE: Ignored message types: COMPLEX_MACRO gateway_common.c has style problems, please review. If any of these errors are false positives, please report them to the maintainer, see CHECKPATCH in MAINTAINERS.

1 0

Failed check next bat_sysfs.c
by postmaster＠open-mesh.org 09 Mar '12

09 Mar '12

CHECK: Coalesced strings are easier to grep and less error prone #259: FILE: bat_sysfs.c:259: + "Invalid parameter for 'vis mode' setting received: " + "%s\n", buff); CHECK: Coalesced strings are easier to grep and less error prone #334: FILE: bat_sysfs.c:334: + "Invalid parameter for 'gw mode' setting received: " + "%s\n", buff); CHECK: Coalesced strings are easier to grep and less error prone #506: FILE: bat_sysfs.c:506: + pr_err("Invalid parameter for 'mesh_iface' setting received: " + "interface name too long '%s'\n", buff); CHECK: Coalesced strings are easier to grep and less error prone #681: FILE: bat_sysfs.c:681: + bat_dbg(DBG_BATMAN, bat_priv, "Impossible to send " + "uevent for (%s,%s,%s) event (err: %d)\n", total: 0 errors, 0 warnings, 4 checks, 685 lines checked NOTE: Ignored message types: COMPLEX_MACRO bat_sysfs.c has style problems, please review. If any of these errors are false positives, please report them to the maintainer, see CHECKPATCH in MAINTAINERS.

1 0

Failed check next bat_iv_ogm.c
by postmaster＠open-mesh.org 09 Mar '12

09 Mar '12

CHECK: Coalesced strings are easier to grep and less error prone #136: FILE: bat_iv_ogm.c:136: + "%s %spacket (originator %pM, seqno %d, TQ %d, TTL %d," + " IDF %s, ttvn %d) on interface %s [%pM]\n", CHECK: Coalesced strings are easier to grep and less error prone #175: FILE: bat_iv_ogm.c:175: + pr_err("Error - can't forward packet: incoming iface not " + "specified\n"); CHECK: Coalesced strings are easier to grep and less error prone #197: FILE: bat_iv_ogm.c:197: + "%s packet (originator %pM, seqno %d, TTL %d) " + "on interface %s [%pM]\n", CHECK: Coalesced strings are easier to grep and less error prone #512: FILE: bat_iv_ogm.c:512: + "Forwarding packet: tq_orig: %i, tq_avg: %i, " + "tq_forw: %i, ttl_orig: %i, ttl_forw: %i\n", CHECK: Coalesced strings are easier to grep and less error prone #593: FILE: bat_iv_ogm.c:593: + bat_dbg(DBG_BATMAN, bat_priv, "update_originator(): " + "Searching and updating originator entry of received packet\n"); CHECK: Don't begin block comments with only a /* line, use /* comment... #786: FILE: bat_iv_ogm.c:786: + + /* CHECK: Coalesced strings are easier to grep and less error prone #806: FILE: bat_iv_ogm.c:806: + "bidirectional: " + "orig = %-15pM neigh = %-15pM => own_bcast = %2i, " CHECK: Coalesced strings are easier to grep and less error prone #807: FILE: bat_iv_ogm.c:807: + "orig = %-15pM neigh = %-15pM => own_bcast = %2i, " + "real recv = %2i, local tq: %3i, asym_penalty: %3i, " CHECK: Coalesced strings are easier to grep and less error prone #808: FILE: bat_iv_ogm.c:808: + "real recv = %2i, local tq: %3i, asym_penalty: %3i, " + "total tq: %3i\n", CHECK: Coalesced strings are easier to grep and less error prone #937: FILE: bat_iv_ogm.c:937: + "Received BATMAN packet via NB: %pM, IF: %s [%pM] " + "(from OG: %pM, via prev OG: %pM, seqno %d, ttvn %u, " CHECK: Coalesced strings are easier to grep and less error prone #938: FILE: bat_iv_ogm.c:938: + "(from OG: %pM, via prev OG: %pM, seqno %d, ttvn %u, " + "crc %u, changes %u, td %d, TTL %d, V %d, IDF %d)\n", CHECK: Coalesced strings are easier to grep and less error prone #982: FILE: bat_iv_ogm.c:982: + "Drop packet: received my own broadcast (sender: %pM" + ")\n", CHECK: Coalesced strings are easier to grep and less error prone #989: FILE: bat_iv_ogm.c:989: + bat_dbg(DBG_BATMAN, bat_priv, "Drop packet: " + "ignoring all packets with broadcast source addr (sender: %pM" CHECK: Coalesced strings are easier to grep and less error prone #990: FILE: bat_iv_ogm.c:990: + "ignoring all packets with broadcast source addr (sender: %pM" + ")\n", ethhdr->h_source); CHECK: Coalesced strings are easier to grep and less error prone #1021: FILE: bat_iv_ogm.c:1021: + bat_dbg(DBG_BATMAN, bat_priv, "Drop packet: " + "originator packet from myself (via neighbor)\n"); CHECK: Coalesced strings are easier to grep and less error prone #1029: FILE: bat_iv_ogm.c:1029: + "Drop packet: ignoring all rebroadcast echos (sender: " + "%pM)\n", ethhdr->h_source); CHECK: Coalesced strings are easier to grep and less error prone #1043: FILE: bat_iv_ogm.c:1043: + "Drop packet: packet within seqno protection time " + "(sender: %pM)\n", ethhdr->h_source); CHECK: Coalesced strings are easier to grep and less error prone #1065: FILE: bat_iv_ogm.c:1065: + "Drop packet: ignoring all rebroadcast packets that " + "may make me loop (sender: %pM)\n", ethhdr->h_source); CHECK: Coalesced strings are easier to grep and less error prone #1110: FILE: bat_iv_ogm.c:1110: + bat_dbg(DBG_BATMAN, bat_priv, "Forwarding packet: " + "rebroadcast neighbor packet with direct link flag\n"); total: 0 errors, 0 warnings, 19 checks, 1193 lines checked NOTE: Ignored message types: COMPLEX_MACRO bat_iv_ogm.c has style problems, please review. If any of these errors are false positives, please report them to the maintainer, see CHECKPATCH in MAINTAINERS.

1 0

Jump to page:

2024

2023

2022

2021

2020

2019

2018

2017

2016

2015

2014

2013

2012

2011

linux-merge