Build check errors found: 2015-02-28
by postmaster＠open-mesh.org
Name of failed tests
====================
checkpatch next main.h
checkpatch next network-coding.c
checkpatch next soft-interface.c
Output of different failed tests
================================
checkpatch next main.h:
>>>>>>>>
CHECK: spaces preferred around that '*' (ctx:VxV)
#47: FILE: main.h:47:
+#define BATADV_DAT_ENTRY_TIMEOUT (5*60000) /* 5 mins in milliseconds */
^
total: 0 errors, 0 warnings, 1 checks, 390 lines checked
checkpatch next network-coding.c:
>>>>>>>>
CHECK: spaces preferred around that '*' (ctx:VxV)
#278: FILE: network-coding.c:278:
+ bat_priv->nc.max_buffer_time*10);
^
total: 0 errors, 0 warnings, 1 checks, 1936 lines checked
checkpatch next soft-interface.c:
>>>>>>>>
CHECK: Comparison to NULL could be written "hard_iface->soft_iface"
#827: FILE: soft-interface.c:827:
+ if (!hard_iface || hard_iface->soft_iface != NULL)
total: 0 errors, 0 warnings, 1 checks, 1113 lines checked
7 years, 2 months
Build check errors found: 2015-02-27
by postmaster＠open-mesh.org
Name of failed tests
====================
checkpatch master main.c
checkpatch next main.c
checkpatch next main.h
checkpatch next network-coding.c
checkpatch next soft-interface.c
Output of different failed tests
================================
checkpatch next main.c:
>>>>>>>>
CHECK: No space is necessary after a cast
#440: FILE: main.c:440:
+ BUILD_BUG_ON(sizeof(struct batadv_bla_claim_dst) != 6);
CHECK: No space is necessary after a cast
#441: FILE: main.c:441:
+ BUILD_BUG_ON(sizeof(struct batadv_ogm_packet) != 24);
CHECK: No space is necessary after a cast
#442: FILE: main.c:442:
+ BUILD_BUG_ON(sizeof(struct batadv_icmp_header) != 20);
CHECK: No space is necessary after a cast
#443: FILE: main.c:443:
+ BUILD_BUG_ON(sizeof(struct batadv_icmp_packet) != 20);
CHECK: No space is necessary after a cast
#444: FILE: main.c:444:
+ BUILD_BUG_ON(sizeof(struct batadv_icmp_packet_rr) != 116);
CHECK: No space is necessary after a cast
#445: FILE: main.c:445:
+ BUILD_BUG_ON(sizeof(struct batadv_unicast_packet) != 10);
CHECK: No space is necessary after a cast
#446: FILE: main.c:446:
+ BUILD_BUG_ON(sizeof(struct batadv_unicast_4addr_packet) != 18);
CHECK: No space is necessary after a cast
#447: FILE: main.c:447:
+ BUILD_BUG_ON(sizeof(struct batadv_frag_packet) != 20);
CHECK: No space is necessary after a cast
#448: FILE: main.c:448:
+ BUILD_BUG_ON(sizeof(struct batadv_bcast_packet) != 14);
CHECK: No space is necessary after a cast
#449: FILE: main.c:449:
+ BUILD_BUG_ON(sizeof(struct batadv_coded_packet) != 46);
CHECK: No space is necessary after a cast
#450: FILE: main.c:450:
+ BUILD_BUG_ON(sizeof(struct batadv_unicast_tvlv_packet) != 20);
CHECK: No space is necessary after a cast
#451: FILE: main.c:451:
+ BUILD_BUG_ON(sizeof(struct batadv_tvlv_hdr) != 4);
CHECK: No space is necessary after a cast
#452: FILE: main.c:452:
+ BUILD_BUG_ON(sizeof(struct batadv_tvlv_gateway_data) != 8);
CHECK: No space is necessary after a cast
#453: FILE: main.c:453:
+ BUILD_BUG_ON(sizeof(struct batadv_tvlv_tt_vlan_data) != 8);
CHECK: No space is necessary after a cast
#454: FILE: main.c:454:
+ BUILD_BUG_ON(sizeof(struct batadv_tvlv_tt_change) != 12);
CHECK: No space is necessary after a cast
#455: FILE: main.c:455:
+ BUILD_BUG_ON(sizeof(struct batadv_tvlv_roam_adv) != 8);
total: 0 errors, 0 warnings, 16 checks, 1265 lines checked
checkpatch next main.h:
>>>>>>>>
CHECK: spaces preferred around that '*' (ctx:VxV)
#47: FILE: main.h:47:
+#define BATADV_DAT_ENTRY_TIMEOUT (5*60000) /* 5 mins in milliseconds */
^
total: 0 errors, 0 warnings, 1 checks, 390 lines checked
checkpatch next network-coding.c:
>>>>>>>>
CHECK: spaces preferred around that '*' (ctx:VxV)
#278: FILE: network-coding.c:278:
+ bat_priv->nc.max_buffer_time*10);
^
total: 0 errors, 0 warnings, 1 checks, 1936 lines checked
checkpatch next soft-interface.c:
>>>>>>>>
CHECK: Comparison to NULL could be written "hard_iface->soft_iface"
#827: FILE: soft-interface.c:827:
+ if (!hard_iface || hard_iface->soft_iface != NULL)
total: 0 errors, 0 warnings, 1 checks, 1113 lines checked
7 years, 2 months
Build check errors found: 2015-02-26
by postmaster＠open-mesh.org
Name of failed tests
====================
checkpatch master main.c
checkpatch next main.c
checkpatch next main.h
checkpatch next network-coding.c
checkpatch next soft-interface.c
Output of different failed tests
================================
checkpatch next main.c:
>>>>>>>>
CHECK: No space is necessary after a cast
#440: FILE: main.c:440:
+ BUILD_BUG_ON(sizeof(struct batadv_bla_claim_dst) != 6);
CHECK: No space is necessary after a cast
#441: FILE: main.c:441:
+ BUILD_BUG_ON(sizeof(struct batadv_ogm_packet) != 24);
CHECK: No space is necessary after a cast
#442: FILE: main.c:442:
+ BUILD_BUG_ON(sizeof(struct batadv_icmp_header) != 20);
CHECK: No space is necessary after a cast
#443: FILE: main.c:443:
+ BUILD_BUG_ON(sizeof(struct batadv_icmp_packet) != 20);
CHECK: No space is necessary after a cast
#444: FILE: main.c:444:
+ BUILD_BUG_ON(sizeof(struct batadv_icmp_packet_rr) != 116);
CHECK: No space is necessary after a cast
#445: FILE: main.c:445:
+ BUILD_BUG_ON(sizeof(struct batadv_unicast_packet) != 10);
CHECK: No space is necessary after a cast
#446: FILE: main.c:446:
+ BUILD_BUG_ON(sizeof(struct batadv_unicast_4addr_packet) != 18);
CHECK: No space is necessary after a cast
#447: FILE: main.c:447:
+ BUILD_BUG_ON(sizeof(struct batadv_frag_packet) != 20);
CHECK: No space is necessary after a cast
#448: FILE: main.c:448:
+ BUILD_BUG_ON(sizeof(struct batadv_bcast_packet) != 14);
CHECK: No space is necessary after a cast
#449: FILE: main.c:449:
+ BUILD_BUG_ON(sizeof(struct batadv_coded_packet) != 46);
CHECK: No space is necessary after a cast
#450: FILE: main.c:450:
+ BUILD_BUG_ON(sizeof(struct batadv_unicast_tvlv_packet) != 20);
CHECK: No space is necessary after a cast
#451: FILE: main.c:451:
+ BUILD_BUG_ON(sizeof(struct batadv_tvlv_hdr) != 4);
CHECK: No space is necessary after a cast
#452: FILE: main.c:452:
+ BUILD_BUG_ON(sizeof(struct batadv_tvlv_gateway_data) != 8);
CHECK: No space is necessary after a cast
#453: FILE: main.c:453:
+ BUILD_BUG_ON(sizeof(struct batadv_tvlv_tt_vlan_data) != 8);
CHECK: No space is necessary after a cast
#454: FILE: main.c:454:
+ BUILD_BUG_ON(sizeof(struct batadv_tvlv_tt_change) != 12);
CHECK: No space is necessary after a cast
#455: FILE: main.c:455:
+ BUILD_BUG_ON(sizeof(struct batadv_tvlv_roam_adv) != 8);
total: 0 errors, 0 warnings, 16 checks, 1265 lines checked
checkpatch next main.h:
>>>>>>>>
CHECK: spaces preferred around that '*' (ctx:VxV)
#47: FILE: main.h:47:
+#define BATADV_DAT_ENTRY_TIMEOUT (5*60000) /* 5 mins in milliseconds */
^
total: 0 errors, 0 warnings, 1 checks, 390 lines checked
checkpatch next network-coding.c:
>>>>>>>>
CHECK: spaces preferred around that '*' (ctx:VxV)
#278: FILE: network-coding.c:278:
+ bat_priv->nc.max_buffer_time*10);
^
total: 0 errors, 0 warnings, 1 checks, 1936 lines checked
checkpatch next soft-interface.c:
>>>>>>>>
CHECK: Comparison to NULL could be written "hard_iface->soft_iface"
#827: FILE: soft-interface.c:827:
+ if (!hard_iface || hard_iface->soft_iface != NULL)
total: 0 errors, 0 warnings, 1 checks, 1113 lines checked
7 years, 2 months
Build check errors found: 2015-02-25
by postmaster＠open-mesh.org
Name of failed tests
====================
checkpatch master main.c
checkpatch next main.c
checkpatch next main.h
checkpatch next network-coding.c
checkpatch next soft-interface.c
Output of different failed tests
================================
checkpatch next main.c:
>>>>>>>>
CHECK: No space is necessary after a cast
#440: FILE: main.c:440:
+ BUILD_BUG_ON(sizeof(struct batadv_bla_claim_dst) != 6);
CHECK: No space is necessary after a cast
#441: FILE: main.c:441:
+ BUILD_BUG_ON(sizeof(struct batadv_ogm_packet) != 24);
CHECK: No space is necessary after a cast
#442: FILE: main.c:442:
+ BUILD_BUG_ON(sizeof(struct batadv_icmp_header) != 20);
CHECK: No space is necessary after a cast
#443: FILE: main.c:443:
+ BUILD_BUG_ON(sizeof(struct batadv_icmp_packet) != 20);
CHECK: No space is necessary after a cast
#444: FILE: main.c:444:
+ BUILD_BUG_ON(sizeof(struct batadv_icmp_packet_rr) != 116);
CHECK: No space is necessary after a cast
#445: FILE: main.c:445:
+ BUILD_BUG_ON(sizeof(struct batadv_unicast_packet) != 10);
CHECK: No space is necessary after a cast
#446: FILE: main.c:446:
+ BUILD_BUG_ON(sizeof(struct batadv_unicast_4addr_packet) != 18);
CHECK: No space is necessary after a cast
#447: FILE: main.c:447:
+ BUILD_BUG_ON(sizeof(struct batadv_frag_packet) != 20);
CHECK: No space is necessary after a cast
#448: FILE: main.c:448:
+ BUILD_BUG_ON(sizeof(struct batadv_bcast_packet) != 14);
CHECK: No space is necessary after a cast
#449: FILE: main.c:449:
+ BUILD_BUG_ON(sizeof(struct batadv_coded_packet) != 46);
CHECK: No space is necessary after a cast
#450: FILE: main.c:450:
+ BUILD_BUG_ON(sizeof(struct batadv_unicast_tvlv_packet) != 20);
CHECK: No space is necessary after a cast
#451: FILE: main.c:451:
+ BUILD_BUG_ON(sizeof(struct batadv_tvlv_hdr) != 4);
CHECK: No space is necessary after a cast
#452: FILE: main.c:452:
+ BUILD_BUG_ON(sizeof(struct batadv_tvlv_gateway_data) != 8);
CHECK: No space is necessary after a cast
#453: FILE: main.c:453:
+ BUILD_BUG_ON(sizeof(struct batadv_tvlv_tt_vlan_data) != 8);
CHECK: No space is necessary after a cast
#454: FILE: main.c:454:
+ BUILD_BUG_ON(sizeof(struct batadv_tvlv_tt_change) != 12);
CHECK: No space is necessary after a cast
#455: FILE: main.c:455:
+ BUILD_BUG_ON(sizeof(struct batadv_tvlv_roam_adv) != 8);
total: 0 errors, 0 warnings, 16 checks, 1265 lines checked
checkpatch next main.h:
>>>>>>>>
CHECK: spaces preferred around that '*' (ctx:VxV)
#47: FILE: main.h:47:
+#define BATADV_DAT_ENTRY_TIMEOUT (5*60000) /* 5 mins in milliseconds */
^
total: 0 errors, 0 warnings, 1 checks, 390 lines checked
checkpatch next network-coding.c:
>>>>>>>>
CHECK: spaces preferred around that '*' (ctx:VxV)
#278: FILE: network-coding.c:278:
+ bat_priv->nc.max_buffer_time*10);
^
total: 0 errors, 0 warnings, 1 checks, 1936 lines checked
checkpatch next soft-interface.c:
>>>>>>>>
CHECK: Comparison to NULL could be written "hard_iface->soft_iface"
#827: FILE: soft-interface.c:827:
+ if (!hard_iface || hard_iface->soft_iface != NULL)
total: 0 errors, 0 warnings, 1 checks, 1113 lines checked
7 years, 2 months
Build check errors found: 2015-02-24
by postmaster＠open-mesh.org
Name of failed tests
====================
checkpatch master main.c
checkpatch next main.c
checkpatch next main.h
checkpatch next network-coding.c
checkpatch next soft-interface.c
Output of different failed tests
================================
checkpatch next main.c:
>>>>>>>>
CHECK: No space is necessary after a cast
#440: FILE: main.c:440:
+ BUILD_BUG_ON(sizeof(struct batadv_bla_claim_dst) != 6);
CHECK: No space is necessary after a cast
#441: FILE: main.c:441:
+ BUILD_BUG_ON(sizeof(struct batadv_ogm_packet) != 24);
CHECK: No space is necessary after a cast
#442: FILE: main.c:442:
+ BUILD_BUG_ON(sizeof(struct batadv_icmp_header) != 20);
CHECK: No space is necessary after a cast
#443: FILE: main.c:443:
+ BUILD_BUG_ON(sizeof(struct batadv_icmp_packet) != 20);
CHECK: No space is necessary after a cast
#444: FILE: main.c:444:
+ BUILD_BUG_ON(sizeof(struct batadv_icmp_packet_rr) != 116);
CHECK: No space is necessary after a cast
#445: FILE: main.c:445:
+ BUILD_BUG_ON(sizeof(struct batadv_unicast_packet) != 10);
CHECK: No space is necessary after a cast
#446: FILE: main.c:446:
+ BUILD_BUG_ON(sizeof(struct batadv_unicast_4addr_packet) != 18);
CHECK: No space is necessary after a cast
#447: FILE: main.c:447:
+ BUILD_BUG_ON(sizeof(struct batadv_frag_packet) != 20);
CHECK: No space is necessary after a cast
#448: FILE: main.c:448:
+ BUILD_BUG_ON(sizeof(struct batadv_bcast_packet) != 14);
CHECK: No space is necessary after a cast
#449: FILE: main.c:449:
+ BUILD_BUG_ON(sizeof(struct batadv_coded_packet) != 46);
CHECK: No space is necessary after a cast
#450: FILE: main.c:450:
+ BUILD_BUG_ON(sizeof(struct batadv_unicast_tvlv_packet) != 20);
CHECK: No space is necessary after a cast
#451: FILE: main.c:451:
+ BUILD_BUG_ON(sizeof(struct batadv_tvlv_hdr) != 4);
CHECK: No space is necessary after a cast
#452: FILE: main.c:452:
+ BUILD_BUG_ON(sizeof(struct batadv_tvlv_gateway_data) != 8);
CHECK: No space is necessary after a cast
#453: FILE: main.c:453:
+ BUILD_BUG_ON(sizeof(struct batadv_tvlv_tt_vlan_data) != 8);
CHECK: No space is necessary after a cast
#454: FILE: main.c:454:
+ BUILD_BUG_ON(sizeof(struct batadv_tvlv_tt_change) != 12);
CHECK: No space is necessary after a cast
#455: FILE: main.c:455:
+ BUILD_BUG_ON(sizeof(struct batadv_tvlv_roam_adv) != 8);
total: 0 errors, 0 warnings, 16 checks, 1265 lines checked
checkpatch next main.h:
>>>>>>>>
CHECK: spaces preferred around that '*' (ctx:VxV)
#47: FILE: main.h:47:
+#define BATADV_DAT_ENTRY_TIMEOUT (5*60000) /* 5 mins in milliseconds */
^
total: 0 errors, 0 warnings, 1 checks, 390 lines checked
checkpatch next network-coding.c:
>>>>>>>>
CHECK: spaces preferred around that '*' (ctx:VxV)
#278: FILE: network-coding.c:278:
+ bat_priv->nc.max_buffer_time*10);
^
total: 0 errors, 0 warnings, 1 checks, 1936 lines checked
checkpatch next soft-interface.c:
>>>>>>>>
CHECK: Comparison to NULL could be written "hard_iface->soft_iface"
#827: FILE: soft-interface.c:827:
+ if (!hard_iface || hard_iface->soft_iface != NULL)
total: 0 errors, 0 warnings, 1 checks, 1113 lines checked
7 years, 2 months
[linux-next] LinuxNextTracking branch, master, updated. next-20150223
by batman＠open-mesh.org
The following commit has been merged in the master branch:
commit 92b839175064632813a7c4b7e180efde4c08c850
Author: Joe Perches <joe(a)perches.com>
Date: Sun Feb 22 13:47:56 2015 -0800
batman-adv: Fix use of seq_has_overflowed()
net-next commit 6d91147d183c ("batman-adv: Remove uses of return value
of seq_printf") incorrectly changed the overflow occurred return from
-1 to 1. Change it back so that the test of batadv_write_buffer_text's
return value in batadv_gw_client_seq_print_text works properly.
Signed-off-by: Joe Perches <joe(a)perches.com>
Signed-off-by: David S. Miller <davem(a)davemloft.net>
diff --git a/net/batman-adv/gateway_client.c b/net/batman-adv/gateway_client.c
index a0876ea..090828c 100644
--- a/net/batman-adv/gateway_client.c
+++ b/net/batman-adv/gateway_client.c
@@ -601,7 +601,7 @@ static int batadv_write_buffer_text(struct batadv_priv *bat_priv,
gw_node->bandwidth_down % 10,
gw_node->bandwidth_up / 10,
gw_node->bandwidth_up % 10);
- ret = seq_has_overflowed(seq);
+ ret = seq_has_overflowed(seq) ? -1 : 0;
if (curr_gw)
batadv_gw_node_free_ref(curr_gw);
--
LinuxNextTracking
7 years, 2 months
Build check errors found: 2015-02-23
by postmaster＠open-mesh.org
Name of failed tests
====================
checkpatch master main.c
checkpatch next main.c
checkpatch next main.h
checkpatch next network-coding.c
checkpatch next soft-interface.c
Output of different failed tests
================================
checkpatch next main.c:
>>>>>>>>
CHECK: No space is necessary after a cast
#440: FILE: main.c:440:
+ BUILD_BUG_ON(sizeof(struct batadv_bla_claim_dst) != 6);
CHECK: No space is necessary after a cast
#441: FILE: main.c:441:
+ BUILD_BUG_ON(sizeof(struct batadv_ogm_packet) != 24);
CHECK: No space is necessary after a cast
#442: FILE: main.c:442:
+ BUILD_BUG_ON(sizeof(struct batadv_icmp_header) != 20);
CHECK: No space is necessary after a cast
#443: FILE: main.c:443:
+ BUILD_BUG_ON(sizeof(struct batadv_icmp_packet) != 20);
CHECK: No space is necessary after a cast
#444: FILE: main.c:444:
+ BUILD_BUG_ON(sizeof(struct batadv_icmp_packet_rr) != 116);
CHECK: No space is necessary after a cast
#445: FILE: main.c:445:
+ BUILD_BUG_ON(sizeof(struct batadv_unicast_packet) != 10);
CHECK: No space is necessary after a cast
#446: FILE: main.c:446:
+ BUILD_BUG_ON(sizeof(struct batadv_unicast_4addr_packet) != 18);
CHECK: No space is necessary after a cast
#447: FILE: main.c:447:
+ BUILD_BUG_ON(sizeof(struct batadv_frag_packet) != 20);
CHECK: No space is necessary after a cast
#448: FILE: main.c:448:
+ BUILD_BUG_ON(sizeof(struct batadv_bcast_packet) != 14);
CHECK: No space is necessary after a cast
#449: FILE: main.c:449:
+ BUILD_BUG_ON(sizeof(struct batadv_coded_packet) != 46);
CHECK: No space is necessary after a cast
#450: FILE: main.c:450:
+ BUILD_BUG_ON(sizeof(struct batadv_unicast_tvlv_packet) != 20);
CHECK: No space is necessary after a cast
#451: FILE: main.c:451:
+ BUILD_BUG_ON(sizeof(struct batadv_tvlv_hdr) != 4);
CHECK: No space is necessary after a cast
#452: FILE: main.c:452:
+ BUILD_BUG_ON(sizeof(struct batadv_tvlv_gateway_data) != 8);
CHECK: No space is necessary after a cast
#453: FILE: main.c:453:
+ BUILD_BUG_ON(sizeof(struct batadv_tvlv_tt_vlan_data) != 8);
CHECK: No space is necessary after a cast
#454: FILE: main.c:454:
+ BUILD_BUG_ON(sizeof(struct batadv_tvlv_tt_change) != 12);
CHECK: No space is necessary after a cast
#455: FILE: main.c:455:
+ BUILD_BUG_ON(sizeof(struct batadv_tvlv_roam_adv) != 8);
total: 0 errors, 0 warnings, 16 checks, 1265 lines checked
checkpatch next main.h:
>>>>>>>>
CHECK: spaces preferred around that '*' (ctx:VxV)
#47: FILE: main.h:47:
+#define BATADV_DAT_ENTRY_TIMEOUT (5*60000) /* 5 mins in milliseconds */
^
total: 0 errors, 0 warnings, 1 checks, 390 lines checked
checkpatch next network-coding.c:
>>>>>>>>
CHECK: spaces preferred around that '*' (ctx:VxV)
#278: FILE: network-coding.c:278:
+ bat_priv->nc.max_buffer_time*10);
^
total: 0 errors, 0 warnings, 1 checks, 1936 lines checked
checkpatch next soft-interface.c:
>>>>>>>>
CHECK: Comparison to NULL could be written "hard_iface->soft_iface"
#827: FILE: soft-interface.c:827:
+ if (!hard_iface || hard_iface->soft_iface != NULL)
total: 0 errors, 0 warnings, 1 checks, 1113 lines checked
7 years, 2 months
[linux-next] LinuxNextTracking branch, master, updated. next-20150222
by batman＠open-mesh.org
The following commit has been merged in the master branch:
commit 6d91147d183c87d290f3b062d3fbf1ede312b449
Author: Joe Perches <joe(a)perches.com>
Date: Mon Feb 16 17:31:39 2015 -0800
batman-adv: Remove uses of return value of seq_printf
This function is soon going to return void so remove the
return value use.
Convert the return value to test seq_has_overflowed() instead.
Signed-off-by: Joe Perches <joe(a)perches.com>
Acked-by: Antonio Quartulli <antonio(a)meshcoding.com>
Signed-off-by: David S. Miller <davem(a)davemloft.net>
diff --git a/net/batman-adv/gateway_client.c b/net/batman-adv/gateway_client.c
index 27649e8..a0876ea 100644
--- a/net/batman-adv/gateway_client.c
+++ b/net/batman-adv/gateway_client.c
@@ -592,15 +592,16 @@ static int batadv_write_buffer_text(struct batadv_priv *bat_priv,
curr_gw = batadv_gw_get_selected_gw_node(bat_priv);
- ret = seq_printf(seq, "%s %pM (%3i) %pM [%10s]: %u.%u/%u.%u MBit\n",
- (curr_gw == gw_node ? "=>" : " "),
- gw_node->orig_node->orig,
- router_ifinfo->bat_iv.tq_avg, router->addr,
- router->if_incoming->net_dev->name,
- gw_node->bandwidth_down / 10,
- gw_node->bandwidth_down % 10,
- gw_node->bandwidth_up / 10,
- gw_node->bandwidth_up % 10);
+ seq_printf(seq, "%s %pM (%3i) %pM [%10s]: %u.%u/%u.%u MBit\n",
+ (curr_gw == gw_node ? "=>" : " "),
+ gw_node->orig_node->orig,
+ router_ifinfo->bat_iv.tq_avg, router->addr,
+ router->if_incoming->net_dev->name,
+ gw_node->bandwidth_down / 10,
+ gw_node->bandwidth_down % 10,
+ gw_node->bandwidth_up / 10,
+ gw_node->bandwidth_up % 10);
+ ret = seq_has_overflowed(seq);
if (curr_gw)
batadv_gw_node_free_ref(curr_gw);
--
LinuxNextTracking
7 years, 2 months
Build check errors found: 2015-02-22
by postmaster＠open-mesh.org
Name of failed tests
====================
checkpatch master main.c
checkpatch next main.c
checkpatch next main.h
checkpatch next network-coding.c
checkpatch next soft-interface.c
Output of different failed tests
================================
checkpatch next main.c:
>>>>>>>>
CHECK: No space is necessary after a cast
#440: FILE: main.c:440:
+ BUILD_BUG_ON(sizeof(struct batadv_bla_claim_dst) != 6);
CHECK: No space is necessary after a cast
#441: FILE: main.c:441:
+ BUILD_BUG_ON(sizeof(struct batadv_ogm_packet) != 24);
CHECK: No space is necessary after a cast
#442: FILE: main.c:442:
+ BUILD_BUG_ON(sizeof(struct batadv_icmp_header) != 20);
CHECK: No space is necessary after a cast
#443: FILE: main.c:443:
+ BUILD_BUG_ON(sizeof(struct batadv_icmp_packet) != 20);
CHECK: No space is necessary after a cast
#444: FILE: main.c:444:
+ BUILD_BUG_ON(sizeof(struct batadv_icmp_packet_rr) != 116);
CHECK: No space is necessary after a cast
#445: FILE: main.c:445:
+ BUILD_BUG_ON(sizeof(struct batadv_unicast_packet) != 10);
CHECK: No space is necessary after a cast
#446: FILE: main.c:446:
+ BUILD_BUG_ON(sizeof(struct batadv_unicast_4addr_packet) != 18);
CHECK: No space is necessary after a cast
#447: FILE: main.c:447:
+ BUILD_BUG_ON(sizeof(struct batadv_frag_packet) != 20);
CHECK: No space is necessary after a cast
#448: FILE: main.c:448:
+ BUILD_BUG_ON(sizeof(struct batadv_bcast_packet) != 14);
CHECK: No space is necessary after a cast
#449: FILE: main.c:449:
+ BUILD_BUG_ON(sizeof(struct batadv_coded_packet) != 46);
CHECK: No space is necessary after a cast
#450: FILE: main.c:450:
+ BUILD_BUG_ON(sizeof(struct batadv_unicast_tvlv_packet) != 20);
CHECK: No space is necessary after a cast
#451: FILE: main.c:451:
+ BUILD_BUG_ON(sizeof(struct batadv_tvlv_hdr) != 4);
CHECK: No space is necessary after a cast
#452: FILE: main.c:452:
+ BUILD_BUG_ON(sizeof(struct batadv_tvlv_gateway_data) != 8);
CHECK: No space is necessary after a cast
#453: FILE: main.c:453:
+ BUILD_BUG_ON(sizeof(struct batadv_tvlv_tt_vlan_data) != 8);
CHECK: No space is necessary after a cast
#454: FILE: main.c:454:
+ BUILD_BUG_ON(sizeof(struct batadv_tvlv_tt_change) != 12);
CHECK: No space is necessary after a cast
#455: FILE: main.c:455:
+ BUILD_BUG_ON(sizeof(struct batadv_tvlv_roam_adv) != 8);
total: 0 errors, 0 warnings, 16 checks, 1265 lines checked
checkpatch next main.h:
>>>>>>>>
CHECK: spaces preferred around that '*' (ctx:VxV)
#47: FILE: main.h:47:
+#define BATADV_DAT_ENTRY_TIMEOUT (5*60000) /* 5 mins in milliseconds */
^
total: 0 errors, 0 warnings, 1 checks, 390 lines checked
checkpatch next network-coding.c:
>>>>>>>>
CHECK: spaces preferred around that '*' (ctx:VxV)
#278: FILE: network-coding.c:278:
+ bat_priv->nc.max_buffer_time*10);
^
total: 0 errors, 0 warnings, 1 checks, 1936 lines checked
checkpatch next soft-interface.c:
>>>>>>>>
CHECK: Comparison to NULL could be written "hard_iface->soft_iface"
#827: FILE: soft-interface.c:827:
+ if (!hard_iface || hard_iface->soft_iface != NULL)
total: 0 errors, 0 warnings, 1 checks, 1113 lines checked
7 years, 2 months
Build check errors found: 2015-02-21
by postmaster＠open-mesh.org
Name of failed tests
====================
checkpatch master main.c
checkpatch next main.c
checkpatch next main.h
checkpatch next network-coding.c
checkpatch next soft-interface.c
Output of different failed tests
================================
checkpatch next main.c:
>>>>>>>>
CHECK: No space is necessary after a cast
#440: FILE: main.c:440:
+ BUILD_BUG_ON(sizeof(struct batadv_bla_claim_dst) != 6);
CHECK: No space is necessary after a cast
#441: FILE: main.c:441:
+ BUILD_BUG_ON(sizeof(struct batadv_ogm_packet) != 24);
CHECK: No space is necessary after a cast
#442: FILE: main.c:442:
+ BUILD_BUG_ON(sizeof(struct batadv_icmp_header) != 20);
CHECK: No space is necessary after a cast
#443: FILE: main.c:443:
+ BUILD_BUG_ON(sizeof(struct batadv_icmp_packet) != 20);
CHECK: No space is necessary after a cast
#444: FILE: main.c:444:
+ BUILD_BUG_ON(sizeof(struct batadv_icmp_packet_rr) != 116);
CHECK: No space is necessary after a cast
#445: FILE: main.c:445:
+ BUILD_BUG_ON(sizeof(struct batadv_unicast_packet) != 10);
CHECK: No space is necessary after a cast
#446: FILE: main.c:446:
+ BUILD_BUG_ON(sizeof(struct batadv_unicast_4addr_packet) != 18);
CHECK: No space is necessary after a cast
#447: FILE: main.c:447:
+ BUILD_BUG_ON(sizeof(struct batadv_frag_packet) != 20);
CHECK: No space is necessary after a cast
#448: FILE: main.c:448:
+ BUILD_BUG_ON(sizeof(struct batadv_bcast_packet) != 14);
CHECK: No space is necessary after a cast
#449: FILE: main.c:449:
+ BUILD_BUG_ON(sizeof(struct batadv_coded_packet) != 46);
CHECK: No space is necessary after a cast
#450: FILE: main.c:450:
+ BUILD_BUG_ON(sizeof(struct batadv_unicast_tvlv_packet) != 20);
CHECK: No space is necessary after a cast
#451: FILE: main.c:451:
+ BUILD_BUG_ON(sizeof(struct batadv_tvlv_hdr) != 4);
CHECK: No space is necessary after a cast
#452: FILE: main.c:452:
+ BUILD_BUG_ON(sizeof(struct batadv_tvlv_gateway_data) != 8);
CHECK: No space is necessary after a cast
#453: FILE: main.c:453:
+ BUILD_BUG_ON(sizeof(struct batadv_tvlv_tt_vlan_data) != 8);
CHECK: No space is necessary after a cast
#454: FILE: main.c:454:
+ BUILD_BUG_ON(sizeof(struct batadv_tvlv_tt_change) != 12);
CHECK: No space is necessary after a cast
#455: FILE: main.c:455:
+ BUILD_BUG_ON(sizeof(struct batadv_tvlv_roam_adv) != 8);
total: 0 errors, 0 warnings, 16 checks, 1265 lines checked
checkpatch next main.h:
>>>>>>>>
CHECK: spaces preferred around that '*' (ctx:VxV)
#47: FILE: main.h:47:
+#define BATADV_DAT_ENTRY_TIMEOUT (5*60000) /* 5 mins in milliseconds */
^
total: 0 errors, 0 warnings, 1 checks, 390 lines checked
checkpatch next network-coding.c:
>>>>>>>>
CHECK: spaces preferred around that '*' (ctx:VxV)
#278: FILE: network-coding.c:278:
+ bat_priv->nc.max_buffer_time*10);
^
total: 0 errors, 0 warnings, 1 checks, 1936 lines checked
checkpatch next soft-interface.c:
>>>>>>>>
CHECK: Comparison to NULL could be written "hard_iface->soft_iface"
#827: FILE: soft-interface.c:827:
+ if (!hard_iface || hard_iface->soft_iface != NULL)
total: 0 errors, 0 warnings, 1 checks, 1113 lines checked
7 years, 2 months