[linux-next] LinuxNextTracking branch, master, updated. next-20170228
by batman@open-mesh.org
The following commit has been merged in the master branch:
commit a72fabed870be653703e3f48b327a28d3b64ad08
Author: Johannes Berg <johannes.berg(a)intel.com>
Date: Wed Feb 15 09:49:26 2017 +0100
average: change to declare precision, not factor
Declaring the factor is counter-intuitive, and people are prone
to using small(-ish) values even when that makes no sense.
Change the DECLARE_EWMA() macro to take the fractional precision,
in bits, rather than a factor, and update all users.
While at it, add some more documentation.
Signed-off-by: Johannes Berg <johannes.berg(a)intel.com>
Acked-by: David S. Miller <davem(a)davemloft.net>
Signed-off-by: Johannes Berg <johannes.berg(a)intel.com>
diff --git a/drivers/net/virtio_net.c b/drivers/net/virtio_net.c
index 05a83db..df5f494 100644
--- a/drivers/net/virtio_net.c
+++ b/drivers/net/virtio_net.c
@@ -49,7 +49,7 @@ module_param(gso, bool, 0444);
* at once, the weight is chosen so that the EWMA will be insensitive to short-
* term, transient changes in packet size.
*/
-DECLARE_EWMA(pkt_len, 1, 64)
+DECLARE_EWMA(pkt_len, 0, 64)
/* With mergeable buffers we align buffer address and use the low bits to
* encode its true size. Buffer size is up to 1 page so we need to align to
diff --git a/drivers/net/wireless/ath/ath5k/ath5k.h b/drivers/net/wireless/ath/ath5k/ath5k.h
index 67fedb6..979800c 100644
--- a/drivers/net/wireless/ath/ath5k/ath5k.h
+++ b/drivers/net/wireless/ath/ath5k/ath5k.h
@@ -1252,7 +1252,7 @@ struct ath5k_statistics {
#define ATH5K_TXQ_LEN_MAX (ATH_TXBUF / 4) /* bufs per queue */
#define ATH5K_TXQ_LEN_LOW (ATH5K_TXQ_LEN_MAX / 2) /* low mark */
-DECLARE_EWMA(beacon_rssi, 1024, 8)
+DECLARE_EWMA(beacon_rssi, 10, 8)
/* Driver state associated with an instance of a device */
struct ath5k_hw {
diff --git a/drivers/net/wireless/ralink/rt2x00/rt2x00.h b/drivers/net/wireless/ralink/rt2x00/rt2x00.h
index 26869b3..3407878 100644
--- a/drivers/net/wireless/ralink/rt2x00/rt2x00.h
+++ b/drivers/net/wireless/ralink/rt2x00/rt2x00.h
@@ -257,7 +257,7 @@ struct link_qual {
int tx_failed;
};
-DECLARE_EWMA(rssi, 1024, 8)
+DECLARE_EWMA(rssi, 10, 8)
/*
* Antenna settings about the currently active link.
diff --git a/include/linux/average.h b/include/linux/average.h
index d04aa58..7ddaf34 100644
--- a/include/linux/average.h
+++ b/include/linux/average.h
@@ -1,45 +1,66 @@
#ifndef _LINUX_AVERAGE_H
#define _LINUX_AVERAGE_H
-/* Exponentially weighted moving average (EWMA) */
+/*
+ * Exponentially weighted moving average (EWMA)
+ *
+ * This implements a fixed-precision EWMA algorithm, with both the
+ * precision and fall-off coefficient determined at compile-time
+ * and built into the generated helper funtions.
+ *
+ * The first argument to the macro is the name that will be used
+ * for the struct and helper functions.
+ *
+ * The second argument, the precision, expresses how many bits are
+ * used for the fractional part of the fixed-precision values.
+ *
+ * The third argument, the weight reciprocal, determines how the
+ * new values will be weighed vs. the old state, new values will
+ * get weight 1/weight_rcp and old values 1-1/weight_rcp. Note
+ * that this parameter must be a power of two for efficiency.
+ */
-#define DECLARE_EWMA(name, _factor, _weight) \
+#define DECLARE_EWMA(name, _precision, _weight_rcp) \
struct ewma_##name { \
unsigned long internal; \
}; \
static inline void ewma_##name##_init(struct ewma_##name *e) \
{ \
- BUILD_BUG_ON(!__builtin_constant_p(_factor)); \
- BUILD_BUG_ON(!__builtin_constant_p(_weight)); \
- BUILD_BUG_ON_NOT_POWER_OF_2(_factor); \
- BUILD_BUG_ON_NOT_POWER_OF_2(_weight); \
+ BUILD_BUG_ON(!__builtin_constant_p(_precision)); \
+ BUILD_BUG_ON(!__builtin_constant_p(_weight_rcp)); \
+ /* \
+ * Even if you want to feed it just 0/1 you should have \
+ * some bits for the non-fractional part... \
+ */ \
+ BUILD_BUG_ON((_precision) > 30); \
+ BUILD_BUG_ON_NOT_POWER_OF_2(_weight_rcp); \
e->internal = 0; \
} \
static inline unsigned long \
ewma_##name##_read(struct ewma_##name *e) \
{ \
- BUILD_BUG_ON(!__builtin_constant_p(_factor)); \
- BUILD_BUG_ON(!__builtin_constant_p(_weight)); \
- BUILD_BUG_ON_NOT_POWER_OF_2(_factor); \
- BUILD_BUG_ON_NOT_POWER_OF_2(_weight); \
- return e->internal >> ilog2(_factor); \
+ BUILD_BUG_ON(!__builtin_constant_p(_precision)); \
+ BUILD_BUG_ON(!__builtin_constant_p(_weight_rcp)); \
+ BUILD_BUG_ON((_precision) > 30); \
+ BUILD_BUG_ON_NOT_POWER_OF_2(_weight_rcp); \
+ return e->internal >> (_precision); \
} \
static inline void ewma_##name##_add(struct ewma_##name *e, \
unsigned long val) \
{ \
unsigned long internal = ACCESS_ONCE(e->internal); \
- unsigned long weight = ilog2(_weight); \
- unsigned long factor = ilog2(_factor); \
+ unsigned long weight_rcp = ilog2(_weight_rcp); \
+ unsigned long precision = _precision; \
\
- BUILD_BUG_ON(!__builtin_constant_p(_factor)); \
- BUILD_BUG_ON(!__builtin_constant_p(_weight)); \
- BUILD_BUG_ON_NOT_POWER_OF_2(_factor); \
- BUILD_BUG_ON_NOT_POWER_OF_2(_weight); \
+ BUILD_BUG_ON(!__builtin_constant_p(_precision)); \
+ BUILD_BUG_ON(!__builtin_constant_p(_weight_rcp)); \
+ BUILD_BUG_ON((_precision) > 30); \
+ BUILD_BUG_ON_NOT_POWER_OF_2(_weight_rcp); \
\
ACCESS_ONCE(e->internal) = internal ? \
- (((internal << weight) - internal) + \
- (val << factor)) >> weight : \
- (val << factor); \
+ (((internal << weight_rcp) - internal) + \
+ (val << precision)) >> weight_rcp : \
+ (val << precision); \
}
#endif /* _LINUX_AVERAGE_H */
diff --git a/net/batman-adv/types.h b/net/batman-adv/types.h
index 8f64a5c..66b25e4 100644
--- a/net/batman-adv/types.h
+++ b/net/batman-adv/types.h
@@ -402,7 +402,7 @@ struct batadv_gw_node {
struct rcu_head rcu;
};
-DECLARE_EWMA(throughput, 1024, 8)
+DECLARE_EWMA(throughput, 10, 8)
/**
* struct batadv_hardif_neigh_node_bat_v - B.A.T.M.A.N. V private neighbor
diff --git a/net/mac80211/ieee80211_i.h b/net/mac80211/ieee80211_i.h
index 159a1a7..0e71843 100644
--- a/net/mac80211/ieee80211_i.h
+++ b/net/mac80211/ieee80211_i.h
@@ -428,7 +428,7 @@ struct ieee80211_sta_tx_tspec {
bool downgraded;
};
-DECLARE_EWMA(beacon_signal, 16, 4)
+DECLARE_EWMA(beacon_signal, 4, 4)
struct ieee80211_if_managed {
struct timer_list timer;
diff --git a/net/mac80211/sta_info.h b/net/mac80211/sta_info.h
index 71fa41a..90a2c4d 100644
--- a/net/mac80211/sta_info.h
+++ b/net/mac80211/sta_info.h
@@ -322,8 +322,8 @@ struct ieee80211_fast_rx {
struct rcu_head rcu_head;
};
-/* we use only values in the range 0-100, so pick a large factor */
-DECLARE_EWMA(mesh_fail_avg, 1048576, 8)
+/* we use only values in the range 0-100, so pick a large precision */
+DECLARE_EWMA(mesh_fail_avg, 20, 8)
/**
* struct mesh_sta - mesh STA information
@@ -373,7 +373,7 @@ struct mesh_sta {
struct ewma_mesh_fail_avg fail_avg;
};
-DECLARE_EWMA(signal, 1024, 8)
+DECLARE_EWMA(signal, 10, 8)
struct ieee80211_sta_rx_stats {
unsigned long packets;
--
LinuxNextTracking
5 years, 11 months
Build check errors found: 2017-02-28
by postmaster@open-mesh.org
Name of failed tests
====================
master
------
* checkpatch ./net/batman-adv/main.h
* checkpatch ./net/batman-adv/translation-table.c
* difference between net and batadv master
maint
-----
* difference between net and batadv maint
* headers
Output of different failed tests
================================
master: checkpatch ./net/batman-adv/main.h
------------------------------------------
CHECK: Macro argument reuse 'vid' - possible side-effects?
#203: FILE: ./net/batman-adv/main.h:203:
+#define BATADV_PRINT_VID(vid) (((vid) & BATADV_VLAN_HAS_TAG) ? \
+ (int)((vid) & VLAN_VID_MASK) : -1)
total: 0 errors, 0 warnings, 1 checks, 296 lines checked
master: checkpatch ./net/batman-adv/translation-table.c
-------------------------------------------------------
CHECK: Unbalanced braces around else statement
#2256: FILE: ./net/batman-adv/translation-table.c:2256:
+ } else
CHECK: Unbalanced braces around else statement
#2317: FILE: ./net/batman-adv/translation-table.c:2317:
+ } else
total: 0 errors, 0 warnings, 2 checks, 4380 lines checked
maint: difference between net and batadv maint
----------------------------------------------
net/include/uapi/linux/batman_adv.h | 2 -
net/net/batman-adv/Makefile | 2 -
net/net/batman-adv/bat_algo.c | 2 -
net/net/batman-adv/bat_algo.h | 2 -
net/net/batman-adv/bat_iv_ogm.c | 2 -
net/net/batman-adv/bat_iv_ogm.h | 2 -
net/net/batman-adv/bat_v.c | 2 -
net/net/batman-adv/bat_v.h | 2 -
net/net/batman-adv/bat_v_elp.c | 2 -
net/net/batman-adv/bat_v_elp.h | 2 -
net/net/batman-adv/bat_v_ogm.c | 2 -
net/net/batman-adv/bat_v_ogm.h | 2 -
net/net/batman-adv/bitarray.c | 2 -
net/net/batman-adv/bitarray.h | 2 -
net/net/batman-adv/bridge_loop_avoidance.c | 3 --
net/net/batman-adv/bridge_loop_avoidance.h | 20 +++++++++++++++++-
net/net/batman-adv/debugfs.c | 4 +--
net/net/batman-adv/debugfs.h | 2 -
net/net/batman-adv/distributed-arp-table.c | 3 --
net/net/batman-adv/distributed-arp-table.h | 2 -
net/net/batman-adv/fragmentation.c | 22 +++++++++-----------
net/net/batman-adv/fragmentation.h | 2 -
net/net/batman-adv/gateway_client.c | 2 -
net/net/batman-adv/gateway_client.h | 2 -
net/net/batman-adv/gateway_common.c | 2 -
net/net/batman-adv/gateway_common.h | 2 -
net/net/batman-adv/hard-interface.c | 2 -
net/net/batman-adv/hard-interface.h | 2 -
net/net/batman-adv/hash.c | 2 -
net/net/batman-adv/hash.h | 2 -
net/net/batman-adv/icmp_socket.c | 2 -
net/net/batman-adv/icmp_socket.h | 2 -
net/net/batman-adv/log.c | 2 -
net/net/batman-adv/log.h | 2 -
net/net/batman-adv/main.c | 2 -
net/net/batman-adv/main.h | 4 +--
net/net/batman-adv/multicast.c | 2 -
net/net/batman-adv/multicast.h | 2 -
net/net/batman-adv/netlink.c | 2 -
net/net/batman-adv/netlink.h | 2 -
net/net/batman-adv/network-coding.c | 2 -
net/net/batman-adv/network-coding.h | 2 -
net/net/batman-adv/originator.c | 2 -
net/net/batman-adv/originator.h | 2 -
net/net/batman-adv/packet.h | 2 -
net/net/batman-adv/routing.c | 11 ++++------
net/net/batman-adv/routing.h | 2 -
net/net/batman-adv/send.c | 6 +++--
net/net/batman-adv/send.h | 2 -
net/net/batman-adv/soft-interface.c | 7 ++----
net/net/batman-adv/soft-interface.h | 2 -
net/net/batman-adv/sysfs.c | 2 -
net/net/batman-adv/sysfs.h | 2 -
net/net/batman-adv/tp_meter.c | 4 +--
net/net/batman-adv/tp_meter.h | 2 -
net/net/batman-adv/translation-table.c | 4 ---
net/net/batman-adv/translation-table.h | 2 -
net/net/batman-adv/tvlv.c | 2 -
net/net/batman-adv/tvlv.h | 2 -
net/net/batman-adv/types.h | 2 -
60 files changed, 99 insertions(+), 87 deletions(-)
master: difference between net and batadv master
------------------------------------------------
netnext/net/batman-adv/fragmentation.c | 20 +++++++++-----------
1 file changed, 9 insertions(+), 11 deletions(-)
maint: headers
--------------
diff --git a/build/net/batman-adv/debugfs.c b/build/net/batman-adv/debugfs.c
index e4e7ee0..5c04a9c 100644
--- a/build/net/batman-adv/debugfs.c
+++ b/build/net/batman-adv/debugfs.c
@@ -16,10 +16,11 @@
*/
#include "debugfs.h"
+
#include "main.h" // IWYU pragma: keep
#include <linux/debugfs.h>
-#include <linux/device.h>
+#include <linux/err.h>
#include <linux/errno.h>
#include <linux/export.h>
#include <linux/fs.h>
diff --git a/build/net/batman-adv/tp_meter.c b/build/net/batman-adv/tp_meter.c
index c4c52fe..bd513a8 100644
--- a/build/net/batman-adv/tp_meter.c
+++ b/build/net/batman-adv/tp_meter.c
@@ -16,6 +16,7 @@
*/
#include "tp_meter.h"
+
#include "main.h" // IWYU pragma: keep
#include <linux/atomic.h>
@@ -23,7 +24,7 @@
#include <linux/byteorder/generic.h>
#include <linux/cache.h>
#include <linux/compiler.h>
-#include <linux/device.h>
+#include <linux/err.h>
#include <linux/etherdevice.h>
#include <linux/fs.h>
#include <linux/if_ether.h>
Statistics
==========
master
------
Failed tests: 3
Started build tests: 55
Tested Linux versions: 26
Tested configs: 46
maint
-----
Failed tests: 2
Started build tests: 49
Tested Linux versions: 26
Tested configs: 42
5 years, 11 months
Build check errors found: 2017-02-27
by postmaster@open-mesh.org
Name of failed tests
====================
master
------
* checkpatch ./net/batman-adv/main.h
* checkpatch ./net/batman-adv/translation-table.c
* difference between net and batadv master
maint
-----
* difference between net and batadv maint
* headers
Output of different failed tests
================================
master: checkpatch ./net/batman-adv/main.h
------------------------------------------
CHECK: Macro argument reuse 'vid' - possible side-effects?
#203: FILE: ./net/batman-adv/main.h:203:
+#define BATADV_PRINT_VID(vid) (((vid) & BATADV_VLAN_HAS_TAG) ? \
+ (int)((vid) & VLAN_VID_MASK) : -1)
total: 0 errors, 0 warnings, 1 checks, 296 lines checked
master: checkpatch ./net/batman-adv/translation-table.c
-------------------------------------------------------
CHECK: Unbalanced braces around else statement
#2256: FILE: ./net/batman-adv/translation-table.c:2256:
+ } else
CHECK: Unbalanced braces around else statement
#2317: FILE: ./net/batman-adv/translation-table.c:2317:
+ } else
total: 0 errors, 0 warnings, 2 checks, 4380 lines checked
maint: difference between net and batadv maint
----------------------------------------------
net/include/uapi/linux/batman_adv.h | 2 -
net/net/batman-adv/Makefile | 2 -
net/net/batman-adv/bat_algo.c | 2 -
net/net/batman-adv/bat_algo.h | 2 -
net/net/batman-adv/bat_iv_ogm.c | 2 -
net/net/batman-adv/bat_iv_ogm.h | 2 -
net/net/batman-adv/bat_v.c | 2 -
net/net/batman-adv/bat_v.h | 2 -
net/net/batman-adv/bat_v_elp.c | 2 -
net/net/batman-adv/bat_v_elp.h | 2 -
net/net/batman-adv/bat_v_ogm.c | 2 -
net/net/batman-adv/bat_v_ogm.h | 2 -
net/net/batman-adv/bitarray.c | 2 -
net/net/batman-adv/bitarray.h | 2 -
net/net/batman-adv/bridge_loop_avoidance.c | 3 --
net/net/batman-adv/bridge_loop_avoidance.h | 20 +++++++++++++++++-
net/net/batman-adv/debugfs.c | 4 +--
net/net/batman-adv/debugfs.h | 2 -
net/net/batman-adv/distributed-arp-table.c | 3 --
net/net/batman-adv/distributed-arp-table.h | 2 -
net/net/batman-adv/fragmentation.c | 22 +++++++++-----------
net/net/batman-adv/fragmentation.h | 2 -
net/net/batman-adv/gateway_client.c | 2 -
net/net/batman-adv/gateway_client.h | 2 -
net/net/batman-adv/gateway_common.c | 2 -
net/net/batman-adv/gateway_common.h | 2 -
net/net/batman-adv/hard-interface.c | 2 -
net/net/batman-adv/hard-interface.h | 2 -
net/net/batman-adv/hash.c | 2 -
net/net/batman-adv/hash.h | 2 -
net/net/batman-adv/icmp_socket.c | 2 -
net/net/batman-adv/icmp_socket.h | 2 -
net/net/batman-adv/log.c | 2 -
net/net/batman-adv/log.h | 2 -
net/net/batman-adv/main.c | 2 -
net/net/batman-adv/main.h | 4 +--
net/net/batman-adv/multicast.c | 2 -
net/net/batman-adv/multicast.h | 2 -
net/net/batman-adv/netlink.c | 2 -
net/net/batman-adv/netlink.h | 2 -
net/net/batman-adv/network-coding.c | 2 -
net/net/batman-adv/network-coding.h | 2 -
net/net/batman-adv/originator.c | 2 -
net/net/batman-adv/originator.h | 2 -
net/net/batman-adv/packet.h | 2 -
net/net/batman-adv/routing.c | 11 ++++------
net/net/batman-adv/routing.h | 2 -
net/net/batman-adv/send.c | 6 +++--
net/net/batman-adv/send.h | 2 -
net/net/batman-adv/soft-interface.c | 7 ++----
net/net/batman-adv/soft-interface.h | 2 -
net/net/batman-adv/sysfs.c | 2 -
net/net/batman-adv/sysfs.h | 2 -
net/net/batman-adv/tp_meter.c | 4 +--
net/net/batman-adv/tp_meter.h | 2 -
net/net/batman-adv/translation-table.c | 4 ---
net/net/batman-adv/translation-table.h | 2 -
net/net/batman-adv/tvlv.c | 2 -
net/net/batman-adv/tvlv.h | 2 -
net/net/batman-adv/types.h | 2 -
60 files changed, 99 insertions(+), 87 deletions(-)
master: difference between net and batadv master
------------------------------------------------
netnext/net/batman-adv/fragmentation.c | 20 +++++++++-----------
1 file changed, 9 insertions(+), 11 deletions(-)
maint: headers
--------------
diff --git a/build/net/batman-adv/debugfs.c b/build/net/batman-adv/debugfs.c
index e4e7ee0..5c04a9c 100644
--- a/build/net/batman-adv/debugfs.c
+++ b/build/net/batman-adv/debugfs.c
@@ -16,10 +16,11 @@
*/
#include "debugfs.h"
+
#include "main.h" // IWYU pragma: keep
#include <linux/debugfs.h>
-#include <linux/device.h>
+#include <linux/err.h>
#include <linux/errno.h>
#include <linux/export.h>
#include <linux/fs.h>
diff --git a/build/net/batman-adv/tp_meter.c b/build/net/batman-adv/tp_meter.c
index c4c52fe..bd513a8 100644
--- a/build/net/batman-adv/tp_meter.c
+++ b/build/net/batman-adv/tp_meter.c
@@ -16,6 +16,7 @@
*/
#include "tp_meter.h"
+
#include "main.h" // IWYU pragma: keep
#include <linux/atomic.h>
@@ -23,7 +24,7 @@
#include <linux/byteorder/generic.h>
#include <linux/cache.h>
#include <linux/compiler.h>
-#include <linux/device.h>
+#include <linux/err.h>
#include <linux/etherdevice.h>
#include <linux/fs.h>
#include <linux/if_ether.h>
Statistics
==========
master
------
Failed tests: 3
Started build tests: 49
Tested Linux versions: 21
Tested configs: 40
maint
-----
Failed tests: 2
Started build tests: 51
Tested Linux versions: 24
Tested configs: 42
5 years, 11 months
Build check errors found: 2017-02-26
by postmaster@open-mesh.org
Name of failed tests
====================
master
------
* checkpatch ./net/batman-adv/main.h
* checkpatch ./net/batman-adv/translation-table.c
* difference between net and batadv master
maint
-----
* difference between net and batadv maint
* headers
Output of different failed tests
================================
master: checkpatch ./net/batman-adv/main.h
------------------------------------------
CHECK: Macro argument reuse 'vid' - possible side-effects?
#203: FILE: ./net/batman-adv/main.h:203:
+#define BATADV_PRINT_VID(vid) (((vid) & BATADV_VLAN_HAS_TAG) ? \
+ (int)((vid) & VLAN_VID_MASK) : -1)
total: 0 errors, 0 warnings, 1 checks, 296 lines checked
master: checkpatch ./net/batman-adv/translation-table.c
-------------------------------------------------------
CHECK: Unbalanced braces around else statement
#2256: FILE: ./net/batman-adv/translation-table.c:2256:
+ } else
CHECK: Unbalanced braces around else statement
#2317: FILE: ./net/batman-adv/translation-table.c:2317:
+ } else
total: 0 errors, 0 warnings, 2 checks, 4380 lines checked
maint: difference between net and batadv maint
----------------------------------------------
net/include/uapi/linux/batman_adv.h | 2 -
net/net/batman-adv/Makefile | 2 -
net/net/batman-adv/bat_algo.c | 2 -
net/net/batman-adv/bat_algo.h | 2 -
net/net/batman-adv/bat_iv_ogm.c | 2 -
net/net/batman-adv/bat_iv_ogm.h | 2 -
net/net/batman-adv/bat_v.c | 2 -
net/net/batman-adv/bat_v.h | 2 -
net/net/batman-adv/bat_v_elp.c | 2 -
net/net/batman-adv/bat_v_elp.h | 2 -
net/net/batman-adv/bat_v_ogm.c | 2 -
net/net/batman-adv/bat_v_ogm.h | 2 -
net/net/batman-adv/bitarray.c | 2 -
net/net/batman-adv/bitarray.h | 2 -
net/net/batman-adv/bridge_loop_avoidance.c | 3 --
net/net/batman-adv/bridge_loop_avoidance.h | 20 +++++++++++++++++-
net/net/batman-adv/debugfs.c | 4 +--
net/net/batman-adv/debugfs.h | 2 -
net/net/batman-adv/distributed-arp-table.c | 3 --
net/net/batman-adv/distributed-arp-table.h | 2 -
net/net/batman-adv/fragmentation.c | 22 +++++++++-----------
net/net/batman-adv/fragmentation.h | 2 -
net/net/batman-adv/gateway_client.c | 2 -
net/net/batman-adv/gateway_client.h | 2 -
net/net/batman-adv/gateway_common.c | 2 -
net/net/batman-adv/gateway_common.h | 2 -
net/net/batman-adv/hard-interface.c | 2 -
net/net/batman-adv/hard-interface.h | 2 -
net/net/batman-adv/hash.c | 2 -
net/net/batman-adv/hash.h | 2 -
net/net/batman-adv/icmp_socket.c | 2 -
net/net/batman-adv/icmp_socket.h | 2 -
net/net/batman-adv/log.c | 2 -
net/net/batman-adv/log.h | 2 -
net/net/batman-adv/main.c | 2 -
net/net/batman-adv/main.h | 4 +--
net/net/batman-adv/multicast.c | 2 -
net/net/batman-adv/multicast.h | 2 -
net/net/batman-adv/netlink.c | 2 -
net/net/batman-adv/netlink.h | 2 -
net/net/batman-adv/network-coding.c | 2 -
net/net/batman-adv/network-coding.h | 2 -
net/net/batman-adv/originator.c | 2 -
net/net/batman-adv/originator.h | 2 -
net/net/batman-adv/packet.h | 2 -
net/net/batman-adv/routing.c | 11 ++++------
net/net/batman-adv/routing.h | 2 -
net/net/batman-adv/send.c | 6 +++--
net/net/batman-adv/send.h | 2 -
net/net/batman-adv/soft-interface.c | 7 ++----
net/net/batman-adv/soft-interface.h | 2 -
net/net/batman-adv/sysfs.c | 2 -
net/net/batman-adv/sysfs.h | 2 -
net/net/batman-adv/tp_meter.c | 4 +--
net/net/batman-adv/tp_meter.h | 2 -
net/net/batman-adv/translation-table.c | 4 ---
net/net/batman-adv/translation-table.h | 2 -
net/net/batman-adv/tvlv.c | 2 -
net/net/batman-adv/tvlv.h | 2 -
net/net/batman-adv/types.h | 2 -
60 files changed, 99 insertions(+), 87 deletions(-)
master: difference between net and batadv master
------------------------------------------------
netnext/net/batman-adv/fragmentation.c | 20 +++++++++-----------
1 file changed, 9 insertions(+), 11 deletions(-)
maint: headers
--------------
diff --git a/build/net/batman-adv/debugfs.c b/build/net/batman-adv/debugfs.c
index e4e7ee0..5c04a9c 100644
--- a/build/net/batman-adv/debugfs.c
+++ b/build/net/batman-adv/debugfs.c
@@ -16,10 +16,11 @@
*/
#include "debugfs.h"
+
#include "main.h" // IWYU pragma: keep
#include <linux/debugfs.h>
-#include <linux/device.h>
+#include <linux/err.h>
#include <linux/errno.h>
#include <linux/export.h>
#include <linux/fs.h>
diff --git a/build/net/batman-adv/tp_meter.c b/build/net/batman-adv/tp_meter.c
index c4c52fe..bd513a8 100644
--- a/build/net/batman-adv/tp_meter.c
+++ b/build/net/batman-adv/tp_meter.c
@@ -16,6 +16,7 @@
*/
#include "tp_meter.h"
+
#include "main.h" // IWYU pragma: keep
#include <linux/atomic.h>
@@ -23,7 +24,7 @@
#include <linux/byteorder/generic.h>
#include <linux/cache.h>
#include <linux/compiler.h>
-#include <linux/device.h>
+#include <linux/err.h>
#include <linux/etherdevice.h>
#include <linux/fs.h>
#include <linux/if_ether.h>
Statistics
==========
master
------
Failed tests: 3
Started build tests: 60
Tested Linux versions: 24
Tested configs: 49
maint
-----
Failed tests: 2
Started build tests: 56
Tested Linux versions: 23
Tested configs: 45
5 years, 11 months
Build check errors found: 2017-02-25
by postmaster@open-mesh.org
Name of failed tests
====================
master
------
* checkpatch ./net/batman-adv/main.h
* checkpatch ./net/batman-adv/translation-table.c
* difference between net and batadv master
maint
-----
* difference between net and batadv maint
* headers
Output of different failed tests
================================
master: checkpatch ./net/batman-adv/main.h
------------------------------------------
CHECK: Macro argument reuse 'vid' - possible side-effects?
#203: FILE: ./net/batman-adv/main.h:203:
+#define BATADV_PRINT_VID(vid) (((vid) & BATADV_VLAN_HAS_TAG) ? \
+ (int)((vid) & VLAN_VID_MASK) : -1)
total: 0 errors, 0 warnings, 1 checks, 296 lines checked
master: checkpatch ./net/batman-adv/translation-table.c
-------------------------------------------------------
CHECK: Unbalanced braces around else statement
#2256: FILE: ./net/batman-adv/translation-table.c:2256:
+ } else
CHECK: Unbalanced braces around else statement
#2317: FILE: ./net/batman-adv/translation-table.c:2317:
+ } else
total: 0 errors, 0 warnings, 2 checks, 4380 lines checked
maint: difference between net and batadv maint
----------------------------------------------
net/include/uapi/linux/batman_adv.h | 2 -
net/net/batman-adv/Makefile | 2 -
net/net/batman-adv/bat_algo.c | 2 -
net/net/batman-adv/bat_algo.h | 2 -
net/net/batman-adv/bat_iv_ogm.c | 2 -
net/net/batman-adv/bat_iv_ogm.h | 2 -
net/net/batman-adv/bat_v.c | 2 -
net/net/batman-adv/bat_v.h | 2 -
net/net/batman-adv/bat_v_elp.c | 2 -
net/net/batman-adv/bat_v_elp.h | 2 -
net/net/batman-adv/bat_v_ogm.c | 2 -
net/net/batman-adv/bat_v_ogm.h | 2 -
net/net/batman-adv/bitarray.c | 2 -
net/net/batman-adv/bitarray.h | 2 -
net/net/batman-adv/bridge_loop_avoidance.c | 3 --
net/net/batman-adv/bridge_loop_avoidance.h | 20 +++++++++++++++++-
net/net/batman-adv/debugfs.c | 4 +--
net/net/batman-adv/debugfs.h | 2 -
net/net/batman-adv/distributed-arp-table.c | 3 --
net/net/batman-adv/distributed-arp-table.h | 2 -
net/net/batman-adv/fragmentation.c | 22 +++++++++-----------
net/net/batman-adv/fragmentation.h | 2 -
net/net/batman-adv/gateway_client.c | 2 -
net/net/batman-adv/gateway_client.h | 2 -
net/net/batman-adv/gateway_common.c | 2 -
net/net/batman-adv/gateway_common.h | 2 -
net/net/batman-adv/hard-interface.c | 2 -
net/net/batman-adv/hard-interface.h | 2 -
net/net/batman-adv/hash.c | 2 -
net/net/batman-adv/hash.h | 2 -
net/net/batman-adv/icmp_socket.c | 2 -
net/net/batman-adv/icmp_socket.h | 2 -
net/net/batman-adv/log.c | 2 -
net/net/batman-adv/log.h | 2 -
net/net/batman-adv/main.c | 2 -
net/net/batman-adv/main.h | 4 +--
net/net/batman-adv/multicast.c | 2 -
net/net/batman-adv/multicast.h | 2 -
net/net/batman-adv/netlink.c | 2 -
net/net/batman-adv/netlink.h | 2 -
net/net/batman-adv/network-coding.c | 2 -
net/net/batman-adv/network-coding.h | 2 -
net/net/batman-adv/originator.c | 2 -
net/net/batman-adv/originator.h | 2 -
net/net/batman-adv/packet.h | 2 -
net/net/batman-adv/routing.c | 11 ++++------
net/net/batman-adv/routing.h | 2 -
net/net/batman-adv/send.c | 6 +++--
net/net/batman-adv/send.h | 2 -
net/net/batman-adv/soft-interface.c | 7 ++----
net/net/batman-adv/soft-interface.h | 2 -
net/net/batman-adv/sysfs.c | 2 -
net/net/batman-adv/sysfs.h | 2 -
net/net/batman-adv/tp_meter.c | 4 +--
net/net/batman-adv/tp_meter.h | 2 -
net/net/batman-adv/translation-table.c | 4 ---
net/net/batman-adv/translation-table.h | 2 -
net/net/batman-adv/tvlv.c | 2 -
net/net/batman-adv/tvlv.h | 2 -
net/net/batman-adv/types.h | 2 -
60 files changed, 99 insertions(+), 87 deletions(-)
master: difference between net and batadv master
------------------------------------------------
netnext/net/batman-adv/fragmentation.c | 20 +++++++++-----------
1 file changed, 9 insertions(+), 11 deletions(-)
maint: headers
--------------
diff --git a/build/net/batman-adv/debugfs.c b/build/net/batman-adv/debugfs.c
index e4e7ee0..5c04a9c 100644
--- a/build/net/batman-adv/debugfs.c
+++ b/build/net/batman-adv/debugfs.c
@@ -16,10 +16,11 @@
*/
#include "debugfs.h"
+
#include "main.h" // IWYU pragma: keep
#include <linux/debugfs.h>
-#include <linux/device.h>
+#include <linux/err.h>
#include <linux/errno.h>
#include <linux/export.h>
#include <linux/fs.h>
diff --git a/build/net/batman-adv/tp_meter.c b/build/net/batman-adv/tp_meter.c
index c4c52fe..bd513a8 100644
--- a/build/net/batman-adv/tp_meter.c
+++ b/build/net/batman-adv/tp_meter.c
@@ -16,6 +16,7 @@
*/
#include "tp_meter.h"
+
#include "main.h" // IWYU pragma: keep
#include <linux/atomic.h>
@@ -23,7 +24,7 @@
#include <linux/byteorder/generic.h>
#include <linux/cache.h>
#include <linux/compiler.h>
-#include <linux/device.h>
+#include <linux/err.h>
#include <linux/etherdevice.h>
#include <linux/fs.h>
#include <linux/if_ether.h>
Statistics
==========
master
------
Failed tests: 3
Started build tests: 51
Tested Linux versions: 25
Tested configs: 42
maint
-----
Failed tests: 2
Started build tests: 45
Tested Linux versions: 22
Tested configs: 38
5 years, 11 months
Build check errors found: 2017-02-24
by postmaster@open-mesh.org
Name of failed tests
====================
master
------
* checkpatch ./net/batman-adv/main.h
* checkpatch ./net/batman-adv/translation-table.c
* difference between net and batadv master
maint
-----
* difference between net and batadv maint
* headers
Output of different failed tests
================================
master: checkpatch ./net/batman-adv/main.h
------------------------------------------
CHECK: Macro argument reuse 'vid' - possible side-effects?
#203: FILE: ./net/batman-adv/main.h:203:
+#define BATADV_PRINT_VID(vid) (((vid) & BATADV_VLAN_HAS_TAG) ? \
+ (int)((vid) & VLAN_VID_MASK) : -1)
total: 0 errors, 0 warnings, 1 checks, 296 lines checked
master: checkpatch ./net/batman-adv/translation-table.c
-------------------------------------------------------
CHECK: Unbalanced braces around else statement
#2256: FILE: ./net/batman-adv/translation-table.c:2256:
+ } else
CHECK: Unbalanced braces around else statement
#2317: FILE: ./net/batman-adv/translation-table.c:2317:
+ } else
total: 0 errors, 0 warnings, 2 checks, 4380 lines checked
maint: difference between net and batadv maint
----------------------------------------------
net/include/uapi/linux/batman_adv.h | 2 -
net/net/batman-adv/Makefile | 2 -
net/net/batman-adv/bat_algo.c | 2 -
net/net/batman-adv/bat_algo.h | 2 -
net/net/batman-adv/bat_iv_ogm.c | 2 -
net/net/batman-adv/bat_iv_ogm.h | 2 -
net/net/batman-adv/bat_v.c | 2 -
net/net/batman-adv/bat_v.h | 2 -
net/net/batman-adv/bat_v_elp.c | 2 -
net/net/batman-adv/bat_v_elp.h | 2 -
net/net/batman-adv/bat_v_ogm.c | 2 -
net/net/batman-adv/bat_v_ogm.h | 2 -
net/net/batman-adv/bitarray.c | 2 -
net/net/batman-adv/bitarray.h | 2 -
net/net/batman-adv/bridge_loop_avoidance.c | 3 --
net/net/batman-adv/bridge_loop_avoidance.h | 20 +++++++++++++++++-
net/net/batman-adv/debugfs.c | 4 +--
net/net/batman-adv/debugfs.h | 2 -
net/net/batman-adv/distributed-arp-table.c | 3 --
net/net/batman-adv/distributed-arp-table.h | 2 -
net/net/batman-adv/fragmentation.c | 22 +++++++++-----------
net/net/batman-adv/fragmentation.h | 2 -
net/net/batman-adv/gateway_client.c | 2 -
net/net/batman-adv/gateway_client.h | 2 -
net/net/batman-adv/gateway_common.c | 2 -
net/net/batman-adv/gateway_common.h | 2 -
net/net/batman-adv/hard-interface.c | 2 -
net/net/batman-adv/hard-interface.h | 2 -
net/net/batman-adv/hash.c | 2 -
net/net/batman-adv/hash.h | 2 -
net/net/batman-adv/icmp_socket.c | 2 -
net/net/batman-adv/icmp_socket.h | 2 -
net/net/batman-adv/log.c | 2 -
net/net/batman-adv/log.h | 2 -
net/net/batman-adv/main.c | 2 -
net/net/batman-adv/main.h | 4 +--
net/net/batman-adv/multicast.c | 2 -
net/net/batman-adv/multicast.h | 2 -
net/net/batman-adv/netlink.c | 2 -
net/net/batman-adv/netlink.h | 2 -
net/net/batman-adv/network-coding.c | 2 -
net/net/batman-adv/network-coding.h | 2 -
net/net/batman-adv/originator.c | 2 -
net/net/batman-adv/originator.h | 2 -
net/net/batman-adv/packet.h | 2 -
net/net/batman-adv/routing.c | 11 ++++------
net/net/batman-adv/routing.h | 2 -
net/net/batman-adv/send.c | 6 +++--
net/net/batman-adv/send.h | 2 -
net/net/batman-adv/soft-interface.c | 7 ++----
net/net/batman-adv/soft-interface.h | 2 -
net/net/batman-adv/sysfs.c | 2 -
net/net/batman-adv/sysfs.h | 2 -
net/net/batman-adv/tp_meter.c | 4 +--
net/net/batman-adv/tp_meter.h | 2 -
net/net/batman-adv/translation-table.c | 4 ---
net/net/batman-adv/translation-table.h | 2 -
net/net/batman-adv/tvlv.c | 2 -
net/net/batman-adv/tvlv.h | 2 -
net/net/batman-adv/types.h | 2 -
60 files changed, 99 insertions(+), 87 deletions(-)
master: difference between net and batadv master
------------------------------------------------
netnext/net/batman-adv/fragmentation.c | 20 +++++++++-----------
1 file changed, 9 insertions(+), 11 deletions(-)
maint: headers
--------------
diff --git a/build/net/batman-adv/debugfs.c b/build/net/batman-adv/debugfs.c
index e4e7ee0..5c04a9c 100644
--- a/build/net/batman-adv/debugfs.c
+++ b/build/net/batman-adv/debugfs.c
@@ -16,10 +16,11 @@
*/
#include "debugfs.h"
+
#include "main.h" // IWYU pragma: keep
#include <linux/debugfs.h>
-#include <linux/device.h>
+#include <linux/err.h>
#include <linux/errno.h>
#include <linux/export.h>
#include <linux/fs.h>
diff --git a/build/net/batman-adv/tp_meter.c b/build/net/batman-adv/tp_meter.c
index c4c52fe..bd513a8 100644
--- a/build/net/batman-adv/tp_meter.c
+++ b/build/net/batman-adv/tp_meter.c
@@ -16,6 +16,7 @@
*/
#include "tp_meter.h"
+
#include "main.h" // IWYU pragma: keep
#include <linux/atomic.h>
@@ -23,7 +24,7 @@
#include <linux/byteorder/generic.h>
#include <linux/cache.h>
#include <linux/compiler.h>
-#include <linux/device.h>
+#include <linux/err.h>
#include <linux/etherdevice.h>
#include <linux/fs.h>
#include <linux/if_ether.h>
Statistics
==========
master
------
Failed tests: 3
Started build tests: 47
Tested Linux versions: 24
Tested configs: 38
maint
-----
Failed tests: 2
Started build tests: 47
Tested Linux versions: 22
Tested configs: 42
5 years, 11 months
Build check errors found: 2017-02-23
by postmaster@open-mesh.org
Name of failed tests
====================
master
------
* checkpatch ./net/batman-adv/bat_iv_ogm.c
* checkpatch ./net/batman-adv/bat_v.c
* checkpatch ./net/batman-adv/bridge_loop_avoidance.c
* checkpatch ./net/batman-adv/distributed-arp-table.c
* checkpatch ./net/batman-adv/gateway_client.c
* checkpatch ./net/batman-adv/gateway_common.c
* checkpatch ./net/batman-adv/main.h
* checkpatch ./net/batman-adv/multicast.c
* checkpatch ./net/batman-adv/network-coding.c
* checkpatch ./net/batman-adv/originator.c
* checkpatch ./net/batman-adv/routing.c
* checkpatch ./net/batman-adv/send.c
* checkpatch ./net/batman-adv/soft-interface.c
* checkpatch ./net/batman-adv/sysfs.c
* checkpatch ./net/batman-adv/tp_meter.c
* checkpatch ./net/batman-adv/translation-table.c
* checkpatch ./net/batman-adv/tvlv.c
* difference between net and batadv master
maint
-----
* difference between net and batadv maint
* headers
Output of different failed tests
================================
master: checkpatch ./net/batman-adv/bat_iv_ogm.c
------------------------------------------------
CHECK: Unbalanced braces around else statement
#280: FILE: ./net/batman-adv/bat_iv_ogm.c:280:
+ } else {
CHECK: Unbalanced braces around else statement
#812: FILE: ./net/batman-adv/bat_iv_ogm.c:812:
+ } else {
CHECK: Unbalanced braces around else statement
#1073: FILE: ./net/batman-adv/bat_iv_ogm.c:1073:
+ } else {
CHECK: Unbalanced braces around else statement
#1224: FILE: ./net/batman-adv/bat_iv_ogm.c:1224:
+ } else {
CHECK: Unbalanced braces around else statement
#1370: FILE: ./net/batman-adv/bat_iv_ogm.c:1370:
+ } else {
CHECK: Unbalanced braces around else statement
#2395: FILE: ./net/batman-adv/bat_iv_ogm.c:2395:
+ } else {
total: 0 errors, 0 warnings, 6 checks, 2855 lines checked
master: checkpatch ./net/batman-adv/bat_v.c
-------------------------------------------
CHECK: Unbalanced braces around else statement
#327: FILE: ./net/batman-adv/bat_v.c:327:
+ } else {
total: 0 errors, 0 warnings, 1 checks, 1146 lines checked
master: checkpatch ./net/batman-adv/bridge_loop_avoidance.c
-----------------------------------------------------------
CHECK: Unbalanced braces around else statement
#735: FILE: ./net/batman-adv/bridge_loop_avoidance.c:735:
+ } else {
CHECK: Unbalanced braces around else statement
#866: FILE: ./net/batman-adv/bridge_loop_avoidance.c:866:
+ } else {
CHECK: Unbalanced braces around else statement
#1539: FILE: ./net/batman-adv/bridge_loop_avoidance.c:1539:
+ } else {
CHECK: Unbalanced braces around else statement
#1876: FILE: ./net/batman-adv/bridge_loop_avoidance.c:1876:
+ } else {
CHECK: Unbalanced braces around else statement
#1978: FILE: ./net/batman-adv/bridge_loop_avoidance.c:1978:
+ } else {
total: 0 errors, 0 warnings, 5 checks, 2451 lines checked
master: checkpatch ./net/batman-adv/distributed-arp-table.c
-----------------------------------------------------------
CHECK: Unbalanced braces around else statement
#1057: FILE: ./net/batman-adv/distributed-arp-table.c:1057:
+ } else {
total: 0 errors, 0 warnings, 1 checks, 1285 lines checked
master: checkpatch ./net/batman-adv/gateway_client.c
----------------------------------------------------
CHECK: Unbalanced braces around else statement
#267: FILE: ./net/batman-adv/gateway_client.c:267:
+ } else {
total: 0 errors, 0 warnings, 1 checks, 791 lines checked
master: checkpatch ./net/batman-adv/gateway_common.c
----------------------------------------------------
CHECK: Unbalanced braces around else statement
#231: FILE: ./net/batman-adv/gateway_common.c:231:
+ } else {
total: 0 errors, 0 warnings, 1 checks, 269 lines checked
master: checkpatch ./net/batman-adv/main.h
------------------------------------------
CHECK: Macro argument reuse 'vid' - possible side-effects?
#203: FILE: ./net/batman-adv/main.h:203:
+#define BATADV_PRINT_VID(vid) (((vid) & BATADV_VLAN_HAS_TAG) ? \
+ (int)((vid) & VLAN_VID_MASK) : -1)
total: 0 errors, 0 warnings, 1 checks, 296 lines checked
master: checkpatch ./net/batman-adv/multicast.c
-----------------------------------------------
CHECK: Unbalanced braces around else statement
#1204: FILE: ./net/batman-adv/multicast.c:1204:
+ } else {
total: 0 errors, 0 warnings, 1 checks, 1319 lines checked
master: checkpatch ./net/batman-adv/network-coding.c
----------------------------------------------------
CHECK: Unbalanced braces around else statement
#875: FILE: ./net/batman-adv/network-coding.c:875:
+ } else {
CHECK: Unbalanced braces around else statement
#1123: FILE: ./net/batman-adv/network-coding.c:1123:
+ } else {
CHECK: Unbalanced braces around else statement
#1142: FILE: ./net/batman-adv/network-coding.c:1142:
+ } else {
CHECK: Unbalanced braces around else statement
#1699: FILE: ./net/batman-adv/network-coding.c:1699:
+ } else {
CHECK: Unbalanced braces around else statement
#1765: FILE: ./net/batman-adv/network-coding.c:1765:
+ } else {
total: 0 errors, 0 warnings, 5 checks, 1991 lines checked
master: checkpatch ./net/batman-adv/originator.c
------------------------------------------------
CHECK: Unbalanced braces around else statement
#1179: FILE: ./net/batman-adv/originator.c:1179:
+ } else {
total: 0 errors, 0 warnings, 1 checks, 1590 lines checked
master: checkpatch ./net/batman-adv/routing.c
---------------------------------------------
CHECK: Unbalanced braces around else statement
#650: FILE: ./net/batman-adv/routing.c:650:
+ } else {
CHECK: Unbalanced braces around else statement
#772: FILE: ./net/batman-adv/routing.c:772:
+ } else {
total: 0 errors, 0 warnings, 2 checks, 1242 lines checked
master: checkpatch ./net/batman-adv/send.c
------------------------------------------
CHECK: Unbalanced braces around else statement
#834: FILE: ./net/batman-adv/send.c:834:
+ } else {
total: 0 errors, 0 warnings, 1 checks, 942 lines checked
master: checkpatch ./net/batman-adv/soft-interface.c
----------------------------------------------------
CHECK: Unbalanced braces around else statement
#369: FILE: ./net/batman-adv/soft-interface.c:369:
+ } else {
CHECK: Unbalanced braces around else statement
#380: FILE: ./net/batman-adv/soft-interface.c:380:
+ } else {
total: 0 errors, 0 warnings, 2 checks, 1201 lines checked
master: checkpatch ./net/batman-adv/sysfs.c
-------------------------------------------
CHECK: Unbalanced braces around else statement
#816: FILE: ./net/batman-adv/sysfs.c:816:
+ } else {
total: 0 errors, 0 warnings, 1 checks, 1217 lines checked
master: checkpatch ./net/batman-adv/tp_meter.c
----------------------------------------------
CHECK: Unbalanced braces around else statement
#201: FILE: ./net/batman-adv/tp_meter.c:201:
+ } else {
CHECK: Unbalanced braces around else statement
#235: FILE: ./net/batman-adv/tp_meter.c:235:
+ } else {
CHECK: Unbalanced braces around else statement
#714: FILE: ./net/batman-adv/tp_meter.c:714:
+ } else {
CHECK: Unbalanced braces around else statement
#736: FILE: ./net/batman-adv/tp_meter.c:736:
+ } else {
CHECK: Unbalanced braces around else statement
#1413: FILE: ./net/batman-adv/tp_meter.c:1413:
+ } else {
total: 0 errors, 0 warnings, 5 checks, 1502 lines checked
master: checkpatch ./net/batman-adv/translation-table.c
-------------------------------------------------------
CHECK: Unbalanced braces around else statement
#783: FILE: ./net/batman-adv/translation-table.c:783:
+ } else {
CHECK: Unbalanced braces around else statement
#1672: FILE: ./net/batman-adv/translation-table.c:1672:
+ } else {
CHECK: Unbalanced braces around else statement
#2256: FILE: ./net/batman-adv/translation-table.c:2256:
+ } else
CHECK: Unbalanced braces around else statement
#2317: FILE: ./net/batman-adv/translation-table.c:2317:
+ } else
CHECK: Unbalanced braces around else statement
#3170: FILE: ./net/batman-adv/translation-table.c:3170:
+ } else {
CHECK: Unbalanced braces around else statement
#3297: FILE: ./net/batman-adv/translation-table.c:3297:
+ } else {
CHECK: Unbalanced braces around else statement
#3383: FILE: ./net/batman-adv/translation-table.c:3383:
+ } else {
CHECK: Unbalanced braces around else statement
#3512: FILE: ./net/batman-adv/translation-table.c:3512:
+ } else {
CHECK: Unbalanced braces around else statement
#3733: FILE: ./net/batman-adv/translation-table.c:3733:
+ } else {
CHECK: Unbalanced braces around else statement
#3934: FILE: ./net/batman-adv/translation-table.c:3934:
+ } else {
total: 0 errors, 0 warnings, 10 checks, 4380 lines checked
master: checkpatch ./net/batman-adv/tvlv.c
------------------------------------------
CHECK: Unbalanced braces around else statement
#391: FILE: ./net/batman-adv/tvlv.c:391:
+ } else {
total: 0 errors, 0 warnings, 1 checks, 638 lines checked
maint: difference between net and batadv maint
----------------------------------------------
net/include/uapi/linux/batman_adv.h | 2 -
net/net/batman-adv/Makefile | 2 -
net/net/batman-adv/bat_algo.c | 2 -
net/net/batman-adv/bat_algo.h | 2 -
net/net/batman-adv/bat_iv_ogm.c | 2 -
net/net/batman-adv/bat_iv_ogm.h | 2 -
net/net/batman-adv/bat_v.c | 2 -
net/net/batman-adv/bat_v.h | 2 -
net/net/batman-adv/bat_v_elp.c | 2 -
net/net/batman-adv/bat_v_elp.h | 2 -
net/net/batman-adv/bat_v_ogm.c | 2 -
net/net/batman-adv/bat_v_ogm.h | 2 -
net/net/batman-adv/bitarray.c | 2 -
net/net/batman-adv/bitarray.h | 2 -
net/net/batman-adv/bridge_loop_avoidance.c | 3 --
net/net/batman-adv/bridge_loop_avoidance.h | 20 +++++++++++++++++-
net/net/batman-adv/debugfs.c | 4 +--
net/net/batman-adv/debugfs.h | 2 -
net/net/batman-adv/distributed-arp-table.c | 3 --
net/net/batman-adv/distributed-arp-table.h | 2 -
net/net/batman-adv/fragmentation.c | 22 +++++++++-----------
net/net/batman-adv/fragmentation.h | 2 -
net/net/batman-adv/gateway_client.c | 2 -
net/net/batman-adv/gateway_client.h | 2 -
net/net/batman-adv/gateway_common.c | 2 -
net/net/batman-adv/gateway_common.h | 2 -
net/net/batman-adv/hard-interface.c | 2 -
net/net/batman-adv/hard-interface.h | 2 -
net/net/batman-adv/hash.c | 2 -
net/net/batman-adv/hash.h | 2 -
net/net/batman-adv/icmp_socket.c | 2 -
net/net/batman-adv/icmp_socket.h | 2 -
net/net/batman-adv/log.c | 2 -
net/net/batman-adv/log.h | 2 -
net/net/batman-adv/main.c | 2 -
net/net/batman-adv/main.h | 4 +--
net/net/batman-adv/multicast.c | 2 -
net/net/batman-adv/multicast.h | 2 -
net/net/batman-adv/netlink.c | 2 -
net/net/batman-adv/netlink.h | 2 -
net/net/batman-adv/network-coding.c | 2 -
net/net/batman-adv/network-coding.h | 2 -
net/net/batman-adv/originator.c | 2 -
net/net/batman-adv/originator.h | 2 -
net/net/batman-adv/packet.h | 2 -
net/net/batman-adv/routing.c | 11 ++++------
net/net/batman-adv/routing.h | 2 -
net/net/batman-adv/send.c | 6 +++--
net/net/batman-adv/send.h | 2 -
net/net/batman-adv/soft-interface.c | 7 ++----
net/net/batman-adv/soft-interface.h | 2 -
net/net/batman-adv/sysfs.c | 2 -
net/net/batman-adv/sysfs.h | 2 -
net/net/batman-adv/tp_meter.c | 4 +--
net/net/batman-adv/tp_meter.h | 2 -
net/net/batman-adv/translation-table.c | 4 ---
net/net/batman-adv/translation-table.h | 2 -
net/net/batman-adv/tvlv.c | 2 -
net/net/batman-adv/tvlv.h | 2 -
net/net/batman-adv/types.h | 2 -
60 files changed, 99 insertions(+), 87 deletions(-)
master: difference between net and batadv master
------------------------------------------------
netnext/net/batman-adv/fragmentation.c | 20 +++++++++-----------
1 file changed, 9 insertions(+), 11 deletions(-)
maint: headers
--------------
diff --git a/build/net/batman-adv/debugfs.c b/build/net/batman-adv/debugfs.c
index e4e7ee0..5c04a9c 100644
--- a/build/net/batman-adv/debugfs.c
+++ b/build/net/batman-adv/debugfs.c
@@ -16,10 +16,11 @@
*/
#include "debugfs.h"
+
#include "main.h" // IWYU pragma: keep
#include <linux/debugfs.h>
-#include <linux/device.h>
+#include <linux/err.h>
#include <linux/errno.h>
#include <linux/export.h>
#include <linux/fs.h>
diff --git a/build/net/batman-adv/tp_meter.c b/build/net/batman-adv/tp_meter.c
index c4c52fe..bd513a8 100644
--- a/build/net/batman-adv/tp_meter.c
+++ b/build/net/batman-adv/tp_meter.c
@@ -16,6 +16,7 @@
*/
#include "tp_meter.h"
+
#include "main.h" // IWYU pragma: keep
#include <linux/atomic.h>
@@ -23,7 +24,7 @@
#include <linux/byteorder/generic.h>
#include <linux/cache.h>
#include <linux/compiler.h>
-#include <linux/device.h>
+#include <linux/err.h>
#include <linux/etherdevice.h>
#include <linux/fs.h>
#include <linux/if_ether.h>
Statistics
==========
master
------
Failed tests: 18
Started build tests: 47
Tested Linux versions: 23
Tested configs: 40
maint
-----
Failed tests: 2
Started build tests: 45
Tested Linux versions: 23
Tested configs: 39
5 years, 11 months
Build check errors found: 2017-02-22
by postmaster@open-mesh.org
Name of failed tests
====================
master
------
* checkpatch ./net/batman-adv/bat_iv_ogm.c
* checkpatch ./net/batman-adv/bat_v.c
* checkpatch ./net/batman-adv/bridge_loop_avoidance.c
* checkpatch ./net/batman-adv/distributed-arp-table.c
* checkpatch ./net/batman-adv/gateway_client.c
* checkpatch ./net/batman-adv/gateway_common.c
* checkpatch ./net/batman-adv/multicast.c
* checkpatch ./net/batman-adv/network-coding.c
* checkpatch ./net/batman-adv/originator.c
* checkpatch ./net/batman-adv/routing.c
* checkpatch ./net/batman-adv/send.c
* checkpatch ./net/batman-adv/soft-interface.c
* checkpatch ./net/batman-adv/sysfs.c
* checkpatch ./net/batman-adv/tp_meter.c
* checkpatch ./net/batman-adv/translation-table.c
* checkpatch ./net/batman-adv/tvlv.c
* difference between net-next and batadv master
maint
-----
* difference between net and batadv maint
* headers
Output of different failed tests
================================
master: checkpatch ./net/batman-adv/bat_iv_ogm.c
------------------------------------------------
CHECK: Unbalanced braces around else statement
#280: FILE: ./net/batman-adv/bat_iv_ogm.c:280:
+ } else {
CHECK: Unbalanced braces around else statement
#812: FILE: ./net/batman-adv/bat_iv_ogm.c:812:
+ } else {
CHECK: Unbalanced braces around else statement
#1073: FILE: ./net/batman-adv/bat_iv_ogm.c:1073:
+ } else {
CHECK: Unbalanced braces around else statement
#1224: FILE: ./net/batman-adv/bat_iv_ogm.c:1224:
+ } else {
CHECK: Unbalanced braces around else statement
#1370: FILE: ./net/batman-adv/bat_iv_ogm.c:1370:
+ } else {
CHECK: Unbalanced braces around else statement
#2395: FILE: ./net/batman-adv/bat_iv_ogm.c:2395:
+ } else {
total: 0 errors, 0 warnings, 6 checks, 2855 lines checked
master: checkpatch ./net/batman-adv/bat_v.c
-------------------------------------------
CHECK: Unbalanced braces around else statement
#327: FILE: ./net/batman-adv/bat_v.c:327:
+ } else {
total: 0 errors, 0 warnings, 1 checks, 1146 lines checked
master: checkpatch ./net/batman-adv/bridge_loop_avoidance.c
-----------------------------------------------------------
CHECK: Unbalanced braces around else statement
#735: FILE: ./net/batman-adv/bridge_loop_avoidance.c:735:
+ } else {
CHECK: Unbalanced braces around else statement
#866: FILE: ./net/batman-adv/bridge_loop_avoidance.c:866:
+ } else {
CHECK: Unbalanced braces around else statement
#1539: FILE: ./net/batman-adv/bridge_loop_avoidance.c:1539:
+ } else {
CHECK: Unbalanced braces around else statement
#1876: FILE: ./net/batman-adv/bridge_loop_avoidance.c:1876:
+ } else {
CHECK: Unbalanced braces around else statement
#1978: FILE: ./net/batman-adv/bridge_loop_avoidance.c:1978:
+ } else {
total: 0 errors, 0 warnings, 5 checks, 2451 lines checked
master: checkpatch ./net/batman-adv/distributed-arp-table.c
-----------------------------------------------------------
CHECK: Unbalanced braces around else statement
#1057: FILE: ./net/batman-adv/distributed-arp-table.c:1057:
+ } else {
total: 0 errors, 0 warnings, 1 checks, 1285 lines checked
master: checkpatch ./net/batman-adv/gateway_client.c
----------------------------------------------------
CHECK: Unbalanced braces around else statement
#267: FILE: ./net/batman-adv/gateway_client.c:267:
+ } else {
total: 0 errors, 0 warnings, 1 checks, 791 lines checked
master: checkpatch ./net/batman-adv/gateway_common.c
----------------------------------------------------
CHECK: Unbalanced braces around else statement
#231: FILE: ./net/batman-adv/gateway_common.c:231:
+ } else {
total: 0 errors, 0 warnings, 1 checks, 269 lines checked
master: checkpatch ./net/batman-adv/multicast.c
-----------------------------------------------
CHECK: Unbalanced braces around else statement
#1204: FILE: ./net/batman-adv/multicast.c:1204:
+ } else {
total: 0 errors, 0 warnings, 1 checks, 1319 lines checked
master: checkpatch ./net/batman-adv/network-coding.c
----------------------------------------------------
CHECK: Unbalanced braces around else statement
#875: FILE: ./net/batman-adv/network-coding.c:875:
+ } else {
CHECK: Unbalanced braces around else statement
#1123: FILE: ./net/batman-adv/network-coding.c:1123:
+ } else {
CHECK: Unbalanced braces around else statement
#1142: FILE: ./net/batman-adv/network-coding.c:1142:
+ } else {
CHECK: Unbalanced braces around else statement
#1699: FILE: ./net/batman-adv/network-coding.c:1699:
+ } else {
CHECK: Unbalanced braces around else statement
#1765: FILE: ./net/batman-adv/network-coding.c:1765:
+ } else {
total: 0 errors, 0 warnings, 5 checks, 1991 lines checked
master: checkpatch ./net/batman-adv/originator.c
------------------------------------------------
CHECK: Unbalanced braces around else statement
#1179: FILE: ./net/batman-adv/originator.c:1179:
+ } else {
total: 0 errors, 0 warnings, 1 checks, 1590 lines checked
master: checkpatch ./net/batman-adv/routing.c
---------------------------------------------
CHECK: Unbalanced braces around else statement
#650: FILE: ./net/batman-adv/routing.c:650:
+ } else {
CHECK: Unbalanced braces around else statement
#772: FILE: ./net/batman-adv/routing.c:772:
+ } else {
total: 0 errors, 0 warnings, 2 checks, 1242 lines checked
master: checkpatch ./net/batman-adv/send.c
------------------------------------------
CHECK: Unbalanced braces around else statement
#834: FILE: ./net/batman-adv/send.c:834:
+ } else {
total: 0 errors, 0 warnings, 1 checks, 942 lines checked
master: checkpatch ./net/batman-adv/soft-interface.c
----------------------------------------------------
CHECK: Unbalanced braces around else statement
#369: FILE: ./net/batman-adv/soft-interface.c:369:
+ } else {
CHECK: Unbalanced braces around else statement
#380: FILE: ./net/batman-adv/soft-interface.c:380:
+ } else {
total: 0 errors, 0 warnings, 2 checks, 1201 lines checked
master: checkpatch ./net/batman-adv/sysfs.c
-------------------------------------------
CHECK: Unbalanced braces around else statement
#816: FILE: ./net/batman-adv/sysfs.c:816:
+ } else {
total: 0 errors, 0 warnings, 1 checks, 1217 lines checked
master: checkpatch ./net/batman-adv/tp_meter.c
----------------------------------------------
CHECK: Unbalanced braces around else statement
#201: FILE: ./net/batman-adv/tp_meter.c:201:
+ } else {
CHECK: Unbalanced braces around else statement
#235: FILE: ./net/batman-adv/tp_meter.c:235:
+ } else {
CHECK: Unbalanced braces around else statement
#714: FILE: ./net/batman-adv/tp_meter.c:714:
+ } else {
CHECK: Unbalanced braces around else statement
#736: FILE: ./net/batman-adv/tp_meter.c:736:
+ } else {
CHECK: Unbalanced braces around else statement
#1413: FILE: ./net/batman-adv/tp_meter.c:1413:
+ } else {
total: 0 errors, 0 warnings, 5 checks, 1502 lines checked
master: checkpatch ./net/batman-adv/translation-table.c
-------------------------------------------------------
CHECK: Unbalanced braces around else statement
#783: FILE: ./net/batman-adv/translation-table.c:783:
+ } else {
CHECK: Unbalanced braces around else statement
#1672: FILE: ./net/batman-adv/translation-table.c:1672:
+ } else {
CHECK: Unbalanced braces around else statement
#2256: FILE: ./net/batman-adv/translation-table.c:2256:
+ } else
CHECK: Unbalanced braces around else statement
#2317: FILE: ./net/batman-adv/translation-table.c:2317:
+ } else
CHECK: Unbalanced braces around else statement
#3170: FILE: ./net/batman-adv/translation-table.c:3170:
+ } else {
CHECK: Unbalanced braces around else statement
#3297: FILE: ./net/batman-adv/translation-table.c:3297:
+ } else {
CHECK: Unbalanced braces around else statement
#3383: FILE: ./net/batman-adv/translation-table.c:3383:
+ } else {
CHECK: Unbalanced braces around else statement
#3512: FILE: ./net/batman-adv/translation-table.c:3512:
+ } else {
CHECK: Unbalanced braces around else statement
#3733: FILE: ./net/batman-adv/translation-table.c:3733:
+ } else {
CHECK: Unbalanced braces around else statement
#3934: FILE: ./net/batman-adv/translation-table.c:3934:
+ } else {
total: 0 errors, 0 warnings, 10 checks, 4380 lines checked
master: checkpatch ./net/batman-adv/tvlv.c
------------------------------------------
CHECK: Unbalanced braces around else statement
#391: FILE: ./net/batman-adv/tvlv.c:391:
+ } else {
total: 0 errors, 0 warnings, 1 checks, 638 lines checked
maint: difference between net and batadv maint
----------------------------------------------
net/net/batman-adv/fragmentation.c | 20 +++++++++-----------
1 file changed, 9 insertions(+), 11 deletions(-)
master: difference between net-next and batadv master
-----------------------------------------------------
netnext/net/batman-adv/fragmentation.c | 20 +++++++++-----------
1 file changed, 9 insertions(+), 11 deletions(-)
maint: headers
--------------
diff --git a/build/net/batman-adv/debugfs.c b/build/net/batman-adv/debugfs.c
index e4e7ee0..5c04a9c 100644
--- a/build/net/batman-adv/debugfs.c
+++ b/build/net/batman-adv/debugfs.c
@@ -16,10 +16,11 @@
*/
#include "debugfs.h"
+
#include "main.h" // IWYU pragma: keep
#include <linux/debugfs.h>
-#include <linux/device.h>
+#include <linux/err.h>
#include <linux/errno.h>
#include <linux/export.h>
#include <linux/fs.h>
diff --git a/build/net/batman-adv/tp_meter.c b/build/net/batman-adv/tp_meter.c
index c4c52fe..bd513a8 100644
--- a/build/net/batman-adv/tp_meter.c
+++ b/build/net/batman-adv/tp_meter.c
@@ -16,6 +16,7 @@
*/
#include "tp_meter.h"
+
#include "main.h" // IWYU pragma: keep
#include <linux/atomic.h>
@@ -23,7 +24,7 @@
#include <linux/byteorder/generic.h>
#include <linux/cache.h>
#include <linux/compiler.h>
-#include <linux/device.h>
+#include <linux/err.h>
#include <linux/etherdevice.h>
#include <linux/fs.h>
#include <linux/if_ether.h>
Statistics
==========
master
------
Failed tests: 17
Started build tests: 58
Tested Linux versions: 26
Tested configs: 45
maint
-----
Failed tests: 2
Started build tests: 48
Tested Linux versions: 26
Tested configs: 41
5 years, 11 months