Build check errors found: 2014-07-01
by postmaster＠open-mesh.org
Name of failed tests
====================
checkpatch master bat_iv_ogm.c
checkpatch master bitarray.c
checkpatch master bitarray.h
checkpatch master bridge_loop_avoidance.c
checkpatch master debugfs.c
checkpatch master distributed-arp-table.c
checkpatch master fragmentation.c
checkpatch master fragmentation.h
checkpatch master gateway_client.c
checkpatch master main.c
checkpatch master multicast.h
checkpatch master network-coding.c
checkpatch master originator.c
checkpatch master originator.h
checkpatch master packet.h
checkpatch master routing.c
checkpatch master soft-interface.c
checkpatch master sysfs.c
checkpatch master translation-table.c
checkpatch next bat_iv_ogm.c
checkpatch next bitarray.c
checkpatch next bitarray.h
checkpatch next bridge_loop_avoidance.c
checkpatch next debugfs.c
checkpatch next distributed-arp-table.c
checkpatch next fragmentation.c
checkpatch next fragmentation.h
checkpatch next gateway_client.c
checkpatch next hash.c
checkpatch next main.c
checkpatch next multicast.h
checkpatch next network-coding.c
checkpatch next originator.c
checkpatch next originator.h
checkpatch next packet.h
checkpatch next routing.c
checkpatch next soft-interface.c
checkpatch next sysfs.c
checkpatch next translation-table.c
Output of different failed tests
================================
checkpatch master bat_iv_ogm.c:
>>>>>>>>
CHECK: Please don't use multiple blank lines
#29: FILE: bat_iv_ogm.c:29:
+
+
CHECK: Unnecessary parentheses around orig_node->bat_iv.bcast_own[word_index]
#882: FILE: bat_iv_ogm.c:882:
+ word = &(orig_node->bat_iv.bcast_own[word_index]);
CHECK: Please don't use multiple blank lines
#1365: FILE: bat_iv_ogm.c:1365:
+
+
CHECK: Unnecessary parentheses around orig_neigh_node->bat_iv.bcast_own[offset]
#1667: FILE: bat_iv_ogm.c:1667:
+ word = &(orig_neigh_node->bat_iv.bcast_own[offset]);
total: 0 errors, 0 warnings, 4 checks, 1980 lines checked
checkpatch master distributed-arp-table.c:
>>>>>>>>
CHECK: Please use a blank line after function/struct/union/enum declarations
#1103: FILE: distributed-arp-table.c:1103:
+}
+/**
total: 0 errors, 0 warnings, 1 checks, 1203 lines checked
checkpatch master fragmentation.c:
>>>>>>>>
CHECK: Please don't use multiple blank lines
#26: FILE: fragmentation.c:26:
+
+
total: 0 errors, 0 warnings, 1 checks, 498 lines checked
checkpatch next bat_iv_ogm.c:
>>>>>>>>
CHECK: Please don't use multiple blank lines
#29: FILE: bat_iv_ogm.c:29:
+
+
WARNING: Prefer kmalloc_array over kmalloc with multiply
#126: FILE: bat_iv_ogm.c:126:
+ data_ptr = kmalloc(max_if_num * sizeof(uint8_t), GFP_ATOMIC);
WARNING: Prefer kmalloc_array over kmalloc with multiply
#186: FILE: bat_iv_ogm.c:186:
+ data_ptr = kmalloc(max_if_num * sizeof(uint8_t), GFP_ATOMIC);
CHECK: Unnecessary parentheses around orig_node->bat_iv.bcast_own[word_index]
#881: FILE: bat_iv_ogm.c:881:
+ word = &(orig_node->bat_iv.bcast_own[word_index]);
CHECK: Please don't use multiple blank lines
#1364: FILE: bat_iv_ogm.c:1364:
+
+
CHECK: Unnecessary parentheses around orig_neigh_node->bat_iv.bcast_own[offset]
#1666: FILE: bat_iv_ogm.c:1666:
+ word = &(orig_neigh_node->bat_iv.bcast_own[offset]);
total: 0 errors, 2 warnings, 4 checks, 1979 lines checked
checkpatch next bitarray.c:
>>>>>>>>
CHECK: Please don't use multiple blank lines
#32: FILE: bitarray.c:32:
+
+
total: 0 errors, 0 warnings, 1 checks, 93 lines checked
checkpatch next bitarray.h:
>>>>>>>>
WARNING: else is not generally useful after a break or return
#32: FILE: bitarray.h:32:
+ return 0;
+ else
total: 0 errors, 1 warnings, 0 checks, 52 lines checked
checkpatch next bridge_loop_avoidance.c:
>>>>>>>>
CHECK: Please don't use multiple blank lines
#72: FILE: bridge_loop_avoidance.c:72:
+
+
CHECK: Please don't use multiple blank lines
#663: FILE: bridge_loop_avoidance.c:663:
+
+
CHECK: Please don't use multiple blank lines
#849: FILE: bridge_loop_avoidance.c:849:
+
+
CHECK: Please don't use multiple blank lines
#1346: FILE: bridge_loop_avoidance.c:1346:
+
+
CHECK: Please don't use multiple blank lines
#1389: FILE: bridge_loop_avoidance.c:1389:
+
+
CHECK: Please don't use multiple blank lines
#1479: FILE: bridge_loop_avoidance.c:1479:
+
+
total: 0 errors, 0 warnings, 6 checks, 1725 lines checked
checkpatch next debugfs.c:
>>>>>>>>
WARNING: void function return statements are not generally useful
#237: FILE: debugfs.c:237:
+ return;
+}
CHECK: Please use a blank line after function/struct/union/enum declarations
#408: FILE: debugfs.c:408:
+}
+static BATADV_HARDIF_DEBUGINFO(originators, S_IRUGO,
total: 0 errors, 1 warnings, 1 checks, 561 lines checked
checkpatch next distributed-arp-table.c:
>>>>>>>>
WARNING: Prefer kmalloc_array over kmalloc with multiply
#540: FILE: distributed-arp-table.c:540:
+ res = kmalloc(BATADV_DAT_CANDIDATES_NUM * sizeof(*res), GFP_ATOMIC);
CHECK: Please use a blank line after function/struct/union/enum declarations
#1102: FILE: distributed-arp-table.c:1102:
+}
+/**
total: 0 errors, 1 warnings, 1 checks, 1202 lines checked
checkpatch next fragmentation.c:
>>>>>>>>
CHECK: Please don't use multiple blank lines
#26: FILE: fragmentation.c:26:
+
+
total: 0 errors, 0 warnings, 1 checks, 494 lines checked
checkpatch next fragmentation.h:
>>>>>>>>
WARNING: else is not generally useful after a break or return
#44: FILE: fragmentation.h:44:
+ return true;
+ else
total: 0 errors, 1 warnings, 0 checks, 48 lines checked
checkpatch next gateway_client.c:
>>>>>>>>
CHECK: Please use a blank line after function/struct/union/enum declarations
#778: FILE: gateway_client.c:778:
+}
+/**
total: 0 errors, 0 warnings, 1 checks, 879 lines checked
checkpatch next hash.c:
>>>>>>>>
WARNING: Prefer kmalloc_array over kmalloc with multiply
#49: FILE: hash.c:49:
+ hash->table = kmalloc(sizeof(*hash->table) * size, GFP_ATOMIC);
WARNING: Prefer kmalloc_array over kmalloc with multiply
#53: FILE: hash.c:53:
+ hash->list_locks = kmalloc(sizeof(*hash->list_locks) * size,
total: 0 errors, 2 warnings, 0 checks, 76 lines checked
checkpatch next main.c:
>>>>>>>>
CHECK: Please don't use multiple blank lines
#44: FILE: main.c:44:
+
+
total: 0 errors, 0 warnings, 1 checks, 1263 lines checked
checkpatch next multicast.h:
>>>>>>>>
WARNING: void function return statements are not generally useful
#54: FILE: multicast.h:54:
+ return;
+}
WARNING: void function return statements are not generally useful
#71: FILE: multicast.h:71:
+ return;
+}
WARNING: void function return statements are not generally useful
#76: FILE: multicast.h:76:
+ return;
+}
total: 0 errors, 3 warnings, 0 checks, 80 lines checked
checkpatch next network-coding.c:
>>>>>>>>
WARNING: else is not generally useful after a break or return
#1215: FILE: network-coding.c:1215:
+ return false;
+ else
total: 0 errors, 1 warnings, 0 checks, 1937 lines checked
checkpatch next originator.c:
>>>>>>>>
CHECK: Please don't use multiple blank lines
#802: FILE: originator.c:802:
+
+
total: 0 errors, 0 warnings, 1 checks, 1177 lines checked
checkpatch next originator.h:
>>>>>>>>
CHECK: Please don't use multiple blank lines
#73: FILE: originator.h:73:
+
+
total: 0 errors, 0 warnings, 1 checks, 126 lines checked
checkpatch next packet.h:
>>>>>>>>
CHECK: Please use a blank line after function/struct/union/enum declarations
#201: FILE: packet.h:201:
+};
+#pragma pack()
total: 0 errors, 0 warnings, 1 checks, 552 lines checked
checkpatch next routing.c:
>>>>>>>>
CHECK: Please don't use multiple blank lines
#295: FILE: routing.c:295:
+
+
total: 0 errors, 0 warnings, 1 checks, 1085 lines checked
checkpatch next soft-interface.c:
>>>>>>>>
CHECK: Please don't use multiple blank lines
#39: FILE: soft-interface.c:39:
+
+
total: 0 errors, 0 warnings, 1 checks, 1114 lines checked
checkpatch next sysfs.c:
>>>>>>>>
CHECK: Please don't use multiple blank lines
#154: FILE: sysfs.c:154:
+
+
total: 0 errors, 0 warnings, 1 checks, 944 lines checked
checkpatch next translation-table.c:
>>>>>>>>
CHECK: Please don't use multiple blank lines
#1783: FILE: translation-table.c:1783:
+
+
WARNING: else is not generally useful after a break or return
#2772: FILE: translation-table.c:2772:
+ return batadv_send_my_tt_response(bat_priv, tt_data, req_src);
+ else
total: 0 errors, 1 warnings, 1 checks, 3712 lines checked
6 years, 6 months
Build check errors found: 2014-06-30
by postmaster＠open-mesh.org
Name of failed tests
====================
checkpatch master bat_iv_ogm.c
checkpatch master bitarray.c
checkpatch master bitarray.h
checkpatch master bridge_loop_avoidance.c
checkpatch master debugfs.c
checkpatch master distributed-arp-table.c
checkpatch master fragmentation.c
checkpatch master fragmentation.h
checkpatch master gateway_client.c
checkpatch master main.c
checkpatch master multicast.h
checkpatch master network-coding.c
checkpatch master originator.c
checkpatch master originator.h
checkpatch master packet.h
checkpatch master routing.c
checkpatch master soft-interface.c
checkpatch master sysfs.c
checkpatch master translation-table.c
checkpatch next bat_iv_ogm.c
checkpatch next bitarray.c
checkpatch next bitarray.h
checkpatch next bridge_loop_avoidance.c
checkpatch next debugfs.c
checkpatch next distributed-arp-table.c
checkpatch next fragmentation.c
checkpatch next fragmentation.h
checkpatch next gateway_client.c
checkpatch next hash.c
checkpatch next main.c
checkpatch next multicast.h
checkpatch next network-coding.c
checkpatch next originator.c
checkpatch next originator.h
checkpatch next packet.h
checkpatch next routing.c
checkpatch next soft-interface.c
checkpatch next sysfs.c
checkpatch next translation-table.c
Output of different failed tests
================================
checkpatch master bat_iv_ogm.c:
>>>>>>>>
CHECK: Please don't use multiple blank lines
#29: FILE: bat_iv_ogm.c:29:
+
+
CHECK: Unnecessary parentheses around orig_node->bat_iv.bcast_own[word_index]
#882: FILE: bat_iv_ogm.c:882:
+ word = &(orig_node->bat_iv.bcast_own[word_index]);
CHECK: Please don't use multiple blank lines
#1365: FILE: bat_iv_ogm.c:1365:
+
+
CHECK: Unnecessary parentheses around orig_neigh_node->bat_iv.bcast_own[offset]
#1667: FILE: bat_iv_ogm.c:1667:
+ word = &(orig_neigh_node->bat_iv.bcast_own[offset]);
total: 0 errors, 0 warnings, 4 checks, 1980 lines checked
checkpatch master distributed-arp-table.c:
>>>>>>>>
CHECK: Please use a blank line after function/struct/union/enum declarations
#1103: FILE: distributed-arp-table.c:1103:
+}
+/**
total: 0 errors, 0 warnings, 1 checks, 1203 lines checked
checkpatch master fragmentation.c:
>>>>>>>>
CHECK: Please don't use multiple blank lines
#26: FILE: fragmentation.c:26:
+
+
total: 0 errors, 0 warnings, 1 checks, 498 lines checked
checkpatch next bat_iv_ogm.c:
>>>>>>>>
CHECK: Please don't use multiple blank lines
#29: FILE: bat_iv_ogm.c:29:
+
+
WARNING: Prefer kmalloc_array over kmalloc with multiply
#126: FILE: bat_iv_ogm.c:126:
+ data_ptr = kmalloc(max_if_num * sizeof(uint8_t), GFP_ATOMIC);
WARNING: Prefer kmalloc_array over kmalloc with multiply
#186: FILE: bat_iv_ogm.c:186:
+ data_ptr = kmalloc(max_if_num * sizeof(uint8_t), GFP_ATOMIC);
CHECK: Unnecessary parentheses around orig_node->bat_iv.bcast_own[word_index]
#881: FILE: bat_iv_ogm.c:881:
+ word = &(orig_node->bat_iv.bcast_own[word_index]);
CHECK: Please don't use multiple blank lines
#1364: FILE: bat_iv_ogm.c:1364:
+
+
CHECK: Unnecessary parentheses around orig_neigh_node->bat_iv.bcast_own[offset]
#1666: FILE: bat_iv_ogm.c:1666:
+ word = &(orig_neigh_node->bat_iv.bcast_own[offset]);
total: 0 errors, 2 warnings, 4 checks, 1979 lines checked
checkpatch next bitarray.c:
>>>>>>>>
CHECK: Please don't use multiple blank lines
#32: FILE: bitarray.c:32:
+
+
total: 0 errors, 0 warnings, 1 checks, 93 lines checked
checkpatch next bitarray.h:
>>>>>>>>
WARNING: else is not generally useful after a break or return
#32: FILE: bitarray.h:32:
+ return 0;
+ else
total: 0 errors, 1 warnings, 0 checks, 52 lines checked
checkpatch next bridge_loop_avoidance.c:
>>>>>>>>
CHECK: Please don't use multiple blank lines
#72: FILE: bridge_loop_avoidance.c:72:
+
+
CHECK: Please don't use multiple blank lines
#663: FILE: bridge_loop_avoidance.c:663:
+
+
CHECK: Please don't use multiple blank lines
#849: FILE: bridge_loop_avoidance.c:849:
+
+
CHECK: Please don't use multiple blank lines
#1346: FILE: bridge_loop_avoidance.c:1346:
+
+
CHECK: Please don't use multiple blank lines
#1389: FILE: bridge_loop_avoidance.c:1389:
+
+
CHECK: Please don't use multiple blank lines
#1479: FILE: bridge_loop_avoidance.c:1479:
+
+
total: 0 errors, 0 warnings, 6 checks, 1725 lines checked
checkpatch next debugfs.c:
>>>>>>>>
WARNING: void function return statements are not generally useful
#237: FILE: debugfs.c:237:
+ return;
+}
CHECK: Please use a blank line after function/struct/union/enum declarations
#408: FILE: debugfs.c:408:
+}
+static BATADV_HARDIF_DEBUGINFO(originators, S_IRUGO,
total: 0 errors, 1 warnings, 1 checks, 561 lines checked
checkpatch next distributed-arp-table.c:
>>>>>>>>
WARNING: Prefer kmalloc_array over kmalloc with multiply
#540: FILE: distributed-arp-table.c:540:
+ res = kmalloc(BATADV_DAT_CANDIDATES_NUM * sizeof(*res), GFP_ATOMIC);
CHECK: Please use a blank line after function/struct/union/enum declarations
#1102: FILE: distributed-arp-table.c:1102:
+}
+/**
total: 0 errors, 1 warnings, 1 checks, 1202 lines checked
checkpatch next fragmentation.c:
>>>>>>>>
CHECK: Please don't use multiple blank lines
#26: FILE: fragmentation.c:26:
+
+
total: 0 errors, 0 warnings, 1 checks, 494 lines checked
checkpatch next fragmentation.h:
>>>>>>>>
WARNING: else is not generally useful after a break or return
#44: FILE: fragmentation.h:44:
+ return true;
+ else
total: 0 errors, 1 warnings, 0 checks, 48 lines checked
checkpatch next gateway_client.c:
>>>>>>>>
CHECK: Please use a blank line after function/struct/union/enum declarations
#778: FILE: gateway_client.c:778:
+}
+/**
total: 0 errors, 0 warnings, 1 checks, 879 lines checked
checkpatch next hash.c:
>>>>>>>>
WARNING: Prefer kmalloc_array over kmalloc with multiply
#49: FILE: hash.c:49:
+ hash->table = kmalloc(sizeof(*hash->table) * size, GFP_ATOMIC);
WARNING: Prefer kmalloc_array over kmalloc with multiply
#53: FILE: hash.c:53:
+ hash->list_locks = kmalloc(sizeof(*hash->list_locks) * size,
total: 0 errors, 2 warnings, 0 checks, 76 lines checked
checkpatch next main.c:
>>>>>>>>
CHECK: Please don't use multiple blank lines
#44: FILE: main.c:44:
+
+
total: 0 errors, 0 warnings, 1 checks, 1263 lines checked
checkpatch next multicast.h:
>>>>>>>>
WARNING: void function return statements are not generally useful
#54: FILE: multicast.h:54:
+ return;
+}
WARNING: void function return statements are not generally useful
#71: FILE: multicast.h:71:
+ return;
+}
WARNING: void function return statements are not generally useful
#76: FILE: multicast.h:76:
+ return;
+}
total: 0 errors, 3 warnings, 0 checks, 80 lines checked
checkpatch next network-coding.c:
>>>>>>>>
WARNING: else is not generally useful after a break or return
#1215: FILE: network-coding.c:1215:
+ return false;
+ else
total: 0 errors, 1 warnings, 0 checks, 1937 lines checked
checkpatch next originator.c:
>>>>>>>>
CHECK: Please don't use multiple blank lines
#802: FILE: originator.c:802:
+
+
total: 0 errors, 0 warnings, 1 checks, 1177 lines checked
checkpatch next originator.h:
>>>>>>>>
CHECK: Please don't use multiple blank lines
#73: FILE: originator.h:73:
+
+
total: 0 errors, 0 warnings, 1 checks, 126 lines checked
checkpatch next packet.h:
>>>>>>>>
CHECK: Please use a blank line after function/struct/union/enum declarations
#201: FILE: packet.h:201:
+};
+#pragma pack()
total: 0 errors, 0 warnings, 1 checks, 552 lines checked
checkpatch next routing.c:
>>>>>>>>
CHECK: Please don't use multiple blank lines
#295: FILE: routing.c:295:
+
+
total: 0 errors, 0 warnings, 1 checks, 1085 lines checked
checkpatch next soft-interface.c:
>>>>>>>>
CHECK: Please don't use multiple blank lines
#39: FILE: soft-interface.c:39:
+
+
total: 0 errors, 0 warnings, 1 checks, 1114 lines checked
checkpatch next sysfs.c:
>>>>>>>>
CHECK: Please don't use multiple blank lines
#154: FILE: sysfs.c:154:
+
+
total: 0 errors, 0 warnings, 1 checks, 944 lines checked
checkpatch next translation-table.c:
>>>>>>>>
CHECK: Please don't use multiple blank lines
#1783: FILE: translation-table.c:1783:
+
+
WARNING: else is not generally useful after a break or return
#2772: FILE: translation-table.c:2772:
+ return batadv_send_my_tt_response(bat_priv, tt_data, req_src);
+ else
total: 0 errors, 1 warnings, 1 checks, 3712 lines checked
6 years, 6 months
Build check errors found: 2014-06-29
by postmaster＠open-mesh.org
Name of failed tests
====================
checkpatch master bat_iv_ogm.c
checkpatch master bitarray.c
checkpatch master bitarray.h
checkpatch master bridge_loop_avoidance.c
checkpatch master debugfs.c
checkpatch master distributed-arp-table.c
checkpatch master fragmentation.c
checkpatch master fragmentation.h
checkpatch master gateway_client.c
checkpatch master main.c
checkpatch master multicast.h
checkpatch master network-coding.c
checkpatch master originator.c
checkpatch master originator.h
checkpatch master packet.h
checkpatch master routing.c
checkpatch master soft-interface.c
checkpatch master sysfs.c
checkpatch master translation-table.c
checkpatch next bat_iv_ogm.c
checkpatch next bitarray.c
checkpatch next bitarray.h
checkpatch next bridge_loop_avoidance.c
checkpatch next debugfs.c
checkpatch next distributed-arp-table.c
checkpatch next fragmentation.c
checkpatch next fragmentation.h
checkpatch next gateway_client.c
checkpatch next hash.c
checkpatch next main.c
checkpatch next multicast.h
checkpatch next network-coding.c
checkpatch next originator.c
checkpatch next originator.h
checkpatch next packet.h
checkpatch next routing.c
checkpatch next soft-interface.c
checkpatch next sysfs.c
checkpatch next translation-table.c
Output of different failed tests
================================
checkpatch master bat_iv_ogm.c:
>>>>>>>>
CHECK: Please don't use multiple blank lines
#29: FILE: bat_iv_ogm.c:29:
+
+
CHECK: Unnecessary parentheses around orig_node->bat_iv.bcast_own[word_index]
#882: FILE: bat_iv_ogm.c:882:
+ word = &(orig_node->bat_iv.bcast_own[word_index]);
CHECK: Please don't use multiple blank lines
#1365: FILE: bat_iv_ogm.c:1365:
+
+
CHECK: Unnecessary parentheses around orig_neigh_node->bat_iv.bcast_own[offset]
#1667: FILE: bat_iv_ogm.c:1667:
+ word = &(orig_neigh_node->bat_iv.bcast_own[offset]);
total: 0 errors, 0 warnings, 4 checks, 1980 lines checked
checkpatch master distributed-arp-table.c:
>>>>>>>>
CHECK: Please use a blank line after function/struct/union/enum declarations
#1103: FILE: distributed-arp-table.c:1103:
+}
+/**
total: 0 errors, 0 warnings, 1 checks, 1203 lines checked
checkpatch master fragmentation.c:
>>>>>>>>
CHECK: Please don't use multiple blank lines
#26: FILE: fragmentation.c:26:
+
+
total: 0 errors, 0 warnings, 1 checks, 498 lines checked
checkpatch next bat_iv_ogm.c:
>>>>>>>>
CHECK: Please don't use multiple blank lines
#29: FILE: bat_iv_ogm.c:29:
+
+
WARNING: Prefer kmalloc_array over kmalloc with multiply
#126: FILE: bat_iv_ogm.c:126:
+ data_ptr = kmalloc(max_if_num * sizeof(uint8_t), GFP_ATOMIC);
WARNING: Prefer kmalloc_array over kmalloc with multiply
#186: FILE: bat_iv_ogm.c:186:
+ data_ptr = kmalloc(max_if_num * sizeof(uint8_t), GFP_ATOMIC);
CHECK: Unnecessary parentheses around orig_node->bat_iv.bcast_own[word_index]
#881: FILE: bat_iv_ogm.c:881:
+ word = &(orig_node->bat_iv.bcast_own[word_index]);
CHECK: Please don't use multiple blank lines
#1364: FILE: bat_iv_ogm.c:1364:
+
+
CHECK: Unnecessary parentheses around orig_neigh_node->bat_iv.bcast_own[offset]
#1666: FILE: bat_iv_ogm.c:1666:
+ word = &(orig_neigh_node->bat_iv.bcast_own[offset]);
total: 0 errors, 2 warnings, 4 checks, 1979 lines checked
checkpatch next bitarray.c:
>>>>>>>>
CHECK: Please don't use multiple blank lines
#32: FILE: bitarray.c:32:
+
+
total: 0 errors, 0 warnings, 1 checks, 93 lines checked
checkpatch next bitarray.h:
>>>>>>>>
WARNING: else is not generally useful after a break or return
#32: FILE: bitarray.h:32:
+ return 0;
+ else
total: 0 errors, 1 warnings, 0 checks, 52 lines checked
checkpatch next bridge_loop_avoidance.c:
>>>>>>>>
CHECK: Please don't use multiple blank lines
#72: FILE: bridge_loop_avoidance.c:72:
+
+
CHECK: Please don't use multiple blank lines
#663: FILE: bridge_loop_avoidance.c:663:
+
+
CHECK: Please don't use multiple blank lines
#849: FILE: bridge_loop_avoidance.c:849:
+
+
CHECK: Please don't use multiple blank lines
#1346: FILE: bridge_loop_avoidance.c:1346:
+
+
CHECK: Please don't use multiple blank lines
#1389: FILE: bridge_loop_avoidance.c:1389:
+
+
CHECK: Please don't use multiple blank lines
#1479: FILE: bridge_loop_avoidance.c:1479:
+
+
total: 0 errors, 0 warnings, 6 checks, 1725 lines checked
checkpatch next debugfs.c:
>>>>>>>>
WARNING: void function return statements are not generally useful
#237: FILE: debugfs.c:237:
+ return;
+}
CHECK: Please use a blank line after function/struct/union/enum declarations
#408: FILE: debugfs.c:408:
+}
+static BATADV_HARDIF_DEBUGINFO(originators, S_IRUGO,
total: 0 errors, 1 warnings, 1 checks, 561 lines checked
checkpatch next distributed-arp-table.c:
>>>>>>>>
WARNING: Prefer kmalloc_array over kmalloc with multiply
#540: FILE: distributed-arp-table.c:540:
+ res = kmalloc(BATADV_DAT_CANDIDATES_NUM * sizeof(*res), GFP_ATOMIC);
CHECK: Please use a blank line after function/struct/union/enum declarations
#1102: FILE: distributed-arp-table.c:1102:
+}
+/**
total: 0 errors, 1 warnings, 1 checks, 1202 lines checked
checkpatch next fragmentation.c:
>>>>>>>>
CHECK: Please don't use multiple blank lines
#26: FILE: fragmentation.c:26:
+
+
total: 0 errors, 0 warnings, 1 checks, 494 lines checked
checkpatch next fragmentation.h:
>>>>>>>>
WARNING: else is not generally useful after a break or return
#44: FILE: fragmentation.h:44:
+ return true;
+ else
total: 0 errors, 1 warnings, 0 checks, 48 lines checked
checkpatch next gateway_client.c:
>>>>>>>>
CHECK: Please use a blank line after function/struct/union/enum declarations
#778: FILE: gateway_client.c:778:
+}
+/**
total: 0 errors, 0 warnings, 1 checks, 879 lines checked
checkpatch next hash.c:
>>>>>>>>
WARNING: Prefer kmalloc_array over kmalloc with multiply
#49: FILE: hash.c:49:
+ hash->table = kmalloc(sizeof(*hash->table) * size, GFP_ATOMIC);
WARNING: Prefer kmalloc_array over kmalloc with multiply
#53: FILE: hash.c:53:
+ hash->list_locks = kmalloc(sizeof(*hash->list_locks) * size,
total: 0 errors, 2 warnings, 0 checks, 76 lines checked
checkpatch next main.c:
>>>>>>>>
CHECK: Please don't use multiple blank lines
#44: FILE: main.c:44:
+
+
total: 0 errors, 0 warnings, 1 checks, 1263 lines checked
checkpatch next multicast.h:
>>>>>>>>
WARNING: void function return statements are not generally useful
#54: FILE: multicast.h:54:
+ return;
+}
WARNING: void function return statements are not generally useful
#71: FILE: multicast.h:71:
+ return;
+}
WARNING: void function return statements are not generally useful
#76: FILE: multicast.h:76:
+ return;
+}
total: 0 errors, 3 warnings, 0 checks, 80 lines checked
checkpatch next network-coding.c:
>>>>>>>>
WARNING: else is not generally useful after a break or return
#1215: FILE: network-coding.c:1215:
+ return false;
+ else
total: 0 errors, 1 warnings, 0 checks, 1937 lines checked
checkpatch next originator.c:
>>>>>>>>
CHECK: Please don't use multiple blank lines
#802: FILE: originator.c:802:
+
+
total: 0 errors, 0 warnings, 1 checks, 1177 lines checked
checkpatch next originator.h:
>>>>>>>>
CHECK: Please don't use multiple blank lines
#73: FILE: originator.h:73:
+
+
total: 0 errors, 0 warnings, 1 checks, 126 lines checked
checkpatch next packet.h:
>>>>>>>>
CHECK: Please use a blank line after function/struct/union/enum declarations
#201: FILE: packet.h:201:
+};
+#pragma pack()
total: 0 errors, 0 warnings, 1 checks, 552 lines checked
checkpatch next routing.c:
>>>>>>>>
CHECK: Please don't use multiple blank lines
#295: FILE: routing.c:295:
+
+
total: 0 errors, 0 warnings, 1 checks, 1085 lines checked
checkpatch next soft-interface.c:
>>>>>>>>
CHECK: Please don't use multiple blank lines
#39: FILE: soft-interface.c:39:
+
+
total: 0 errors, 0 warnings, 1 checks, 1114 lines checked
checkpatch next sysfs.c:
>>>>>>>>
CHECK: Please don't use multiple blank lines
#154: FILE: sysfs.c:154:
+
+
total: 0 errors, 0 warnings, 1 checks, 944 lines checked
checkpatch next translation-table.c:
>>>>>>>>
CHECK: Please don't use multiple blank lines
#1783: FILE: translation-table.c:1783:
+
+
WARNING: else is not generally useful after a break or return
#2772: FILE: translation-table.c:2772:
+ return batadv_send_my_tt_response(bat_priv, tt_data, req_src);
+ else
total: 0 errors, 1 warnings, 1 checks, 3712 lines checked
6 years, 6 months
Build check errors found: 2014-06-28
by postmaster＠open-mesh.org
Name of failed tests
====================
checkpatch master bat_iv_ogm.c
checkpatch master bitarray.c
checkpatch master bitarray.h
checkpatch master bridge_loop_avoidance.c
checkpatch master debugfs.c
checkpatch master distributed-arp-table.c
checkpatch master fragmentation.c
checkpatch master fragmentation.h
checkpatch master gateway_client.c
checkpatch master main.c
checkpatch master multicast.h
checkpatch master network-coding.c
checkpatch master originator.c
checkpatch master originator.h
checkpatch master packet.h
checkpatch master routing.c
checkpatch master soft-interface.c
checkpatch master sysfs.c
checkpatch master translation-table.c
checkpatch next bat_iv_ogm.c
checkpatch next bitarray.c
checkpatch next bitarray.h
checkpatch next bridge_loop_avoidance.c
checkpatch next debugfs.c
checkpatch next distributed-arp-table.c
checkpatch next fragmentation.c
checkpatch next fragmentation.h
checkpatch next gateway_client.c
checkpatch next hash.c
checkpatch next main.c
checkpatch next multicast.h
checkpatch next network-coding.c
checkpatch next originator.c
checkpatch next originator.h
checkpatch next packet.h
checkpatch next routing.c
checkpatch next soft-interface.c
checkpatch next sysfs.c
checkpatch next translation-table.c
Output of different failed tests
================================
checkpatch master bat_iv_ogm.c:
>>>>>>>>
CHECK: Please don't use multiple blank lines
#29: FILE: bat_iv_ogm.c:29:
+
+
CHECK: Unnecessary parentheses around orig_node->bat_iv.bcast_own[word_index]
#882: FILE: bat_iv_ogm.c:882:
+ word = &(orig_node->bat_iv.bcast_own[word_index]);
CHECK: Please don't use multiple blank lines
#1365: FILE: bat_iv_ogm.c:1365:
+
+
CHECK: Unnecessary parentheses around orig_neigh_node->bat_iv.bcast_own[offset]
#1667: FILE: bat_iv_ogm.c:1667:
+ word = &(orig_neigh_node->bat_iv.bcast_own[offset]);
total: 0 errors, 0 warnings, 4 checks, 1980 lines checked
checkpatch master distributed-arp-table.c:
>>>>>>>>
CHECK: Please use a blank line after function/struct/union/enum declarations
#1103: FILE: distributed-arp-table.c:1103:
+}
+/**
total: 0 errors, 0 warnings, 1 checks, 1203 lines checked
checkpatch master fragmentation.c:
>>>>>>>>
CHECK: Please don't use multiple blank lines
#26: FILE: fragmentation.c:26:
+
+
total: 0 errors, 0 warnings, 1 checks, 498 lines checked
checkpatch next bat_iv_ogm.c:
>>>>>>>>
CHECK: Please don't use multiple blank lines
#29: FILE: bat_iv_ogm.c:29:
+
+
WARNING: Prefer kmalloc_array over kmalloc with multiply
#126: FILE: bat_iv_ogm.c:126:
+ data_ptr = kmalloc(max_if_num * sizeof(uint8_t), GFP_ATOMIC);
WARNING: Prefer kmalloc_array over kmalloc with multiply
#186: FILE: bat_iv_ogm.c:186:
+ data_ptr = kmalloc(max_if_num * sizeof(uint8_t), GFP_ATOMIC);
CHECK: Unnecessary parentheses around orig_node->bat_iv.bcast_own[word_index]
#881: FILE: bat_iv_ogm.c:881:
+ word = &(orig_node->bat_iv.bcast_own[word_index]);
CHECK: Please don't use multiple blank lines
#1364: FILE: bat_iv_ogm.c:1364:
+
+
CHECK: Unnecessary parentheses around orig_neigh_node->bat_iv.bcast_own[offset]
#1666: FILE: bat_iv_ogm.c:1666:
+ word = &(orig_neigh_node->bat_iv.bcast_own[offset]);
total: 0 errors, 2 warnings, 4 checks, 1979 lines checked
checkpatch next bitarray.c:
>>>>>>>>
CHECK: Please don't use multiple blank lines
#32: FILE: bitarray.c:32:
+
+
total: 0 errors, 0 warnings, 1 checks, 93 lines checked
checkpatch next bitarray.h:
>>>>>>>>
WARNING: else is not generally useful after a break or return
#32: FILE: bitarray.h:32:
+ return 0;
+ else
total: 0 errors, 1 warnings, 0 checks, 52 lines checked
checkpatch next bridge_loop_avoidance.c:
>>>>>>>>
CHECK: Please don't use multiple blank lines
#72: FILE: bridge_loop_avoidance.c:72:
+
+
CHECK: Please don't use multiple blank lines
#663: FILE: bridge_loop_avoidance.c:663:
+
+
CHECK: Please don't use multiple blank lines
#849: FILE: bridge_loop_avoidance.c:849:
+
+
CHECK: Please don't use multiple blank lines
#1346: FILE: bridge_loop_avoidance.c:1346:
+
+
CHECK: Please don't use multiple blank lines
#1389: FILE: bridge_loop_avoidance.c:1389:
+
+
CHECK: Please don't use multiple blank lines
#1479: FILE: bridge_loop_avoidance.c:1479:
+
+
total: 0 errors, 0 warnings, 6 checks, 1725 lines checked
checkpatch next debugfs.c:
>>>>>>>>
WARNING: void function return statements are not generally useful
#237: FILE: debugfs.c:237:
+ return;
+}
CHECK: Please use a blank line after function/struct/union/enum declarations
#408: FILE: debugfs.c:408:
+}
+static BATADV_HARDIF_DEBUGINFO(originators, S_IRUGO,
total: 0 errors, 1 warnings, 1 checks, 561 lines checked
checkpatch next distributed-arp-table.c:
>>>>>>>>
WARNING: Prefer kmalloc_array over kmalloc with multiply
#540: FILE: distributed-arp-table.c:540:
+ res = kmalloc(BATADV_DAT_CANDIDATES_NUM * sizeof(*res), GFP_ATOMIC);
CHECK: Please use a blank line after function/struct/union/enum declarations
#1102: FILE: distributed-arp-table.c:1102:
+}
+/**
total: 0 errors, 1 warnings, 1 checks, 1202 lines checked
checkpatch next fragmentation.c:
>>>>>>>>
CHECK: Please don't use multiple blank lines
#26: FILE: fragmentation.c:26:
+
+
total: 0 errors, 0 warnings, 1 checks, 494 lines checked
checkpatch next fragmentation.h:
>>>>>>>>
WARNING: else is not generally useful after a break or return
#44: FILE: fragmentation.h:44:
+ return true;
+ else
total: 0 errors, 1 warnings, 0 checks, 48 lines checked
checkpatch next gateway_client.c:
>>>>>>>>
CHECK: Please use a blank line after function/struct/union/enum declarations
#778: FILE: gateway_client.c:778:
+}
+/**
total: 0 errors, 0 warnings, 1 checks, 879 lines checked
checkpatch next hash.c:
>>>>>>>>
WARNING: Prefer kmalloc_array over kmalloc with multiply
#49: FILE: hash.c:49:
+ hash->table = kmalloc(sizeof(*hash->table) * size, GFP_ATOMIC);
WARNING: Prefer kmalloc_array over kmalloc with multiply
#53: FILE: hash.c:53:
+ hash->list_locks = kmalloc(sizeof(*hash->list_locks) * size,
total: 0 errors, 2 warnings, 0 checks, 76 lines checked
checkpatch next main.c:
>>>>>>>>
CHECK: Please don't use multiple blank lines
#44: FILE: main.c:44:
+
+
total: 0 errors, 0 warnings, 1 checks, 1263 lines checked
checkpatch next multicast.h:
>>>>>>>>
WARNING: void function return statements are not generally useful
#54: FILE: multicast.h:54:
+ return;
+}
WARNING: void function return statements are not generally useful
#71: FILE: multicast.h:71:
+ return;
+}
WARNING: void function return statements are not generally useful
#76: FILE: multicast.h:76:
+ return;
+}
total: 0 errors, 3 warnings, 0 checks, 80 lines checked
checkpatch next network-coding.c:
>>>>>>>>
WARNING: else is not generally useful after a break or return
#1215: FILE: network-coding.c:1215:
+ return false;
+ else
total: 0 errors, 1 warnings, 0 checks, 1937 lines checked
checkpatch next originator.c:
>>>>>>>>
CHECK: Please don't use multiple blank lines
#802: FILE: originator.c:802:
+
+
total: 0 errors, 0 warnings, 1 checks, 1177 lines checked
checkpatch next originator.h:
>>>>>>>>
CHECK: Please don't use multiple blank lines
#73: FILE: originator.h:73:
+
+
total: 0 errors, 0 warnings, 1 checks, 126 lines checked
checkpatch next packet.h:
>>>>>>>>
CHECK: Please use a blank line after function/struct/union/enum declarations
#201: FILE: packet.h:201:
+};
+#pragma pack()
total: 0 errors, 0 warnings, 1 checks, 552 lines checked
checkpatch next routing.c:
>>>>>>>>
CHECK: Please don't use multiple blank lines
#295: FILE: routing.c:295:
+
+
total: 0 errors, 0 warnings, 1 checks, 1085 lines checked
checkpatch next soft-interface.c:
>>>>>>>>
CHECK: Please don't use multiple blank lines
#39: FILE: soft-interface.c:39:
+
+
total: 0 errors, 0 warnings, 1 checks, 1114 lines checked
checkpatch next sysfs.c:
>>>>>>>>
CHECK: Please don't use multiple blank lines
#154: FILE: sysfs.c:154:
+
+
total: 0 errors, 0 warnings, 1 checks, 944 lines checked
checkpatch next translation-table.c:
>>>>>>>>
CHECK: Please don't use multiple blank lines
#1783: FILE: translation-table.c:1783:
+
+
WARNING: else is not generally useful after a break or return
#2772: FILE: translation-table.c:2772:
+ return batadv_send_my_tt_response(bat_priv, tt_data, req_src);
+ else
total: 0 errors, 1 warnings, 1 checks, 3712 lines checked
6 years, 6 months
Build check errors found: 2014-06-27
by postmaster＠open-mesh.org
Name of failed tests
====================
checkpatch master bat_iv_ogm.c
checkpatch master bitarray.c
checkpatch master bitarray.h
checkpatch master bridge_loop_avoidance.c
checkpatch master debugfs.c
checkpatch master distributed-arp-table.c
checkpatch master fragmentation.c
checkpatch master fragmentation.h
checkpatch master gateway_client.c
checkpatch master main.c
checkpatch master multicast.h
checkpatch master network-coding.c
checkpatch master originator.c
checkpatch master originator.h
checkpatch master packet.h
checkpatch master routing.c
checkpatch master soft-interface.c
checkpatch master sysfs.c
checkpatch master translation-table.c
checkpatch next bat_iv_ogm.c
checkpatch next bitarray.c
checkpatch next bitarray.h
checkpatch next bridge_loop_avoidance.c
checkpatch next debugfs.c
checkpatch next distributed-arp-table.c
checkpatch next fragmentation.c
checkpatch next fragmentation.h
checkpatch next gateway_client.c
checkpatch next hash.c
checkpatch next main.c
checkpatch next multicast.h
checkpatch next network-coding.c
checkpatch next originator.c
checkpatch next originator.h
checkpatch next packet.h
checkpatch next routing.c
checkpatch next soft-interface.c
checkpatch next sysfs.c
checkpatch next translation-table.c
Output of different failed tests
================================
checkpatch master bat_iv_ogm.c:
>>>>>>>>
CHECK: Please don't use multiple blank lines
#29: FILE: bat_iv_ogm.c:29:
+
+
CHECK: Unnecessary parentheses around orig_node->bat_iv.bcast_own[word_index]
#882: FILE: bat_iv_ogm.c:882:
+ word = &(orig_node->bat_iv.bcast_own[word_index]);
CHECK: Please don't use multiple blank lines
#1365: FILE: bat_iv_ogm.c:1365:
+
+
CHECK: Unnecessary parentheses around orig_neigh_node->bat_iv.bcast_own[offset]
#1667: FILE: bat_iv_ogm.c:1667:
+ word = &(orig_neigh_node->bat_iv.bcast_own[offset]);
total: 0 errors, 0 warnings, 4 checks, 1980 lines checked
checkpatch master distributed-arp-table.c:
>>>>>>>>
CHECK: Please use a blank line after function/struct/union/enum declarations
#1103: FILE: distributed-arp-table.c:1103:
+}
+/**
total: 0 errors, 0 warnings, 1 checks, 1203 lines checked
checkpatch master fragmentation.c:
>>>>>>>>
CHECK: Please don't use multiple blank lines
#26: FILE: fragmentation.c:26:
+
+
total: 0 errors, 0 warnings, 1 checks, 498 lines checked
checkpatch next bat_iv_ogm.c:
>>>>>>>>
CHECK: Please don't use multiple blank lines
#29: FILE: bat_iv_ogm.c:29:
+
+
WARNING: Prefer kmalloc_array over kmalloc with multiply
#126: FILE: bat_iv_ogm.c:126:
+ data_ptr = kmalloc(max_if_num * sizeof(uint8_t), GFP_ATOMIC);
WARNING: Prefer kmalloc_array over kmalloc with multiply
#186: FILE: bat_iv_ogm.c:186:
+ data_ptr = kmalloc(max_if_num * sizeof(uint8_t), GFP_ATOMIC);
CHECK: Unnecessary parentheses around orig_node->bat_iv.bcast_own[word_index]
#881: FILE: bat_iv_ogm.c:881:
+ word = &(orig_node->bat_iv.bcast_own[word_index]);
CHECK: Please don't use multiple blank lines
#1364: FILE: bat_iv_ogm.c:1364:
+
+
CHECK: Unnecessary parentheses around orig_neigh_node->bat_iv.bcast_own[offset]
#1666: FILE: bat_iv_ogm.c:1666:
+ word = &(orig_neigh_node->bat_iv.bcast_own[offset]);
total: 0 errors, 2 warnings, 4 checks, 1979 lines checked
checkpatch next bitarray.c:
>>>>>>>>
CHECK: Please don't use multiple blank lines
#32: FILE: bitarray.c:32:
+
+
total: 0 errors, 0 warnings, 1 checks, 93 lines checked
checkpatch next bitarray.h:
>>>>>>>>
WARNING: else is not generally useful after a break or return
#32: FILE: bitarray.h:32:
+ return 0;
+ else
total: 0 errors, 1 warnings, 0 checks, 52 lines checked
checkpatch next bridge_loop_avoidance.c:
>>>>>>>>
CHECK: Please don't use multiple blank lines
#72: FILE: bridge_loop_avoidance.c:72:
+
+
CHECK: Please don't use multiple blank lines
#663: FILE: bridge_loop_avoidance.c:663:
+
+
CHECK: Please don't use multiple blank lines
#849: FILE: bridge_loop_avoidance.c:849:
+
+
CHECK: Please don't use multiple blank lines
#1346: FILE: bridge_loop_avoidance.c:1346:
+
+
CHECK: Please don't use multiple blank lines
#1389: FILE: bridge_loop_avoidance.c:1389:
+
+
CHECK: Please don't use multiple blank lines
#1479: FILE: bridge_loop_avoidance.c:1479:
+
+
total: 0 errors, 0 warnings, 6 checks, 1725 lines checked
checkpatch next debugfs.c:
>>>>>>>>
WARNING: void function return statements are not generally useful
#237: FILE: debugfs.c:237:
+ return;
+}
CHECK: Please use a blank line after function/struct/union/enum declarations
#408: FILE: debugfs.c:408:
+}
+static BATADV_HARDIF_DEBUGINFO(originators, S_IRUGO,
total: 0 errors, 1 warnings, 1 checks, 561 lines checked
checkpatch next distributed-arp-table.c:
>>>>>>>>
WARNING: Prefer kmalloc_array over kmalloc with multiply
#540: FILE: distributed-arp-table.c:540:
+ res = kmalloc(BATADV_DAT_CANDIDATES_NUM * sizeof(*res), GFP_ATOMIC);
CHECK: Please use a blank line after function/struct/union/enum declarations
#1102: FILE: distributed-arp-table.c:1102:
+}
+/**
total: 0 errors, 1 warnings, 1 checks, 1202 lines checked
checkpatch next fragmentation.c:
>>>>>>>>
CHECK: Please don't use multiple blank lines
#26: FILE: fragmentation.c:26:
+
+
total: 0 errors, 0 warnings, 1 checks, 494 lines checked
checkpatch next fragmentation.h:
>>>>>>>>
WARNING: else is not generally useful after a break or return
#44: FILE: fragmentation.h:44:
+ return true;
+ else
total: 0 errors, 1 warnings, 0 checks, 48 lines checked
checkpatch next gateway_client.c:
>>>>>>>>
CHECK: Please use a blank line after function/struct/union/enum declarations
#778: FILE: gateway_client.c:778:
+}
+/**
total: 0 errors, 0 warnings, 1 checks, 879 lines checked
checkpatch next hash.c:
>>>>>>>>
WARNING: Prefer kmalloc_array over kmalloc with multiply
#49: FILE: hash.c:49:
+ hash->table = kmalloc(sizeof(*hash->table) * size, GFP_ATOMIC);
WARNING: Prefer kmalloc_array over kmalloc with multiply
#53: FILE: hash.c:53:
+ hash->list_locks = kmalloc(sizeof(*hash->list_locks) * size,
total: 0 errors, 2 warnings, 0 checks, 76 lines checked
checkpatch next main.c:
>>>>>>>>
CHECK: Please don't use multiple blank lines
#44: FILE: main.c:44:
+
+
total: 0 errors, 0 warnings, 1 checks, 1263 lines checked
checkpatch next multicast.h:
>>>>>>>>
WARNING: void function return statements are not generally useful
#54: FILE: multicast.h:54:
+ return;
+}
WARNING: void function return statements are not generally useful
#71: FILE: multicast.h:71:
+ return;
+}
WARNING: void function return statements are not generally useful
#76: FILE: multicast.h:76:
+ return;
+}
total: 0 errors, 3 warnings, 0 checks, 80 lines checked
checkpatch next network-coding.c:
>>>>>>>>
WARNING: else is not generally useful after a break or return
#1215: FILE: network-coding.c:1215:
+ return false;
+ else
total: 0 errors, 1 warnings, 0 checks, 1937 lines checked
checkpatch next originator.c:
>>>>>>>>
CHECK: Please don't use multiple blank lines
#802: FILE: originator.c:802:
+
+
total: 0 errors, 0 warnings, 1 checks, 1177 lines checked
checkpatch next originator.h:
>>>>>>>>
CHECK: Please don't use multiple blank lines
#73: FILE: originator.h:73:
+
+
total: 0 errors, 0 warnings, 1 checks, 126 lines checked
checkpatch next packet.h:
>>>>>>>>
CHECK: Please use a blank line after function/struct/union/enum declarations
#201: FILE: packet.h:201:
+};
+#pragma pack()
total: 0 errors, 0 warnings, 1 checks, 552 lines checked
checkpatch next routing.c:
>>>>>>>>
CHECK: Please don't use multiple blank lines
#295: FILE: routing.c:295:
+
+
total: 0 errors, 0 warnings, 1 checks, 1085 lines checked
checkpatch next soft-interface.c:
>>>>>>>>
CHECK: Please don't use multiple blank lines
#39: FILE: soft-interface.c:39:
+
+
total: 0 errors, 0 warnings, 1 checks, 1114 lines checked
checkpatch next sysfs.c:
>>>>>>>>
CHECK: Please don't use multiple blank lines
#154: FILE: sysfs.c:154:
+
+
total: 0 errors, 0 warnings, 1 checks, 944 lines checked
checkpatch next translation-table.c:
>>>>>>>>
CHECK: Please don't use multiple blank lines
#1783: FILE: translation-table.c:1783:
+
+
WARNING: else is not generally useful after a break or return
#2772: FILE: translation-table.c:2772:
+ return batadv_send_my_tt_response(bat_priv, tt_data, req_src);
+ else
total: 0 errors, 1 warnings, 1 checks, 3712 lines checked
6 years, 6 months
[linux-next] LinuxNextTracking branch, master, updated. next-20140626
by batman＠open-mesh.org
The following commit has been merged in the master branch:
commit b76682f84aa463ebc5979a65a617f15f0da8fa18
Author: Ken Helias <kenhelias(a)firemail.de>
Date: Thu Jun 26 10:42:49 2014 +1000
list: fix order of arguments for hlist_add_after(_rcu)
All other add functions for lists have the new item as first argument and
the position where it is added as second argument. This was changed for
no good reason in this function and makes using it unnecessary confusing.
The name was changed to hlist_add_behind() to cause unconverted code to
generate a compile error instead of using the wrong parameter order.
Signed-off-by: Ken Helias <kenhelias(a)firemail.de>
Cc: "Paul E. McKenney" <paulmck(a)linux.vnet.ibm.com>
Acked-by: Jeff Kirsher <jeffrey.t.kirsher(a)intel.com> [intel driver bits]
Cc: Hugh Dickins <hughd(a)google.com>
Cc: Christoph Hellwig <hch(a)infradead.org>
Signed-off-by: Andrew Morton <akpm(a)linux-foundation.org>
diff --git a/Documentation/RCU/whatisRCU.txt b/Documentation/RCU/whatisRCU.txt
index 49b8551..e48c57f 100644
--- a/Documentation/RCU/whatisRCU.txt
+++ b/Documentation/RCU/whatisRCU.txt
@@ -818,7 +818,7 @@ RCU pointer/list update:
list_add_tail_rcu
list_del_rcu
list_replace_rcu
- hlist_add_after_rcu
+ hlist_add_behind_rcu
hlist_add_before_rcu
hlist_add_head_rcu
hlist_del_rcu
diff --git a/drivers/gpu/drm/drm_hashtab.c b/drivers/gpu/drm/drm_hashtab.c
index 7e4bae7..c3b80fd 100644
--- a/drivers/gpu/drm/drm_hashtab.c
+++ b/drivers/gpu/drm/drm_hashtab.c
@@ -125,7 +125,7 @@ int drm_ht_insert_item(struct drm_open_hash *ht, struct drm_hash_item *item)
parent = &entry->head;
}
if (parent) {
- hlist_add_after_rcu(parent, &item->head);
+ hlist_add_behind_rcu(&item->head, parent);
} else {
hlist_add_head_rcu(&item->head, h_list);
}
diff --git a/drivers/net/ethernet/intel/i40e/i40e_ethtool.c b/drivers/net/ethernet/intel/i40e/i40e_ethtool.c
index 4a488ff..c57b085 100644
--- a/drivers/net/ethernet/intel/i40e/i40e_ethtool.c
+++ b/drivers/net/ethernet/intel/i40e/i40e_ethtool.c
@@ -1498,7 +1498,7 @@ static int i40e_update_ethtool_fdir_entry(struct i40e_vsi *vsi,
/* add filter to the list */
if (parent)
- hlist_add_after(&parent->fdir_node, &input->fdir_node);
+ hlist_add_behind(&input->fdir_node, &parent->fdir_node);
else
hlist_add_head(&input->fdir_node,
&pf->fdir_filter_list);
diff --git a/drivers/net/ethernet/intel/ixgbe/ixgbe_ethtool.c b/drivers/net/ethernet/intel/ixgbe/ixgbe_ethtool.c
index a452730..a6e5bcc 100644
--- a/drivers/net/ethernet/intel/ixgbe/ixgbe_ethtool.c
+++ b/drivers/net/ethernet/intel/ixgbe/ixgbe_ethtool.c
@@ -2518,7 +2518,7 @@ static int ixgbe_update_ethtool_fdir_entry(struct ixgbe_adapter *adapter,
/* add filter to the list */
if (parent)
- hlist_add_after(&parent->fdir_node, &input->fdir_node);
+ hlist_add_behind(&input->fdir_node, &parent->fdir_node);
else
hlist_add_head(&input->fdir_node,
&adapter->fdir_filter_list);
diff --git a/drivers/staging/lustre/lustre/libcfs/hash.c b/drivers/staging/lustre/lustre/libcfs/hash.c
index 6d2b455..6db7391 100644
--- a/drivers/staging/lustre/lustre/libcfs/hash.c
+++ b/drivers/staging/lustre/lustre/libcfs/hash.c
@@ -351,7 +351,7 @@ cfs_hash_dh_hnode_add(struct cfs_hash *hs, struct cfs_hash_bd *bd,
cfs_hash_dhead_t, dh_head);
if (dh->dh_tail != NULL) /* not empty */
- hlist_add_after(dh->dh_tail, hnode);
+ hlist_add_behind(hnode, dh->dh_tail);
else /* empty list */
hlist_add_head(hnode, &dh->dh_head);
dh->dh_tail = hnode;
@@ -406,7 +406,7 @@ cfs_hash_dd_hnode_add(struct cfs_hash *hs, struct cfs_hash_bd *bd,
cfs_hash_dhead_dep_t, dd_head);
if (dh->dd_tail != NULL) /* not empty */
- hlist_add_after(dh->dd_tail, hnode);
+ hlist_add_behind(hnode, dh->dd_tail);
else /* empty list */
hlist_add_head(hnode, &dh->dd_head);
dh->dd_tail = hnode;
diff --git a/fs/namespace.c b/fs/namespace.c
index 182bc41..2a1447c 100644
--- a/fs/namespace.c
+++ b/fs/namespace.c
@@ -798,7 +798,7 @@ static void commit_tree(struct mount *mnt, struct mount *shadows)
list_splice(&head, n->list.prev);
if (shadows)
- hlist_add_after_rcu(&shadows->mnt_hash, &mnt->mnt_hash);
+ hlist_add_behind_rcu(&mnt->mnt_hash, &shadows->mnt_hash);
else
hlist_add_head_rcu(&mnt->mnt_hash,
m_hash(&parent->mnt, mnt->mnt_mountpoint));
diff --git a/fs/notify/inode_mark.c b/fs/notify/inode_mark.c
index 74825be..9ce0622 100644
--- a/fs/notify/inode_mark.c
+++ b/fs/notify/inode_mark.c
@@ -232,7 +232,7 @@ int fsnotify_add_inode_mark(struct fsnotify_mark *mark,
BUG_ON(last == NULL);
/* mark should be the last entry. last is the current last entry */
- hlist_add_after_rcu(&last->i.i_list, &mark->i.i_list);
+ hlist_add_behind_rcu(&mark->i.i_list, &last->i.i_list);
out:
fsnotify_recalc_inode_mask_locked(inode);
spin_unlock(&inode->i_lock);
diff --git a/fs/notify/vfsmount_mark.c b/fs/notify/vfsmount_mark.c
index 68ca5a8..ac851e8 100644
--- a/fs/notify/vfsmount_mark.c
+++ b/fs/notify/vfsmount_mark.c
@@ -191,7 +191,7 @@ int fsnotify_add_vfsmount_mark(struct fsnotify_mark *mark,
BUG_ON(last == NULL);
/* mark should be the last entry. last is the current last entry */
- hlist_add_after_rcu(&last->m.m_list, &mark->m.m_list);
+ hlist_add_behind_rcu(&mark->m.m_list, &last->m.m_list);
out:
fsnotify_recalc_vfsmount_mask_locked(mnt);
spin_unlock(&mnt->mnt_root->d_lock);
diff --git a/include/linux/list.h b/include/linux/list.h
index 624ec7f..cbbb96f 100644
--- a/include/linux/list.h
+++ b/include/linux/list.h
@@ -654,8 +654,8 @@ static inline void hlist_add_before(struct hlist_node *n,
*(n->pprev) = n;
}
-static inline void hlist_add_after(struct hlist_node *prev,
- struct hlist_node *n)
+static inline void hlist_add_behind(struct hlist_node *n,
+ struct hlist_node *prev)
{
n->next = prev->next;
prev->next = n;
diff --git a/include/linux/rculist.h b/include/linux/rculist.h
index 8183b46..81c004d 100644
--- a/include/linux/rculist.h
+++ b/include/linux/rculist.h
@@ -432,9 +432,9 @@ static inline void hlist_add_before_rcu(struct hlist_node *n,
}
/**
- * hlist_add_after_rcu
- * @prev: the existing element to add the new element after.
+ * hlist_add_behind_rcu
* @n: the new element to add to the hash list.
+ * @prev: the existing element to add the new element after.
*
* Description:
* Adds the specified element to the specified hlist
@@ -449,8 +449,8 @@ static inline void hlist_add_before_rcu(struct hlist_node *n,
* hlist_for_each_entry_rcu(), used to prevent memory-consistency
* problems on Alpha CPUs.
*/
-static inline void hlist_add_after_rcu(struct hlist_node *prev,
- struct hlist_node *n)
+static inline void hlist_add_behind_rcu(struct hlist_node *n,
+ struct hlist_node *prev)
{
n->next = prev->next;
n->pprev = &prev->next;
diff --git a/net/batman-adv/fragmentation.c b/net/batman-adv/fragmentation.c
index f14e54a..16dd409 100644
--- a/net/batman-adv/fragmentation.c
+++ b/net/batman-adv/fragmentation.c
@@ -184,7 +184,7 @@ static bool batadv_frag_insert_packet(struct batadv_orig_node *orig_node,
/* Reached the end of the list, so insert after 'frag_entry_curr'. */
if (likely(frag_entry_curr)) {
- hlist_add_after(&frag_entry_curr->list, &frag_entry_new->list);
+ hlist_add_behind(&frag_entry_new->list, &frag_entry_curr->list);
chain->size += skb->len - hdr_size;
chain->timestamp = jiffies;
ret = true;
diff --git a/net/bridge/br_multicast.c b/net/bridge/br_multicast.c
index abfa0b65..d9c4f57 100644
--- a/net/bridge/br_multicast.c
+++ b/net/bridge/br_multicast.c
@@ -1174,7 +1174,7 @@ static void br_multicast_add_router(struct net_bridge *br,
}
if (slot)
- hlist_add_after_rcu(slot, &port->rlist);
+ hlist_add_behind_rcu(&port->rlist, slot);
else
hlist_add_head_rcu(&port->rlist, &br->router_list);
}
diff --git a/net/ipv4/fib_trie.c b/net/ipv4/fib_trie.c
index 5afeb5a..e9cb258 100644
--- a/net/ipv4/fib_trie.c
+++ b/net/ipv4/fib_trie.c
@@ -940,7 +940,7 @@ static void insert_leaf_info(struct hlist_head *head, struct leaf_info *new)
last = li;
}
if (last)
- hlist_add_after_rcu(&last->hlist, &new->hlist);
+ hlist_add_behind_rcu(&new->hlist, &last->hlist);
else
hlist_add_before_rcu(&new->hlist, &li->hlist);
}
diff --git a/net/ipv6/addrlabel.c b/net/ipv6/addrlabel.c
index 731e1e1..fd0dc47 100644
--- a/net/ipv6/addrlabel.c
+++ b/net/ipv6/addrlabel.c
@@ -277,7 +277,7 @@ static int __ip6addrlbl_add(struct ip6addrlbl_entry *newp, int replace)
last = p;
}
if (last)
- hlist_add_after_rcu(&last->list, &newp->list);
+ hlist_add_behind_rcu(&newp->list, &last->list);
else
hlist_add_head_rcu(&newp->list, &ip6addrlbl_table.head);
out:
diff --git a/net/xfrm/xfrm_policy.c b/net/xfrm/xfrm_policy.c
index a8ef510..92cb08d 100644
--- a/net/xfrm/xfrm_policy.c
+++ b/net/xfrm/xfrm_policy.c
@@ -389,7 +389,7 @@ redo:
if (h != h0)
continue;
hlist_del(&pol->bydst);
- hlist_add_after(entry0, &pol->bydst);
+ hlist_add_behind(&pol->bydst, entry0);
}
entry0 = &pol->bydst;
}
@@ -654,7 +654,7 @@ int xfrm_policy_insert(int dir, struct xfrm_policy *policy, int excl)
break;
}
if (newpos)
- hlist_add_after(newpos, &policy->bydst);
+ hlist_add_behind(&policy->bydst, newpos);
else
hlist_add_head(&policy->bydst, chain);
xfrm_pol_hold(policy);
--
LinuxNextTracking
6 years, 6 months
Build check errors found: 2014-06-26
by postmaster＠open-mesh.org
Name of failed tests
====================
checkpatch master bitarray.h
checkpatch master debugfs.c
checkpatch master fragmentation.h
checkpatch master multicast.h
checkpatch master network-coding.c
checkpatch master translation-table.c
checkpatch next bat_iv_ogm.c
checkpatch next bitarray.h
checkpatch next debugfs.c
checkpatch next distributed-arp-table.c
checkpatch next fragmentation.h
checkpatch next hash.c
checkpatch next multicast.h
checkpatch next network-coding.c
checkpatch next translation-table.c
Output of different failed tests
================================
checkpatch next bat_iv_ogm.c:
>>>>>>>>
WARNING: Prefer kmalloc_array over kmalloc with multiply
#126: FILE: bat_iv_ogm.c:126:
+ data_ptr = kmalloc(max_if_num * sizeof(uint8_t), GFP_ATOMIC);
WARNING: Prefer kmalloc_array over kmalloc with multiply
#186: FILE: bat_iv_ogm.c:186:
+ data_ptr = kmalloc(max_if_num * sizeof(uint8_t), GFP_ATOMIC);
total: 0 errors, 2 warnings, 0 checks, 1979 lines checked
checkpatch next bitarray.h:
>>>>>>>>
WARNING: else is not generally useful after a break or return
#32: FILE: bitarray.h:32:
+ return 0;
+ else
total: 0 errors, 1 warnings, 0 checks, 52 lines checked
checkpatch next debugfs.c:
>>>>>>>>
WARNING: void function return statements are not generally useful
#237: FILE: debugfs.c:237:
+ return;
+}
total: 0 errors, 1 warnings, 0 checks, 561 lines checked
checkpatch next distributed-arp-table.c:
>>>>>>>>
WARNING: Prefer kmalloc_array over kmalloc with multiply
#540: FILE: distributed-arp-table.c:540:
+ res = kmalloc(BATADV_DAT_CANDIDATES_NUM * sizeof(*res), GFP_ATOMIC);
total: 0 errors, 1 warnings, 0 checks, 1202 lines checked
checkpatch next fragmentation.h:
>>>>>>>>
WARNING: else is not generally useful after a break or return
#44: FILE: fragmentation.h:44:
+ return true;
+ else
total: 0 errors, 1 warnings, 0 checks, 48 lines checked
checkpatch next hash.c:
>>>>>>>>
WARNING: Prefer kmalloc_array over kmalloc with multiply
#49: FILE: hash.c:49:
+ hash->table = kmalloc(sizeof(*hash->table) * size, GFP_ATOMIC);
WARNING: Prefer kmalloc_array over kmalloc with multiply
#53: FILE: hash.c:53:
+ hash->list_locks = kmalloc(sizeof(*hash->list_locks) * size,
total: 0 errors, 2 warnings, 0 checks, 76 lines checked
checkpatch next multicast.h:
>>>>>>>>
WARNING: void function return statements are not generally useful
#54: FILE: multicast.h:54:
+ return;
+}
WARNING: void function return statements are not generally useful
#71: FILE: multicast.h:71:
+ return;
+}
WARNING: void function return statements are not generally useful
#76: FILE: multicast.h:76:
+ return;
+}
total: 0 errors, 3 warnings, 0 checks, 80 lines checked
checkpatch next network-coding.c:
>>>>>>>>
WARNING: else is not generally useful after a break or return
#1215: FILE: network-coding.c:1215:
+ return false;
+ else
total: 0 errors, 1 warnings, 0 checks, 1937 lines checked
checkpatch next translation-table.c:
>>>>>>>>
WARNING: else is not generally useful after a break or return
#2772: FILE: translation-table.c:2772:
+ return batadv_send_my_tt_response(bat_priv, tt_data, req_src);
+ else
total: 0 errors, 1 warnings, 0 checks, 3712 lines checked
6 years, 6 months
Build check errors found: 2014-06-25
by postmaster＠open-mesh.org
Name of failed tests
====================
checkpatch master bitarray.h
checkpatch master debugfs.c
checkpatch master fragmentation.h
checkpatch master multicast.h
checkpatch master network-coding.c
checkpatch master translation-table.c
checkpatch next bat_iv_ogm.c
checkpatch next bitarray.h
checkpatch next debugfs.c
checkpatch next distributed-arp-table.c
checkpatch next fragmentation.h
checkpatch next hash.c
checkpatch next multicast.h
checkpatch next network-coding.c
checkpatch next translation-table.c
Output of different failed tests
================================
checkpatch next bat_iv_ogm.c:
>>>>>>>>
WARNING: Prefer kmalloc_array over kmalloc with multiply
#126: FILE: bat_iv_ogm.c:126:
+ data_ptr = kmalloc(max_if_num * sizeof(uint8_t), GFP_ATOMIC);
WARNING: Prefer kmalloc_array over kmalloc with multiply
#186: FILE: bat_iv_ogm.c:186:
+ data_ptr = kmalloc(max_if_num * sizeof(uint8_t), GFP_ATOMIC);
total: 0 errors, 2 warnings, 0 checks, 1979 lines checked
checkpatch next bitarray.h:
>>>>>>>>
WARNING: else is not generally useful after a break or return
#32: FILE: bitarray.h:32:
+ return 0;
+ else
total: 0 errors, 1 warnings, 0 checks, 52 lines checked
checkpatch next debugfs.c:
>>>>>>>>
WARNING: void function return statements are not generally useful
#237: FILE: debugfs.c:237:
+ return;
+}
total: 0 errors, 1 warnings, 0 checks, 561 lines checked
checkpatch next distributed-arp-table.c:
>>>>>>>>
WARNING: Prefer kmalloc_array over kmalloc with multiply
#540: FILE: distributed-arp-table.c:540:
+ res = kmalloc(BATADV_DAT_CANDIDATES_NUM * sizeof(*res), GFP_ATOMIC);
total: 0 errors, 1 warnings, 0 checks, 1202 lines checked
checkpatch next fragmentation.h:
>>>>>>>>
WARNING: else is not generally useful after a break or return
#44: FILE: fragmentation.h:44:
+ return true;
+ else
total: 0 errors, 1 warnings, 0 checks, 48 lines checked
checkpatch next hash.c:
>>>>>>>>
WARNING: Prefer kmalloc_array over kmalloc with multiply
#49: FILE: hash.c:49:
+ hash->table = kmalloc(sizeof(*hash->table) * size, GFP_ATOMIC);
WARNING: Prefer kmalloc_array over kmalloc with multiply
#53: FILE: hash.c:53:
+ hash->list_locks = kmalloc(sizeof(*hash->list_locks) * size,
total: 0 errors, 2 warnings, 0 checks, 76 lines checked
checkpatch next multicast.h:
>>>>>>>>
WARNING: void function return statements are not generally useful
#54: FILE: multicast.h:54:
+ return;
+}
WARNING: void function return statements are not generally useful
#71: FILE: multicast.h:71:
+ return;
+}
WARNING: void function return statements are not generally useful
#76: FILE: multicast.h:76:
+ return;
+}
total: 0 errors, 3 warnings, 0 checks, 80 lines checked
checkpatch next network-coding.c:
>>>>>>>>
WARNING: else is not generally useful after a break or return
#1215: FILE: network-coding.c:1215:
+ return false;
+ else
total: 0 errors, 1 warnings, 0 checks, 1937 lines checked
checkpatch next translation-table.c:
>>>>>>>>
WARNING: else is not generally useful after a break or return
#2772: FILE: translation-table.c:2772:
+ return batadv_send_my_tt_response(bat_priv, tt_data, req_src);
+ else
total: 0 errors, 1 warnings, 0 checks, 3712 lines checked
6 years, 6 months
