CHECK: Coalesced strings are easier to grep and less error prone
#87: FILE: routing.c:87:
+ "Changing route towards: %pM "
+ "(now via %pM - was via %pM)\n",
CHECK: braces {} should be used on all arms of this statement
#234: FILE: routing.c:234:
+ if (has_timed_out(*last_reset, RESET_PROTECTION_MS)) {
[...]
+ } else
[...]
CHECK: Coalesced strings are easier to grep and less error prone
#349: FILE: routing.c:349:
+ pr_debug("Warning - can't forward icmp packet from %pM to "
+ "%pM: ttl exceeded\n", icmp_packet->orig,
CHECK: Coalesced strings are easier to grep and less error prone
#678: FILE: routing.c:678:
+ bat_dbg(DBG_TT, bat_priv, "Received ROAMING_ADV from %pM "
+ "(client %pM)\n", roam_adv_packet->src,
CHECK: Coalesced strings are easier to grep and less error prone
#817: FILE: routing.c:817:
+ pr_debug("Warning - can't forward unicast packet from %pM to "
+ "%pM: ttl exceeded\n", ethhdr->h_source,
CHECK: Coalesced strings are easier to grep and less error prone
#938: FILE: routing.c:938:
+ bat_dbg(DBG_ROUTES, bat_priv, "TTVN mismatch (old_ttvn %u "
+ "new_ttvn %u)! Rerouting unicast packet (for %pM) to "
CHECK: Coalesced strings are easier to grep and less error prone
#939: FILE: routing.c:939:
+ "new_ttvn %u)! Rerouting unicast packet (for %pM) to "
+ "%pM\n", unicast_packet->ttvn, curr_ttvn,
total: 0 errors, 0 warnings, 7 checks, 1132 lines checked
NOTE: Ignored message types: COMPLEX_MACRO
routing.c has style problems, please review.
If any of these errors are false positives, please report
them to the maintainer, see CHECKPATCH in MAINTAINERS.
Show replies by date