linux-merge January 2013

linux-merge@lists.open-mesh.org

2 participants
66 discussions

Build check errors found: 2013-01-12

by postmaster＠open-mesh.org

Name of failed tests ==================== checkpatch master bridge_loop_avoidance.c checkpatch master icmp_socket.c checkpatch master soft-interface.c checkpatch master vis.c checkpatch next bat_iv_ogm.c checkpatch next bridge_loop_avoidance.c checkpatch next debugfs.c checkpatch next icmp_socket.c checkpatch next originator.c checkpatch next routing.c checkpatch next send.c checkpatch next soft-interface.c checkpatch next translation-table.c checkpatch next unicast.c checkpatch next vis.c Output of different failed tests ================================ checkpatch master bridge_loop_avoidance.c: >>>>>>>> WARNING: Avoid CamelCase: <vhdr->h_vlan_TCI> #874: FILE: bridge_loop_avoidance.c:874: + vid = ntohs(vhdr->h_vlan_TCI) & VLAN_VID_MASK; total: 0 errors, 1 warnings, 0 checks, 1699 lines checked checkpatch master soft-interface.c: >>>>>>>> Use of uninitialized value $ms_size in pattern match (m//) at /home/batman/build_test/linux-next/scripts/checkpatch.pl line 3383. Use of uninitialized value $ms_size in pattern match (m//) at /home/batman/build_test/linux-next/scripts/checkpatch.pl line 3386. Use of uninitialized value $ms_size in pattern match (m//) at /home/batman/build_test/linux-next/scripts/checkpatch.pl line 3383. Use of uninitialized value $ms_size in pattern match (m//) at /home/batman/build_test/linux-next/scripts/checkpatch.pl line 3386. Use of uninitialized value $ms_size in pattern match (m//) at /home/batman/build_test/linux-next/scripts/checkpatch.pl line 3383. Use of uninitialized value $ms_size in pattern match (m//) at /home/batman/build_test/linux-next/scripts/checkpatch.pl line 3386. WARNING: Avoid CamelCase: <vhdr->h_vlan_TCI> #169: FILE: soft-interface.c:169: + vid = ntohs(vhdr->h_vlan_TCI) & VLAN_VID_MASK; total: 0 errors, 1 warnings, 0 checks, 666 lines checked checkpatch next bat_iv_ogm.c: >>>>>>>> CHECK: Blank lines aren't necessary after an open brace '{' #186: FILE: bat_iv_ogm.c:186: + batadv_ogm_packet->tt_num_changes)) { + CHECK: Blank lines aren't necessary after an open brace '{' #264: FILE: bat_iv_ogm.c:264: + (forw_packet->own && (forw_packet->if_incoming != primary_if))) { + CHECK: Blank lines aren't necessary after an open brace '{' #328: FILE: bat_iv_ogm.c:328: + (aggregated_bytes <= BATADV_MAX_AGGREGATION_BYTES)) { + CHECK: Blank lines aren't necessary after an open brace '{' #818: FILE: bat_iv_ogm.c:818: + &orig_neigh_node->neigh_list, list) { + CHECK: Blank lines aren't necessary after an open brace '{' #952: FILE: bat_iv_ogm.c:952: + &orig_node->neigh_list, list) { + CHECK: Blank lines aren't necessary after an open brace '{' #1226: FILE: bat_iv_ogm.c:1226: + if (is_single_hop_neigh) { + total: 0 errors, 0 warnings, 6 checks, 1349 lines checked checkpatch next bridge_loop_avoidance.c: >>>>>>>> CHECK: Blank lines aren't necessary after an open brace '{' #238: FILE: bridge_loop_avoidance.c:238: + head, hash_entry) { + CHECK: Blank lines aren't necessary before a close brace '}' #342: FILE: bridge_loop_avoidance.c:342: + + } CHECK: Blank lines aren't necessary before a close brace '}' #543: FILE: bridge_loop_avoidance.c:543: + +} CHECK: Blank lines aren't necessary before a close brace '}' #602: FILE: bridge_loop_avoidance.c:602: + + } WARNING: Avoid CamelCase: <vhdr->h_vlan_TCI> #875: FILE: bridge_loop_avoidance.c:875: + vid = ntohs(vhdr->h_vlan_TCI) & VLAN_VID_MASK; total: 0 errors, 1 warnings, 4 checks, 1706 lines checked checkpatch next debugfs.c: >>>>>>>> CHECK: Blank lines aren't necessary before a close brace '}' #168: FILE: debugfs.c:168: + + } WARNING: debugfs_remove_recursive(NULL) is safe this check is probably not required #401: FILE: debugfs.c:401: + if (batadv_debugfs) { + debugfs_remove_recursive(batadv_debugfs); total: 0 errors, 1 warnings, 1 checks, 459 lines checked checkpatch next icmp_socket.c: >>>>>>>> Use of uninitialized value $ms_size in pattern match (m//) at /home/batman/build_test/linux-next/scripts/checkpatch.pl line 3383. Use of uninitialized value $ms_size in pattern match (m//) at /home/batman/build_test/linux-next/scripts/checkpatch.pl line 3386. Use of uninitialized value $ms_size in pattern match (m//) at /home/batman/build_test/linux-next/scripts/checkpatch.pl line 3383. Use of uninitialized value $ms_size in pattern match (m//) at /home/batman/build_test/linux-next/scripts/checkpatch.pl line 3386. Use of uninitialized value $ms_size in pattern match (m//) at /home/batman/build_test/linux-next/scripts/checkpatch.pl line 3383. Use of uninitialized value $ms_size in pattern match (m//) at /home/batman/build_test/linux-next/scripts/checkpatch.pl line 3386. checkpatch next originator.c: >>>>>>>> CHECK: Blank lines aren't necessary after an open brace '{' #181: FILE: originator.c:181: + head, hash_entry) { + CHECK: Blank lines aren't necessary after an open brace '{' #288: FILE: originator.c:288: + &orig_node->neigh_list, list) { + CHECK: Blank lines aren't necessary after an open brace '{' #296: FILE: originator.c:296: + (if_incoming->if_status == BATADV_IF_TO_BE_REMOVED)) { + total: 0 errors, 0 warnings, 3 checks, 645 lines checked checkpatch next routing.c: >>>>>>>> CHECK: Blank lines aren't necessary after an open brace '{' #83: FILE: routing.c:83: + } else if ((!curr_router) && (neigh_node)) { + CHECK: Blank lines aren't necessary after an open brace '{' #175: FILE: routing.c:175: + &orig_node->neigh_list, list) { + CHECK: Blank lines aren't necessary after an open brace '{' #839: FILE: routing.c:839: + neigh_node->if_incoming->net_dev->mtu)) { + CHECK: Blank lines aren't necessary after an open brace '{' #1106: FILE: routing.c:1106: + if (batadv_is_my_mac(unicast_packet->dest)) { + total: 0 errors, 0 warnings, 4 checks, 1281 lines checked checkpatch next send.c: >>>>>>>> CHECK: Blank lines aren't necessary after an open brace '{' #333: FILE: send.c:333: + &bat_priv->forw_bcast_list, list) { + CHECK: Blank lines aren't necessary after an open brace '{' #360: FILE: send.c:360: + &bat_priv->forw_bat_list, list) { + total: 0 errors, 0 warnings, 2 checks, 382 lines checked checkpatch next soft-interface.c: >>>>>>>> Use of uninitialized value $ms_size in pattern match (m//) at /home/batman/build_test/linux-next/scripts/checkpatch.pl line 3383. Use of uninitialized value $ms_size in pattern match (m//) at /home/batman/build_test/linux-next/scripts/checkpatch.pl line 3386. Use of uninitialized value $ms_size in pattern match (m//) at /home/batman/build_test/linux-next/scripts/checkpatch.pl line 3383. Use of uninitialized value $ms_size in pattern match (m//) at /home/batman/build_test/linux-next/scripts/checkpatch.pl line 3386. Use of uninitialized value $ms_size in pattern match (m//) at /home/batman/build_test/linux-next/scripts/checkpatch.pl line 3383. Use of uninitialized value $ms_size in pattern match (m//) at /home/batman/build_test/linux-next/scripts/checkpatch.pl line 3386. WARNING: Avoid CamelCase: <vhdr->h_vlan_TCI> #170: FILE: soft-interface.c:170: + vid = ntohs(vhdr->h_vlan_TCI) & VLAN_VID_MASK; total: 0 errors, 1 warnings, 0 checks, 662 lines checked checkpatch next translation-table.c: >>>>>>>> CHECK: Blank lines aren't necessary before a close brace '}' #116: FILE: translation-table.c:116: + +} CHECK: Blank lines aren't necessary before a close brace '}' #253: FILE: translation-table.c:253: + +} CHECK: Blank lines aren't necessary before a close brace '}' #631: FILE: translation-table.c:631: + +} CHECK: Blank lines aren't necessary before a close brace '}' #1053: FILE: translation-table.c:1053: + +} CHECK: Blank lines aren't necessary before a close brace '}' #1829: FILE: translation-table.c:1829: + +} CHECK: Blank lines aren't necessary before a close brace '}' #2356: FILE: translation-table.c:2356: + +} CHECK: Blank lines aren't necessary before a close brace '}' #2553: FILE: translation-table.c:2553: + +} total: 0 errors, 0 warnings, 7 checks, 2579 lines checked checkpatch next unicast.c: >>>>>>>> CHECK: Blank lines aren't necessary after an open brace '{' #136: FILE: unicast.c:136: + list_for_each_entry(tfp, head, list) { + CHECK: Blank lines aren't necessary after an open brace '{' #165: FILE: unicast.c:165: + if (!list_empty(head)) { + total: 0 errors, 0 warnings, 2 checks, 480 lines checked checkpatch next vis.c: >>>>>>>> Use of uninitialized value $ms_size in pattern match (m//) at /home/batman/build_test/linux-next/scripts/checkpatch.pl line 3383. Use of uninitialized value $ms_size in pattern match (m//) at /home/batman/build_test/linux-next/scripts/checkpatch.pl line 3386. Use of uninitialized value $ms_size in pattern match (m//) at /home/batman/build_test/linux-next/scripts/checkpatch.pl line 3383. Use of uninitialized value $ms_size in pattern match (m//) at /home/batman/build_test/linux-next/scripts/checkpatch.pl line 3386. Use of uninitialized value $ms_size in pattern match (m//) at /home/batman/build_test/linux-next/scripts/checkpatch.pl line 3383. Use of uninitialized value $ms_size in pattern match (m//) at /home/batman/build_test/linux-next/scripts/checkpatch.pl line 3386. Use of uninitialized value $ms_size in pattern match (m//) at /home/batman/build_test/linux-next/scripts/checkpatch.pl line 3383. Use of uninitialized value $ms_size in pattern match (m//) at /home/batman/build_test/linux-next/scripts/checkpatch.pl line 3386. Use of uninitialized value $ms_size in pattern match (m//) at /home/batman/build_test/linux-next/scripts/checkpatch.pl line 3383. Use of uninitialized value $ms_size in pattern match (m//) at /home/batman/build_test/linux-next/scripts/checkpatch.pl line 3386. Use of uninitialized value $ms_size in pattern match (m//) at /home/batman/build_test/linux-next/scripts/checkpatch.pl line 3383. Use of uninitialized value $ms_size in pattern match (m//) at /home/batman/build_test/linux-next/scripts/checkpatch.pl line 3386. Use of uninitialized value $ms_size in pattern match (m//) at /home/batman/build_test/linux-next/scripts/checkpatch.pl line 3383. Use of uninitialized value $ms_size in pattern match (m//) at /home/batman/build_test/linux-next/scripts/checkpatch.pl line 3386. Use of uninitialized value $ms_size in pattern match (m//) at /home/batman/build_test/linux-next/scripts/checkpatch.pl line 3383. Use of uninitialized value $ms_size in pattern match (m//) at /home/batman/build_test/linux-next/scripts/checkpatch.pl line 3386. Use of uninitialized value $ms_size in pattern match (m//) at /home/batman/build_test/linux-next/scripts/checkpatch.pl line 3383. Use of uninitialized value $ms_size in pattern match (m//) at /home/batman/build_test/linux-next/scripts/checkpatch.pl line 3386. Use of uninitialized value $ms_size in pattern match (m//) at /home/batman/build_test/linux-next/scripts/checkpatch.pl line 3383. Use of uninitialized value $ms_size in pattern match (m//) at /home/batman/build_test/linux-next/scripts/checkpatch.pl line 3386.

10 years, 2 months

Build check errors found: 2013-01-11

by postmaster＠open-mesh.org

10 years, 2 months

Build check errors found: 2013-01-10

by postmaster＠open-mesh.org

10 years, 2 months

Build check errors found: 2013-01-09

by postmaster＠open-mesh.org

Name of failed tests ==================== checkpatch master bridge_loop_avoidance.c checkpatch master icmp_socket.c checkpatch master soft-interface.c checkpatch master vis.c checkpatch next bat_iv_ogm.c checkpatch next bridge_loop_avoidance.c checkpatch next debugfs.c checkpatch next icmp_socket.c checkpatch next originator.c checkpatch next routing.c checkpatch next send.c checkpatch next soft-interface.c checkpatch next translation-table.c checkpatch next unicast.c checkpatch next vis.c Output of different failed tests ================================ checkpatch master bridge_loop_avoidance.c: >>>>>>>> WARNING: Avoid CamelCase: <vhdr->h_vlan_TCI> #874: FILE: bridge_loop_avoidance.c:874: + vid = ntohs(vhdr->h_vlan_TCI) & VLAN_VID_MASK; total: 0 errors, 1 warnings, 0 checks, 1699 lines checked checkpatch master soft-interface.c: >>>>>>>> Use of uninitialized value $ms_size in pattern match (m//) at /home/batman/build_test/linux-next/scripts/checkpatch.pl line 3383. Use of uninitialized value $ms_size in pattern match (m//) at /home/batman/build_test/linux-next/scripts/checkpatch.pl line 3386. Use of uninitialized value $ms_size in pattern match (m//) at /home/batman/build_test/linux-next/scripts/checkpatch.pl line 3383. Use of uninitialized value $ms_size in pattern match (m//) at /home/batman/build_test/linux-next/scripts/checkpatch.pl line 3386. Use of uninitialized value $ms_size in pattern match (m//) at /home/batman/build_test/linux-next/scripts/checkpatch.pl line 3383. Use of uninitialized value $ms_size in pattern match (m//) at /home/batman/build_test/linux-next/scripts/checkpatch.pl line 3386. WARNING: Avoid CamelCase: <vhdr->h_vlan_TCI> #170: FILE: soft-interface.c:170: + vid = ntohs(vhdr->h_vlan_TCI) & VLAN_VID_MASK; total: 0 errors, 1 warnings, 0 checks, 667 lines checked checkpatch next bat_iv_ogm.c: >>>>>>>> CHECK: Blank lines aren't necessary after an open brace '{' #186: FILE: bat_iv_ogm.c:186: + batadv_ogm_packet->tt_num_changes)) { + CHECK: Blank lines aren't necessary after an open brace '{' #264: FILE: bat_iv_ogm.c:264: + (forw_packet->own && (forw_packet->if_incoming != primary_if))) { + CHECK: Blank lines aren't necessary after an open brace '{' #328: FILE: bat_iv_ogm.c:328: + (aggregated_bytes <= BATADV_MAX_AGGREGATION_BYTES)) { + CHECK: Blank lines aren't necessary after an open brace '{' #818: FILE: bat_iv_ogm.c:818: + &orig_neigh_node->neigh_list, list) { + CHECK: Blank lines aren't necessary after an open brace '{' #952: FILE: bat_iv_ogm.c:952: + &orig_node->neigh_list, list) { + CHECK: Blank lines aren't necessary after an open brace '{' #1226: FILE: bat_iv_ogm.c:1226: + if (is_single_hop_neigh) { + total: 0 errors, 0 warnings, 6 checks, 1349 lines checked checkpatch next bridge_loop_avoidance.c: >>>>>>>> CHECK: Blank lines aren't necessary after an open brace '{' #238: FILE: bridge_loop_avoidance.c:238: + head, hash_entry) { + CHECK: Blank lines aren't necessary before a close brace '}' #342: FILE: bridge_loop_avoidance.c:342: + + } CHECK: Blank lines aren't necessary before a close brace '}' #543: FILE: bridge_loop_avoidance.c:543: + +} CHECK: Blank lines aren't necessary before a close brace '}' #602: FILE: bridge_loop_avoidance.c:602: + + } WARNING: Avoid CamelCase: <vhdr->h_vlan_TCI> #875: FILE: bridge_loop_avoidance.c:875: + vid = ntohs(vhdr->h_vlan_TCI) & VLAN_VID_MASK; total: 0 errors, 1 warnings, 4 checks, 1706 lines checked checkpatch next debugfs.c: >>>>>>>> CHECK: Blank lines aren't necessary before a close brace '}' #168: FILE: debugfs.c:168: + + } WARNING: debugfs_remove_recursive(NULL) is safe this check is probably not required #401: FILE: debugfs.c:401: + if (batadv_debugfs) { + debugfs_remove_recursive(batadv_debugfs); total: 0 errors, 1 warnings, 1 checks, 459 lines checked checkpatch next icmp_socket.c: >>>>>>>> Use of uninitialized value $ms_size in pattern match (m//) at /home/batman/build_test/linux-next/scripts/checkpatch.pl line 3383. Use of uninitialized value $ms_size in pattern match (m//) at /home/batman/build_test/linux-next/scripts/checkpatch.pl line 3386. Use of uninitialized value $ms_size in pattern match (m//) at /home/batman/build_test/linux-next/scripts/checkpatch.pl line 3383. Use of uninitialized value $ms_size in pattern match (m//) at /home/batman/build_test/linux-next/scripts/checkpatch.pl line 3386. Use of uninitialized value $ms_size in pattern match (m//) at /home/batman/build_test/linux-next/scripts/checkpatch.pl line 3383. Use of uninitialized value $ms_size in pattern match (m//) at /home/batman/build_test/linux-next/scripts/checkpatch.pl line 3386. checkpatch next originator.c: >>>>>>>> CHECK: Blank lines aren't necessary after an open brace '{' #181: FILE: originator.c:181: + head, hash_entry) { + CHECK: Blank lines aren't necessary after an open brace '{' #288: FILE: originator.c:288: + &orig_node->neigh_list, list) { + CHECK: Blank lines aren't necessary after an open brace '{' #296: FILE: originator.c:296: + (if_incoming->if_status == BATADV_IF_TO_BE_REMOVED)) { + total: 0 errors, 0 warnings, 3 checks, 645 lines checked checkpatch next routing.c: >>>>>>>> CHECK: Blank lines aren't necessary after an open brace '{' #83: FILE: routing.c:83: + } else if ((!curr_router) && (neigh_node)) { + CHECK: Blank lines aren't necessary after an open brace '{' #175: FILE: routing.c:175: + &orig_node->neigh_list, list) { + CHECK: Blank lines aren't necessary after an open brace '{' #839: FILE: routing.c:839: + neigh_node->if_incoming->net_dev->mtu)) { + CHECK: Blank lines aren't necessary after an open brace '{' #1106: FILE: routing.c:1106: + if (batadv_is_my_mac(unicast_packet->dest)) { + total: 0 errors, 0 warnings, 4 checks, 1281 lines checked checkpatch next send.c: >>>>>>>> CHECK: Blank lines aren't necessary after an open brace '{' #333: FILE: send.c:333: + &bat_priv->forw_bcast_list, list) { + CHECK: Blank lines aren't necessary after an open brace '{' #360: FILE: send.c:360: + &bat_priv->forw_bat_list, list) { + total: 0 errors, 0 warnings, 2 checks, 382 lines checked checkpatch next soft-interface.c: >>>>>>>> Use of uninitialized value $ms_size in pattern match (m//) at /home/batman/build_test/linux-next/scripts/checkpatch.pl line 3383. Use of uninitialized value $ms_size in pattern match (m//) at /home/batman/build_test/linux-next/scripts/checkpatch.pl line 3386. Use of uninitialized value $ms_size in pattern match (m//) at /home/batman/build_test/linux-next/scripts/checkpatch.pl line 3383. Use of uninitialized value $ms_size in pattern match (m//) at /home/batman/build_test/linux-next/scripts/checkpatch.pl line 3386. Use of uninitialized value $ms_size in pattern match (m//) at /home/batman/build_test/linux-next/scripts/checkpatch.pl line 3383. Use of uninitialized value $ms_size in pattern match (m//) at /home/batman/build_test/linux-next/scripts/checkpatch.pl line 3386. WARNING: Avoid CamelCase: <vhdr->h_vlan_TCI> #170: FILE: soft-interface.c:170: + vid = ntohs(vhdr->h_vlan_TCI) & VLAN_VID_MASK; total: 0 errors, 1 warnings, 0 checks, 662 lines checked checkpatch next translation-table.c: >>>>>>>> CHECK: Blank lines aren't necessary before a close brace '}' #116: FILE: translation-table.c:116: + +} CHECK: Blank lines aren't necessary before a close brace '}' #253: FILE: translation-table.c:253: + +} CHECK: Blank lines aren't necessary before a close brace '}' #631: FILE: translation-table.c:631: + +} CHECK: Blank lines aren't necessary before a close brace '}' #1053: FILE: translation-table.c:1053: + +} CHECK: Blank lines aren't necessary before a close brace '}' #1829: FILE: translation-table.c:1829: + +} CHECK: Blank lines aren't necessary before a close brace '}' #2356: FILE: translation-table.c:2356: + +} CHECK: Blank lines aren't necessary before a close brace '}' #2553: FILE: translation-table.c:2553: + +} total: 0 errors, 0 warnings, 7 checks, 2579 lines checked checkpatch next unicast.c: >>>>>>>> CHECK: Blank lines aren't necessary after an open brace '{' #136: FILE: unicast.c:136: + list_for_each_entry(tfp, head, list) { + CHECK: Blank lines aren't necessary after an open brace '{' #165: FILE: unicast.c:165: + if (!list_empty(head)) { + total: 0 errors, 0 warnings, 2 checks, 480 lines checked checkpatch next vis.c: >>>>>>>> Use of uninitialized value $ms_size in pattern match (m//) at /home/batman/build_test/linux-next/scripts/checkpatch.pl line 3383. Use of uninitialized value $ms_size in pattern match (m//) at /home/batman/build_test/linux-next/scripts/checkpatch.pl line 3386. Use of uninitialized value $ms_size in pattern match (m//) at /home/batman/build_test/linux-next/scripts/checkpatch.pl line 3383. Use of uninitialized value $ms_size in pattern match (m//) at /home/batman/build_test/linux-next/scripts/checkpatch.pl line 3386. Use of uninitialized value $ms_size in pattern match (m//) at /home/batman/build_test/linux-next/scripts/checkpatch.pl line 3383. Use of uninitialized value $ms_size in pattern match (m//) at /home/batman/build_test/linux-next/scripts/checkpatch.pl line 3386. Use of uninitialized value $ms_size in pattern match (m//) at /home/batman/build_test/linux-next/scripts/checkpatch.pl line 3383. Use of uninitialized value $ms_size in pattern match (m//) at /home/batman/build_test/linux-next/scripts/checkpatch.pl line 3386. Use of uninitialized value $ms_size in pattern match (m//) at /home/batman/build_test/linux-next/scripts/checkpatch.pl line 3383. Use of uninitialized value $ms_size in pattern match (m//) at /home/batman/build_test/linux-next/scripts/checkpatch.pl line 3386. Use of uninitialized value $ms_size in pattern match (m//) at /home/batman/build_test/linux-next/scripts/checkpatch.pl line 3383. Use of uninitialized value $ms_size in pattern match (m//) at /home/batman/build_test/linux-next/scripts/checkpatch.pl line 3386. Use of uninitialized value $ms_size in pattern match (m//) at /home/batman/build_test/linux-next/scripts/checkpatch.pl line 3383. Use of uninitialized value $ms_size in pattern match (m//) at /home/batman/build_test/linux-next/scripts/checkpatch.pl line 3386. Use of uninitialized value $ms_size in pattern match (m//) at /home/batman/build_test/linux-next/scripts/checkpatch.pl line 3383. Use of uninitialized value $ms_size in pattern match (m//) at /home/batman/build_test/linux-next/scripts/checkpatch.pl line 3386. Use of uninitialized value $ms_size in pattern match (m//) at /home/batman/build_test/linux-next/scripts/checkpatch.pl line 3383. Use of uninitialized value $ms_size in pattern match (m//) at /home/batman/build_test/linux-next/scripts/checkpatch.pl line 3386. Use of uninitialized value $ms_size in pattern match (m//) at /home/batman/build_test/linux-next/scripts/checkpatch.pl line 3383. Use of uninitialized value $ms_size in pattern match (m//) at /home/batman/build_test/linux-next/scripts/checkpatch.pl line 3386.

10 years, 2 months

[linux-next] LinuxNextTracking branch, master, updated. next-20130108

by batman＠open-mesh.org

The following commit has been merged in the master branch: commit 7826d43f2db45c9305a6e0ba165650e1a203f517 Author: Jiri Pirko <jiri(a)resnulli.us> Date: Sun Jan 6 00:44:26 2013 +0000 ethtool: fix drvinfo strings set in drivers Use strlcpy where possible to ensure the string is \0 terminated. Use always sizeof(string) instead of 32, ETHTOOL_BUSINFO_LEN and custom defines. Use snprintf instead of sprint. Remove unnecessary inits of ->fw_version Remove unnecessary inits of drvinfo struct. Signed-off-by: Jiri Pirko <jiri(a)resnulli.us> Signed-off-by: David S. Miller <davem(a)davemloft.net> diff --git a/arch/um/drivers/net_kern.c b/arch/um/drivers/net_kern.c index fd9090d..d8926c3 100644 --- a/arch/um/drivers/net_kern.c +++ b/arch/um/drivers/net_kern.c @@ -274,8 +274,8 @@ static void uml_net_poll_controller(struct net_device *dev) static void uml_net_get_drvinfo(struct net_device *dev, struct ethtool_drvinfo *info) { - strcpy(info->driver, DRIVER_NAME); - strcpy(info->version, "42"); + strlcpy(info->driver, DRIVER_NAME, sizeof(info->driver)); + strlcpy(info->version, "42", sizeof(info->version)); } static const struct ethtool_ops uml_net_ethtool_ops = { diff --git a/drivers/infiniband/hw/nes/nes_nic.c b/drivers/infiniband/hw/nes/nes_nic.c index 9542e16..177cf76 100644 --- a/drivers/infiniband/hw/nes/nes_nic.c +++ b/drivers/infiniband/hw/nes/nes_nic.c @@ -1317,11 +1317,13 @@ static void nes_netdev_get_drvinfo(struct net_device *netdev, struct nes_vnic *nesvnic = netdev_priv(netdev); struct nes_adapter *nesadapter = nesvnic->nesdev->nesadapter; - strcpy(drvinfo->driver, DRV_NAME); - strcpy(drvinfo->bus_info, pci_name(nesvnic->nesdev->pcidev)); - sprintf(drvinfo->fw_version, "%u.%u", nesadapter->firmware_version>>16, - nesadapter->firmware_version & 0x000000ff); - strcpy(drvinfo->version, DRV_VERSION); + strlcpy(drvinfo->driver, DRV_NAME, sizeof(drvinfo->driver)); + strlcpy(drvinfo->bus_info, pci_name(nesvnic->nesdev->pcidev), + sizeof(drvinfo->bus_info)); + snprintf(drvinfo->fw_version, sizeof(drvinfo->fw_version), + "%u.%u", nesadapter->firmware_version >> 16, + nesadapter->firmware_version & 0x000000ff); + strlcpy(drvinfo->version, DRV_VERSION, sizeof(drvinfo->version)); drvinfo->testinfo_len = 0; drvinfo->eedump_len = 0; drvinfo->regdump_len = 0; diff --git a/drivers/infiniband/ulp/ipoib/ipoib_ethtool.c b/drivers/infiniband/ulp/ipoib/ipoib_ethtool.c index 29bc7b5..ca13133 100644 --- a/drivers/infiniband/ulp/ipoib/ipoib_ethtool.c +++ b/drivers/infiniband/ulp/ipoib/ipoib_ethtool.c @@ -39,7 +39,7 @@ static void ipoib_get_drvinfo(struct net_device *netdev, struct ethtool_drvinfo *drvinfo) { - strncpy(drvinfo->driver, "ipoib", sizeof(drvinfo->driver) - 1); + strlcpy(drvinfo->driver, "ipoib", sizeof(drvinfo->driver)); } static int ipoib_get_coalesce(struct net_device *dev, diff --git a/drivers/net/bonding/bond_main.c b/drivers/net/bonding/bond_main.c index c495298..564cf42 100644 --- a/drivers/net/bonding/bond_main.c +++ b/drivers/net/bonding/bond_main.c @@ -4330,11 +4330,12 @@ void bond_set_mode_ops(struct bonding *bond, int mode) } static void bond_ethtool_get_drvinfo(struct net_device *bond_dev, - struct ethtool_drvinfo *drvinfo) + struct ethtool_drvinfo *drvinfo) { - strncpy(drvinfo->driver, DRV_NAME, 32); - strncpy(drvinfo->version, DRV_VERSION, 32); - snprintf(drvinfo->fw_version, 32, "%d", BOND_ABI_VERSION); + strlcpy(drvinfo->driver, DRV_NAME, sizeof(drvinfo->driver)); + strlcpy(drvinfo->version, DRV_VERSION, sizeof(drvinfo->version)); + snprintf(drvinfo->fw_version, sizeof(drvinfo->fw_version), "%d", + BOND_ABI_VERSION); } static const struct ethtool_ops bond_ethtool_ops = { diff --git a/drivers/net/cris/eth_v10.c b/drivers/net/cris/eth_v10.c index 021d69c..29e272c 100644 --- a/drivers/net/cris/eth_v10.c +++ b/drivers/net/cris/eth_v10.c @@ -1448,10 +1448,10 @@ static int e100_set_settings(struct net_device *dev, static void e100_get_drvinfo(struct net_device *dev, struct ethtool_drvinfo *info) { - strncpy(info->driver, "ETRAX 100LX", sizeof(info->driver) - 1); - strncpy(info->version, "$Revision: 1.31 $", sizeof(info->version) - 1); - strncpy(info->fw_version, "N/A", sizeof(info->fw_version) - 1); - strncpy(info->bus_info, "N/A", sizeof(info->bus_info) - 1); + strlcpy(info->driver, "ETRAX 100LX", sizeof(info->driver)); + strlcpy(info->version, "$Revision: 1.31 $", sizeof(info->version)); + strlcpy(info->fw_version, "N/A", sizeof(info->fw_version)); + strlcpy(info->bus_info, "N/A", sizeof(info->bus_info)); } static int e100_nway_reset(struct net_device *dev) diff --git a/drivers/net/ethernet/3com/3c501.c b/drivers/net/ethernet/3com/3c501.c index 2038eaa..9abd9a7 100644 --- a/drivers/net/ethernet/3com/3c501.c +++ b/drivers/net/ethernet/3com/3c501.c @@ -823,9 +823,10 @@ static void set_multicast_list(struct net_device *dev) static void netdev_get_drvinfo(struct net_device *dev, struct ethtool_drvinfo *info) { - strcpy(info->driver, DRV_NAME); - strcpy(info->version, DRV_VERSION); - sprintf(info->bus_info, "ISA 0x%lx", dev->base_addr); + strlcpy(info->driver, DRV_NAME, sizeof(info->driver)); + strlcpy(info->version, DRV_VERSION, sizeof(info->version)); + snprintf(info->bus_info, sizeof(info->bus_info), "ISA 0x%lx", + dev->base_addr); } static u32 netdev_get_msglevel(struct net_device *dev) diff --git a/drivers/net/ethernet/3com/3c509.c b/drivers/net/ethernet/3com/3c509.c index 633c709..f36ff99 100644 --- a/drivers/net/ethernet/3com/3c509.c +++ b/drivers/net/ethernet/3com/3c509.c @@ -1161,8 +1161,8 @@ el3_netdev_set_ecmd(struct net_device *dev, struct ethtool_cmd *ecmd) static void el3_get_drvinfo(struct net_device *dev, struct ethtool_drvinfo *info) { - strcpy(info->driver, DRV_NAME); - strcpy(info->version, DRV_VERSION); + strlcpy(info->driver, DRV_NAME, sizeof(info->driver)); + strlcpy(info->version, DRV_VERSION, sizeof(info->version)); } static int el3_get_settings(struct net_device *dev, struct ethtool_cmd *ecmd) diff --git a/drivers/net/ethernet/3com/3c515.c b/drivers/net/ethernet/3com/3c515.c index 59e1e00..94c656f 100644 --- a/drivers/net/ethernet/3com/3c515.c +++ b/drivers/net/ethernet/3com/3c515.c @@ -1542,9 +1542,10 @@ static void set_rx_mode(struct net_device *dev) static void netdev_get_drvinfo(struct net_device *dev, struct ethtool_drvinfo *info) { - strcpy(info->driver, DRV_NAME); - strcpy(info->version, DRV_VERSION); - sprintf(info->bus_info, "ISA 0x%lx", dev->base_addr); + strlcpy(info->driver, DRV_NAME, sizeof(info->driver)); + strlcpy(info->version, DRV_VERSION, sizeof(info->version)); + snprintf(info->bus_info, sizeof(info->bus_info), "ISA 0x%lx", + dev->base_addr); } static u32 netdev_get_msglevel(struct net_device *dev) diff --git a/drivers/net/ethernet/8390/3c503.c b/drivers/net/ethernet/8390/3c503.c index 49d76bd..0e9afe7 100644 --- a/drivers/net/ethernet/8390/3c503.c +++ b/drivers/net/ethernet/8390/3c503.c @@ -695,9 +695,10 @@ el2_block_input(struct net_device *dev, int count, struct sk_buff *skb, int ring static void netdev_get_drvinfo(struct net_device *dev, struct ethtool_drvinfo *info) { - strcpy(info->driver, DRV_NAME); - strcpy(info->version, DRV_VERSION); - sprintf(info->bus_info, "ISA 0x%lx", dev->base_addr); + strlcpy(info->driver, DRV_NAME, sizeof(info->driver)); + strlcpy(info->version, DRV_VERSION, sizeof(info->version)); + snprintf(info->bus_info, sizeof(info->bus_info), "ISA 0x%lx", + dev->base_addr); } static const struct ethtool_ops netdev_ethtool_ops = { diff --git a/drivers/net/ethernet/8390/ax88796.c b/drivers/net/ethernet/8390/ax88796.c index 70dba5d..7eeddf0 100644 --- a/drivers/net/ethernet/8390/ax88796.c +++ b/drivers/net/ethernet/8390/ax88796.c @@ -469,9 +469,9 @@ static void ax_get_drvinfo(struct net_device *dev, { struct platform_device *pdev = to_platform_device(dev->dev.parent); - strcpy(info->driver, DRV_NAME); - strcpy(info->version, DRV_VERSION); - strcpy(info->bus_info, pdev->name); + strlcpy(info->driver, DRV_NAME, sizeof(info->driver)); + strlcpy(info->version, DRV_VERSION, sizeof(info->version)); + strlcpy(info->bus_info, pdev->name, sizeof(info->bus_info)); } static int ax_get_settings(struct net_device *dev, struct ethtool_cmd *cmd) diff --git a/drivers/net/ethernet/adi/bfin_mac.c b/drivers/net/ethernet/adi/bfin_mac.c index 8c3c9cf..c7a83f6 100644 --- a/drivers/net/ethernet/adi/bfin_mac.c +++ b/drivers/net/ethernet/adi/bfin_mac.c @@ -498,10 +498,10 @@ bfin_mac_ethtool_setsettings(struct net_device *dev, struct ethtool_cmd *cmd) static void bfin_mac_ethtool_getdrvinfo(struct net_device *dev, struct ethtool_drvinfo *info) { - strcpy(info->driver, KBUILD_MODNAME); - strcpy(info->version, DRV_VERSION); - strcpy(info->fw_version, "N/A"); - strcpy(info->bus_info, dev_name(&dev->dev)); + strlcpy(info->driver, KBUILD_MODNAME, sizeof(info->driver)); + strlcpy(info->version, DRV_VERSION, sizeof(info->version)); + strlcpy(info->fw_version, "N/A", sizeof(info->fw_version)); + strlcpy(info->bus_info, dev_name(&dev->dev), sizeof(info->bus_info)); } static void bfin_mac_ethtool_getwol(struct net_device *dev, diff --git a/drivers/net/ethernet/aeroflex/greth.c b/drivers/net/ethernet/aeroflex/greth.c index aa53115..480662b 100644 --- a/drivers/net/ethernet/aeroflex/greth.c +++ b/drivers/net/ethernet/aeroflex/greth.c @@ -1127,10 +1127,11 @@ static void greth_get_drvinfo(struct net_device *dev, struct ethtool_drvinfo *in { struct greth_private *greth = netdev_priv(dev); - strncpy(info->driver, dev_driver_string(greth->dev), 32); - strncpy(info->version, "revision: 1.0", 32); - strncpy(info->bus_info, greth->dev->bus->name, 32); - strncpy(info->fw_version, "N/A", 32); + strlcpy(info->driver, dev_driver_string(greth->dev), + sizeof(info->driver)); + strlcpy(info->version, "revision: 1.0", sizeof(info->version)); + strlcpy(info->bus_info, greth->dev->bus->name, sizeof(info->bus_info)); + strlcpy(info->fw_version, "N/A", sizeof(info->fw_version)); info->eedump_len = 0; info->regdump_len = sizeof(struct greth_regs); } diff --git a/drivers/net/ethernet/amd/au1000_eth.c b/drivers/net/ethernet/amd/au1000_eth.c index 2ea221e..65b865a 100644 --- a/drivers/net/ethernet/amd/au1000_eth.c +++ b/drivers/net/ethernet/amd/au1000_eth.c @@ -587,10 +587,10 @@ au1000_get_drvinfo(struct net_device *dev, struct ethtool_drvinfo *info) { struct au1000_private *aup = netdev_priv(dev); - strcpy(info->driver, DRV_NAME); - strcpy(info->version, DRV_VERSION); - info->fw_version[0] = '\0'; - sprintf(info->bus_info, "%s %d", DRV_NAME, aup->mac_id); + strlcpy(info->driver, DRV_NAME, sizeof(info->driver)); + strlcpy(info->version, DRV_VERSION, sizeof(info->version)); + snprintf(info->bus_info, sizeof(info->bus_info), "%s %d", DRV_NAME, + aup->mac_id); info->regdump_len = 0; } diff --git a/drivers/net/ethernet/amd/sunlance.c b/drivers/net/ethernet/amd/sunlance.c index c2d696c..6a40290 100644 --- a/drivers/net/ethernet/amd/sunlance.c +++ b/drivers/net/ethernet/amd/sunlance.c @@ -1284,8 +1284,8 @@ static void lance_free_hwresources(struct lance_private *lp) /* Ethtool support... */ static void sparc_lance_get_drvinfo(struct net_device *dev, struct ethtool_drvinfo *info) { - strcpy(info->driver, "sunlance"); - strcpy(info->version, "2.02"); + strlcpy(info->driver, "sunlance", sizeof(info->driver)); + strlcpy(info->version, "2.02", sizeof(info->version)); } static const struct ethtool_ops sparc_lance_ethtool_ops = { diff --git a/drivers/net/ethernet/broadcom/bcm63xx_enet.c b/drivers/net/ethernet/broadcom/bcm63xx_enet.c index 39387d6..d8a1510 100644 --- a/drivers/net/ethernet/broadcom/bcm63xx_enet.c +++ b/drivers/net/ethernet/broadcom/bcm63xx_enet.c @@ -1227,10 +1227,11 @@ static const u32 unused_mib_regs[] = { static void bcm_enet_get_drvinfo(struct net_device *netdev, struct ethtool_drvinfo *drvinfo) { - strncpy(drvinfo->driver, bcm_enet_driver_name, 32); - strncpy(drvinfo->version, bcm_enet_driver_version, 32); - strncpy(drvinfo->fw_version, "N/A", 32); - strncpy(drvinfo->bus_info, "bcm63xx", 32); + strlcpy(drvinfo->driver, bcm_enet_driver_name, sizeof(drvinfo->driver)); + strlcpy(drvinfo->version, bcm_enet_driver_version, + sizeof(drvinfo->version)); + strlcpy(drvinfo->fw_version, "N/A", sizeof(drvinfo->fw_version)); + strlcpy(drvinfo->bus_info, "bcm63xx", sizeof(drvinfo->bus_info)); drvinfo->n_stats = BCM_ENET_STATS_LEN; } diff --git a/drivers/net/ethernet/cirrus/ep93xx_eth.c b/drivers/net/ethernet/cirrus/ep93xx_eth.c index 78c5521..354cbb7 100644 --- a/drivers/net/ethernet/cirrus/ep93xx_eth.c +++ b/drivers/net/ethernet/cirrus/ep93xx_eth.c @@ -710,8 +710,8 @@ static int ep93xx_ioctl(struct net_device *dev, struct ifreq *ifr, int cmd) static void ep93xx_get_drvinfo(struct net_device *dev, struct ethtool_drvinfo *info) { - strcpy(info->driver, DRV_MODULE_NAME); - strcpy(info->version, DRV_MODULE_VERSION); + strlcpy(info->driver, DRV_MODULE_NAME, sizeof(info->driver)); + strlcpy(info->version, DRV_MODULE_VERSION, sizeof(info->version)); } static int ep93xx_get_settings(struct net_device *dev, struct ethtool_cmd *cmd) diff --git a/drivers/net/ethernet/davicom/dm9000.c b/drivers/net/ethernet/davicom/dm9000.c index c73472c..8cdf025 100644 --- a/drivers/net/ethernet/davicom/dm9000.c +++ b/drivers/net/ethernet/davicom/dm9000.c @@ -434,9 +434,10 @@ static void dm9000_get_drvinfo(struct net_device *dev, { board_info_t *dm = to_dm9000_board(dev); - strcpy(info->driver, CARDNAME); - strcpy(info->version, DRV_VERSION); - strcpy(info->bus_info, to_platform_device(dm->dev)->name); + strlcpy(info->driver, CARDNAME, sizeof(info->driver)); + strlcpy(info->version, DRV_VERSION, sizeof(info->version)); + strlcpy(info->bus_info, to_platform_device(dm->dev)->name, + sizeof(info->bus_info)); } static u32 dm9000_get_msglevel(struct net_device *dev) diff --git a/drivers/net/ethernet/dec/ewrk3.c b/drivers/net/ethernet/dec/ewrk3.c index 9f992b9..5015172 100644 --- a/drivers/net/ethernet/dec/ewrk3.c +++ b/drivers/net/ethernet/dec/ewrk3.c @@ -1506,10 +1506,10 @@ static void ewrk3_get_drvinfo(struct net_device *dev, struct ethtool_drvinfo *in { int fwrev = Read_EEPROM(dev->base_addr, EEPROM_REVLVL); - strcpy(info->driver, DRV_NAME); - strcpy(info->version, DRV_VERSION); - sprintf(info->fw_version, "%d", fwrev); - strcpy(info->bus_info, "N/A"); + strlcpy(info->driver, DRV_NAME, sizeof(info->driver)); + strlcpy(info->version, DRV_VERSION, sizeof(info->version)); + snprintf(info->fw_version, sizeof(info->fw_version), "%d", fwrev); + strlcpy(info->bus_info, "N/A", sizeof(info->bus_info)); info->eedump_len = EEPROM_MAX; } diff --git a/drivers/net/ethernet/dlink/dl2k.c b/drivers/net/ethernet/dlink/dl2k.c index 1d342d3..110d26f 100644 --- a/drivers/net/ethernet/dlink/dl2k.c +++ b/drivers/net/ethernet/dlink/dl2k.c @@ -1156,9 +1156,10 @@ set_multicast (struct net_device *dev) static void rio_get_drvinfo(struct net_device *dev, struct ethtool_drvinfo *info) { struct netdev_private *np = netdev_priv(dev); - strcpy(info->driver, "dl2k"); - strcpy(info->version, DRV_VERSION); - strcpy(info->bus_info, pci_name(np->pdev)); + + strlcpy(info->driver, "dl2k", sizeof(info->driver)); + strlcpy(info->version, DRV_VERSION, sizeof(info->version)); + strlcpy(info->bus_info, pci_name(np->pdev), sizeof(info->bus_info)); } static int rio_get_settings(struct net_device *dev, struct ethtool_cmd *cmd) diff --git a/drivers/net/ethernet/emulex/benet/be_ethtool.c b/drivers/net/ethernet/emulex/benet/be_ethtool.c index 00454a1..76b302f 100644 --- a/drivers/net/ethernet/emulex/benet/be_ethtool.c +++ b/drivers/net/ethernet/emulex/benet/be_ethtool.c @@ -183,12 +183,12 @@ static void be_get_drvinfo(struct net_device *netdev, strlcpy(drvinfo->driver, DRV_NAME, sizeof(drvinfo->driver)); strlcpy(drvinfo->version, DRV_VER, sizeof(drvinfo->version)); - strncpy(drvinfo->fw_version, adapter->fw_ver, FW_VER_LEN); - if (memcmp(adapter->fw_ver, fw_on_flash, FW_VER_LEN) != 0) { - strcat(drvinfo->fw_version, " ["); - strcat(drvinfo->fw_version, fw_on_flash); - strcat(drvinfo->fw_version, "]"); - } + if (!memcmp(adapter->fw_ver, fw_on_flash, FW_VER_LEN)) + strlcpy(drvinfo->fw_version, adapter->fw_ver, + sizeof(drvinfo->fw_version)); + else + snprintf(drvinfo->fw_version, sizeof(drvinfo->fw_version), + "%s [%s]", adapter->fw_ver, fw_on_flash); strlcpy(drvinfo->bus_info, pci_name(adapter->pdev), sizeof(drvinfo->bus_info)); diff --git a/drivers/net/ethernet/faraday/ftgmac100.c b/drivers/net/ethernet/faraday/ftgmac100.c index 74d749e..96454b5 100644 --- a/drivers/net/ethernet/faraday/ftgmac100.c +++ b/drivers/net/ethernet/faraday/ftgmac100.c @@ -955,9 +955,9 @@ static int ftgmac100_mdiobus_reset(struct mii_bus *bus) static void ftgmac100_get_drvinfo(struct net_device *netdev, struct ethtool_drvinfo *info) { - strcpy(info->driver, DRV_NAME); - strcpy(info->version, DRV_VERSION); - strcpy(info->bus_info, dev_name(&netdev->dev)); + strlcpy(info->driver, DRV_NAME, sizeof(info->driver)); + strlcpy(info->version, DRV_VERSION, sizeof(info->version)); + strlcpy(info->bus_info, dev_name(&netdev->dev), sizeof(info->bus_info)); } static int ftgmac100_get_settings(struct net_device *netdev, diff --git a/drivers/net/ethernet/faraday/ftmac100.c b/drivers/net/ethernet/faraday/ftmac100.c index b901a01..b5ea8fb 100644 --- a/drivers/net/ethernet/faraday/ftmac100.c +++ b/drivers/net/ethernet/faraday/ftmac100.c @@ -820,9 +820,9 @@ static void ftmac100_mdio_write(struct net_device *netdev, int phy_id, int reg, static void ftmac100_get_drvinfo(struct net_device *netdev, struct ethtool_drvinfo *info) { - strcpy(info->driver, DRV_NAME); - strcpy(info->version, DRV_VERSION); - strcpy(info->bus_info, dev_name(&netdev->dev)); + strlcpy(info->driver, DRV_NAME, sizeof(info->driver)); + strlcpy(info->version, DRV_VERSION, sizeof(info->version)); + strlcpy(info->bus_info, dev_name(&netdev->dev), sizeof(info->bus_info)); } static int ftmac100_get_settings(struct net_device *netdev, struct ethtool_cmd *cmd) diff --git a/drivers/net/ethernet/freescale/fec.c b/drivers/net/ethernet/freescale/fec.c index a379319..0a9748b 100644 --- a/drivers/net/ethernet/freescale/fec.c +++ b/drivers/net/ethernet/freescale/fec.c @@ -1168,9 +1168,10 @@ static void fec_enet_get_drvinfo(struct net_device *ndev, { struct fec_enet_private *fep = netdev_priv(ndev); - strcpy(info->driver, fep->pdev->dev.driver->name); - strcpy(info->version, "Revision: 1.0"); - strcpy(info->bus_info, dev_name(&ndev->dev)); + strlcpy(info->driver, fep->pdev->dev.driver->name, + sizeof(info->driver)); + strlcpy(info->version, "Revision: 1.0", sizeof(info->version)); + strlcpy(info->bus_info, dev_name(&ndev->dev), sizeof(info->bus_info)); } static const struct ethtool_ops fec_enet_ethtool_ops = { diff --git a/drivers/net/ethernet/freescale/fs_enet/fs_enet-main.c b/drivers/net/ethernet/freescale/fs_enet/fs_enet-main.c index e9879c5..46df288 100644 --- a/drivers/net/ethernet/freescale/fs_enet/fs_enet-main.c +++ b/drivers/net/ethernet/freescale/fs_enet/fs_enet-main.c @@ -888,8 +888,8 @@ static struct net_device_stats *fs_enet_get_stats(struct net_device *dev) static void fs_get_drvinfo(struct net_device *dev, struct ethtool_drvinfo *info) { - strcpy(info->driver, DRV_MODULE_NAME); - strcpy(info->version, DRV_MODULE_VERSION); + strlcpy(info->driver, DRV_MODULE_NAME, sizeof(info->driver)); + strlcpy(info->version, DRV_MODULE_VERSION, sizeof(info->version)); } static int fs_get_regs_len(struct net_device *dev) diff --git a/drivers/net/ethernet/freescale/gianfar.h b/drivers/net/ethernet/freescale/gianfar.h index 22eabc1..1b6a67c 100644 --- a/drivers/net/ethernet/freescale/gianfar.h +++ b/drivers/net/ethernet/freescale/gianfar.h @@ -649,8 +649,6 @@ struct gfar_extra_stats { /* Number of stats in the stats structure (ignore car and cam regs)*/ #define GFAR_STATS_LEN (GFAR_RMON_LEN + GFAR_EXTRA_STATS_LEN) -#define GFAR_INFOSTR_LEN 32 - struct gfar_stats { u64 extra[GFAR_EXTRA_STATS_LEN]; u64 rmon[GFAR_RMON_LEN]; diff --git a/drivers/net/ethernet/freescale/gianfar_ethtool.c b/drivers/net/ethernet/freescale/gianfar_ethtool.c index ab6762c..d0fe53c 100644 --- a/drivers/net/ethernet/freescale/gianfar_ethtool.c +++ b/drivers/net/ethernet/freescale/gianfar_ethtool.c @@ -184,10 +184,11 @@ static int gfar_sset_count(struct net_device *dev, int sset) static void gfar_gdrvinfo(struct net_device *dev, struct ethtool_drvinfo *drvinfo) { - strncpy(drvinfo->driver, DRV_NAME, GFAR_INFOSTR_LEN); - strncpy(drvinfo->version, gfar_driver_version, GFAR_INFOSTR_LEN); - strncpy(drvinfo->fw_version, "N/A", GFAR_INFOSTR_LEN); - strncpy(drvinfo->bus_info, "N/A", GFAR_INFOSTR_LEN); + strlcpy(drvinfo->driver, DRV_NAME, sizeof(drvinfo->driver)); + strlcpy(drvinfo->version, gfar_driver_version, + sizeof(drvinfo->version)); + strlcpy(drvinfo->fw_version, "N/A", sizeof(drvinfo->fw_version)); + strlcpy(drvinfo->bus_info, "N/A", sizeof(drvinfo->bus_info)); drvinfo->regdump_len = 0; drvinfo->eedump_len = 0; } diff --git a/drivers/net/ethernet/freescale/ucc_geth_ethtool.c b/drivers/net/ethernet/freescale/ucc_geth_ethtool.c index 37b0353..1ebf712 100644 --- a/drivers/net/ethernet/freescale/ucc_geth_ethtool.c +++ b/drivers/net/ethernet/freescale/ucc_geth_ethtool.c @@ -350,10 +350,10 @@ static void uec_get_drvinfo(struct net_device *netdev, struct ethtool_drvinfo *drvinfo) { - strncpy(drvinfo->driver, DRV_NAME, 32); - strncpy(drvinfo->version, DRV_VERSION, 32); - strncpy(drvinfo->fw_version, "N/A", 32); - strncpy(drvinfo->bus_info, "QUICC ENGINE", 32); + strlcpy(drvinfo->driver, DRV_NAME, sizeof(drvinfo->driver)); + strlcpy(drvinfo->version, DRV_VERSION, sizeof(drvinfo->version)); + strlcpy(drvinfo->fw_version, "N/A", sizeof(drvinfo->fw_version)); + strlcpy(drvinfo->bus_info, "QUICC ENGINE", sizeof(drvinfo->bus_info)); drvinfo->eedump_len = 0; drvinfo->regdump_len = uec_get_regs_len(netdev); } diff --git a/drivers/net/ethernet/i825xx/3c505.c b/drivers/net/ethernet/i825xx/3c505.c index 6a5c21b..6d000d6 100644 --- a/drivers/net/ethernet/i825xx/3c505.c +++ b/drivers/net/ethernet/i825xx/3c505.c @@ -1138,9 +1138,10 @@ static struct net_device_stats *elp_get_stats(struct net_device *dev) static void netdev_get_drvinfo(struct net_device *dev, struct ethtool_drvinfo *info) { - strcpy(info->driver, DRV_NAME); - strcpy(info->version, DRV_VERSION); - sprintf(info->bus_info, "ISA 0x%lx", dev->base_addr); + strlcpy(info->driver, DRV_NAME, sizeof(info->driver)); + strlcpy(info->version, DRV_VERSION, sizeof(info->version)); + snprintf(info->bus_info, sizeof(info->bus_info), "ISA 0x%lx", + dev->base_addr); } static u32 netdev_get_msglevel(struct net_device *dev) diff --git a/drivers/net/ethernet/i825xx/3c507.c b/drivers/net/ethernet/i825xx/3c507.c index e8984b05..13983ee 100644 --- a/drivers/net/ethernet/i825xx/3c507.c +++ b/drivers/net/ethernet/i825xx/3c507.c @@ -888,9 +888,10 @@ static void el16_rx(struct net_device *dev) static void netdev_get_drvinfo(struct net_device *dev, struct ethtool_drvinfo *info) { - strcpy(info->driver, DRV_NAME); - strcpy(info->version, DRV_VERSION); - sprintf(info->bus_info, "ISA 0x%lx", dev->base_addr); + strlcpy(info->driver, DRV_NAME, sizeof(info->driver)); + strlcpy(info->version, DRV_VERSION, sizeof(info->version)); + snprintf(info->bus_info, sizeof(info->bus_info), "ISA 0x%lx", + dev->base_addr); } static u32 netdev_get_msglevel(struct net_device *dev) diff --git a/drivers/net/ethernet/ibm/emac/core.c b/drivers/net/ethernet/ibm/emac/core.c index 256bdb8..4989481 100644 --- a/drivers/net/ethernet/ibm/emac/core.c +++ b/drivers/net/ethernet/ibm/emac/core.c @@ -2190,11 +2190,10 @@ static void emac_ethtool_get_drvinfo(struct net_device *ndev, { struct emac_instance *dev = netdev_priv(ndev); - strcpy(info->driver, "ibm_emac"); - strcpy(info->version, DRV_VERSION); - info->fw_version[0] = '\0'; - sprintf(info->bus_info, "PPC 4xx EMAC-%d %s", - dev->cell_index, dev->ofdev->dev.of_node->full_name); + strlcpy(info->driver, "ibm_emac", sizeof(info->driver)); + strlcpy(info->version, DRV_VERSION, sizeof(info->version)); + snprintf(info->bus_info, sizeof(info->bus_info), "PPC 4xx EMAC-%d %s", + dev->cell_index, dev->ofdev->dev.of_node->full_name); info->regdump_len = emac_ethtool_get_regs_len(ndev); } diff --git a/drivers/net/ethernet/ibm/ibmveth.c b/drivers/net/ethernet/ibm/ibmveth.c index f2fdbb7..4181f6e 100644 --- a/drivers/net/ethernet/ibm/ibmveth.c +++ b/drivers/net/ethernet/ibm/ibmveth.c @@ -722,9 +722,8 @@ static int netdev_get_settings(struct net_device *dev, struct ethtool_cmd *cmd) static void netdev_get_drvinfo(struct net_device *dev, struct ethtool_drvinfo *info) { - strncpy(info->driver, ibmveth_driver_name, sizeof(info->driver) - 1); - strncpy(info->version, ibmveth_driver_version, - sizeof(info->version) - 1); + strlcpy(info->driver, ibmveth_driver_name, sizeof(info->driver)); + strlcpy(info->version, ibmveth_driver_version, sizeof(info->version)); } static netdev_features_t ibmveth_fix_features(struct net_device *dev, diff --git a/drivers/net/ethernet/korina.c b/drivers/net/ethernet/korina.c index bc58f1d..5409fe8 100644 --- a/drivers/net/ethernet/korina.c +++ b/drivers/net/ethernet/korina.c @@ -695,9 +695,9 @@ static void netdev_get_drvinfo(struct net_device *dev, { struct korina_private *lp = netdev_priv(dev); - strcpy(info->driver, DRV_NAME); - strcpy(info->version, DRV_VERSION); - strcpy(info->bus_info, lp->dev->name); + strlcpy(info->driver, DRV_NAME, sizeof(info->driver)); + strlcpy(info->version, DRV_VERSION, sizeof(info->version)); + strlcpy(info->bus_info, lp->dev->name, sizeof(info->bus_info)); } static int netdev_get_settings(struct net_device *dev, struct ethtool_cmd *cmd) diff --git a/drivers/net/ethernet/lantiq_etop.c b/drivers/net/ethernet/lantiq_etop.c index cd3d2c0..8ead46a 100644 --- a/drivers/net/ethernet/lantiq_etop.c +++ b/drivers/net/ethernet/lantiq_etop.c @@ -302,9 +302,9 @@ ltq_etop_hw_init(struct net_device *dev) static void ltq_etop_get_drvinfo(struct net_device *dev, struct ethtool_drvinfo *info) { - strcpy(info->driver, "Lantiq ETOP"); - strcpy(info->bus_info, "internal"); - strcpy(info->version, DRV_VERSION); + strlcpy(info->driver, "Lantiq ETOP", sizeof(info->driver)); + strlcpy(info->bus_info, "internal", sizeof(info->bus_info)); + strlcpy(info->version, DRV_VERSION, sizeof(info->version)); } static int diff --git a/drivers/net/ethernet/marvell/pxa168_eth.c b/drivers/net/ethernet/marvell/pxa168_eth.c index aa037ca..c7f2fa6 100644 --- a/drivers/net/ethernet/marvell/pxa168_eth.c +++ b/drivers/net/ethernet/marvell/pxa168_eth.c @@ -1443,10 +1443,10 @@ static int pxa168_set_settings(struct net_device *dev, struct ethtool_cmd *cmd) static void pxa168_get_drvinfo(struct net_device *dev, struct ethtool_drvinfo *info) { - strncpy(info->driver, DRIVER_NAME, 32); - strncpy(info->version, DRIVER_VERSION, 32); - strncpy(info->fw_version, "N/A", 32); - strncpy(info->bus_info, "N/A", 32); + strlcpy(info->driver, DRIVER_NAME, sizeof(info->driver)); + strlcpy(info->version, DRIVER_VERSION, sizeof(info->version)); + strlcpy(info->fw_version, "N/A", sizeof(info->fw_version)); + strlcpy(info->bus_info, "N/A", sizeof(info->bus_info)); } static const struct ethtool_ops pxa168_ethtool_ops = { diff --git a/drivers/net/ethernet/neterion/vxge/vxge-ethtool.c b/drivers/net/ethernet/neterion/vxge/vxge-ethtool.c index 92dd72d..f8f0738 100644 --- a/drivers/net/ethernet/neterion/vxge/vxge-ethtool.c +++ b/drivers/net/ethernet/neterion/vxge/vxge-ethtool.c @@ -82,9 +82,9 @@ static void vxge_ethtool_gdrvinfo(struct net_device *dev, struct ethtool_drvinfo *info) { struct vxgedev *vdev = netdev_priv(dev); - strlcpy(info->driver, VXGE_DRIVER_NAME, sizeof(VXGE_DRIVER_NAME)); - strlcpy(info->version, DRV_VERSION, sizeof(DRV_VERSION)); - strlcpy(info->fw_version, vdev->fw_version, VXGE_HW_FW_STRLEN); + strlcpy(info->driver, VXGE_DRIVER_NAME, sizeof(info->driver)); + strlcpy(info->version, DRV_VERSION, sizeof(info->version)); + strlcpy(info->fw_version, vdev->fw_version, sizeof(info->fw_version)); strlcpy(info->bus_info, pci_name(vdev->pdev), sizeof(info->bus_info)); info->regdump_len = sizeof(struct vxge_hw_vpath_reg) * vdev->no_of_vpath; diff --git a/drivers/net/ethernet/nuvoton/w90p910_ether.c b/drivers/net/ethernet/nuvoton/w90p910_ether.c index cbd6a52..162da89 100644 --- a/drivers/net/ethernet/nuvoton/w90p910_ether.c +++ b/drivers/net/ethernet/nuvoton/w90p910_ether.c @@ -878,8 +878,8 @@ static int w90p910_ether_ioctl(struct net_device *dev, static void w90p910_get_drvinfo(struct net_device *dev, struct ethtool_drvinfo *info) { - strcpy(info->driver, DRV_MODULE_NAME); - strcpy(info->version, DRV_MODULE_VERSION); + strlcpy(info->driver, DRV_MODULE_NAME, sizeof(info->driver)); + strlcpy(info->version, DRV_MODULE_VERSION, sizeof(info->version)); } static int w90p910_get_settings(struct net_device *dev, struct ethtool_cmd *cmd) diff --git a/drivers/net/ethernet/nxp/lpc_eth.c b/drivers/net/ethernet/nxp/lpc_eth.c index 3466ca1..6fda51e 100644 --- a/drivers/net/ethernet/nxp/lpc_eth.c +++ b/drivers/net/ethernet/nxp/lpc_eth.c @@ -1239,9 +1239,10 @@ static int lpc_eth_open(struct net_device *ndev) static void lpc_eth_ethtool_getdrvinfo(struct net_device *ndev, struct ethtool_drvinfo *info) { - strcpy(info->driver, MODNAME); - strcpy(info->version, DRV_VERSION); - strcpy(info->bus_info, dev_name(ndev->dev.parent)); + strlcpy(info->driver, MODNAME, sizeof(info->driver)); + strlcpy(info->version, DRV_VERSION, sizeof(info->version)); + strlcpy(info->bus_info, dev_name(ndev->dev.parent), + sizeof(info->bus_info)); } static u32 lpc_eth_ethtool_getmsglevel(struct net_device *ndev) diff --git a/drivers/net/ethernet/octeon/octeon_mgmt.c b/drivers/net/ethernet/octeon/octeon_mgmt.c index b4a842c..921729f 100644 --- a/drivers/net/ethernet/octeon/octeon_mgmt.c +++ b/drivers/net/ethernet/octeon/octeon_mgmt.c @@ -1350,10 +1350,10 @@ static void octeon_mgmt_poll_controller(struct net_device *netdev) static void octeon_mgmt_get_drvinfo(struct net_device *netdev, struct ethtool_drvinfo *info) { - strncpy(info->driver, DRV_NAME, sizeof(info->driver)); - strncpy(info->version, DRV_VERSION, sizeof(info->version)); - strncpy(info->fw_version, "N/A", sizeof(info->fw_version)); - strncpy(info->bus_info, "N/A", sizeof(info->bus_info)); + strlcpy(info->driver, DRV_NAME, sizeof(info->driver)); + strlcpy(info->version, DRV_VERSION, sizeof(info->version)); + strlcpy(info->fw_version, "N/A", sizeof(info->fw_version)); + strlcpy(info->bus_info, "N/A", sizeof(info->bus_info)); info->n_stats = 0; info->testinfo_len = 0; info->regdump_len = 0; diff --git a/drivers/net/ethernet/packetengines/hamachi.c b/drivers/net/ethernet/packetengines/hamachi.c index bf829ee..cac33e5 100644 --- a/drivers/net/ethernet/packetengines/hamachi.c +++ b/drivers/net/ethernet/packetengines/hamachi.c @@ -1808,9 +1808,10 @@ static int check_if_running(struct net_device *dev) static void hamachi_get_drvinfo(struct net_device *dev, struct ethtool_drvinfo *info) { struct hamachi_private *np = netdev_priv(dev); - strcpy(info->driver, DRV_NAME); - strcpy(info->version, DRV_VERSION); - strcpy(info->bus_info, pci_name(np->pci_dev)); + + strlcpy(info->driver, DRV_NAME, sizeof(info->driver)); + strlcpy(info->version, DRV_VERSION, sizeof(info->version)); + strlcpy(info->bus_info, pci_name(np->pci_dev), sizeof(info->bus_info)); } static int hamachi_get_settings(struct net_device *dev, struct ethtool_cmd *ecmd) diff --git a/drivers/net/ethernet/packetengines/yellowfin.c b/drivers/net/ethernet/packetengines/yellowfin.c index fbaed4f..d28593b 100644 --- a/drivers/net/ethernet/packetengines/yellowfin.c +++ b/drivers/net/ethernet/packetengines/yellowfin.c @@ -1326,9 +1326,10 @@ static void set_rx_mode(struct net_device *dev) static void yellowfin_get_drvinfo(struct net_device *dev, struct ethtool_drvinfo *info) { struct yellowfin_private *np = netdev_priv(dev); - strcpy(info->driver, DRV_NAME); - strcpy(info->version, DRV_VERSION); - strcpy(info->bus_info, pci_name(np->pci_dev)); + + strlcpy(info->driver, DRV_NAME, sizeof(info->driver)); + strlcpy(info->version, DRV_VERSION, sizeof(info->version)); + strlcpy(info->bus_info, pci_name(np->pci_dev), sizeof(info->bus_info)); } static const struct ethtool_ops ethtool_ops = { diff --git a/drivers/net/ethernet/rdc/r6040.c b/drivers/net/ethernet/rdc/r6040.c index 63c1312..ba0be4b 100644 --- a/drivers/net/ethernet/rdc/r6040.c +++ b/drivers/net/ethernet/rdc/r6040.c @@ -957,9 +957,9 @@ static void netdev_get_drvinfo(struct net_device *dev, { struct r6040_private *rp = netdev_priv(dev); - strcpy(info->driver, DRV_NAME); - strcpy(info->version, DRV_VERSION); - strcpy(info->bus_info, pci_name(rp->pdev)); + strlcpy(info->driver, DRV_NAME, sizeof(info->driver)); + strlcpy(info->version, DRV_VERSION, sizeof(info->version)); + strlcpy(info->bus_info, pci_name(rp->pdev), sizeof(info->bus_info)); } static int netdev_get_settings(struct net_device *dev, struct ethtool_cmd *cmd) diff --git a/drivers/net/ethernet/sgi/ioc3-eth.c b/drivers/net/ethernet/sgi/ioc3-eth.c index dc171b4..7ed08c3 100644 --- a/drivers/net/ethernet/sgi/ioc3-eth.c +++ b/drivers/net/ethernet/sgi/ioc3-eth.c @@ -1565,9 +1565,9 @@ static void ioc3_get_drvinfo (struct net_device *dev, { struct ioc3_private *ip = netdev_priv(dev); - strcpy (info->driver, IOC3_NAME); - strcpy (info->version, IOC3_VERSION); - strcpy (info->bus_info, pci_name(ip->pdev)); + strlcpy(info->driver, IOC3_NAME, sizeof(info->driver)); + strlcpy(info->version, IOC3_VERSION, sizeof(info->version)); + strlcpy(info->bus_info, pci_name(ip->pdev), sizeof(info->bus_info)); } static int ioc3_get_settings(struct net_device *dev, struct ethtool_cmd *cmd) diff --git a/drivers/net/ethernet/smsc/smc911x.c b/drivers/net/ethernet/smsc/smc911x.c index 59a6f88..1538d54 100644 --- a/drivers/net/ethernet/smsc/smc911x.c +++ b/drivers/net/ethernet/smsc/smc911x.c @@ -1522,9 +1522,10 @@ smc911x_ethtool_setsettings(struct net_device *dev, struct ethtool_cmd *cmd) static void smc911x_ethtool_getdrvinfo(struct net_device *dev, struct ethtool_drvinfo *info) { - strncpy(info->driver, CARDNAME, sizeof(info->driver)); - strncpy(info->version, version, sizeof(info->version)); - strncpy(info->bus_info, dev_name(dev->dev.parent), sizeof(info->bus_info)); + strlcpy(info->driver, CARDNAME, sizeof(info->driver)); + strlcpy(info->version, version, sizeof(info->version)); + strlcpy(info->bus_info, dev_name(dev->dev.parent), + sizeof(info->bus_info)); } static int smc911x_ethtool_nwayreset(struct net_device *dev) diff --git a/drivers/net/ethernet/smsc/smc91x.c b/drivers/net/ethernet/smsc/smc91x.c index a670d23..591650a 100644 --- a/drivers/net/ethernet/smsc/smc91x.c +++ b/drivers/net/ethernet/smsc/smc91x.c @@ -1597,9 +1597,10 @@ smc_ethtool_setsettings(struct net_device *dev, struct ethtool_cmd *cmd) static void smc_ethtool_getdrvinfo(struct net_device *dev, struct ethtool_drvinfo *info) { - strncpy(info->driver, CARDNAME, sizeof(info->driver)); - strncpy(info->version, version, sizeof(info->version)); - strncpy(info->bus_info, dev_name(dev->dev.parent), sizeof(info->bus_info)); + strlcpy(info->driver, CARDNAME, sizeof(info->driver)); + strlcpy(info->version, version, sizeof(info->version)); + strlcpy(info->bus_info, dev_name(dev->dev.parent), + sizeof(info->bus_info)); } static int smc_ethtool_nwayreset(struct net_device *dev) diff --git a/drivers/net/ethernet/stmicro/stmmac/stmmac_ethtool.c b/drivers/net/ethernet/stmicro/stmmac/stmmac_ethtool.c index 1372ce2..d1ac39c 100644 --- a/drivers/net/ethernet/stmicro/stmmac/stmmac_ethtool.c +++ b/drivers/net/ethernet/stmicro/stmmac/stmmac_ethtool.c @@ -210,8 +210,7 @@ static void stmmac_ethtool_getdrvinfo(struct net_device *dev, strlcpy(info->driver, MAC100_ETHTOOL_NAME, sizeof(info->driver)); - strcpy(info->version, DRV_MODULE_VERSION); - info->fw_version[0] = '\0'; + strlcpy(info->version, DRV_MODULE_VERSION, sizeof(info->version)); } static int stmmac_ethtool_getsettings(struct net_device *dev, diff --git a/drivers/net/ethernet/sun/sunbmac.c b/drivers/net/ethernet/sun/sunbmac.c index be82f6d..5fafca0 100644 --- a/drivers/net/ethernet/sun/sunbmac.c +++ b/drivers/net/ethernet/sun/sunbmac.c @@ -1042,8 +1042,8 @@ static void bigmac_set_multicast(struct net_device *dev) /* Ethtool support... */ static void bigmac_get_drvinfo(struct net_device *dev, struct ethtool_drvinfo *info) { - strcpy(info->driver, "sunbmac"); - strcpy(info->version, "2.0"); + strlcpy(info->driver, "sunbmac", sizeof(info->driver)); + strlcpy(info->version, "2.0", sizeof(info->version)); } static u32 bigmac_get_link(struct net_device *dev) diff --git a/drivers/net/ethernet/sun/sunqe.c b/drivers/net/ethernet/sun/sunqe.c index 1dcee69..49bf3e2 100644 --- a/drivers/net/ethernet/sun/sunqe.c +++ b/drivers/net/ethernet/sun/sunqe.c @@ -685,13 +685,14 @@ static void qe_get_drvinfo(struct net_device *dev, struct ethtool_drvinfo *info) struct sunqe *qep = netdev_priv(dev); struct platform_device *op; - strcpy(info->driver, "sunqe"); - strcpy(info->version, "3.0"); + strlcpy(info->driver, "sunqe", sizeof(info->driver)); + strlcpy(info->version, "3.0", sizeof(info->version)); op = qep->op; regs = of_get_property(op->dev.of_node, "reg", NULL); if (regs) - sprintf(info->bus_info, "SBUS:%d", regs->which_io); + snprintf(info->bus_info, sizeof(info->bus_info), "SBUS:%d", + regs->which_io); } diff --git a/drivers/net/ethernet/sun/sunvnet.c b/drivers/net/ethernet/sun/sunvnet.c index e1b8955..1cf767e 100644 --- a/drivers/net/ethernet/sun/sunvnet.c +++ b/drivers/net/ethernet/sun/sunvnet.c @@ -882,8 +882,8 @@ static int vnet_set_mac_addr(struct net_device *dev, void *p) static void vnet_get_drvinfo(struct net_device *dev, struct ethtool_drvinfo *info) { - strcpy(info->driver, DRV_MODULE_NAME); - strcpy(info->version, DRV_MODULE_VERSION); + strlcpy(info->driver, DRV_MODULE_NAME, sizeof(info->driver)); + strlcpy(info->version, DRV_MODULE_VERSION, sizeof(info->version)); } static u32 vnet_get_msglevel(struct net_device *dev) diff --git a/drivers/net/ethernet/tehuti/tehuti.c b/drivers/net/ethernet/tehuti/tehuti.c index 1e4d743..e15cc71 100644 --- a/drivers/net/ethernet/tehuti/tehuti.c +++ b/drivers/net/ethernet/tehuti/tehuti.c @@ -2179,10 +2179,10 @@ bdx_get_drvinfo(struct net_device *netdev, struct ethtool_drvinfo *drvinfo) { struct bdx_priv *priv = netdev_priv(netdev); - strlcat(drvinfo->driver, BDX_DRV_NAME, sizeof(drvinfo->driver)); - strlcat(drvinfo->version, BDX_DRV_VERSION, sizeof(drvinfo->version)); - strlcat(drvinfo->fw_version, "N/A", sizeof(drvinfo->fw_version)); - strlcat(drvinfo->bus_info, pci_name(priv->pdev), + strlcpy(drvinfo->driver, BDX_DRV_NAME, sizeof(drvinfo->driver)); + strlcpy(drvinfo->version, BDX_DRV_VERSION, sizeof(drvinfo->version)); + strlcpy(drvinfo->fw_version, "N/A", sizeof(drvinfo->fw_version)); + strlcpy(drvinfo->bus_info, pci_name(priv->pdev), sizeof(drvinfo->bus_info)); drvinfo->n_stats = ((priv->stats_flag) ? ARRAY_SIZE(bdx_stat_names) : 0); diff --git a/drivers/net/ethernet/ti/cpmac.c b/drivers/net/ethernet/ti/cpmac.c index d9625f6..70d1920 100644 --- a/drivers/net/ethernet/ti/cpmac.c +++ b/drivers/net/ethernet/ti/cpmac.c @@ -904,10 +904,9 @@ static int cpmac_set_ringparam(struct net_device *dev, static void cpmac_get_drvinfo(struct net_device *dev, struct ethtool_drvinfo *info) { - strcpy(info->driver, "cpmac"); - strcpy(info->version, CPMAC_VERSION); - info->fw_version[0] = '\0'; - sprintf(info->bus_info, "%s", "cpmac"); + strlcpy(info->driver, "cpmac", sizeof(info->driver)); + strlcpy(info->version, CPMAC_VERSION, sizeof(info->version)); + snprintf(info->bus_info, sizeof(info->bus_info), "%s", "cpmac"); info->regdump_len = 0; } diff --git a/drivers/net/ethernet/ti/cpsw.c b/drivers/net/ethernet/ti/cpsw.c index 40aff68..bea736b 100644 --- a/drivers/net/ethernet/ti/cpsw.c +++ b/drivers/net/ethernet/ti/cpsw.c @@ -944,9 +944,10 @@ static void cpsw_get_drvinfo(struct net_device *ndev, struct ethtool_drvinfo *info) { struct cpsw_priv *priv = netdev_priv(ndev); - strcpy(info->driver, "TI CPSW Driver v1.0"); - strcpy(info->version, "1.0"); - strcpy(info->bus_info, priv->pdev->name); + + strlcpy(info->driver, "TI CPSW Driver v1.0", sizeof(info->driver)); + strlcpy(info->version, "1.0", sizeof(info->version)); + strlcpy(info->bus_info, priv->pdev->name, sizeof(info->bus_info)); } static u32 cpsw_get_msglevel(struct net_device *ndev) diff --git a/drivers/net/ethernet/ti/davinci_emac.c b/drivers/net/ethernet/ti/davinci_emac.c index 6841a22..6621ae3 100644 --- a/drivers/net/ethernet/ti/davinci_emac.c +++ b/drivers/net/ethernet/ti/davinci_emac.c @@ -480,8 +480,8 @@ static void emac_dump_regs(struct emac_priv *priv) static void emac_get_drvinfo(struct net_device *ndev, struct ethtool_drvinfo *info) { - strcpy(info->driver, emac_version_string); - strcpy(info->version, EMAC_MODULE_VERSION); + strlcpy(info->driver, emac_version_string, sizeof(info->driver)); + strlcpy(info->version, EMAC_MODULE_VERSION, sizeof(info->version)); } /** diff --git a/drivers/net/ethernet/toshiba/ps3_gelic_net.c b/drivers/net/ethernet/toshiba/ps3_gelic_net.c index e321d0b..445c059 100644 --- a/drivers/net/ethernet/toshiba/ps3_gelic_net.c +++ b/drivers/net/ethernet/toshiba/ps3_gelic_net.c @@ -1226,8 +1226,8 @@ int gelic_net_open(struct net_device *netdev) void gelic_net_get_drvinfo(struct net_device *netdev, struct ethtool_drvinfo *info) { - strncpy(info->driver, DRV_NAME, sizeof(info->driver) - 1); - strncpy(info->version, DRV_VERSION, sizeof(info->version) - 1); + strlcpy(info->driver, DRV_NAME, sizeof(info->driver)); + strlcpy(info->version, DRV_VERSION, sizeof(info->version)); } static int gelic_ether_get_settings(struct net_device *netdev, diff --git a/drivers/net/ethernet/toshiba/spider_net_ethtool.c b/drivers/net/ethernet/toshiba/spider_net_ethtool.c index 9c288cd..ffe5193 100644 --- a/drivers/net/ethernet/toshiba/spider_net_ethtool.c +++ b/drivers/net/ethernet/toshiba/spider_net_ethtool.c @@ -72,11 +72,13 @@ spider_net_ethtool_get_drvinfo(struct net_device *netdev, card = netdev_priv(netdev); /* clear and fill out info */ - memset(drvinfo, 0, sizeof(struct ethtool_drvinfo)); - strncpy(drvinfo->driver, spider_net_driver_name, 32); - strncpy(drvinfo->version, VERSION, 32); - strcpy(drvinfo->fw_version, "no information"); - strncpy(drvinfo->bus_info, pci_name(card->pdev), 32); + strlcpy(drvinfo->driver, spider_net_driver_name, + sizeof(drvinfo->driver)); + strlcpy(drvinfo->version, VERSION, sizeof(drvinfo->version)); + strlcpy(drvinfo->fw_version, "no information", + sizeof(drvinfo->fw_version)); + strlcpy(drvinfo->bus_info, pci_name(card->pdev), + sizeof(drvinfo->bus_info)); } static void diff --git a/drivers/net/ethernet/toshiba/tc35815.c b/drivers/net/ethernet/toshiba/tc35815.c index 9819349..23a789e 100644 --- a/drivers/net/ethernet/toshiba/tc35815.c +++ b/drivers/net/ethernet/toshiba/tc35815.c @@ -1976,9 +1976,10 @@ tc35815_set_multicast_list(struct net_device *dev) static void tc35815_get_drvinfo(struct net_device *dev, struct ethtool_drvinfo *info) { struct tc35815_local *lp = netdev_priv(dev); - strcpy(info->driver, MODNAME); - strcpy(info->version, DRV_VERSION); - strcpy(info->bus_info, pci_name(lp->pci_dev)); + + strlcpy(info->driver, MODNAME, sizeof(info->driver)); + strlcpy(info->version, DRV_VERSION, sizeof(info->version)); + strlcpy(info->bus_info, pci_name(lp->pci_dev), sizeof(info->bus_info)); } static int tc35815_get_settings(struct net_device *dev, struct ethtool_cmd *cmd) diff --git a/drivers/net/ethernet/xilinx/xilinx_axienet_main.c b/drivers/net/ethernet/xilinx/xilinx_axienet_main.c index d9f69b8..d3b3571 100644 --- a/drivers/net/ethernet/xilinx/xilinx_axienet_main.c +++ b/drivers/net/ethernet/xilinx/xilinx_axienet_main.c @@ -1124,9 +1124,8 @@ static int axienet_ethtools_set_settings(struct net_device *ndev, static void axienet_ethtools_get_drvinfo(struct net_device *ndev, struct ethtool_drvinfo *ed) { - memset(ed, 0, sizeof(struct ethtool_drvinfo)); - strcpy(ed->driver, DRIVER_NAME); - strcpy(ed->version, DRIVER_VERSION); + strlcpy(ed->driver, DRIVER_NAME, sizeof(ed->driver)); + strlcpy(ed->version, DRIVER_VERSION, sizeof(ed->version)); ed->regdump_len = sizeof(u32) * AXIENET_REGS_N; } diff --git a/drivers/net/ethernet/xircom/xirc2ps_cs.c b/drivers/net/ethernet/xircom/xirc2ps_cs.c index 94a1f94..98e09d0 100644 --- a/drivers/net/ethernet/xircom/xirc2ps_cs.c +++ b/drivers/net/ethernet/xircom/xirc2ps_cs.c @@ -1412,7 +1412,8 @@ static void netdev_get_drvinfo(struct net_device *dev, struct ethtool_drvinfo *info) { strlcpy(info->driver, "xirc2ps_cs", sizeof(info->driver)); - sprintf(info->bus_info, "PCMCIA 0x%lx", dev->base_addr); + snprintf(info->bus_info, sizeof(info->bus_info), "PCMCIA 0x%lx", + dev->base_addr); } static const struct ethtool_ops netdev_ethtool_ops = { diff --git a/drivers/net/ethernet/xscale/ixp4xx_eth.c b/drivers/net/ethernet/xscale/ixp4xx_eth.c index d3ebb73..a4be1ad 100644 --- a/drivers/net/ethernet/xscale/ixp4xx_eth.c +++ b/drivers/net/ethernet/xscale/ixp4xx_eth.c @@ -977,11 +977,12 @@ static void ixp4xx_get_drvinfo(struct net_device *dev, struct ethtool_drvinfo *info) { struct port *port = netdev_priv(dev); - strcpy(info->driver, DRV_NAME); + + strlcpy(info->driver, DRV_NAME, sizeof(info->driver)); snprintf(info->fw_version, sizeof(info->fw_version), "%u:%u:%u:%u", port->firmware[0], port->firmware[1], port->firmware[2], port->firmware[3]); - strcpy(info->bus_info, "internal"); + strlcpy(info->bus_info, "internal", sizeof(info->bus_info)); } static int ixp4xx_get_settings(struct net_device *dev, struct ethtool_cmd *cmd) diff --git a/drivers/net/hyperv/netvsc_drv.c b/drivers/net/hyperv/netvsc_drv.c index f825a62..a9975c7 100644 --- a/drivers/net/hyperv/netvsc_drv.c +++ b/drivers/net/hyperv/netvsc_drv.c @@ -304,9 +304,9 @@ int netvsc_recv_callback(struct hv_device *device_obj, static void netvsc_get_drvinfo(struct net_device *net, struct ethtool_drvinfo *info) { - strcpy(info->driver, KBUILD_MODNAME); - strcpy(info->version, HV_DRV_VERSION); - strcpy(info->fw_version, "N/A"); + strlcpy(info->driver, KBUILD_MODNAME, sizeof(info->driver)); + strlcpy(info->version, HV_DRV_VERSION, sizeof(info->version)); + strlcpy(info->fw_version, "N/A", sizeof(info->fw_version)); } static int netvsc_change_mtu(struct net_device *ndev, int mtu) diff --git a/drivers/net/macvlan.c b/drivers/net/macvlan.c index 0ae4518..1047e58 100644 --- a/drivers/net/macvlan.c +++ b/drivers/net/macvlan.c @@ -585,8 +585,8 @@ static int macvlan_fdb_del(struct ndmsg *ndm, static void macvlan_ethtool_get_drvinfo(struct net_device *dev, struct ethtool_drvinfo *drvinfo) { - snprintf(drvinfo->driver, 32, "macvlan"); - snprintf(drvinfo->version, 32, "0.1"); + strlcpy(drvinfo->driver, "macvlan", sizeof(drvinfo->driver)); + strlcpy(drvinfo->version, "0.1", sizeof(drvinfo->version)); } static int macvlan_ethtool_get_settings(struct net_device *dev, diff --git a/drivers/net/rionet.c b/drivers/net/rionet.c index d8b9b1e..f433b59 100644 --- a/drivers/net/rionet.c +++ b/drivers/net/rionet.c @@ -410,10 +410,10 @@ static void rionet_get_drvinfo(struct net_device *ndev, { struct rionet_private *rnet = netdev_priv(ndev); - strcpy(info->driver, DRV_NAME); - strcpy(info->version, DRV_VERSION); - strcpy(info->fw_version, "n/a"); - strcpy(info->bus_info, rnet->mport->name); + strlcpy(info->driver, DRV_NAME, sizeof(info->driver)); + strlcpy(info->version, DRV_VERSION, sizeof(info->version)); + strlcpy(info->fw_version, "n/a", sizeof(info->fw_version)); + strlcpy(info->bus_info, rnet->mport->name, sizeof(info->bus_info)); } static u32 rionet_get_msglevel(struct net_device *ndev) diff --git a/drivers/net/usb/asix_common.c b/drivers/net/usb/asix_common.c index 50d1673..19bc23f 100644 --- a/drivers/net/usb/asix_common.c +++ b/drivers/net/usb/asix_common.c @@ -510,8 +510,8 @@ void asix_get_drvinfo(struct net_device *net, struct ethtool_drvinfo *info) { /* Inherit standard device info */ usbnet_get_drvinfo(net, info); - strncpy (info->driver, DRIVER_NAME, sizeof info->driver); - strncpy (info->version, DRIVER_VERSION, sizeof info->version); + strlcpy(info->driver, DRIVER_NAME, sizeof(info->driver)); + strlcpy(info->version, DRIVER_VERSION, sizeof(info->version)); info->eedump_len = AX_EEPROM_LEN; } diff --git a/drivers/net/usb/catc.c b/drivers/net/usb/catc.c index 18d9579..8d5cac2 100644 --- a/drivers/net/usb/catc.c +++ b/drivers/net/usb/catc.c @@ -685,9 +685,9 @@ static void catc_get_drvinfo(struct net_device *dev, struct ethtool_drvinfo *info) { struct catc *catc = netdev_priv(dev); - strncpy(info->driver, driver_name, ETHTOOL_BUSINFO_LEN); - strncpy(info->version, DRIVER_VERSION, ETHTOOL_BUSINFO_LEN); - usb_make_path (catc->usbdev, info->bus_info, sizeof info->bus_info); + strlcpy(info->driver, driver_name, sizeof(info->driver)); + strlcpy(info->version, DRIVER_VERSION, sizeof(info->version)); + usb_make_path(catc->usbdev, info->bus_info, sizeof(info->bus_info)); } static int catc_get_settings(struct net_device *dev, struct ethtool_cmd *cmd) diff --git a/drivers/net/usb/cdc_ncm.c b/drivers/net/usb/cdc_ncm.c index 71b6e92..016aa6f 100644 --- a/drivers/net/usb/cdc_ncm.c +++ b/drivers/net/usb/cdc_ncm.c @@ -65,9 +65,9 @@ cdc_ncm_get_drvinfo(struct net_device *net, struct ethtool_drvinfo *info) { struct usbnet *dev = netdev_priv(net); - strncpy(info->driver, dev->driver_name, sizeof(info->driver)); - strncpy(info->version, DRIVER_VERSION, sizeof(info->version)); - strncpy(info->fw_version, dev->driver_info->description, + strlcpy(info->driver, dev->driver_name, sizeof(info->driver)); + strlcpy(info->version, DRIVER_VERSION, sizeof(info->version)); + strlcpy(info->fw_version, dev->driver_info->description, sizeof(info->fw_version)); usb_make_path(dev->udev, info->bus_info, sizeof(info->bus_info)); } diff --git a/drivers/net/usb/pegasus.c b/drivers/net/usb/pegasus.c index a0b5807..3c02f95 100644 --- a/drivers/net/usb/pegasus.c +++ b/drivers/net/usb/pegasus.c @@ -1074,8 +1074,9 @@ static void pegasus_get_drvinfo(struct net_device *dev, struct ethtool_drvinfo *info) { pegasus_t *pegasus = netdev_priv(dev); - strncpy(info->driver, driver_name, sizeof(info->driver) - 1); - strncpy(info->version, DRIVER_VERSION, sizeof(info->version) - 1); + + strlcpy(info->driver, driver_name, sizeof(info->driver)); + strlcpy(info->version, DRIVER_VERSION, sizeof(info->version)); usb_make_path(pegasus->usb, info->bus_info, sizeof(info->bus_info)); } diff --git a/drivers/net/usb/rtl8150.c b/drivers/net/usb/rtl8150.c index 5f39a3b..a491d3a 100644 --- a/drivers/net/usb/rtl8150.c +++ b/drivers/net/usb/rtl8150.c @@ -776,9 +776,9 @@ static void rtl8150_get_drvinfo(struct net_device *netdev, struct ethtool_drvinf { rtl8150_t *dev = netdev_priv(netdev); - strncpy(info->driver, driver_name, ETHTOOL_BUSINFO_LEN); - strncpy(info->version, DRIVER_VERSION, ETHTOOL_BUSINFO_LEN); - usb_make_path(dev->udev, info->bus_info, sizeof info->bus_info); + strlcpy(info->driver, driver_name, sizeof(info->driver)); + strlcpy(info->version, DRIVER_VERSION, sizeof(info->version)); + usb_make_path(dev->udev, info->bus_info, sizeof(info->bus_info)); } static int rtl8150_get_settings(struct net_device *netdev, struct ethtool_cmd *ecmd) diff --git a/drivers/net/usb/sierra_net.c b/drivers/net/usb/sierra_net.c index 18dd425..453aa6c 100644 --- a/drivers/net/usb/sierra_net.c +++ b/drivers/net/usb/sierra_net.c @@ -598,8 +598,8 @@ static void sierra_net_get_drvinfo(struct net_device *net, { /* Inherit standard device info */ usbnet_get_drvinfo(net, info); - strncpy(info->driver, driver_name, sizeof info->driver); - strncpy(info->version, DRIVER_VERSION, sizeof info->version); + strlcpy(info->driver, driver_name, sizeof(info->driver)); + strlcpy(info->version, DRIVER_VERSION, sizeof(info->version)); } static u32 sierra_net_get_link(struct net_device *net) diff --git a/drivers/net/vmxnet3/vmxnet3_ethtool.c b/drivers/net/vmxnet3/vmxnet3_ethtool.c index 587a218..8c9fa4b 100644 --- a/drivers/net/vmxnet3/vmxnet3_ethtool.c +++ b/drivers/net/vmxnet3/vmxnet3_ethtool.c @@ -207,7 +207,7 @@ vmxnet3_get_drvinfo(struct net_device *netdev, struct ethtool_drvinfo *drvinfo) sizeof(drvinfo->version)); strlcpy(drvinfo->bus_info, pci_name(adapter->pdev), - ETHTOOL_BUSINFO_LEN); + sizeof(drvinfo->bus_info)); drvinfo->n_stats = vmxnet3_get_sset_count(netdev, ETH_SS_STATS); drvinfo->testinfo_len = 0; drvinfo->eedump_len = 0; diff --git a/drivers/net/wimax/i2400m/netdev.c b/drivers/net/wimax/i2400m/netdev.c index 1d76ae8..cedd4d3 100644 --- a/drivers/net/wimax/i2400m/netdev.c +++ b/drivers/net/wimax/i2400m/netdev.c @@ -596,12 +596,12 @@ static void i2400m_get_drvinfo(struct net_device *net_dev, { struct i2400m *i2400m = net_dev_to_i2400m(net_dev); - strncpy(info->driver, KBUILD_MODNAME, sizeof(info->driver) - 1); - strncpy(info->fw_version, - i2400m->fw_name ? : "", sizeof(info->fw_version) - 1); + strlcpy(info->driver, KBUILD_MODNAME, sizeof(info->driver)); + strlcpy(info->fw_version, i2400m->fw_name ? : "", + sizeof(info->fw_version)); if (net_dev->dev.parent) - strncpy(info->bus_info, dev_name(net_dev->dev.parent), - sizeof(info->bus_info) - 1); + strlcpy(info->bus_info, dev_name(net_dev->dev.parent), + sizeof(info->bus_info)); } static const struct ethtool_ops i2400m_ethtool_ops = { diff --git a/drivers/net/wimax/i2400m/usb.c b/drivers/net/wimax/i2400m/usb.c index 080f363..cd15a93 100644 --- a/drivers/net/wimax/i2400m/usb.c +++ b/drivers/net/wimax/i2400m/usb.c @@ -346,9 +346,9 @@ static void i2400mu_get_drvinfo(struct net_device *net_dev, struct i2400mu *i2400mu = container_of(i2400m, struct i2400mu, i2400m); struct usb_device *udev = i2400mu->usb_dev; - strncpy(info->driver, KBUILD_MODNAME, sizeof(info->driver) - 1); - strncpy(info->fw_version, - i2400m->fw_name ? : "", sizeof(info->fw_version) - 1); + strlcpy(info->driver, KBUILD_MODNAME, sizeof(info->driver)); + strlcpy(info->fw_version, i2400m->fw_name ? : "", + sizeof(info->fw_version)); usb_make_path(udev, info->bus_info, sizeof(info->bus_info)); } diff --git a/drivers/net/wireless/brcm80211/brcmfmac/dhd_linux.c b/drivers/net/wireless/brcm80211/brcmfmac/dhd_linux.c index 74a616b..8c28a15 100644 --- a/drivers/net/wireless/brcm80211/brcmfmac/dhd_linux.c +++ b/drivers/net/wireless/brcm80211/brcmfmac/dhd_linux.c @@ -395,9 +395,11 @@ static void brcmf_ethtool_get_drvinfo(struct net_device *ndev, struct brcmf_if *ifp = netdev_priv(ndev); struct brcmf_pub *drvr = ifp->drvr; - sprintf(info->driver, KBUILD_MODNAME); - sprintf(info->version, "%lu", drvr->drv_version); - sprintf(info->bus_info, "%s", dev_name(drvr->bus_if->dev)); + strlcpy(info->driver, KBUILD_MODNAME, sizeof(info->driver)); + snprintf(info->version, sizeof(info->version), "%lu", + drvr->drv_version); + strlcpy(info->bus_info, dev_name(drvr->bus_if->dev), + sizeof(info->bus_info)); } static const struct ethtool_ops brcmf_ethtool_ops = { diff --git a/drivers/s390/net/qeth_core_main.c b/drivers/s390/net/qeth_core_main.c index 638a57f..029a7ac 100644 --- a/drivers/s390/net/qeth_core_main.c +++ b/drivers/s390/net/qeth_core_main.c @@ -5444,17 +5444,14 @@ void qeth_core_get_drvinfo(struct net_device *dev, struct ethtool_drvinfo *info) { struct qeth_card *card = dev->ml_priv; - if (card->options.layer2) - strcpy(info->driver, "qeth_l2"); - else - strcpy(info->driver, "qeth_l3"); - - strcpy(info->version, "1.0"); - strcpy(info->fw_version, card->info.mcl_level); - sprintf(info->bus_info, "%s/%s/%s", - CARD_RDEV_ID(card), - CARD_WDEV_ID(card), - CARD_DDEV_ID(card)); + + strlcpy(info->driver, card->options.layer2 ? "qeth_l2" : "qeth_l3", + sizeof(info->driver)); + strlcpy(info->version, "1.0", sizeof(info->version)); + strlcpy(info->fw_version, card->info.mcl_level, + sizeof(info->fw_version)); + snprintf(info->bus_info, sizeof(info->bus_info), "%s/%s/%s", + CARD_RDEV_ID(card), CARD_WDEV_ID(card), CARD_DDEV_ID(card)); } EXPORT_SYMBOL_GPL(qeth_core_get_drvinfo); diff --git a/drivers/staging/bcm/Bcmnet.c b/drivers/staging/bcm/Bcmnet.c index a3b91c7..4e470d4 100644 --- a/drivers/staging/bcm/Bcmnet.c +++ b/drivers/staging/bcm/Bcmnet.c @@ -145,8 +145,8 @@ static void bcm_get_drvinfo(struct net_device *dev, struct bcm_interface_adapter *psIntfAdapter = Adapter->pvInterfaceAdapter; struct usb_device *udev = interface_to_usbdev(psIntfAdapter->interface); - strcpy(info->driver, DRV_NAME); - strcpy(info->version, DRV_VERSION); + strlcpy(info->driver, DRV_NAME, sizeof(info->driver)); + strlcpy(info->version, DRV_VERSION, sizeof(info->version)); snprintf(info->fw_version, sizeof(info->fw_version), "%u.%u", Adapter->uiFlashLayoutMajorVersion, Adapter->uiFlashLayoutMinorVersion); diff --git a/drivers/staging/ccg/u_ether.c b/drivers/staging/ccg/u_ether.c index d0dabcf..fed7886 100644 --- a/drivers/staging/ccg/u_ether.c +++ b/drivers/staging/ccg/u_ether.c @@ -157,12 +157,12 @@ static int ueth_change_mtu(struct net_device *net, int new_mtu) static void eth_get_drvinfo(struct net_device *net, struct ethtool_drvinfo *p) { - struct eth_dev *dev = netdev_priv(net); + struct eth_dev *dev = netdev_priv(net); - strlcpy(p->driver, "g_ether", sizeof p->driver); - strlcpy(p->version, UETH__VERSION, sizeof p->version); - strlcpy(p->fw_version, dev->gadget->name, sizeof p->fw_version); - strlcpy(p->bus_info, dev_name(&dev->gadget->dev), sizeof p->bus_info); + strlcpy(p->driver, "g_ether", sizeof(p->driver)); + strlcpy(p->version, UETH__VERSION, sizeof(p->version)); + strlcpy(p->fw_version, dev->gadget->name, sizeof(p->fw_version)); + strlcpy(p->bus_info, dev_name(&dev->gadget->dev), sizeof(p->bus_info)); } /* REVISIT can also support: diff --git a/drivers/staging/et131x/et131x.c b/drivers/staging/et131x/et131x.c index 84bbcd4..f15059c 100644 --- a/drivers/staging/et131x/et131x.c +++ b/drivers/staging/et131x/et131x.c @@ -3560,15 +3560,15 @@ static void et131x_get_regs(struct net_device *netdev, regs_buff[num++] = readl(&aregs->rxdma.fbr1_min_des); } -#define ET131X_DRVINFO_LEN 32 /* value from ethtool.h */ static void et131x_get_drvinfo(struct net_device *netdev, struct ethtool_drvinfo *info) { struct et131x_adapter *adapter = netdev_priv(netdev); - strncpy(info->driver, DRIVER_NAME, ET131X_DRVINFO_LEN); - strncpy(info->version, DRIVER_VERSION, ET131X_DRVINFO_LEN); - strncpy(info->bus_info, pci_name(adapter->pdev), ET131X_DRVINFO_LEN); + strlcpy(info->driver, DRIVER_NAME, sizeof(info->driver)); + strlcpy(info->version, DRIVER_VERSION, sizeof(info->version)); + strlcpy(info->bus_info, pci_name(adapter->pdev), + sizeof(info->bus_info)); } static struct ethtool_ops et131x_ethtool_ops = { diff --git a/drivers/staging/ft1000/ft1000-pcmcia/ft1000_hw.c b/drivers/staging/ft1000/ft1000-pcmcia/ft1000_hw.c index 86a680c..67ca5c9 100644 --- a/drivers/staging/ft1000/ft1000-pcmcia/ft1000_hw.c +++ b/drivers/staging/ft1000/ft1000-pcmcia/ft1000_hw.c @@ -2077,11 +2077,12 @@ static void ft1000_get_drvinfo(struct net_device *dev, struct ft1000_info *ft_info; ft_info = netdev_priv(dev); - snprintf(info->driver, 32, "ft1000"); - snprintf(info->bus_info, ETHTOOL_BUSINFO_LEN, "PCMCIA 0x%lx", + strlcpy(info->driver, "ft1000", sizeof(info->driver)); + snprintf(info->bus_info, sizeof(info->bus_info), "PCMCIA 0x%lx", dev->base_addr); - snprintf(info->fw_version, 32, "%d.%d.%d.%d", ft_info->DspVer[0], - ft_info->DspVer[1], ft_info->DspVer[2], ft_info->DspVer[3]); + snprintf(info->fw_version, sizeof(info->fw_version), "%d.%d.%d.%d", + ft_info->DspVer[0], ft_info->DspVer[1], ft_info->DspVer[2], + ft_info->DspVer[3]); } static u32 ft1000_get_link(struct net_device *dev) diff --git a/drivers/staging/octeon/ethernet-mdio.c b/drivers/staging/octeon/ethernet-mdio.c index f15b31b..83b1030 100644 --- a/drivers/staging/octeon/ethernet-mdio.c +++ b/drivers/staging/octeon/ethernet-mdio.c @@ -46,9 +46,9 @@ static void cvm_oct_get_drvinfo(struct net_device *dev, struct ethtool_drvinfo *info) { - strcpy(info->driver, "cavium-ethernet"); - strcpy(info->version, OCTEON_ETHERNET_VERSION); - strcpy(info->bus_info, "Builtin"); + strlcpy(info->driver, "cavium-ethernet", sizeof(info->driver)); + strlcpy(info->version, OCTEON_ETHERNET_VERSION, sizeof(info->version)); + strlcpy(info->bus_info, "Builtin", sizeof(info->bus_info)); } static int cvm_oct_get_settings(struct net_device *dev, struct ethtool_cmd *cmd) diff --git a/drivers/staging/rtl8192e/rtl8192e/rtl_ethtool.c b/drivers/staging/rtl8192e/rtl8192e/rtl_ethtool.c index 36452fb..0cfb3ec 100644 --- a/drivers/staging/rtl8192e/rtl8192e/rtl_ethtool.c +++ b/drivers/staging/rtl8192e/rtl8192e/rtl_ethtool.c @@ -34,9 +34,9 @@ static void rtl819x_ethtool_get_drvinfo(struct net_device *dev, { struct r8192_priv *priv = rtllib_priv(dev); - strcpy(info->driver, DRV_NAME); - strcpy(info->version, DRV_VERSION); - strcpy(info->bus_info, pci_name(priv->pdev)); + strlcpy(info->driver, DRV_NAME, sizeof(info->driver)); + strlcpy(info->version, DRV_VERSION, sizeof(info->version)); + strlcpy(info->bus_info, pci_name(priv->pdev), sizeof(info->bus_info)); } static u32 rtl819x_ethtool_get_link(struct net_device *dev) diff --git a/drivers/staging/wlags49_h2/wl_netdev.c b/drivers/staging/wlags49_h2/wl_netdev.c index fb42140..235cc2a 100644 --- a/drivers/staging/wlags49_h2/wl_netdev.c +++ b/drivers/staging/wlags49_h2/wl_netdev.c @@ -457,17 +457,17 @@ int wl_close( struct net_device *dev ) static void wl_get_drvinfo(struct net_device *dev, struct ethtool_drvinfo *info) { - strncpy(info->driver, DRIVER_NAME, sizeof(info->driver) - 1); - strncpy(info->version, DRV_VERSION_STR, sizeof(info->version) - 1); -// strncpy(info.fw_version, priv->fw_name, -// sizeof(info.fw_version) - 1); + strlcpy(info->driver, DRIVER_NAME, sizeof(info->driver)); + strlcpy(info->version, DRV_VERSION_STR, sizeof(info->version)); +// strlcpy(info.fw_version, priv->fw_name, +// sizeof(info.fw_version)); if (dev->dev.parent) { dev_set_name(dev->dev.parent, "%s", info->bus_info); - //strncpy(info->bus_info, dev->dev.parent->bus_id, - // sizeof(info->bus_info) - 1); + //strlcpy(info->bus_info, dev->dev.parent->bus_id, + // sizeof(info->bus_info)); } else { - snprintf(info->bus_info, sizeof(info->bus_info) - 1, + snprintf(info->bus_info, sizeof(info->bus_info), "PCMCIA FIXME"); // "PCMCIA 0x%lx", priv->hw.iobase); } diff --git a/drivers/usb/gadget/u_ether.c b/drivers/usb/gadget/u_ether.c index 4ec3c0d..a0aa721 100644 --- a/drivers/usb/gadget/u_ether.c +++ b/drivers/usb/gadget/u_ether.c @@ -159,12 +159,12 @@ static int ueth_change_mtu(struct net_device *net, int new_mtu) static void eth_get_drvinfo(struct net_device *net, struct ethtool_drvinfo *p) { - struct eth_dev *dev = netdev_priv(net); + struct eth_dev *dev = netdev_priv(net); - strlcpy(p->driver, "g_ether", sizeof p->driver); - strlcpy(p->version, UETH__VERSION, sizeof p->version); - strlcpy(p->fw_version, dev->gadget->name, sizeof p->fw_version); - strlcpy(p->bus_info, dev_name(&dev->gadget->dev), sizeof p->bus_info); + strlcpy(p->driver, "g_ether", sizeof(p->driver)); + strlcpy(p->version, UETH__VERSION, sizeof(p->version)); + strlcpy(p->fw_version, dev->gadget->name, sizeof(p->fw_version)); + strlcpy(p->bus_info, dev_name(&dev->gadget->dev), sizeof(p->bus_info)); } /* REVISIT can also support: diff --git a/net/8021q/vlan_dev.c b/net/8021q/vlan_dev.c index 4a6d31a..09f9108 100644 --- a/net/8021q/vlan_dev.c +++ b/net/8021q/vlan_dev.c @@ -640,9 +640,9 @@ static int vlan_ethtool_get_settings(struct net_device *dev, static void vlan_ethtool_get_drvinfo(struct net_device *dev, struct ethtool_drvinfo *info) { - strcpy(info->driver, vlan_fullname); - strcpy(info->version, vlan_version); - strcpy(info->fw_version, "N/A"); + strlcpy(info->driver, vlan_fullname, sizeof(info->driver)); + strlcpy(info->version, vlan_version, sizeof(info->version)); + strlcpy(info->fw_version, "N/A", sizeof(info->fw_version)); } static struct rtnl_link_stats64 *vlan_dev_get_stats64(struct net_device *dev, struct rtnl_link_stats64 *stats) diff --git a/net/batman-adv/soft-interface.c b/net/batman-adv/soft-interface.c index fa388b2..90f4049 100644 --- a/net/batman-adv/soft-interface.c +++ b/net/batman-adv/soft-interface.c @@ -580,10 +580,10 @@ static int batadv_get_settings(struct net_device *dev, struct ethtool_cmd *cmd) static void batadv_get_drvinfo(struct net_device *dev, struct ethtool_drvinfo *info) { - strcpy(info->driver, "B.A.T.M.A.N. advanced"); - strcpy(info->version, BATADV_SOURCE_VERSION); - strcpy(info->fw_version, "N/A"); - strcpy(info->bus_info, "batman"); + strlcpy(info->driver, "B.A.T.M.A.N. advanced", sizeof(info->driver)); + strlcpy(info->version, BATADV_SOURCE_VERSION, sizeof(info->version)); + strlcpy(info->fw_version, "N/A", sizeof(info->fw_version)); + strlcpy(info->bus_info, "batman", sizeof(info->bus_info)); } static u32 batadv_get_msglevel(struct net_device *dev) diff --git a/net/bridge/br_device.c b/net/bridge/br_device.c index 38974f7..e1bc090 100644 --- a/net/bridge/br_device.c +++ b/net/bridge/br_device.c @@ -184,10 +184,10 @@ static int br_set_mac_address(struct net_device *dev, void *p) static void br_getinfo(struct net_device *dev, struct ethtool_drvinfo *info) { - strcpy(info->driver, "bridge"); - strcpy(info->version, BR_VERSION); - strcpy(info->fw_version, "N/A"); - strcpy(info->bus_info, "N/A"); + strlcpy(info->driver, "bridge", sizeof(info->driver)); + strlcpy(info->version, BR_VERSION, sizeof(info->version)); + strlcpy(info->fw_version, "N/A", sizeof(info->fw_version)); + strlcpy(info->bus_info, "N/A", sizeof(info->bus_info)); } static netdev_features_t br_fix_features(struct net_device *dev, diff --git a/net/dsa/slave.c b/net/dsa/slave.c index e32083d..f795b0c 100644 --- a/net/dsa/slave.c +++ b/net/dsa/slave.c @@ -203,10 +203,10 @@ dsa_slave_set_settings(struct net_device *dev, struct ethtool_cmd *cmd) static void dsa_slave_get_drvinfo(struct net_device *dev, struct ethtool_drvinfo *drvinfo) { - strncpy(drvinfo->driver, "dsa", 32); - strncpy(drvinfo->version, dsa_driver_version, 32); - strncpy(drvinfo->fw_version, "N/A", 32); - strncpy(drvinfo->bus_info, "platform", 32); + strlcpy(drvinfo->driver, "dsa", sizeof(drvinfo->driver)); + strlcpy(drvinfo->version, dsa_driver_version, sizeof(drvinfo->version)); + strlcpy(drvinfo->fw_version, "N/A", sizeof(drvinfo->fw_version)); + strlcpy(drvinfo->bus_info, "platform", sizeof(drvinfo->bus_info)); } static int dsa_slave_nway_reset(struct net_device *dev) diff --git a/net/openvswitch/vport-internal_dev.c b/net/openvswitch/vport-internal_dev.c index 44cd5c3..0531de6 100644 --- a/net/openvswitch/vport-internal_dev.c +++ b/net/openvswitch/vport-internal_dev.c @@ -97,7 +97,7 @@ static int internal_dev_stop(struct net_device *netdev) static void internal_dev_getinfo(struct net_device *netdev, struct ethtool_drvinfo *info) { - strcpy(info->driver, "openvswitch"); + strlcpy(info->driver, "openvswitch", sizeof(info->driver)); } static const struct ethtool_ops internal_dev_ethtool_ops = { diff --git a/net/wireless/ethtool.c b/net/wireless/ethtool.c index 48c48ff..e37862f 100644 --- a/net/wireless/ethtool.c +++ b/net/wireless/ethtool.c @@ -15,10 +15,10 @@ static void cfg80211_get_drvinfo(struct net_device *dev, strlcpy(info->version, init_utsname()->release, sizeof(info->version)); if (wdev->wiphy->fw_version[0]) - strncpy(info->fw_version, wdev->wiphy->fw_version, + strlcpy(info->fw_version, wdev->wiphy->fw_version, sizeof(info->fw_version)); else - strncpy(info->fw_version, "N/A", sizeof(info->fw_version)); + strlcpy(info->fw_version, "N/A", sizeof(info->fw_version)); strlcpy(info->bus_info, dev_name(wiphy_dev(wdev->wiphy)), sizeof(info->bus_info)); -- LinuxNextTracking

10 years, 2 months

Build check errors found: 2013-01-08

by postmaster＠open-mesh.org

Name of failed tests ==================== checkpatch master bridge_loop_avoidance.c checkpatch master icmp_socket.c checkpatch master soft-interface.c checkpatch master vis.c checkpatch next bat_iv_ogm.c checkpatch next bridge_loop_avoidance.c checkpatch next debugfs.c checkpatch next icmp_socket.c checkpatch next originator.c checkpatch next routing.c checkpatch next send.c checkpatch next soft-interface.c checkpatch next translation-table.c checkpatch next unicast.c checkpatch next vis.c Output of different failed tests ================================ checkpatch master bridge_loop_avoidance.c: >>>>>>>> WARNING: Avoid CamelCase: <vhdr->h_vlan_TCI> #874: FILE: bridge_loop_avoidance.c:874: + vid = ntohs(vhdr->h_vlan_TCI) & VLAN_VID_MASK; total: 0 errors, 1 warnings, 0 checks, 1699 lines checked checkpatch master soft-interface.c: >>>>>>>> Use of uninitialized value $ms_size in pattern match (m//) at /home/batman/build_test/linux-next/scripts/checkpatch.pl line 3383. Use of uninitialized value $ms_size in pattern match (m//) at /home/batman/build_test/linux-next/scripts/checkpatch.pl line 3386. Use of uninitialized value $ms_size in pattern match (m//) at /home/batman/build_test/linux-next/scripts/checkpatch.pl line 3383. Use of uninitialized value $ms_size in pattern match (m//) at /home/batman/build_test/linux-next/scripts/checkpatch.pl line 3386. Use of uninitialized value $ms_size in pattern match (m//) at /home/batman/build_test/linux-next/scripts/checkpatch.pl line 3383. Use of uninitialized value $ms_size in pattern match (m//) at /home/batman/build_test/linux-next/scripts/checkpatch.pl line 3386. WARNING: Avoid CamelCase: <vhdr->h_vlan_TCI> #170: FILE: soft-interface.c:170: + vid = ntohs(vhdr->h_vlan_TCI) & VLAN_VID_MASK; total: 0 errors, 1 warnings, 0 checks, 667 lines checked checkpatch next bat_iv_ogm.c: >>>>>>>> CHECK: Blank lines aren't necessary after an open brace '{' #186: FILE: bat_iv_ogm.c:186: + batadv_ogm_packet->tt_num_changes)) { + CHECK: Blank lines aren't necessary after an open brace '{' #264: FILE: bat_iv_ogm.c:264: + (forw_packet->own && (forw_packet->if_incoming != primary_if))) { + CHECK: Blank lines aren't necessary after an open brace '{' #328: FILE: bat_iv_ogm.c:328: + (aggregated_bytes <= BATADV_MAX_AGGREGATION_BYTES)) { + CHECK: Blank lines aren't necessary after an open brace '{' #818: FILE: bat_iv_ogm.c:818: + &orig_neigh_node->neigh_list, list) { + CHECK: Blank lines aren't necessary after an open brace '{' #952: FILE: bat_iv_ogm.c:952: + &orig_node->neigh_list, list) { + CHECK: Blank lines aren't necessary after an open brace '{' #1226: FILE: bat_iv_ogm.c:1226: + if (is_single_hop_neigh) { + total: 0 errors, 0 warnings, 6 checks, 1349 lines checked checkpatch next bridge_loop_avoidance.c: >>>>>>>> CHECK: Blank lines aren't necessary after an open brace '{' #238: FILE: bridge_loop_avoidance.c:238: + head, hash_entry) { + CHECK: Blank lines aren't necessary before a close brace '}' #342: FILE: bridge_loop_avoidance.c:342: + + } CHECK: Blank lines aren't necessary before a close brace '}' #543: FILE: bridge_loop_avoidance.c:543: + +} CHECK: Blank lines aren't necessary before a close brace '}' #602: FILE: bridge_loop_avoidance.c:602: + + } WARNING: Avoid CamelCase: <vhdr->h_vlan_TCI> #875: FILE: bridge_loop_avoidance.c:875: + vid = ntohs(vhdr->h_vlan_TCI) & VLAN_VID_MASK; total: 0 errors, 1 warnings, 4 checks, 1706 lines checked checkpatch next debugfs.c: >>>>>>>> CHECK: Blank lines aren't necessary before a close brace '}' #168: FILE: debugfs.c:168: + + } WARNING: debugfs_remove_recursive(NULL) is safe this check is probably not required #401: FILE: debugfs.c:401: + if (batadv_debugfs) { + debugfs_remove_recursive(batadv_debugfs); total: 0 errors, 1 warnings, 1 checks, 459 lines checked checkpatch next icmp_socket.c: >>>>>>>> Use of uninitialized value $ms_size in pattern match (m//) at /home/batman/build_test/linux-next/scripts/checkpatch.pl line 3383. Use of uninitialized value $ms_size in pattern match (m//) at /home/batman/build_test/linux-next/scripts/checkpatch.pl line 3386. Use of uninitialized value $ms_size in pattern match (m//) at /home/batman/build_test/linux-next/scripts/checkpatch.pl line 3383. Use of uninitialized value $ms_size in pattern match (m//) at /home/batman/build_test/linux-next/scripts/checkpatch.pl line 3386. Use of uninitialized value $ms_size in pattern match (m//) at /home/batman/build_test/linux-next/scripts/checkpatch.pl line 3383. Use of uninitialized value $ms_size in pattern match (m//) at /home/batman/build_test/linux-next/scripts/checkpatch.pl line 3386. checkpatch next originator.c: >>>>>>>> CHECK: Blank lines aren't necessary after an open brace '{' #181: FILE: originator.c:181: + head, hash_entry) { + CHECK: Blank lines aren't necessary after an open brace '{' #288: FILE: originator.c:288: + &orig_node->neigh_list, list) { + CHECK: Blank lines aren't necessary after an open brace '{' #296: FILE: originator.c:296: + (if_incoming->if_status == BATADV_IF_TO_BE_REMOVED)) { + total: 0 errors, 0 warnings, 3 checks, 645 lines checked checkpatch next routing.c: >>>>>>>> CHECK: Blank lines aren't necessary after an open brace '{' #83: FILE: routing.c:83: + } else if ((!curr_router) && (neigh_node)) { + CHECK: Blank lines aren't necessary after an open brace '{' #175: FILE: routing.c:175: + &orig_node->neigh_list, list) { + CHECK: Blank lines aren't necessary after an open brace '{' #839: FILE: routing.c:839: + neigh_node->if_incoming->net_dev->mtu)) { + CHECK: Blank lines aren't necessary after an open brace '{' #1106: FILE: routing.c:1106: + if (batadv_is_my_mac(unicast_packet->dest)) { + total: 0 errors, 0 warnings, 4 checks, 1281 lines checked checkpatch next send.c: >>>>>>>> CHECK: Blank lines aren't necessary after an open brace '{' #333: FILE: send.c:333: + &bat_priv->forw_bcast_list, list) { + CHECK: Blank lines aren't necessary after an open brace '{' #360: FILE: send.c:360: + &bat_priv->forw_bat_list, list) { + total: 0 errors, 0 warnings, 2 checks, 382 lines checked checkpatch next soft-interface.c: >>>>>>>> Use of uninitialized value $ms_size in pattern match (m//) at /home/batman/build_test/linux-next/scripts/checkpatch.pl line 3383. Use of uninitialized value $ms_size in pattern match (m//) at /home/batman/build_test/linux-next/scripts/checkpatch.pl line 3386. Use of uninitialized value $ms_size in pattern match (m//) at /home/batman/build_test/linux-next/scripts/checkpatch.pl line 3383. Use of uninitialized value $ms_size in pattern match (m//) at /home/batman/build_test/linux-next/scripts/checkpatch.pl line 3386. Use of uninitialized value $ms_size in pattern match (m//) at /home/batman/build_test/linux-next/scripts/checkpatch.pl line 3383. Use of uninitialized value $ms_size in pattern match (m//) at /home/batman/build_test/linux-next/scripts/checkpatch.pl line 3386. WARNING: Avoid CamelCase: <vhdr->h_vlan_TCI> #170: FILE: soft-interface.c:170: + vid = ntohs(vhdr->h_vlan_TCI) & VLAN_VID_MASK; total: 0 errors, 1 warnings, 0 checks, 662 lines checked checkpatch next translation-table.c: >>>>>>>> CHECK: Blank lines aren't necessary before a close brace '}' #116: FILE: translation-table.c:116: + +} CHECK: Blank lines aren't necessary before a close brace '}' #253: FILE: translation-table.c:253: + +} CHECK: Blank lines aren't necessary before a close brace '}' #631: FILE: translation-table.c:631: + +} CHECK: Blank lines aren't necessary before a close brace '}' #1053: FILE: translation-table.c:1053: + +} CHECK: Blank lines aren't necessary before a close brace '}' #1829: FILE: translation-table.c:1829: + +} CHECK: Blank lines aren't necessary before a close brace '}' #2356: FILE: translation-table.c:2356: + +} CHECK: Blank lines aren't necessary before a close brace '}' #2553: FILE: translation-table.c:2553: + +} total: 0 errors, 0 warnings, 7 checks, 2579 lines checked checkpatch next unicast.c: >>>>>>>> CHECK: Blank lines aren't necessary after an open brace '{' #136: FILE: unicast.c:136: + list_for_each_entry(tfp, head, list) { + CHECK: Blank lines aren't necessary after an open brace '{' #165: FILE: unicast.c:165: + if (!list_empty(head)) { + total: 0 errors, 0 warnings, 2 checks, 480 lines checked checkpatch next vis.c: >>>>>>>> Use of uninitialized value $ms_size in pattern match (m//) at /home/batman/build_test/linux-next/scripts/checkpatch.pl line 3383. Use of uninitialized value $ms_size in pattern match (m//) at /home/batman/build_test/linux-next/scripts/checkpatch.pl line 3386. Use of uninitialized value $ms_size in pattern match (m//) at /home/batman/build_test/linux-next/scripts/checkpatch.pl line 3383. Use of uninitialized value $ms_size in pattern match (m//) at /home/batman/build_test/linux-next/scripts/checkpatch.pl line 3386. Use of uninitialized value $ms_size in pattern match (m//) at /home/batman/build_test/linux-next/scripts/checkpatch.pl line 3383. Use of uninitialized value $ms_size in pattern match (m//) at /home/batman/build_test/linux-next/scripts/checkpatch.pl line 3386. Use of uninitialized value $ms_size in pattern match (m//) at /home/batman/build_test/linux-next/scripts/checkpatch.pl line 3383. Use of uninitialized value $ms_size in pattern match (m//) at /home/batman/build_test/linux-next/scripts/checkpatch.pl line 3386. Use of uninitialized value $ms_size in pattern match (m//) at /home/batman/build_test/linux-next/scripts/checkpatch.pl line 3383. Use of uninitialized value $ms_size in pattern match (m//) at /home/batman/build_test/linux-next/scripts/checkpatch.pl line 3386. Use of uninitialized value $ms_size in pattern match (m//) at /home/batman/build_test/linux-next/scripts/checkpatch.pl line 3383. Use of uninitialized value $ms_size in pattern match (m//) at /home/batman/build_test/linux-next/scripts/checkpatch.pl line 3386. Use of uninitialized value $ms_size in pattern match (m//) at /home/batman/build_test/linux-next/scripts/checkpatch.pl line 3383. Use of uninitialized value $ms_size in pattern match (m//) at /home/batman/build_test/linux-next/scripts/checkpatch.pl line 3386. Use of uninitialized value $ms_size in pattern match (m//) at /home/batman/build_test/linux-next/scripts/checkpatch.pl line 3383. Use of uninitialized value $ms_size in pattern match (m//) at /home/batman/build_test/linux-next/scripts/checkpatch.pl line 3386. Use of uninitialized value $ms_size in pattern match (m//) at /home/batman/build_test/linux-next/scripts/checkpatch.pl line 3383. Use of uninitialized value $ms_size in pattern match (m//) at /home/batman/build_test/linux-next/scripts/checkpatch.pl line 3386. Use of uninitialized value $ms_size in pattern match (m//) at /home/batman/build_test/linux-next/scripts/checkpatch.pl line 3383. Use of uninitialized value $ms_size in pattern match (m//) at /home/batman/build_test/linux-next/scripts/checkpatch.pl line 3386.

10 years, 2 months

[linux-next] LinuxNextTracking branch, master, updated. next-20130107

by batman＠open-mesh.org

The following commit has been merged in the master branch: commit 15c6ff3bc0ff3464a8c7efcdea09c86454571622 Author: Jiri Pirko <jiri(a)resnulli.us> Date: Tue Jan 1 03:30:17 2013 +0000 net: remove unnecessary NET_ADDR_RANDOM "bitclean" NET_ADDR_SET is set in dev_set_mac_address() no need to alter dev->addr_assign_type value in drivers. Signed-off-by: Jiri Pirko <jiri(a)resnulli.us> Signed-off-by: David S. Miller <davem(a)davemloft.net> diff --git a/drivers/net/ethernet/adi/bfin_mac.c b/drivers/net/ethernet/adi/bfin_mac.c index c1fdb8b..8c3c9cf 100644 --- a/drivers/net/ethernet/adi/bfin_mac.c +++ b/drivers/net/ethernet/adi/bfin_mac.c @@ -647,7 +647,6 @@ static int bfin_mac_set_mac_address(struct net_device *dev, void *p) if (netif_running(dev)) return -EBUSY; memcpy(dev->dev_addr, addr->sa_data, dev->addr_len); - dev->addr_assign_type &= ~NET_ADDR_RANDOM; setup_mac_addr(dev->dev_addr); return 0; } diff --git a/drivers/net/ethernet/atheros/atl1c/atl1c_main.c b/drivers/net/ethernet/atheros/atl1c/atl1c_main.c index 17651c7..7af95ce 100644 --- a/drivers/net/ethernet/atheros/atl1c/atl1c_main.c +++ b/drivers/net/ethernet/atheros/atl1c/atl1c_main.c @@ -472,7 +472,6 @@ static int atl1c_set_mac_addr(struct net_device *netdev, void *p) memcpy(netdev->dev_addr, addr->sa_data, netdev->addr_len); memcpy(adapter->hw.mac_addr, addr->sa_data, netdev->addr_len); - netdev->addr_assign_type &= ~NET_ADDR_RANDOM; atl1c_hw_set_mac_addr(&adapter->hw, adapter->hw.mac_addr); diff --git a/drivers/net/ethernet/atheros/atlx/atlx.c b/drivers/net/ethernet/atheros/atlx/atlx.c index 77ffbc4..f82eb16 100644 --- a/drivers/net/ethernet/atheros/atlx/atlx.c +++ b/drivers/net/ethernet/atheros/atlx/atlx.c @@ -84,7 +84,6 @@ static int atlx_set_mac(struct net_device *netdev, void *p) memcpy(netdev->dev_addr, addr->sa_data, netdev->addr_len); memcpy(adapter->hw.mac_addr, addr->sa_data, netdev->addr_len); - netdev->addr_assign_type &= ~NET_ADDR_RANDOM; atlx_set_mac_addr(&adapter->hw); return 0; diff --git a/drivers/net/ethernet/broadcom/bnx2x/bnx2x_cmn.c b/drivers/net/ethernet/broadcom/bnx2x/bnx2x_cmn.c index f9a15cb..d17fa5a 100644 --- a/drivers/net/ethernet/broadcom/bnx2x/bnx2x_cmn.c +++ b/drivers/net/ethernet/broadcom/bnx2x/bnx2x_cmn.c @@ -3904,7 +3904,6 @@ int bnx2x_change_mac_addr(struct net_device *dev, void *p) return rc; } - dev->addr_assign_type &= ~NET_ADDR_RANDOM; memcpy(dev->dev_addr, addr->sa_data, dev->addr_len); if (netif_running(dev)) diff --git a/drivers/net/ethernet/calxeda/xgmac.c b/drivers/net/ethernet/calxeda/xgmac.c index b407043..a345e24 100644 --- a/drivers/net/ethernet/calxeda/xgmac.c +++ b/drivers/net/ethernet/calxeda/xgmac.c @@ -1459,7 +1459,6 @@ static int xgmac_set_mac_address(struct net_device *dev, void *p) if (!is_valid_ether_addr(addr->sa_data)) return -EADDRNOTAVAIL; - dev->addr_assign_type &= ~NET_ADDR_RANDOM; memcpy(dev->dev_addr, addr->sa_data, dev->addr_len); xgmac_set_mac_addr(ioaddr, dev->dev_addr, 0); diff --git a/drivers/net/ethernet/cisco/enic/enic_main.c b/drivers/net/ethernet/cisco/enic/enic_main.c index 64866ff..ebccebf 100644 --- a/drivers/net/ethernet/cisco/enic/enic_main.c +++ b/drivers/net/ethernet/cisco/enic/enic_main.c @@ -865,7 +865,6 @@ static int enic_set_mac_addr(struct net_device *netdev, char *addr) } memcpy(netdev->dev_addr, addr, netdev->addr_len); - netdev->addr_assign_type &= ~NET_ADDR_RANDOM; return 0; } diff --git a/drivers/net/ethernet/ethoc.c b/drivers/net/ethernet/ethoc.c index f380bb7..b93062d 100644 --- a/drivers/net/ethernet/ethoc.c +++ b/drivers/net/ethernet/ethoc.c @@ -784,7 +784,6 @@ static int ethoc_set_mac_address(struct net_device *dev, void *addr) ethoc_write(priv, MAC_ADDR1, (mac[0] << 8) | (mac[1] << 0)); memcpy(dev->dev_addr, mac, ETH_ALEN); - dev->addr_assign_type &= ~NET_ADDR_RANDOM; return 0; } diff --git a/drivers/net/ethernet/intel/igbvf/netdev.c b/drivers/net/ethernet/intel/igbvf/netdev.c index 277f5df..53281ff 100644 --- a/drivers/net/ethernet/intel/igbvf/netdev.c +++ b/drivers/net/ethernet/intel/igbvf/netdev.c @@ -1738,7 +1738,6 @@ static int igbvf_set_mac(struct net_device *netdev, void *p) return -EADDRNOTAVAIL; memcpy(netdev->dev_addr, addr->sa_data, netdev->addr_len); - netdev->addr_assign_type &= ~NET_ADDR_RANDOM; return 0; } diff --git a/drivers/net/ethernet/marvell/pxa168_eth.c b/drivers/net/ethernet/marvell/pxa168_eth.c index 10d678d..aa037ca 100644 --- a/drivers/net/ethernet/marvell/pxa168_eth.c +++ b/drivers/net/ethernet/marvell/pxa168_eth.c @@ -627,7 +627,6 @@ static int pxa168_eth_set_mac_address(struct net_device *dev, void *addr) if (!is_valid_ether_addr(sa->sa_data)) return -EADDRNOTAVAIL; memcpy(oldMac, dev->dev_addr, ETH_ALEN); - dev->addr_assign_type &= ~NET_ADDR_RANDOM; memcpy(dev->dev_addr, sa->sa_data, ETH_ALEN); netif_addr_lock_bh(dev); update_hash_table_mac_address(pep, oldMac, dev->dev_addr); diff --git a/drivers/net/ethernet/micrel/ks8842.c b/drivers/net/ethernet/micrel/ks8842.c index b71eb39..fbcb9e7 100644 --- a/drivers/net/ethernet/micrel/ks8842.c +++ b/drivers/net/ethernet/micrel/ks8842.c @@ -1080,7 +1080,6 @@ static int ks8842_set_mac(struct net_device *netdev, void *p) if (!is_valid_ether_addr(addr->sa_data)) return -EADDRNOTAVAIL; - netdev->addr_assign_type &= ~NET_ADDR_RANDOM; memcpy(netdev->dev_addr, mac, netdev->addr_len); ks8842_write_mac_addr(adapter, mac); diff --git a/drivers/net/ethernet/micrel/ks8851.c b/drivers/net/ethernet/micrel/ks8851.c index 286816a..d59bc0e 100644 --- a/drivers/net/ethernet/micrel/ks8851.c +++ b/drivers/net/ethernet/micrel/ks8851.c @@ -1052,7 +1052,6 @@ static int ks8851_set_mac_address(struct net_device *dev, void *addr) if (!is_valid_ether_addr(sa->sa_data)) return -EADDRNOTAVAIL; - dev->addr_assign_type &= ~NET_ADDR_RANDOM; memcpy(dev->dev_addr, sa->sa_data, ETH_ALEN); return ks8851_write_mac_addr(dev); } diff --git a/drivers/net/ethernet/micrel/ks8851_mll.c b/drivers/net/ethernet/micrel/ks8851_mll.c index ef8f9f9..a343066 100644 --- a/drivers/net/ethernet/micrel/ks8851_mll.c +++ b/drivers/net/ethernet/micrel/ks8851_mll.c @@ -1237,7 +1237,6 @@ static int ks_set_mac_address(struct net_device *netdev, void *paddr) struct sockaddr *addr = paddr; u8 *da; - netdev->addr_assign_type &= ~NET_ADDR_RANDOM; memcpy(netdev->dev_addr, addr->sa_data, netdev->addr_len); da = (u8 *)netdev->dev_addr; diff --git a/drivers/net/ethernet/microchip/enc28j60.c b/drivers/net/ethernet/microchip/enc28j60.c index a99456c..5d98a9f 100644 --- a/drivers/net/ethernet/microchip/enc28j60.c +++ b/drivers/net/ethernet/microchip/enc28j60.c @@ -527,7 +527,6 @@ static int enc28j60_set_mac_address(struct net_device *dev, void *addr) if (!is_valid_ether_addr(address->sa_data)) return -EADDRNOTAVAIL; - dev->addr_assign_type &= ~NET_ADDR_RANDOM; memcpy(dev->dev_addr, address->sa_data, dev->addr_len); return enc28j60_set_hw_macaddr(dev); } diff --git a/drivers/net/ethernet/nvidia/forcedeth.c b/drivers/net/ethernet/nvidia/forcedeth.c index 653487d..b53bf9d 100644 --- a/drivers/net/ethernet/nvidia/forcedeth.c +++ b/drivers/net/ethernet/nvidia/forcedeth.c @@ -3025,7 +3025,6 @@ static int nv_set_mac_address(struct net_device *dev, void *addr) /* synchronized against open : rtnl_lock() held by caller */ memcpy(dev->dev_addr, macaddr->sa_data, ETH_ALEN); - dev->addr_assign_type &= ~NET_ADDR_RANDOM; if (netif_running(dev)) { netif_tx_lock_bh(dev); diff --git a/drivers/net/ethernet/octeon/octeon_mgmt.c b/drivers/net/ethernet/octeon/octeon_mgmt.c index b549919..b4a842c 100644 --- a/drivers/net/ethernet/octeon/octeon_mgmt.c +++ b/drivers/net/ethernet/octeon/octeon_mgmt.c @@ -1534,12 +1534,10 @@ static int octeon_mgmt_probe(struct platform_device *pdev) mac = of_get_mac_address(pdev->dev.of_node); - if (mac && is_valid_ether_addr(mac)) { + if (mac && is_valid_ether_addr(mac)) memcpy(netdev->dev_addr, mac, ETH_ALEN); - netdev->addr_assign_type &= ~NET_ADDR_RANDOM; - } else { + else eth_hw_addr_random(netdev); - } p->phy_np = of_parse_phandle(pdev->dev.of_node, "phy-handle", 0); diff --git a/drivers/net/ethernet/smsc/smsc911x.c b/drivers/net/ethernet/smsc/smsc911x.c index e112877..04ff63c 100644 --- a/drivers/net/ethernet/smsc/smsc911x.c +++ b/drivers/net/ethernet/smsc/smsc911x.c @@ -1831,7 +1831,6 @@ static int smsc911x_set_mac_address(struct net_device *dev, void *p) if (!is_valid_ether_addr(addr->sa_data)) return -EADDRNOTAVAIL; - dev->addr_assign_type &= ~NET_ADDR_RANDOM; memcpy(dev->dev_addr, addr->sa_data, ETH_ALEN); spin_lock_irq(&pdata->mac_lock); diff --git a/drivers/net/ethernet/ti/davinci_emac.c b/drivers/net/ethernet/ti/davinci_emac.c index 2a3e2c5..6841a22 100644 --- a/drivers/net/ethernet/ti/davinci_emac.c +++ b/drivers/net/ethernet/ti/davinci_emac.c @@ -1264,7 +1264,6 @@ static int emac_dev_setmac_addr(struct net_device *ndev, void *addr) /* Store mac addr in priv and rx channel and set it in EMAC hw */ memcpy(priv->mac_addr, sa->sa_data, ndev->addr_len); memcpy(ndev->dev_addr, sa->sa_data, ndev->addr_len); - ndev->addr_assign_type &= ~NET_ADDR_RANDOM; /* MAC address is configured only after the interface is enabled. */ if (netif_running(ndev)) { diff --git a/drivers/net/ethernet/tile/tilepro.c b/drivers/net/ethernet/tile/tilepro.c index 96070e9..3643549 100644 --- a/drivers/net/ethernet/tile/tilepro.c +++ b/drivers/net/ethernet/tile/tilepro.c @@ -2195,7 +2195,6 @@ static int tile_net_set_mac_address(struct net_device *dev, void *p) /* ISSUE: Note that "dev_addr" is now a pointer. */ memcpy(dev->dev_addr, addr->sa_data, dev->addr_len); - dev->addr_assign_type &= ~NET_ADDR_RANDOM; return 0; } diff --git a/drivers/net/ethernet/wiznet/w5100.c b/drivers/net/ethernet/wiznet/w5100.c index 3523838..545043c 100644 --- a/drivers/net/ethernet/wiznet/w5100.c +++ b/drivers/net/ethernet/wiznet/w5100.c @@ -570,7 +570,6 @@ static int w5100_set_macaddr(struct net_device *ndev, void *addr) if (!is_valid_ether_addr(sock_addr->sa_data)) return -EADDRNOTAVAIL; memcpy(ndev->dev_addr, sock_addr->sa_data, ETH_ALEN); - ndev->addr_assign_type &= ~NET_ADDR_RANDOM; w5100_write_macaddr(priv); return 0; } diff --git a/drivers/net/ethernet/wiznet/w5300.c b/drivers/net/ethernet/wiznet/w5300.c index 9d1d986..7cbd0e6 100644 --- a/drivers/net/ethernet/wiznet/w5300.c +++ b/drivers/net/ethernet/wiznet/w5300.c @@ -490,7 +490,6 @@ static int w5300_set_macaddr(struct net_device *ndev, void *addr) if (!is_valid_ether_addr(sock_addr->sa_data)) return -EADDRNOTAVAIL; memcpy(ndev->dev_addr, sock_addr->sa_data, ETH_ALEN); - ndev->addr_assign_type &= ~NET_ADDR_RANDOM; w5300_write_macaddr(priv); return 0; } diff --git a/drivers/net/macvlan.c b/drivers/net/macvlan.c index 68a43fe..80c6f92 100644 --- a/drivers/net/macvlan.c +++ b/drivers/net/macvlan.c @@ -375,7 +375,6 @@ static int macvlan_set_mac_address(struct net_device *dev, void *p) if (!(dev->flags & IFF_UP)) { /* Just copy in the new address */ - dev->addr_assign_type &= ~NET_ADDR_RANDOM; memcpy(dev->dev_addr, addr->sa_data, ETH_ALEN); } else { /* Rehash and update the device filters */ diff --git a/drivers/net/team/team.c b/drivers/net/team/team.c index 78c7d87..2ea4f0e 100644 --- a/drivers/net/team/team.c +++ b/drivers/net/team/team.c @@ -1500,7 +1500,6 @@ static int team_set_mac_address(struct net_device *dev, void *p) if (dev->type == ARPHRD_ETHER && !is_valid_ether_addr(addr->sa_data)) return -EADDRNOTAVAIL; memcpy(dev->dev_addr, addr->sa_data, dev->addr_len); - dev->addr_assign_type &= ~NET_ADDR_RANDOM; rcu_read_lock(); list_for_each_entry_rcu(port, &team->port_list, list) if (team->ops.port_change_dev_addr) @@ -1770,7 +1769,6 @@ static void team_setup_by_port(struct net_device *dev, dev->mtu = port_dev->mtu; memcpy(dev->broadcast, port_dev->broadcast, port_dev->addr_len); memcpy(dev->dev_addr, port_dev->dev_addr, port_dev->addr_len); - dev->addr_assign_type &= ~NET_ADDR_RANDOM; } static int team_dev_type_check_change(struct net_device *dev, diff --git a/drivers/staging/octeon/ethernet.c b/drivers/staging/octeon/ethernet.c index ef32dc1..9a2ec25 100644 --- a/drivers/staging/octeon/ethernet.c +++ b/drivers/staging/octeon/ethernet.c @@ -453,12 +453,10 @@ int cvm_oct_common_init(struct net_device *dev) if (priv->of_node) mac = of_get_mac_address(priv->of_node); - if (mac && is_valid_ether_addr(mac)) { + if (mac && is_valid_ether_addr(mac)) memcpy(dev->dev_addr, mac, ETH_ALEN); - dev->addr_assign_type &= ~NET_ADDR_RANDOM; - } else { + else eth_hw_addr_random(dev); - } /* * Force the interface to use the POW send if always_use_pow diff --git a/net/batman-adv/soft-interface.c b/net/batman-adv/soft-interface.c index 6b548fd..fa388b2 100644 --- a/net/batman-adv/soft-interface.c +++ b/net/batman-adv/soft-interface.c @@ -124,7 +124,6 @@ static int batadv_interface_set_mac_addr(struct net_device *dev, void *p) batadv_tt_local_add(dev, addr->sa_data, BATADV_NULL_IFINDEX); } - dev->addr_assign_type &= ~NET_ADDR_RANDOM; return 0; } diff --git a/net/bridge/br_device.c b/net/bridge/br_device.c index 7c78e26..38974f7 100644 --- a/net/bridge/br_device.c +++ b/net/bridge/br_device.c @@ -172,7 +172,6 @@ static int br_set_mac_address(struct net_device *dev, void *p) spin_lock_bh(&br->lock); if (!ether_addr_equal(dev->dev_addr, addr->sa_data)) { - dev->addr_assign_type &= ~NET_ADDR_RANDOM; memcpy(dev->dev_addr, addr->sa_data, ETH_ALEN); br_fdb_change_mac_address(br, addr->sa_data); br_stp_change_bridge_id(br, addr->sa_data); diff --git a/net/ethernet/eth.c b/net/ethernet/eth.c index 4efad53..bc39c8c 100644 --- a/net/ethernet/eth.c +++ b/net/ethernet/eth.c @@ -290,8 +290,6 @@ int eth_mac_addr(struct net_device *dev, void *p) if (!is_valid_ether_addr(addr->sa_data)) return -EADDRNOTAVAIL; memcpy(dev->dev_addr, addr->sa_data, ETH_ALEN); - /* if device marked as NET_ADDR_RANDOM, reset it */ - dev->addr_assign_type &= ~NET_ADDR_RANDOM; return 0; } EXPORT_SYMBOL(eth_mac_addr); diff --git a/net/openvswitch/vport-internal_dev.c b/net/openvswitch/vport-internal_dev.c index 5d460c3..44cd5c3 100644 --- a/net/openvswitch/vport-internal_dev.c +++ b/net/openvswitch/vport-internal_dev.c @@ -69,7 +69,6 @@ static int internal_dev_mac_addr(struct net_device *dev, void *p) if (!is_valid_ether_addr(addr->sa_data)) return -EADDRNOTAVAIL; - dev->addr_assign_type &= ~NET_ADDR_RANDOM; memcpy(dev->dev_addr, addr->sa_data, dev->addr_len); return 0; } -- LinuxNextTracking

10 years, 2 months

Build check errors found: 2013-01-07

by postmaster＠open-mesh.org

Name of failed tests ==================== checkpatch master bridge_loop_avoidance.c checkpatch master icmp_socket.c checkpatch master soft-interface.c checkpatch master vis.c checkpatch next bat_iv_ogm.c checkpatch next bridge_loop_avoidance.c checkpatch next debugfs.c checkpatch next icmp_socket.c checkpatch next originator.c checkpatch next routing.c checkpatch next send.c checkpatch next soft-interface.c checkpatch next translation-table.c checkpatch next unicast.c checkpatch next vis.c Output of different failed tests ================================ checkpatch master bridge_loop_avoidance.c: >>>>>>>> WARNING: Avoid CamelCase: <vhdr->h_vlan_TCI> #874: FILE: bridge_loop_avoidance.c:874: + vid = ntohs(vhdr->h_vlan_TCI) & VLAN_VID_MASK; total: 0 errors, 1 warnings, 0 checks, 1699 lines checked checkpatch master soft-interface.c: >>>>>>>> Use of uninitialized value $ms_size in pattern match (m//) at /home/batman/build_test/linux-next/scripts/checkpatch.pl line 3368. Use of uninitialized value $ms_size in pattern match (m//) at /home/batman/build_test/linux-next/scripts/checkpatch.pl line 3371. Use of uninitialized value $ms_size in pattern match (m//) at /home/batman/build_test/linux-next/scripts/checkpatch.pl line 3368. Use of uninitialized value $ms_size in pattern match (m//) at /home/batman/build_test/linux-next/scripts/checkpatch.pl line 3371. Use of uninitialized value $ms_size in pattern match (m//) at /home/batman/build_test/linux-next/scripts/checkpatch.pl line 3368. Use of uninitialized value $ms_size in pattern match (m//) at /home/batman/build_test/linux-next/scripts/checkpatch.pl line 3371. WARNING: Avoid CamelCase: <vhdr->h_vlan_TCI> #170: FILE: soft-interface.c:170: + vid = ntohs(vhdr->h_vlan_TCI) & VLAN_VID_MASK; total: 0 errors, 1 warnings, 0 checks, 667 lines checked checkpatch next bat_iv_ogm.c: >>>>>>>> CHECK: Blank lines aren't necessary after an open brace '{' #186: FILE: bat_iv_ogm.c:186: + batadv_ogm_packet->tt_num_changes)) { + CHECK: Blank lines aren't necessary after an open brace '{' #264: FILE: bat_iv_ogm.c:264: + (forw_packet->own && (forw_packet->if_incoming != primary_if))) { + CHECK: Blank lines aren't necessary after an open brace '{' #328: FILE: bat_iv_ogm.c:328: + (aggregated_bytes <= BATADV_MAX_AGGREGATION_BYTES)) { + CHECK: Blank lines aren't necessary after an open brace '{' #818: FILE: bat_iv_ogm.c:818: + &orig_neigh_node->neigh_list, list) { + CHECK: Blank lines aren't necessary after an open brace '{' #952: FILE: bat_iv_ogm.c:952: + &orig_node->neigh_list, list) { + CHECK: Blank lines aren't necessary after an open brace '{' #1226: FILE: bat_iv_ogm.c:1226: + if (is_single_hop_neigh) { + total: 0 errors, 0 warnings, 6 checks, 1349 lines checked checkpatch next bridge_loop_avoidance.c: >>>>>>>> CHECK: Blank lines aren't necessary after an open brace '{' #238: FILE: bridge_loop_avoidance.c:238: + head, hash_entry) { + CHECK: Blank lines aren't necessary before a close brace '}' #342: FILE: bridge_loop_avoidance.c:342: + + } CHECK: Blank lines aren't necessary before a close brace '}' #543: FILE: bridge_loop_avoidance.c:543: + +} CHECK: Blank lines aren't necessary before a close brace '}' #602: FILE: bridge_loop_avoidance.c:602: + + } WARNING: Avoid CamelCase: <vhdr->h_vlan_TCI> #875: FILE: bridge_loop_avoidance.c:875: + vid = ntohs(vhdr->h_vlan_TCI) & VLAN_VID_MASK; total: 0 errors, 1 warnings, 4 checks, 1706 lines checked checkpatch next debugfs.c: >>>>>>>> CHECK: Blank lines aren't necessary before a close brace '}' #168: FILE: debugfs.c:168: + + } WARNING: debugfs_remove_recursive(NULL) is safe this check is probably not required #401: FILE: debugfs.c:401: + if (batadv_debugfs) { + debugfs_remove_recursive(batadv_debugfs); total: 0 errors, 1 warnings, 1 checks, 459 lines checked checkpatch next icmp_socket.c: >>>>>>>> Use of uninitialized value $ms_size in pattern match (m//) at /home/batman/build_test/linux-next/scripts/checkpatch.pl line 3368. Use of uninitialized value $ms_size in pattern match (m//) at /home/batman/build_test/linux-next/scripts/checkpatch.pl line 3371. Use of uninitialized value $ms_size in pattern match (m//) at /home/batman/build_test/linux-next/scripts/checkpatch.pl line 3368. Use of uninitialized value $ms_size in pattern match (m//) at /home/batman/build_test/linux-next/scripts/checkpatch.pl line 3371. Use of uninitialized value $ms_size in pattern match (m//) at /home/batman/build_test/linux-next/scripts/checkpatch.pl line 3368. Use of uninitialized value $ms_size in pattern match (m//) at /home/batman/build_test/linux-next/scripts/checkpatch.pl line 3371. checkpatch next originator.c: >>>>>>>> CHECK: Blank lines aren't necessary after an open brace '{' #181: FILE: originator.c:181: + head, hash_entry) { + CHECK: Blank lines aren't necessary after an open brace '{' #288: FILE: originator.c:288: + &orig_node->neigh_list, list) { + CHECK: Blank lines aren't necessary after an open brace '{' #296: FILE: originator.c:296: + (if_incoming->if_status == BATADV_IF_TO_BE_REMOVED)) { + total: 0 errors, 0 warnings, 3 checks, 645 lines checked checkpatch next routing.c: >>>>>>>> CHECK: Blank lines aren't necessary after an open brace '{' #83: FILE: routing.c:83: + } else if ((!curr_router) && (neigh_node)) { + CHECK: Blank lines aren't necessary after an open brace '{' #175: FILE: routing.c:175: + &orig_node->neigh_list, list) { + CHECK: Blank lines aren't necessary after an open brace '{' #839: FILE: routing.c:839: + neigh_node->if_incoming->net_dev->mtu)) { + CHECK: Blank lines aren't necessary after an open brace '{' #1106: FILE: routing.c:1106: + if (batadv_is_my_mac(unicast_packet->dest)) { + total: 0 errors, 0 warnings, 4 checks, 1281 lines checked checkpatch next send.c: >>>>>>>> CHECK: Blank lines aren't necessary after an open brace '{' #333: FILE: send.c:333: + &bat_priv->forw_bcast_list, list) { + CHECK: Blank lines aren't necessary after an open brace '{' #360: FILE: send.c:360: + &bat_priv->forw_bat_list, list) { + total: 0 errors, 0 warnings, 2 checks, 382 lines checked checkpatch next soft-interface.c: >>>>>>>> Use of uninitialized value $ms_size in pattern match (m//) at /home/batman/build_test/linux-next/scripts/checkpatch.pl line 3368. Use of uninitialized value $ms_size in pattern match (m//) at /home/batman/build_test/linux-next/scripts/checkpatch.pl line 3371. Use of uninitialized value $ms_size in pattern match (m//) at /home/batman/build_test/linux-next/scripts/checkpatch.pl line 3368. Use of uninitialized value $ms_size in pattern match (m//) at /home/batman/build_test/linux-next/scripts/checkpatch.pl line 3371. Use of uninitialized value $ms_size in pattern match (m//) at /home/batman/build_test/linux-next/scripts/checkpatch.pl line 3368. Use of uninitialized value $ms_size in pattern match (m//) at /home/batman/build_test/linux-next/scripts/checkpatch.pl line 3371. WARNING: Avoid CamelCase: <vhdr->h_vlan_TCI> #170: FILE: soft-interface.c:170: + vid = ntohs(vhdr->h_vlan_TCI) & VLAN_VID_MASK; total: 0 errors, 1 warnings, 0 checks, 662 lines checked checkpatch next translation-table.c: >>>>>>>> CHECK: Blank lines aren't necessary before a close brace '}' #116: FILE: translation-table.c:116: + +} CHECK: Blank lines aren't necessary before a close brace '}' #253: FILE: translation-table.c:253: + +} CHECK: Blank lines aren't necessary before a close brace '}' #631: FILE: translation-table.c:631: + +} CHECK: Blank lines aren't necessary before a close brace '}' #1053: FILE: translation-table.c:1053: + +} CHECK: Blank lines aren't necessary before a close brace '}' #1829: FILE: translation-table.c:1829: + +} CHECK: Blank lines aren't necessary before a close brace '}' #2356: FILE: translation-table.c:2356: + +} CHECK: Blank lines aren't necessary before a close brace '}' #2553: FILE: translation-table.c:2553: + +} total: 0 errors, 0 warnings, 7 checks, 2579 lines checked checkpatch next unicast.c: >>>>>>>> CHECK: Blank lines aren't necessary after an open brace '{' #136: FILE: unicast.c:136: + list_for_each_entry(tfp, head, list) { + CHECK: Blank lines aren't necessary after an open brace '{' #165: FILE: unicast.c:165: + if (!list_empty(head)) { + total: 0 errors, 0 warnings, 2 checks, 480 lines checked checkpatch next vis.c: >>>>>>>> Use of uninitialized value $ms_size in pattern match (m//) at /home/batman/build_test/linux-next/scripts/checkpatch.pl line 3368. Use of uninitialized value $ms_size in pattern match (m//) at /home/batman/build_test/linux-next/scripts/checkpatch.pl line 3371. Use of uninitialized value $ms_size in pattern match (m//) at /home/batman/build_test/linux-next/scripts/checkpatch.pl line 3368. Use of uninitialized value $ms_size in pattern match (m//) at /home/batman/build_test/linux-next/scripts/checkpatch.pl line 3371. Use of uninitialized value $ms_size in pattern match (m//) at /home/batman/build_test/linux-next/scripts/checkpatch.pl line 3368. Use of uninitialized value $ms_size in pattern match (m//) at /home/batman/build_test/linux-next/scripts/checkpatch.pl line 3371. Use of uninitialized value $ms_size in pattern match (m//) at /home/batman/build_test/linux-next/scripts/checkpatch.pl line 3368. Use of uninitialized value $ms_size in pattern match (m//) at /home/batman/build_test/linux-next/scripts/checkpatch.pl line 3371. Use of uninitialized value $ms_size in pattern match (m//) at /home/batman/build_test/linux-next/scripts/checkpatch.pl line 3368. Use of uninitialized value $ms_size in pattern match (m//) at /home/batman/build_test/linux-next/scripts/checkpatch.pl line 3371. Use of uninitialized value $ms_size in pattern match (m//) at /home/batman/build_test/linux-next/scripts/checkpatch.pl line 3368. Use of uninitialized value $ms_size in pattern match (m//) at /home/batman/build_test/linux-next/scripts/checkpatch.pl line 3371. Use of uninitialized value $ms_size in pattern match (m//) at /home/batman/build_test/linux-next/scripts/checkpatch.pl line 3368. Use of uninitialized value $ms_size in pattern match (m//) at /home/batman/build_test/linux-next/scripts/checkpatch.pl line 3371. Use of uninitialized value $ms_size in pattern match (m//) at /home/batman/build_test/linux-next/scripts/checkpatch.pl line 3368. Use of uninitialized value $ms_size in pattern match (m//) at /home/batman/build_test/linux-next/scripts/checkpatch.pl line 3371. Use of uninitialized value $ms_size in pattern match (m//) at /home/batman/build_test/linux-next/scripts/checkpatch.pl line 3368. Use of uninitialized value $ms_size in pattern match (m//) at /home/batman/build_test/linux-next/scripts/checkpatch.pl line 3371. Use of uninitialized value $ms_size in pattern match (m//) at /home/batman/build_test/linux-next/scripts/checkpatch.pl line 3368. Use of uninitialized value $ms_size in pattern match (m//) at /home/batman/build_test/linux-next/scripts/checkpatch.pl line 3371.

10 years, 2 months

Build check errors found: 2013-01-06

by postmaster＠open-mesh.org

Name of failed tests ==================== checkpatch master bridge_loop_avoidance.c checkpatch master icmp_socket.c checkpatch master soft-interface.c checkpatch master vis.c checkpatch next bat_iv_ogm.c checkpatch next bridge_loop_avoidance.c checkpatch next debugfs.c checkpatch next icmp_socket.c checkpatch next originator.c checkpatch next routing.c checkpatch next send.c checkpatch next soft-interface.c checkpatch next translation-table.c checkpatch next unicast.c checkpatch next vis.c Output of different failed tests ================================ checkpatch master bridge_loop_avoidance.c: >>>>>>>> WARNING: Avoid CamelCase: <vhdr->h_vlan_TCI> #874: FILE: bridge_loop_avoidance.c:874: + vid = ntohs(vhdr->h_vlan_TCI) & VLAN_VID_MASK; total: 0 errors, 1 warnings, 0 checks, 1699 lines checked checkpatch master soft-interface.c: >>>>>>>> Use of uninitialized value $ms_size in pattern match (m//) at /home/batman/build_test/linux-next/scripts/checkpatch.pl line 3368. Use of uninitialized value $ms_size in pattern match (m//) at /home/batman/build_test/linux-next/scripts/checkpatch.pl line 3371. Use of uninitialized value $ms_size in pattern match (m//) at /home/batman/build_test/linux-next/scripts/checkpatch.pl line 3368. Use of uninitialized value $ms_size in pattern match (m//) at /home/batman/build_test/linux-next/scripts/checkpatch.pl line 3371. Use of uninitialized value $ms_size in pattern match (m//) at /home/batman/build_test/linux-next/scripts/checkpatch.pl line 3368. Use of uninitialized value $ms_size in pattern match (m//) at /home/batman/build_test/linux-next/scripts/checkpatch.pl line 3371. WARNING: Avoid CamelCase: <vhdr->h_vlan_TCI> #170: FILE: soft-interface.c:170: + vid = ntohs(vhdr->h_vlan_TCI) & VLAN_VID_MASK; total: 0 errors, 1 warnings, 0 checks, 667 lines checked checkpatch next bat_iv_ogm.c: >>>>>>>> CHECK: Blank lines aren't necessary after an open brace '{' #186: FILE: bat_iv_ogm.c:186: + batadv_ogm_packet->tt_num_changes)) { + CHECK: Blank lines aren't necessary after an open brace '{' #264: FILE: bat_iv_ogm.c:264: + (forw_packet->own && (forw_packet->if_incoming != primary_if))) { + CHECK: Blank lines aren't necessary after an open brace '{' #328: FILE: bat_iv_ogm.c:328: + (aggregated_bytes <= BATADV_MAX_AGGREGATION_BYTES)) { + CHECK: Blank lines aren't necessary after an open brace '{' #818: FILE: bat_iv_ogm.c:818: + &orig_neigh_node->neigh_list, list) { + CHECK: Blank lines aren't necessary after an open brace '{' #952: FILE: bat_iv_ogm.c:952: + &orig_node->neigh_list, list) { + CHECK: Blank lines aren't necessary after an open brace '{' #1226: FILE: bat_iv_ogm.c:1226: + if (is_single_hop_neigh) { + total: 0 errors, 0 warnings, 6 checks, 1349 lines checked checkpatch next bridge_loop_avoidance.c: >>>>>>>> CHECK: Blank lines aren't necessary after an open brace '{' #238: FILE: bridge_loop_avoidance.c:238: + head, hash_entry) { + CHECK: Blank lines aren't necessary before a close brace '}' #342: FILE: bridge_loop_avoidance.c:342: + + } CHECK: Blank lines aren't necessary before a close brace '}' #543: FILE: bridge_loop_avoidance.c:543: + +} CHECK: Blank lines aren't necessary before a close brace '}' #602: FILE: bridge_loop_avoidance.c:602: + + } WARNING: Avoid CamelCase: <vhdr->h_vlan_TCI> #875: FILE: bridge_loop_avoidance.c:875: + vid = ntohs(vhdr->h_vlan_TCI) & VLAN_VID_MASK; total: 0 errors, 1 warnings, 4 checks, 1706 lines checked checkpatch next debugfs.c: >>>>>>>> CHECK: Blank lines aren't necessary before a close brace '}' #168: FILE: debugfs.c:168: + + } WARNING: debugfs_remove_recursive(NULL) is safe this check is probably not required #401: FILE: debugfs.c:401: + if (batadv_debugfs) { + debugfs_remove_recursive(batadv_debugfs); total: 0 errors, 1 warnings, 1 checks, 459 lines checked checkpatch next icmp_socket.c: >>>>>>>> Use of uninitialized value $ms_size in pattern match (m//) at /home/batman/build_test/linux-next/scripts/checkpatch.pl line 3368. Use of uninitialized value $ms_size in pattern match (m//) at /home/batman/build_test/linux-next/scripts/checkpatch.pl line 3371. Use of uninitialized value $ms_size in pattern match (m//) at /home/batman/build_test/linux-next/scripts/checkpatch.pl line 3368. Use of uninitialized value $ms_size in pattern match (m//) at /home/batman/build_test/linux-next/scripts/checkpatch.pl line 3371. Use of uninitialized value $ms_size in pattern match (m//) at /home/batman/build_test/linux-next/scripts/checkpatch.pl line 3368. Use of uninitialized value $ms_size in pattern match (m//) at /home/batman/build_test/linux-next/scripts/checkpatch.pl line 3371. checkpatch next originator.c: >>>>>>>> CHECK: Blank lines aren't necessary after an open brace '{' #181: FILE: originator.c:181: + head, hash_entry) { + CHECK: Blank lines aren't necessary after an open brace '{' #288: FILE: originator.c:288: + &orig_node->neigh_list, list) { + CHECK: Blank lines aren't necessary after an open brace '{' #296: FILE: originator.c:296: + (if_incoming->if_status == BATADV_IF_TO_BE_REMOVED)) { + total: 0 errors, 0 warnings, 3 checks, 645 lines checked checkpatch next routing.c: >>>>>>>> CHECK: Blank lines aren't necessary after an open brace '{' #83: FILE: routing.c:83: + } else if ((!curr_router) && (neigh_node)) { + CHECK: Blank lines aren't necessary after an open brace '{' #175: FILE: routing.c:175: + &orig_node->neigh_list, list) { + CHECK: Blank lines aren't necessary after an open brace '{' #839: FILE: routing.c:839: + neigh_node->if_incoming->net_dev->mtu)) { + CHECK: Blank lines aren't necessary after an open brace '{' #1106: FILE: routing.c:1106: + if (batadv_is_my_mac(unicast_packet->dest)) { + total: 0 errors, 0 warnings, 4 checks, 1281 lines checked checkpatch next send.c: >>>>>>>> CHECK: Blank lines aren't necessary after an open brace '{' #333: FILE: send.c:333: + &bat_priv->forw_bcast_list, list) { + CHECK: Blank lines aren't necessary after an open brace '{' #360: FILE: send.c:360: + &bat_priv->forw_bat_list, list) { + total: 0 errors, 0 warnings, 2 checks, 382 lines checked checkpatch next soft-interface.c: >>>>>>>> Use of uninitialized value $ms_size in pattern match (m//) at /home/batman/build_test/linux-next/scripts/checkpatch.pl line 3368. Use of uninitialized value $ms_size in pattern match (m//) at /home/batman/build_test/linux-next/scripts/checkpatch.pl line 3371. Use of uninitialized value $ms_size in pattern match (m//) at /home/batman/build_test/linux-next/scripts/checkpatch.pl line 3368. Use of uninitialized value $ms_size in pattern match (m//) at /home/batman/build_test/linux-next/scripts/checkpatch.pl line 3371. Use of uninitialized value $ms_size in pattern match (m//) at /home/batman/build_test/linux-next/scripts/checkpatch.pl line 3368. Use of uninitialized value $ms_size in pattern match (m//) at /home/batman/build_test/linux-next/scripts/checkpatch.pl line 3371. WARNING: Avoid CamelCase: <vhdr->h_vlan_TCI> #170: FILE: soft-interface.c:170: + vid = ntohs(vhdr->h_vlan_TCI) & VLAN_VID_MASK; total: 0 errors, 1 warnings, 0 checks, 662 lines checked checkpatch next translation-table.c: >>>>>>>> CHECK: Blank lines aren't necessary before a close brace '}' #116: FILE: translation-table.c:116: + +} CHECK: Blank lines aren't necessary before a close brace '}' #253: FILE: translation-table.c:253: + +} CHECK: Blank lines aren't necessary before a close brace '}' #631: FILE: translation-table.c:631: + +} CHECK: Blank lines aren't necessary before a close brace '}' #1053: FILE: translation-table.c:1053: + +} CHECK: Blank lines aren't necessary before a close brace '}' #1829: FILE: translation-table.c:1829: + +} CHECK: Blank lines aren't necessary before a close brace '}' #2356: FILE: translation-table.c:2356: + +} CHECK: Blank lines aren't necessary before a close brace '}' #2553: FILE: translation-table.c:2553: + +} total: 0 errors, 0 warnings, 7 checks, 2579 lines checked checkpatch next unicast.c: >>>>>>>> CHECK: Blank lines aren't necessary after an open brace '{' #136: FILE: unicast.c:136: + list_for_each_entry(tfp, head, list) { + CHECK: Blank lines aren't necessary after an open brace '{' #165: FILE: unicast.c:165: + if (!list_empty(head)) { + total: 0 errors, 0 warnings, 2 checks, 480 lines checked checkpatch next vis.c: >>>>>>>> Use of uninitialized value $ms_size in pattern match (m//) at /home/batman/build_test/linux-next/scripts/checkpatch.pl line 3368. Use of uninitialized value $ms_size in pattern match (m//) at /home/batman/build_test/linux-next/scripts/checkpatch.pl line 3371. Use of uninitialized value $ms_size in pattern match (m//) at /home/batman/build_test/linux-next/scripts/checkpatch.pl line 3368. Use of uninitialized value $ms_size in pattern match (m//) at /home/batman/build_test/linux-next/scripts/checkpatch.pl line 3371. Use of uninitialized value $ms_size in pattern match (m//) at /home/batman/build_test/linux-next/scripts/checkpatch.pl line 3368. Use of uninitialized value $ms_size in pattern match (m//) at /home/batman/build_test/linux-next/scripts/checkpatch.pl line 3371. Use of uninitialized value $ms_size in pattern match (m//) at /home/batman/build_test/linux-next/scripts/checkpatch.pl line 3368. Use of uninitialized value $ms_size in pattern match (m//) at /home/batman/build_test/linux-next/scripts/checkpatch.pl line 3371. Use of uninitialized value $ms_size in pattern match (m//) at /home/batman/build_test/linux-next/scripts/checkpatch.pl line 3368. Use of uninitialized value $ms_size in pattern match (m//) at /home/batman/build_test/linux-next/scripts/checkpatch.pl line 3371. Use of uninitialized value $ms_size in pattern match (m//) at /home/batman/build_test/linux-next/scripts/checkpatch.pl line 3368. Use of uninitialized value $ms_size in pattern match (m//) at /home/batman/build_test/linux-next/scripts/checkpatch.pl line 3371. Use of uninitialized value $ms_size in pattern match (m//) at /home/batman/build_test/linux-next/scripts/checkpatch.pl line 3368. Use of uninitialized value $ms_size in pattern match (m//) at /home/batman/build_test/linux-next/scripts/checkpatch.pl line 3371. Use of uninitialized value $ms_size in pattern match (m//) at /home/batman/build_test/linux-next/scripts/checkpatch.pl line 3368. Use of uninitialized value $ms_size in pattern match (m//) at /home/batman/build_test/linux-next/scripts/checkpatch.pl line 3371. Use of uninitialized value $ms_size in pattern match (m//) at /home/batman/build_test/linux-next/scripts/checkpatch.pl line 3368. Use of uninitialized value $ms_size in pattern match (m//) at /home/batman/build_test/linux-next/scripts/checkpatch.pl line 3371. Use of uninitialized value $ms_size in pattern match (m//) at /home/batman/build_test/linux-next/scripts/checkpatch.pl line 3368. Use of uninitialized value $ms_size in pattern match (m//) at /home/batman/build_test/linux-next/scripts/checkpatch.pl line 3371.

10 years, 2 months

Build check errors found: 2013-01-05

by postmaster＠open-mesh.org

Name of failed tests ==================== checkpatch master bridge_loop_avoidance.c checkpatch master icmp_socket.c checkpatch master soft-interface.c checkpatch master vis.c checkpatch next bat_iv_ogm.c checkpatch next bridge_loop_avoidance.c checkpatch next debugfs.c checkpatch next icmp_socket.c checkpatch next originator.c checkpatch next routing.c checkpatch next send.c checkpatch next soft-interface.c checkpatch next translation-table.c checkpatch next unicast.c checkpatch next vis.c Output of different failed tests ================================ checkpatch master bridge_loop_avoidance.c: >>>>>>>> WARNING: Avoid CamelCase: <vhdr->h_vlan_TCI> #874: FILE: bridge_loop_avoidance.c:874: + vid = ntohs(vhdr->h_vlan_TCI) & VLAN_VID_MASK; total: 0 errors, 1 warnings, 0 checks, 1699 lines checked checkpatch master soft-interface.c: >>>>>>>> Use of uninitialized value $ms_size in pattern match (m//) at /home/batman/build_test/linux-next/scripts/checkpatch.pl line 3368. Use of uninitialized value $ms_size in pattern match (m//) at /home/batman/build_test/linux-next/scripts/checkpatch.pl line 3371. Use of uninitialized value $ms_size in pattern match (m//) at /home/batman/build_test/linux-next/scripts/checkpatch.pl line 3368. Use of uninitialized value $ms_size in pattern match (m//) at /home/batman/build_test/linux-next/scripts/checkpatch.pl line 3371. Use of uninitialized value $ms_size in pattern match (m//) at /home/batman/build_test/linux-next/scripts/checkpatch.pl line 3368. Use of uninitialized value $ms_size in pattern match (m//) at /home/batman/build_test/linux-next/scripts/checkpatch.pl line 3371. WARNING: Avoid CamelCase: <vhdr->h_vlan_TCI> #170: FILE: soft-interface.c:170: + vid = ntohs(vhdr->h_vlan_TCI) & VLAN_VID_MASK; total: 0 errors, 1 warnings, 0 checks, 667 lines checked checkpatch next bat_iv_ogm.c: >>>>>>>> CHECK: Blank lines aren't necessary after an open brace '{' #186: FILE: bat_iv_ogm.c:186: + batadv_ogm_packet->tt_num_changes)) { + CHECK: Blank lines aren't necessary after an open brace '{' #264: FILE: bat_iv_ogm.c:264: + (forw_packet->own && (forw_packet->if_incoming != primary_if))) { + CHECK: Blank lines aren't necessary after an open brace '{' #328: FILE: bat_iv_ogm.c:328: + (aggregated_bytes <= BATADV_MAX_AGGREGATION_BYTES)) { + CHECK: Blank lines aren't necessary after an open brace '{' #818: FILE: bat_iv_ogm.c:818: + &orig_neigh_node->neigh_list, list) { + CHECK: Blank lines aren't necessary after an open brace '{' #952: FILE: bat_iv_ogm.c:952: + &orig_node->neigh_list, list) { + CHECK: Blank lines aren't necessary after an open brace '{' #1226: FILE: bat_iv_ogm.c:1226: + if (is_single_hop_neigh) { + total: 0 errors, 0 warnings, 6 checks, 1349 lines checked checkpatch next bridge_loop_avoidance.c: >>>>>>>> CHECK: Blank lines aren't necessary after an open brace '{' #238: FILE: bridge_loop_avoidance.c:238: + head, hash_entry) { + CHECK: Blank lines aren't necessary before a close brace '}' #342: FILE: bridge_loop_avoidance.c:342: + + } CHECK: Blank lines aren't necessary before a close brace '}' #543: FILE: bridge_loop_avoidance.c:543: + +} CHECK: Blank lines aren't necessary before a close brace '}' #602: FILE: bridge_loop_avoidance.c:602: + + } WARNING: Avoid CamelCase: <vhdr->h_vlan_TCI> #875: FILE: bridge_loop_avoidance.c:875: + vid = ntohs(vhdr->h_vlan_TCI) & VLAN_VID_MASK; total: 0 errors, 1 warnings, 4 checks, 1706 lines checked checkpatch next debugfs.c: >>>>>>>> CHECK: Blank lines aren't necessary before a close brace '}' #168: FILE: debugfs.c:168: + + } WARNING: debugfs_remove_recursive(NULL) is safe this check is probably not required #401: FILE: debugfs.c:401: + if (batadv_debugfs) { + debugfs_remove_recursive(batadv_debugfs); total: 0 errors, 1 warnings, 1 checks, 459 lines checked checkpatch next icmp_socket.c: >>>>>>>> Use of uninitialized value $ms_size in pattern match (m//) at /home/batman/build_test/linux-next/scripts/checkpatch.pl line 3368. Use of uninitialized value $ms_size in pattern match (m//) at /home/batman/build_test/linux-next/scripts/checkpatch.pl line 3371. Use of uninitialized value $ms_size in pattern match (m//) at /home/batman/build_test/linux-next/scripts/checkpatch.pl line 3368. Use of uninitialized value $ms_size in pattern match (m//) at /home/batman/build_test/linux-next/scripts/checkpatch.pl line 3371. Use of uninitialized value $ms_size in pattern match (m//) at /home/batman/build_test/linux-next/scripts/checkpatch.pl line 3368. Use of uninitialized value $ms_size in pattern match (m//) at /home/batman/build_test/linux-next/scripts/checkpatch.pl line 3371. checkpatch next originator.c: >>>>>>>> CHECK: Blank lines aren't necessary after an open brace '{' #181: FILE: originator.c:181: + head, hash_entry) { + CHECK: Blank lines aren't necessary after an open brace '{' #288: FILE: originator.c:288: + &orig_node->neigh_list, list) { + CHECK: Blank lines aren't necessary after an open brace '{' #296: FILE: originator.c:296: + (if_incoming->if_status == BATADV_IF_TO_BE_REMOVED)) { + total: 0 errors, 0 warnings, 3 checks, 645 lines checked checkpatch next routing.c: >>>>>>>> CHECK: Blank lines aren't necessary after an open brace '{' #83: FILE: routing.c:83: + } else if ((!curr_router) && (neigh_node)) { + CHECK: Blank lines aren't necessary after an open brace '{' #175: FILE: routing.c:175: + &orig_node->neigh_list, list) { + CHECK: Blank lines aren't necessary after an open brace '{' #839: FILE: routing.c:839: + neigh_node->if_incoming->net_dev->mtu)) { + CHECK: Blank lines aren't necessary after an open brace '{' #1106: FILE: routing.c:1106: + if (batadv_is_my_mac(unicast_packet->dest)) { + total: 0 errors, 0 warnings, 4 checks, 1281 lines checked checkpatch next send.c: >>>>>>>> CHECK: Blank lines aren't necessary after an open brace '{' #333: FILE: send.c:333: + &bat_priv->forw_bcast_list, list) { + CHECK: Blank lines aren't necessary after an open brace '{' #360: FILE: send.c:360: + &bat_priv->forw_bat_list, list) { + total: 0 errors, 0 warnings, 2 checks, 382 lines checked checkpatch next soft-interface.c: >>>>>>>> Use of uninitialized value $ms_size in pattern match (m//) at /home/batman/build_test/linux-next/scripts/checkpatch.pl line 3368. Use of uninitialized value $ms_size in pattern match (m//) at /home/batman/build_test/linux-next/scripts/checkpatch.pl line 3371. Use of uninitialized value $ms_size in pattern match (m//) at /home/batman/build_test/linux-next/scripts/checkpatch.pl line 3368. Use of uninitialized value $ms_size in pattern match (m//) at /home/batman/build_test/linux-next/scripts/checkpatch.pl line 3371. Use of uninitialized value $ms_size in pattern match (m//) at /home/batman/build_test/linux-next/scripts/checkpatch.pl line 3368. Use of uninitialized value $ms_size in pattern match (m//) at /home/batman/build_test/linux-next/scripts/checkpatch.pl line 3371. WARNING: Avoid CamelCase: <vhdr->h_vlan_TCI> #170: FILE: soft-interface.c:170: + vid = ntohs(vhdr->h_vlan_TCI) & VLAN_VID_MASK; total: 0 errors, 1 warnings, 0 checks, 662 lines checked checkpatch next translation-table.c: >>>>>>>> CHECK: Blank lines aren't necessary before a close brace '}' #116: FILE: translation-table.c:116: + +} CHECK: Blank lines aren't necessary before a close brace '}' #253: FILE: translation-table.c:253: + +} CHECK: Blank lines aren't necessary before a close brace '}' #631: FILE: translation-table.c:631: + +} CHECK: Blank lines aren't necessary before a close brace '}' #1053: FILE: translation-table.c:1053: + +} CHECK: Blank lines aren't necessary before a close brace '}' #1829: FILE: translation-table.c:1829: + +} CHECK: Blank lines aren't necessary before a close brace '}' #2356: FILE: translation-table.c:2356: + +} CHECK: Blank lines aren't necessary before a close brace '}' #2553: FILE: translation-table.c:2553: + +} total: 0 errors, 0 warnings, 7 checks, 2579 lines checked checkpatch next unicast.c: >>>>>>>> CHECK: Blank lines aren't necessary after an open brace '{' #136: FILE: unicast.c:136: + list_for_each_entry(tfp, head, list) { + CHECK: Blank lines aren't necessary after an open brace '{' #165: FILE: unicast.c:165: + if (!list_empty(head)) { + total: 0 errors, 0 warnings, 2 checks, 480 lines checked checkpatch next vis.c: >>>>>>>> Use of uninitialized value $ms_size in pattern match (m//) at /home/batman/build_test/linux-next/scripts/checkpatch.pl line 3368. Use of uninitialized value $ms_size in pattern match (m//) at /home/batman/build_test/linux-next/scripts/checkpatch.pl line 3371. Use of uninitialized value $ms_size in pattern match (m//) at /home/batman/build_test/linux-next/scripts/checkpatch.pl line 3368. Use of uninitialized value $ms_size in pattern match (m//) at /home/batman/build_test/linux-next/scripts/checkpatch.pl line 3371. Use of uninitialized value $ms_size in pattern match (m//) at /home/batman/build_test/linux-next/scripts/checkpatch.pl line 3368. Use of uninitialized value $ms_size in pattern match (m//) at /home/batman/build_test/linux-next/scripts/checkpatch.pl line 3371. Use of uninitialized value $ms_size in pattern match (m//) at /home/batman/build_test/linux-next/scripts/checkpatch.pl line 3368. Use of uninitialized value $ms_size in pattern match (m//) at /home/batman/build_test/linux-next/scripts/checkpatch.pl line 3371. Use of uninitialized value $ms_size in pattern match (m//) at /home/batman/build_test/linux-next/scripts/checkpatch.pl line 3368. Use of uninitialized value $ms_size in pattern match (m//) at /home/batman/build_test/linux-next/scripts/checkpatch.pl line 3371. Use of uninitialized value $ms_size in pattern match (m//) at /home/batman/build_test/linux-next/scripts/checkpatch.pl line 3368. Use of uninitialized value $ms_size in pattern match (m//) at /home/batman/build_test/linux-next/scripts/checkpatch.pl line 3371. Use of uninitialized value $ms_size in pattern match (m//) at /home/batman/build_test/linux-next/scripts/checkpatch.pl line 3368. Use of uninitialized value $ms_size in pattern match (m//) at /home/batman/build_test/linux-next/scripts/checkpatch.pl line 3371. Use of uninitialized value $ms_size in pattern match (m//) at /home/batman/build_test/linux-next/scripts/checkpatch.pl line 3368. Use of uninitialized value $ms_size in pattern match (m//) at /home/batman/build_test/linux-next/scripts/checkpatch.pl line 3371. Use of uninitialized value $ms_size in pattern match (m//) at /home/batman/build_test/linux-next/scripts/checkpatch.pl line 3368. Use of uninitialized value $ms_size in pattern match (m//) at /home/batman/build_test/linux-next/scripts/checkpatch.pl line 3371. Use of uninitialized value $ms_size in pattern match (m//) at /home/batman/build_test/linux-next/scripts/checkpatch.pl line 3368. Use of uninitialized value $ms_size in pattern match (m//) at /home/batman/build_test/linux-next/scripts/checkpatch.pl line 3371.

10 years, 2 months

2023

2022

2021

2020

2019

2018

2017

2016

2015

2014

2013

2012

2011

linux-merge January 2013