linux-merge January 2013

linux-merge@lists.open-mesh.org

2 participants
66 discussions

[linux-next] LinuxNextTracking branch, master, updated. next-20130115
by batman＠open-mesh.org 15 Jan '13

15 Jan '13

The following commit has been merged in the master branch: commit 39a329915889a220b5f2c3f2eb3d7fd892567715 Author: Antonio Quartulli <ordex(a)autistici.org> Date: Mon Nov 19 09:01:43 2012 +0100 batman-adv: unify and properly print hex values Values are printed in hexadecimal format in several points in the code, but they are not printed using the same format string. This patches unifies the format used for such numbers so that they look the same everywhere. Given the fact that all the variables printed as hexadecimal are 16 bit long, this is the chosen printing format: %#.4x Signed-off-by: Antonio Quartulli <ordex(a)autistici.org> Signed-off-by: Marek Lindner <lindner_marek(a)yahoo.de> diff --git a/net/batman-adv/bat_iv_ogm.c b/net/batman-adv/bat_iv_ogm.c index 7d02ebd..f2a3649 100644 --- a/net/batman-adv/bat_iv_ogm.c +++ b/net/batman-adv/bat_iv_ogm.c @@ -1033,7 +1033,7 @@ static void batadv_iv_ogm_process(const struct ethhdr *ethhdr, is_single_hop_neigh = true; batadv_dbg(BATADV_DBG_BATMAN, bat_priv, - "Received BATMAN packet via NB: %pM, IF: %s [%pM] (from OG: %pM, via prev OG: %pM, seqno %u, ttvn %u, crc %u, changes %u, td %d, TTL %d, V %d, IDF %d)\n", + "Received BATMAN packet via NB: %pM, IF: %s [%pM] (from OG: %pM, via prev OG: %pM, seqno %u, ttvn %u, crc %#.4x, changes %u, td %d, TTL %d, V %d, IDF %d)\n", ethhdr->h_source, if_incoming->net_dev->name, if_incoming->net_dev->dev_addr, batadv_ogm_packet->orig, batadv_ogm_packet->prev_sender, diff --git a/net/batman-adv/bridge_loop_avoidance.c b/net/batman-adv/bridge_loop_avoidance.c index 5aebe93..ec12c79 100644 --- a/net/batman-adv/bridge_loop_avoidance.c +++ b/net/batman-adv/bridge_loop_avoidance.c @@ -661,12 +661,12 @@ static int batadv_handle_announce(struct batadv_priv *bat_priv, crc = ntohs(*((__be16 *)(&an_addr[4]))); batadv_dbg(BATADV_DBG_BLA, bat_priv, - "handle_announce(): ANNOUNCE vid %d (sent by %pM)... CRC = %04x\n", + "handle_announce(): ANNOUNCE vid %d (sent by %pM)... CRC = %#.4x\n", vid, backbone_gw->orig, crc); if (backbone_gw->crc != crc) { batadv_dbg(BATADV_DBG_BLA, backbone_gw->bat_priv, - "handle_announce(): CRC FAILED for %pM/%d (my = %04x, sent = %04x)\n", + "handle_announce(): CRC FAILED for %pM/%d (my = %#.4x, sent = %#.4x)\n", backbone_gw->orig, backbone_gw->vid, backbone_gw->crc, crc); @@ -835,7 +835,7 @@ static int batadv_check_claim_group(struct batadv_priv *bat_priv, /* if our mesh friends mac is bigger, use it for ourselves. */ if (ntohs(bla_dst->group) > ntohs(bla_dst_own->group)) { batadv_dbg(BATADV_DBG_BLA, bat_priv, - "taking other backbones claim group: %04x\n", + "taking other backbones claim group: %#.4x\n", ntohs(bla_dst->group)); bla_dst_own->group = bla_dst->group; } @@ -1626,10 +1626,10 @@ int batadv_bla_claim_table_seq_print_text(struct seq_file *seq, void *offset) primary_addr = primary_if->net_dev->dev_addr; seq_printf(seq, - "Claims announced for the mesh %s (orig %pM, group id %04x)\n", + "Claims announced for the mesh %s (orig %pM, group id %#.4x)\n", net_dev->name, primary_addr, ntohs(bat_priv->bla.claim_dest.group)); - seq_printf(seq, " %-17s %-5s %-17s [o] (%-4s)\n", + seq_printf(seq, " %-17s %-5s %-17s [o] (%-6s)\n", "Client", "VID", "Originator", "CRC"); for (i = 0; i < hash->size; i++) { head = &hash->table[i]; @@ -1638,7 +1638,7 @@ int batadv_bla_claim_table_seq_print_text(struct seq_file *seq, void *offset) hlist_for_each_entry_rcu(claim, node, head, hash_entry) { is_own = batadv_compare_eth(claim->backbone_gw->orig, primary_addr); - seq_printf(seq, " * %pM on % 5d by %pM [%c] (%04x)\n", + seq_printf(seq, " * %pM on % 5d by %pM [%c] (%#.4x)\n", claim->addr, claim->vid, claim->backbone_gw->orig, (is_own ? 'x' : ' '), @@ -1672,10 +1672,10 @@ int batadv_bla_backbone_table_seq_print_text(struct seq_file *seq, void *offset) primary_addr = primary_if->net_dev->dev_addr; seq_printf(seq, - "Backbones announced for the mesh %s (orig %pM, group id %04x)\n", + "Backbones announced for the mesh %s (orig %pM, group id %#.4x)\n", net_dev->name, primary_addr, ntohs(bat_priv->bla.claim_dest.group)); - seq_printf(seq, " %-17s %-5s %-9s (%-4s)\n", + seq_printf(seq, " %-17s %-5s %-9s (%-6s)\n", "Originator", "VID", "last seen", "CRC"); for (i = 0; i < hash->size; i++) { head = &hash->table[i]; @@ -1693,7 +1693,7 @@ int batadv_bla_backbone_table_seq_print_text(struct seq_file *seq, void *offset) continue; seq_printf(seq, - " * %pM on % 5d % 4i.%03is (%04x)\n", + " * %pM on % 5d % 4i.%03is (%#.4x)\n", backbone_gw->orig, backbone_gw->vid, secs, msecs, backbone_gw->crc); } diff --git a/net/batman-adv/translation-table.c b/net/batman-adv/translation-table.c index 408807e..40ef955 100644 --- a/net/batman-adv/translation-table.c +++ b/net/batman-adv/translation-table.c @@ -2518,7 +2518,7 @@ void batadv_tt_update_orig(struct batadv_priv *bat_priv, orig_node->tt_crc != tt_crc) { request_table: batadv_dbg(BATADV_DBG_TT, bat_priv, - "TT inconsistency for %pM. Need to retrieve the correct information (ttvn: %u last_ttvn: %u crc: %u last_crc: %u num_changes: %u)\n", + "TT inconsistency for %pM. Need to retrieve the correct information (ttvn: %u last_ttvn: %u crc: %#.4x last_crc: %#.4x num_changes: %u)\n", orig_node->orig, ttvn, orig_ttvn, tt_crc, orig_node->tt_crc, tt_num_changes); batadv_send_tt_request(bat_priv, orig_node, ttvn, -- LinuxNextTracking

1 0

[linux-next] LinuxNextTracking branch, master, updated. next-20130115
by batman＠open-mesh.org 15 Jan '13

15 Jan '13

The following commit has been merged in the master branch: commit 8425ec6aea20f8c8e1783d7390f5ea6ca01c58e1 Author: Antonio Quartulli <ordex(a)autistici.org> Date: Mon Nov 19 09:01:44 2012 +0100 batman-adv: remove useless assignment in tt_local_add() The flag field of the tt_local_entry->common structure in tt_local_add() is first assigned NO_FLAGS and then TT_CLIENT_NEW so nullifying the first operation. For this reason it is safe to remove the first assignment. This was introuduced by ("batman-adv: keep local table consistency for further TT_RESPONSE") Signed-off-by: Antonio Quartulli <ordex(a)autistici.org> Signed-off-by: Marek Lindner <lindner_marek(a)yahoo.de> diff --git a/net/batman-adv/translation-table.c b/net/batman-adv/translation-table.c index 40ef955..5f44232 100644 --- a/net/batman-adv/translation-table.c +++ b/net/batman-adv/translation-table.c @@ -305,7 +305,11 @@ void batadv_tt_local_add(struct net_device *soft_iface, const uint8_t *addr, (uint8_t)atomic_read(&bat_priv->tt.vn)); memcpy(tt_local->common.addr, addr, ETH_ALEN); - tt_local->common.flags = BATADV_NO_FLAGS; + /* The local entry has to be marked as NEW to avoid to send it in + * a full table response going out before the next ttvn increment + * (consistency check) + */ + tt_local->common.flags = BATADV_TT_CLIENT_NEW; if (batadv_is_wifi_iface(ifindex)) tt_local->common.flags |= BATADV_TT_CLIENT_WIFI; atomic_set(&tt_local->common.refcount, 2); @@ -316,12 +320,6 @@ void batadv_tt_local_add(struct net_device *soft_iface, const uint8_t *addr, if (batadv_compare_eth(addr, soft_iface->dev_addr)) tt_local->common.flags |= BATADV_TT_CLIENT_NOPURGE; - /* The local entry has to be marked as NEW to avoid to send it in - * a full table response going out before the next ttvn increment - * (consistency check) - */ - tt_local->common.flags |= BATADV_TT_CLIENT_NEW; - hash_added = batadv_hash_add(bat_priv->tt.local_hash, batadv_compare_tt, batadv_choose_orig, &tt_local->common, &tt_local->common.hash_entry); -- LinuxNextTracking

1 0

[linux-next] LinuxNextTracking branch, master, updated. next-20130115
by batman＠open-mesh.org 15 Jan '13

15 Jan '13

The following commit has been merged in the master branch: commit dec05074b1a322f5fbbe3f81bc438a75bfec3c34 Author: Antonio Quartulli <ordex(a)autistici.org> Date: Sat Nov 10 11:00:32 2012 +0100 batman-adv: Initialize lockdep class keys for hashes Different hashes have the same class key because they get initialised with the same one. For this reason lockdep can create false warning when they are used recursively. Re-initialise the key for each hash after the invocation to hash_new() to avoid this problem. Signed-off-by: Antonio Quartulli <ordex(a)autistici.org> Tested-by: Linus Lüssing <linus.luessing(a)web.de> Signed-off-by: Marek Lindner <lindner_marek(a)yahoo.de> diff --git a/net/batman-adv/originator.c b/net/batman-adv/originator.c index 8c32cf1..109081c4 100644 --- a/net/batman-adv/originator.c +++ b/net/batman-adv/originator.c @@ -29,6 +29,9 @@ #include "soft-interface.h" #include "bridge_loop_avoidance.h" +/* hash class keys */ +static struct lock_class_key batadv_orig_hash_lock_class_key; + static void batadv_purge_orig(struct work_struct *work); static void batadv_start_purge_timer(struct batadv_priv *bat_priv) @@ -57,6 +60,9 @@ int batadv_originator_init(struct batadv_priv *bat_priv) if (!bat_priv->orig_hash) goto err; + batadv_hash_set_lock_class(bat_priv->orig_hash, + &batadv_orig_hash_lock_class_key); + batadv_start_purge_timer(bat_priv); return 0; diff --git a/net/batman-adv/translation-table.c b/net/batman-adv/translation-table.c index 5f44232..c6fd0b7 100644 --- a/net/batman-adv/translation-table.c +++ b/net/batman-adv/translation-table.c @@ -29,6 +29,10 @@ #include <linux/crc16.h> +/* hash class keys */ +static struct lock_class_key batadv_tt_local_hash_lock_class_key; +static struct lock_class_key batadv_tt_global_hash_lock_class_key; + static void batadv_send_roam_adv(struct batadv_priv *bat_priv, uint8_t *client, struct batadv_orig_node *orig_node); static void batadv_tt_purge(struct work_struct *work); @@ -235,6 +239,9 @@ static int batadv_tt_local_init(struct batadv_priv *bat_priv) if (!bat_priv->tt.local_hash) return -ENOMEM; + batadv_hash_set_lock_class(bat_priv->tt.local_hash, + &batadv_tt_local_hash_lock_class_key); + return 0; } @@ -694,6 +701,9 @@ static int batadv_tt_global_init(struct batadv_priv *bat_priv) if (!bat_priv->tt.global_hash) return -ENOMEM; + batadv_hash_set_lock_class(bat_priv->tt.global_hash, + &batadv_tt_global_hash_lock_class_key); + return 0; } diff --git a/net/batman-adv/vis.c b/net/batman-adv/vis.c index 0f65a9d..60eb9b7 100644 --- a/net/batman-adv/vis.c +++ b/net/batman-adv/vis.c @@ -28,6 +28,9 @@ #define BATADV_MAX_VIS_PACKET_SIZE 1000 +/* hash class keys */ +static struct lock_class_key batadv_vis_hash_lock_class_key; + static void batadv_start_vis_timer(struct batadv_priv *bat_priv); /* free the info */ @@ -852,6 +855,9 @@ int batadv_vis_init(struct batadv_priv *bat_priv) goto err; } + batadv_hash_set_lock_class(bat_priv->vis.hash, + &batadv_vis_hash_lock_class_key); + bat_priv->vis.my_info = kmalloc(BATADV_MAX_VIS_PACKET_SIZE, GFP_ATOMIC); if (!bat_priv->vis.my_info) goto err; -- LinuxNextTracking

1 0

[linux-next] LinuxNextTracking branch, master, updated. next-20130115
by batman＠open-mesh.org 15 Jan '13

15 Jan '13

The following commit has been merged in the master branch: commit 569174433d3bd96e206a4b5969a4498371c70d16 Author: Shan Wei <davidshan(a)tencent.com> Date: Tue Nov 13 09:53:26 2012 +0800 batman-adv: use per_cpu_add helper this_cpu_add is an atomic operation. and be more faster than per_cpu_ptr operation. Signed-off-by: Shan Wei <davidshan(a)tencent.com> Reviewed-by: Christoph Lameter <cl(a)linux.com> Signed-off-by: Sven Eckelmann <sven(a)narfation.org> Signed-off-by: Marek Lindner <lindner_marek(a)yahoo.de> Signed-off-by: Antonio Quartulli <ordex(a)autistici.org> diff --git a/net/batman-adv/main.h b/net/batman-adv/main.h index 2f85577..c4fe41f 100644 --- a/net/batman-adv/main.h +++ b/net/batman-adv/main.h @@ -276,9 +276,7 @@ static inline bool batadv_has_timed_out(unsigned long timestamp, static inline void batadv_add_counter(struct batadv_priv *bat_priv, size_t idx, size_t count) { - int cpu = get_cpu(); - per_cpu_ptr(bat_priv->bat_counters, cpu)[idx] += count; - put_cpu(); + this_cpu_add(bat_priv->bat_counters[idx], count); } #define batadv_inc_counter(b, i) batadv_add_counter(b, i, 1) -- LinuxNextTracking

1 0

[linux-next] LinuxNextTracking branch, master, updated. next-20130115
by batman＠open-mesh.org 15 Jan '13

15 Jan '13

The following commit has been merged in the master branch: commit 02233e0c75fc512ca60e7e82943f0a4395a85411 Author: Linus Lüssing <linus.luessing(a)web.de> Date: Wed Oct 17 15:07:35 2012 +0200 batman-adv: Do not add multicast MAC addresses to translation table The current translation table mechanism is not suitable for multicast addresses and we are currently flooding such frames anyway. Therefore this patch prevents multicast MAC addresses being added to the translation table. Signed-off-by: Linus Lüssing <linus.luessing(a)web.de> Acked-by: Antonio Quartulli <ordex(a)autistici.org> Signed-off-by: Marek Lindner <lindner_marek(a)yahoo.de> Signed-off-by: Antonio Quartulli <ordex(a)autistici.org> diff --git a/net/batman-adv/soft-interface.c b/net/batman-adv/soft-interface.c index 90f4049..f8cc142 100644 --- a/net/batman-adv/soft-interface.c +++ b/net/batman-adv/soft-interface.c @@ -180,7 +180,8 @@ static int batadv_interface_tx(struct sk_buff *skb, goto dropped; /* Register the client MAC in the transtable */ - batadv_tt_local_add(soft_iface, ethhdr->h_source, skb->skb_iif); + if (!is_multicast_ether_addr(ethhdr->h_source)) + batadv_tt_local_add(soft_iface, ethhdr->h_source, skb->skb_iif); /* don't accept stp packets. STP does not help in meshes. * better use the bridge loop avoidance ... -- LinuxNextTracking

1 0

[linux-next] LinuxNextTracking branch, master, updated. next-20130115
by batman＠open-mesh.org 15 Jan '13

15 Jan '13

The following commit has been merged in the master branch: commit 7cf4d520fdb72250b769920274279249629881ce Author: Antonio Quartulli <ordex(a)autistici.org> Date: Thu Nov 8 22:16:15 2012 +0100 batman-adv: reduce local TT entry timeout to 10 minutes The current timeout is set to one hour. However a client connected to the mesh network will always generate traffic. In the worst case it will send ARP requests every 4 or 5 minutes. On the other hand having a long timeout means storing dead entries for one hour and it leads to very big trans-tables containing useless clients. This patch reduces the timeout to 10 minutes Signed-off-by: Antonio Quartulli <ordex(a)autistici.org> Signed-off-by: Marek Lindner <lindner_marek(a)yahoo.de> diff --git a/net/batman-adv/main.h b/net/batman-adv/main.h index c4fe41f..d04b209 100644 --- a/net/batman-adv/main.h +++ b/net/batman-adv/main.h @@ -41,7 +41,7 @@ * -> TODO: check influence on BATADV_TQ_LOCAL_WINDOW_SIZE */ #define BATADV_PURGE_TIMEOUT 200000 /* 200 seconds */ -#define BATADV_TT_LOCAL_TIMEOUT 3600000 /* in milliseconds */ +#define BATADV_TT_LOCAL_TIMEOUT 600000 /* in milliseconds */ #define BATADV_TT_CLIENT_ROAM_TIMEOUT 600000 /* in milliseconds */ #define BATADV_TT_CLIENT_TEMP_TIMEOUT 600000 /* in milliseconds */ #define BATADV_DAT_ENTRY_TIMEOUT (5*60000) /* 5 mins in milliseconds */ -- LinuxNextTracking

1 0

Build check errors found: 2013-01-15
by postmaster＠open-mesh.org 15 Jan '13

15 Jan '13

Name of failed tests ==================== checkpatch master icmp_socket.c checkpatch master soft-interface.c checkpatch master vis.c checkpatch next icmp_socket.c checkpatch next soft-interface.c checkpatch next vis.c Output of different failed tests ================================ checkpatch next soft-interface.c: >>>>>>>> Use of uninitialized value $ms_size in pattern match (m//) at /home/batman/build_test/linux-next/scripts/checkpatch.pl line 3383. Use of uninitialized value $ms_size in pattern match (m//) at /home/batman/build_test/linux-next/scripts/checkpatch.pl line 3386. Use of uninitialized value $ms_size in pattern match (m//) at /home/batman/build_test/linux-next/scripts/checkpatch.pl line 3383. Use of uninitialized value $ms_size in pattern match (m//) at /home/batman/build_test/linux-next/scripts/checkpatch.pl line 3386. Use of uninitialized value $ms_size in pattern match (m//) at /home/batman/build_test/linux-next/scripts/checkpatch.pl line 3383. Use of uninitialized value $ms_size in pattern match (m//) at /home/batman/build_test/linux-next/scripts/checkpatch.pl line 3386. checkpatch next vis.c: >>>>>>>> Use of uninitialized value $ms_size in pattern match (m//) at /home/batman/build_test/linux-next/scripts/checkpatch.pl line 3383. Use of uninitialized value $ms_size in pattern match (m//) at /home/batman/build_test/linux-next/scripts/checkpatch.pl line 3386. Use of uninitialized value $ms_size in pattern match (m//) at /home/batman/build_test/linux-next/scripts/checkpatch.pl line 3383. Use of uninitialized value $ms_size in pattern match (m//) at /home/batman/build_test/linux-next/scripts/checkpatch.pl line 3386. Use of uninitialized value $ms_size in pattern match (m//) at /home/batman/build_test/linux-next/scripts/checkpatch.pl line 3383. Use of uninitialized value $ms_size in pattern match (m//) at /home/batman/build_test/linux-next/scripts/checkpatch.pl line 3386. Use of uninitialized value $ms_size in pattern match (m//) at /home/batman/build_test/linux-next/scripts/checkpatch.pl line 3383. Use of uninitialized value $ms_size in pattern match (m//) at /home/batman/build_test/linux-next/scripts/checkpatch.pl line 3386. Use of uninitialized value $ms_size in pattern match (m//) at /home/batman/build_test/linux-next/scripts/checkpatch.pl line 3383. Use of uninitialized value $ms_size in pattern match (m//) at /home/batman/build_test/linux-next/scripts/checkpatch.pl line 3386. Use of uninitialized value $ms_size in pattern match (m//) at /home/batman/build_test/linux-next/scripts/checkpatch.pl line 3383. Use of uninitialized value $ms_size in pattern match (m//) at /home/batman/build_test/linux-next/scripts/checkpatch.pl line 3386. Use of uninitialized value $ms_size in pattern match (m//) at /home/batman/build_test/linux-next/scripts/checkpatch.pl line 3383. Use of uninitialized value $ms_size in pattern match (m//) at /home/batman/build_test/linux-next/scripts/checkpatch.pl line 3386. Use of uninitialized value $ms_size in pattern match (m//) at /home/batman/build_test/linux-next/scripts/checkpatch.pl line 3383. Use of uninitialized value $ms_size in pattern match (m//) at /home/batman/build_test/linux-next/scripts/checkpatch.pl line 3386. Use of uninitialized value $ms_size in pattern match (m//) at /home/batman/build_test/linux-next/scripts/checkpatch.pl line 3383. Use of uninitialized value $ms_size in pattern match (m//) at /home/batman/build_test/linux-next/scripts/checkpatch.pl line 3386. Use of uninitialized value $ms_size in pattern match (m//) at /home/batman/build_test/linux-next/scripts/checkpatch.pl line 3383. Use of uninitialized value $ms_size in pattern match (m//) at /home/batman/build_test/linux-next/scripts/checkpatch.pl line 3386.

1 0

Build check errors found: 2013-01-14
by postmaster＠open-mesh.org 13 Jan '13

13 Jan '13

Name of failed tests ==================== checkpatch master bridge_loop_avoidance.c checkpatch master icmp_socket.c checkpatch master soft-interface.c checkpatch master vis.c checkpatch next bat_iv_ogm.c checkpatch next bridge_loop_avoidance.c checkpatch next debugfs.c checkpatch next icmp_socket.c checkpatch next originator.c checkpatch next routing.c checkpatch next send.c checkpatch next soft-interface.c checkpatch next translation-table.c checkpatch next unicast.c checkpatch next vis.c Output of different failed tests ================================ checkpatch master bridge_loop_avoidance.c: >>>>>>>> WARNING: Avoid CamelCase: <vhdr->h_vlan_TCI> #874: FILE: bridge_loop_avoidance.c:874: + vid = ntohs(vhdr->h_vlan_TCI) & VLAN_VID_MASK; total: 0 errors, 1 warnings, 0 checks, 1699 lines checked checkpatch master soft-interface.c: >>>>>>>> Use of uninitialized value $ms_size in pattern match (m//) at /home/batman/build_test/linux-next/scripts/checkpatch.pl line 3383. Use of uninitialized value $ms_size in pattern match (m//) at /home/batman/build_test/linux-next/scripts/checkpatch.pl line 3386. Use of uninitialized value $ms_size in pattern match (m//) at /home/batman/build_test/linux-next/scripts/checkpatch.pl line 3383. Use of uninitialized value $ms_size in pattern match (m//) at /home/batman/build_test/linux-next/scripts/checkpatch.pl line 3386. Use of uninitialized value $ms_size in pattern match (m//) at /home/batman/build_test/linux-next/scripts/checkpatch.pl line 3383. Use of uninitialized value $ms_size in pattern match (m//) at /home/batman/build_test/linux-next/scripts/checkpatch.pl line 3386. WARNING: Avoid CamelCase: <vhdr->h_vlan_TCI> #169: FILE: soft-interface.c:169: + vid = ntohs(vhdr->h_vlan_TCI) & VLAN_VID_MASK; total: 0 errors, 1 warnings, 0 checks, 692 lines checked checkpatch next bat_iv_ogm.c: >>>>>>>> CHECK: Blank lines aren't necessary after an open brace '{' #186: FILE: bat_iv_ogm.c:186: + batadv_ogm_packet->tt_num_changes)) { + CHECK: Blank lines aren't necessary after an open brace '{' #264: FILE: bat_iv_ogm.c:264: + (forw_packet->own && (forw_packet->if_incoming != primary_if))) { + CHECK: Blank lines aren't necessary after an open brace '{' #328: FILE: bat_iv_ogm.c:328: + (aggregated_bytes <= BATADV_MAX_AGGREGATION_BYTES)) { + CHECK: Blank lines aren't necessary after an open brace '{' #818: FILE: bat_iv_ogm.c:818: + &orig_neigh_node->neigh_list, list) { + CHECK: Blank lines aren't necessary after an open brace '{' #952: FILE: bat_iv_ogm.c:952: + &orig_node->neigh_list, list) { + CHECK: Blank lines aren't necessary after an open brace '{' #1226: FILE: bat_iv_ogm.c:1226: + if (is_single_hop_neigh) { + total: 0 errors, 0 warnings, 6 checks, 1349 lines checked checkpatch next bridge_loop_avoidance.c: >>>>>>>> CHECK: Blank lines aren't necessary after an open brace '{' #238: FILE: bridge_loop_avoidance.c:238: + head, hash_entry) { + CHECK: Blank lines aren't necessary before a close brace '}' #342: FILE: bridge_loop_avoidance.c:342: + + } CHECK: Blank lines aren't necessary before a close brace '}' #543: FILE: bridge_loop_avoidance.c:543: + +} CHECK: Blank lines aren't necessary before a close brace '}' #602: FILE: bridge_loop_avoidance.c:602: + + } WARNING: Avoid CamelCase: <vhdr->h_vlan_TCI> #875: FILE: bridge_loop_avoidance.c:875: + vid = ntohs(vhdr->h_vlan_TCI) & VLAN_VID_MASK; total: 0 errors, 1 warnings, 4 checks, 1706 lines checked checkpatch next debugfs.c: >>>>>>>> CHECK: Blank lines aren't necessary before a close brace '}' #168: FILE: debugfs.c:168: + + } WARNING: debugfs_remove_recursive(NULL) is safe this check is probably not required #401: FILE: debugfs.c:401: + if (batadv_debugfs) { + debugfs_remove_recursive(batadv_debugfs); total: 0 errors, 1 warnings, 1 checks, 459 lines checked checkpatch next icmp_socket.c: >>>>>>>> Use of uninitialized value $ms_size in pattern match (m//) at /home/batman/build_test/linux-next/scripts/checkpatch.pl line 3383. Use of uninitialized value $ms_size in pattern match (m//) at /home/batman/build_test/linux-next/scripts/checkpatch.pl line 3386. Use of uninitialized value $ms_size in pattern match (m//) at /home/batman/build_test/linux-next/scripts/checkpatch.pl line 3383. Use of uninitialized value $ms_size in pattern match (m//) at /home/batman/build_test/linux-next/scripts/checkpatch.pl line 3386. Use of uninitialized value $ms_size in pattern match (m//) at /home/batman/build_test/linux-next/scripts/checkpatch.pl line 3383. Use of uninitialized value $ms_size in pattern match (m//) at /home/batman/build_test/linux-next/scripts/checkpatch.pl line 3386. checkpatch next originator.c: >>>>>>>> CHECK: Blank lines aren't necessary after an open brace '{' #181: FILE: originator.c:181: + head, hash_entry) { + CHECK: Blank lines aren't necessary after an open brace '{' #288: FILE: originator.c:288: + &orig_node->neigh_list, list) { + CHECK: Blank lines aren't necessary after an open brace '{' #296: FILE: originator.c:296: + (if_incoming->if_status == BATADV_IF_TO_BE_REMOVED)) { + total: 0 errors, 0 warnings, 3 checks, 645 lines checked checkpatch next routing.c: >>>>>>>> CHECK: Blank lines aren't necessary after an open brace '{' #83: FILE: routing.c:83: + } else if ((!curr_router) && (neigh_node)) { + CHECK: Blank lines aren't necessary after an open brace '{' #175: FILE: routing.c:175: + &orig_node->neigh_list, list) { + CHECK: Blank lines aren't necessary after an open brace '{' #839: FILE: routing.c:839: + neigh_node->if_incoming->net_dev->mtu)) { + CHECK: Blank lines aren't necessary after an open brace '{' #1106: FILE: routing.c:1106: + if (batadv_is_my_mac(unicast_packet->dest)) { + total: 0 errors, 0 warnings, 4 checks, 1281 lines checked checkpatch next send.c: >>>>>>>> CHECK: Blank lines aren't necessary after an open brace '{' #333: FILE: send.c:333: + &bat_priv->forw_bcast_list, list) { + CHECK: Blank lines aren't necessary after an open brace '{' #360: FILE: send.c:360: + &bat_priv->forw_bat_list, list) { + total: 0 errors, 0 warnings, 2 checks, 382 lines checked checkpatch next soft-interface.c: >>>>>>>> Use of uninitialized value $ms_size in pattern match (m//) at /home/batman/build_test/linux-next/scripts/checkpatch.pl line 3383. Use of uninitialized value $ms_size in pattern match (m//) at /home/batman/build_test/linux-next/scripts/checkpatch.pl line 3386. Use of uninitialized value $ms_size in pattern match (m//) at /home/batman/build_test/linux-next/scripts/checkpatch.pl line 3383. Use of uninitialized value $ms_size in pattern match (m//) at /home/batman/build_test/linux-next/scripts/checkpatch.pl line 3386. Use of uninitialized value $ms_size in pattern match (m//) at /home/batman/build_test/linux-next/scripts/checkpatch.pl line 3383. Use of uninitialized value $ms_size in pattern match (m//) at /home/batman/build_test/linux-next/scripts/checkpatch.pl line 3386. WARNING: Avoid CamelCase: <vhdr->h_vlan_TCI> #170: FILE: soft-interface.c:170: + vid = ntohs(vhdr->h_vlan_TCI) & VLAN_VID_MASK; total: 0 errors, 1 warnings, 0 checks, 662 lines checked checkpatch next translation-table.c: >>>>>>>> CHECK: Blank lines aren't necessary before a close brace '}' #116: FILE: translation-table.c:116: + +} CHECK: Blank lines aren't necessary before a close brace '}' #253: FILE: translation-table.c:253: + +} CHECK: Blank lines aren't necessary before a close brace '}' #631: FILE: translation-table.c:631: + +} CHECK: Blank lines aren't necessary before a close brace '}' #1053: FILE: translation-table.c:1053: + +} CHECK: Blank lines aren't necessary before a close brace '}' #1829: FILE: translation-table.c:1829: + +} CHECK: Blank lines aren't necessary before a close brace '}' #2356: FILE: translation-table.c:2356: + +} CHECK: Blank lines aren't necessary before a close brace '}' #2553: FILE: translation-table.c:2553: + +} total: 0 errors, 0 warnings, 7 checks, 2579 lines checked checkpatch next unicast.c: >>>>>>>> CHECK: Blank lines aren't necessary after an open brace '{' #136: FILE: unicast.c:136: + list_for_each_entry(tfp, head, list) { + CHECK: Blank lines aren't necessary after an open brace '{' #165: FILE: unicast.c:165: + if (!list_empty(head)) { + total: 0 errors, 0 warnings, 2 checks, 480 lines checked checkpatch next vis.c: >>>>>>>> Use of uninitialized value $ms_size in pattern match (m//) at /home/batman/build_test/linux-next/scripts/checkpatch.pl line 3383. Use of uninitialized value $ms_size in pattern match (m//) at /home/batman/build_test/linux-next/scripts/checkpatch.pl line 3386. Use of uninitialized value $ms_size in pattern match (m//) at /home/batman/build_test/linux-next/scripts/checkpatch.pl line 3383. Use of uninitialized value $ms_size in pattern match (m//) at /home/batman/build_test/linux-next/scripts/checkpatch.pl line 3386. Use of uninitialized value $ms_size in pattern match (m//) at /home/batman/build_test/linux-next/scripts/checkpatch.pl line 3383. Use of uninitialized value $ms_size in pattern match (m//) at /home/batman/build_test/linux-next/scripts/checkpatch.pl line 3386. Use of uninitialized value $ms_size in pattern match (m//) at /home/batman/build_test/linux-next/scripts/checkpatch.pl line 3383. Use of uninitialized value $ms_size in pattern match (m//) at /home/batman/build_test/linux-next/scripts/checkpatch.pl line 3386. Use of uninitialized value $ms_size in pattern match (m//) at /home/batman/build_test/linux-next/scripts/checkpatch.pl line 3383. Use of uninitialized value $ms_size in pattern match (m//) at /home/batman/build_test/linux-next/scripts/checkpatch.pl line 3386. Use of uninitialized value $ms_size in pattern match (m//) at /home/batman/build_test/linux-next/scripts/checkpatch.pl line 3383. Use of uninitialized value $ms_size in pattern match (m//) at /home/batman/build_test/linux-next/scripts/checkpatch.pl line 3386. Use of uninitialized value $ms_size in pattern match (m//) at /home/batman/build_test/linux-next/scripts/checkpatch.pl line 3383. Use of uninitialized value $ms_size in pattern match (m//) at /home/batman/build_test/linux-next/scripts/checkpatch.pl line 3386. Use of uninitialized value $ms_size in pattern match (m//) at /home/batman/build_test/linux-next/scripts/checkpatch.pl line 3383. Use of uninitialized value $ms_size in pattern match (m//) at /home/batman/build_test/linux-next/scripts/checkpatch.pl line 3386. Use of uninitialized value $ms_size in pattern match (m//) at /home/batman/build_test/linux-next/scripts/checkpatch.pl line 3383. Use of uninitialized value $ms_size in pattern match (m//) at /home/batman/build_test/linux-next/scripts/checkpatch.pl line 3386. Use of uninitialized value $ms_size in pattern match (m//) at /home/batman/build_test/linux-next/scripts/checkpatch.pl line 3383. Use of uninitialized value $ms_size in pattern match (m//) at /home/batman/build_test/linux-next/scripts/checkpatch.pl line 3386.

1 0

Build check errors found: 2013-01-13
by postmaster＠open-mesh.org 12 Jan '13

12 Jan '13

1 0

Build check errors found: 2013-01-12
by postmaster＠open-mesh.org 12 Jan '13

12 Jan '13

1 0

2024

2023

2022

2021

2020

2019

2018

2017

2016

2015

2014

2013

2012

2011

linux-merge January 2013