CHECK: Coalesced strings are easier to grep and less error prone
#182: FILE: bat_iv_ogm.c:182:
+ "%s %spacket (originator %pM, seqno %u, TQ %d, TTL %d,"
+ " IDF %s, ttvn %d) on interface %s [%pM]\n",
CHECK: Coalesced strings are easier to grep and less error prone
#221: FILE: bat_iv_ogm.c:221:
+ pr_err("Error - can't forward packet: incoming iface not "
+ "specified\n");
CHECK: Coalesced strings are easier to grep and less error prone
#243: FILE: bat_iv_ogm.c:243:
+ "%s packet (originator %pM, seqno %u, TTL %d) "
+ "on interface %s [%pM]\n",
CHECK: Coalesced strings are easier to grep and less error prone
#558: FILE: bat_iv_ogm.c:558:
+ "Forwarding packet: tq_orig: %i, tq_avg: %i, "
+ "tq_forw: %i, ttl_orig: %i, ttl_forw: %i\n",
CHECK: Coalesced strings are easier to grep and less error prone
#639: FILE: bat_iv_ogm.c:639:
+ bat_dbg(DBG_BATMAN, bat_priv, "update_originator(): "
+ "Searching and updating originator entry of received packet\n");
CHECK: Don't begin block comments with only a /* line, use /* comment...
#834: FILE: bat_iv_ogm.c:834:
+
+ /*
CHECK: Coalesced strings are easier to grep and less error prone
#854: FILE: bat_iv_ogm.c:854:
+ "bidirectional: "
+ "orig = %-15pM neigh = %-15pM => own_bcast = %2i, "
CHECK: Coalesced strings are easier to grep and less error prone
#855: FILE: bat_iv_ogm.c:855:
+ "orig = %-15pM neigh = %-15pM => own_bcast = %2i, "
+ "real recv = %2i, local tq: %3i, asym_penalty: %3i, "
CHECK: Coalesced strings are easier to grep and less error prone
#856: FILE: bat_iv_ogm.c:856:
+ "real recv = %2i, local tq: %3i, asym_penalty: %3i, "
+ "total tq: %3i\n",
CHECK: Coalesced strings are easier to grep and less error prone
#988: FILE: bat_iv_ogm.c:988:
+ "Received BATMAN packet via NB: %pM, IF: %s [%pM] "
+ "(from OG: %pM, via prev OG: %pM, seqno %u, ttvn %u, "
CHECK: Coalesced strings are easier to grep and less error prone
#989: FILE: bat_iv_ogm.c:989:
+ "(from OG: %pM, via prev OG: %pM, seqno %u, ttvn %u, "
+ "crc %u, changes %u, td %d, TTL %d, V %d, IDF %d)\n",
CHECK: Coalesced strings are easier to grep and less error prone
#1033: FILE: bat_iv_ogm.c:1033:
+ "Drop packet: received my own broadcast (sender: %pM"
+ ")\n",
CHECK: Coalesced strings are easier to grep and less error prone
#1040: FILE: bat_iv_ogm.c:1040:
+ bat_dbg(DBG_BATMAN, bat_priv, "Drop packet: "
+ "ignoring all packets with broadcast source addr (sender: %pM"
CHECK: Coalesced strings are easier to grep and less error prone
#1041: FILE: bat_iv_ogm.c:1041:
+ "ignoring all packets with broadcast source addr (sender: %pM"
+ ")\n", ethhdr->h_source);
CHECK: Coalesced strings are easier to grep and less error prone
#1072: FILE: bat_iv_ogm.c:1072:
+ bat_dbg(DBG_BATMAN, bat_priv, "Drop packet: "
+ "originator packet from myself (via neighbor)\n");
CHECK: Coalesced strings are easier to grep and less error prone
#1080: FILE: bat_iv_ogm.c:1080:
+ "Drop packet: ignoring all rebroadcast echos (sender: "
+ "%pM)\n", ethhdr->h_source);
CHECK: Coalesced strings are easier to grep and less error prone
#1094: FILE: bat_iv_ogm.c:1094:
+ "Drop packet: packet within seqno protection time "
+ "(sender: %pM)\n", ethhdr->h_source);
CHECK: Coalesced strings are easier to grep and less error prone
#1116: FILE: bat_iv_ogm.c:1116:
+ "Drop packet: ignoring all rebroadcast packets that "
+ "may make me loop (sender: %pM)\n", ethhdr->h_source);
CHECK: Coalesced strings are easier to grep and less error prone
#1161: FILE: bat_iv_ogm.c:1161:
+ bat_dbg(DBG_BATMAN, bat_priv, "Forwarding packet: "
+ "rebroadcast neighbor packet with direct link flag\n");
total: 0 errors, 0 warnings, 19 checks, 1268 lines checked
NOTE: Ignored message types: COMPLEX_MACRO
bat_iv_ogm.c has style problems, please review.
If any of these errors are false positives, please report
them to the maintainer, see CHECKPATCH in MAINTAINERS.