linux-merge

linux-merge@lists.open-mesh.org

3 participants
7468 discussions

Build check errors found (B.A.T.M.A.N. V): 2015-11-28
by postmaster＠open-mesh.org 28 Nov '15

28 Nov '15

Name of failed tests ==================== * checkpatch batman_v ./net/batman-adv/bat_v_ogm.c Output of different failed tests ================================ checkpatch batman_v ./net/batman-adv/bat_v_ogm.c ------------------------------------------------ WARNING: line over 80 characters #317: FILE: ./net/batman-adv/bat_v_ogm.c:317: + * - throughput if the outgoing interface is the default interface WARNING: line over 80 characters #318: FILE: ./net/batman-adv/bat_v_ogm.c:318: + * (i.e. this OGM is processed for the internal table total: 0 errors, 2 warnings, 0 checks, 840 lines checked

1 0

Build check errors found: 2015-11-28
by postmaster＠open-mesh.org 28 Nov '15

28 Nov '15

Name of failed tests ==================== * difference between net-next and batadv next Output of different failed tests ================================ difference between net-next and batadv next ------------------------------------------- Documentation/networking/batman-adv.txt | 9 net/batman-adv/bat_iv_ogm.c | 92 +------ net/batman-adv/bitarray.c | 12 net/batman-adv/bitarray.h | 12 net/batman-adv/bridge_loop_avoidance.c | 282 +++++------------------ net/batman-adv/bridge_loop_avoidance.h | 2 net/batman-adv/debugfs.c | 15 - net/batman-adv/distributed-arp-table.c | 46 +-- net/batman-adv/fragmentation.c | 26 -- net/batman-adv/fragmentation.h | 2 net/batman-adv/gateway_client.c | 14 - net/batman-adv/gateway_common.c | 119 +++++---- net/batman-adv/hard-interface.c | 11 net/batman-adv/hash.h | 22 - net/batman-adv/main.c | 51 ++-- net/batman-adv/main.h | 21 - net/batman-adv/multicast.c | 35 +- net/batman-adv/multicast.h | 2 net/batman-adv/network-coding.c | 59 +--- net/batman-adv/originator.c | 241 +------------------ net/batman-adv/originator.h | 7 net/batman-adv/packet.h | 20 - net/batman-adv/routing.c | 61 +--- net/batman-adv/send.c | 32 +- net/batman-adv/send.h | 4 net/batman-adv/soft-interface.c | 18 - net/batman-adv/sysfs.c | 31 -- net/batman-adv/translation-table.c | 155 ++++-------- net/batman-adv/types.h | 90 ++----- 29 files changed, 450 insertions(+), 1041 deletions(-)

1 0

Noticed difference in packet.h in next.diff
by postmaster＠open-mesh.org 27 Nov '15

27 Nov '15

--- batman-adv_next.packet.h 2015-11-28 00:05:01.594866341 +0100 +++ batctl_next.packet.h 2015-11-28 00:05:01.774878322 +0100 @@ -72,7 +72,8 @@ * enum batadv_iv_flags - flags used in B.A.T.M.A.N. IV OGM packets * @BATADV_NOT_BEST_NEXT_HOP: flag is set when ogm packet is forwarded and was * previously received from someone else than the best neighbor. - * @BATADV_PRIMARIES_FIRST_HOP: flag unused. + * @BATADV_PRIMARIES_FIRST_HOP: flag is set when the primary interface address + * is used, and the packet travels its first hop. * @BATADV_DIRECTLINK: flag is for the first hop or if rebroadcasted from a * one hop neighbor on the interface where it was originally received. */ @@ -158,7 +159,7 @@ }; /** - * enum batadv_vlan_flags - flags for the four MSB of any vlan ID field + * batadv_vlan_flags - flags for the four MSB of any vlan ID field * @BATADV_VLAN_HAS_TAG: whether the field contains a valid vlan tag or not */ enum batadv_vlan_flags { @@ -209,11 +210,6 @@ * @version: batman-adv protocol version, part of the genereal header * @ttl: time to live for this packet, part of the genereal header * @flags: contains routing relevant flags - see enum batadv_iv_flags - * @seqno: sequence identification - * @orig: address of the source node - * @prev_sender: address of the previous sender - * @reserved: reserved byte for alignment - * @tq: transmission quality * @tvlv_len: length of tvlv data following the ogm header */ struct batadv_ogm_packet { @@ -235,7 +231,7 @@ #define BATADV_OGM_HLEN sizeof(struct batadv_ogm_packet) /** - * struct batadv_icmp_header - common members among all the ICMP packets + * batadv_icmp_header - common members among all the ICMP packets * @packet_type: batman-adv packet type, part of the general header * @version: batman-adv protocol version, part of the genereal header * @ttl: time to live for this packet, part of the genereal header @@ -261,7 +257,7 @@ }; /** - * struct batadv_icmp_packet - ICMP packet + * batadv_icmp_packet - ICMP packet * @packet_type: batman-adv packet type, part of the general header * @version: batman-adv protocol version, part of the genereal header * @ttl: time to live for this packet, part of the genereal header @@ -287,7 +283,7 @@ #define BATADV_RR_LEN 16 /** - * struct batadv_icmp_packet_rr - ICMP RouteRecord packet + * batadv_icmp_packet_rr - ICMP RouteRecord packet * @packet_type: batman-adv packet type, part of the general header * @version: batman-adv protocol version, part of the genereal header * @ttl: time to live for this packet, part of the genereal header @@ -350,7 +346,6 @@ * @u: common unicast packet header * @src: address of the source * @subtype: packet subtype - * @reserved: reserved byte for alignment */ struct batadv_unicast_4addr_packet { struct batadv_unicast_packet u; @@ -419,6 +414,7 @@ * @packet_type: batman-adv packet type, part of the general header * @version: batman-adv protocol version, part of the genereal header * @ttl: time to live for this packet, part of the genereal header + * @reserved: Align following fields to 2-byte boundaries * @first_source: original source of first included packet * @first_orig_dest: original destinal of first included packet * @first_crc: checksum of first included packet @@ -500,7 +496,7 @@ * struct batadv_tvlv_tt_data - tt data propagated through the tt tvlv container * @flags: translation table flags (see batadv_tt_data_flags) * @ttvn: translation table version number - * @num_vlan: number of announced VLANs. In the TVLV this struct is followed by + * @vlan_num: number of announced VLANs. In the TVLV this struct is followed by * one batadv_tvlv_tt_vlan_data object per announced vlan */ struct batadv_tvlv_tt_data {

1 0

Build check errors found: 2015-11-27
by postmaster＠open-mesh.org 27 Nov '15

27 Nov '15

1 0

Coverity Scan: Analysis completed for batctl
by scan-admin＠coverity.com 26 Nov '15

26 Nov '15

Your request for analysis of batctl has been completed successfully. The results are available at https://scan.coverity.com/projects/batctl Analysis Summary: New defects found: 0 Defects eliminated: 0

1 0

Coverity Scan: Analysis completed for alfred
by scan-admin＠coverity.com 26 Nov '15

26 Nov '15

Your request for analysis of alfred has been completed successfully. The results are available at https://scan.coverity.com/projects/alfred Analysis Summary: New defects found: 0 Defects eliminated: 0

1 0

Noticed difference in packet.h in next.diff
by postmaster＠open-mesh.org 26 Nov '15

26 Nov '15

--- batman-adv_next.packet.h 2015-11-27 00:05:01.203648577 +0100 +++ batctl_next.packet.h 2015-11-27 00:05:01.211649058 +0100 @@ -72,7 +72,8 @@ * enum batadv_iv_flags - flags used in B.A.T.M.A.N. IV OGM packets * @BATADV_NOT_BEST_NEXT_HOP: flag is set when ogm packet is forwarded and was * previously received from someone else than the best neighbor. - * @BATADV_PRIMARIES_FIRST_HOP: flag unused. + * @BATADV_PRIMARIES_FIRST_HOP: flag is set when the primary interface address + * is used, and the packet travels its first hop. * @BATADV_DIRECTLINK: flag is for the first hop or if rebroadcasted from a * one hop neighbor on the interface where it was originally received. */ @@ -158,7 +159,7 @@ }; /** - * enum batadv_vlan_flags - flags for the four MSB of any vlan ID field + * batadv_vlan_flags - flags for the four MSB of any vlan ID field * @BATADV_VLAN_HAS_TAG: whether the field contains a valid vlan tag or not */ enum batadv_vlan_flags { @@ -209,11 +210,6 @@ * @version: batman-adv protocol version, part of the genereal header * @ttl: time to live for this packet, part of the genereal header * @flags: contains routing relevant flags - see enum batadv_iv_flags - * @seqno: sequence identification - * @orig: address of the source node - * @prev_sender: address of the previous sender - * @reserved: reserved byte for alignment - * @tq: transmission quality * @tvlv_len: length of tvlv data following the ogm header */ struct batadv_ogm_packet { @@ -235,7 +231,7 @@ #define BATADV_OGM_HLEN sizeof(struct batadv_ogm_packet) /** - * struct batadv_icmp_header - common members among all the ICMP packets + * batadv_icmp_header - common members among all the ICMP packets * @packet_type: batman-adv packet type, part of the general header * @version: batman-adv protocol version, part of the genereal header * @ttl: time to live for this packet, part of the genereal header @@ -261,7 +257,7 @@ }; /** - * struct batadv_icmp_packet - ICMP packet + * batadv_icmp_packet - ICMP packet * @packet_type: batman-adv packet type, part of the general header * @version: batman-adv protocol version, part of the genereal header * @ttl: time to live for this packet, part of the genereal header @@ -287,7 +283,7 @@ #define BATADV_RR_LEN 16 /** - * struct batadv_icmp_packet_rr - ICMP RouteRecord packet + * batadv_icmp_packet_rr - ICMP RouteRecord packet * @packet_type: batman-adv packet type, part of the general header * @version: batman-adv protocol version, part of the genereal header * @ttl: time to live for this packet, part of the genereal header @@ -350,7 +346,6 @@ * @u: common unicast packet header * @src: address of the source * @subtype: packet subtype - * @reserved: reserved byte for alignment */ struct batadv_unicast_4addr_packet { struct batadv_unicast_packet u; @@ -419,6 +414,7 @@ * @packet_type: batman-adv packet type, part of the general header * @version: batman-adv protocol version, part of the genereal header * @ttl: time to live for this packet, part of the genereal header + * @reserved: Align following fields to 2-byte boundaries * @first_source: original source of first included packet * @first_orig_dest: original destinal of first included packet * @first_crc: checksum of first included packet @@ -500,7 +496,7 @@ * struct batadv_tvlv_tt_data - tt data propagated through the tt tvlv container * @flags: translation table flags (see batadv_tt_data_flags) * @ttvn: translation table version number - * @num_vlan: number of announced VLANs. In the TVLV this struct is followed by + * @vlan_num: number of announced VLANs. In the TVLV this struct is followed by * one batadv_tvlv_tt_vlan_data object per announced vlan */ struct batadv_tvlv_tt_data {

1 0

Build check errors found: 2015-11-26
by postmaster＠open-mesh.org 26 Nov '15

26 Nov '15

Name of failed tests ==================== * checkpatch next ./net/batman-adv/gateway_common.c * checkpatch next ./net/batman-adv/main.c * difference between net-next and batadv next Output of different failed tests ================================ checkpatch next ./net/batman-adv/gateway_common.c ------------------------------------------------- WARNING: Comparisons should place the constant on the right side of the test #92: FILE: ./net/batman-adv/gateway_common.c:92: + if (U32_MAX < ldown) { WARNING: Comparisons should place the constant on the right side of the test #142: FILE: ./net/batman-adv/gateway_common.c:142: + if (U32_MAX < lup) { total: 0 errors, 2 warnings, 0 checks, 287 lines checked checkpatch next ./net/batman-adv/main.c --------------------------------------- CHECK: 'wether' may be misspelled - perhaps 'whether'? #911: FILE: ./net/batman-adv/main.c:911: + * @ogm_source: flag indicating wether the tvlv is an ogm or a unicast packet CHECK: 'wether' may be misspelled - perhaps 'whether'? #964: FILE: ./net/batman-adv/main.c:964: + * @ogm_source: flag indicating wether the tvlv is an ogm or a unicast packet total: 0 errors, 0 warnings, 2 checks, 1284 lines checked difference between net-next and batadv next ------------------------------------------- net/batman-adv/bridge_loop_avoidance.c | 35 +++--------------------- net/batman-adv/distributed-arp-table.c | 5 --- net/batman-adv/routing.c | 19 ++----------- net/batman-adv/translation-table.c | 30 +++----------------- net/batman-adv/types.h | 2 - 5 files changed, 15 insertions(+), 76 deletions(-)

1 0

Build check errors found: 2015-11-25
by postmaster＠open-mesh.org 25 Nov '15

25 Nov '15

1 0

Build check errors found (B.A.T.M.A.N. V, patch batv_5): 2015-11-24
by postmaster＠open-mesh.org 24 Nov '15

24 Nov '15

Name of failed tests ==================== * bracket_align ecsv/batv_5 ./net/batman-adv/bat_v_elp.c * checkpatch ecsv/batv_5 ./net/batman-adv/bat_v_elp.c * checkpatch ecsv/batv_5 ./net/batman-adv/bat_v_ogm.c * headers ecsv/batv_5 * kerneldoc ecsv/batv_5 ./net/batman-adv/bat_v_ogm.c * sparse ecsv/batv_5 linux-3.16 cfg: BLA=n DAT=n DEBUG=n NC=y MCAST=n BATMAN_V=y * sparse ecsv/batv_5 linux-3.17 cfg: BLA=n DAT=n DEBUG=n NC=y MCAST=n BATMAN_V=y * sparse ecsv/batv_5 linux-3.18 cfg: BLA=n DAT=n DEBUG=n NC=y MCAST=n BATMAN_V=y * sparse ecsv/batv_5 linux-3.19 cfg: BLA=n DAT=n DEBUG=n NC=y MCAST=n BATMAN_V=y * sparse ecsv/batv_5 linux-4.0 cfg: BLA=n DAT=n DEBUG=n NC=y MCAST=n BATMAN_V=y * sparse ecsv/batv_5 linux-4.1 cfg: BLA=n DAT=n DEBUG=n NC=y MCAST=n BATMAN_V=y * sparse ecsv/batv_5 linux-4.2 cfg: BLA=n DAT=n DEBUG=n NC=y MCAST=n BATMAN_V=y * sparse ecsv/batv_5 linux-4.3 cfg: BLA=n DAT=n DEBUG=n NC=y MCAST=n BATMAN_V=y * unused_symbols ecsv/batv_5 linux-3.16 cfg: BLA=n DAT=n DEBUG=n NC=y MCAST=n BATMAN_V=y * unused_symbols ecsv/batv_5 linux-3.17 cfg: BLA=n DAT=n DEBUG=n NC=y MCAST=n BATMAN_V=y * unused_symbols ecsv/batv_5 linux-3.18 cfg: BLA=n DAT=n DEBUG=n NC=y MCAST=n BATMAN_V=y * unused_symbols ecsv/batv_5 linux-3.19 cfg: BLA=n DAT=n DEBUG=n NC=y MCAST=n BATMAN_V=y * unused_symbols ecsv/batv_5 linux-4.0 cfg: BLA=n DAT=n DEBUG=n NC=y MCAST=n BATMAN_V=y * unused_symbols ecsv/batv_5 linux-4.1 cfg: BLA=n DAT=n DEBUG=n NC=y MCAST=n BATMAN_V=y * unused_symbols ecsv/batv_5 linux-4.2 cfg: BLA=n DAT=n DEBUG=n NC=y MCAST=n BATMAN_V=y * unused_symbols ecsv/batv_5 linux-4.3 cfg: BLA=n DAT=n DEBUG=n NC=y MCAST=n BATMAN_V=y Output of different failed tests ================================ bracket_align ecsv/batv_5 ./net/batman-adv/bat_v_elp.c ------------------------------------------------------ Found wrong alignment at ./net/batman-adv/bat_v_elp.c:237, was 1 but expected 37 Found wrong alignment at ./net/batman-adv/bat_v_elp.c:239, was 1 but expected 28 Found wrong alignment at ./net/batman-adv/bat_v_elp.c:240, was 1 but expected 28 checkpatch ecsv/batv_5 ./net/batman-adv/bat_v_elp.c --------------------------------------------------- ERROR: do not use C99 // comments #235: FILE: ./net/batman-adv/bat_v_elp.c:235: +// TODO: host restarted ? WARNING: please, no space before tabs #236: FILE: ./net/batman-adv/bat_v_elp.c:236: +// ^Iif (batadv_window_protected(bat_priv, seqno_diff,$ ERROR: do not use C99 // comments #236: FILE: ./net/batman-adv/bat_v_elp.c:236: +// if (batadv_window_protected(bat_priv, seqno_diff, WARNING: please, no space before tabs #237: FILE: ./net/batman-adv/bat_v_elp.c:237: +// ^I^I^I^I &neigh->batman_seqno_reset)) {$ ERROR: do not use C99 // comments #237: FILE: ./net/batman-adv/bat_v_elp.c:237: +// &neigh->batman_seqno_reset)) { WARNING: please, no space before tabs #238: FILE: ./net/batman-adv/bat_v_elp.c:238: +// ^I^Ibatadv_dbg(BATADV_DBG_BATMAN, bat_priv,$ ERROR: do not use C99 // comments #238: FILE: ./net/batman-adv/bat_v_elp.c:238: +// batadv_dbg(BATADV_DBG_BATMAN, bat_priv, WARNING: line over 80 characters #239: FILE: ./net/batman-adv/bat_v_elp.c:239: +// "Drop ELP packet: packet within window protection time from %pM\n", WARNING: please, no space before tabs #239: FILE: ./net/batman-adv/bat_v_elp.c:239: +// ^I^I^I "Drop ELP packet: packet within window protection time from %pM\n",$ ERROR: do not use C99 // comments #239: FILE: ./net/batman-adv/bat_v_elp.c:239: +// "Drop ELP packet: packet within window protection time from %pM\n", WARNING: please, no space before tabs #240: FILE: ./net/batman-adv/bat_v_elp.c:240: +// ^I^I^I elp_packet->orig);$ ERROR: do not use C99 // comments #240: FILE: ./net/batman-adv/bat_v_elp.c:240: +// elp_packet->orig); WARNING: please, no space before tabs #241: FILE: ./net/batman-adv/bat_v_elp.c:241: +// ^I^Igoto out;$ ERROR: do not use C99 // comments #241: FILE: ./net/batman-adv/bat_v_elp.c:241: +// goto out; WARNING: please, no space before tabs #242: FILE: ./net/batman-adv/bat_v_elp.c:242: +// ^I}$ ERROR: do not use C99 // comments #242: FILE: ./net/batman-adv/bat_v_elp.c:242: +// } total: 8 errors, 8 warnings, 0 checks, 313 lines checked checkpatch ecsv/batv_5 ./net/batman-adv/bat_v_ogm.c --------------------------------------------------- WARNING: line over 80 characters #266: FILE: ./net/batman-adv/bat_v_ogm.c:266: + /* TODO: also switch route if this seqno is X newer than the last received seqno from our best next hop */ WARNING: line over 80 characters #271: FILE: ./net/batman-adv/bat_v_ogm.c:271: + router_ifinfo->bat_v.throughput >= neigh_ifinfo->bat_v.throughput) total: 0 errors, 2 warnings, 0 checks, 669 lines checked headers ecsv/batv_5 ------------------- diff --git a/net/batman-adv/bat_v_ogm.c b/net/batman-adv/bat_v_ogm.c index e7ad0e3..dbd4049 100644 --- a/net/batman-adv/bat_v_ogm.c +++ b/net/batman-adv/bat_v_ogm.c @@ -26,7 +26,6 @@ #include <linux/if_ether.h> #include <linux/jiffies.h> #include <linux/kernel.h> -#include <linux/list.h> #include <linux/netdevice.h> #include <linux/random.h> #include <linux/rculist.h> kerneldoc ecsv/batv_5 ./net/batman-adv/bat_v_ogm.c -------------------------------------------------- ./net/batman-adv/bat_v_ogm.c:392: warning: No description found for parameter 'bat_priv' ./net/batman-adv/bat_v_ogm.c:392: warning: No description found for parameter 'ethhdr' ./net/batman-adv/bat_v_ogm.c:392: warning: No description found for parameter 'ogm2' ./net/batman-adv/bat_v_ogm.c:392: warning: No description found for parameter 'orig_node' ./net/batman-adv/bat_v_ogm.c:392: warning: No description found for parameter 'neigh_node' ./net/batman-adv/bat_v_ogm.c:392: warning: Excess function parameter 'skb' description in 'batadv_v_ogm_process_per_outif' sparse ecsv/batv_5 linux-4.3 cfg: BLA=n DAT=n DEBUG=n NC=y MCAST=n BATMAN_V=y --------------------------------------------------------------------------- /home/build_test/build_env/tmp/net/batman-adv/bat_v_ogm.c:411:38: warning: incorrect type in argument 3 (different base types) /home/build_test/build_env/tmp/net/batman-adv/bat_v_ogm.c:411:38: expected signed int [signed] [usertype] [explicitly-signed] seq_old_max_diff /home/build_test/build_env/tmp/net/batman-adv/bat_v_ogm.c:411:38: got unsigned long *<noident> /home/build_test/build_env/tmp/net/batman-adv/bat_v_ogm.c:410:36: error: not enough arguments for function batadv_window_protected /home/build_test/build_env/tmp/net/batman-adv/bat_v_ogm.c: In function 'batadv_v_ogm_process_per_outif': /home/build_test/build_env/tmp/net/batman-adv/bat_v_ogm.c:411:9: warning: passing argument 3 of 'batadv_window_protected' makes integer from pointer without a cast &orig_ifinfo->batman_seqno_reset)) { ^ In file included from /home/build_test/build_env/tmp/net/batman-adv/bat_v_ogm.c:45:0: /home/build_test/build_env/tmp/net/batman-adv/routing.h:54:5: note: expected 's32' but argument is of type 'long unsigned int *' int batadv_window_protected(struct batadv_priv *bat_priv, s32 seq_num_diff, ^ /home/build_test/build_env/tmp/net/batman-adv/bat_v_ogm.c:410:6: error: too few arguments to function 'batadv_window_protected' batadv_window_protected(bat_priv, seq_diff, ^ In file included from /home/build_test/build_env/tmp/net/batman-adv/bat_v_ogm.c:45:0: /home/build_test/build_env/tmp/net/batman-adv/routing.h:54:5: note: declared here int batadv_window_protected(struct batadv_priv *bat_priv, s32 seq_num_diff, ^ make[2]: *** [/home/build_test/build_env/tmp/net/batman-adv/bat_v_ogm.o] Error 1 make[1]: *** [_module_/home/build_test/build_env/tmp/net/batman-adv] Error 2 make: *** [all] Error 2 unused_symbols ecsv/batv_5 linux-4.3 cfg: BLA=n DAT=n DEBUG=n NC=y MCAST=n BATMAN_V=y --------------------------------------------------------------------------- batadv_iv_init batadv_v_init batadv_v_mesh_free batadv_v_mesh_init

1 0

Jump to page:

2025

2024

2023

2022

2021

2020

2019

2018

2017

2016

2015

2014

2013

2012

2011

linux-merge