linux-merge October 2024

linux-merge@lists.open-mesh.org

3 participants
45 discussions

[linux-next] LinuxNextTracking branch, master, updated. next-20241016
by batman＠open-mesh.org 16 Oct '24

16 Oct '24

The following commit has been merged in the master branch: commit 4436df478860bb5da1864df2cd20f281a210f139 Author: Erick Archer <erick.archer(a)outlook.com> Date: Fri Jun 7 18:19:12 2024 +0200 batman-adv: Add flex array to struct batadv_tvlv_tt_data The "struct batadv_tvlv_tt_data" uses a dynamically sized set of trailing elements. Specifically, it uses an array of structures of type "batadv_tvlv_tt_vlan_data". So, use the preferred way in the kernel declaring a flexible array [1]. At the same time, prepare for the coming implementation by GCC and Clang of the __counted_by attribute. Flexible array members annotated with __counted_by can have their accesses bounds-checked at run-time via CONFIG_UBSAN_BOUNDS (for array indexing) and CONFIG_FORTIFY_SOURCE (for strcpy/memcpy-family functions). In this case, it is important to note that the attribute used is specifically __counted_by_be since variable "num_vlan" is of type __be16. The following change to the "batadv_tt_tvlv_ogm_handler_v1" function: - tt_vlan = (struct batadv_tvlv_tt_vlan_data *)(tt_data + 1); - tt_change = (struct batadv_tvlv_tt_change *)(tt_vlan + num_vlan); + tt_change = (struct batadv_tvlv_tt_change *)((void *)tt_data + + flex_size); is intended to prevent the compiler from generating an "out-of-bounds" notification due to the __counted_by attribute. The compiler can do a pointer calculation using the vlan_data flexible array memory, or in other words, this may be calculated as an array offset, since it is the same as: &tt_data->vlan_data[num_vlan] Therefore, we go past the end of the array. In other "multiple trailing flexible array" situations, this has been solved by addressing from the base pointer, since the compiler either knows the full allocation size or it knows nothing about it (this case, since it came from a "void *" function argument). The order in which the structure batadv_tvlv_tt_data and the structure batadv_tvlv_tt_vlan_data are defined must be swap to avoid an incomplete type error. Also, avoid the open-coded arithmetic in memory allocator functions [2] using the "struct_size" macro and use the "flex_array_size" helper to clarify some calculations, when possible. Moreover, the new structure member also allow us to avoid the open-coded arithmetic on pointers in some situations. Take advantage of this. This code was detected with the help of Coccinelle, and audited and modified manually. Link: https://www.kernel.org/doc/html/next/process/deprecated.html#zero-length-an… [1] Link: https://www.kernel.org/doc/html/next/process/deprecated.html#open-coded-ari… [2] Reviewed-by: Kees Cook <keescook(a)chromium.org> Signed-off-by: Erick Archer <erick.archer(a)outlook.com> Signed-off-by: Sven Eckelmann <sven(a)narfation.org> Signed-off-by: Simon Wunderlich <sw(a)simonwunderlich.de> diff --git a/include/uapi/linux/batadv_packet.h b/include/uapi/linux/batadv_packet.h index 6e25753015dfa..439132a819eac 100644 --- a/include/uapi/linux/batadv_packet.h +++ b/include/uapi/linux/batadv_packet.h @@ -9,6 +9,7 @@ #include <asm/byteorder.h> #include <linux/if_ether.h> +#include <linux/stddef.h> #include <linux/types.h> /** @@ -592,19 +593,6 @@ struct batadv_tvlv_gateway_data { __be32 bandwidth_up; }; -/** - * struct batadv_tvlv_tt_data - tt data propagated through the tt tvlv container - * @flags: translation table flags (see batadv_tt_data_flags) - * @ttvn: translation table version number - * @num_vlan: number of announced VLANs. In the TVLV this struct is followed by - * one batadv_tvlv_tt_vlan_data object per announced vlan - */ -struct batadv_tvlv_tt_data { - __u8 flags; - __u8 ttvn; - __be16 num_vlan; -}; - /** * struct batadv_tvlv_tt_vlan_data - vlan specific tt data propagated through * the tt tvlv container @@ -618,6 +606,21 @@ struct batadv_tvlv_tt_vlan_data { __u16 reserved; }; +/** + * struct batadv_tvlv_tt_data - tt data propagated through the tt tvlv container + * @flags: translation table flags (see batadv_tt_data_flags) + * @ttvn: translation table version number + * @num_vlan: number of announced VLANs. In the TVLV this struct is followed by + * one batadv_tvlv_tt_vlan_data object per announced vlan + * @vlan_data: array of batadv_tvlv_tt_vlan_data objects + */ +struct batadv_tvlv_tt_data { + __u8 flags; + __u8 ttvn; + __be16 num_vlan; + struct batadv_tvlv_tt_vlan_data vlan_data[] __counted_by_be(num_vlan); +}; + /** * struct batadv_tvlv_tt_change - translation table diff data * @flags: status indicators concerning the non-mesh client (see diff --git a/net/batman-adv/translation-table.c b/net/batman-adv/translation-table.c index 2243cec18ecc8..6815d1262feba 100644 --- a/net/batman-adv/translation-table.c +++ b/net/batman-adv/translation-table.c @@ -28,6 +28,7 @@ #include <linux/net.h> #include <linux/netdevice.h> #include <linux/netlink.h> +#include <linux/overflow.h> #include <linux/rculist.h> #include <linux/rcupdate.h> #include <linux/skbuff.h> @@ -856,8 +857,7 @@ batadv_tt_prepare_tvlv_global_data(struct batadv_orig_node *orig_node, num_entries += atomic_read(&vlan->tt.num_entries); } - change_offset = sizeof(**tt_data); - change_offset += num_vlan * sizeof(*tt_vlan); + change_offset = struct_size(*tt_data, vlan_data, num_vlan); /* if tt_len is negative, allocate the space needed by the full table */ if (*tt_len < 0) @@ -876,7 +876,7 @@ batadv_tt_prepare_tvlv_global_data(struct batadv_orig_node *orig_node, (*tt_data)->ttvn = atomic_read(&orig_node->last_ttvn); (*tt_data)->num_vlan = htons(num_vlan); - tt_vlan = (struct batadv_tvlv_tt_vlan_data *)(*tt_data + 1); + tt_vlan = (*tt_data)->vlan_data; hlist_for_each_entry(vlan, &orig_node->vlan_list, list) { tt_vlan->vid = htons(vlan->vid); tt_vlan->crc = htonl(vlan->tt.crc); @@ -936,8 +936,7 @@ batadv_tt_prepare_tvlv_local_data(struct batadv_priv *bat_priv, total_entries += vlan_entries; } - change_offset = sizeof(**tt_data); - change_offset += num_vlan * sizeof(*tt_vlan); + change_offset = struct_size(*tt_data, vlan_data, num_vlan); /* if tt_len is negative, allocate the space needed by the full table */ if (*tt_len < 0) @@ -956,7 +955,7 @@ batadv_tt_prepare_tvlv_local_data(struct batadv_priv *bat_priv, (*tt_data)->ttvn = atomic_read(&bat_priv->tt.vn); (*tt_data)->num_vlan = htons(num_vlan); - tt_vlan = (struct batadv_tvlv_tt_vlan_data *)(*tt_data + 1); + tt_vlan = (*tt_data)->vlan_data; hlist_for_each_entry(vlan, &bat_priv->softif_vlan_list, list) { vlan_entries = atomic_read(&vlan->tt.num_entries); if (vlan_entries < 1) @@ -2916,7 +2915,6 @@ static bool batadv_send_tt_request(struct batadv_priv *bat_priv, { struct batadv_tvlv_tt_data *tvlv_tt_data = NULL; struct batadv_tt_req_node *tt_req_node = NULL; - struct batadv_tvlv_tt_vlan_data *tt_vlan_req; struct batadv_hard_iface *primary_if; bool ret = false; int i, size; @@ -2932,7 +2930,7 @@ static bool batadv_send_tt_request(struct batadv_priv *bat_priv, if (!tt_req_node) goto out; - size = sizeof(*tvlv_tt_data) + sizeof(*tt_vlan_req) * num_vlan; + size = struct_size(tvlv_tt_data, vlan_data, num_vlan); tvlv_tt_data = kzalloc(size, GFP_ATOMIC); if (!tvlv_tt_data) goto out; @@ -2944,12 +2942,10 @@ static bool batadv_send_tt_request(struct batadv_priv *bat_priv, /* send all the CRCs within the request. This is needed by intermediate * nodes to ensure they have the correct table before replying */ - tt_vlan_req = (struct batadv_tvlv_tt_vlan_data *)(tvlv_tt_data + 1); for (i = 0; i < num_vlan; i++) { - tt_vlan_req->vid = tt_vlan->vid; - tt_vlan_req->crc = tt_vlan->crc; + tvlv_tt_data->vlan_data[i].vid = tt_vlan->vid; + tvlv_tt_data->vlan_data[i].crc = tt_vlan->crc; - tt_vlan_req++; tt_vlan++; } @@ -3001,7 +2997,6 @@ static bool batadv_send_other_tt_response(struct batadv_priv *bat_priv, struct batadv_orig_node *res_dst_orig_node = NULL; struct batadv_tvlv_tt_change *tt_change; struct batadv_tvlv_tt_data *tvlv_tt_data = NULL; - struct batadv_tvlv_tt_vlan_data *tt_vlan; bool ret = false, full_table; u8 orig_ttvn, req_ttvn; u16 tvlv_len; @@ -3024,10 +3019,9 @@ static bool batadv_send_other_tt_response(struct batadv_priv *bat_priv, orig_ttvn = (u8)atomic_read(&req_dst_orig_node->last_ttvn); req_ttvn = tt_data->ttvn; - tt_vlan = (struct batadv_tvlv_tt_vlan_data *)(tt_data + 1); /* this node doesn't have the requested data */ if (orig_ttvn != req_ttvn || - !batadv_tt_global_check_crc(req_dst_orig_node, tt_vlan, + !batadv_tt_global_check_crc(req_dst_orig_node, tt_data->vlan_data, ntohs(tt_data->num_vlan))) goto out; @@ -3370,7 +3364,6 @@ static void batadv_handle_tt_response(struct batadv_priv *bat_priv, struct batadv_orig_node *orig_node = NULL; struct batadv_tvlv_tt_change *tt_change; u8 *tvlv_ptr = (u8 *)tt_data; - u16 change_offset; batadv_dbg(BATADV_DBG_TT, bat_priv, "Received TT_RESPONSE from %pM for ttvn %d t_size: %d [%c]\n", @@ -3383,10 +3376,7 @@ static void batadv_handle_tt_response(struct batadv_priv *bat_priv, spin_lock_bh(&orig_node->tt_lock); - change_offset = sizeof(struct batadv_tvlv_tt_vlan_data); - change_offset *= ntohs(tt_data->num_vlan); - change_offset += sizeof(*tt_data); - tvlv_ptr += change_offset; + tvlv_ptr += struct_size(tt_data, vlan_data, ntohs(tt_data->num_vlan)); tt_change = (struct batadv_tvlv_tt_change *)tvlv_ptr; if (tt_data->flags & BATADV_TT_FULL_TABLE) { @@ -3985,10 +3975,10 @@ static void batadv_tt_tvlv_ogm_handler_v1(struct batadv_priv *bat_priv, u8 flags, void *tvlv_value, u16 tvlv_value_len) { - struct batadv_tvlv_tt_vlan_data *tt_vlan; struct batadv_tvlv_tt_change *tt_change; struct batadv_tvlv_tt_data *tt_data; u16 num_entries, num_vlan; + size_t flex_size; if (tvlv_value_len < sizeof(*tt_data)) return; @@ -3998,17 +3988,18 @@ static void batadv_tt_tvlv_ogm_handler_v1(struct batadv_priv *bat_priv, num_vlan = ntohs(tt_data->num_vlan); - if (tvlv_value_len < sizeof(*tt_vlan) * num_vlan) + flex_size = flex_array_size(tt_data, vlan_data, num_vlan); + if (tvlv_value_len < flex_size) return; - tt_vlan = (struct batadv_tvlv_tt_vlan_data *)(tt_data + 1); - tt_change = (struct batadv_tvlv_tt_change *)(tt_vlan + num_vlan); - tvlv_value_len -= sizeof(*tt_vlan) * num_vlan; + tt_change = (struct batadv_tvlv_tt_change *)((void *)tt_data + + flex_size); + tvlv_value_len -= flex_size; num_entries = batadv_tt_entries(tvlv_value_len); - batadv_tt_update_orig(bat_priv, orig, tt_vlan, num_vlan, tt_change, - num_entries, tt_data->ttvn); + batadv_tt_update_orig(bat_priv, orig, tt_data->vlan_data, num_vlan, + tt_change, num_entries, tt_data->ttvn); } /** @@ -4039,8 +4030,8 @@ static int batadv_tt_tvlv_unicast_handler_v1(struct batadv_priv *bat_priv, tt_data = tvlv_value; tvlv_value_len -= sizeof(*tt_data); - tt_vlan_len = sizeof(struct batadv_tvlv_tt_vlan_data); - tt_vlan_len *= ntohs(tt_data->num_vlan); + tt_vlan_len = flex_array_size(tt_data, vlan_data, + ntohs(tt_data->num_vlan)); if (tvlv_value_len < tt_vlan_len) return NET_RX_SUCCESS; -- LinuxNextTracking

1 0

[linux-next] LinuxNextTracking branch, master, updated. next-20241016
by batman＠open-mesh.org 16 Oct '24

16 Oct '24

The following commit has been merged in the master branch: commit 0f4e6f94760026b4c46873bc21b440e6cef9c0b6 Author: Simon Wunderlich <sw(a)simonwunderlich.de> Date: Mon Jun 3 10:16:14 2024 +0200 batman-adv: Start new development cycle This version will contain all the (major or even only minor) changes for Linux 6.13. The version number isn't a semantic version number with major and minor information. It is just encoding the year of the expected publishing as Linux -rc1 and the number of published versions this year (starting at 0). Signed-off-by: Simon Wunderlich <sw(a)simonwunderlich.de> diff --git a/net/batman-adv/main.h b/net/batman-adv/main.h index 3d4c36ae2e1ad..97ea71a052f8c 100644 --- a/net/batman-adv/main.h +++ b/net/batman-adv/main.h @@ -13,7 +13,7 @@ #define BATADV_DRIVER_DEVICE "batman-adv" #ifndef BATADV_SOURCE_VERSION -#define BATADV_SOURCE_VERSION "2024.2" +#define BATADV_SOURCE_VERSION "2024.3" #endif /* B.A.T.M.A.N. parameters */ -- LinuxNextTracking

1 0

Build check errors found: 2024-10-16
by postmaster＠open-mesh.org 16 Oct '24

16 Oct '24

Name of failed tests ==================== main ---- * difference between net-next and batadv main stable ------ * difference between net and batadv stable Output of different failed tests ================================ stable: difference between net and batadv stable ------------------------------------------------ net/net/batman-adv/distributed-arp-table.c | 2 +- net/net/batman-adv/main.h | 2 +- 2 files changed, 2 insertions(+), 2 deletions(-) main: difference between net-next and batadv main ------------------------------------------------- netnext/net/batman-adv/distributed-arp-table.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) Statistics ========== main ---- Failed tests: 1 Started build tests: 224 Tested Linux versions: 43 Tested configs: 108 stable ------ Failed tests: 1 Started build tests: 251 Tested Linux versions: 43 Tested configs: 111

1 0

[linux-next] LinuxNextTracking branch, master, updated. next-20241015
by batman＠open-mesh.org 15 Oct '24

15 Oct '24

The following commit has been merged in the master branch: commit 6485cf5ea253d40d507cd71253c9568c5470cd27 Merge: 8e929cb546ee42c9a61d24fae60605e9e3192354 2934b12281abf4eb5f915086fd5699de5c497ccd Author: Linus Torvalds <torvalds(a)linux-foundation.org> Date: Sun Oct 13 16:35:20 2024 -0700 Merge tag 'hid-for-linus-2024101301' of git://git.kernel.org/pub/scm/linux/kernel/git/hid/hid Pull HID fixes from Jiri Kosina: - fix for memory corruption regression in amd_sfh driver (Basavaraj Natikar) - fix for mis-reporting of BTN_TOOL_PEN and BTN_TOOL_RUBBER for AES sensors tools in Wacom driver (Jason Gerecke) - fix for unitialized variable use in intel-ish-hid driver (SurajSonawane2415) - a few device-specific quirks / device ID additions * tag 'hid-for-linus-2024101301' of git://git.kernel.org/pub/scm/linux/kernel/git/hid/hid: HID: wacom: Hardcode (non-inverted) AES pens as BTN_TOOL_PEN HID: amd_sfh: Switch to device-managed dmam_alloc_coherent() HID: multitouch: Add quirk for HONOR MagicBook Art 14 touchpad HID: multitouch: Add support for B2402FVA track point HID: plantronics: Workaround for an unexcepted opposite volume key hid: intel-ish-hid: Fix uninitialized variable 'rv' in ish_fw_xfer_direct_dma -- LinuxNextTracking

1 0

Coverity Scan: Analysis completed for batctl
by scan-admin＠coverity.com 15 Oct '24

15 Oct '24

Your request for analysis of batctl has been completed successfully. The results are available at https://u15810271.ct.sendgrid.net/ls/click?upn=u001.AxU2LYlgjL6eX23u9ErQy-2… Build ID: 647644 Analysis Summary: New defects found: 0 Defects eliminated: 0

1 0

Coverity Scan: Analysis completed for alfred
by scan-admin＠coverity.com 15 Oct '24

15 Oct '24

Your request for analysis of alfred has been completed successfully. The results are available at https://u15810271.ct.sendgrid.net/ls/click?upn=u001.AxU2LYlgjL6eX23u9ErQy-2… Build ID: 647643 Analysis Summary: New defects found: 0 Defects eliminated: 0

1 0

Build check errors found: 2024-10-15
by postmaster＠open-mesh.org 15 Oct '24

15 Oct '24

Name of failed tests ==================== main ---- * coccicheck * difference between net-next and batadv main stable ------ * difference between net and batadv stable * sparse v6.12-rc1 cfg: BLA=n DAT=n DEBUG=y TRACING=y NC=y MCAST=y BATMAN_V=n * sparse v6.12-rc1 cfg: BLA=n DAT=y DEBUG=y TRACING=y NC=y MCAST=y BATMAN_V=n * sparse v6.12-rc1 cfg: BLA=y DAT=y DEBUG=n TRACING=n NC=n MCAST=y BATMAN_V=n * unused_symbols v6.12-rc1 cfg: BLA=n DAT=n DEBUG=y TRACING=y NC=y MCAST=y BATMAN_V=n * unused_symbols v6.12-rc1 cfg: BLA=n DAT=y DEBUG=y TRACING=y NC=y MCAST=y BATMAN_V=n * unused_symbols v6.12-rc1 cfg: BLA=y DAT=y DEBUG=n TRACING=n NC=n MCAST=y BATMAN_V=n Output of different failed tests ================================ main: coccicheck ---------------- /home/build_test/build_env/tmp.PkZBHG7CRT/./net/batman-adv/bridge_loop_avoidance.c:1956:6-34: opportunity for str_yes_no(batadv_is_my_client ( bat_priv , ethhdr -> h_source , vid )) /home/build_test/build_env/tmp.PkZBHG7CRT/./net/batman-adv/bat_iv_ogm.c:374:7-53: opportunity for str_on_off(( batadv_ogm_packet -> flags & BATADV_DIRECTLINK )) stable: difference between net and batadv stable ------------------------------------------------ net/net/batman-adv/distributed-arp-table.c | 2 +- net/net/batman-adv/soft-interface.c | 5 +++-- 2 files changed, 4 insertions(+), 3 deletions(-) main: difference between net-next and batadv main ------------------------------------------------- netnext/net/batman-adv/distributed-arp-table.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) stable: sparse v6.12-rc1 cfg: BLA=y DAT=y DEBUG=n TRACING=n NC=n MCAST=y BATMAN_V=n --------------------------------------------------------------------------- /home/build_test/build_env/tmp.PkZBHG7CRT/net/batman-adv/soft-interface.c: In function ‘batadv_softif_init_early’: /home/build_test/build_env/tmp.PkZBHG7CRT/net/batman-adv/soft-interface.c:1023:56: error: ‘NETIF_F_NETNS_LOCAL’ undeclared (first use in this function) 1023 | dev->features |= NETIF_F_HW_VLAN_CTAG_FILTER | NETIF_F_NETNS_LOCAL; | ^~~~~~~~~~~~~~~~~~~ /home/build_test/build_env/tmp.PkZBHG7CRT/net/batman-adv/soft-interface.c:1023:56: note: each undeclared identifier is reported only once for each function it appears in /home/build_test/build_env/tmp.PkZBHG7CRT/net/batman-adv/soft-interface.c:1024:26: error: ‘NETIF_F_LLTX’ undeclared (first use in this function); did you mean ‘NETIF_F_LRO’? 1024 | dev->features |= NETIF_F_LLTX; | ^~~~~~~~~~~~ | NETIF_F_LRO make[4]: *** [scripts/Makefile.build:229: /home/build_test/build_env/tmp.PkZBHG7CRT/net/batman-adv/soft-interface.o] Error 1 make[3]: *** [scripts/Makefile.build:478: /home/build_test/build_env/tmp.PkZBHG7CRT/net/batman-adv] Error 2 make[2]: *** [/home/build_test/build_env/linux-build/linux/v6.12-rc1/Makefile:1936: /home/build_test/build_env/tmp.PkZBHG7CRT] Error 2 make[1]: *** [Makefile:224: __sub-make] Error 2 make: *** [Makefile:68: all] Error 2 stable: unused_symbols v6.12-rc1 cfg: BLA=n DAT=n DEBUG=y TRACING=y NC=y MCAST=y BATMAN_V=n --------------------------------------------------------------------------- batadv_algo_get batadv_algo_select batadv_gw_dhcp_recipient_get batadv_gw_out_of_range batadv_hardif_disable_interface batadv_hardif_enable_interface batadv_hardif_min_mtu batadv_mcast_forw_mcsend batadv_mcast_forw_mode batadv_mcast_forw_send batadv_mesh_free batadv_mesh_init batadv_nc_init_bat_priv batadv_netlink_tpmeter_notify batadv_orig_node_vlan_get batadv_orig_node_vlan_new batadv_orig_node_vlan_release batadv_routing_algo batadv_send_bcast_packet batadv_send_skb_via_gw batadv_send_skb_via_tt_generic batadv_vlan_ap_isola_get stable: unused_symbols v6.12-rc1 cfg: BLA=n DAT=y DEBUG=y TRACING=y NC=y MCAST=y BATMAN_V=n --------------------------------------------------------------------------- batadv_algo_get batadv_algo_select batadv_dat_snoop_outgoing_arp_reply batadv_dat_snoop_outgoing_arp_request batadv_dat_snoop_outgoing_dhcp_ack batadv_gw_dhcp_recipient_get batadv_gw_out_of_range batadv_hardif_disable_interface batadv_hardif_enable_interface batadv_hardif_min_mtu batadv_mcast_forw_mcsend batadv_mcast_forw_mode batadv_mcast_forw_send batadv_mesh_free batadv_mesh_init batadv_nc_init_bat_priv batadv_netlink_tpmeter_notify batadv_orig_node_vlan_get batadv_orig_node_vlan_new batadv_orig_node_vlan_release batadv_routing_algo batadv_send_bcast_packet batadv_send_skb_via_gw batadv_vlan_ap_isola_get stable: unused_symbols v6.12-rc1 cfg: BLA=y DAT=y DEBUG=n TRACING=n NC=n MCAST=y BATMAN_V=n --------------------------------------------------------------------------- batadv_algo_get batadv_algo_select batadv_bla_rx batadv_bla_tx batadv_dat_snoop_outgoing_arp_reply batadv_dat_snoop_outgoing_arp_request batadv_dat_snoop_outgoing_dhcp_ack batadv_gw_dhcp_recipient_get batadv_gw_out_of_range batadv_hardif_disable_interface batadv_hardif_enable_interface batadv_hardif_min_mtu batadv_mcast_forw_mcsend batadv_mcast_forw_mode batadv_mcast_forw_send batadv_mesh_free batadv_mesh_init batadv_netlink_tpmeter_notify batadv_orig_node_vlan_get batadv_orig_node_vlan_new batadv_orig_node_vlan_release batadv_routing_algo batadv_send_bcast_packet batadv_send_skb_via_gw batadv_vlan_ap_isola_get Statistics ========== main ---- Failed tests: 2 Started build tests: 212 Tested Linux versions: 42 Tested configs: 110 stable ------ Failed tests: 7 Started build tests: 252 Tested Linux versions: 43 Tested configs: 105

1 0

Coverity Scan: Analysis completed for batman-adv
by scan-admin＠coverity.com 14 Oct '24

14 Oct '24

Your request for analysis of batman-adv has been completed successfully. The results are available at https://u15810271.ct.sendgrid.net/ls/click?upn=u001.AxU2LYlgjL6eX23u9ErQy-2… Build ID: 647426 Analysis Summary: New defects found: 0 Defects eliminated: 0

1 0

Build check errors found: 2024-10-14
by postmaster＠open-mesh.org 14 Oct '24

14 Oct '24

Name of failed tests ==================== stable ------ * difference between net and batadv stable * sparse v6.12-rc1 cfg: BLA=n DAT=n DEBUG=y TRACING=n NC=n MCAST=y BATMAN_V=n * sparse v6.12-rc1 cfg: BLA=n DAT=y DEBUG=y TRACING=n NC=y MCAST=y BATMAN_V=y * sparse v6.12-rc1 cfg: BLA=y DAT=n DEBUG=n TRACING=y NC=y MCAST=n BATMAN_V=n * sparse v6.12-rc1 cfg: BLA=y DAT=y DEBUG=n TRACING=y NC=y MCAST=y BATMAN_V=n * sparse v6.12-rc1 cfg: BLA=y DAT=y DEBUG=y TRACING=y NC=n MCAST=y BATMAN_V=y * unused_symbols v6.12-rc1 cfg: BLA=n DAT=n DEBUG=y TRACING=n NC=n MCAST=y BATMAN_V=n * unused_symbols v6.12-rc1 cfg: BLA=n DAT=y DEBUG=y TRACING=n NC=y MCAST=y BATMAN_V=y * unused_symbols v6.12-rc1 cfg: BLA=y DAT=n DEBUG=n TRACING=y NC=y MCAST=n BATMAN_V=n * unused_symbols v6.12-rc1 cfg: BLA=y DAT=y DEBUG=n TRACING=y NC=y MCAST=y BATMAN_V=n * unused_symbols v6.12-rc1 cfg: BLA=y DAT=y DEBUG=y TRACING=y NC=n MCAST=y BATMAN_V=y main ---- * coccicheck * difference between net-next and batadv main Output of different failed tests ================================ main: coccicheck ---------------- /home/build_test/build_env/tmp.8uaXd4iRBo/./net/batman-adv/bridge_loop_avoidance.c:1956:6-34: opportunity for str_yes_no(batadv_is_my_client ( bat_priv , ethhdr -> h_source , vid )) /home/build_test/build_env/tmp.8uaXd4iRBo/./net/batman-adv/bat_iv_ogm.c:374:7-53: opportunity for str_on_off(( batadv_ogm_packet -> flags & BATADV_DIRECTLINK )) stable: difference between net and batadv stable ------------------------------------------------ net/net/batman-adv/distributed-arp-table.c | 2 +- net/net/batman-adv/soft-interface.c | 5 +++-- 2 files changed, 4 insertions(+), 3 deletions(-) main: difference between net-next and batadv main ------------------------------------------------- netnext/net/batman-adv/distributed-arp-table.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) stable: sparse v6.12-rc1 cfg: BLA=y DAT=n DEBUG=n TRACING=y NC=y MCAST=n BATMAN_V=n --------------------------------------------------------------------------- /home/build_test/build_env/tmp.8uaXd4iRBo/net/batman-adv/soft-interface.c: In function ‘batadv_softif_init_early’: /home/build_test/build_env/tmp.8uaXd4iRBo/net/batman-adv/soft-interface.c:1023:56: error: ‘NETIF_F_NETNS_LOCAL’ undeclared (first use in this function) 1023 | dev->features |= NETIF_F_HW_VLAN_CTAG_FILTER | NETIF_F_NETNS_LOCAL; | ^~~~~~~~~~~~~~~~~~~ /home/build_test/build_env/tmp.8uaXd4iRBo/net/batman-adv/soft-interface.c:1023:56: note: each undeclared identifier is reported only once for each function it appears in /home/build_test/build_env/tmp.8uaXd4iRBo/net/batman-adv/soft-interface.c:1024:26: error: ‘NETIF_F_LLTX’ undeclared (first use in this function); did you mean ‘NETIF_F_LRO’? 1024 | dev->features |= NETIF_F_LLTX; | ^~~~~~~~~~~~ | NETIF_F_LRO make[4]: *** [scripts/Makefile.build:229: /home/build_test/build_env/tmp.8uaXd4iRBo/net/batman-adv/soft-interface.o] Error 1 make[3]: *** [scripts/Makefile.build:478: /home/build_test/build_env/tmp.8uaXd4iRBo/net/batman-adv] Error 2 make[2]: *** [/home/build_test/build_env/linux-build/linux/v6.12-rc1/Makefile:1936: /home/build_test/build_env/tmp.8uaXd4iRBo] Error 2 make[1]: *** [Makefile:224: __sub-make] Error 2 make: *** [Makefile:68: all] Error 2 stable: unused_symbols v6.12-rc1 cfg: BLA=n DAT=n DEBUG=y TRACING=n NC=n MCAST=y BATMAN_V=n --------------------------------------------------------------------------- batadv_algo_get batadv_algo_select batadv_gw_dhcp_recipient_get batadv_gw_out_of_range batadv_hardif_disable_interface batadv_hardif_enable_interface batadv_hardif_min_mtu batadv_mcast_forw_mcsend batadv_mcast_forw_mode batadv_mcast_forw_send batadv_mesh_free batadv_mesh_init batadv_netlink_tpmeter_notify batadv_orig_node_vlan_get batadv_orig_node_vlan_new batadv_orig_node_vlan_release batadv_routing_algo batadv_send_bcast_packet batadv_send_skb_via_gw batadv_send_skb_via_tt_generic batadv_vlan_ap_isola_get stable: unused_symbols v6.12-rc1 cfg: BLA=n DAT=y DEBUG=y TRACING=n NC=y MCAST=y BATMAN_V=y --------------------------------------------------------------------------- batadv_algo_get batadv_algo_select batadv_dat_snoop_outgoing_arp_reply batadv_dat_snoop_outgoing_arp_request batadv_dat_snoop_outgoing_dhcp_ack batadv_gw_dhcp_recipient_get batadv_gw_out_of_range batadv_hardif_disable_interface batadv_hardif_enable_interface batadv_hardif_min_mtu batadv_mcast_forw_mcsend batadv_mcast_forw_mode batadv_mcast_forw_send batadv_mesh_free batadv_mesh_init batadv_nc_init_bat_priv batadv_netlink_tpmeter_notify batadv_orig_node_vlan_get batadv_orig_node_vlan_new batadv_orig_node_vlan_release batadv_routing_algo batadv_send_bcast_packet batadv_send_skb_via_gw batadv_vlan_ap_isola_get stable: unused_symbols v6.12-rc1 cfg: BLA=y DAT=n DEBUG=n TRACING=y NC=y MCAST=n BATMAN_V=n --------------------------------------------------------------------------- batadv_algo_get batadv_algo_select batadv_bla_is_backbone_gw_orig batadv_bla_rx batadv_bla_tx batadv_gw_dhcp_recipient_get batadv_gw_out_of_range batadv_hardif_disable_interface batadv_hardif_enable_interface batadv_hardif_min_mtu batadv_mesh_free batadv_mesh_init batadv_nc_init_bat_priv batadv_netlink_tpmeter_notify batadv_orig_node_vlan_get batadv_orig_node_vlan_new batadv_orig_node_vlan_release batadv_routing_algo batadv_send_bcast_packet batadv_send_skb_via_gw batadv_send_skb_via_tt_generic batadv_vlan_ap_isola_get stable: unused_symbols v6.12-rc1 cfg: BLA=y DAT=y DEBUG=n TRACING=y NC=y MCAST=y BATMAN_V=n --------------------------------------------------------------------------- batadv_algo_get batadv_algo_select batadv_bla_rx batadv_bla_tx batadv_dat_snoop_outgoing_arp_reply batadv_dat_snoop_outgoing_arp_request batadv_dat_snoop_outgoing_dhcp_ack batadv_gw_dhcp_recipient_get batadv_gw_out_of_range batadv_hardif_disable_interface batadv_hardif_enable_interface batadv_hardif_min_mtu batadv_mcast_forw_mcsend batadv_mcast_forw_mode batadv_mcast_forw_send batadv_mesh_free batadv_mesh_init batadv_nc_init_bat_priv batadv_netlink_tpmeter_notify batadv_orig_node_vlan_get batadv_orig_node_vlan_new batadv_orig_node_vlan_release batadv_routing_algo batadv_send_bcast_packet batadv_send_skb_via_gw batadv_vlan_ap_isola_get stable: unused_symbols v6.12-rc1 cfg: BLA=y DAT=y DEBUG=y TRACING=y NC=n MCAST=y BATMAN_V=y --------------------------------------------------------------------------- batadv_algo_get batadv_algo_select batadv_bla_rx batadv_bla_tx batadv_dat_snoop_outgoing_arp_reply batadv_dat_snoop_outgoing_arp_request batadv_dat_snoop_outgoing_dhcp_ack batadv_gw_dhcp_recipient_get batadv_gw_out_of_range batadv_hardif_disable_interface batadv_hardif_enable_interface batadv_hardif_min_mtu batadv_mcast_forw_mcsend batadv_mcast_forw_mode batadv_mcast_forw_send batadv_mesh_free batadv_mesh_init batadv_netlink_tpmeter_notify batadv_orig_node_vlan_get batadv_orig_node_vlan_new batadv_orig_node_vlan_release batadv_routing_algo batadv_send_bcast_packet batadv_send_skb_via_gw batadv_vlan_ap_isola_get Statistics ========== stable ------ Failed tests: 11 Started build tests: 243 Tested Linux versions: 43 Tested configs: 117 main ---- Failed tests: 2 Started build tests: 224 Tested Linux versions: 43 Tested configs: 103

1 0

Build check errors found: 2024-10-13
by postmaster＠open-mesh.org 13 Oct '24

13 Oct '24

Name of failed tests ==================== stable ------ * difference between net and batadv stable * sparse v6.12-rc1 cfg: BLA=n DAT=n DEBUG=n TRACING=n NC=y MCAST=n BATMAN_V=n * sparse v6.12-rc1 cfg: BLA=n DAT=n DEBUG=n TRACING=y NC=y MCAST=y BATMAN_V=y * sparse v6.12-rc1 cfg: BLA=n DAT=y DEBUG=n TRACING=n NC=n MCAST=n BATMAN_V=n * sparse v6.12-rc1 cfg: BLA=n DAT=y DEBUG=y TRACING=y NC=n MCAST=y BATMAN_V=n * sparse v6.12-rc1 cfg: BLA=y DAT=n DEBUG=n TRACING=y NC=y MCAST=y BATMAN_V=y * sparse v6.12-rc1 cfg: BLA=y DAT=n DEBUG=y TRACING=y NC=n MCAST=y BATMAN_V=n * sparse v6.12-rc1 cfg: BLA=y DAT=y DEBUG=n TRACING=y NC=y MCAST=y BATMAN_V=n * unused_symbols v6.12-rc1 cfg: BLA=n DAT=n DEBUG=n TRACING=n NC=y MCAST=n BATMAN_V=n * unused_symbols v6.12-rc1 cfg: BLA=n DAT=n DEBUG=n TRACING=y NC=y MCAST=y BATMAN_V=y * unused_symbols v6.12-rc1 cfg: BLA=n DAT=y DEBUG=n TRACING=n NC=n MCAST=n BATMAN_V=n * unused_symbols v6.12-rc1 cfg: BLA=n DAT=y DEBUG=y TRACING=y NC=n MCAST=y BATMAN_V=n * unused_symbols v6.12-rc1 cfg: BLA=y DAT=n DEBUG=n TRACING=y NC=y MCAST=y BATMAN_V=y * unused_symbols v6.12-rc1 cfg: BLA=y DAT=n DEBUG=y TRACING=y NC=n MCAST=y BATMAN_V=n * unused_symbols v6.12-rc1 cfg: BLA=y DAT=y DEBUG=n TRACING=y NC=y MCAST=y BATMAN_V=n main ---- * coccicheck * difference between net-next and batadv main Output of different failed tests ================================ main: coccicheck ---------------- /home/build_test/build_env/tmp.wfjYzJbDQ1/./net/batman-adv/bridge_loop_avoidance.c:1956:6-34: opportunity for str_yes_no(batadv_is_my_client ( bat_priv , ethhdr -> h_source , vid )) /home/build_test/build_env/tmp.wfjYzJbDQ1/./net/batman-adv/bat_iv_ogm.c:374:7-53: opportunity for str_on_off(( batadv_ogm_packet -> flags & BATADV_DIRECTLINK )) stable: difference between net and batadv stable ------------------------------------------------ net/net/batman-adv/distributed-arp-table.c | 2 +- net/net/batman-adv/soft-interface.c | 5 +++-- 2 files changed, 4 insertions(+), 3 deletions(-) main: difference between net-next and batadv main ------------------------------------------------- netnext/net/batman-adv/distributed-arp-table.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) stable: sparse v6.12-rc1 cfg: BLA=y DAT=y DEBUG=n TRACING=y NC=y MCAST=y BATMAN_V=n --------------------------------------------------------------------------- /home/build_test/build_env/tmp.wfjYzJbDQ1/net/batman-adv/soft-interface.c: In function ‘batadv_softif_init_early’: /home/build_test/build_env/tmp.wfjYzJbDQ1/net/batman-adv/soft-interface.c:1023:56: error: ‘NETIF_F_NETNS_LOCAL’ undeclared (first use in this function) 1023 | dev->features |= NETIF_F_HW_VLAN_CTAG_FILTER | NETIF_F_NETNS_LOCAL; | ^~~~~~~~~~~~~~~~~~~ /home/build_test/build_env/tmp.wfjYzJbDQ1/net/batman-adv/soft-interface.c:1023:56: note: each undeclared identifier is reported only once for each function it appears in /home/build_test/build_env/tmp.wfjYzJbDQ1/net/batman-adv/soft-interface.c:1024:26: error: ‘NETIF_F_LLTX’ undeclared (first use in this function); did you mean ‘NETIF_F_LRO’? 1024 | dev->features |= NETIF_F_LLTX; | ^~~~~~~~~~~~ | NETIF_F_LRO make[4]: *** [scripts/Makefile.build:229: /home/build_test/build_env/tmp.wfjYzJbDQ1/net/batman-adv/soft-interface.o] Error 1 make[3]: *** [scripts/Makefile.build:478: /home/build_test/build_env/tmp.wfjYzJbDQ1/net/batman-adv] Error 2 make[2]: *** [/home/build_test/build_env/linux-build/linux/v6.12-rc1/Makefile:1936: /home/build_test/build_env/tmp.wfjYzJbDQ1] Error 2 make[1]: *** [Makefile:224: __sub-make] Error 2 make: *** [Makefile:68: all] Error 2 stable: unused_symbols v6.12-rc1 cfg: BLA=n DAT=n DEBUG=n TRACING=n NC=y MCAST=n BATMAN_V=n --------------------------------------------------------------------------- batadv_algo_get batadv_algo_select batadv_gw_dhcp_recipient_get batadv_gw_out_of_range batadv_hardif_disable_interface batadv_hardif_enable_interface batadv_hardif_min_mtu batadv_mesh_free batadv_mesh_init batadv_nc_init_bat_priv batadv_netlink_tpmeter_notify batadv_orig_node_vlan_get batadv_orig_node_vlan_new batadv_orig_node_vlan_release batadv_routing_algo batadv_send_bcast_packet batadv_send_skb_via_gw batadv_send_skb_via_tt_generic batadv_vlan_ap_isola_get stable: unused_symbols v6.12-rc1 cfg: BLA=n DAT=n DEBUG=n TRACING=y NC=y MCAST=y BATMAN_V=y --------------------------------------------------------------------------- batadv_algo_get batadv_algo_select batadv_gw_dhcp_recipient_get batadv_gw_out_of_range batadv_hardif_disable_interface batadv_hardif_enable_interface batadv_hardif_min_mtu batadv_mcast_forw_mcsend batadv_mcast_forw_mode batadv_mcast_forw_send batadv_mesh_free batadv_mesh_init batadv_nc_init_bat_priv batadv_netlink_tpmeter_notify batadv_orig_node_vlan_get batadv_orig_node_vlan_new batadv_orig_node_vlan_release batadv_routing_algo batadv_send_bcast_packet batadv_send_skb_via_gw batadv_send_skb_via_tt_generic batadv_vlan_ap_isola_get stable: unused_symbols v6.12-rc1 cfg: BLA=n DAT=y DEBUG=n TRACING=n NC=n MCAST=n BATMAN_V=n --------------------------------------------------------------------------- batadv_algo_get batadv_algo_select batadv_dat_snoop_outgoing_arp_reply batadv_dat_snoop_outgoing_arp_request batadv_dat_snoop_outgoing_dhcp_ack batadv_gw_dhcp_recipient_get batadv_gw_out_of_range batadv_hardif_disable_interface batadv_hardif_enable_interface batadv_hardif_min_mtu batadv_mesh_free batadv_mesh_init batadv_netlink_tpmeter_notify batadv_orig_node_vlan_get batadv_orig_node_vlan_new batadv_orig_node_vlan_release batadv_routing_algo batadv_send_bcast_packet batadv_send_skb_via_gw batadv_vlan_ap_isola_get stable: unused_symbols v6.12-rc1 cfg: BLA=n DAT=y DEBUG=y TRACING=y NC=n MCAST=y BATMAN_V=n --------------------------------------------------------------------------- batadv_algo_get batadv_algo_select batadv_dat_snoop_outgoing_arp_reply batadv_dat_snoop_outgoing_arp_request batadv_dat_snoop_outgoing_dhcp_ack batadv_gw_dhcp_recipient_get batadv_gw_out_of_range batadv_hardif_disable_interface batadv_hardif_enable_interface batadv_hardif_min_mtu batadv_mcast_forw_mcsend batadv_mcast_forw_mode batadv_mcast_forw_send batadv_mesh_free batadv_mesh_init batadv_netlink_tpmeter_notify batadv_orig_node_vlan_get batadv_orig_node_vlan_new batadv_orig_node_vlan_release batadv_routing_algo batadv_send_bcast_packet batadv_send_skb_via_gw batadv_vlan_ap_isola_get stable: unused_symbols v6.12-rc1 cfg: BLA=y DAT=n DEBUG=n TRACING=y NC=y MCAST=y BATMAN_V=y --------------------------------------------------------------------------- batadv_algo_get batadv_algo_select batadv_bla_rx batadv_bla_tx batadv_gw_dhcp_recipient_get batadv_gw_out_of_range batadv_hardif_disable_interface batadv_hardif_enable_interface batadv_hardif_min_mtu batadv_mcast_forw_mcsend batadv_mcast_forw_mode batadv_mcast_forw_send batadv_mesh_free batadv_mesh_init batadv_nc_init_bat_priv batadv_netlink_tpmeter_notify batadv_orig_node_vlan_get batadv_orig_node_vlan_new batadv_orig_node_vlan_release batadv_routing_algo batadv_send_bcast_packet batadv_send_skb_via_gw batadv_send_skb_via_tt_generic batadv_vlan_ap_isola_get stable: unused_symbols v6.12-rc1 cfg: BLA=y DAT=n DEBUG=y TRACING=y NC=n MCAST=y BATMAN_V=n --------------------------------------------------------------------------- batadv_algo_get batadv_algo_select batadv_bla_rx batadv_bla_tx batadv_gw_dhcp_recipient_get batadv_gw_out_of_range batadv_hardif_disable_interface batadv_hardif_enable_interface batadv_hardif_min_mtu batadv_mcast_forw_mcsend batadv_mcast_forw_mode batadv_mcast_forw_send batadv_mesh_free batadv_mesh_init batadv_netlink_tpmeter_notify batadv_orig_node_vlan_get batadv_orig_node_vlan_new batadv_orig_node_vlan_release batadv_routing_algo batadv_send_bcast_packet batadv_send_skb_via_gw batadv_send_skb_via_tt_generic batadv_vlan_ap_isola_get stable: unused_symbols v6.12-rc1 cfg: BLA=y DAT=y DEBUG=n TRACING=y NC=y MCAST=y BATMAN_V=n --------------------------------------------------------------------------- batadv_algo_get batadv_algo_select batadv_bla_rx batadv_bla_tx batadv_dat_snoop_outgoing_arp_reply batadv_dat_snoop_outgoing_arp_request batadv_dat_snoop_outgoing_dhcp_ack batadv_gw_dhcp_recipient_get batadv_gw_out_of_range batadv_hardif_disable_interface batadv_hardif_enable_interface batadv_hardif_min_mtu batadv_mcast_forw_mcsend batadv_mcast_forw_mode batadv_mcast_forw_send batadv_mesh_free batadv_mesh_init batadv_nc_init_bat_priv batadv_netlink_tpmeter_notify batadv_orig_node_vlan_get batadv_orig_node_vlan_new batadv_orig_node_vlan_release batadv_routing_algo batadv_send_bcast_packet batadv_send_skb_via_gw batadv_vlan_ap_isola_get Statistics ========== stable ------ Failed tests: 15 Started build tests: 240 Tested Linux versions: 43 Tested configs: 106 main ---- Failed tests: 2 Started build tests: 226 Tested Linux versions: 43 Tested configs: 107

1 0

2024

2023

2022

2021

2020

2019

2018

2017

2016

2015

2014

2013

2012

2011

linux-merge October 2024