Build check errors found: 2020-08-17
by postmaster＠open-mesh.org
Name of failed tests
====================
master
------
* checkpatch ./net/batman-adv/bridge_loop_avoidance.c
* checkpatch ./net/batman-adv/fragmentation.c
* checkpatch ./net/batman-adv/hard-interface.c
* checkpatch ./net/batman-adv/multicast.c
* checkpatch ./net/batman-adv/network-coding.c
* checkpatch ./net/batman-adv/send.c
* checkpatch ./net/batman-adv/soft-interface.c
* checkpatch ./net/batman-adv/types.h
* difference between net and batadv master
* headers
maint
-----
* difference between net and batadv maint
Output of different failed tests
================================
master: checkpatch ./net/batman-adv/bridge_loop_avoidance.c
-----------------------------------------------------------
WARNING: Possible repeated word: 'function'
#1798: FILE: ./net/batman-adv/bridge_loop_avoidance.c:1798:
+ /* backbone_gw is unreferenced in the report work function function
total: 0 errors, 1 warnings, 0 checks, 2544 lines checked
master: checkpatch ./net/batman-adv/fragmentation.c
---------------------------------------------------
WARNING: Possible repeated word: 'not'
#309: FILE: ./net/batman-adv/fragmentation.c:309:
+ * Return: true when the packet is merged or buffered, false when skb is not not
total: 0 errors, 1 warnings, 0 checks, 548 lines checked
master: checkpatch ./net/batman-adv/hard-interface.c
----------------------------------------------------
WARNING: Possible repeated word: 'table'
#602: FILE: ./net/batman-adv/hard-interface.c:602:
+ * maximum local table table size
total: 0 errors, 1 warnings, 0 checks, 1098 lines checked
master: checkpatch ./net/batman-adv/multicast.c
-----------------------------------------------
WARNING: Possible repeated word: 'multicast'
#210: FILE: ./net/batman-adv/multicast.c:210:
+ * is capable of performing proper RFC4286 multicast multicast router
total: 0 errors, 1 warnings, 0 checks, 2430 lines checked
master: checkpatch ./net/batman-adv/network-coding.c
----------------------------------------------------
WARNING: Possible repeated word: 'is'
#253: FILE: ./net/batman-adv/network-coding.c:253:
+ * @dropped: whether the packet is freed because is is dropped
total: 0 errors, 1 warnings, 0 checks, 1962 lines checked
master: checkpatch ./net/batman-adv/send.c
------------------------------------------
WARNING: Possible repeated word: 'is'
#464: FILE: ./net/batman-adv/send.c:464:
+ * @dropped: whether the packet is freed because is is dropped
total: 0 errors, 1 warnings, 0 checks, 1002 lines checked
master: checkpatch ./net/batman-adv/soft-interface.c
----------------------------------------------------
WARNING: Possible repeated word: 'the'
#652: FILE: ./net/batman-adv/soft-interface.c:652:
+ * @proto: protocol of the the vlan id
WARNING: Possible repeated word: 'the'
#710: FILE: ./net/batman-adv/soft-interface.c:710:
+ * @proto: protocol of the the vlan id
total: 0 errors, 2 warnings, 0 checks, 1180 lines checked
master: checkpatch ./net/batman-adv/types.h
-------------------------------------------
WARNING: Possible repeated word: 'time'
#1495: FILE: ./net/batman-adv/types.h:1495:
+ /** @last_recv_time: time time (jiffies) a msg was received */
WARNING: Possible repeated word: 'address'
#1999: FILE: ./net/batman-adv/types.h:1999:
+ * @addr: mac address address of the originator this request was sent to
total: 0 errors, 2 warnings, 0 checks, 2476 lines checked
maint: difference between net and batadv maint
----------------------------------------------
net/Documentation/networking/batman-adv.rst | 8 ++--
net/include/uapi/linux/batman_adv.h | 7 ++-
net/net/batman-adv/bat_iv_ogm.c | 25 ++++++------
net/net/batman-adv/bat_v_elp.c | 10 ++---
net/net/batman-adv/bat_v_ogm.c | 38 +++++++++++--------
net/net/batman-adv/bridge_loop_avoidance.c | 6 +--
net/net/batman-adv/distributed-arp-table.c | 2 -
net/net/batman-adv/fragmentation.c | 6 +--
net/net/batman-adv/gateway_client.c | 6 +--
net/net/batman-adv/hard-interface.c | 16 ++++----
net/net/batman-adv/log.h | 6 +--
net/net/batman-adv/main.c | 2 -
net/net/batman-adv/main.h | 8 ++--
net/net/batman-adv/multicast.c | 21 +++++-----
net/net/batman-adv/netlink.c | 14 ++++++-
net/net/batman-adv/network-coding.c | 14 +++----
net/net/batman-adv/originator.c | 8 ++--
net/net/batman-adv/routing.c | 4 +-
net/net/batman-adv/send.c | 4 +-
net/net/batman-adv/soft-interface.c | 2 -
net/net/batman-adv/tp_meter.c | 12 +++---
net/net/batman-adv/translation-table.c | 10 ++---
net/net/batman-adv/tvlv.c | 4 +-
net/net/batman-adv/types.h | 18 ++++++---
24 files changed, 138 insertions(+), 113 deletions(-)
master: difference between net and batadv master
------------------------------------------------
netnext/net/batman-adv/bat_v_ogm.c | 11 +++++------
netnext/net/batman-adv/gateway_client.c | 6 ++----
2 files changed, 7 insertions(+), 10 deletions(-)
master: headers
---------------
diff --git a/net/batman-adv/bat_iv_ogm.c b/net/batman-adv/bat_iv_ogm.c
index d3aab104..26363a27 100644
--- a/net/batman-adv/bat_iv_ogm.c
+++ b/net/batman-adv/bat_iv_ogm.c
@@ -6,7 +6,6 @@
#include "bat_iv_ogm.h"
#include "main.h" // IWYU pragma: keep
-
#include <linux/atomic.h>
#include <linux/bitmap.h>
#include <linux/bitops.h>
@@ -49,6 +48,7 @@
#include "gateway_client.h"
#include "hard-interface.h"
#include "hash.h"
+#include "linux/prandom.h"
#include "log.h"
#include "netlink.h"
#include "network-coding.h"
diff --git a/net/batman-adv/bat_v_elp.c b/net/batman-adv/bat_v_elp.c
index b8ec89da..e372f1b3 100644
--- a/net/batman-adv/bat_v_elp.c
+++ b/net/batman-adv/bat_v_elp.c
@@ -6,7 +6,6 @@
#include "bat_v_elp.h"
#include "main.h" // IWYU pragma: keep
-
#include <linux/atomic.h>
#include <linux/bitops.h>
#include <linux/byteorder/generic.h>
@@ -35,6 +34,7 @@
#include "bat_algo.h"
#include "bat_v_ogm.h"
#include "hard-interface.h"
+#include "linux/prandom.h"
#include "log.h"
#include "originator.h"
#include "routing.h"
diff --git a/net/batman-adv/bat_v_ogm.c b/net/batman-adv/bat_v_ogm.c
index 1e9ddf61..c1778770 100644
--- a/net/batman-adv/bat_v_ogm.c
+++ b/net/batman-adv/bat_v_ogm.c
@@ -6,7 +6,6 @@
#include "bat_v_ogm.h"
#include "main.h" // IWYU pragma: keep
-
#include <linux/atomic.h>
#include <linux/byteorder/generic.h>
#include <linux/errno.h>
@@ -35,6 +34,7 @@
#include "bat_algo.h"
#include "hard-interface.h"
#include "hash.h"
+#include "linux/prandom.h"
#include "log.h"
#include "originator.h"
#include "routing.h"
diff --git a/net/batman-adv/bridge_loop_avoidance.c b/net/batman-adv/bridge_loop_avoidance.c
index af7ba3f7..40b4b8f8 100644
--- a/net/batman-adv/bridge_loop_avoidance.c
+++ b/net/batman-adv/bridge_loop_avoidance.c
@@ -6,7 +6,6 @@
#include "bridge_loop_avoidance.h"
#include "main.h" // IWYU pragma: keep
-
#include <linux/atomic.h>
#include <linux/byteorder/generic.h>
#include <linux/compiler.h>
@@ -22,7 +21,6 @@
#include <linux/kernel.h>
#include <linux/kref.h>
#include <linux/list.h>
-#include <linux/lockdep.h>
#include <linux/netdevice.h>
#include <linux/netlink.h>
#include <linux/rculist.h>
@@ -43,6 +41,7 @@
#include "hard-interface.h"
#include "hash.h"
+#include "linux/lockdep_types.h"
#include "log.h"
#include "netlink.h"
#include "originator.h"
diff --git a/net/batman-adv/hash.h b/net/batman-adv/hash.h
index 9a8dc28c..64a2e5fb 100644
--- a/net/batman-adv/hash.h
+++ b/net/batman-adv/hash.h
@@ -8,16 +8,16 @@
#define _NET_BATMAN_ADV_HASH_H_
#include "main.h" // IWYU pragma: keep
-
#include <linux/atomic.h>
#include <linux/compiler.h>
#include <linux/list.h>
-#include <linux/lockdep.h>
#include <linux/rculist.h>
#include <linux/spinlock.h>
#include <linux/stddef.h>
#include <linux/types.h>
+#include "linux/lockdep_types.h"
+
/* callback to a compare function. should compare 2 element datas for their
* keys
*
diff --git a/net/batman-adv/network-coding.c b/net/batman-adv/network-coding.c
index b3d947e8..a3802025 100644
--- a/net/batman-adv/network-coding.c
+++ b/net/batman-adv/network-coding.c
@@ -6,7 +6,6 @@
#include "network-coding.h"
#include "main.h" // IWYU pragma: keep
-
#include <linux/atomic.h>
#include <linux/bitops.h>
#include <linux/byteorder/generic.h>
@@ -27,7 +26,6 @@
#include <linux/net.h>
#include <linux/netdevice.h>
#include <linux/printk.h>
-#include <linux/random.h>
#include <linux/rculist.h>
#include <linux/rcupdate.h>
#include <linux/seq_file.h>
@@ -41,6 +39,8 @@
#include "hard-interface.h"
#include "hash.h"
+#include "linux/lockdep_types.h"
+#include "linux/prandom.h"
#include "log.h"
#include "originator.h"
#include "routing.h"
diff --git a/net/batman-adv/originator.c b/net/batman-adv/originator.c
index 29a0050b..80fd2149 100644
--- a/net/batman-adv/originator.c
+++ b/net/batman-adv/originator.c
@@ -6,7 +6,6 @@
#include "originator.h"
#include "main.h" // IWYU pragma: keep
-
#include <linux/atomic.h>
#include <linux/errno.h>
#include <linux/etherdevice.h>
@@ -15,7 +14,6 @@
#include <linux/kernel.h>
#include <linux/kref.h>
#include <linux/list.h>
-#include <linux/lockdep.h>
#include <linux/netdevice.h>
#include <linux/netlink.h>
#include <linux/rculist.h>
@@ -36,6 +34,7 @@
#include "gateway_client.h"
#include "hard-interface.h"
#include "hash.h"
+#include "linux/lockdep_types.h"
#include "log.h"
#include "multicast.h"
#include "netlink.h"
diff --git a/net/batman-adv/soft-interface.c b/net/batman-adv/soft-interface.c
index dd5e6343..22ef6471 100644
--- a/net/batman-adv/soft-interface.c
+++ b/net/batman-adv/soft-interface.c
@@ -6,7 +6,6 @@
#include "soft-interface.h"
#include "main.h" // IWYU pragma: keep
-
#include <linux/atomic.h>
#include <linux/byteorder/generic.h>
#include <linux/cache.h>
@@ -47,6 +46,7 @@
#include "distributed-arp-table.h"
#include "gateway_client.h"
#include "hard-interface.h"
+#include "linux/lockdep_types.h"
#include "multicast.h"
#include "network-coding.h"
#include "originator.h"
diff --git a/net/batman-adv/translation-table.c b/net/batman-adv/translation-table.c
index 4b267683..d9a770a0 100644
--- a/net/batman-adv/translation-table.c
+++ b/net/batman-adv/translation-table.c
@@ -6,7 +6,6 @@
#include "translation-table.h"
#include "main.h" // IWYU pragma: keep
-
#include <linux/atomic.h>
#include <linux/bitops.h>
#include <linux/build_bug.h>
@@ -46,6 +45,7 @@
#include "bridge_loop_avoidance.h"
#include "hard-interface.h"
#include "hash.h"
+#include "linux/lockdep_types.h"
#include "log.h"
#include "netlink.h"
#include "originator.h"
Statistics
==========
master
------
Failed tests: 10
Started build tests: 281
Tested Linux versions: 34
Tested configs: 218
maint
-----
Failed tests: 1
Started build tests: 269
Tested Linux versions: 34
Tested configs: 209
3 months, 1 week
Build check errors found: 2020-08-16
by postmaster＠open-mesh.org
Name of failed tests
====================
master
------
* checkpatch ./net/batman-adv/bridge_loop_avoidance.c
* checkpatch ./net/batman-adv/fragmentation.c
* checkpatch ./net/batman-adv/hard-interface.c
* checkpatch ./net/batman-adv/multicast.c
* checkpatch ./net/batman-adv/network-coding.c
* checkpatch ./net/batman-adv/send.c
* checkpatch ./net/batman-adv/soft-interface.c
* checkpatch ./net/batman-adv/types.h
* difference between net and batadv master
maint
-----
* difference between net and batadv maint
Output of different failed tests
================================
master: checkpatch ./net/batman-adv/bridge_loop_avoidance.c
-----------------------------------------------------------
WARNING: Possible repeated word: 'function'
#1798: FILE: ./net/batman-adv/bridge_loop_avoidance.c:1798:
+ /* backbone_gw is unreferenced in the report work function function
total: 0 errors, 1 warnings, 0 checks, 2544 lines checked
master: checkpatch ./net/batman-adv/fragmentation.c
---------------------------------------------------
WARNING: Possible repeated word: 'not'
#309: FILE: ./net/batman-adv/fragmentation.c:309:
+ * Return: true when the packet is merged or buffered, false when skb is not not
total: 0 errors, 1 warnings, 0 checks, 548 lines checked
master: checkpatch ./net/batman-adv/hard-interface.c
----------------------------------------------------
WARNING: Possible repeated word: 'table'
#602: FILE: ./net/batman-adv/hard-interface.c:602:
+ * maximum local table table size
total: 0 errors, 1 warnings, 0 checks, 1098 lines checked
master: checkpatch ./net/batman-adv/multicast.c
-----------------------------------------------
WARNING: Possible repeated word: 'multicast'
#210: FILE: ./net/batman-adv/multicast.c:210:
+ * is capable of performing proper RFC4286 multicast multicast router
total: 0 errors, 1 warnings, 0 checks, 2430 lines checked
master: checkpatch ./net/batman-adv/network-coding.c
----------------------------------------------------
WARNING: Possible repeated word: 'is'
#253: FILE: ./net/batman-adv/network-coding.c:253:
+ * @dropped: whether the packet is freed because is is dropped
total: 0 errors, 1 warnings, 0 checks, 1962 lines checked
master: checkpatch ./net/batman-adv/send.c
------------------------------------------
WARNING: Possible repeated word: 'is'
#464: FILE: ./net/batman-adv/send.c:464:
+ * @dropped: whether the packet is freed because is is dropped
total: 0 errors, 1 warnings, 0 checks, 1002 lines checked
master: checkpatch ./net/batman-adv/soft-interface.c
----------------------------------------------------
WARNING: Possible repeated word: 'the'
#652: FILE: ./net/batman-adv/soft-interface.c:652:
+ * @proto: protocol of the the vlan id
WARNING: Possible repeated word: 'the'
#710: FILE: ./net/batman-adv/soft-interface.c:710:
+ * @proto: protocol of the the vlan id
total: 0 errors, 2 warnings, 0 checks, 1180 lines checked
master: checkpatch ./net/batman-adv/types.h
-------------------------------------------
WARNING: Possible repeated word: 'time'
#1495: FILE: ./net/batman-adv/types.h:1495:
+ /** @last_recv_time: time time (jiffies) a msg was received */
WARNING: Possible repeated word: 'address'
#1999: FILE: ./net/batman-adv/types.h:1999:
+ * @addr: mac address address of the originator this request was sent to
total: 0 errors, 2 warnings, 0 checks, 2476 lines checked
maint: difference between net and batadv maint
----------------------------------------------
net/Documentation/networking/batman-adv.rst | 8 ++--
net/include/uapi/linux/batman_adv.h | 7 ++-
net/net/batman-adv/bat_iv_ogm.c | 25 ++++++------
net/net/batman-adv/bat_v_elp.c | 10 ++---
net/net/batman-adv/bat_v_ogm.c | 38 +++++++++++--------
net/net/batman-adv/bridge_loop_avoidance.c | 6 +--
net/net/batman-adv/distributed-arp-table.c | 2 -
net/net/batman-adv/fragmentation.c | 6 +--
net/net/batman-adv/gateway_client.c | 6 +--
net/net/batman-adv/hard-interface.c | 16 ++++----
net/net/batman-adv/log.h | 6 +--
net/net/batman-adv/main.c | 2 -
net/net/batman-adv/main.h | 8 ++--
net/net/batman-adv/multicast.c | 21 +++++-----
net/net/batman-adv/netlink.c | 14 ++++++-
net/net/batman-adv/network-coding.c | 14 +++----
net/net/batman-adv/originator.c | 8 ++--
net/net/batman-adv/routing.c | 4 +-
net/net/batman-adv/send.c | 4 +-
net/net/batman-adv/soft-interface.c | 2 -
net/net/batman-adv/tp_meter.c | 12 +++---
net/net/batman-adv/translation-table.c | 10 ++---
net/net/batman-adv/tvlv.c | 4 +-
net/net/batman-adv/types.h | 18 ++++++---
24 files changed, 138 insertions(+), 113 deletions(-)
master: difference between net and batadv master
------------------------------------------------
netnext/net/batman-adv/bat_v_ogm.c | 11 +++++------
netnext/net/batman-adv/gateway_client.c | 6 ++----
2 files changed, 7 insertions(+), 10 deletions(-)
Statistics
==========
master
------
Failed tests: 9
Started build tests: 306
Tested Linux versions: 32
Tested configs: 234
maint
-----
Failed tests: 1
Started build tests: 314
Tested Linux versions: 32
Tested configs: 232
3 months, 1 week
Build check errors found: 2020-08-15
by postmaster＠open-mesh.org
Name of failed tests
====================
maint
-----
* difference between net and batadv maint
* smatch linux-5.8 CONFIG_BATMAN_ADV_BLA=n CONFIG_BATMAN_ADV_DAT=n CONFIG_BATMAN_ADV_DEBUGFS=n CONFIG_BATMAN_ADV_DEBUG=n CONFIG_BATMAN_ADV_TRACING=y CONFIG_BATMAN_ADV_NC=y CONFIG_BATMAN_ADV_MCAST=n CONFIG_BATMAN_ADV_BATMAN_V=y CONFIG_BATMAN_ADV_SYSFS=y
* smatch linux-5.8 CONFIG_BATMAN_ADV_BLA=n CONFIG_BATMAN_ADV_DAT=y CONFIG_BATMAN_ADV_DEBUGFS=n CONFIG_BATMAN_ADV_DEBUG=y CONFIG_BATMAN_ADV_TRACING=n CONFIG_BATMAN_ADV_NC=y CONFIG_BATMAN_ADV_MCAST=y CONFIG_BATMAN_ADV_BATMAN_V=y CONFIG_BATMAN_ADV_SYSFS=n
* smatch linux-5.8 CONFIG_BATMAN_ADV_BLA=n CONFIG_BATMAN_ADV_DAT=y CONFIG_BATMAN_ADV_DEBUGFS=n CONFIG_BATMAN_ADV_DEBUG=y CONFIG_BATMAN_ADV_TRACING=y CONFIG_BATMAN_ADV_NC=y CONFIG_BATMAN_ADV_MCAST=y CONFIG_BATMAN_ADV_BATMAN_V=y CONFIG_BATMAN_ADV_SYSFS=y
* smatch linux-5.8 CONFIG_BATMAN_ADV_BLA=n CONFIG_BATMAN_ADV_DAT=y CONFIG_BATMAN_ADV_DEBUGFS=y CONFIG_BATMAN_ADV_DEBUG=n CONFIG_BATMAN_ADV_TRACING=n CONFIG_BATMAN_ADV_NC=y CONFIG_BATMAN_ADV_MCAST=n CONFIG_BATMAN_ADV_BATMAN_V=y CONFIG_BATMAN_ADV_SYSFS=y
* smatch linux-5.8 CONFIG_BATMAN_ADV_BLA=y CONFIG_BATMAN_ADV_DAT=n CONFIG_BATMAN_ADV_DEBUGFS=n CONFIG_BATMAN_ADV_DEBUG=n CONFIG_BATMAN_ADV_TRACING=n CONFIG_BATMAN_ADV_NC=y CONFIG_BATMAN_ADV_MCAST=n CONFIG_BATMAN_ADV_BATMAN_V=n CONFIG_BATMAN_ADV_SYSFS=y
* smatch linux-5.8 CONFIG_BATMAN_ADV_BLA=y CONFIG_BATMAN_ADV_DAT=n CONFIG_BATMAN_ADV_DEBUGFS=n CONFIG_BATMAN_ADV_DEBUG=y CONFIG_BATMAN_ADV_TRACING=n CONFIG_BATMAN_ADV_NC=n CONFIG_BATMAN_ADV_MCAST=n CONFIG_BATMAN_ADV_BATMAN_V=n CONFIG_BATMAN_ADV_SYSFS=y
* smatch linux-5.8 CONFIG_BATMAN_ADV_BLA=y CONFIG_BATMAN_ADV_DAT=n CONFIG_BATMAN_ADV_DEBUGFS=n CONFIG_BATMAN_ADV_DEBUG=y CONFIG_BATMAN_ADV_TRACING=y CONFIG_BATMAN_ADV_NC=n CONFIG_BATMAN_ADV_MCAST=y CONFIG_BATMAN_ADV_BATMAN_V=y CONFIG_BATMAN_ADV_SYSFS=y
* smatch linux-5.8 CONFIG_BATMAN_ADV_BLA=y CONFIG_BATMAN_ADV_DAT=n CONFIG_BATMAN_ADV_DEBUGFS=y CONFIG_BATMAN_ADV_DEBUG=n CONFIG_BATMAN_ADV_TRACING=y CONFIG_BATMAN_ADV_NC=y CONFIG_BATMAN_ADV_MCAST=y CONFIG_BATMAN_ADV_BATMAN_V=y CONFIG_BATMAN_ADV_SYSFS=n
* smatch linux-5.8 CONFIG_BATMAN_ADV_BLA=y CONFIG_BATMAN_ADV_DAT=y CONFIG_BATMAN_ADV_DEBUGFS=y CONFIG_BATMAN_ADV_DEBUG=y CONFIG_BATMAN_ADV_TRACING=y CONFIG_BATMAN_ADV_NC=n CONFIG_BATMAN_ADV_MCAST=y CONFIG_BATMAN_ADV_BATMAN_V=n CONFIG_BATMAN_ADV_SYSFS=y
master
------
* checkpatch ./net/batman-adv/bridge_loop_avoidance.c
* checkpatch ./net/batman-adv/fragmentation.c
* checkpatch ./net/batman-adv/hard-interface.c
* checkpatch ./net/batman-adv/multicast.c
* checkpatch ./net/batman-adv/network-coding.c
* checkpatch ./net/batman-adv/send.c
* checkpatch ./net/batman-adv/soft-interface.c
* checkpatch ./net/batman-adv/types.h
* difference between net and batadv master
* smatch linux-5.8 CONFIG_BATMAN_ADV_BLA=n CONFIG_BATMAN_ADV_DAT=n CONFIG_BATMAN_ADV_DEBUGFS=n CONFIG_BATMAN_ADV_DEBUG=y CONFIG_BATMAN_ADV_TRACING=n CONFIG_BATMAN_ADV_NC=y CONFIG_BATMAN_ADV_MCAST=y CONFIG_BATMAN_ADV_BATMAN_V=y CONFIG_BATMAN_ADV_SYSFS=n
* smatch linux-5.8 CONFIG_BATMAN_ADV_BLA=n CONFIG_BATMAN_ADV_DAT=n CONFIG_BATMAN_ADV_DEBUGFS=y CONFIG_BATMAN_ADV_DEBUG=n CONFIG_BATMAN_ADV_TRACING=y CONFIG_BATMAN_ADV_NC=n CONFIG_BATMAN_ADV_MCAST=n CONFIG_BATMAN_ADV_BATMAN_V=n CONFIG_BATMAN_ADV_SYSFS=n
* smatch linux-5.8 CONFIG_BATMAN_ADV_BLA=n CONFIG_BATMAN_ADV_DAT=y CONFIG_BATMAN_ADV_DEBUGFS=y CONFIG_BATMAN_ADV_DEBUG=y CONFIG_BATMAN_ADV_TRACING=y CONFIG_BATMAN_ADV_NC=y CONFIG_BATMAN_ADV_MCAST=n CONFIG_BATMAN_ADV_BATMAN_V=y CONFIG_BATMAN_ADV_SYSFS=n
* smatch linux-5.8 CONFIG_BATMAN_ADV_BLA=y CONFIG_BATMAN_ADV_DAT=y CONFIG_BATMAN_ADV_DEBUGFS=y CONFIG_BATMAN_ADV_DEBUG=n CONFIG_BATMAN_ADV_TRACING=y CONFIG_BATMAN_ADV_NC=n CONFIG_BATMAN_ADV_MCAST=n CONFIG_BATMAN_ADV_BATMAN_V=n CONFIG_BATMAN_ADV_SYSFS=y
* smatch linux-5.8 CONFIG_BATMAN_ADV_BLA=y CONFIG_BATMAN_ADV_DAT=y CONFIG_BATMAN_ADV_DEBUGFS=y CONFIG_BATMAN_ADV_DEBUG=y CONFIG_BATMAN_ADV_TRACING=y CONFIG_BATMAN_ADV_NC=n CONFIG_BATMAN_ADV_MCAST=y CONFIG_BATMAN_ADV_BATMAN_V=y CONFIG_BATMAN_ADV_SYSFS=n
* smatch linux-5.8 CONFIG_BATMAN_ADV_BLA=y CONFIG_BATMAN_ADV_DAT=y CONFIG_BATMAN_ADV_DEBUGFS=y CONFIG_BATMAN_ADV_DEBUG=y CONFIG_BATMAN_ADV_TRACING=y CONFIG_BATMAN_ADV_NC=y CONFIG_BATMAN_ADV_MCAST=y CONFIG_BATMAN_ADV_BATMAN_V=n CONFIG_BATMAN_ADV_SYSFS=y
Output of different failed tests
================================
master: checkpatch ./net/batman-adv/bridge_loop_avoidance.c
-----------------------------------------------------------
WARNING: Possible repeated word: 'function'
#1798: FILE: ./net/batman-adv/bridge_loop_avoidance.c:1798:
+ /* backbone_gw is unreferenced in the report work function function
total: 0 errors, 1 warnings, 0 checks, 2544 lines checked
master: checkpatch ./net/batman-adv/fragmentation.c
---------------------------------------------------
WARNING: Possible repeated word: 'not'
#309: FILE: ./net/batman-adv/fragmentation.c:309:
+ * Return: true when the packet is merged or buffered, false when skb is not not
total: 0 errors, 1 warnings, 0 checks, 548 lines checked
master: checkpatch ./net/batman-adv/hard-interface.c
----------------------------------------------------
WARNING: Possible repeated word: 'table'
#602: FILE: ./net/batman-adv/hard-interface.c:602:
+ * maximum local table table size
total: 0 errors, 1 warnings, 0 checks, 1098 lines checked
master: checkpatch ./net/batman-adv/multicast.c
-----------------------------------------------
WARNING: Possible repeated word: 'multicast'
#210: FILE: ./net/batman-adv/multicast.c:210:
+ * is capable of performing proper RFC4286 multicast multicast router
total: 0 errors, 1 warnings, 0 checks, 2430 lines checked
master: checkpatch ./net/batman-adv/network-coding.c
----------------------------------------------------
WARNING: Possible repeated word: 'is'
#253: FILE: ./net/batman-adv/network-coding.c:253:
+ * @dropped: whether the packet is freed because is is dropped
total: 0 errors, 1 warnings, 0 checks, 1962 lines checked
master: checkpatch ./net/batman-adv/send.c
------------------------------------------
WARNING: Possible repeated word: 'is'
#464: FILE: ./net/batman-adv/send.c:464:
+ * @dropped: whether the packet is freed because is is dropped
total: 0 errors, 1 warnings, 0 checks, 1002 lines checked
master: checkpatch ./net/batman-adv/soft-interface.c
----------------------------------------------------
WARNING: Possible repeated word: 'the'
#652: FILE: ./net/batman-adv/soft-interface.c:652:
+ * @proto: protocol of the the vlan id
WARNING: Possible repeated word: 'the'
#710: FILE: ./net/batman-adv/soft-interface.c:710:
+ * @proto: protocol of the the vlan id
total: 0 errors, 2 warnings, 0 checks, 1180 lines checked
master: checkpatch ./net/batman-adv/types.h
-------------------------------------------
WARNING: Possible repeated word: 'time'
#1495: FILE: ./net/batman-adv/types.h:1495:
+ /** @last_recv_time: time time (jiffies) a msg was received */
WARNING: Possible repeated word: 'address'
#1999: FILE: ./net/batman-adv/types.h:1999:
+ * @addr: mac address address of the originator this request was sent to
total: 0 errors, 2 warnings, 0 checks, 2476 lines checked
maint: difference between net and batadv maint
----------------------------------------------
net/Documentation/networking/batman-adv.rst | 8 ++--
net/include/uapi/linux/batman_adv.h | 7 ++-
net/net/batman-adv/bat_iv_ogm.c | 25 ++++++------
net/net/batman-adv/bat_v_elp.c | 10 ++---
net/net/batman-adv/bat_v_ogm.c | 38 +++++++++++--------
net/net/batman-adv/bridge_loop_avoidance.c | 6 +--
net/net/batman-adv/distributed-arp-table.c | 2 -
net/net/batman-adv/fragmentation.c | 6 +--
net/net/batman-adv/gateway_client.c | 6 +--
net/net/batman-adv/hard-interface.c | 16 ++++----
net/net/batman-adv/log.h | 6 +--
net/net/batman-adv/main.c | 2 -
net/net/batman-adv/main.h | 8 ++--
net/net/batman-adv/multicast.c | 21 +++++-----
net/net/batman-adv/netlink.c | 14 ++++++-
net/net/batman-adv/network-coding.c | 14 +++----
net/net/batman-adv/originator.c | 8 ++--
net/net/batman-adv/routing.c | 4 +-
net/net/batman-adv/send.c | 4 +-
net/net/batman-adv/soft-interface.c | 2 -
net/net/batman-adv/tp_meter.c | 12 +++---
net/net/batman-adv/translation-table.c | 10 ++---
net/net/batman-adv/tvlv.c | 4 +-
net/net/batman-adv/types.h | 18 ++++++---
24 files changed, 138 insertions(+), 113 deletions(-)
master: difference between net and batadv master
------------------------------------------------
netnext/net/batman-adv/bat_v_ogm.c | 11 +++++------
netnext/net/batman-adv/gateway_client.c | 6 ++----
2 files changed, 7 insertions(+), 10 deletions(-)
master: smatch linux-5.8 CONFIG_BATMAN_ADV_BLA=y CONFIG_BATMAN_ADV_DAT=y CONFIG_BATMAN_ADV_DEBUGFS=y CONFIG_BATMAN_ADV_DEBUG=y CONFIG_BATMAN_ADV_TRACING=y CONFIG_BATMAN_ADV_NC=y CONFIG_BATMAN_ADV_MCAST=y CONFIG_BATMAN_ADV_BATMAN_V=n CONFIG_BATMAN_ADV_SYSFS=y
---------------------------------------------------------------------------
/home/build_test/build_env/tmp.yqfnOtAkx1/net/batman-adv/routing.c:1159 batadv_recv_frag_packet() warn: variable dereferenced before check 'skb' (see line 1133)
Statistics
==========
maint
-----
Failed tests: 10
Started build tests: 292
Tested Linux versions: 32
Tested configs: 223
master
------
Failed tests: 15
Started build tests: 294
Tested Linux versions: 32
Tested configs: 214
3 months, 1 week
Build check errors found: 2020-08-14
by postmaster＠open-mesh.org
Name of failed tests
====================
maint
-----
* difference between net and batadv maint
* smatch linux-5.8 CONFIG_BATMAN_ADV_BLA=n CONFIG_BATMAN_ADV_DAT=n CONFIG_BATMAN_ADV_DEBUGFS=n CONFIG_BATMAN_ADV_DEBUG=y CONFIG_BATMAN_ADV_TRACING=y CONFIG_BATMAN_ADV_NC=y CONFIG_BATMAN_ADV_MCAST=y CONFIG_BATMAN_ADV_BATMAN_V=y CONFIG_BATMAN_ADV_SYSFS=n
* smatch linux-5.8 CONFIG_BATMAN_ADV_BLA=n CONFIG_BATMAN_ADV_DAT=n CONFIG_BATMAN_ADV_DEBUGFS=y CONFIG_BATMAN_ADV_DEBUG=n CONFIG_BATMAN_ADV_TRACING=n CONFIG_BATMAN_ADV_NC=y CONFIG_BATMAN_ADV_MCAST=n CONFIG_BATMAN_ADV_BATMAN_V=y CONFIG_BATMAN_ADV_SYSFS=y
* smatch linux-5.8 CONFIG_BATMAN_ADV_BLA=n CONFIG_BATMAN_ADV_DAT=n CONFIG_BATMAN_ADV_DEBUGFS=y CONFIG_BATMAN_ADV_DEBUG=n CONFIG_BATMAN_ADV_TRACING=y CONFIG_BATMAN_ADV_NC=n CONFIG_BATMAN_ADV_MCAST=n CONFIG_BATMAN_ADV_BATMAN_V=y CONFIG_BATMAN_ADV_SYSFS=n
* smatch linux-5.8 CONFIG_BATMAN_ADV_BLA=n CONFIG_BATMAN_ADV_DAT=n CONFIG_BATMAN_ADV_DEBUGFS=y CONFIG_BATMAN_ADV_DEBUG=y CONFIG_BATMAN_ADV_TRACING=y CONFIG_BATMAN_ADV_NC=n CONFIG_BATMAN_ADV_MCAST=y CONFIG_BATMAN_ADV_BATMAN_V=n CONFIG_BATMAN_ADV_SYSFS=n
* smatch linux-5.8 CONFIG_BATMAN_ADV_BLA=n CONFIG_BATMAN_ADV_DAT=y CONFIG_BATMAN_ADV_DEBUGFS=n CONFIG_BATMAN_ADV_DEBUG=n CONFIG_BATMAN_ADV_TRACING=n CONFIG_BATMAN_ADV_NC=y CONFIG_BATMAN_ADV_MCAST=y CONFIG_BATMAN_ADV_BATMAN_V=n CONFIG_BATMAN_ADV_SYSFS=y
* smatch linux-5.8 CONFIG_BATMAN_ADV_BLA=n CONFIG_BATMAN_ADV_DAT=y CONFIG_BATMAN_ADV_DEBUGFS=n CONFIG_BATMAN_ADV_DEBUG=y CONFIG_BATMAN_ADV_TRACING=y CONFIG_BATMAN_ADV_NC=n CONFIG_BATMAN_ADV_MCAST=n CONFIG_BATMAN_ADV_BATMAN_V=n CONFIG_BATMAN_ADV_SYSFS=y
* smatch linux-5.8 CONFIG_BATMAN_ADV_BLA=n CONFIG_BATMAN_ADV_DAT=y CONFIG_BATMAN_ADV_DEBUGFS=y CONFIG_BATMAN_ADV_DEBUG=y CONFIG_BATMAN_ADV_TRACING=y CONFIG_BATMAN_ADV_NC=y CONFIG_BATMAN_ADV_MCAST=n CONFIG_BATMAN_ADV_BATMAN_V=n CONFIG_BATMAN_ADV_SYSFS=n
* smatch linux-5.8 CONFIG_BATMAN_ADV_BLA=y CONFIG_BATMAN_ADV_DAT=n CONFIG_BATMAN_ADV_DEBUGFS=y CONFIG_BATMAN_ADV_DEBUG=y CONFIG_BATMAN_ADV_TRACING=n CONFIG_BATMAN_ADV_NC=y CONFIG_BATMAN_ADV_MCAST=y CONFIG_BATMAN_ADV_BATMAN_V=n CONFIG_BATMAN_ADV_SYSFS=y
* smatch linux-5.8 CONFIG_BATMAN_ADV_BLA=y CONFIG_BATMAN_ADV_DAT=y CONFIG_BATMAN_ADV_DEBUGFS=n CONFIG_BATMAN_ADV_DEBUG=y CONFIG_BATMAN_ADV_TRACING=n CONFIG_BATMAN_ADV_NC=y CONFIG_BATMAN_ADV_MCAST=y CONFIG_BATMAN_ADV_BATMAN_V=y CONFIG_BATMAN_ADV_SYSFS=n
* smatch linux-5.8 CONFIG_BATMAN_ADV_BLA=y CONFIG_BATMAN_ADV_DAT=y CONFIG_BATMAN_ADV_DEBUGFS=y CONFIG_BATMAN_ADV_DEBUG=n CONFIG_BATMAN_ADV_TRACING=y CONFIG_BATMAN_ADV_NC=y CONFIG_BATMAN_ADV_MCAST=n CONFIG_BATMAN_ADV_BATMAN_V=n CONFIG_BATMAN_ADV_SYSFS=y
master
------
* checkpatch ./net/batman-adv/bridge_loop_avoidance.c
* checkpatch ./net/batman-adv/fragmentation.c
* checkpatch ./net/batman-adv/hard-interface.c
* checkpatch ./net/batman-adv/multicast.c
* checkpatch ./net/batman-adv/network-coding.c
* checkpatch ./net/batman-adv/send.c
* checkpatch ./net/batman-adv/soft-interface.c
* checkpatch ./net/batman-adv/types.h
* difference between net and batadv master
* smatch linux-5.8 CONFIG_BATMAN_ADV_BLA=n CONFIG_BATMAN_ADV_DAT=n CONFIG_BATMAN_ADV_DEBUGFS=y CONFIG_BATMAN_ADV_DEBUG=n CONFIG_BATMAN_ADV_TRACING=n CONFIG_BATMAN_ADV_NC=y CONFIG_BATMAN_ADV_MCAST=n CONFIG_BATMAN_ADV_BATMAN_V=y CONFIG_BATMAN_ADV_SYSFS=y
* smatch linux-5.8 CONFIG_BATMAN_ADV_BLA=n CONFIG_BATMAN_ADV_DAT=n CONFIG_BATMAN_ADV_DEBUGFS=y CONFIG_BATMAN_ADV_DEBUG=y CONFIG_BATMAN_ADV_TRACING=y CONFIG_BATMAN_ADV_NC=n CONFIG_BATMAN_ADV_MCAST=y CONFIG_BATMAN_ADV_BATMAN_V=y CONFIG_BATMAN_ADV_SYSFS=n
* smatch linux-5.8 CONFIG_BATMAN_ADV_BLA=n CONFIG_BATMAN_ADV_DAT=y CONFIG_BATMAN_ADV_DEBUGFS=y CONFIG_BATMAN_ADV_DEBUG=n CONFIG_BATMAN_ADV_TRACING=n CONFIG_BATMAN_ADV_NC=y CONFIG_BATMAN_ADV_MCAST=y CONFIG_BATMAN_ADV_BATMAN_V=n CONFIG_BATMAN_ADV_SYSFS=y
* smatch linux-5.8 CONFIG_BATMAN_ADV_BLA=n CONFIG_BATMAN_ADV_DAT=y CONFIG_BATMAN_ADV_DEBUGFS=y CONFIG_BATMAN_ADV_DEBUG=n CONFIG_BATMAN_ADV_TRACING=y CONFIG_BATMAN_ADV_NC=n CONFIG_BATMAN_ADV_MCAST=n CONFIG_BATMAN_ADV_BATMAN_V=n CONFIG_BATMAN_ADV_SYSFS=y
* smatch linux-5.8 CONFIG_BATMAN_ADV_BLA=y CONFIG_BATMAN_ADV_DAT=n CONFIG_BATMAN_ADV_DEBUGFS=n CONFIG_BATMAN_ADV_DEBUG=n CONFIG_BATMAN_ADV_TRACING=n CONFIG_BATMAN_ADV_NC=n CONFIG_BATMAN_ADV_MCAST=y CONFIG_BATMAN_ADV_BATMAN_V=y CONFIG_BATMAN_ADV_SYSFS=n
* smatch linux-5.8 CONFIG_BATMAN_ADV_BLA=y CONFIG_BATMAN_ADV_DAT=n CONFIG_BATMAN_ADV_DEBUGFS=n CONFIG_BATMAN_ADV_DEBUG=n CONFIG_BATMAN_ADV_TRACING=n CONFIG_BATMAN_ADV_NC=y CONFIG_BATMAN_ADV_MCAST=n CONFIG_BATMAN_ADV_BATMAN_V=n CONFIG_BATMAN_ADV_SYSFS=n
* smatch linux-5.8 CONFIG_BATMAN_ADV_BLA=y CONFIG_BATMAN_ADV_DAT=n CONFIG_BATMAN_ADV_DEBUGFS=n CONFIG_BATMAN_ADV_DEBUG=y CONFIG_BATMAN_ADV_TRACING=y CONFIG_BATMAN_ADV_NC=n CONFIG_BATMAN_ADV_MCAST=n CONFIG_BATMAN_ADV_BATMAN_V=y CONFIG_BATMAN_ADV_SYSFS=n
* smatch linux-5.8 CONFIG_BATMAN_ADV_BLA=y CONFIG_BATMAN_ADV_DAT=n CONFIG_BATMAN_ADV_DEBUGFS=y CONFIG_BATMAN_ADV_DEBUG=y CONFIG_BATMAN_ADV_TRACING=n CONFIG_BATMAN_ADV_NC=y CONFIG_BATMAN_ADV_MCAST=n CONFIG_BATMAN_ADV_BATMAN_V=n CONFIG_BATMAN_ADV_SYSFS=y
* smatch linux-5.8 CONFIG_BATMAN_ADV_BLA=y CONFIG_BATMAN_ADV_DAT=n CONFIG_BATMAN_ADV_DEBUGFS=y CONFIG_BATMAN_ADV_DEBUG=y CONFIG_BATMAN_ADV_TRACING=y CONFIG_BATMAN_ADV_NC=n CONFIG_BATMAN_ADV_MCAST=y CONFIG_BATMAN_ADV_BATMAN_V=n CONFIG_BATMAN_ADV_SYSFS=n
Output of different failed tests
================================
master: checkpatch ./net/batman-adv/bridge_loop_avoidance.c
-----------------------------------------------------------
WARNING: Possible repeated word: 'function'
#1798: FILE: ./net/batman-adv/bridge_loop_avoidance.c:1798:
+ /* backbone_gw is unreferenced in the report work function function
total: 0 errors, 1 warnings, 0 checks, 2544 lines checked
master: checkpatch ./net/batman-adv/fragmentation.c
---------------------------------------------------
WARNING: Possible repeated word: 'not'
#309: FILE: ./net/batman-adv/fragmentation.c:309:
+ * Return: true when the packet is merged or buffered, false when skb is not not
total: 0 errors, 1 warnings, 0 checks, 548 lines checked
master: checkpatch ./net/batman-adv/hard-interface.c
----------------------------------------------------
WARNING: Possible repeated word: 'table'
#602: FILE: ./net/batman-adv/hard-interface.c:602:
+ * maximum local table table size
total: 0 errors, 1 warnings, 0 checks, 1098 lines checked
master: checkpatch ./net/batman-adv/multicast.c
-----------------------------------------------
WARNING: Possible repeated word: 'multicast'
#210: FILE: ./net/batman-adv/multicast.c:210:
+ * is capable of performing proper RFC4286 multicast multicast router
total: 0 errors, 1 warnings, 0 checks, 2430 lines checked
master: checkpatch ./net/batman-adv/network-coding.c
----------------------------------------------------
WARNING: Possible repeated word: 'is'
#253: FILE: ./net/batman-adv/network-coding.c:253:
+ * @dropped: whether the packet is freed because is is dropped
total: 0 errors, 1 warnings, 0 checks, 1962 lines checked
master: checkpatch ./net/batman-adv/send.c
------------------------------------------
WARNING: Possible repeated word: 'is'
#464: FILE: ./net/batman-adv/send.c:464:
+ * @dropped: whether the packet is freed because is is dropped
total: 0 errors, 1 warnings, 0 checks, 1002 lines checked
master: checkpatch ./net/batman-adv/soft-interface.c
----------------------------------------------------
WARNING: Possible repeated word: 'the'
#652: FILE: ./net/batman-adv/soft-interface.c:652:
+ * @proto: protocol of the the vlan id
WARNING: Possible repeated word: 'the'
#710: FILE: ./net/batman-adv/soft-interface.c:710:
+ * @proto: protocol of the the vlan id
total: 0 errors, 2 warnings, 0 checks, 1180 lines checked
master: checkpatch ./net/batman-adv/types.h
-------------------------------------------
WARNING: Possible repeated word: 'time'
#1495: FILE: ./net/batman-adv/types.h:1495:
+ /** @last_recv_time: time time (jiffies) a msg was received */
WARNING: Possible repeated word: 'address'
#1999: FILE: ./net/batman-adv/types.h:1999:
+ * @addr: mac address address of the originator this request was sent to
total: 0 errors, 2 warnings, 0 checks, 2476 lines checked
maint: difference between net and batadv maint
----------------------------------------------
net/Documentation/networking/batman-adv.rst | 8 ++--
net/include/uapi/linux/batman_adv.h | 7 ++-
net/net/batman-adv/bat_iv_ogm.c | 25 ++++++------
net/net/batman-adv/bat_v_elp.c | 10 ++---
net/net/batman-adv/bat_v_ogm.c | 38 +++++++++++--------
net/net/batman-adv/bridge_loop_avoidance.c | 6 +--
net/net/batman-adv/distributed-arp-table.c | 2 -
net/net/batman-adv/fragmentation.c | 6 +--
net/net/batman-adv/gateway_client.c | 6 +--
net/net/batman-adv/hard-interface.c | 16 ++++----
net/net/batman-adv/log.h | 6 +--
net/net/batman-adv/main.c | 2 -
net/net/batman-adv/main.h | 8 ++--
net/net/batman-adv/multicast.c | 21 +++++-----
net/net/batman-adv/netlink.c | 14 ++++++-
net/net/batman-adv/network-coding.c | 14 +++----
net/net/batman-adv/originator.c | 8 ++--
net/net/batman-adv/routing.c | 4 +-
net/net/batman-adv/send.c | 4 +-
net/net/batman-adv/soft-interface.c | 2 -
net/net/batman-adv/tp_meter.c | 12 +++---
net/net/batman-adv/translation-table.c | 10 ++---
net/net/batman-adv/tvlv.c | 4 +-
net/net/batman-adv/types.h | 18 ++++++---
24 files changed, 138 insertions(+), 113 deletions(-)
master: difference between net and batadv master
------------------------------------------------
netnext/net/batman-adv/bat_v_ogm.c | 11 +++++------
netnext/net/batman-adv/gateway_client.c | 6 ++----
2 files changed, 7 insertions(+), 10 deletions(-)
master: smatch linux-5.8 CONFIG_BATMAN_ADV_BLA=y CONFIG_BATMAN_ADV_DAT=n CONFIG_BATMAN_ADV_DEBUGFS=y CONFIG_BATMAN_ADV_DEBUG=y CONFIG_BATMAN_ADV_TRACING=y CONFIG_BATMAN_ADV_NC=n CONFIG_BATMAN_ADV_MCAST=y CONFIG_BATMAN_ADV_BATMAN_V=n CONFIG_BATMAN_ADV_SYSFS=n
---------------------------------------------------------------------------
/home/build_test/build_env/tmp.ZNvnvOn91n/net/batman-adv/routing.c:1159 batadv_recv_frag_packet() warn: variable dereferenced before check 'skb' (see line 1133)
Statistics
==========
maint
-----
Failed tests: 11
Started build tests: 292
Tested Linux versions: 32
Tested configs: 227
master
------
Failed tests: 18
Started build tests: 281
Tested Linux versions: 32
Tested configs: 216
3 months, 1 week
Build check errors found: 2020-08-13
by postmaster＠open-mesh.org
Name of failed tests
====================
maint
-----
* difference between net and batadv maint
* sparse linux-5.8 cfg: BLA=n DAT=n DEBUGFS=n DEBUG=n TRACING=y NC=n MCAST=y BATMAN_V=n SYSFS=n
* sparse linux-5.8 cfg: BLA=n DAT=n DEBUGFS=y DEBUG=y TRACING=y NC=n MCAST=n BATMAN_V=y SYSFS=n
* sparse linux-5.8 cfg: BLA=n DAT=n DEBUGFS=y DEBUG=y TRACING=y NC=n MCAST=n BATMAN_V=y SYSFS=y
* sparse linux-5.8 cfg: BLA=y DAT=y DEBUGFS=n DEBUG=n TRACING=n NC=n MCAST=n BATMAN_V=n SYSFS=n
* sparse linux-5.8 cfg: BLA=y DAT=y DEBUGFS=y DEBUG=n TRACING=y NC=y MCAST=y BATMAN_V=n SYSFS=y
master
------
* checkpatch ./net/batman-adv/bridge_loop_avoidance.c
* checkpatch ./net/batman-adv/fragmentation.c
* checkpatch ./net/batman-adv/hard-interface.c
* checkpatch ./net/batman-adv/multicast.c
* checkpatch ./net/batman-adv/network-coding.c
* checkpatch ./net/batman-adv/send.c
* checkpatch ./net/batman-adv/soft-interface.c
* checkpatch ./net/batman-adv/types.h
* difference between net and batadv master
* sparse linux-5.8 cfg: BLA=n DAT=n DEBUGFS=y DEBUG=y TRACING=y NC=n MCAST=n BATMAN_V=n SYSFS=y
* sparse linux-5.8 cfg: BLA=n DAT=y DEBUGFS=n DEBUG=y TRACING=n NC=n MCAST=y BATMAN_V=n SYSFS=y
Output of different failed tests
================================
master: checkpatch ./net/batman-adv/bridge_loop_avoidance.c
-----------------------------------------------------------
WARNING: Possible repeated word: 'function'
#1798: FILE: ./net/batman-adv/bridge_loop_avoidance.c:1798:
+ /* backbone_gw is unreferenced in the report work function function
total: 0 errors, 1 warnings, 0 checks, 2544 lines checked
master: checkpatch ./net/batman-adv/fragmentation.c
---------------------------------------------------
WARNING: Possible repeated word: 'not'
#309: FILE: ./net/batman-adv/fragmentation.c:309:
+ * Return: true when the packet is merged or buffered, false when skb is not not
total: 0 errors, 1 warnings, 0 checks, 548 lines checked
master: checkpatch ./net/batman-adv/hard-interface.c
----------------------------------------------------
WARNING: Possible repeated word: 'table'
#602: FILE: ./net/batman-adv/hard-interface.c:602:
+ * maximum local table table size
total: 0 errors, 1 warnings, 0 checks, 1098 lines checked
master: checkpatch ./net/batman-adv/multicast.c
-----------------------------------------------
WARNING: Possible repeated word: 'multicast'
#210: FILE: ./net/batman-adv/multicast.c:210:
+ * is capable of performing proper RFC4286 multicast multicast router
total: 0 errors, 1 warnings, 0 checks, 2430 lines checked
master: checkpatch ./net/batman-adv/network-coding.c
----------------------------------------------------
WARNING: Possible repeated word: 'is'
#253: FILE: ./net/batman-adv/network-coding.c:253:
+ * @dropped: whether the packet is freed because is is dropped
total: 0 errors, 1 warnings, 0 checks, 1962 lines checked
master: checkpatch ./net/batman-adv/send.c
------------------------------------------
WARNING: Possible repeated word: 'is'
#464: FILE: ./net/batman-adv/send.c:464:
+ * @dropped: whether the packet is freed because is is dropped
total: 0 errors, 1 warnings, 0 checks, 1002 lines checked
master: checkpatch ./net/batman-adv/soft-interface.c
----------------------------------------------------
WARNING: Possible repeated word: 'the'
#652: FILE: ./net/batman-adv/soft-interface.c:652:
+ * @proto: protocol of the the vlan id
WARNING: Possible repeated word: 'the'
#710: FILE: ./net/batman-adv/soft-interface.c:710:
+ * @proto: protocol of the the vlan id
total: 0 errors, 2 warnings, 0 checks, 1180 lines checked
master: checkpatch ./net/batman-adv/types.h
-------------------------------------------
WARNING: Possible repeated word: 'time'
#1495: FILE: ./net/batman-adv/types.h:1495:
+ /** @last_recv_time: time time (jiffies) a msg was received */
WARNING: Possible repeated word: 'address'
#1999: FILE: ./net/batman-adv/types.h:1999:
+ * @addr: mac address address of the originator this request was sent to
total: 0 errors, 2 warnings, 0 checks, 2476 lines checked
maint: difference between net and batadv maint
----------------------------------------------
net/Documentation/networking/batman-adv.rst | 8 ++--
net/include/uapi/linux/batman_adv.h | 7 ++-
net/net/batman-adv/bat_iv_ogm.c | 25 ++++++------
net/net/batman-adv/bat_v_elp.c | 10 ++---
net/net/batman-adv/bat_v_ogm.c | 38 +++++++++++--------
net/net/batman-adv/bridge_loop_avoidance.c | 6 +--
net/net/batman-adv/distributed-arp-table.c | 2 -
net/net/batman-adv/fragmentation.c | 6 +--
net/net/batman-adv/gateway_client.c | 6 +--
net/net/batman-adv/hard-interface.c | 16 ++++----
net/net/batman-adv/log.h | 6 +--
net/net/batman-adv/main.c | 2 -
net/net/batman-adv/main.h | 8 ++--
net/net/batman-adv/multicast.c | 21 +++++-----
net/net/batman-adv/netlink.c | 14 ++++++-
net/net/batman-adv/network-coding.c | 14 +++----
net/net/batman-adv/originator.c | 8 ++--
net/net/batman-adv/routing.c | 4 +-
net/net/batman-adv/send.c | 4 +-
net/net/batman-adv/soft-interface.c | 2 -
net/net/batman-adv/tp_meter.c | 12 +++---
net/net/batman-adv/translation-table.c | 10 ++---
net/net/batman-adv/tvlv.c | 4 +-
net/net/batman-adv/types.h | 18 ++++++---
24 files changed, 138 insertions(+), 113 deletions(-)
master: difference between net and batadv master
------------------------------------------------
netnext/net/batman-adv/bat_v_ogm.c | 11 +++++------
netnext/net/batman-adv/gateway_client.c | 6 ++----
2 files changed, 7 insertions(+), 10 deletions(-)
master: sparse linux-5.8 cfg: BLA=n DAT=y DEBUGFS=n DEBUG=y TRACING=n NC=n MCAST=y BATMAN_V=n SYSFS=y
---------------------------------------------------------------------------
WARNING: modpost: Symbol info of vmlinux is missing. Unresolved symbol check will be entirely skipped.
Statistics
==========
maint
-----
Failed tests: 6
Started build tests: 117
Tested Linux versions: 32
Tested configs: 103
master
------
Failed tests: 11
Started build tests: 116
Tested Linux versions: 31
Tested configs: 105
3 months, 1 week
Build check errors found: 2020-08-12
by postmaster＠open-mesh.org
Name of failed tests
====================
maint
-----
* difference between net and batadv maint
* sparse linux-5.8 cfg: BLA=n DAT=n DEBUGFS=n DEBUG=y TRACING=n NC=n MCAST=y BATMAN_V=y SYSFS=y
* sparse linux-5.8 cfg: BLA=n DAT=n DEBUGFS=y DEBUG=y TRACING=n NC=n MCAST=y BATMAN_V=y SYSFS=y
* sparse linux-5.8 cfg: BLA=y DAT=y DEBUGFS=n DEBUG=y TRACING=y NC=y MCAST=n BATMAN_V=n SYSFS=n
master
------
* checkpatch ./net/batman-adv/bridge_loop_avoidance.c
* checkpatch ./net/batman-adv/fragmentation.c
* checkpatch ./net/batman-adv/hard-interface.c
* checkpatch ./net/batman-adv/multicast.c
* checkpatch ./net/batman-adv/network-coding.c
* checkpatch ./net/batman-adv/send.c
* checkpatch ./net/batman-adv/soft-interface.c
* checkpatch ./net/batman-adv/types.h
* difference between net and batadv master
* sparse linux-5.8 cfg: BLA=n DAT=n DEBUGFS=y DEBUG=y TRACING=y NC=n MCAST=y BATMAN_V=n SYSFS=n
Output of different failed tests
================================
master: checkpatch ./net/batman-adv/bridge_loop_avoidance.c
-----------------------------------------------------------
WARNING: Possible repeated word: 'function'
#1798: FILE: ./net/batman-adv/bridge_loop_avoidance.c:1798:
+ /* backbone_gw is unreferenced in the report work function function
total: 0 errors, 1 warnings, 0 checks, 2544 lines checked
master: checkpatch ./net/batman-adv/fragmentation.c
---------------------------------------------------
WARNING: Possible repeated word: 'not'
#309: FILE: ./net/batman-adv/fragmentation.c:309:
+ * Return: true when the packet is merged or buffered, false when skb is not not
total: 0 errors, 1 warnings, 0 checks, 548 lines checked
master: checkpatch ./net/batman-adv/hard-interface.c
----------------------------------------------------
WARNING: Possible repeated word: 'table'
#602: FILE: ./net/batman-adv/hard-interface.c:602:
+ * maximum local table table size
total: 0 errors, 1 warnings, 0 checks, 1098 lines checked
master: checkpatch ./net/batman-adv/multicast.c
-----------------------------------------------
WARNING: Possible repeated word: 'multicast'
#210: FILE: ./net/batman-adv/multicast.c:210:
+ * is capable of performing proper RFC4286 multicast multicast router
total: 0 errors, 1 warnings, 0 checks, 2430 lines checked
master: checkpatch ./net/batman-adv/network-coding.c
----------------------------------------------------
WARNING: Possible repeated word: 'is'
#253: FILE: ./net/batman-adv/network-coding.c:253:
+ * @dropped: whether the packet is freed because is is dropped
total: 0 errors, 1 warnings, 0 checks, 1962 lines checked
master: checkpatch ./net/batman-adv/send.c
------------------------------------------
WARNING: Possible repeated word: 'is'
#464: FILE: ./net/batman-adv/send.c:464:
+ * @dropped: whether the packet is freed because is is dropped
total: 0 errors, 1 warnings, 0 checks, 1002 lines checked
master: checkpatch ./net/batman-adv/soft-interface.c
----------------------------------------------------
WARNING: Possible repeated word: 'the'
#652: FILE: ./net/batman-adv/soft-interface.c:652:
+ * @proto: protocol of the the vlan id
WARNING: Possible repeated word: 'the'
#710: FILE: ./net/batman-adv/soft-interface.c:710:
+ * @proto: protocol of the the vlan id
total: 0 errors, 2 warnings, 0 checks, 1180 lines checked
master: checkpatch ./net/batman-adv/types.h
-------------------------------------------
WARNING: Possible repeated word: 'time'
#1495: FILE: ./net/batman-adv/types.h:1495:
+ /** @last_recv_time: time time (jiffies) a msg was received */
WARNING: Possible repeated word: 'address'
#1999: FILE: ./net/batman-adv/types.h:1999:
+ * @addr: mac address address of the originator this request was sent to
total: 0 errors, 2 warnings, 0 checks, 2476 lines checked
maint: difference between net and batadv maint
----------------------------------------------
net/Documentation/networking/batman-adv.rst | 8 ++--
net/include/uapi/linux/batman_adv.h | 7 ++-
net/net/batman-adv/bat_iv_ogm.c | 25 ++++++------
net/net/batman-adv/bat_v_elp.c | 10 ++---
net/net/batman-adv/bat_v_ogm.c | 38 +++++++++++--------
net/net/batman-adv/bridge_loop_avoidance.c | 6 +--
net/net/batman-adv/distributed-arp-table.c | 2 -
net/net/batman-adv/fragmentation.c | 6 +--
net/net/batman-adv/gateway_client.c | 6 +--
net/net/batman-adv/hard-interface.c | 16 ++++----
net/net/batman-adv/log.h | 6 +--
net/net/batman-adv/main.c | 2 -
net/net/batman-adv/main.h | 8 ++--
net/net/batman-adv/multicast.c | 21 +++++-----
net/net/batman-adv/netlink.c | 14 ++++++-
net/net/batman-adv/network-coding.c | 14 +++----
net/net/batman-adv/originator.c | 8 ++--
net/net/batman-adv/routing.c | 4 +-
net/net/batman-adv/send.c | 4 +-
net/net/batman-adv/soft-interface.c | 2 -
net/net/batman-adv/tp_meter.c | 12 +++---
net/net/batman-adv/translation-table.c | 10 ++---
net/net/batman-adv/tvlv.c | 4 +-
net/net/batman-adv/types.h | 18 ++++++---
24 files changed, 138 insertions(+), 113 deletions(-)
master: difference between net and batadv master
------------------------------------------------
netnext/net/batman-adv/bat_v_ogm.c | 11 +++++------
netnext/net/batman-adv/gateway_client.c | 6 ++----
2 files changed, 7 insertions(+), 10 deletions(-)
master: sparse linux-5.8 cfg: BLA=n DAT=n DEBUGFS=y DEBUG=y TRACING=y NC=n MCAST=y BATMAN_V=n SYSFS=n
---------------------------------------------------------------------------
WARNING: modpost: Symbol info of vmlinux is missing. Unresolved symbol check will be entirely skipped.
Statistics
==========
maint
-----
Failed tests: 4
Started build tests: 117
Tested Linux versions: 30
Tested configs: 105
master
------
Failed tests: 10
Started build tests: 112
Tested Linux versions: 29
Tested configs: 105
3 months, 2 weeks
[linux-next] LinuxNextTracking branch, master, updated. next-20200811
by batman＠open-mesh.org
The following commit has been merged in the master branch:
commit 7a6b60441f02f6e22e7c0936ef16fa3f51832a48
Merge: 8d3e09b43312991c503478bf0f5f99e92c23ccf1 b297fed699ad9e50315b27e78de42ac631c9990d
Author: Linus Torvalds <torvalds(a)linux-foundation.org>
Date: Sun Aug 9 13:58:04 2020 -0700
Merge tag 'nfsd-5.9' of git://git.linux-nfs.org/projects/cel/cel-2.6
Pull NFS server updates from Chuck Lever:
"Highlights:
- Support for user extended attributes on NFS (RFC 8276)
- Further reduce unnecessary NFSv4 delegation recalls
Notable fixes:
- Fix recent krb5p regression
- Address a few resource leaks and a rare NULL dereference
Other:
- De-duplicate RPC/RDMA error handling and other utility functions
- Replace storage and display of kernel memory addresses by tracepoints"
* tag 'nfsd-5.9' of git://git.linux-nfs.org/projects/cel/cel-2.6: (38 commits)
svcrdma: CM event handler clean up
svcrdma: Remove transport reference counting
svcrdma: Fix another Receive buffer leak
SUNRPC: Refresh the show_rqstp_flags() macro
nfsd: netns.h: delete a duplicated word
SUNRPC: Fix ("SUNRPC: Add "@len" parameter to gss_unwrap()")
nfsd: avoid a NULL dereference in __cld_pipe_upcall()
nfsd4: a client's own opens needn't prevent delegations
nfsd: Use seq_putc() in two functions
svcrdma: Display chunk completion ID when posting a rw_ctxt
svcrdma: Record send_ctxt completion ID in trace_svcrdma_post_send()
svcrdma: Introduce Send completion IDs
svcrdma: Record Receive completion ID in svc_rdma_decode_rqst
svcrdma: Introduce Receive completion IDs
svcrdma: Introduce infrastructure to support completion IDs
svcrdma: Add common XDR encoders for RDMA and Read segments
svcrdma: Add common XDR decoders for RDMA and Read segments
SUNRPC: Add helpers for decoding list discriminators symbolically
svcrdma: Remove declarations for functions long removed
svcrdma: Clean up trace_svcrdma_send_failed() tracepoint
...
diff --combined fs/locks.c
index 938fe325bc54,d5de9039dbd7..8fc0542f5132
--- a/fs/locks.c
+++ b/fs/locks.c
@@@ -1282,7 -1282,6 +1282,7 @@@ static int posix_lock_inode(struct inod
if (!new_fl)
goto out;
locks_copy_lock(new_fl, request);
+ locks_move_blocks(new_fl, request);
request = new_fl;
new_fl = NULL;
locks_insert_lock_ctx(request, &fl->fl_list);
@@@ -1808,6 -1807,9 +1808,9 @@@ check_conflicting_open(struct file *fil
if (flags & FL_LAYOUT)
return 0;
+ if (flags & FL_DELEG)
+ /* We leave these checks to the caller. */
+ return 0;
if (arg == F_RDLCK)
return inode_is_open_for_write(inode) ? -EAGAIN : 0;
diff --combined fs/nfsd/nfs4state.c
index c9056316a0b3,fdba971d06c3..81ed8e8bab3f
--- a/fs/nfsd/nfs4state.c
+++ b/fs/nfsd/nfs4state.c
@@@ -507,17 -507,6 +507,17 @@@ find_any_file(struct nfs4_file *f
return ret;
}
+static struct nfsd_file *find_deleg_file(struct nfs4_file *f)
+{
+ struct nfsd_file *ret = NULL;
+
+ spin_lock(&f->fi_lock);
+ if (f->fi_deleg_file)
+ ret = nfsd_file_get(f->fi_deleg_file);
+ spin_unlock(&f->fi_lock);
+ return ret;
+}
+
static atomic_long_t num_delegations;
unsigned long max_delegations;
@@@ -2455,8 -2444,6 +2455,8 @@@ static int nfs4_show_open(struct seq_fi
oo = ols->st_stateowner;
nf = st->sc_file;
file = find_any_file(nf);
+ if (!file)
+ return 0;
seq_printf(s, "- ");
nfs4_show_stateid(s, &st->sc_stateid);
@@@ -2494,8 -2481,6 +2494,8 @@@ static int nfs4_show_lock(struct seq_fi
oo = ols->st_stateowner;
nf = st->sc_file;
file = find_any_file(nf);
+ if (!file)
+ return 0;
seq_printf(s, "- ");
nfs4_show_stateid(s, &st->sc_stateid);
@@@ -2528,9 -2513,7 +2528,9 @@@ static int nfs4_show_deleg(struct seq_f
ds = delegstateid(st);
nf = st->sc_file;
- file = nf->fi_deleg_file;
+ file = find_deleg_file(nf);
+ if (!file)
+ return 0;
seq_printf(s, "- ");
nfs4_show_stateid(s, &st->sc_stateid);
@@@ -2546,7 -2529,6 +2546,7 @@@
seq_printf(s, ", ");
nfs4_show_fname(s, file);
seq_printf(s, " }\n");
+ nfsd_file_put(file);
return 0;
}
@@@ -4940,6 -4922,32 +4940,32 @@@ static struct file_lock *nfs4_alloc_ini
return fl;
}
+ static int nfsd4_check_conflicting_opens(struct nfs4_client *clp,
+ struct nfs4_file *fp)
+ {
+ struct nfs4_clnt_odstate *co;
+ struct file *f = fp->fi_deleg_file->nf_file;
+ struct inode *ino = locks_inode(f);
+ int writes = atomic_read(&ino->i_writecount);
+
+ if (fp->fi_fds[O_WRONLY])
+ writes--;
+ if (fp->fi_fds[O_RDWR])
+ writes--;
+ WARN_ON_ONCE(writes < 0);
+ if (writes > 0)
+ return -EAGAIN;
+ spin_lock(&fp->fi_lock);
+ list_for_each_entry(co, &fp->fi_clnt_odstate, co_perfile) {
+ if (co->co_client != clp) {
+ spin_unlock(&fp->fi_lock);
+ return -EAGAIN;
+ }
+ }
+ spin_unlock(&fp->fi_lock);
+ return 0;
+ }
+
static struct nfs4_delegation *
nfs4_set_delegation(struct nfs4_client *clp, struct svc_fh *fh,
struct nfs4_file *fp, struct nfs4_clnt_odstate *odstate)
@@@ -4959,9 -4967,12 +4985,12 @@@
nf = find_readable_file(fp);
if (!nf) {
- /* We should always have a readable file here */
- WARN_ON_ONCE(1);
- return ERR_PTR(-EBADF);
+ /*
+ * We probably could attempt another open and get a read
+ * delegation, but for now, don't bother until the
+ * client actually sends us one.
+ */
+ return ERR_PTR(-EAGAIN);
}
spin_lock(&state_lock);
spin_lock(&fp->fi_lock);
@@@ -4991,11 -5002,19 +5020,19 @@@
if (!fl)
goto out_clnt_odstate;
+ status = nfsd4_check_conflicting_opens(clp, fp);
+ if (status) {
+ locks_free_lock(fl);
+ goto out_clnt_odstate;
+ }
status = vfs_setlease(fp->fi_deleg_file->nf_file, fl->fl_type, &fl, NULL);
if (fl)
locks_free_lock(fl);
if (status)
goto out_clnt_odstate;
+ status = nfsd4_check_conflicting_opens(clp, fp);
+ if (status)
+ goto out_clnt_odstate;
spin_lock(&state_lock);
spin_lock(&fp->fi_lock);
@@@ -5077,17 -5096,6 +5114,6 @@@ nfs4_open_delegation(struct svc_fh *fh
goto out_no_deleg;
if (!cb_up || !(oo->oo_flags & NFS4_OO_CONFIRMED))
goto out_no_deleg;
- /*
- * Also, if the file was opened for write or
- * create, there's a good chance the client's
- * about to write to it, resulting in an
- * immediate recall (since we don't support
- * write delegations):
- */
- if (open->op_share_access & NFS4_SHARE_ACCESS_WRITE)
- goto out_no_deleg;
- if (open->op_create == NFS4_OPEN_CREATE)
- goto out_no_deleg;
break;
default:
goto out_no_deleg;
diff --combined include/linux/xattr.h
index c5afaf8ca7a2,fac75810d9d3..10b4dc2709f0
--- a/include/linux/xattr.h
+++ b/include/linux/xattr.h
@@@ -15,7 -15,6 +15,7 @@@
#include <linux/slab.h>
#include <linux/types.h>
#include <linux/spinlock.h>
+#include <linux/mm.h>
#include <uapi/linux/xattr.h>
struct inode;
@@@ -52,14 -51,18 +52,18 @@@ ssize_t vfs_getxattr(struct dentry *, c
ssize_t vfs_listxattr(struct dentry *d, char *list, size_t size);
int __vfs_setxattr(struct dentry *, struct inode *, const char *, const void *, size_t, int);
int __vfs_setxattr_noperm(struct dentry *, const char *, const void *, size_t, int);
+ int __vfs_setxattr_locked(struct dentry *, const char *, const void *, size_t, int, struct inode **);
int vfs_setxattr(struct dentry *, const char *, const void *, size_t, int);
int __vfs_removexattr(struct dentry *, const char *);
+ int __vfs_removexattr_locked(struct dentry *, const char *, struct inode **);
int vfs_removexattr(struct dentry *, const char *);
ssize_t generic_listxattr(struct dentry *dentry, char *buffer, size_t buffer_size);
ssize_t vfs_getxattr_alloc(struct dentry *dentry, const char *name,
char **xattr_value, size_t size, gfp_t flags);
+ int xattr_supported_namespace(struct inode *inode, const char *prefix);
+
static inline const char *xattr_prefix(const struct xattr_handler *handler)
{
return handler->prefix ?: handler->name;
@@@ -95,7 -98,7 +99,7 @@@ static inline void simple_xattrs_free(s
list_for_each_entry_safe(xattr, node, &xattrs->head, list) {
kfree(xattr->name);
- kfree(xattr);
+ kvfree(xattr);
}
}
diff --combined net/sunrpc/xprtrdma/rpc_rdma.c
index 453bacc99907,73ed51893175..0f5120c7668f
--- a/net/sunrpc/xprtrdma/rpc_rdma.c
+++ b/net/sunrpc/xprtrdma/rpc_rdma.c
@@@ -71,7 -71,7 +71,7 @@@ static unsigned int rpcrdma_max_call_he
size = RPCRDMA_HDRLEN_MIN;
/* Maximum Read list size */
- size = maxsegs * rpcrdma_readchunk_maxsz * sizeof(__be32);
+ size += maxsegs * rpcrdma_readchunk_maxsz * sizeof(__be32);
/* Minimal Read chunk size */
size += sizeof(__be32); /* segment count */
@@@ -94,7 -94,7 +94,7 @@@ static unsigned int rpcrdma_max_reply_h
size = RPCRDMA_HDRLEN_MIN;
/* Maximum Write list size */
- size = sizeof(__be32); /* segment count */
+ size += sizeof(__be32); /* segment count */
size += maxsegs * rpcrdma_segment_maxsz * sizeof(__be32);
size += sizeof(__be32); /* list discriminator */
@@@ -275,14 -275,6 +275,6 @@@ out
return n;
}
- static void
- xdr_encode_rdma_segment(__be32 *iptr, struct rpcrdma_mr *mr)
- {
- *iptr++ = cpu_to_be32(mr->mr_handle);
- *iptr++ = cpu_to_be32(mr->mr_length);
- xdr_encode_hyper(iptr, mr->mr_offset);
- }
-
static int
encode_rdma_segment(struct xdr_stream *xdr, struct rpcrdma_mr *mr)
{
@@@ -292,7 -284,7 +284,7 @@@
if (unlikely(!p))
return -EMSGSIZE;
- xdr_encode_rdma_segment(p, mr);
+ xdr_encode_rdma_segment(p, mr->mr_handle, mr->mr_length, mr->mr_offset);
return 0;
}
@@@ -307,8 -299,8 +299,8 @@@ encode_read_segment(struct xdr_stream *
return -EMSGSIZE;
*p++ = xdr_one; /* Item present */
- *p++ = cpu_to_be32(position);
- xdr_encode_rdma_segment(p, mr);
+ xdr_encode_read_segment(p, position, mr->mr_handle, mr->mr_length,
+ mr->mr_offset);
return 0;
}
@@@ -1133,11 -1125,11 +1125,11 @@@ rpcrdma_is_bcall(struct rpcrdma_xprt *r
p = xdr_inline_decode(xdr, 0);
/* Chunk lists */
- if (*p++ != xdr_zero)
+ if (xdr_item_is_present(p++))
return false;
- if (*p++ != xdr_zero)
+ if (xdr_item_is_present(p++))
return false;
- if (*p++ != xdr_zero)
+ if (xdr_item_is_present(p++))
return false;
/* RPC header */
@@@ -1176,10 -1168,7 +1168,7 @@@ static int decode_rdma_segment(struct x
if (unlikely(!p))
return -EIO;
- handle = be32_to_cpup(p++);
- *length = be32_to_cpup(p++);
- xdr_decode_hyper(p, &offset);
-
+ xdr_decode_rdma_segment(p, &handle, length, &offset);
trace_xprtrdma_decode_seg(handle, *length, offset);
return 0;
}
@@@ -1215,7 -1204,7 +1204,7 @@@ static int decode_read_list(struct xdr_
p = xdr_inline_decode(xdr, sizeof(*p));
if (unlikely(!p))
return -EIO;
- if (unlikely(*p != xdr_zero))
+ if (unlikely(xdr_item_is_present(p)))
return -EIO;
return 0;
}
@@@ -1234,7 -1223,7 +1223,7 @@@ static int decode_write_list(struct xdr
p = xdr_inline_decode(xdr, sizeof(*p));
if (unlikely(!p))
return -EIO;
- if (*p == xdr_zero)
+ if (xdr_item_is_absent(p))
break;
if (!first)
return -EIO;
@@@ -1256,7 -1245,7 +1245,7 @@@ static int decode_reply_chunk(struct xd
return -EIO;
*length = 0;
- if (*p != xdr_zero)
+ if (xdr_item_is_present(p))
if (decode_write_chunk(xdr, length))
return -EIO;
return 0;
--
LinuxNextTracking
3 months, 2 weeks
