linux-merge October 2016

linux-merge@lists.open-mesh.org

3 participants
54 discussions

Build check errors found: 2016-10-26
by postmaster＠open-mesh.org 26 Oct '16

26 Oct '16

Name of failed tests ==================== next ---- * checkpatch ./net/batman-adv/debugfs.c * checkpatch ./net/batman-adv/icmp_socket.c * checkpatch ./net/batman-adv/log.c * checkpatch ./net/batman-adv/network-coding.c * checkpatch ./net/batman-adv/sysfs.c * difference between net-next and batadv next Output of different failed tests ================================ next: checkpatch ./net/batman-adv/debugfs.c ------------------------------------------- WARNING: Symbolic permissions 'S_IRUGO' are not preferred. Consider using octal permissions '0444'. #189: FILE: ./net/batman-adv/debugfs.c:189: +static BATADV_DEBUGINFO(routing_algos, S_IRUGO, batadv_algorithms_open); WARNING: Symbolic permissions 'S_IRUGO' are not preferred. Consider using octal permissions '0444'. #197: FILE: ./net/batman-adv/debugfs.c:197: +static BATADV_DEBUGINFO(neighbors, S_IRUGO, neighbors_open); WARNING: Symbolic permissions 'S_IRUGO' are not preferred. Consider using octal permissions '0444'. #198: FILE: ./net/batman-adv/debugfs.c:198: +static BATADV_DEBUGINFO(originators, S_IRUGO, batadv_originators_open); WARNING: Symbolic permissions 'S_IRUGO' are not preferred. Consider using octal permissions '0444'. #199: FILE: ./net/batman-adv/debugfs.c:199: +static BATADV_DEBUGINFO(gateways, S_IRUGO, batadv_gateways_open); WARNING: Symbolic permissions 'S_IRUGO' are not preferred. Consider using octal permissions '0444'. #200: FILE: ./net/batman-adv/debugfs.c:200: +static BATADV_DEBUGINFO(transtable_global, S_IRUGO, WARNING: Symbolic permissions 'S_IRUGO' are not preferred. Consider using octal permissions '0444'. #203: FILE: ./net/batman-adv/debugfs.c:203: +static BATADV_DEBUGINFO(bla_claim_table, S_IRUGO, batadv_bla_claim_table_open); WARNING: Symbolic permissions 'S_IRUGO' are not preferred. Consider using octal permissions '0444'. #204: FILE: ./net/batman-adv/debugfs.c:204: +static BATADV_DEBUGINFO(bla_backbone_table, S_IRUGO, WARNING: Symbolic permissions 'S_IRUGO' are not preferred. Consider using octal permissions '0444'. #208: FILE: ./net/batman-adv/debugfs.c:208: +static BATADV_DEBUGINFO(dat_cache, S_IRUGO, batadv_dat_cache_open); WARNING: Symbolic permissions 'S_IRUGO' are not preferred. Consider using octal permissions '0444'. #210: FILE: ./net/batman-adv/debugfs.c:210: +static BATADV_DEBUGINFO(transtable_local, S_IRUGO, WARNING: Symbolic permissions 'S_IRUGO' are not preferred. Consider using octal permissions '0444'. #213: FILE: ./net/batman-adv/debugfs.c:213: +static BATADV_DEBUGINFO(nc_nodes, S_IRUGO, batadv_nc_nodes_open); WARNING: Symbolic permissions 'S_IRUGO' are not preferred. Consider using octal permissions '0444'. #216: FILE: ./net/batman-adv/debugfs.c:216: +static BATADV_DEBUGINFO(mcast_flags, S_IRUGO, batadv_mcast_flags_open); WARNING: Symbolic permissions 'S_IRUGO' are not preferred. Consider using octal permissions '0444'. #256: FILE: ./net/batman-adv/debugfs.c:256: +static BATADV_HARDIF_DEBUGINFO(originators, S_IRUGO, total: 0 errors, 12 warnings, 0 checks, 420 lines checked next: checkpatch ./net/batman-adv/icmp_socket.c ----------------------------------------------- WARNING: Symbolic permissions 'S_IWUSR | S_IRUSR' are not preferred. Consider using octal permissions '0600'. #325: FILE: ./net/batman-adv/icmp_socket.c:325: + d = debugfs_create_file(BATADV_ICMP_SOCKET, S_IFREG | S_IWUSR | S_IRUSR, total: 0 errors, 1 warnings, 0 checks, 407 lines checked next: checkpatch ./net/batman-adv/log.c --------------------------------------- WARNING: Symbolic permissions 'S_IRUSR' are not preferred. Consider using octal permissions '0400'. #215: FILE: ./net/batman-adv/log.c:215: + d = debugfs_create_file("log", S_IFREG | S_IRUSR, total: 0 errors, 1 warnings, 0 checks, 231 lines checked next: checkpatch ./net/batman-adv/network-coding.c -------------------------------------------------- WARNING: Symbolic permissions 'S_IRUGO | S_IWUSR' are not preferred. Consider using octal permissions '0644'. #1964: FILE: ./net/batman-adv/network-coding.c:1964: + file = debugfs_create_u8("min_tq", S_IRUGO | S_IWUSR, nc_dir, WARNING: Symbolic permissions 'S_IRUGO | S_IWUSR' are not preferred. Consider using octal permissions '0644'. #1969: FILE: ./net/batman-adv/network-coding.c:1969: + file = debugfs_create_u32("max_fwd_delay", S_IRUGO | S_IWUSR, nc_dir, WARNING: Symbolic permissions 'S_IRUGO | S_IWUSR' are not preferred. Consider using octal permissions '0644'. #1974: FILE: ./net/batman-adv/network-coding.c:1974: + file = debugfs_create_u32("max_buffer_time", S_IRUGO | S_IWUSR, nc_dir, total: 0 errors, 3 warnings, 0 checks, 1984 lines checked next: checkpatch ./net/batman-adv/sysfs.c ----------------------------------------- WARNING: Symbolic permissions 'S_IRUGO | S_IWUSR' are not preferred. Consider using octal permissions '0644'. #669: FILE: ./net/batman-adv/sysfs.c:669: +BATADV_ATTR_SIF_BOOL(aggregated_ogms, S_IRUGO | S_IWUSR, NULL); WARNING: Symbolic permissions 'S_IRUGO | S_IWUSR' are not preferred. Consider using octal permissions '0644'. #670: FILE: ./net/batman-adv/sysfs.c:670: +BATADV_ATTR_SIF_BOOL(bonding, S_IRUGO | S_IWUSR, NULL); WARNING: Symbolic permissions 'S_IRUGO | S_IWUSR' are not preferred. Consider using octal permissions '0644'. #672: FILE: ./net/batman-adv/sysfs.c:672: +BATADV_ATTR_SIF_BOOL(bridge_loop_avoidance, S_IRUGO | S_IWUSR, WARNING: Symbolic permissions 'S_IRUGO | S_IWUSR' are not preferred. Consider using octal permissions '0644'. #676: FILE: ./net/batman-adv/sysfs.c:676: +BATADV_ATTR_SIF_BOOL(distributed_arp_table, S_IRUGO | S_IWUSR, WARNING: Symbolic permissions 'S_IRUGO | S_IWUSR' are not preferred. Consider using octal permissions '0644'. #679: FILE: ./net/batman-adv/sysfs.c:679: +BATADV_ATTR_SIF_BOOL(fragmentation, S_IRUGO | S_IWUSR, batadv_update_min_mtu); WARNING: Symbolic permissions 'S_IRUGO' are not preferred. Consider using octal permissions '0444'. #680: FILE: ./net/batman-adv/sysfs.c:680: +static BATADV_ATTR(routing_algo, S_IRUGO, batadv_show_bat_algo, NULL); WARNING: Symbolic permissions 'S_IRUGO | S_IWUSR' are not preferred. Consider using octal permissions '0644'. #681: FILE: ./net/batman-adv/sysfs.c:681: +static BATADV_ATTR(gw_mode, S_IRUGO | S_IWUSR, batadv_show_gw_mode, WARNING: Symbolic permissions 'S_IRUGO | S_IWUSR' are not preferred. Consider using octal permissions '0644'. #683: FILE: ./net/batman-adv/sysfs.c:683: +BATADV_ATTR_SIF_UINT(orig_interval, orig_interval, S_IRUGO | S_IWUSR, WARNING: Symbolic permissions 'S_IRUGO | S_IWUSR' are not preferred. Consider using octal permissions '0644'. #685: FILE: ./net/batman-adv/sysfs.c:685: +BATADV_ATTR_SIF_UINT(hop_penalty, hop_penalty, S_IRUGO | S_IWUSR, 0, WARNING: Symbolic permissions 'S_IRUGO | S_IWUSR' are not preferred. Consider using octal permissions '0644'. #687: FILE: ./net/batman-adv/sysfs.c:687: +static BATADV_ATTR(gw_sel_class, S_IRUGO | S_IWUSR, batadv_show_gw_sel_class, WARNING: Symbolic permissions 'S_IRUGO | S_IWUSR' are not preferred. Consider using octal permissions '0644'. #689: FILE: ./net/batman-adv/sysfs.c:689: +static BATADV_ATTR(gw_bandwidth, S_IRUGO | S_IWUSR, batadv_show_gw_bwidth, WARNING: Symbolic permissions 'S_IRUGO | S_IWUSR' are not preferred. Consider using octal permissions '0644'. #692: FILE: ./net/batman-adv/sysfs.c:692: +BATADV_ATTR_SIF_BOOL(multicast_mode, S_IRUGO | S_IWUSR, NULL); WARNING: Symbolic permissions 'S_IRUGO | S_IWUSR' are not preferred. Consider using octal permissions '0644'. #695: FILE: ./net/batman-adv/sysfs.c:695: +BATADV_ATTR_SIF_UINT(log_level, log_level, S_IRUGO | S_IWUSR, 0, WARNING: Symbolic permissions 'S_IRUGO | S_IWUSR' are not preferred. Consider using octal permissions '0644'. #699: FILE: ./net/batman-adv/sysfs.c:699: +BATADV_ATTR_SIF_BOOL(network_coding, S_IRUGO | S_IWUSR, WARNING: Symbolic permissions 'S_IRUGO | S_IWUSR' are not preferred. Consider using octal permissions '0644'. #702: FILE: ./net/batman-adv/sysfs.c:702: +static BATADV_ATTR(isolation_mark, S_IRUGO | S_IWUSR, WARNING: Symbolic permissions 'S_IRUGO | S_IWUSR' are not preferred. Consider using octal permissions '0644'. #734: FILE: ./net/batman-adv/sysfs.c:734: +BATADV_ATTR_VLAN_BOOL(ap_isolation, S_IRUGO | S_IWUSR, NULL); WARNING: Symbolic permissions 'S_IRUGO | S_IWUSR' are not preferred. Consider using octal permissions '0644'. #1119: FILE: ./net/batman-adv/sysfs.c:1119: +static BATADV_ATTR(mesh_iface, S_IRUGO | S_IWUSR, batadv_show_mesh_iface, WARNING: Symbolic permissions 'S_IRUGO' are not preferred. Consider using octal permissions '0444'. #1121: FILE: ./net/batman-adv/sysfs.c:1121: +static BATADV_ATTR(iface_status, S_IRUGO, batadv_show_iface_status, NULL); WARNING: Symbolic permissions 'S_IRUGO | S_IWUSR' are not preferred. Consider using octal permissions '0644'. #1123: FILE: ./net/batman-adv/sysfs.c:1123: +BATADV_ATTR_HIF_UINT(elp_interval, bat_v.elp_interval, S_IRUGO | S_IWUSR, WARNING: Symbolic permissions 'S_IRUGO | S_IWUSR' are not preferred. Consider using octal permissions '0644'. #1125: FILE: ./net/batman-adv/sysfs.c:1125: +static BATADV_ATTR(throughput_override, S_IRUGO | S_IWUSR, total: 0 errors, 20 warnings, 0 checks, 1224 lines checked next: difference between net-next and batadv next ------------------------------------------------- netnext/net/batman-adv/hard-interface.c | 1 + netnext/net/batman-adv/log.h | 2 +- netnext/net/batman-adv/originator.c | 2 +- netnext/net/batman-adv/soft-interface.c | 13 +------------ 4 files changed, 4 insertions(+), 14 deletions(-) Statistics ========== master ------ Failed tests: 0 Started build tests: 112 Tested Linux versions: 27 Tested configs: 72 next ---- Failed tests: 6 Started build tests: 112 Tested Linux versions: 27 Tested configs: 79

1 0

Coverity Scan: Analysis completed for batctl
by scan-admin＠coverity.com 25 Oct '16

25 Oct '16

1 0

Build check errors found: 2016-10-25
by postmaster＠open-mesh.org 25 Oct '16

25 Oct '16

Name of failed tests ==================== master ------ * cppcheck * sparse linux-3.10 cfg: BLA=n DAT=n DEBUGFS=y DEBUG=n NC=y MCAST=y BATMAN_V=n * sparse linux-3.10 cfg: BLA=n DAT=y DEBUGFS=y DEBUG=n NC=y MCAST=y BATMAN_V=n * sparse linux-3.10 cfg: BLA=y DAT=n DEBUGFS=n DEBUG=n NC=n MCAST=y BATMAN_V=n * sparse linux-3.10 cfg: BLA=y DAT=y DEBUGFS=y DEBUG=n NC=n MCAST=y BATMAN_V=n * sparse linux-3.11 cfg: BLA=n DAT=n DEBUGFS=y DEBUG=n NC=y MCAST=y BATMAN_V=n * sparse linux-3.11 cfg: BLA=n DAT=y DEBUGFS=n DEBUG=n NC=n MCAST=n BATMAN_V=n * sparse linux-3.11 cfg: BLA=y DAT=y DEBUGFS=n DEBUG=n NC=y MCAST=n BATMAN_V=n * sparse linux-3.11 cfg: BLA=y DAT=y DEBUGFS=y DEBUG=n NC=y MCAST=n BATMAN_V=n * sparse linux-3.12 cfg: BLA=y DAT=y DEBUGFS=y DEBUG=y NC=n MCAST=n BATMAN_V=n * sparse linux-3.13 cfg: BLA=n DAT=y DEBUGFS=y DEBUG=y NC=y MCAST=n BATMAN_V=n * sparse linux-3.13 cfg: BLA=y DAT=n DEBUGFS=y DEBUG=y NC=n MCAST=n BATMAN_V=n * sparse linux-3.15 cfg: BLA=n DAT=y DEBUGFS=y DEBUG=y NC=n MCAST=y BATMAN_V=n * sparse linux-3.15 cfg: BLA=y DAT=n DEBUGFS=n DEBUG=n NC=n MCAST=y BATMAN_V=n * sparse linux-3.15 cfg: BLA=y DAT=n DEBUGFS=y DEBUG=y NC=n MCAST=n BATMAN_V=n * sparse linux-3.16 cfg: BLA=n DAT=n DEBUGFS=y DEBUG=n NC=n MCAST=n BATMAN_V=n * sparse linux-3.16 cfg: BLA=n DAT=y DEBUGFS=n DEBUG=n NC=n MCAST=y BATMAN_V=n * sparse linux-3.16 cfg: BLA=n DAT=y DEBUGFS=y DEBUG=y NC=n MCAST=y BATMAN_V=y * sparse linux-3.16 cfg: BLA=y DAT=n DEBUGFS=y DEBUG=n NC=y MCAST=y BATMAN_V=n * sparse linux-3.16 cfg: BLA=y DAT=y DEBUGFS=n DEBUG=n NC=n MCAST=y BATMAN_V=n * sparse linux-3.17 cfg: BLA=n DAT=n DEBUGFS=y DEBUG=y NC=y MCAST=n BATMAN_V=n * sparse linux-3.17 cfg: BLA=n DAT=y DEBUGFS=n DEBUG=n NC=y MCAST=n BATMAN_V=y * sparse linux-3.17 cfg: BLA=n DAT=y DEBUGFS=y DEBUG=y NC=y MCAST=n BATMAN_V=y * sparse linux-3.17 cfg: BLA=n DAT=y DEBUGFS=y DEBUG=y NC=y MCAST=y BATMAN_V=n * sparse linux-3.17 cfg: BLA=y DAT=n DEBUGFS=y DEBUG=y NC=n MCAST=n BATMAN_V=n * sparse linux-3.17 cfg: BLA=y DAT=y DEBUGFS=n DEBUG=n NC=y MCAST=n BATMAN_V=y * sparse linux-3.18 cfg: BLA=n DAT=y DEBUGFS=n DEBUG=n NC=y MCAST=y BATMAN_V=y * sparse linux-3.18 cfg: BLA=y DAT=y DEBUGFS=y DEBUG=y NC=n MCAST=y BATMAN_V=y * sparse linux-3.19 cfg: BLA=n DAT=n DEBUGFS=y DEBUG=y NC=n MCAST=n BATMAN_V=y * sparse linux-3.19 cfg: BLA=n DAT=n DEBUGFS=y DEBUG=y NC=y MCAST=n BATMAN_V=n * sparse linux-3.19 cfg: BLA=n DAT=y DEBUGFS=y DEBUG=n NC=y MCAST=n BATMAN_V=n * sparse linux-3.19 cfg: BLA=n DAT=y DEBUGFS=y DEBUG=y NC=n MCAST=y BATMAN_V=n * sparse linux-3.19 cfg: BLA=y DAT=n DEBUGFS=y DEBUG=n NC=n MCAST=n BATMAN_V=n * sparse linux-3.19 cfg: BLA=y DAT=n DEBUGFS=y DEBUG=y NC=y MCAST=n BATMAN_V=n * sparse linux-3.19 cfg: BLA=y DAT=y DEBUGFS=y DEBUG=y NC=n MCAST=y BATMAN_V=y * sparse linux-3.2 cfg: BLA=y DAT=y DEBUGFS=n DEBUG=n NC=y MCAST=n BATMAN_V=n * sparse linux-3.2 cfg: BLA=y DAT=y DEBUGFS=y DEBUG=y NC=y MCAST=y BATMAN_V=n * sparse linux-3.3 cfg: BLA=n DAT=n DEBUGFS=n DEBUG=n NC=n MCAST=y BATMAN_V=n * sparse linux-3.4 cfg: BLA=n DAT=y DEBUGFS=y DEBUG=n NC=y MCAST=y BATMAN_V=n * sparse linux-3.4 cfg: BLA=y DAT=n DEBUGFS=y DEBUG=y NC=n MCAST=y BATMAN_V=n * sparse linux-3.5 cfg: BLA=n DAT=n DEBUGFS=n DEBUG=n NC=n MCAST=y BATMAN_V=n * sparse linux-3.5 cfg: BLA=n DAT=n DEBUGFS=n DEBUG=n NC=y MCAST=y BATMAN_V=n * sparse linux-3.5 cfg: BLA=n DAT=n DEBUGFS=y DEBUG=y NC=n MCAST=y BATMAN_V=n * sparse linux-3.6 cfg: BLA=y DAT=n DEBUGFS=n DEBUG=n NC=n MCAST=y BATMAN_V=n * sparse linux-3.6 cfg: BLA=y DAT=y DEBUGFS=y DEBUG=y NC=n MCAST=n BATMAN_V=n * sparse linux-3.7 cfg: BLA=y DAT=y DEBUGFS=n DEBUG=n NC=n MCAST=y BATMAN_V=n * sparse linux-3.8 cfg: BLA=n DAT=n DEBUGFS=y DEBUG=y NC=n MCAST=n BATMAN_V=n * sparse linux-3.8 cfg: BLA=n DAT=y DEBUGFS=y DEBUG=y NC=n MCAST=n BATMAN_V=n * sparse linux-3.8 cfg: BLA=n DAT=y DEBUGFS=y DEBUG=y NC=y MCAST=y BATMAN_V=n * sparse linux-3.9 cfg: BLA=n DAT=n DEBUGFS=y DEBUG=y NC=y MCAST=n BATMAN_V=n * sparse linux-3.9 cfg: BLA=y DAT=n DEBUGFS=y DEBUG=y NC=n MCAST=n BATMAN_V=n * sparse linux-3.9 cfg: BLA=y DAT=y DEBUGFS=n DEBUG=n NC=n MCAST=n BATMAN_V=n * sparse linux-4.0 cfg: BLA=n DAT=n DEBUGFS=y DEBUG=y NC=n MCAST=n BATMAN_V=n * sparse linux-4.0 cfg: BLA=n DAT=n DEBUGFS=y DEBUG=y NC=n MCAST=y BATMAN_V=y * sparse linux-4.0 cfg: BLA=n DAT=n DEBUGFS=y DEBUG=y NC=y MCAST=y BATMAN_V=n * sparse linux-4.0 cfg: BLA=n DAT=y DEBUGFS=y DEBUG=y NC=n MCAST=n BATMAN_V=n * sparse linux-4.0 cfg: BLA=y DAT=n DEBUGFS=n DEBUG=n NC=n MCAST=n BATMAN_V=n * sparse linux-4.0 cfg: BLA=y DAT=n DEBUGFS=y DEBUG=n NC=y MCAST=y BATMAN_V=y * sparse linux-4.1 cfg: BLA=n DAT=n DEBUGFS=n DEBUG=n NC=n MCAST=y BATMAN_V=n * sparse linux-4.1 cfg: BLA=n DAT=y DEBUGFS=y DEBUG=y NC=n MCAST=n BATMAN_V=y * sparse linux-4.1 cfg: BLA=y DAT=n DEBUGFS=y DEBUG=n NC=y MCAST=y BATMAN_V=y * sparse linux-4.1 cfg: BLA=y DAT=n DEBUGFS=y DEBUG=y NC=n MCAST=y BATMAN_V=y * sparse linux-4.2 cfg: BLA=n DAT=y DEBUGFS=y DEBUG=n NC=y MCAST=n BATMAN_V=y * sparse linux-4.2 cfg: BLA=n DAT=y DEBUGFS=y DEBUG=n NC=y MCAST=y BATMAN_V=n * sparse linux-4.2 cfg: BLA=n DAT=y DEBUGFS=y DEBUG=y NC=n MCAST=y BATMAN_V=n * sparse linux-4.2 cfg: BLA=y DAT=n DEBUGFS=n DEBUG=n NC=n MCAST=y BATMAN_V=y * sparse linux-4.2 cfg: BLA=y DAT=n DEBUGFS=y DEBUG=y NC=y MCAST=n BATMAN_V=y * sparse linux-4.2 cfg: BLA=y DAT=y DEBUGFS=y DEBUG=y NC=y MCAST=y BATMAN_V=n * sparse linux-4.3 cfg: BLA=n DAT=n DEBUGFS=y DEBUG=n NC=n MCAST=y BATMAN_V=n * sparse linux-4.4 cfg: BLA=n DAT=y DEBUGFS=y DEBUG=y NC=n MCAST=n BATMAN_V=y * sparse linux-4.4 cfg: BLA=y DAT=n DEBUGFS=n DEBUG=n NC=y MCAST=n BATMAN_V=y * sparse linux-4.4 cfg: BLA=y DAT=y DEBUGFS=y DEBUG=y NC=n MCAST=n BATMAN_V=n * sparse linux-4.5 cfg: BLA=n DAT=n DEBUGFS=n DEBUG=n NC=n MCAST=n BATMAN_V=n * sparse linux-4.5 cfg: BLA=n DAT=y DEBUGFS=y DEBUG=y NC=n MCAST=n BATMAN_V=n * sparse linux-4.5 cfg: BLA=n DAT=y DEBUGFS=y DEBUG=y NC=n MCAST=n BATMAN_V=n * sparse linux-4.5 cfg: BLA=n DAT=y DEBUGFS=y DEBUG=y NC=y MCAST=y BATMAN_V=y * sparse linux-4.5 cfg: BLA=y DAT=n DEBUGFS=n DEBUG=n NC=y MCAST=y BATMAN_V=y * sparse linux-4.5 cfg: BLA=y DAT=n DEBUGFS=y DEBUG=y NC=y MCAST=y BATMAN_V=n * sparse linux-4.6 cfg: BLA=n DAT=n DEBUGFS=y DEBUG=n NC=n MCAST=n BATMAN_V=y * sparse linux-4.6 cfg: BLA=n DAT=n DEBUGFS=y DEBUG=y NC=n MCAST=n BATMAN_V=y * sparse linux-4.6 cfg: BLA=n DAT=n DEBUGFS=y DEBUG=y NC=y MCAST=y BATMAN_V=n * sparse linux-4.6 cfg: BLA=n DAT=y DEBUGFS=y DEBUG=y NC=n MCAST=n BATMAN_V=y * sparse linux-4.6 cfg: BLA=y DAT=n DEBUGFS=y DEBUG=n NC=y MCAST=n BATMAN_V=n * sparse linux-4.7 cfg: BLA=n DAT=n DEBUGFS=y DEBUG=y NC=n MCAST=y BATMAN_V=n * sparse linux-4.7 cfg: BLA=n DAT=y DEBUGFS=y DEBUG=n NC=y MCAST=n BATMAN_V=y * sparse linux-4.7 cfg: BLA=n DAT=y DEBUGFS=y DEBUG=y NC=n MCAST=y BATMAN_V=n * sparse linux-4.7 cfg: BLA=n DAT=y DEBUGFS=y DEBUG=y NC=y MCAST=y BATMAN_V=n * sparse linux-4.7 cfg: BLA=y DAT=n DEBUGFS=y DEBUG=n NC=y MCAST=y BATMAN_V=y * sparse linux-4.7 cfg: BLA=y DAT=n DEBUGFS=y DEBUG=y NC=y MCAST=y BATMAN_V=n * sparse linux-4.7 cfg: BLA=y DAT=y DEBUGFS=n DEBUG=n NC=n MCAST=n BATMAN_V=n * sparse linux-4.7 cfg: BLA=y DAT=y DEBUGFS=y DEBUG=y NC=y MCAST=y BATMAN_V=n * sparse linux-4.8 cfg: BLA=n DAT=n DEBUGFS=y DEBUG=y NC=y MCAST=n BATMAN_V=n * sparse linux-4.8 cfg: BLA=n DAT=y DEBUGFS=y DEBUG=n NC=y MCAST=y BATMAN_V=n * sparse linux-4.8 cfg: BLA=n DAT=y DEBUGFS=y DEBUG=n NC=y MCAST=y BATMAN_V=y * sparse linux-4.8 cfg: BLA=n DAT=y DEBUGFS=y DEBUG=y NC=y MCAST=n BATMAN_V=y * sparse linux-4.8 cfg: BLA=y DAT=n DEBUGFS=n DEBUG=n NC=y MCAST=n BATMAN_V=y * sparse linux-4.8 cfg: BLA=y DAT=n DEBUGFS=y DEBUG=y NC=y MCAST=n BATMAN_V=n * sparse linux-4.8 cfg: BLA=y DAT=y DEBUGFS=y DEBUG=n NC=y MCAST=y BATMAN_V=y * unused_symbols linux-3.10 cfg: BLA=n DAT=n DEBUGFS=y DEBUG=n NC=y MCAST=y BATMAN_V=n * unused_symbols linux-3.10 cfg: BLA=n DAT=y DEBUGFS=y DEBUG=n NC=y MCAST=y BATMAN_V=n * unused_symbols linux-3.10 cfg: BLA=y DAT=n DEBUGFS=n DEBUG=n NC=n MCAST=y BATMAN_V=n * unused_symbols linux-3.10 cfg: BLA=y DAT=y DEBUGFS=y DEBUG=n NC=n MCAST=y BATMAN_V=n * unused_symbols linux-3.11 cfg: BLA=n DAT=n DEBUGFS=y DEBUG=n NC=y MCAST=y BATMAN_V=n * unused_symbols linux-3.11 cfg: BLA=n DAT=y DEBUGFS=n DEBUG=n NC=n MCAST=n BATMAN_V=n * unused_symbols linux-3.11 cfg: BLA=y DAT=y DEBUGFS=n DEBUG=n NC=y MCAST=n BATMAN_V=n * unused_symbols linux-3.11 cfg: BLA=y DAT=y DEBUGFS=y DEBUG=n NC=y MCAST=n BATMAN_V=n * unused_symbols linux-3.12 cfg: BLA=y DAT=y DEBUGFS=y DEBUG=y NC=n MCAST=n BATMAN_V=n * unused_symbols linux-3.13 cfg: BLA=n DAT=y DEBUGFS=y DEBUG=y NC=y MCAST=n BATMAN_V=n * unused_symbols linux-3.13 cfg: BLA=y DAT=n DEBUGFS=y DEBUG=y NC=n MCAST=n BATMAN_V=n * unused_symbols linux-3.15 cfg: BLA=n DAT=y DEBUGFS=y DEBUG=y NC=n MCAST=y BATMAN_V=n * unused_symbols linux-3.15 cfg: BLA=y DAT=n DEBUGFS=n DEBUG=n NC=n MCAST=y BATMAN_V=n * unused_symbols linux-3.15 cfg: BLA=y DAT=n DEBUGFS=y DEBUG=y NC=n MCAST=n BATMAN_V=n * unused_symbols linux-3.16 cfg: BLA=n DAT=n DEBUGFS=y DEBUG=n NC=n MCAST=n BATMAN_V=n * unused_symbols linux-3.16 cfg: BLA=n DAT=y DEBUGFS=n DEBUG=n NC=n MCAST=y BATMAN_V=n * unused_symbols linux-3.16 cfg: BLA=n DAT=y DEBUGFS=y DEBUG=y NC=n MCAST=y BATMAN_V=y * unused_symbols linux-3.16 cfg: BLA=y DAT=n DEBUGFS=y DEBUG=n NC=y MCAST=y BATMAN_V=n * unused_symbols linux-3.16 cfg: BLA=y DAT=y DEBUGFS=n DEBUG=n NC=n MCAST=y BATMAN_V=n * unused_symbols linux-3.17 cfg: BLA=n DAT=n DEBUGFS=y DEBUG=y NC=y MCAST=n BATMAN_V=n * unused_symbols linux-3.17 cfg: BLA=n DAT=y DEBUGFS=n DEBUG=n NC=y MCAST=n BATMAN_V=y * unused_symbols linux-3.17 cfg: BLA=n DAT=y DEBUGFS=y DEBUG=y NC=y MCAST=n BATMAN_V=y * unused_symbols linux-3.17 cfg: BLA=n DAT=y DEBUGFS=y DEBUG=y NC=y MCAST=y BATMAN_V=n * unused_symbols linux-3.17 cfg: BLA=y DAT=n DEBUGFS=y DEBUG=y NC=n MCAST=n BATMAN_V=n * unused_symbols linux-3.17 cfg: BLA=y DAT=y DEBUGFS=n DEBUG=n NC=y MCAST=n BATMAN_V=y * unused_symbols linux-3.18 cfg: BLA=n DAT=y DEBUGFS=n DEBUG=n NC=y MCAST=y BATMAN_V=y * unused_symbols linux-3.18 cfg: BLA=y DAT=y DEBUGFS=y DEBUG=y NC=n MCAST=y BATMAN_V=y * unused_symbols linux-3.19 cfg: BLA=n DAT=n DEBUGFS=y DEBUG=y NC=n MCAST=n BATMAN_V=y * unused_symbols linux-3.19 cfg: BLA=n DAT=n DEBUGFS=y DEBUG=y NC=y MCAST=n BATMAN_V=n * unused_symbols linux-3.19 cfg: BLA=n DAT=y DEBUGFS=y DEBUG=n NC=y MCAST=n BATMAN_V=n * unused_symbols linux-3.19 cfg: BLA=n DAT=y DEBUGFS=y DEBUG=y NC=n MCAST=y BATMAN_V=n * unused_symbols linux-3.19 cfg: BLA=y DAT=n DEBUGFS=y DEBUG=n NC=n MCAST=n BATMAN_V=n * unused_symbols linux-3.19 cfg: BLA=y DAT=n DEBUGFS=y DEBUG=y NC=y MCAST=n BATMAN_V=n * unused_symbols linux-3.19 cfg: BLA=y DAT=y DEBUGFS=y DEBUG=y NC=n MCAST=y BATMAN_V=y * unused_symbols linux-3.2 cfg: BLA=y DAT=y DEBUGFS=n DEBUG=n NC=y MCAST=n BATMAN_V=n * unused_symbols linux-3.2 cfg: BLA=y DAT=y DEBUGFS=y DEBUG=y NC=y MCAST=y BATMAN_V=n * unused_symbols linux-3.3 cfg: BLA=n DAT=n DEBUGFS=n DEBUG=n NC=n MCAST=y BATMAN_V=n * unused_symbols linux-3.4 cfg: BLA=n DAT=y DEBUGFS=y DEBUG=n NC=y MCAST=y BATMAN_V=n * unused_symbols linux-3.4 cfg: BLA=y DAT=n DEBUGFS=y DEBUG=y NC=n MCAST=y BATMAN_V=n * unused_symbols linux-3.5 cfg: BLA=n DAT=n DEBUGFS=n DEBUG=n NC=n MCAST=y BATMAN_V=n * unused_symbols linux-3.5 cfg: BLA=n DAT=n DEBUGFS=n DEBUG=n NC=y MCAST=y BATMAN_V=n * unused_symbols linux-3.5 cfg: BLA=n DAT=n DEBUGFS=y DEBUG=y NC=n MCAST=y BATMAN_V=n * unused_symbols linux-3.6 cfg: BLA=y DAT=n DEBUGFS=n DEBUG=n NC=n MCAST=y BATMAN_V=n * unused_symbols linux-3.6 cfg: BLA=y DAT=y DEBUGFS=y DEBUG=y NC=n MCAST=n BATMAN_V=n * unused_symbols linux-3.7 cfg: BLA=y DAT=y DEBUGFS=n DEBUG=n NC=n MCAST=y BATMAN_V=n * unused_symbols linux-3.8 cfg: BLA=n DAT=n DEBUGFS=y DEBUG=y NC=n MCAST=n BATMAN_V=n * unused_symbols linux-3.8 cfg: BLA=n DAT=y DEBUGFS=y DEBUG=y NC=n MCAST=n BATMAN_V=n * unused_symbols linux-3.8 cfg: BLA=n DAT=y DEBUGFS=y DEBUG=y NC=y MCAST=y BATMAN_V=n * unused_symbols linux-3.9 cfg: BLA=n DAT=n DEBUGFS=y DEBUG=y NC=y MCAST=n BATMAN_V=n * unused_symbols linux-3.9 cfg: BLA=y DAT=n DEBUGFS=y DEBUG=y NC=n MCAST=n BATMAN_V=n * unused_symbols linux-3.9 cfg: BLA=y DAT=y DEBUGFS=n DEBUG=n NC=n MCAST=n BATMAN_V=n * unused_symbols linux-4.0 cfg: BLA=n DAT=n DEBUGFS=y DEBUG=y NC=n MCAST=n BATMAN_V=n * unused_symbols linux-4.0 cfg: BLA=n DAT=n DEBUGFS=y DEBUG=y NC=y MCAST=y BATMAN_V=n * unused_symbols linux-4.0 cfg: BLA=n DAT=y DEBUGFS=y DEBUG=y NC=n MCAST=n BATMAN_V=n * unused_symbols linux-4.0 cfg: BLA=y DAT=n DEBUGFS=n DEBUG=n NC=n MCAST=n BATMAN_V=n * unused_symbols linux-4.1 cfg: BLA=n DAT=n DEBUGFS=n DEBUG=n NC=n MCAST=y BATMAN_V=n * unused_symbols linux-4.2 cfg: BLA=n DAT=y DEBUGFS=y DEBUG=n NC=y MCAST=y BATMAN_V=n * unused_symbols linux-4.2 cfg: BLA=n DAT=y DEBUGFS=y DEBUG=y NC=n MCAST=y BATMAN_V=n * unused_symbols linux-4.2 cfg: BLA=y DAT=y DEBUGFS=y DEBUG=y NC=y MCAST=y BATMAN_V=n * unused_symbols linux-4.3 cfg: BLA=n DAT=n DEBUGFS=y DEBUG=n NC=n MCAST=y BATMAN_V=n * unused_symbols linux-4.4 cfg: BLA=y DAT=y DEBUGFS=y DEBUG=y NC=n MCAST=n BATMAN_V=n * unused_symbols linux-4.5 cfg: BLA=n DAT=n DEBUGFS=n DEBUG=n NC=n MCAST=n BATMAN_V=n * unused_symbols linux-4.5 cfg: BLA=n DAT=y DEBUGFS=y DEBUG=y NC=n MCAST=n BATMAN_V=n * unused_symbols linux-4.5 cfg: BLA=n DAT=y DEBUGFS=y DEBUG=y NC=n MCAST=n BATMAN_V=n * unused_symbols linux-4.5 cfg: BLA=y DAT=n DEBUGFS=y DEBUG=y NC=y MCAST=y BATMAN_V=n * unused_symbols linux-4.6 cfg: BLA=n DAT=n DEBUGFS=y DEBUG=y NC=y MCAST=y BATMAN_V=n * unused_symbols linux-4.6 cfg: BLA=y DAT=n DEBUGFS=y DEBUG=n NC=y MCAST=n BATMAN_V=n * unused_symbols linux-4.7 cfg: BLA=n DAT=n DEBUGFS=y DEBUG=y NC=n MCAST=y BATMAN_V=n * unused_symbols linux-4.7 cfg: BLA=n DAT=y DEBUGFS=y DEBUG=y NC=n MCAST=y BATMAN_V=n * unused_symbols linux-4.7 cfg: BLA=n DAT=y DEBUGFS=y DEBUG=y NC=y MCAST=y BATMAN_V=n * unused_symbols linux-4.7 cfg: BLA=y DAT=n DEBUGFS=y DEBUG=y NC=y MCAST=y BATMAN_V=n * unused_symbols linux-4.7 cfg: BLA=y DAT=y DEBUGFS=n DEBUG=n NC=n MCAST=n BATMAN_V=n * unused_symbols linux-4.7 cfg: BLA=y DAT=y DEBUGFS=y DEBUG=y NC=y MCAST=y BATMAN_V=n * unused_symbols linux-4.8 cfg: BLA=n DAT=n DEBUGFS=y DEBUG=y NC=y MCAST=n BATMAN_V=n * unused_symbols linux-4.8 cfg: BLA=n DAT=y DEBUGFS=y DEBUG=n NC=y MCAST=y BATMAN_V=n * unused_symbols linux-4.8 cfg: BLA=y DAT=n DEBUGFS=y DEBUG=y NC=y MCAST=n BATMAN_V=n next ---- * checkpatch ./net/batman-adv/debugfs.c * checkpatch ./net/batman-adv/icmp_socket.c * checkpatch ./net/batman-adv/log.c * checkpatch ./net/batman-adv/network-coding.c * checkpatch ./net/batman-adv/sysfs.c * difference between net-next and batadv next Output of different failed tests ================================ next: checkpatch ./net/batman-adv/debugfs.c ------------------------------------------- WARNING: Symbolic permissions 'S_IRUGO' are not preferred. Consider using octal permissions '0444'. #189: FILE: ./net/batman-adv/debugfs.c:189: +static BATADV_DEBUGINFO(routing_algos, S_IRUGO, batadv_algorithms_open); WARNING: Symbolic permissions 'S_IRUGO' are not preferred. Consider using octal permissions '0444'. #197: FILE: ./net/batman-adv/debugfs.c:197: +static BATADV_DEBUGINFO(neighbors, S_IRUGO, neighbors_open); WARNING: Symbolic permissions 'S_IRUGO' are not preferred. Consider using octal permissions '0444'. #198: FILE: ./net/batman-adv/debugfs.c:198: +static BATADV_DEBUGINFO(originators, S_IRUGO, batadv_originators_open); WARNING: Symbolic permissions 'S_IRUGO' are not preferred. Consider using octal permissions '0444'. #199: FILE: ./net/batman-adv/debugfs.c:199: +static BATADV_DEBUGINFO(gateways, S_IRUGO, batadv_gateways_open); WARNING: Symbolic permissions 'S_IRUGO' are not preferred. Consider using octal permissions '0444'. #200: FILE: ./net/batman-adv/debugfs.c:200: +static BATADV_DEBUGINFO(transtable_global, S_IRUGO, WARNING: Symbolic permissions 'S_IRUGO' are not preferred. Consider using octal permissions '0444'. #203: FILE: ./net/batman-adv/debugfs.c:203: +static BATADV_DEBUGINFO(bla_claim_table, S_IRUGO, batadv_bla_claim_table_open); WARNING: Symbolic permissions 'S_IRUGO' are not preferred. Consider using octal permissions '0444'. #204: FILE: ./net/batman-adv/debugfs.c:204: +static BATADV_DEBUGINFO(bla_backbone_table, S_IRUGO, WARNING: Symbolic permissions 'S_IRUGO' are not preferred. Consider using octal permissions '0444'. #208: FILE: ./net/batman-adv/debugfs.c:208: +static BATADV_DEBUGINFO(dat_cache, S_IRUGO, batadv_dat_cache_open); WARNING: Symbolic permissions 'S_IRUGO' are not preferred. Consider using octal permissions '0444'. #210: FILE: ./net/batman-adv/debugfs.c:210: +static BATADV_DEBUGINFO(transtable_local, S_IRUGO, WARNING: Symbolic permissions 'S_IRUGO' are not preferred. Consider using octal permissions '0444'. #213: FILE: ./net/batman-adv/debugfs.c:213: +static BATADV_DEBUGINFO(nc_nodes, S_IRUGO, batadv_nc_nodes_open); WARNING: Symbolic permissions 'S_IRUGO' are not preferred. Consider using octal permissions '0444'. #216: FILE: ./net/batman-adv/debugfs.c:216: +static BATADV_DEBUGINFO(mcast_flags, S_IRUGO, batadv_mcast_flags_open); WARNING: Symbolic permissions 'S_IRUGO' are not preferred. Consider using octal permissions '0444'. #256: FILE: ./net/batman-adv/debugfs.c:256: +static BATADV_HARDIF_DEBUGINFO(originators, S_IRUGO, total: 0 errors, 12 warnings, 0 checks, 420 lines checked next: checkpatch ./net/batman-adv/icmp_socket.c ----------------------------------------------- WARNING: Symbolic permissions 'S_IWUSR | S_IRUSR' are not preferred. Consider using octal permissions '0600'. #325: FILE: ./net/batman-adv/icmp_socket.c:325: + d = debugfs_create_file(BATADV_ICMP_SOCKET, S_IFREG | S_IWUSR | S_IRUSR, total: 0 errors, 1 warnings, 0 checks, 407 lines checked next: checkpatch ./net/batman-adv/log.c --------------------------------------- WARNING: Symbolic permissions 'S_IRUSR' are not preferred. Consider using octal permissions '0400'. #215: FILE: ./net/batman-adv/log.c:215: + d = debugfs_create_file("log", S_IFREG | S_IRUSR, total: 0 errors, 1 warnings, 0 checks, 231 lines checked next: checkpatch ./net/batman-adv/network-coding.c -------------------------------------------------- WARNING: Symbolic permissions 'S_IRUGO | S_IWUSR' are not preferred. Consider using octal permissions '0644'. #1964: FILE: ./net/batman-adv/network-coding.c:1964: + file = debugfs_create_u8("min_tq", S_IRUGO | S_IWUSR, nc_dir, WARNING: Symbolic permissions 'S_IRUGO | S_IWUSR' are not preferred. Consider using octal permissions '0644'. #1969: FILE: ./net/batman-adv/network-coding.c:1969: + file = debugfs_create_u32("max_fwd_delay", S_IRUGO | S_IWUSR, nc_dir, WARNING: Symbolic permissions 'S_IRUGO | S_IWUSR' are not preferred. Consider using octal permissions '0644'. #1974: FILE: ./net/batman-adv/network-coding.c:1974: + file = debugfs_create_u32("max_buffer_time", S_IRUGO | S_IWUSR, nc_dir, total: 0 errors, 3 warnings, 0 checks, 1984 lines checked next: checkpatch ./net/batman-adv/sysfs.c ----------------------------------------- WARNING: Symbolic permissions 'S_IRUGO | S_IWUSR' are not preferred. Consider using octal permissions '0644'. #669: FILE: ./net/batman-adv/sysfs.c:669: +BATADV_ATTR_SIF_BOOL(aggregated_ogms, S_IRUGO | S_IWUSR, NULL); WARNING: Symbolic permissions 'S_IRUGO | S_IWUSR' are not preferred. Consider using octal permissions '0644'. #670: FILE: ./net/batman-adv/sysfs.c:670: +BATADV_ATTR_SIF_BOOL(bonding, S_IRUGO | S_IWUSR, NULL); WARNING: Symbolic permissions 'S_IRUGO | S_IWUSR' are not preferred. Consider using octal permissions '0644'. #672: FILE: ./net/batman-adv/sysfs.c:672: +BATADV_ATTR_SIF_BOOL(bridge_loop_avoidance, S_IRUGO | S_IWUSR, WARNING: Symbolic permissions 'S_IRUGO | S_IWUSR' are not preferred. Consider using octal permissions '0644'. #676: FILE: ./net/batman-adv/sysfs.c:676: +BATADV_ATTR_SIF_BOOL(distributed_arp_table, S_IRUGO | S_IWUSR, WARNING: Symbolic permissions 'S_IRUGO | S_IWUSR' are not preferred. Consider using octal permissions '0644'. #679: FILE: ./net/batman-adv/sysfs.c:679: +BATADV_ATTR_SIF_BOOL(fragmentation, S_IRUGO | S_IWUSR, batadv_update_min_mtu); WARNING: Symbolic permissions 'S_IRUGO' are not preferred. Consider using octal permissions '0444'. #680: FILE: ./net/batman-adv/sysfs.c:680: +static BATADV_ATTR(routing_algo, S_IRUGO, batadv_show_bat_algo, NULL); WARNING: Symbolic permissions 'S_IRUGO | S_IWUSR' are not preferred. Consider using octal permissions '0644'. #681: FILE: ./net/batman-adv/sysfs.c:681: +static BATADV_ATTR(gw_mode, S_IRUGO | S_IWUSR, batadv_show_gw_mode, WARNING: Symbolic permissions 'S_IRUGO | S_IWUSR' are not preferred. Consider using octal permissions '0644'. #683: FILE: ./net/batman-adv/sysfs.c:683: +BATADV_ATTR_SIF_UINT(orig_interval, orig_interval, S_IRUGO | S_IWUSR, WARNING: Symbolic permissions 'S_IRUGO | S_IWUSR' are not preferred. Consider using octal permissions '0644'. #685: FILE: ./net/batman-adv/sysfs.c:685: +BATADV_ATTR_SIF_UINT(hop_penalty, hop_penalty, S_IRUGO | S_IWUSR, 0, WARNING: Symbolic permissions 'S_IRUGO | S_IWUSR' are not preferred. Consider using octal permissions '0644'. #687: FILE: ./net/batman-adv/sysfs.c:687: +static BATADV_ATTR(gw_sel_class, S_IRUGO | S_IWUSR, batadv_show_gw_sel_class, WARNING: Symbolic permissions 'S_IRUGO | S_IWUSR' are not preferred. Consider using octal permissions '0644'. #689: FILE: ./net/batman-adv/sysfs.c:689: +static BATADV_ATTR(gw_bandwidth, S_IRUGO | S_IWUSR, batadv_show_gw_bwidth, WARNING: Symbolic permissions 'S_IRUGO | S_IWUSR' are not preferred. Consider using octal permissions '0644'. #692: FILE: ./net/batman-adv/sysfs.c:692: +BATADV_ATTR_SIF_BOOL(multicast_mode, S_IRUGO | S_IWUSR, NULL); WARNING: Symbolic permissions 'S_IRUGO | S_IWUSR' are not preferred. Consider using octal permissions '0644'. #695: FILE: ./net/batman-adv/sysfs.c:695: +BATADV_ATTR_SIF_UINT(log_level, log_level, S_IRUGO | S_IWUSR, 0, WARNING: Symbolic permissions 'S_IRUGO | S_IWUSR' are not preferred. Consider using octal permissions '0644'. #699: FILE: ./net/batman-adv/sysfs.c:699: +BATADV_ATTR_SIF_BOOL(network_coding, S_IRUGO | S_IWUSR, WARNING: Symbolic permissions 'S_IRUGO | S_IWUSR' are not preferred. Consider using octal permissions '0644'. #702: FILE: ./net/batman-adv/sysfs.c:702: +static BATADV_ATTR(isolation_mark, S_IRUGO | S_IWUSR, WARNING: Symbolic permissions 'S_IRUGO | S_IWUSR' are not preferred. Consider using octal permissions '0644'. #734: FILE: ./net/batman-adv/sysfs.c:734: +BATADV_ATTR_VLAN_BOOL(ap_isolation, S_IRUGO | S_IWUSR, NULL); WARNING: Symbolic permissions 'S_IRUGO | S_IWUSR' are not preferred. Consider using octal permissions '0644'. #1119: FILE: ./net/batman-adv/sysfs.c:1119: +static BATADV_ATTR(mesh_iface, S_IRUGO | S_IWUSR, batadv_show_mesh_iface, WARNING: Symbolic permissions 'S_IRUGO' are not preferred. Consider using octal permissions '0444'. #1121: FILE: ./net/batman-adv/sysfs.c:1121: +static BATADV_ATTR(iface_status, S_IRUGO, batadv_show_iface_status, NULL); WARNING: Symbolic permissions 'S_IRUGO | S_IWUSR' are not preferred. Consider using octal permissions '0644'. #1123: FILE: ./net/batman-adv/sysfs.c:1123: +BATADV_ATTR_HIF_UINT(elp_interval, bat_v.elp_interval, S_IRUGO | S_IWUSR, WARNING: Symbolic permissions 'S_IRUGO | S_IWUSR' are not preferred. Consider using octal permissions '0644'. #1125: FILE: ./net/batman-adv/sysfs.c:1125: +static BATADV_ATTR(throughput_override, S_IRUGO | S_IWUSR, total: 0 errors, 20 warnings, 0 checks, 1224 lines checked master: cppcheck ---------------- [net/batman-adv/hard-interface.c:258] -> [net/batman-adv/hard-interface.c:261]: (style) Variable 'real_netdev' is reassigned a value before the old one has been used. next: difference between net-next and batadv next ------------------------------------------------- netnext/net/batman-adv/hard-interface.c | 1 + netnext/net/batman-adv/log.h | 2 +- netnext/net/batman-adv/originator.c | 2 +- netnext/net/batman-adv/soft-interface.c | 13 +------------ 4 files changed, 4 insertions(+), 14 deletions(-) master: sparse linux-3.13 cfg: BLA=y DAT=n DEBUGFS=y DEBUG=y NC=n MCAST=n BATMAN_V=n --------------------------------------------------------------------------- init_defs_builtins: /usr/lib/coccinelle/standard.h 6 files match HANDLING: /home/build_test/build_env/tmp.PxRYrAyIRt/build/net/batman-adv/netlink.c diff = HANDLING: /home/build_test/build_env/tmp.PxRYrAyIRt/build/net/batman-adv/bat_v.c diff = HANDLING: /home/build_test/build_env/tmp.PxRYrAyIRt/build/net/batman-adv/bridge_loop_avoidance.c diff = HANDLING: /home/build_test/build_env/tmp.PxRYrAyIRt/build/net/batman-adv/bat_algo.c diff = HANDLING: /home/build_test/build_env/tmp.PxRYrAyIRt/build/net/batman-adv/translation-table.c diff = HANDLING: /home/build_test/build_env/tmp.PxRYrAyIRt/build/net/batman-adv/bat_iv_ogm.c diff = init_defs_builtins: /usr/lib/coccinelle/standard.h 1 files match HANDLING: /home/build_test/build_env/tmp.PxRYrAyIRt/build/net/batman-adv/netlink.c diff = init_defs_builtins: /usr/lib/coccinelle/standard.h 1 files match HANDLING: /home/build_test/build_env/tmp.PxRYrAyIRt/build/net/batman-adv/soft-interface.c diff = init_defs_builtins: /usr/lib/coccinelle/standard.h 1 files match HANDLING: /home/build_test/build_env/tmp.PxRYrAyIRt/build/net/batman-adv/hard-interface.c init_defs_builtins: /usr/lib/coccinelle/standard.h 1 files match HANDLING: /home/build_test/build_env/tmp.PxRYrAyIRt/build/net/batman-adv/soft-interface.c diff = /home/build_test/build_env/tmp.PxRYrAyIRt/build/net/batman-adv/hard-interface.c:101:35: error: no member 'get_link_net' in struct rtnl_link_ops /home/build_test/build_env/tmp.PxRYrAyIRt/build/net/batman-adv/hard-interface.c:104:37: error: no member 'get_link_net' in struct rtnl_link_ops /home/build_test/build_env/tmp.PxRYrAyIRt/build/net/batman-adv/hard-interface.c:104:30: error: 'const struct rtnl_link_ops' has no member named 'get_link_net' return netdev->rtnl_link_ops->get_link_net(netdev); ^ /home/build_test/build_env/tmp.PxRYrAyIRt/build/net/batman-adv/hard-interface.c:105:1: warning: control reaches end of non-void function [-Wreturn-type] } ^ make[3]: *** [/home/build_test/build_env/tmp.PxRYrAyIRt/build/net/batman-adv/hard-interface.o] Error 1 make[2]: *** [/home/build_test/build_env/tmp.PxRYrAyIRt/build/net/batman-adv] Error 2 make[1]: *** [_module_/home/build_test/build_env/tmp.PxRYrAyIRt] Error 2 make: *** [all] Error 2 master: sparse linux-4.2 cfg: BLA=n DAT=y DEBUGFS=y DEBUG=y NC=n MCAST=y BATMAN_V=n --------------------------------------------------------------------------- init_defs_builtins: /usr/lib/coccinelle/standard.h 6 files match HANDLING: /home/build_test/build_env/tmp.PxRYrAyIRt/build/net/batman-adv/netlink.c diff = HANDLING: /home/build_test/build_env/tmp.PxRYrAyIRt/build/net/batman-adv/bat_v.c diff = HANDLING: /home/build_test/build_env/tmp.PxRYrAyIRt/build/net/batman-adv/bridge_loop_avoidance.c diff = HANDLING: /home/build_test/build_env/tmp.PxRYrAyIRt/build/net/batman-adv/bat_algo.c diff = HANDLING: /home/build_test/build_env/tmp.PxRYrAyIRt/build/net/batman-adv/translation-table.c diff = HANDLING: /home/build_test/build_env/tmp.PxRYrAyIRt/build/net/batman-adv/bat_iv_ogm.c diff = init_defs_builtins: /usr/lib/coccinelle/standard.h 1 files match HANDLING: /home/build_test/build_env/tmp.PxRYrAyIRt/build/net/batman-adv/netlink.c diff = init_defs_builtins: /usr/lib/coccinelle/standard.h 1 files match HANDLING: /home/build_test/build_env/tmp.PxRYrAyIRt/build/net/batman-adv/soft-interface.c diff = init_defs_builtins: /usr/lib/coccinelle/standard.h 1 files match HANDLING: /home/build_test/build_env/tmp.PxRYrAyIRt/build/net/batman-adv/hard-interface.c init_defs_builtins: /usr/lib/coccinelle/standard.h 1 files match HANDLING: /home/build_test/build_env/tmp.PxRYrAyIRt/build/net/batman-adv/soft-interface.c diff = master: unused_symbols linux-3.10 cfg: BLA=y DAT=y DEBUGFS=y DEBUG=n NC=n MCAST=y BATMAN_V=n --------------------------------------------------------------------------- batadv_algo_dump batadv_algo_init batadv_algo_select batadv_bla_backbone_dump batadv_bla_check_bcast_duplist batadv_bla_claim_dump batadv_bla_free batadv_bla_init batadv_bla_is_backbone_gw batadv_bla_is_backbone_gw_orig batadv_bla_rx batadv_bla_status_update batadv_bla_tx batadv_bla_update_orig_address batadv_dat_drop_broadcast_packet batadv_dat_free batadv_dat_init batadv_dat_snoop_incoming_arp_reply batadv_dat_snoop_incoming_arp_request batadv_dat_snoop_outgoing_arp_reply batadv_dat_snoop_outgoing_arp_request batadv_dat_status_update batadv_debugfs_add_hardif batadv_debugfs_add_meshif batadv_debugfs_del_hardif batadv_debugfs_del_meshif batadv_debugfs_destroy batadv_debugfs_init batadv_frag_purge_orig batadv_frag_send_packet batadv_frag_skb_buffer batadv_frag_skb_fwd batadv_gw_bandwidth_set batadv_gw_check_client_stop batadv_gw_dhcp_recipient_get batadv_gw_dump batadv_gw_election batadv_gw_free batadv_gw_get_selected_orig batadv_gw_init batadv_gw_node_delete batadv_gw_node_free batadv_gw_out_of_range batadv_gw_tvlv_container_update batadv_iv_init batadv_routing_algo master: unused_symbols linux-3.11 cfg: BLA=n DAT=y DEBUGFS=n DEBUG=n NC=n MCAST=n BATMAN_V=n --------------------------------------------------------------------------- batadv_algo_dump batadv_algo_init batadv_algo_select batadv_dat_drop_broadcast_packet batadv_dat_free batadv_dat_init batadv_dat_snoop_incoming_arp_reply batadv_dat_snoop_incoming_arp_request batadv_dat_snoop_outgoing_arp_reply batadv_dat_snoop_outgoing_arp_request batadv_dat_status_update batadv_frag_purge_orig batadv_frag_send_packet batadv_frag_skb_buffer batadv_frag_skb_fwd batadv_gw_bandwidth_set batadv_gw_check_client_stop batadv_gw_dhcp_recipient_get batadv_gw_dump batadv_gw_election batadv_gw_free batadv_gw_get_selected_orig batadv_gw_init batadv_gw_node_delete batadv_gw_node_free batadv_gw_out_of_range batadv_gw_tvlv_container_update batadv_iv_init batadv_routing_algo master: unused_symbols linux-3.11 cfg: BLA=y DAT=y DEBUGFS=n DEBUG=n NC=y MCAST=n BATMAN_V=n --------------------------------------------------------------------------- batadv_algo_dump batadv_algo_init batadv_algo_select batadv_bla_backbone_dump batadv_bla_check_bcast_duplist batadv_bla_claim_dump batadv_bla_free batadv_bla_init batadv_bla_is_backbone_gw batadv_bla_is_backbone_gw_orig batadv_bla_rx batadv_bla_status_update batadv_bla_tx batadv_bla_update_orig_address batadv_dat_drop_broadcast_packet batadv_dat_free batadv_dat_init batadv_dat_snoop_incoming_arp_reply batadv_dat_snoop_incoming_arp_request batadv_dat_snoop_outgoing_arp_reply batadv_dat_snoop_outgoing_arp_request batadv_dat_status_update batadv_frag_purge_orig batadv_frag_send_packet batadv_frag_skb_buffer batadv_frag_skb_fwd batadv_gw_bandwidth_set batadv_gw_check_client_stop batadv_gw_dhcp_recipient_get batadv_gw_dump batadv_gw_election batadv_gw_free batadv_gw_get_selected_orig batadv_gw_init batadv_gw_node_delete batadv_gw_node_free batadv_gw_out_of_range batadv_gw_tvlv_container_update batadv_iv_init batadv_routing_algo master: unused_symbols linux-3.13 cfg: BLA=y DAT=n DEBUGFS=y DEBUG=y NC=n MCAST=n BATMAN_V=n --------------------------------------------------------------------------- batadv_algo_dump batadv_algo_init batadv_algo_select batadv_bla_backbone_dump batadv_bla_check_bcast_duplist batadv_bla_claim_dump batadv_bla_free batadv_bla_init batadv_bla_is_backbone_gw batadv_bla_is_backbone_gw_orig batadv_bla_rx batadv_bla_status_update batadv_bla_tx batadv_bla_update_orig_address batadv_debugfs_add_hardif batadv_debugfs_add_meshif batadv_debugfs_del_hardif batadv_debugfs_del_meshif batadv_debugfs_destroy batadv_debugfs_init batadv_frag_purge_orig batadv_frag_send_packet batadv_frag_skb_buffer batadv_frag_skb_fwd batadv_gw_bandwidth_set batadv_gw_check_client_stop batadv_gw_dhcp_recipient_get batadv_gw_dump batadv_gw_election batadv_gw_free batadv_gw_get_selected_orig batadv_gw_init batadv_gw_node_delete batadv_gw_node_free batadv_gw_out_of_range batadv_gw_tvlv_container_update batadv_iv_init batadv_routing_algo master: unused_symbols linux-3.17 cfg: BLA=n DAT=y DEBUGFS=n DEBUG=n NC=y MCAST=n BATMAN_V=y --------------------------------------------------------------------------- batadv_algo_dump batadv_algo_init batadv_algo_select batadv_dat_drop_broadcast_packet batadv_dat_free batadv_dat_init batadv_dat_snoop_incoming_arp_reply batadv_dat_snoop_incoming_arp_request batadv_dat_snoop_outgoing_arp_reply batadv_dat_snoop_outgoing_arp_request batadv_dat_status_update batadv_frag_purge_orig batadv_frag_send_packet batadv_frag_skb_buffer batadv_frag_skb_fwd batadv_gw_bandwidth_set batadv_gw_check_client_stop batadv_gw_dhcp_recipient_get batadv_gw_dump batadv_gw_election batadv_gw_free batadv_gw_get_selected_orig batadv_gw_init batadv_gw_node_delete batadv_gw_node_free batadv_gw_out_of_range batadv_gw_tvlv_container_update batadv_iv_init batadv_routing_algo batadv_v_hardif_init batadv_v_init batadv_v_mesh_free batadv_v_mesh_init master: unused_symbols linux-3.17 cfg: BLA=n DAT=y DEBUGFS=y DEBUG=y NC=y MCAST=n BATMAN_V=y --------------------------------------------------------------------------- batadv_algo_dump batadv_algo_init batadv_algo_select batadv_dat_drop_broadcast_packet batadv_dat_free batadv_dat_init batadv_dat_snoop_incoming_arp_reply batadv_dat_snoop_incoming_arp_request batadv_dat_snoop_outgoing_arp_reply batadv_dat_snoop_outgoing_arp_request batadv_dat_status_update batadv_debugfs_add_hardif batadv_debugfs_add_meshif batadv_debugfs_del_hardif batadv_debugfs_del_meshif batadv_debugfs_destroy batadv_debugfs_init batadv_frag_purge_orig batadv_frag_send_packet batadv_frag_skb_buffer batadv_frag_skb_fwd batadv_gw_bandwidth_set batadv_gw_check_client_stop batadv_gw_dhcp_recipient_get batadv_gw_dump batadv_gw_election batadv_gw_free batadv_gw_get_selected_orig batadv_gw_init batadv_gw_node_delete batadv_gw_node_free batadv_gw_out_of_range batadv_gw_tvlv_container_update batadv_iv_init batadv_routing_algo batadv_v_hardif_init batadv_v_init batadv_v_mesh_free batadv_v_mesh_init master: unused_symbols linux-3.17 cfg: BLA=y DAT=y DEBUGFS=n DEBUG=n NC=y MCAST=n BATMAN_V=y --------------------------------------------------------------------------- batadv_algo_dump batadv_algo_init batadv_algo_select batadv_bla_backbone_dump batadv_bla_check_bcast_duplist batadv_bla_claim_dump batadv_bla_free batadv_bla_init batadv_bla_is_backbone_gw batadv_bla_is_backbone_gw_orig batadv_bla_rx batadv_bla_status_update batadv_bla_tx batadv_bla_update_orig_address batadv_dat_drop_broadcast_packet batadv_dat_free batadv_dat_init batadv_dat_snoop_incoming_arp_reply batadv_dat_snoop_incoming_arp_request batadv_dat_snoop_outgoing_arp_reply batadv_dat_snoop_outgoing_arp_request batadv_dat_status_update batadv_frag_purge_orig batadv_frag_send_packet batadv_frag_skb_buffer batadv_frag_skb_fwd batadv_gw_bandwidth_set batadv_gw_check_client_stop batadv_gw_dhcp_recipient_get batadv_gw_dump batadv_gw_election batadv_gw_free batadv_gw_get_selected_orig batadv_gw_init batadv_gw_node_delete batadv_gw_node_free batadv_gw_out_of_range batadv_gw_tvlv_container_update batadv_iv_init batadv_routing_algo batadv_v_hardif_init batadv_v_init batadv_v_mesh_free batadv_v_mesh_init master: unused_symbols linux-3.19 cfg: BLA=n DAT=n DEBUGFS=y DEBUG=y NC=n MCAST=n BATMAN_V=y --------------------------------------------------------------------------- batadv_algo_dump batadv_algo_init batadv_algo_select batadv_debugfs_add_hardif batadv_debugfs_add_meshif batadv_debugfs_del_hardif batadv_debugfs_del_meshif batadv_debugfs_destroy batadv_debugfs_init batadv_frag_purge_orig batadv_frag_send_packet batadv_frag_skb_buffer batadv_frag_skb_fwd batadv_gw_bandwidth_set batadv_gw_check_client_stop batadv_gw_dhcp_recipient_get batadv_gw_dump batadv_gw_election batadv_gw_free batadv_gw_get_selected_orig batadv_gw_init batadv_gw_node_delete batadv_gw_node_free batadv_gw_out_of_range batadv_gw_tvlv_container_update batadv_iv_init batadv_routing_algo batadv_v_hardif_init batadv_v_init batadv_v_mesh_free batadv_v_mesh_init master: unused_symbols linux-3.19 cfg: BLA=n DAT=n DEBUGFS=y DEBUG=y NC=y MCAST=n BATMAN_V=n --------------------------------------------------------------------------- batadv_algo_dump batadv_algo_init batadv_algo_select batadv_debugfs_add_hardif batadv_debugfs_add_meshif batadv_debugfs_del_hardif batadv_debugfs_del_meshif batadv_debugfs_destroy batadv_debugfs_init batadv_frag_purge_orig batadv_frag_send_packet batadv_frag_skb_buffer batadv_frag_skb_fwd batadv_gw_bandwidth_set batadv_gw_check_client_stop batadv_gw_dhcp_recipient_get batadv_gw_dump batadv_gw_election batadv_gw_free batadv_gw_get_selected_orig batadv_gw_init batadv_gw_node_delete batadv_gw_node_free batadv_gw_out_of_range batadv_gw_tvlv_container_update batadv_iv_init batadv_routing_algo master: unused_symbols linux-3.19 cfg: BLA=y DAT=y DEBUGFS=y DEBUG=y NC=n MCAST=y BATMAN_V=y --------------------------------------------------------------------------- batadv_algo_dump batadv_algo_init batadv_algo_select batadv_bla_backbone_dump batadv_bla_check_bcast_duplist batadv_bla_claim_dump batadv_bla_free batadv_bla_init batadv_bla_is_backbone_gw batadv_bla_is_backbone_gw_orig batadv_bla_rx batadv_bla_status_update batadv_bla_tx batadv_bla_update_orig_address batadv_dat_drop_broadcast_packet batadv_dat_free batadv_dat_init batadv_dat_snoop_incoming_arp_reply batadv_dat_snoop_incoming_arp_request batadv_dat_snoop_outgoing_arp_reply batadv_dat_snoop_outgoing_arp_request batadv_dat_status_update batadv_debugfs_add_hardif batadv_debugfs_add_meshif batadv_debugfs_del_hardif batadv_debugfs_del_meshif batadv_debugfs_destroy batadv_debugfs_init batadv_frag_purge_orig batadv_frag_send_packet batadv_frag_skb_buffer batadv_frag_skb_fwd batadv_gw_bandwidth_set batadv_gw_check_client_stop batadv_gw_dhcp_recipient_get batadv_gw_dump batadv_gw_election batadv_gw_free batadv_gw_get_selected_orig batadv_gw_init batadv_gw_node_delete batadv_gw_node_free batadv_gw_out_of_range batadv_gw_tvlv_container_update batadv_iv_init batadv_routing_algo batadv_v_hardif_init batadv_v_init batadv_v_mesh_free batadv_v_mesh_init master: unused_symbols linux-3.4 cfg: BLA=n DAT=y DEBUGFS=y DEBUG=n NC=y MCAST=y BATMAN_V=n --------------------------------------------------------------------------- batadv_algo_dump batadv_algo_init batadv_algo_select batadv_dat_drop_broadcast_packet batadv_dat_free batadv_dat_init batadv_dat_snoop_incoming_arp_reply batadv_dat_snoop_incoming_arp_request batadv_dat_snoop_outgoing_arp_reply batadv_dat_snoop_outgoing_arp_request batadv_dat_status_update batadv_debugfs_add_hardif batadv_debugfs_add_meshif batadv_debugfs_del_hardif batadv_debugfs_del_meshif batadv_debugfs_destroy batadv_debugfs_init batadv_frag_purge_orig batadv_frag_send_packet batadv_frag_skb_buffer batadv_frag_skb_fwd batadv_gw_bandwidth_set batadv_gw_check_client_stop batadv_gw_dhcp_recipient_get batadv_gw_dump batadv_gw_election batadv_gw_free batadv_gw_get_selected_orig batadv_gw_init batadv_gw_node_delete batadv_gw_node_free batadv_gw_out_of_range batadv_gw_tvlv_container_update batadv_iv_init batadv_routing_algo master: unused_symbols linux-3.5 cfg: BLA=n DAT=n DEBUGFS=n DEBUG=n NC=n MCAST=y BATMAN_V=n --------------------------------------------------------------------------- batadv_algo_dump batadv_algo_init batadv_algo_select batadv_frag_purge_orig batadv_frag_send_packet batadv_frag_skb_buffer batadv_frag_skb_fwd batadv_gw_bandwidth_set batadv_gw_check_client_stop batadv_gw_dhcp_recipient_get batadv_gw_dump batadv_gw_election batadv_gw_free batadv_gw_get_selected_orig batadv_gw_init batadv_gw_node_delete batadv_gw_node_free batadv_gw_out_of_range batadv_gw_tvlv_container_update batadv_iv_init batadv_routing_algo master: unused_symbols linux-3.6 cfg: BLA=y DAT=n DEBUGFS=n DEBUG=n NC=n MCAST=y BATMAN_V=n --------------------------------------------------------------------------- batadv_algo_dump batadv_algo_init batadv_algo_select batadv_bla_backbone_dump batadv_bla_check_bcast_duplist batadv_bla_claim_dump batadv_bla_free batadv_bla_init batadv_bla_is_backbone_gw batadv_bla_is_backbone_gw_orig batadv_bla_rx batadv_bla_status_update batadv_bla_tx batadv_bla_update_orig_address batadv_frag_purge_orig batadv_frag_send_packet batadv_frag_skb_buffer batadv_frag_skb_fwd batadv_gw_bandwidth_set batadv_gw_check_client_stop batadv_gw_dhcp_recipient_get batadv_gw_dump batadv_gw_election batadv_gw_free batadv_gw_get_selected_orig batadv_gw_init batadv_gw_node_delete batadv_gw_node_free batadv_gw_out_of_range batadv_gw_tvlv_container_update batadv_iv_init batadv_routing_algo master: unused_symbols linux-4.2 cfg: BLA=n DAT=y DEBUGFS=y DEBUG=y NC=n MCAST=y BATMAN_V=n --------------------------------------------------------------------------- batadv_is_cfg80211_hardif Statistics ========== master ------ Failed tests: 174 Started build tests: 127 Tested Linux versions: 27 Tested configs: 81 next ---- Failed tests: 6 Started build tests: 115 Tested Linux versions: 25 Tested configs: 77

1 0

New Defects reported by Coverity Scan for batctl
by scan-admin＠coverity.com 24 Oct '16

24 Oct '16

Hi, Please find the latest report on new defect(s) introduced to batctl found with Coverity Scan. 5 new defect(s) introduced to batctl found with Coverity Scan. 1 defect(s), reported by Coverity Scan earlier, were marked fixed in the recent build analyzed by Coverity Scan. New defect(s) Reported-by: Coverity Scan Showing 5 of 5 defect(s) ** CID 153716: Memory - illegal accesses (UNINIT) /icmp_helper.c: 381 in get_nexthop_debugfs() ________________________________________________________________________________________________________ *** CID 153716: Memory - illegal accesses (UNINIT) /icmp_helper.c: 381 in get_nexthop_debugfs() 375 continue; 376 377 mac_tmp = ether_aton(dest); 378 if (!mac_tmp || memcmp(mac_tmp, mac, ETH_ALEN) != 0) 379 continue; 380 >>> CID 153716: Memory - illegal accesses (UNINIT) >>> Using uninitialized value "neigh" when calling "ether_aton". 381 mac_tmp = ether_aton(neigh); 382 if (!mac_tmp) 383 continue; 384 385 memcpy(nexthop, mac_tmp, ETH_ALEN); 386 strncpy(ifname, iface, IF_NAMESIZE); ** CID 153715: Memory - illegal accesses (UNINIT) /icmp_helper.c: 386 in get_nexthop_debugfs() ________________________________________________________________________________________________________ *** CID 153715: Memory - illegal accesses (UNINIT) /icmp_helper.c: 386 in get_nexthop_debugfs() 380 381 mac_tmp = ether_aton(neigh); 382 if (!mac_tmp) 383 continue; 384 385 memcpy(nexthop, mac_tmp, ETH_ALEN); >>> CID 153715: Memory - illegal accesses (UNINIT) >>> Using uninitialized value "iface" when calling "strncpy". 386 strncpy(ifname, iface, IF_NAMESIZE); 387 ifname[IF_NAMESIZE - 1] = '\0'; 388 break; 389 } 390 free(line); 391 fclose(f); ** CID 153714: Error handling issues (NEGATIVE_RETURNS) /ping.c: 204 in ping() ________________________________________________________________________________________________________ *** CID 153714: Error handling issues (NEGATIVE_RETURNS) /ping.c: 204 in ping() 198 icmp_packet_out.seqno = htons(++seq_counter); 199 200 res = icmp_interface_write(mesh_iface, 201 (struct batadv_icmp_header *)&icmp_packet_out, 202 packet_len); 203 if (res < 0) { >>> CID 153714: Error handling issues (NEGATIVE_RETURNS) >>> "res" is passed to a parameter that cannot be negative. 204 fprintf(stderr, "Error - can't send icmp packet: %s\n", strerror(res)); 205 goto sleep; 206 } 207 208 read_packet: 209 start_timer(); ** CID 153713: Error handling issues (NEGATIVE_RETURNS) /traceroute.c: 151 in traceroute() ________________________________________________________________________________________________________ *** CID 153713: Error handling issues (NEGATIVE_RETURNS) /traceroute.c: 151 in traceroute() 145 time_delta[i] = 0.0; 146 147 res = icmp_interface_write(mesh_iface, 148 (struct batadv_icmp_header *)&icmp_packet_out, 149 sizeof(icmp_packet_out)); 150 if (res < 0) { >>> CID 153713: Error handling issues (NEGATIVE_RETURNS) >>> "res" is passed to a parameter that cannot be negative. 151 fprintf(stderr, "Error - can't send icmp packet: %s\n", strerror(res)); 152 continue; 153 } 154 155 read_packet: 156 start_timer(); ** CID 153712: Security best practices violations (DC.WEAK_CRYPTO) /functions.c: 1122 in get_random_bytes_fallback() ________________________________________________________________________________________________________ *** CID 153712: Security best practices violations (DC.WEAK_CRYPTO) /functions.c: 1122 in get_random_bytes_fallback() 1116 clock_gettime(CLOCK_MONOTONIC, &now); 1117 srand(now.tv_sec ^ now.tv_nsec); 1118 initialized = 1; 1119 } 1120 1121 for (i = 0; i < buflen; i++) >>> CID 153712: Security best practices violations (DC.WEAK_CRYPTO) >>> "rand" should not be used for security related applications, as linear congruential algorithms are too easy to break. 1122 bufc[i] = rand() & 0xff; 1123 1124 return 0; 1125 } 1126 1127 void get_random_bytes(void *buf, size_t buflen) ________________________________________________________________________________________________________ To view the defects in Coverity Scan visit, https://u2389337.ct.sendgrid.net/wf/click?upn=08onrYu34A-2BWcWUl-2F-2BfV0V0… To manage Coverity Scan email notifications for "linux-merge(a)lists.open-mesh.org", click https://u2389337.ct.sendgrid.net/wf/click?upn=08onrYu34A-2BWcWUl-2F-2BfV0V0…

1 0

Coverity Scan: Analysis completed for batctl
by scan-admin＠coverity.com 24 Oct '16

24 Oct '16

Your request for analysis of batctl has been completed successfully. The results are available at https://u2389337.ct.sendgrid.net/wf/click?upn=08onrYu34A-2BWcWUl-2F-2BfV0V0… Analysis Summary: New defects found: 5 Defects eliminated: 1 If you have difficulty understading any defects, email us at scan-admin(a)coverity.com, or post your question to StackOverflow at https://u2389337.ct.sendgrid.net/wf/click?upn=OgIsEqWzmIl4S-2FzEUMxLXL-2Buk…

1 0

Build check errors found: 2016-10-24
by postmaster＠open-mesh.org 24 Oct '16

24 Oct '16

Name of failed tests ==================== next ---- * checkpatch ./net/batman-adv/debugfs.c * checkpatch ./net/batman-adv/icmp_socket.c * checkpatch ./net/batman-adv/log.c * checkpatch ./net/batman-adv/network-coding.c * checkpatch ./net/batman-adv/sysfs.c * difference between net-next and batadv next Output of different failed tests ================================ next: checkpatch ./net/batman-adv/debugfs.c ------------------------------------------- WARNING: Symbolic permissions 'S_IRUGO' are not preferred. Consider using octal permissions '0444'. #189: FILE: ./net/batman-adv/debugfs.c:189: +static BATADV_DEBUGINFO(routing_algos, S_IRUGO, batadv_algorithms_open); WARNING: Symbolic permissions 'S_IRUGO' are not preferred. Consider using octal permissions '0444'. #197: FILE: ./net/batman-adv/debugfs.c:197: +static BATADV_DEBUGINFO(neighbors, S_IRUGO, neighbors_open); WARNING: Symbolic permissions 'S_IRUGO' are not preferred. Consider using octal permissions '0444'. #198: FILE: ./net/batman-adv/debugfs.c:198: +static BATADV_DEBUGINFO(originators, S_IRUGO, batadv_originators_open); WARNING: Symbolic permissions 'S_IRUGO' are not preferred. Consider using octal permissions '0444'. #199: FILE: ./net/batman-adv/debugfs.c:199: +static BATADV_DEBUGINFO(gateways, S_IRUGO, batadv_gateways_open); WARNING: Symbolic permissions 'S_IRUGO' are not preferred. Consider using octal permissions '0444'. #200: FILE: ./net/batman-adv/debugfs.c:200: +static BATADV_DEBUGINFO(transtable_global, S_IRUGO, WARNING: Symbolic permissions 'S_IRUGO' are not preferred. Consider using octal permissions '0444'. #203: FILE: ./net/batman-adv/debugfs.c:203: +static BATADV_DEBUGINFO(bla_claim_table, S_IRUGO, batadv_bla_claim_table_open); WARNING: Symbolic permissions 'S_IRUGO' are not preferred. Consider using octal permissions '0444'. #204: FILE: ./net/batman-adv/debugfs.c:204: +static BATADV_DEBUGINFO(bla_backbone_table, S_IRUGO, WARNING: Symbolic permissions 'S_IRUGO' are not preferred. Consider using octal permissions '0444'. #208: FILE: ./net/batman-adv/debugfs.c:208: +static BATADV_DEBUGINFO(dat_cache, S_IRUGO, batadv_dat_cache_open); WARNING: Symbolic permissions 'S_IRUGO' are not preferred. Consider using octal permissions '0444'. #210: FILE: ./net/batman-adv/debugfs.c:210: +static BATADV_DEBUGINFO(transtable_local, S_IRUGO, WARNING: Symbolic permissions 'S_IRUGO' are not preferred. Consider using octal permissions '0444'. #213: FILE: ./net/batman-adv/debugfs.c:213: +static BATADV_DEBUGINFO(nc_nodes, S_IRUGO, batadv_nc_nodes_open); WARNING: Symbolic permissions 'S_IRUGO' are not preferred. Consider using octal permissions '0444'. #216: FILE: ./net/batman-adv/debugfs.c:216: +static BATADV_DEBUGINFO(mcast_flags, S_IRUGO, batadv_mcast_flags_open); WARNING: Symbolic permissions 'S_IRUGO' are not preferred. Consider using octal permissions '0444'. #256: FILE: ./net/batman-adv/debugfs.c:256: +static BATADV_HARDIF_DEBUGINFO(originators, S_IRUGO, total: 0 errors, 12 warnings, 0 checks, 420 lines checked next: checkpatch ./net/batman-adv/icmp_socket.c ----------------------------------------------- WARNING: Symbolic permissions 'S_IWUSR | S_IRUSR' are not preferred. Consider using octal permissions '0600'. #325: FILE: ./net/batman-adv/icmp_socket.c:325: + d = debugfs_create_file(BATADV_ICMP_SOCKET, S_IFREG | S_IWUSR | S_IRUSR, total: 0 errors, 1 warnings, 0 checks, 407 lines checked next: checkpatch ./net/batman-adv/log.c --------------------------------------- WARNING: Symbolic permissions 'S_IRUSR' are not preferred. Consider using octal permissions '0400'. #215: FILE: ./net/batman-adv/log.c:215: + d = debugfs_create_file("log", S_IFREG | S_IRUSR, total: 0 errors, 1 warnings, 0 checks, 231 lines checked next: checkpatch ./net/batman-adv/network-coding.c -------------------------------------------------- WARNING: Symbolic permissions 'S_IRUGO | S_IWUSR' are not preferred. Consider using octal permissions '0644'. #1964: FILE: ./net/batman-adv/network-coding.c:1964: + file = debugfs_create_u8("min_tq", S_IRUGO | S_IWUSR, nc_dir, WARNING: Symbolic permissions 'S_IRUGO | S_IWUSR' are not preferred. Consider using octal permissions '0644'. #1969: FILE: ./net/batman-adv/network-coding.c:1969: + file = debugfs_create_u32("max_fwd_delay", S_IRUGO | S_IWUSR, nc_dir, WARNING: Symbolic permissions 'S_IRUGO | S_IWUSR' are not preferred. Consider using octal permissions '0644'. #1974: FILE: ./net/batman-adv/network-coding.c:1974: + file = debugfs_create_u32("max_buffer_time", S_IRUGO | S_IWUSR, nc_dir, total: 0 errors, 3 warnings, 0 checks, 1984 lines checked next: checkpatch ./net/batman-adv/sysfs.c ----------------------------------------- WARNING: Symbolic permissions 'S_IRUGO | S_IWUSR' are not preferred. Consider using octal permissions '0644'. #669: FILE: ./net/batman-adv/sysfs.c:669: +BATADV_ATTR_SIF_BOOL(aggregated_ogms, S_IRUGO | S_IWUSR, NULL); WARNING: Symbolic permissions 'S_IRUGO | S_IWUSR' are not preferred. Consider using octal permissions '0644'. #670: FILE: ./net/batman-adv/sysfs.c:670: +BATADV_ATTR_SIF_BOOL(bonding, S_IRUGO | S_IWUSR, NULL); WARNING: Symbolic permissions 'S_IRUGO | S_IWUSR' are not preferred. Consider using octal permissions '0644'. #672: FILE: ./net/batman-adv/sysfs.c:672: +BATADV_ATTR_SIF_BOOL(bridge_loop_avoidance, S_IRUGO | S_IWUSR, WARNING: Symbolic permissions 'S_IRUGO | S_IWUSR' are not preferred. Consider using octal permissions '0644'. #676: FILE: ./net/batman-adv/sysfs.c:676: +BATADV_ATTR_SIF_BOOL(distributed_arp_table, S_IRUGO | S_IWUSR, WARNING: Symbolic permissions 'S_IRUGO | S_IWUSR' are not preferred. Consider using octal permissions '0644'. #679: FILE: ./net/batman-adv/sysfs.c:679: +BATADV_ATTR_SIF_BOOL(fragmentation, S_IRUGO | S_IWUSR, batadv_update_min_mtu); WARNING: Symbolic permissions 'S_IRUGO' are not preferred. Consider using octal permissions '0444'. #680: FILE: ./net/batman-adv/sysfs.c:680: +static BATADV_ATTR(routing_algo, S_IRUGO, batadv_show_bat_algo, NULL); WARNING: Symbolic permissions 'S_IRUGO | S_IWUSR' are not preferred. Consider using octal permissions '0644'. #681: FILE: ./net/batman-adv/sysfs.c:681: +static BATADV_ATTR(gw_mode, S_IRUGO | S_IWUSR, batadv_show_gw_mode, WARNING: Symbolic permissions 'S_IRUGO | S_IWUSR' are not preferred. Consider using octal permissions '0644'. #683: FILE: ./net/batman-adv/sysfs.c:683: +BATADV_ATTR_SIF_UINT(orig_interval, orig_interval, S_IRUGO | S_IWUSR, WARNING: Symbolic permissions 'S_IRUGO | S_IWUSR' are not preferred. Consider using octal permissions '0644'. #685: FILE: ./net/batman-adv/sysfs.c:685: +BATADV_ATTR_SIF_UINT(hop_penalty, hop_penalty, S_IRUGO | S_IWUSR, 0, WARNING: Symbolic permissions 'S_IRUGO | S_IWUSR' are not preferred. Consider using octal permissions '0644'. #687: FILE: ./net/batman-adv/sysfs.c:687: +static BATADV_ATTR(gw_sel_class, S_IRUGO | S_IWUSR, batadv_show_gw_sel_class, WARNING: Symbolic permissions 'S_IRUGO | S_IWUSR' are not preferred. Consider using octal permissions '0644'. #689: FILE: ./net/batman-adv/sysfs.c:689: +static BATADV_ATTR(gw_bandwidth, S_IRUGO | S_IWUSR, batadv_show_gw_bwidth, WARNING: Symbolic permissions 'S_IRUGO | S_IWUSR' are not preferred. Consider using octal permissions '0644'. #692: FILE: ./net/batman-adv/sysfs.c:692: +BATADV_ATTR_SIF_BOOL(multicast_mode, S_IRUGO | S_IWUSR, NULL); WARNING: Symbolic permissions 'S_IRUGO | S_IWUSR' are not preferred. Consider using octal permissions '0644'. #695: FILE: ./net/batman-adv/sysfs.c:695: +BATADV_ATTR_SIF_UINT(log_level, log_level, S_IRUGO | S_IWUSR, 0, WARNING: Symbolic permissions 'S_IRUGO | S_IWUSR' are not preferred. Consider using octal permissions '0644'. #699: FILE: ./net/batman-adv/sysfs.c:699: +BATADV_ATTR_SIF_BOOL(network_coding, S_IRUGO | S_IWUSR, WARNING: Symbolic permissions 'S_IRUGO | S_IWUSR' are not preferred. Consider using octal permissions '0644'. #702: FILE: ./net/batman-adv/sysfs.c:702: +static BATADV_ATTR(isolation_mark, S_IRUGO | S_IWUSR, WARNING: Symbolic permissions 'S_IRUGO | S_IWUSR' are not preferred. Consider using octal permissions '0644'. #734: FILE: ./net/batman-adv/sysfs.c:734: +BATADV_ATTR_VLAN_BOOL(ap_isolation, S_IRUGO | S_IWUSR, NULL); WARNING: Symbolic permissions 'S_IRUGO | S_IWUSR' are not preferred. Consider using octal permissions '0644'. #1119: FILE: ./net/batman-adv/sysfs.c:1119: +static BATADV_ATTR(mesh_iface, S_IRUGO | S_IWUSR, batadv_show_mesh_iface, WARNING: Symbolic permissions 'S_IRUGO' are not preferred. Consider using octal permissions '0444'. #1121: FILE: ./net/batman-adv/sysfs.c:1121: +static BATADV_ATTR(iface_status, S_IRUGO, batadv_show_iface_status, NULL); WARNING: Symbolic permissions 'S_IRUGO | S_IWUSR' are not preferred. Consider using octal permissions '0644'. #1123: FILE: ./net/batman-adv/sysfs.c:1123: +BATADV_ATTR_HIF_UINT(elp_interval, bat_v.elp_interval, S_IRUGO | S_IWUSR, WARNING: Symbolic permissions 'S_IRUGO | S_IWUSR' are not preferred. Consider using octal permissions '0644'. #1125: FILE: ./net/batman-adv/sysfs.c:1125: +static BATADV_ATTR(throughput_override, S_IRUGO | S_IWUSR, total: 0 errors, 20 warnings, 0 checks, 1224 lines checked next: difference between net-next and batadv next ------------------------------------------------- netnext/net/batman-adv/hard-interface.c | 1 + netnext/net/batman-adv/log.h | 2 +- netnext/net/batman-adv/originator.c | 2 +- netnext/net/batman-adv/soft-interface.c | 13 +------------ 4 files changed, 4 insertions(+), 14 deletions(-) Statistics ========== master ------ Failed tests: 0 Started build tests: 106 Tested Linux versions: 27 Tested configs: 78 next ---- Failed tests: 6 Started build tests: 115 Tested Linux versions: 27 Tested configs: 76

1 0

Build check errors found: 2016-10-23
by postmaster＠open-mesh.org 23 Oct '16

23 Oct '16

Name of failed tests ==================== next ---- * checkpatch ./net/batman-adv/debugfs.c * checkpatch ./net/batman-adv/icmp_socket.c * checkpatch ./net/batman-adv/log.c * checkpatch ./net/batman-adv/network-coding.c * checkpatch ./net/batman-adv/sysfs.c * difference between net-next and batadv next Output of different failed tests ================================ next: checkpatch ./net/batman-adv/debugfs.c ------------------------------------------- WARNING: Symbolic permissions 'S_IRUGO' are not preferred. Consider using octal permissions '0444'. #189: FILE: ./net/batman-adv/debugfs.c:189: +static BATADV_DEBUGINFO(routing_algos, S_IRUGO, batadv_algorithms_open); WARNING: Symbolic permissions 'S_IRUGO' are not preferred. Consider using octal permissions '0444'. #197: FILE: ./net/batman-adv/debugfs.c:197: +static BATADV_DEBUGINFO(neighbors, S_IRUGO, neighbors_open); WARNING: Symbolic permissions 'S_IRUGO' are not preferred. Consider using octal permissions '0444'. #198: FILE: ./net/batman-adv/debugfs.c:198: +static BATADV_DEBUGINFO(originators, S_IRUGO, batadv_originators_open); WARNING: Symbolic permissions 'S_IRUGO' are not preferred. Consider using octal permissions '0444'. #199: FILE: ./net/batman-adv/debugfs.c:199: +static BATADV_DEBUGINFO(gateways, S_IRUGO, batadv_gateways_open); WARNING: Symbolic permissions 'S_IRUGO' are not preferred. Consider using octal permissions '0444'. #200: FILE: ./net/batman-adv/debugfs.c:200: +static BATADV_DEBUGINFO(transtable_global, S_IRUGO, WARNING: Symbolic permissions 'S_IRUGO' are not preferred. Consider using octal permissions '0444'. #203: FILE: ./net/batman-adv/debugfs.c:203: +static BATADV_DEBUGINFO(bla_claim_table, S_IRUGO, batadv_bla_claim_table_open); WARNING: Symbolic permissions 'S_IRUGO' are not preferred. Consider using octal permissions '0444'. #204: FILE: ./net/batman-adv/debugfs.c:204: +static BATADV_DEBUGINFO(bla_backbone_table, S_IRUGO, WARNING: Symbolic permissions 'S_IRUGO' are not preferred. Consider using octal permissions '0444'. #208: FILE: ./net/batman-adv/debugfs.c:208: +static BATADV_DEBUGINFO(dat_cache, S_IRUGO, batadv_dat_cache_open); WARNING: Symbolic permissions 'S_IRUGO' are not preferred. Consider using octal permissions '0444'. #210: FILE: ./net/batman-adv/debugfs.c:210: +static BATADV_DEBUGINFO(transtable_local, S_IRUGO, WARNING: Symbolic permissions 'S_IRUGO' are not preferred. Consider using octal permissions '0444'. #213: FILE: ./net/batman-adv/debugfs.c:213: +static BATADV_DEBUGINFO(nc_nodes, S_IRUGO, batadv_nc_nodes_open); WARNING: Symbolic permissions 'S_IRUGO' are not preferred. Consider using octal permissions '0444'. #216: FILE: ./net/batman-adv/debugfs.c:216: +static BATADV_DEBUGINFO(mcast_flags, S_IRUGO, batadv_mcast_flags_open); WARNING: Symbolic permissions 'S_IRUGO' are not preferred. Consider using octal permissions '0444'. #256: FILE: ./net/batman-adv/debugfs.c:256: +static BATADV_HARDIF_DEBUGINFO(originators, S_IRUGO, total: 0 errors, 12 warnings, 0 checks, 420 lines checked next: checkpatch ./net/batman-adv/icmp_socket.c ----------------------------------------------- WARNING: Symbolic permissions 'S_IWUSR | S_IRUSR' are not preferred. Consider using octal permissions '0600'. #325: FILE: ./net/batman-adv/icmp_socket.c:325: + d = debugfs_create_file(BATADV_ICMP_SOCKET, S_IFREG | S_IWUSR | S_IRUSR, total: 0 errors, 1 warnings, 0 checks, 407 lines checked next: checkpatch ./net/batman-adv/log.c --------------------------------------- WARNING: Symbolic permissions 'S_IRUSR' are not preferred. Consider using octal permissions '0400'. #215: FILE: ./net/batman-adv/log.c:215: + d = debugfs_create_file("log", S_IFREG | S_IRUSR, total: 0 errors, 1 warnings, 0 checks, 231 lines checked next: checkpatch ./net/batman-adv/network-coding.c -------------------------------------------------- WARNING: Symbolic permissions 'S_IRUGO | S_IWUSR' are not preferred. Consider using octal permissions '0644'. #1964: FILE: ./net/batman-adv/network-coding.c:1964: + file = debugfs_create_u8("min_tq", S_IRUGO | S_IWUSR, nc_dir, WARNING: Symbolic permissions 'S_IRUGO | S_IWUSR' are not preferred. Consider using octal permissions '0644'. #1969: FILE: ./net/batman-adv/network-coding.c:1969: + file = debugfs_create_u32("max_fwd_delay", S_IRUGO | S_IWUSR, nc_dir, WARNING: Symbolic permissions 'S_IRUGO | S_IWUSR' are not preferred. Consider using octal permissions '0644'. #1974: FILE: ./net/batman-adv/network-coding.c:1974: + file = debugfs_create_u32("max_buffer_time", S_IRUGO | S_IWUSR, nc_dir, total: 0 errors, 3 warnings, 0 checks, 1984 lines checked next: checkpatch ./net/batman-adv/sysfs.c ----------------------------------------- WARNING: Symbolic permissions 'S_IRUGO | S_IWUSR' are not preferred. Consider using octal permissions '0644'. #669: FILE: ./net/batman-adv/sysfs.c:669: +BATADV_ATTR_SIF_BOOL(aggregated_ogms, S_IRUGO | S_IWUSR, NULL); WARNING: Symbolic permissions 'S_IRUGO | S_IWUSR' are not preferred. Consider using octal permissions '0644'. #670: FILE: ./net/batman-adv/sysfs.c:670: +BATADV_ATTR_SIF_BOOL(bonding, S_IRUGO | S_IWUSR, NULL); WARNING: Symbolic permissions 'S_IRUGO | S_IWUSR' are not preferred. Consider using octal permissions '0644'. #672: FILE: ./net/batman-adv/sysfs.c:672: +BATADV_ATTR_SIF_BOOL(bridge_loop_avoidance, S_IRUGO | S_IWUSR, WARNING: Symbolic permissions 'S_IRUGO | S_IWUSR' are not preferred. Consider using octal permissions '0644'. #676: FILE: ./net/batman-adv/sysfs.c:676: +BATADV_ATTR_SIF_BOOL(distributed_arp_table, S_IRUGO | S_IWUSR, WARNING: Symbolic permissions 'S_IRUGO | S_IWUSR' are not preferred. Consider using octal permissions '0644'. #679: FILE: ./net/batman-adv/sysfs.c:679: +BATADV_ATTR_SIF_BOOL(fragmentation, S_IRUGO | S_IWUSR, batadv_update_min_mtu); WARNING: Symbolic permissions 'S_IRUGO' are not preferred. Consider using octal permissions '0444'. #680: FILE: ./net/batman-adv/sysfs.c:680: +static BATADV_ATTR(routing_algo, S_IRUGO, batadv_show_bat_algo, NULL); WARNING: Symbolic permissions 'S_IRUGO | S_IWUSR' are not preferred. Consider using octal permissions '0644'. #681: FILE: ./net/batman-adv/sysfs.c:681: +static BATADV_ATTR(gw_mode, S_IRUGO | S_IWUSR, batadv_show_gw_mode, WARNING: Symbolic permissions 'S_IRUGO | S_IWUSR' are not preferred. Consider using octal permissions '0644'. #683: FILE: ./net/batman-adv/sysfs.c:683: +BATADV_ATTR_SIF_UINT(orig_interval, orig_interval, S_IRUGO | S_IWUSR, WARNING: Symbolic permissions 'S_IRUGO | S_IWUSR' are not preferred. Consider using octal permissions '0644'. #685: FILE: ./net/batman-adv/sysfs.c:685: +BATADV_ATTR_SIF_UINT(hop_penalty, hop_penalty, S_IRUGO | S_IWUSR, 0, WARNING: Symbolic permissions 'S_IRUGO | S_IWUSR' are not preferred. Consider using octal permissions '0644'. #687: FILE: ./net/batman-adv/sysfs.c:687: +static BATADV_ATTR(gw_sel_class, S_IRUGO | S_IWUSR, batadv_show_gw_sel_class, WARNING: Symbolic permissions 'S_IRUGO | S_IWUSR' are not preferred. Consider using octal permissions '0644'. #689: FILE: ./net/batman-adv/sysfs.c:689: +static BATADV_ATTR(gw_bandwidth, S_IRUGO | S_IWUSR, batadv_show_gw_bwidth, WARNING: Symbolic permissions 'S_IRUGO | S_IWUSR' are not preferred. Consider using octal permissions '0644'. #692: FILE: ./net/batman-adv/sysfs.c:692: +BATADV_ATTR_SIF_BOOL(multicast_mode, S_IRUGO | S_IWUSR, NULL); WARNING: Symbolic permissions 'S_IRUGO | S_IWUSR' are not preferred. Consider using octal permissions '0644'. #695: FILE: ./net/batman-adv/sysfs.c:695: +BATADV_ATTR_SIF_UINT(log_level, log_level, S_IRUGO | S_IWUSR, 0, WARNING: Symbolic permissions 'S_IRUGO | S_IWUSR' are not preferred. Consider using octal permissions '0644'. #699: FILE: ./net/batman-adv/sysfs.c:699: +BATADV_ATTR_SIF_BOOL(network_coding, S_IRUGO | S_IWUSR, WARNING: Symbolic permissions 'S_IRUGO | S_IWUSR' are not preferred. Consider using octal permissions '0644'. #702: FILE: ./net/batman-adv/sysfs.c:702: +static BATADV_ATTR(isolation_mark, S_IRUGO | S_IWUSR, WARNING: Symbolic permissions 'S_IRUGO | S_IWUSR' are not preferred. Consider using octal permissions '0644'. #734: FILE: ./net/batman-adv/sysfs.c:734: +BATADV_ATTR_VLAN_BOOL(ap_isolation, S_IRUGO | S_IWUSR, NULL); WARNING: Symbolic permissions 'S_IRUGO | S_IWUSR' are not preferred. Consider using octal permissions '0644'. #1119: FILE: ./net/batman-adv/sysfs.c:1119: +static BATADV_ATTR(mesh_iface, S_IRUGO | S_IWUSR, batadv_show_mesh_iface, WARNING: Symbolic permissions 'S_IRUGO' are not preferred. Consider using octal permissions '0444'. #1121: FILE: ./net/batman-adv/sysfs.c:1121: +static BATADV_ATTR(iface_status, S_IRUGO, batadv_show_iface_status, NULL); WARNING: Symbolic permissions 'S_IRUGO | S_IWUSR' are not preferred. Consider using octal permissions '0644'. #1123: FILE: ./net/batman-adv/sysfs.c:1123: +BATADV_ATTR_HIF_UINT(elp_interval, bat_v.elp_interval, S_IRUGO | S_IWUSR, WARNING: Symbolic permissions 'S_IRUGO | S_IWUSR' are not preferred. Consider using octal permissions '0644'. #1125: FILE: ./net/batman-adv/sysfs.c:1125: +static BATADV_ATTR(throughput_override, S_IRUGO | S_IWUSR, total: 0 errors, 20 warnings, 0 checks, 1224 lines checked next: difference between net-next and batadv next ------------------------------------------------- netnext/net/batman-adv/hard-interface.c | 1 + netnext/net/batman-adv/log.h | 2 +- netnext/net/batman-adv/originator.c | 2 +- netnext/net/batman-adv/soft-interface.c | 13 +------------ 4 files changed, 4 insertions(+), 14 deletions(-) Statistics ========== master ------ Failed tests: 0 Started build tests: 111 Tested Linux versions: 26 Tested configs: 80 next ---- Failed tests: 6 Started build tests: 112 Tested Linux versions: 26 Tested configs: 74

1 0

Build check errors found: 2016-10-22
by postmaster＠open-mesh.org 22 Oct '16

22 Oct '16

Name of failed tests ==================== next ---- * checkpatch ./net/batman-adv/debugfs.c * checkpatch ./net/batman-adv/icmp_socket.c * checkpatch ./net/batman-adv/log.c * checkpatch ./net/batman-adv/network-coding.c * checkpatch ./net/batman-adv/sysfs.c * difference between net-next and batadv next Output of different failed tests ================================ next: checkpatch ./net/batman-adv/debugfs.c ------------------------------------------- WARNING: Symbolic permissions 'S_IRUGO' are not preferred. Consider using octal permissions '0444'. #189: FILE: ./net/batman-adv/debugfs.c:189: +static BATADV_DEBUGINFO(routing_algos, S_IRUGO, batadv_algorithms_open); WARNING: Symbolic permissions 'S_IRUGO' are not preferred. Consider using octal permissions '0444'. #197: FILE: ./net/batman-adv/debugfs.c:197: +static BATADV_DEBUGINFO(neighbors, S_IRUGO, neighbors_open); WARNING: Symbolic permissions 'S_IRUGO' are not preferred. Consider using octal permissions '0444'. #198: FILE: ./net/batman-adv/debugfs.c:198: +static BATADV_DEBUGINFO(originators, S_IRUGO, batadv_originators_open); WARNING: Symbolic permissions 'S_IRUGO' are not preferred. Consider using octal permissions '0444'. #199: FILE: ./net/batman-adv/debugfs.c:199: +static BATADV_DEBUGINFO(gateways, S_IRUGO, batadv_gateways_open); WARNING: Symbolic permissions 'S_IRUGO' are not preferred. Consider using octal permissions '0444'. #200: FILE: ./net/batman-adv/debugfs.c:200: +static BATADV_DEBUGINFO(transtable_global, S_IRUGO, WARNING: Symbolic permissions 'S_IRUGO' are not preferred. Consider using octal permissions '0444'. #203: FILE: ./net/batman-adv/debugfs.c:203: +static BATADV_DEBUGINFO(bla_claim_table, S_IRUGO, batadv_bla_claim_table_open); WARNING: Symbolic permissions 'S_IRUGO' are not preferred. Consider using octal permissions '0444'. #204: FILE: ./net/batman-adv/debugfs.c:204: +static BATADV_DEBUGINFO(bla_backbone_table, S_IRUGO, WARNING: Symbolic permissions 'S_IRUGO' are not preferred. Consider using octal permissions '0444'. #208: FILE: ./net/batman-adv/debugfs.c:208: +static BATADV_DEBUGINFO(dat_cache, S_IRUGO, batadv_dat_cache_open); WARNING: Symbolic permissions 'S_IRUGO' are not preferred. Consider using octal permissions '0444'. #210: FILE: ./net/batman-adv/debugfs.c:210: +static BATADV_DEBUGINFO(transtable_local, S_IRUGO, WARNING: Symbolic permissions 'S_IRUGO' are not preferred. Consider using octal permissions '0444'. #213: FILE: ./net/batman-adv/debugfs.c:213: +static BATADV_DEBUGINFO(nc_nodes, S_IRUGO, batadv_nc_nodes_open); WARNING: Symbolic permissions 'S_IRUGO' are not preferred. Consider using octal permissions '0444'. #216: FILE: ./net/batman-adv/debugfs.c:216: +static BATADV_DEBUGINFO(mcast_flags, S_IRUGO, batadv_mcast_flags_open); WARNING: Symbolic permissions 'S_IRUGO' are not preferred. Consider using octal permissions '0444'. #256: FILE: ./net/batman-adv/debugfs.c:256: +static BATADV_HARDIF_DEBUGINFO(originators, S_IRUGO, total: 0 errors, 12 warnings, 0 checks, 420 lines checked next: checkpatch ./net/batman-adv/icmp_socket.c ----------------------------------------------- WARNING: Symbolic permissions 'S_IWUSR | S_IRUSR' are not preferred. Consider using octal permissions '0600'. #325: FILE: ./net/batman-adv/icmp_socket.c:325: + d = debugfs_create_file(BATADV_ICMP_SOCKET, S_IFREG | S_IWUSR | S_IRUSR, total: 0 errors, 1 warnings, 0 checks, 407 lines checked next: checkpatch ./net/batman-adv/log.c --------------------------------------- WARNING: Symbolic permissions 'S_IRUSR' are not preferred. Consider using octal permissions '0400'. #215: FILE: ./net/batman-adv/log.c:215: + d = debugfs_create_file("log", S_IFREG | S_IRUSR, total: 0 errors, 1 warnings, 0 checks, 231 lines checked next: checkpatch ./net/batman-adv/network-coding.c -------------------------------------------------- WARNING: Symbolic permissions 'S_IRUGO | S_IWUSR' are not preferred. Consider using octal permissions '0644'. #1964: FILE: ./net/batman-adv/network-coding.c:1964: + file = debugfs_create_u8("min_tq", S_IRUGO | S_IWUSR, nc_dir, WARNING: Symbolic permissions 'S_IRUGO | S_IWUSR' are not preferred. Consider using octal permissions '0644'. #1969: FILE: ./net/batman-adv/network-coding.c:1969: + file = debugfs_create_u32("max_fwd_delay", S_IRUGO | S_IWUSR, nc_dir, WARNING: Symbolic permissions 'S_IRUGO | S_IWUSR' are not preferred. Consider using octal permissions '0644'. #1974: FILE: ./net/batman-adv/network-coding.c:1974: + file = debugfs_create_u32("max_buffer_time", S_IRUGO | S_IWUSR, nc_dir, total: 0 errors, 3 warnings, 0 checks, 1984 lines checked next: checkpatch ./net/batman-adv/sysfs.c ----------------------------------------- WARNING: Symbolic permissions 'S_IRUGO | S_IWUSR' are not preferred. Consider using octal permissions '0644'. #669: FILE: ./net/batman-adv/sysfs.c:669: +BATADV_ATTR_SIF_BOOL(aggregated_ogms, S_IRUGO | S_IWUSR, NULL); WARNING: Symbolic permissions 'S_IRUGO | S_IWUSR' are not preferred. Consider using octal permissions '0644'. #670: FILE: ./net/batman-adv/sysfs.c:670: +BATADV_ATTR_SIF_BOOL(bonding, S_IRUGO | S_IWUSR, NULL); WARNING: Symbolic permissions 'S_IRUGO | S_IWUSR' are not preferred. Consider using octal permissions '0644'. #672: FILE: ./net/batman-adv/sysfs.c:672: +BATADV_ATTR_SIF_BOOL(bridge_loop_avoidance, S_IRUGO | S_IWUSR, WARNING: Symbolic permissions 'S_IRUGO | S_IWUSR' are not preferred. Consider using octal permissions '0644'. #676: FILE: ./net/batman-adv/sysfs.c:676: +BATADV_ATTR_SIF_BOOL(distributed_arp_table, S_IRUGO | S_IWUSR, WARNING: Symbolic permissions 'S_IRUGO | S_IWUSR' are not preferred. Consider using octal permissions '0644'. #679: FILE: ./net/batman-adv/sysfs.c:679: +BATADV_ATTR_SIF_BOOL(fragmentation, S_IRUGO | S_IWUSR, batadv_update_min_mtu); WARNING: Symbolic permissions 'S_IRUGO' are not preferred. Consider using octal permissions '0444'. #680: FILE: ./net/batman-adv/sysfs.c:680: +static BATADV_ATTR(routing_algo, S_IRUGO, batadv_show_bat_algo, NULL); WARNING: Symbolic permissions 'S_IRUGO | S_IWUSR' are not preferred. Consider using octal permissions '0644'. #681: FILE: ./net/batman-adv/sysfs.c:681: +static BATADV_ATTR(gw_mode, S_IRUGO | S_IWUSR, batadv_show_gw_mode, WARNING: Symbolic permissions 'S_IRUGO | S_IWUSR' are not preferred. Consider using octal permissions '0644'. #683: FILE: ./net/batman-adv/sysfs.c:683: +BATADV_ATTR_SIF_UINT(orig_interval, orig_interval, S_IRUGO | S_IWUSR, WARNING: Symbolic permissions 'S_IRUGO | S_IWUSR' are not preferred. Consider using octal permissions '0644'. #685: FILE: ./net/batman-adv/sysfs.c:685: +BATADV_ATTR_SIF_UINT(hop_penalty, hop_penalty, S_IRUGO | S_IWUSR, 0, WARNING: Symbolic permissions 'S_IRUGO | S_IWUSR' are not preferred. Consider using octal permissions '0644'. #687: FILE: ./net/batman-adv/sysfs.c:687: +static BATADV_ATTR(gw_sel_class, S_IRUGO | S_IWUSR, batadv_show_gw_sel_class, WARNING: Symbolic permissions 'S_IRUGO | S_IWUSR' are not preferred. Consider using octal permissions '0644'. #689: FILE: ./net/batman-adv/sysfs.c:689: +static BATADV_ATTR(gw_bandwidth, S_IRUGO | S_IWUSR, batadv_show_gw_bwidth, WARNING: Symbolic permissions 'S_IRUGO | S_IWUSR' are not preferred. Consider using octal permissions '0644'. #692: FILE: ./net/batman-adv/sysfs.c:692: +BATADV_ATTR_SIF_BOOL(multicast_mode, S_IRUGO | S_IWUSR, NULL); WARNING: Symbolic permissions 'S_IRUGO | S_IWUSR' are not preferred. Consider using octal permissions '0644'. #695: FILE: ./net/batman-adv/sysfs.c:695: +BATADV_ATTR_SIF_UINT(log_level, log_level, S_IRUGO | S_IWUSR, 0, WARNING: Symbolic permissions 'S_IRUGO | S_IWUSR' are not preferred. Consider using octal permissions '0644'. #699: FILE: ./net/batman-adv/sysfs.c:699: +BATADV_ATTR_SIF_BOOL(network_coding, S_IRUGO | S_IWUSR, WARNING: Symbolic permissions 'S_IRUGO | S_IWUSR' are not preferred. Consider using octal permissions '0644'. #702: FILE: ./net/batman-adv/sysfs.c:702: +static BATADV_ATTR(isolation_mark, S_IRUGO | S_IWUSR, WARNING: Symbolic permissions 'S_IRUGO | S_IWUSR' are not preferred. Consider using octal permissions '0644'. #734: FILE: ./net/batman-adv/sysfs.c:734: +BATADV_ATTR_VLAN_BOOL(ap_isolation, S_IRUGO | S_IWUSR, NULL); WARNING: Symbolic permissions 'S_IRUGO | S_IWUSR' are not preferred. Consider using octal permissions '0644'. #1119: FILE: ./net/batman-adv/sysfs.c:1119: +static BATADV_ATTR(mesh_iface, S_IRUGO | S_IWUSR, batadv_show_mesh_iface, WARNING: Symbolic permissions 'S_IRUGO' are not preferred. Consider using octal permissions '0444'. #1121: FILE: ./net/batman-adv/sysfs.c:1121: +static BATADV_ATTR(iface_status, S_IRUGO, batadv_show_iface_status, NULL); WARNING: Symbolic permissions 'S_IRUGO | S_IWUSR' are not preferred. Consider using octal permissions '0644'. #1123: FILE: ./net/batman-adv/sysfs.c:1123: +BATADV_ATTR_HIF_UINT(elp_interval, bat_v.elp_interval, S_IRUGO | S_IWUSR, WARNING: Symbolic permissions 'S_IRUGO | S_IWUSR' are not preferred. Consider using octal permissions '0644'. #1125: FILE: ./net/batman-adv/sysfs.c:1125: +static BATADV_ATTR(throughput_override, S_IRUGO | S_IWUSR, total: 0 errors, 20 warnings, 0 checks, 1224 lines checked next: difference between net-next and batadv next ------------------------------------------------- netnext/net/batman-adv/hard-interface.c | 1 + netnext/net/batman-adv/log.h | 2 +- netnext/net/batman-adv/originator.c | 2 +- netnext/net/batman-adv/soft-interface.c | 13 +------------ 4 files changed, 4 insertions(+), 14 deletions(-) Statistics ========== master ------ Failed tests: 0 Started build tests: 107 Tested Linux versions: 26 Tested configs: 76 next ---- Failed tests: 6 Started build tests: 123 Tested Linux versions: 27 Tested configs: 77

1 0

[linux-next] LinuxNextTracking branch, master, updated. next-20161021
by batman＠open-mesh.org 21 Oct '16

21 Oct '16

The following commit has been merged in the master branch: commit b3e3893e1253692c3d2b8e8ebd5a26183ed30443 Author: Jarod Wilson <jarod(a)redhat.com> Date: Thu Oct 20 13:55:22 2016 -0400 net: use core MTU range checking in misc drivers firewire-net: - set min/max_mtu - remove fwnet_change_mtu nes: - set max_mtu - clean up nes_netdev_change_mtu xpnet: - set min/max_mtu - remove xpnet_dev_change_mtu hippi: - set min/max_mtu - remove hippi_change_mtu batman-adv: - set max_mtu - remove batadv_interface_change_mtu - initialization is a little async, not 100% certain that max_mtu is set in the optimal place, don't have hardware to test with rionet: - set min/max_mtu - remove rionet_change_mtu slip: - set min/max_mtu - streamline sl_change_mtu um/net_kern: - remove pointless ndo_change_mtu hsi/clients/ssi_protocol: - use core MTU range checking - remove now redundant ssip_pn_set_mtu ipoib: - set a default max MTU value - Note: ipoib's actual max MTU can vary, depending on if the device is in connected mode or not, so we'll just set the max_mtu value to the max possible, and let the ndo_change_mtu function continue to validate any new MTU change requests with checks for CM or not. Note that ipoib has no min_mtu set, and thus, the network core's mtu > 0 check is the only lower bounds here. mptlan: - use net core MTU range checking - remove now redundant mpt_lan_change_mtu fddi: - min_mtu = 21, max_mtu = 4470 - remove now redundant fddi_change_mtu (including export) fjes: - min_mtu = 8192, max_mtu = 65536 - The max_mtu value is actually one over IP_MAX_MTU here, but the idea is to get past the core net MTU range checks so fjes_change_mtu can validate a new MTU against what it supports (see fjes_support_mtu in fjes_hw.c) hsr: - min_mtu = 0 (calls ether_setup, max_mtu is 1500) f_phonet: - min_mtu = 6, max_mtu = 65541 u_ether: - min_mtu = 14, max_mtu = 15412 phonet/pep-gprs: - min_mtu = 576, max_mtu = 65530 - remove redundant gprs_set_mtu CC: netdev(a)vger.kernel.org CC: linux-rdma(a)vger.kernel.org CC: Stefan Richter <stefanr(a)s5r6.in-berlin.de> CC: Faisal Latif <faisal.latif(a)intel.com> CC: linux-rdma(a)vger.kernel.org CC: Cliff Whickman <cpw(a)sgi.com> CC: Robin Holt <robinmholt(a)gmail.com> CC: Jes Sorensen <jes(a)trained-monkey.org> CC: Marek Lindner <mareklindner(a)neomailbox.ch> CC: Simon Wunderlich <sw(a)simonwunderlich.de> CC: Antonio Quartulli <a(a)unstable.cc> CC: Sathya Prakash <sathya.prakash(a)broadcom.com> CC: Chaitra P B <chaitra.basappa(a)broadcom.com> CC: Suganath Prabu Subramani <suganath-prabu.subramani(a)broadcom.com> CC: MPT-FusionLinux.pdl(a)broadcom.com CC: Sebastian Reichel <sre(a)kernel.org> CC: Felipe Balbi <balbi(a)kernel.org> CC: Arvid Brodin <arvid.brodin(a)alten.se> CC: Remi Denis-Courmont <courmisch(a)gmail.com> Signed-off-by: Jarod Wilson <jarod(a)redhat.com> Signed-off-by: David S. Miller <davem(a)davemloft.net> diff --git a/arch/um/drivers/net_kern.c b/arch/um/drivers/net_kern.c index 2cd5b68..1669240 100644 --- a/arch/um/drivers/net_kern.c +++ b/arch/um/drivers/net_kern.c @@ -256,13 +256,6 @@ static void uml_net_tx_timeout(struct net_device *dev) netif_wake_queue(dev); } -static int uml_net_change_mtu(struct net_device *dev, int new_mtu) -{ - dev->mtu = new_mtu; - - return 0; -} - #ifdef CONFIG_NET_POLL_CONTROLLER static void uml_net_poll_controller(struct net_device *dev) { @@ -374,7 +367,6 @@ static const struct net_device_ops uml_netdev_ops = { .ndo_set_rx_mode = uml_net_set_multicast_list, .ndo_tx_timeout = uml_net_tx_timeout, .ndo_set_mac_address = eth_mac_addr, - .ndo_change_mtu = uml_net_change_mtu, .ndo_validate_addr = eth_validate_addr, #ifdef CONFIG_NET_POLL_CONTROLLER .ndo_poll_controller = uml_net_poll_controller, diff --git a/drivers/firewire/net.c b/drivers/firewire/net.c index 309311b..8430222 100644 --- a/drivers/firewire/net.c +++ b/drivers/firewire/net.c @@ -1349,15 +1349,6 @@ static netdev_tx_t fwnet_tx(struct sk_buff *skb, struct net_device *net) return NETDEV_TX_OK; } -static int fwnet_change_mtu(struct net_device *net, int new_mtu) -{ - if (new_mtu < 68) - return -EINVAL; - - net->mtu = new_mtu; - return 0; -} - static const struct ethtool_ops fwnet_ethtool_ops = { .get_link = ethtool_op_get_link, }; @@ -1366,7 +1357,6 @@ static const struct net_device_ops fwnet_netdev_ops = { .ndo_open = fwnet_open, .ndo_stop = fwnet_stop, .ndo_start_xmit = fwnet_tx, - .ndo_change_mtu = fwnet_change_mtu, }; static void fwnet_init_dev(struct net_device *net) @@ -1435,7 +1425,6 @@ static int fwnet_probe(struct fw_unit *unit, struct net_device *net; bool allocated_netdev = false; struct fwnet_device *dev; - unsigned max_mtu; int ret; union fwnet_hwaddr *ha; @@ -1478,9 +1467,10 @@ static int fwnet_probe(struct fw_unit *unit, * Use the RFC 2734 default 1500 octets or the maximum payload * as initial MTU */ - max_mtu = (1 << (card->max_receive + 1)) - - sizeof(struct rfc2734_header) - IEEE1394_GASP_HDR_SIZE; - net->mtu = min(1500U, max_mtu); + net->max_mtu = (1 << (card->max_receive + 1)) + - sizeof(struct rfc2734_header) - IEEE1394_GASP_HDR_SIZE; + net->mtu = min(1500U, net->max_mtu); + net->min_mtu = ETH_MIN_MTU; /* Set our hardware address while we're at it */ ha = (union fwnet_hwaddr *)net->dev_addr; diff --git a/drivers/hsi/clients/ssi_protocol.c b/drivers/hsi/clients/ssi_protocol.c index 6031cd1..7ef8196 100644 --- a/drivers/hsi/clients/ssi_protocol.c +++ b/drivers/hsi/clients/ssi_protocol.c @@ -960,15 +960,6 @@ static int ssip_pn_stop(struct net_device *dev) return 0; } -static int ssip_pn_set_mtu(struct net_device *dev, int new_mtu) -{ - if (new_mtu > SSIP_MAX_MTU || new_mtu < PHONET_MIN_MTU) - return -EINVAL; - dev->mtu = new_mtu; - - return 0; -} - static void ssip_xmit_work(struct work_struct *work) { struct ssi_protocol *ssi = @@ -1060,7 +1051,6 @@ static const struct net_device_ops ssip_pn_ops = { .ndo_open = ssip_pn_open, .ndo_stop = ssip_pn_stop, .ndo_start_xmit = ssip_pn_xmit, - .ndo_change_mtu = ssip_pn_set_mtu, }; static void ssip_pn_setup(struct net_device *dev) @@ -1136,6 +1126,10 @@ static int ssi_protocol_probe(struct device *dev) goto out1; } + /* MTU range: 6 - 65535 */ + ssi->netdev->min_mtu = PHONET_MIN_MTU; + ssi->netdev->max_mtu = SSIP_MAX_MTU; + SET_NETDEV_DEV(ssi->netdev, dev); netif_carrier_off(ssi->netdev); err = register_netdev(ssi->netdev); diff --git a/drivers/infiniband/hw/nes/nes.c b/drivers/infiniband/hw/nes/nes.c index 35cbb17..2baa45a 100644 --- a/drivers/infiniband/hw/nes/nes.c +++ b/drivers/infiniband/hw/nes/nes.c @@ -65,7 +65,6 @@ MODULE_DESCRIPTION("NetEffect RNIC Low-level iWARP Driver"); MODULE_LICENSE("Dual BSD/GPL"); MODULE_VERSION(DRV_VERSION); -int max_mtu = 9000; int interrupt_mod_interval = 0; /* Interoperability */ diff --git a/drivers/infiniband/hw/nes/nes.h b/drivers/infiniband/hw/nes/nes.h index e7430c9..85acd08 100644 --- a/drivers/infiniband/hw/nes/nes.h +++ b/drivers/infiniband/hw/nes/nes.h @@ -83,6 +83,8 @@ #define NES_FIRST_QPN 64 #define NES_SW_CONTEXT_ALIGN 1024 +#define NES_MAX_MTU 9000 + #define NES_NIC_MAX_NICS 16 #define NES_MAX_ARP_TABLE_SIZE 4096 @@ -169,8 +171,6 @@ do { \ #include "nes_cm.h" #include "nes_mgt.h" -extern int max_mtu; -#define max_frame_len (max_mtu+ETH_HLEN) extern int interrupt_mod_interval; extern int nes_if_count; extern int mpa_version; diff --git a/drivers/infiniband/hw/nes/nes_nic.c b/drivers/infiniband/hw/nes/nes_nic.c index 2b27d13..7f8597d 100644 --- a/drivers/infiniband/hw/nes/nes_nic.c +++ b/drivers/infiniband/hw/nes/nes_nic.c @@ -981,20 +981,16 @@ static int nes_netdev_change_mtu(struct net_device *netdev, int new_mtu) { struct nes_vnic *nesvnic = netdev_priv(netdev); struct nes_device *nesdev = nesvnic->nesdev; - int ret = 0; u8 jumbomode = 0; u32 nic_active; u32 nic_active_bit; u32 uc_all_active; u32 mc_all_active; - if ((new_mtu < ETH_ZLEN) || (new_mtu > max_mtu)) - return -EINVAL; - netdev->mtu = new_mtu; nesvnic->max_frame_size = new_mtu + VLAN_ETH_HLEN; - if (netdev->mtu > 1500) { + if (netdev->mtu > ETH_DATA_LEN) { jumbomode=1; } nes_nic_init_timer_defaults(nesdev, jumbomode); @@ -1020,7 +1016,7 @@ static int nes_netdev_change_mtu(struct net_device *netdev, int new_mtu) nes_write_indexed(nesdev, NES_IDX_NIC_UNICAST_ALL, nic_active); } - return ret; + return 0; } @@ -1658,7 +1654,7 @@ struct net_device *nes_netdev_init(struct nes_device *nesdev, netdev->watchdog_timeo = NES_TX_TIMEOUT; netdev->irq = nesdev->pcidev->irq; - netdev->mtu = ETH_DATA_LEN; + netdev->max_mtu = NES_MAX_MTU; netdev->hard_header_len = ETH_HLEN; netdev->addr_len = ETH_ALEN; netdev->type = ARPHRD_ETHER; diff --git a/drivers/infiniband/ulp/ipoib/ipoib_main.c b/drivers/infiniband/ulp/ipoib/ipoib_main.c index cc05921..ae5d7cd 100644 --- a/drivers/infiniband/ulp/ipoib/ipoib_main.c +++ b/drivers/infiniband/ulp/ipoib/ipoib_main.c @@ -2017,6 +2017,7 @@ static struct net_device *ipoib_add_port(const char *format, /* MTU will be reset when mcast join happens */ priv->dev->mtu = IPOIB_UD_MTU(priv->max_ib_mtu); priv->mcast_mtu = priv->admin_mtu = priv->dev->mtu; + priv->dev->max_mtu = IPOIB_CM_MTU; priv->dev->neigh_priv_len = sizeof(struct ipoib_neigh); diff --git a/drivers/message/fusion/mptlan.c b/drivers/message/fusion/mptlan.c index 6955c9e..55dd71b 100644 --- a/drivers/message/fusion/mptlan.c +++ b/drivers/message/fusion/mptlan.c @@ -549,16 +549,6 @@ mpt_lan_close(struct net_device *dev) } /*=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=*/ -static int -mpt_lan_change_mtu(struct net_device *dev, int new_mtu) -{ - if ((new_mtu < MPT_LAN_MIN_MTU) || (new_mtu > MPT_LAN_MAX_MTU)) - return -EINVAL; - dev->mtu = new_mtu; - return 0; -} - -/*=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=*/ /* Tx timeout handler. */ static void mpt_lan_tx_timeout(struct net_device *dev) @@ -1304,7 +1294,6 @@ static const struct net_device_ops mpt_netdev_ops = { .ndo_open = mpt_lan_open, .ndo_stop = mpt_lan_close, .ndo_start_xmit = mpt_lan_sdu_send, - .ndo_change_mtu = mpt_lan_change_mtu, .ndo_tx_timeout = mpt_lan_tx_timeout, }; @@ -1375,6 +1364,10 @@ mpt_register_lan_device (MPT_ADAPTER *mpt_dev, int pnum) dev->netdev_ops = &mpt_netdev_ops; dev->watchdog_timeo = MPT_LAN_TX_TIMEOUT; + /* MTU range: 96 - 65280 */ + dev->min_mtu = MPT_LAN_MIN_MTU; + dev->max_mtu = MPT_LAN_MAX_MTU; + dlprintk((KERN_INFO MYNAM ": Finished registering dev " "and setting initial values\n")); diff --git a/drivers/misc/sgi-xp/xpnet.c b/drivers/misc/sgi-xp/xpnet.c index 557f978..0c26eaf 100644 --- a/drivers/misc/sgi-xp/xpnet.c +++ b/drivers/misc/sgi-xp/xpnet.c @@ -118,6 +118,8 @@ static DEFINE_SPINLOCK(xpnet_broadcast_lock); * now, the default is 64KB. */ #define XPNET_MAX_MTU (0x800000UL - L1_CACHE_BYTES) +/* 68 comes from min TCP+IP+MAC header */ +#define XPNET_MIN_MTU 68 /* 32KB has been determined to be the ideal */ #define XPNET_DEF_MTU (0x8000UL) @@ -330,22 +332,6 @@ xpnet_dev_stop(struct net_device *dev) return 0; } -static int -xpnet_dev_change_mtu(struct net_device *dev, int new_mtu) -{ - /* 68 comes from min TCP+IP+MAC header */ - if ((new_mtu < 68) || (new_mtu > XPNET_MAX_MTU)) { - dev_err(xpnet, "ifconfig %s mtu %d failed; value must be " - "between 68 and %ld\n", dev->name, new_mtu, - XPNET_MAX_MTU); - return -EINVAL; - } - - dev->mtu = new_mtu; - dev_dbg(xpnet, "ifconfig %s mtu set to %d\n", dev->name, new_mtu); - return 0; -} - /* * Notification that the other end has received the message and * DMA'd the skb information. At this point, they are done with @@ -519,7 +505,6 @@ static const struct net_device_ops xpnet_netdev_ops = { .ndo_open = xpnet_dev_open, .ndo_stop = xpnet_dev_stop, .ndo_start_xmit = xpnet_dev_hard_start_xmit, - .ndo_change_mtu = xpnet_dev_change_mtu, .ndo_tx_timeout = xpnet_dev_tx_timeout, .ndo_set_mac_address = eth_mac_addr, .ndo_validate_addr = eth_validate_addr, @@ -555,6 +540,8 @@ xpnet_init(void) xpnet_device->netdev_ops = &xpnet_netdev_ops; xpnet_device->mtu = XPNET_DEF_MTU; + xpnet_device->min_mtu = XPNET_MIN_MTU; + xpnet_device->max_mtu = XPNET_MAX_MTU; /* * Multicast assumes the LSB of the first octet is set for multicast diff --git a/drivers/net/fddi/skfp/skfddi.c b/drivers/net/fddi/skfp/skfddi.c index 51acc6d..3a63918 100644 --- a/drivers/net/fddi/skfp/skfddi.c +++ b/drivers/net/fddi/skfp/skfddi.c @@ -166,7 +166,6 @@ static const struct net_device_ops skfp_netdev_ops = { .ndo_stop = skfp_close, .ndo_start_xmit = skfp_send_pkt, .ndo_get_stats = skfp_ctl_get_stats, - .ndo_change_mtu = fddi_change_mtu, .ndo_set_rx_mode = skfp_ctl_set_multicast_list, .ndo_set_mac_address = skfp_ctl_set_mac_address, .ndo_do_ioctl = skfp_ioctl, diff --git a/drivers/net/fjes/fjes_main.c b/drivers/net/fjes/fjes_main.c index f36eb4a..b77e4ecf 100644 --- a/drivers/net/fjes/fjes_main.c +++ b/drivers/net/fjes/fjes_main.c @@ -1316,6 +1316,8 @@ static void fjes_netdev_setup(struct net_device *netdev) netdev->netdev_ops = &fjes_netdev_ops; fjes_set_ethtool_ops(netdev); netdev->mtu = fjes_support_mtu[3]; + netdev->min_mtu = fjes_support_mtu[0]; + netdev->max_mtu = fjes_support_mtu[3]; netdev->flags |= IFF_BROADCAST; netdev->features |= NETIF_F_HW_CSUM | NETIF_F_HW_VLAN_CTAG_FILTER; } diff --git a/drivers/net/hippi/rrunner.c b/drivers/net/hippi/rrunner.c index 95c0b45..f5a9728 100644 --- a/drivers/net/hippi/rrunner.c +++ b/drivers/net/hippi/rrunner.c @@ -68,7 +68,6 @@ static const struct net_device_ops rr_netdev_ops = { .ndo_stop = rr_close, .ndo_do_ioctl = rr_ioctl, .ndo_start_xmit = rr_start_xmit, - .ndo_change_mtu = hippi_change_mtu, .ndo_set_mac_address = hippi_mac_addr, }; diff --git a/drivers/net/rionet.c b/drivers/net/rionet.c index a31f461..300bb14 100644 --- a/drivers/net/rionet.c +++ b/drivers/net/rionet.c @@ -466,17 +466,6 @@ static void rionet_set_msglevel(struct net_device *ndev, u32 value) rnet->msg_enable = value; } -static int rionet_change_mtu(struct net_device *ndev, int new_mtu) -{ - if ((new_mtu < 68) || (new_mtu > RIONET_MAX_MTU)) { - printk(KERN_ERR "%s: Invalid MTU size %d\n", - ndev->name, new_mtu); - return -EINVAL; - } - ndev->mtu = new_mtu; - return 0; -} - static const struct ethtool_ops rionet_ethtool_ops = { .get_drvinfo = rionet_get_drvinfo, .get_msglevel = rionet_get_msglevel, @@ -488,7 +477,6 @@ static const struct net_device_ops rionet_netdev_ops = { .ndo_open = rionet_open, .ndo_stop = rionet_close, .ndo_start_xmit = rionet_start_xmit, - .ndo_change_mtu = rionet_change_mtu, .ndo_validate_addr = eth_validate_addr, .ndo_set_mac_address = eth_mac_addr, }; @@ -525,6 +513,9 @@ static int rionet_setup_netdev(struct rio_mport *mport, struct net_device *ndev) ndev->netdev_ops = &rionet_netdev_ops; ndev->mtu = RIONET_MAX_MTU; + /* MTU range: 68 - 4082 */ + ndev->min_mtu = ETH_MIN_MTU; + ndev->max_mtu = RIONET_MAX_MTU; ndev->features = NETIF_F_LLTX; SET_NETDEV_DEV(ndev, &mport->dev); ndev->ethtool_ops = &rionet_ethtool_ops; diff --git a/drivers/net/slip/slip.c b/drivers/net/slip/slip.c index 9ed6d1c..7e933d8 100644 --- a/drivers/net/slip/slip.c +++ b/drivers/net/slip/slip.c @@ -561,12 +561,7 @@ static int sl_change_mtu(struct net_device *dev, int new_mtu) { struct slip *sl = netdev_priv(dev); - if (new_mtu < 68 || new_mtu > 65534) - return -EINVAL; - - if (new_mtu != dev->mtu) - return sl_realloc_bufs(sl, new_mtu); - return 0; + return sl_realloc_bufs(sl, new_mtu); } /* Netdevice get statistics request */ @@ -663,6 +658,10 @@ static void sl_setup(struct net_device *dev) dev->addr_len = 0; dev->tx_queue_len = 10; + /* MTU range: 68 - 65534 */ + dev->min_mtu = 68; + dev->max_mtu = 65534; + /* New-style flags. */ dev->flags = IFF_NOARP|IFF_POINTOPOINT|IFF_MULTICAST; } diff --git a/drivers/usb/gadget/function/f_phonet.c b/drivers/usb/gadget/function/f_phonet.c index 0473d61..b4058f0 100644 --- a/drivers/usb/gadget/function/f_phonet.c +++ b/drivers/usb/gadget/function/f_phonet.c @@ -261,19 +261,10 @@ out: return NETDEV_TX_OK; } -static int pn_net_mtu(struct net_device *dev, int new_mtu) -{ - if ((new_mtu < PHONET_MIN_MTU) || (new_mtu > PHONET_MAX_MTU)) - return -EINVAL; - dev->mtu = new_mtu; - return 0; -} - static const struct net_device_ops pn_netdev_ops = { .ndo_open = pn_net_open, .ndo_stop = pn_net_close, .ndo_start_xmit = pn_net_xmit, - .ndo_change_mtu = pn_net_mtu, }; static void pn_net_setup(struct net_device *dev) @@ -282,6 +273,8 @@ static void pn_net_setup(struct net_device *dev) dev->type = ARPHRD_PHONET; dev->flags = IFF_POINTOPOINT | IFF_NOARP; dev->mtu = PHONET_DEV_MTU; + dev->min_mtu = PHONET_MIN_MTU; + dev->max_mtu = PHONET_MAX_MTU; dev->hard_header_len = 1; dev->dev_addr[0] = PN_MEDIA_USB; dev->addr_len = 1; diff --git a/drivers/usb/gadget/function/u_ether.c b/drivers/usb/gadget/function/u_ether.c index 9c8c9ed..39a6df1 100644 --- a/drivers/usb/gadget/function/u_ether.c +++ b/drivers/usb/gadget/function/u_ether.c @@ -142,15 +142,6 @@ static inline int qlen(struct usb_gadget *gadget, unsigned qmult) /* NETWORK DRIVER HOOKUP (to the layer above this driver) */ -static int ueth_change_mtu(struct net_device *net, int new_mtu) -{ - if (new_mtu <= ETH_HLEN || new_mtu > GETHER_MAX_ETH_FRAME_LEN) - return -ERANGE; - net->mtu = new_mtu; - - return 0; -} - static void eth_get_drvinfo(struct net_device *net, struct ethtool_drvinfo *p) { struct eth_dev *dev = netdev_priv(net); @@ -736,7 +727,6 @@ static const struct net_device_ops eth_netdev_ops = { .ndo_open = eth_open, .ndo_stop = eth_stop, .ndo_start_xmit = eth_start_xmit, - .ndo_change_mtu = ueth_change_mtu, .ndo_set_mac_address = eth_mac_addr, .ndo_validate_addr = eth_validate_addr, }; @@ -799,6 +789,10 @@ struct eth_dev *gether_setup_name(struct usb_gadget *g, net->ethtool_ops = &ops; + /* MTU range: 14 - 15412 */ + net->min_mtu = ETH_HLEN; + net->max_mtu = GETHER_MAX_ETH_FRAME_LEN; + dev->gadget = g; SET_NETDEV_DEV(net, &g->dev); SET_NETDEV_DEVTYPE(net, &gadget_type); diff --git a/include/linux/fddidevice.h b/include/linux/fddidevice.h index 9a79f01..32c22cf 100644 --- a/include/linux/fddidevice.h +++ b/include/linux/fddidevice.h @@ -26,7 +26,6 @@ #ifdef __KERNEL__ __be16 fddi_type_trans(struct sk_buff *skb, struct net_device *dev); -int fddi_change_mtu(struct net_device *dev, int new_mtu); struct net_device *alloc_fddidev(int sizeof_priv); #endif diff --git a/include/linux/hippidevice.h b/include/linux/hippidevice.h index 8ec23fb..402f99e 100644 --- a/include/linux/hippidevice.h +++ b/include/linux/hippidevice.h @@ -32,7 +32,6 @@ struct hippi_cb { }; __be16 hippi_type_trans(struct sk_buff *skb, struct net_device *dev); -int hippi_change_mtu(struct net_device *dev, int new_mtu); int hippi_mac_addr(struct net_device *dev, void *p); int hippi_neigh_setup_dev(struct net_device *dev, struct neigh_parms *p); struct net_device *alloc_hippi_dev(int sizeof_priv); diff --git a/net/802/fddi.c b/net/802/fddi.c index 7d3a0af..6356623 100644 --- a/net/802/fddi.c +++ b/net/802/fddi.c @@ -141,15 +141,6 @@ __be16 fddi_type_trans(struct sk_buff *skb, struct net_device *dev) EXPORT_SYMBOL(fddi_type_trans); -int fddi_change_mtu(struct net_device *dev, int new_mtu) -{ - if ((new_mtu < FDDI_K_SNAP_HLEN) || (new_mtu > FDDI_K_SNAP_DLEN)) - return -EINVAL; - dev->mtu = new_mtu; - return 0; -} -EXPORT_SYMBOL(fddi_change_mtu); - static const struct header_ops fddi_header_ops = { .create = fddi_header, }; @@ -161,6 +152,8 @@ static void fddi_setup(struct net_device *dev) dev->type = ARPHRD_FDDI; dev->hard_header_len = FDDI_K_SNAP_HLEN+3; /* Assume 802.2 SNAP hdr len + 3 pad bytes */ dev->mtu = FDDI_K_SNAP_DLEN; /* Assume max payload of 802.2 SNAP frame */ + dev->min_mtu = FDDI_K_SNAP_HLEN; + dev->max_mtu = FDDI_K_SNAP_DLEN; dev->addr_len = FDDI_K_ALEN; dev->tx_queue_len = 100; /* Long queues on FDDI */ dev->flags = IFF_BROADCAST | IFF_MULTICAST; diff --git a/net/802/hippi.c b/net/802/hippi.c index ade1a52..5e4427b 100644 --- a/net/802/hippi.c +++ b/net/802/hippi.c @@ -116,18 +116,6 @@ __be16 hippi_type_trans(struct sk_buff *skb, struct net_device *dev) EXPORT_SYMBOL(hippi_type_trans); -int hippi_change_mtu(struct net_device *dev, int new_mtu) -{ - /* - * HIPPI's got these nice large MTUs. - */ - if ((new_mtu < 68) || (new_mtu > 65280)) - return -EINVAL; - dev->mtu = new_mtu; - return 0; -} -EXPORT_SYMBOL(hippi_change_mtu); - /* * For HIPPI we will actually use the lower 4 bytes of the hardware * address as the I-FIELD rather than the actual hardware address. @@ -174,6 +162,8 @@ static void hippi_setup(struct net_device *dev) dev->type = ARPHRD_HIPPI; dev->hard_header_len = HIPPI_HLEN; dev->mtu = 65280; + dev->min_mtu = 68; + dev->max_mtu = 65280; dev->addr_len = HIPPI_ALEN; dev->tx_queue_len = 25 /* 5 */; memset(dev->broadcast, 0xFF, HIPPI_ALEN); diff --git a/net/batman-adv/soft-interface.c b/net/batman-adv/soft-interface.c index 49e16b6..112679d 100644 --- a/net/batman-adv/soft-interface.c +++ b/net/batman-adv/soft-interface.c @@ -158,17 +158,6 @@ static int batadv_interface_set_mac_addr(struct net_device *dev, void *p) return 0; } -static int batadv_interface_change_mtu(struct net_device *dev, int new_mtu) -{ - /* check ranges */ - if ((new_mtu < 68) || (new_mtu > batadv_hardif_min_mtu(dev))) - return -EINVAL; - - dev->mtu = new_mtu; - - return 0; -} - /** * batadv_interface_set_rx_mode - set the rx mode of a device * @dev: registered network device to modify @@ -920,7 +909,6 @@ static const struct net_device_ops batadv_netdev_ops = { .ndo_vlan_rx_add_vid = batadv_interface_add_vid, .ndo_vlan_rx_kill_vid = batadv_interface_kill_vid, .ndo_set_mac_address = batadv_interface_set_mac_addr, - .ndo_change_mtu = batadv_interface_change_mtu, .ndo_set_rx_mode = batadv_interface_set_rx_mode, .ndo_start_xmit = batadv_interface_tx, .ndo_validate_addr = eth_validate_addr, @@ -987,6 +975,7 @@ struct net_device *batadv_softif_create(struct net *net, const char *name) dev_net_set(soft_iface, net); soft_iface->rtnl_link_ops = &batadv_link_ops; + soft_iface->max_mtu = batadv_hardif_min_mtu(soft_iface); ret = register_netdevice(soft_iface); if (ret < 0) { diff --git a/net/hsr/hsr_device.c b/net/hsr/hsr_device.c index 16737cd..fc65b14 100644 --- a/net/hsr/hsr_device.c +++ b/net/hsr/hsr_device.c @@ -398,6 +398,7 @@ void hsr_dev_setup(struct net_device *dev) random_ether_addr(dev->dev_addr); ether_setup(dev); + dev->min_mtu = 0; dev->header_ops = &hsr_header_ops; dev->netdev_ops = &hsr_device_ops; SET_NETDEV_DEVTYPE(dev, &hsr_type); diff --git a/net/phonet/pep-gprs.c b/net/phonet/pep-gprs.c index fa8237f..21c28b5 100644 --- a/net/phonet/pep-gprs.c +++ b/net/phonet/pep-gprs.c @@ -217,20 +217,10 @@ static netdev_tx_t gprs_xmit(struct sk_buff *skb, struct net_device *dev) return NETDEV_TX_OK; } -static int gprs_set_mtu(struct net_device *dev, int new_mtu) -{ - if ((new_mtu < 576) || (new_mtu > (PHONET_MAX_MTU - 11))) - return -EINVAL; - - dev->mtu = new_mtu; - return 0; -} - static const struct net_device_ops gprs_netdev_ops = { .ndo_open = gprs_open, .ndo_stop = gprs_close, .ndo_start_xmit = gprs_xmit, - .ndo_change_mtu = gprs_set_mtu, }; static void gprs_setup(struct net_device *dev) @@ -239,6 +229,8 @@ static void gprs_setup(struct net_device *dev) dev->type = ARPHRD_PHONET_PIPE; dev->flags = IFF_POINTOPOINT | IFF_NOARP; dev->mtu = GPRS_DEFAULT_MTU; + dev->min_mtu = 576; + dev->max_mtu = (PHONET_MAX_MTU - 11); dev->hard_header_len = 0; dev->addr_len = 0; dev->tx_queue_len = 10; -- LinuxNextTracking

1 0

Build check errors found: 2016-10-21
by postmaster＠open-mesh.org 21 Oct '16

21 Oct '16

Name of failed tests ==================== next ---- * checkpatch ./net/batman-adv/debugfs.c * checkpatch ./net/batman-adv/icmp_socket.c * checkpatch ./net/batman-adv/log.c * checkpatch ./net/batman-adv/network-coding.c * checkpatch ./net/batman-adv/sysfs.c * difference between net-next and batadv next Output of different failed tests ================================ next: checkpatch ./net/batman-adv/debugfs.c ------------------------------------------- WARNING: Symbolic permissions 'S_IRUGO' are not preferred. Consider using octal permissions '0444'. #189: FILE: ./net/batman-adv/debugfs.c:189: +static BATADV_DEBUGINFO(routing_algos, S_IRUGO, batadv_algorithms_open); WARNING: Symbolic permissions 'S_IRUGO' are not preferred. Consider using octal permissions '0444'. #197: FILE: ./net/batman-adv/debugfs.c:197: +static BATADV_DEBUGINFO(neighbors, S_IRUGO, neighbors_open); WARNING: Symbolic permissions 'S_IRUGO' are not preferred. Consider using octal permissions '0444'. #198: FILE: ./net/batman-adv/debugfs.c:198: +static BATADV_DEBUGINFO(originators, S_IRUGO, batadv_originators_open); WARNING: Symbolic permissions 'S_IRUGO' are not preferred. Consider using octal permissions '0444'. #199: FILE: ./net/batman-adv/debugfs.c:199: +static BATADV_DEBUGINFO(gateways, S_IRUGO, batadv_gateways_open); WARNING: Symbolic permissions 'S_IRUGO' are not preferred. Consider using octal permissions '0444'. #200: FILE: ./net/batman-adv/debugfs.c:200: +static BATADV_DEBUGINFO(transtable_global, S_IRUGO, WARNING: Symbolic permissions 'S_IRUGO' are not preferred. Consider using octal permissions '0444'. #203: FILE: ./net/batman-adv/debugfs.c:203: +static BATADV_DEBUGINFO(bla_claim_table, S_IRUGO, batadv_bla_claim_table_open); WARNING: Symbolic permissions 'S_IRUGO' are not preferred. Consider using octal permissions '0444'. #204: FILE: ./net/batman-adv/debugfs.c:204: +static BATADV_DEBUGINFO(bla_backbone_table, S_IRUGO, WARNING: Symbolic permissions 'S_IRUGO' are not preferred. Consider using octal permissions '0444'. #208: FILE: ./net/batman-adv/debugfs.c:208: +static BATADV_DEBUGINFO(dat_cache, S_IRUGO, batadv_dat_cache_open); WARNING: Symbolic permissions 'S_IRUGO' are not preferred. Consider using octal permissions '0444'. #210: FILE: ./net/batman-adv/debugfs.c:210: +static BATADV_DEBUGINFO(transtable_local, S_IRUGO, WARNING: Symbolic permissions 'S_IRUGO' are not preferred. Consider using octal permissions '0444'. #213: FILE: ./net/batman-adv/debugfs.c:213: +static BATADV_DEBUGINFO(nc_nodes, S_IRUGO, batadv_nc_nodes_open); WARNING: Symbolic permissions 'S_IRUGO' are not preferred. Consider using octal permissions '0444'. #216: FILE: ./net/batman-adv/debugfs.c:216: +static BATADV_DEBUGINFO(mcast_flags, S_IRUGO, batadv_mcast_flags_open); WARNING: Symbolic permissions 'S_IRUGO' are not preferred. Consider using octal permissions '0444'. #256: FILE: ./net/batman-adv/debugfs.c:256: +static BATADV_HARDIF_DEBUGINFO(originators, S_IRUGO, total: 0 errors, 12 warnings, 0 checks, 420 lines checked next: checkpatch ./net/batman-adv/icmp_socket.c ----------------------------------------------- WARNING: Symbolic permissions 'S_IWUSR | S_IRUSR' are not preferred. Consider using octal permissions '0600'. #325: FILE: ./net/batman-adv/icmp_socket.c:325: + d = debugfs_create_file(BATADV_ICMP_SOCKET, S_IFREG | S_IWUSR | S_IRUSR, total: 0 errors, 1 warnings, 0 checks, 407 lines checked next: checkpatch ./net/batman-adv/log.c --------------------------------------- WARNING: Symbolic permissions 'S_IRUSR' are not preferred. Consider using octal permissions '0400'. #215: FILE: ./net/batman-adv/log.c:215: + d = debugfs_create_file("log", S_IFREG | S_IRUSR, total: 0 errors, 1 warnings, 0 checks, 231 lines checked next: checkpatch ./net/batman-adv/network-coding.c -------------------------------------------------- WARNING: Symbolic permissions 'S_IRUGO | S_IWUSR' are not preferred. Consider using octal permissions '0644'. #1964: FILE: ./net/batman-adv/network-coding.c:1964: + file = debugfs_create_u8("min_tq", S_IRUGO | S_IWUSR, nc_dir, WARNING: Symbolic permissions 'S_IRUGO | S_IWUSR' are not preferred. Consider using octal permissions '0644'. #1969: FILE: ./net/batman-adv/network-coding.c:1969: + file = debugfs_create_u32("max_fwd_delay", S_IRUGO | S_IWUSR, nc_dir, WARNING: Symbolic permissions 'S_IRUGO | S_IWUSR' are not preferred. Consider using octal permissions '0644'. #1974: FILE: ./net/batman-adv/network-coding.c:1974: + file = debugfs_create_u32("max_buffer_time", S_IRUGO | S_IWUSR, nc_dir, total: 0 errors, 3 warnings, 0 checks, 1984 lines checked next: checkpatch ./net/batman-adv/sysfs.c ----------------------------------------- WARNING: Symbolic permissions 'S_IRUGO | S_IWUSR' are not preferred. Consider using octal permissions '0644'. #669: FILE: ./net/batman-adv/sysfs.c:669: +BATADV_ATTR_SIF_BOOL(aggregated_ogms, S_IRUGO | S_IWUSR, NULL); WARNING: Symbolic permissions 'S_IRUGO | S_IWUSR' are not preferred. Consider using octal permissions '0644'. #670: FILE: ./net/batman-adv/sysfs.c:670: +BATADV_ATTR_SIF_BOOL(bonding, S_IRUGO | S_IWUSR, NULL); WARNING: Symbolic permissions 'S_IRUGO | S_IWUSR' are not preferred. Consider using octal permissions '0644'. #672: FILE: ./net/batman-adv/sysfs.c:672: +BATADV_ATTR_SIF_BOOL(bridge_loop_avoidance, S_IRUGO | S_IWUSR, WARNING: Symbolic permissions 'S_IRUGO | S_IWUSR' are not preferred. Consider using octal permissions '0644'. #676: FILE: ./net/batman-adv/sysfs.c:676: +BATADV_ATTR_SIF_BOOL(distributed_arp_table, S_IRUGO | S_IWUSR, WARNING: Symbolic permissions 'S_IRUGO | S_IWUSR' are not preferred. Consider using octal permissions '0644'. #679: FILE: ./net/batman-adv/sysfs.c:679: +BATADV_ATTR_SIF_BOOL(fragmentation, S_IRUGO | S_IWUSR, batadv_update_min_mtu); WARNING: Symbolic permissions 'S_IRUGO' are not preferred. Consider using octal permissions '0444'. #680: FILE: ./net/batman-adv/sysfs.c:680: +static BATADV_ATTR(routing_algo, S_IRUGO, batadv_show_bat_algo, NULL); WARNING: Symbolic permissions 'S_IRUGO | S_IWUSR' are not preferred. Consider using octal permissions '0644'. #681: FILE: ./net/batman-adv/sysfs.c:681: +static BATADV_ATTR(gw_mode, S_IRUGO | S_IWUSR, batadv_show_gw_mode, WARNING: Symbolic permissions 'S_IRUGO | S_IWUSR' are not preferred. Consider using octal permissions '0644'. #683: FILE: ./net/batman-adv/sysfs.c:683: +BATADV_ATTR_SIF_UINT(orig_interval, orig_interval, S_IRUGO | S_IWUSR, WARNING: Symbolic permissions 'S_IRUGO | S_IWUSR' are not preferred. Consider using octal permissions '0644'. #685: FILE: ./net/batman-adv/sysfs.c:685: +BATADV_ATTR_SIF_UINT(hop_penalty, hop_penalty, S_IRUGO | S_IWUSR, 0, WARNING: Symbolic permissions 'S_IRUGO | S_IWUSR' are not preferred. Consider using octal permissions '0644'. #687: FILE: ./net/batman-adv/sysfs.c:687: +static BATADV_ATTR(gw_sel_class, S_IRUGO | S_IWUSR, batadv_show_gw_sel_class, WARNING: Symbolic permissions 'S_IRUGO | S_IWUSR' are not preferred. Consider using octal permissions '0644'. #689: FILE: ./net/batman-adv/sysfs.c:689: +static BATADV_ATTR(gw_bandwidth, S_IRUGO | S_IWUSR, batadv_show_gw_bwidth, WARNING: Symbolic permissions 'S_IRUGO | S_IWUSR' are not preferred. Consider using octal permissions '0644'. #692: FILE: ./net/batman-adv/sysfs.c:692: +BATADV_ATTR_SIF_BOOL(multicast_mode, S_IRUGO | S_IWUSR, NULL); WARNING: Symbolic permissions 'S_IRUGO | S_IWUSR' are not preferred. Consider using octal permissions '0644'. #695: FILE: ./net/batman-adv/sysfs.c:695: +BATADV_ATTR_SIF_UINT(log_level, log_level, S_IRUGO | S_IWUSR, 0, WARNING: Symbolic permissions 'S_IRUGO | S_IWUSR' are not preferred. Consider using octal permissions '0644'. #699: FILE: ./net/batman-adv/sysfs.c:699: +BATADV_ATTR_SIF_BOOL(network_coding, S_IRUGO | S_IWUSR, WARNING: Symbolic permissions 'S_IRUGO | S_IWUSR' are not preferred. Consider using octal permissions '0644'. #702: FILE: ./net/batman-adv/sysfs.c:702: +static BATADV_ATTR(isolation_mark, S_IRUGO | S_IWUSR, WARNING: Symbolic permissions 'S_IRUGO | S_IWUSR' are not preferred. Consider using octal permissions '0644'. #734: FILE: ./net/batman-adv/sysfs.c:734: +BATADV_ATTR_VLAN_BOOL(ap_isolation, S_IRUGO | S_IWUSR, NULL); WARNING: Symbolic permissions 'S_IRUGO | S_IWUSR' are not preferred. Consider using octal permissions '0644'. #1119: FILE: ./net/batman-adv/sysfs.c:1119: +static BATADV_ATTR(mesh_iface, S_IRUGO | S_IWUSR, batadv_show_mesh_iface, WARNING: Symbolic permissions 'S_IRUGO' are not preferred. Consider using octal permissions '0444'. #1121: FILE: ./net/batman-adv/sysfs.c:1121: +static BATADV_ATTR(iface_status, S_IRUGO, batadv_show_iface_status, NULL); WARNING: Symbolic permissions 'S_IRUGO | S_IWUSR' are not preferred. Consider using octal permissions '0644'. #1123: FILE: ./net/batman-adv/sysfs.c:1123: +BATADV_ATTR_HIF_UINT(elp_interval, bat_v.elp_interval, S_IRUGO | S_IWUSR, WARNING: Symbolic permissions 'S_IRUGO | S_IWUSR' are not preferred. Consider using octal permissions '0644'. #1125: FILE: ./net/batman-adv/sysfs.c:1125: +static BATADV_ATTR(throughput_override, S_IRUGO | S_IWUSR, total: 0 errors, 20 warnings, 0 checks, 1224 lines checked next: difference between net-next and batadv next ------------------------------------------------- netnext/net/batman-adv/log.h | 2 +- netnext/net/batman-adv/originator.c | 2 +- netnext/net/batman-adv/soft-interface.c | 13 +------------ 3 files changed, 3 insertions(+), 14 deletions(-) Statistics ========== master ------ Failed tests: 0 Started build tests: 114 Tested Linux versions: 27 Tested configs: 75 next ---- Failed tests: 6 Started build tests: 126 Tested Linux versions: 27 Tested configs: 80

1 0

2024

2023

2022

2021

2020

2019

2018

2017

2016

2015

2014

2013

2012

2011

linux-merge October 2016