Your request for analysis of batctl has been completed successfully.
The results are available at https://scan.coverity.com/projects/batctl
Analysis Summary:
New defects found: 0
Defects eliminated: 0
Your request for analysis of alfred has been completed successfully.
The results are available at https://scan.coverity.com/projects/alfred
Analysis Summary:
New defects found: 0
Defects eliminated: 0
--- batman-adv_next.packet.h 2015-11-27 00:05:01.203648577 +0100
+++ batctl_next.packet.h 2015-11-27 00:05:01.211649058 +0100
@@ -72,7 +72,8 @@
* enum batadv_iv_flags - flags used in B.A.T.M.A.N. IV OGM packets
* @BATADV_NOT_BEST_NEXT_HOP: flag is set when ogm packet is forwarded and was
* previously received from someone else than the best neighbor.
- * @BATADV_PRIMARIES_FIRST_HOP: flag unused.
+ * @BATADV_PRIMARIES_FIRST_HOP: flag is set when the primary interface address
+ * is used, and the packet travels its first hop.
* @BATADV_DIRECTLINK: flag is for the first hop or if rebroadcasted from a
* one hop neighbor on the interface where it was originally received.
*/
@@ -158,7 +159,7 @@
};
/**
- * enum batadv_vlan_flags - flags for the four MSB of any vlan ID field
+ * batadv_vlan_flags - flags for the four MSB of any vlan ID field
* @BATADV_VLAN_HAS_TAG: whether the field contains a valid vlan tag or not
*/
enum batadv_vlan_flags {
@@ -209,11 +210,6 @@
* @version: batman-adv protocol version, part of the genereal header
* @ttl: time to live for this packet, part of the genereal header
* @flags: contains routing relevant flags - see enum batadv_iv_flags
- * @seqno: sequence identification
- * @orig: address of the source node
- * @prev_sender: address of the previous sender
- * @reserved: reserved byte for alignment
- * @tq: transmission quality
* @tvlv_len: length of tvlv data following the ogm header
*/
struct batadv_ogm_packet {
@@ -235,7 +231,7 @@
#define BATADV_OGM_HLEN sizeof(struct batadv_ogm_packet)
/**
- * struct batadv_icmp_header - common members among all the ICMP packets
+ * batadv_icmp_header - common members among all the ICMP packets
* @packet_type: batman-adv packet type, part of the general header
* @version: batman-adv protocol version, part of the genereal header
* @ttl: time to live for this packet, part of the genereal header
@@ -261,7 +257,7 @@
};
/**
- * struct batadv_icmp_packet - ICMP packet
+ * batadv_icmp_packet - ICMP packet
* @packet_type: batman-adv packet type, part of the general header
* @version: batman-adv protocol version, part of the genereal header
* @ttl: time to live for this packet, part of the genereal header
@@ -287,7 +283,7 @@
#define BATADV_RR_LEN 16
/**
- * struct batadv_icmp_packet_rr - ICMP RouteRecord packet
+ * batadv_icmp_packet_rr - ICMP RouteRecord packet
* @packet_type: batman-adv packet type, part of the general header
* @version: batman-adv protocol version, part of the genereal header
* @ttl: time to live for this packet, part of the genereal header
@@ -350,7 +346,6 @@
* @u: common unicast packet header
* @src: address of the source
* @subtype: packet subtype
- * @reserved: reserved byte for alignment
*/
struct batadv_unicast_4addr_packet {
struct batadv_unicast_packet u;
@@ -419,6 +414,7 @@
* @packet_type: batman-adv packet type, part of the general header
* @version: batman-adv protocol version, part of the genereal header
* @ttl: time to live for this packet, part of the genereal header
+ * @reserved: Align following fields to 2-byte boundaries
* @first_source: original source of first included packet
* @first_orig_dest: original destinal of first included packet
* @first_crc: checksum of first included packet
@@ -500,7 +496,7 @@
* struct batadv_tvlv_tt_data - tt data propagated through the tt tvlv container
* @flags: translation table flags (see batadv_tt_data_flags)
* @ttvn: translation table version number
- * @num_vlan: number of announced VLANs. In the TVLV this struct is followed by
+ * @vlan_num: number of announced VLANs. In the TVLV this struct is followed by
* one batadv_tvlv_tt_vlan_data object per announced vlan
*/
struct batadv_tvlv_tt_data {
Name of failed tests
====================
* checkpatch next ./net/batman-adv/gateway_common.c
* checkpatch next ./net/batman-adv/main.c
* difference between net-next and batadv next
Output of different failed tests
================================
checkpatch next ./net/batman-adv/gateway_common.c
-------------------------------------------------
WARNING: Comparisons should place the constant on the right side of the test
#92: FILE: ./net/batman-adv/gateway_common.c:92:
+ if (U32_MAX < ldown) {
WARNING: Comparisons should place the constant on the right side of the test
#142: FILE: ./net/batman-adv/gateway_common.c:142:
+ if (U32_MAX < lup) {
total: 0 errors, 2 warnings, 0 checks, 287 lines checked
checkpatch next ./net/batman-adv/main.c
---------------------------------------
CHECK: 'wether' may be misspelled - perhaps 'whether'?
#911: FILE: ./net/batman-adv/main.c:911:
+ * @ogm_source: flag indicating wether the tvlv is an ogm or a unicast packet
CHECK: 'wether' may be misspelled - perhaps 'whether'?
#964: FILE: ./net/batman-adv/main.c:964:
+ * @ogm_source: flag indicating wether the tvlv is an ogm or a unicast packet
total: 0 errors, 0 warnings, 2 checks, 1284 lines checked
difference between net-next and batadv next
-------------------------------------------
net/batman-adv/bridge_loop_avoidance.c | 35 +++---------------------
net/batman-adv/distributed-arp-table.c | 5 ---
net/batman-adv/routing.c | 19 ++-----------
net/batman-adv/translation-table.c | 30 +++-----------------
net/batman-adv/types.h | 2 -
5 files changed, 15 insertions(+), 76 deletions(-)
Name of failed tests
====================
* checkpatch next ./net/batman-adv/gateway_common.c
* checkpatch next ./net/batman-adv/main.c
* difference between net-next and batadv next
Output of different failed tests
================================
checkpatch next ./net/batman-adv/gateway_common.c
-------------------------------------------------
WARNING: Comparisons should place the constant on the right side of the test
#92: FILE: ./net/batman-adv/gateway_common.c:92:
+ if (U32_MAX < ldown) {
WARNING: Comparisons should place the constant on the right side of the test
#142: FILE: ./net/batman-adv/gateway_common.c:142:
+ if (U32_MAX < lup) {
total: 0 errors, 2 warnings, 0 checks, 287 lines checked
checkpatch next ./net/batman-adv/main.c
---------------------------------------
CHECK: 'wether' may be misspelled - perhaps 'whether'?
#911: FILE: ./net/batman-adv/main.c:911:
+ * @ogm_source: flag indicating wether the tvlv is an ogm or a unicast packet
CHECK: 'wether' may be misspelled - perhaps 'whether'?
#964: FILE: ./net/batman-adv/main.c:964:
+ * @ogm_source: flag indicating wether the tvlv is an ogm or a unicast packet
total: 0 errors, 0 warnings, 2 checks, 1284 lines checked
difference between net-next and batadv next
-------------------------------------------
net/batman-adv/bridge_loop_avoidance.c | 35 +++---------------------
net/batman-adv/distributed-arp-table.c | 5 ---
net/batman-adv/routing.c | 19 ++-----------
net/batman-adv/translation-table.c | 30 +++-----------------
net/batman-adv/types.h | 2 -
5 files changed, 15 insertions(+), 76 deletions(-)
Name of failed tests
====================
* bracket_align ecsv/batv_4 ./net/batman-adv/bat_v_elp.c
* checkpatch ecsv/batv_4 ./net/batman-adv/bat_v_elp.c
Output of different failed tests
================================
bracket_align ecsv/batv_4 ./net/batman-adv/bat_v_elp.c
------------------------------------------------------
Found wrong alignment at ./net/batman-adv/bat_v_elp.c:276, was 1 but expected 37
Found wrong alignment at ./net/batman-adv/bat_v_elp.c:278, was 1 but expected 28
Found wrong alignment at ./net/batman-adv/bat_v_elp.c:279, was 1 but expected 28
checkpatch ecsv/batv_4 ./net/batman-adv/bat_v_elp.c
---------------------------------------------------
ERROR: do not use C99 // comments
#274: FILE: ./net/batman-adv/bat_v_elp.c:274:
+// TODO: host restarted ?
WARNING: please, no space before tabs
#275: FILE: ./net/batman-adv/bat_v_elp.c:275:
+// ^Iif (batadv_window_protected(bat_priv, seqno_diff,$
ERROR: do not use C99 // comments
#275: FILE: ./net/batman-adv/bat_v_elp.c:275:
+// if (batadv_window_protected(bat_priv, seqno_diff,
WARNING: please, no space before tabs
#276: FILE: ./net/batman-adv/bat_v_elp.c:276:
+// ^I^I^I^I &neigh->batman_seqno_reset)) {$
ERROR: do not use C99 // comments
#276: FILE: ./net/batman-adv/bat_v_elp.c:276:
+// &neigh->batman_seqno_reset)) {
WARNING: please, no space before tabs
#277: FILE: ./net/batman-adv/bat_v_elp.c:277:
+// ^I^Ibatadv_dbg(BATADV_DBG_BATMAN, bat_priv,$
ERROR: do not use C99 // comments
#277: FILE: ./net/batman-adv/bat_v_elp.c:277:
+// batadv_dbg(BATADV_DBG_BATMAN, bat_priv,
WARNING: line over 80 characters
#278: FILE: ./net/batman-adv/bat_v_elp.c:278:
+// "Drop ELP packet: packet within window protection time from %pM\n",
WARNING: please, no space before tabs
#278: FILE: ./net/batman-adv/bat_v_elp.c:278:
+// ^I^I^I "Drop ELP packet: packet within window protection time from %pM\n",$
ERROR: do not use C99 // comments
#278: FILE: ./net/batman-adv/bat_v_elp.c:278:
+// "Drop ELP packet: packet within window protection time from %pM\n",
WARNING: please, no space before tabs
#279: FILE: ./net/batman-adv/bat_v_elp.c:279:
+// ^I^I^I elp_packet->orig);$
ERROR: do not use C99 // comments
#279: FILE: ./net/batman-adv/bat_v_elp.c:279:
+// elp_packet->orig);
WARNING: please, no space before tabs
#280: FILE: ./net/batman-adv/bat_v_elp.c:280:
+// ^I^Igoto out;$
ERROR: do not use C99 // comments
#280: FILE: ./net/batman-adv/bat_v_elp.c:280:
+// goto out;
WARNING: please, no space before tabs
#281: FILE: ./net/batman-adv/bat_v_elp.c:281:
+// ^I}$
ERROR: do not use C99 // comments
#281: FILE: ./net/batman-adv/bat_v_elp.c:281:
+// }
total: 8 errors, 8 warnings, 0 checks, 352 lines checked
Name of failed tests
====================
* bracket_align ecsv/batv_3 ./net/batman-adv/bat_v_elp.c
* checkpatch ecsv/batv_3 ./net/batman-adv/bat_v_elp.c
Output of different failed tests
================================
bracket_align ecsv/batv_3 ./net/batman-adv/bat_v_elp.c
------------------------------------------------------
Found wrong alignment at ./net/batman-adv/bat_v_elp.c:276, was 1 but expected 37
Found wrong alignment at ./net/batman-adv/bat_v_elp.c:278, was 1 but expected 28
Found wrong alignment at ./net/batman-adv/bat_v_elp.c:279, was 1 but expected 28
checkpatch ecsv/batv_3 ./net/batman-adv/bat_v_elp.c
---------------------------------------------------
ERROR: do not use C99 // comments
#274: FILE: ./net/batman-adv/bat_v_elp.c:274:
+// TODO: host restarted ?
WARNING: please, no space before tabs
#275: FILE: ./net/batman-adv/bat_v_elp.c:275:
+// ^Iif (batadv_window_protected(bat_priv, seqno_diff,$
ERROR: do not use C99 // comments
#275: FILE: ./net/batman-adv/bat_v_elp.c:275:
+// if (batadv_window_protected(bat_priv, seqno_diff,
WARNING: please, no space before tabs
#276: FILE: ./net/batman-adv/bat_v_elp.c:276:
+// ^I^I^I^I &neigh->batman_seqno_reset)) {$
ERROR: do not use C99 // comments
#276: FILE: ./net/batman-adv/bat_v_elp.c:276:
+// &neigh->batman_seqno_reset)) {
WARNING: please, no space before tabs
#277: FILE: ./net/batman-adv/bat_v_elp.c:277:
+// ^I^Ibatadv_dbg(BATADV_DBG_BATMAN, bat_priv,$
ERROR: do not use C99 // comments
#277: FILE: ./net/batman-adv/bat_v_elp.c:277:
+// batadv_dbg(BATADV_DBG_BATMAN, bat_priv,
WARNING: line over 80 characters
#278: FILE: ./net/batman-adv/bat_v_elp.c:278:
+// "Drop ELP packet: packet within window protection time from %pM\n",
WARNING: please, no space before tabs
#278: FILE: ./net/batman-adv/bat_v_elp.c:278:
+// ^I^I^I "Drop ELP packet: packet within window protection time from %pM\n",$
ERROR: do not use C99 // comments
#278: FILE: ./net/batman-adv/bat_v_elp.c:278:
+// "Drop ELP packet: packet within window protection time from %pM\n",
WARNING: please, no space before tabs
#279: FILE: ./net/batman-adv/bat_v_elp.c:279:
+// ^I^I^I elp_packet->orig);$
ERROR: do not use C99 // comments
#279: FILE: ./net/batman-adv/bat_v_elp.c:279:
+// elp_packet->orig);
WARNING: please, no space before tabs
#280: FILE: ./net/batman-adv/bat_v_elp.c:280:
+// ^I^Igoto out;$
ERROR: do not use C99 // comments
#280: FILE: ./net/batman-adv/bat_v_elp.c:280:
+// goto out;
WARNING: please, no space before tabs
#281: FILE: ./net/batman-adv/bat_v_elp.c:281:
+// ^I}$
ERROR: do not use C99 // comments
#281: FILE: ./net/batman-adv/bat_v_elp.c:281:
+// }
total: 8 errors, 8 warnings, 0 checks, 352 lines checked
Name of failed tests
====================
* bracket_align ecsv/batv_2 ./net/batman-adv/bat_v_elp.c
* checkpatch ecsv/batv_2 ./net/batman-adv/bat_v_elp.c
Output of different failed tests
================================
bracket_align ecsv/batv_2 ./net/batman-adv/bat_v_elp.c
------------------------------------------------------
Found wrong alignment at ./net/batman-adv/bat_v_elp.c:276, was 1 but expected 37
Found wrong alignment at ./net/batman-adv/bat_v_elp.c:278, was 1 but expected 28
Found wrong alignment at ./net/batman-adv/bat_v_elp.c:279, was 1 but expected 28
checkpatch ecsv/batv_2 ./net/batman-adv/bat_v_elp.c
---------------------------------------------------
ERROR: do not use C99 // comments
#274: FILE: ./net/batman-adv/bat_v_elp.c:274:
+// TODO: host restarted ?
WARNING: please, no space before tabs
#275: FILE: ./net/batman-adv/bat_v_elp.c:275:
+// ^Iif (batadv_window_protected(bat_priv, seqno_diff,$
ERROR: do not use C99 // comments
#275: FILE: ./net/batman-adv/bat_v_elp.c:275:
+// if (batadv_window_protected(bat_priv, seqno_diff,
WARNING: please, no space before tabs
#276: FILE: ./net/batman-adv/bat_v_elp.c:276:
+// ^I^I^I^I &neigh->batman_seqno_reset)) {$
ERROR: do not use C99 // comments
#276: FILE: ./net/batman-adv/bat_v_elp.c:276:
+// &neigh->batman_seqno_reset)) {
WARNING: please, no space before tabs
#277: FILE: ./net/batman-adv/bat_v_elp.c:277:
+// ^I^Ibatadv_dbg(BATADV_DBG_BATMAN, bat_priv,$
ERROR: do not use C99 // comments
#277: FILE: ./net/batman-adv/bat_v_elp.c:277:
+// batadv_dbg(BATADV_DBG_BATMAN, bat_priv,
WARNING: line over 80 characters
#278: FILE: ./net/batman-adv/bat_v_elp.c:278:
+// "Drop ELP packet: packet within window protection time from %pM\n",
WARNING: please, no space before tabs
#278: FILE: ./net/batman-adv/bat_v_elp.c:278:
+// ^I^I^I "Drop ELP packet: packet within window protection time from %pM\n",$
ERROR: do not use C99 // comments
#278: FILE: ./net/batman-adv/bat_v_elp.c:278:
+// "Drop ELP packet: packet within window protection time from %pM\n",
WARNING: please, no space before tabs
#279: FILE: ./net/batman-adv/bat_v_elp.c:279:
+// ^I^I^I elp_packet->orig);$
ERROR: do not use C99 // comments
#279: FILE: ./net/batman-adv/bat_v_elp.c:279:
+// elp_packet->orig);
WARNING: please, no space before tabs
#280: FILE: ./net/batman-adv/bat_v_elp.c:280:
+// ^I^Igoto out;$
ERROR: do not use C99 // comments
#280: FILE: ./net/batman-adv/bat_v_elp.c:280:
+// goto out;
WARNING: please, no space before tabs
#281: FILE: ./net/batman-adv/bat_v_elp.c:281:
+// ^I}$
ERROR: do not use C99 // comments
#281: FILE: ./net/batman-adv/bat_v_elp.c:281:
+// }
total: 8 errors, 8 warnings, 0 checks, 352 lines checked
Name of failed tests
====================
* checkpatch next ./net/batman-adv/gateway_common.c
* checkpatch next ./net/batman-adv/main.c
* difference between net-next and batadv next
Output of different failed tests
================================
checkpatch next ./net/batman-adv/gateway_common.c
-------------------------------------------------
WARNING: Comparisons should place the constant on the right side of the test
#92: FILE: ./net/batman-adv/gateway_common.c:92:
+ if (U32_MAX < ldown) {
WARNING: Comparisons should place the constant on the right side of the test
#142: FILE: ./net/batman-adv/gateway_common.c:142:
+ if (U32_MAX < lup) {
total: 0 errors, 2 warnings, 0 checks, 287 lines checked
checkpatch next ./net/batman-adv/main.c
---------------------------------------
CHECK: 'wether' may be misspelled - perhaps 'whether'?
#911: FILE: ./net/batman-adv/main.c:911:
+ * @ogm_source: flag indicating wether the tvlv is an ogm or a unicast packet
CHECK: 'wether' may be misspelled - perhaps 'whether'?
#964: FILE: ./net/batman-adv/main.c:964:
+ * @ogm_source: flag indicating wether the tvlv is an ogm or a unicast packet
total: 0 errors, 0 warnings, 2 checks, 1284 lines checked
difference between net-next and batadv next
-------------------------------------------
net/batman-adv/bridge_loop_avoidance.c | 35 +++---------------------
net/batman-adv/distributed-arp-table.c | 5 ---
net/batman-adv/routing.c | 19 ++-----------
net/batman-adv/translation-table.c | 30 +++-----------------
net/batman-adv/types.h | 2 -
5 files changed, 15 insertions(+), 76 deletions(-)