linux-merge February 2012

linux-merge@lists.open-mesh.org

2 participants
123 discussions

Failed check master routing.c
by postmaster＠open-mesh.org 27 Feb '12

27 Feb '12

CHECK: Alignment should match open parenthesis #79: FILE: routing.c:79: + tt_global_del_orig(bat_priv, orig_node, + "Deleted route towards originator"); CHECK: Logical continuations should be on the previous line #237: FILE: routing.c:237: + if ((seq_num_diff <= -TQ_LOCAL_WINDOW_SIZE) + || (seq_num_diff >= EXPECTED_SEQNO_RANGE)) { CHECK: Alignment should match open parenthesis #436: FILE: routing.c:436: + memcpy(&(icmp_packet->rr[icmp_packet->rr_cur]), + ethhdr->h_dest, ETH_ALEN); total: 0 errors, 0 warnings, 3 checks, 1155 lines checked NOTE: Ignored message types: COMPLEX_MACRO routing.c has style problems, please review. If any of these errors are false positives, please report them to the maintainer, see CHECKPATCH in MAINTAINERS.

1 0

Failed check master originator.c
by postmaster＠open-mesh.org 27 Feb '12

27 Feb '12

CHECK: Alignment should match open parenthesis #148: FILE: originator.c:148: + tt_global_del_orig(orig_node->bat_priv, orig_node, + "originator timed out"); CHECK: Alignment should match open parenthesis #339: FILE: originator.c:339: + if (purge_orig_neighbors(bat_priv, orig_node, + &best_neigh_node)) { total: 0 errors, 0 warnings, 2 checks, 649 lines checked NOTE: Ignored message types: COMPLEX_MACRO originator.c has style problems, please review. If any of these errors are false positives, please report them to the maintainer, see CHECKPATCH in MAINTAINERS.

1 0

Failed check master hard-interface.c
by postmaster＠open-mesh.org 27 Feb '12

27 Feb '12

CHECK: Alignment should match open parenthesis #346: FILE: hard-interface.c:346: + bat_info(hard_iface->soft_iface, + "The MTU of interface %s is too small (%i) to handle " CHECK: Alignment should match open parenthesis #357: FILE: hard-interface.c:357: + bat_info(hard_iface->soft_iface, + "The MTU of interface %s is too small (%i) to handle " total: 0 errors, 0 warnings, 2 checks, 710 lines checked NOTE: Ignored message types: COMPLEX_MACRO hard-interface.c has style problems, please review. If any of these errors are false positives, please report them to the maintainer, see CHECKPATCH in MAINTAINERS.

1 0

Failed check master gateway_client.c
by postmaster＠open-mesh.org 27 Feb '12

27 Feb '12

CHECK: Alignment should match open parenthesis #632: FILE: gateway_client.c:632: + if ((ntohs(ethhdr->h_proto) == ETH_P_IP) && + (ntohs(udphdr->dest) != 67)) total: 0 errors, 0 warnings, 1 checks, 714 lines checked NOTE: Ignored message types: COMPLEX_MACRO gateway_client.c has style problems, please review. If any of these errors are false positives, please report them to the maintainer, see CHECKPATCH in MAINTAINERS.

1 0

Failed check master gateway_common.c
by postmaster＠open-mesh.org 27 Feb '12

27 Feb '12

CHECK: Alignment should match open parenthesis #96: FILE: gateway_common.c:96: + if ((strnicmp(tmp_ptr, "kbit", 4) == 0) || + (multi > 1)) CHECK: Alignment should match open parenthesis #121: FILE: gateway_common.c:121: + if ((strnicmp(tmp_ptr, "kbit", 4) == 0) || + (multi > 1)) total: 0 errors, 0 warnings, 2 checks, 178 lines checked NOTE: Ignored message types: COMPLEX_MACRO gateway_common.c has style problems, please review. If any of these errors are false positives, please report them to the maintainer, see CHECKPATCH in MAINTAINERS.

1 0

Failed check master distributed-arp-table.c
by postmaster＠open-mesh.org 27 Feb '12

27 Feb '12

CHECK: Alignment should match open parenthesis #336: FILE: distributed-arp-table.c:336: + if (ipv4_is_loopback(ARP_IP_SRC(skb, hdr_size)) || + ipv4_is_multicast(ARP_IP_SRC(skb, hdr_size)) || CHECK: Alignment should match open parenthesis #541: FILE: distributed-arp-table.c:541: + if (!forw_packet->num_packets && + (arp_get_type(bat_priv, forw_packet->skb, total: 0 errors, 0 warnings, 2 checks, 580 lines checked NOTE: Ignored message types: COMPLEX_MACRO distributed-arp-table.c has style problems, please review. If any of these errors are false positives, please report them to the maintainer, see CHECKPATCH in MAINTAINERS.

1 0

Failed check master bitarray.c
by postmaster＠open-mesh.org 27 Feb '12

27 Feb '12

CHECK: Logical continuations should be on the previous line #71: FILE: bitarray.c:71: + if ((seq_num_diff >= TQ_LOCAL_WINDOW_SIZE) + && (seq_num_diff < EXPECTED_SEQNO_RANGE)) { CHECK: Logical continuations should be on the previous line #87: FILE: bitarray.c:87: + if ((seq_num_diff <= -TQ_LOCAL_WINDOW_SIZE) + || (seq_num_diff >= EXPECTED_SEQNO_RANGE)) { total: 0 errors, 0 warnings, 2 checks, 101 lines checked NOTE: Ignored message types: COMPLEX_MACRO bitarray.c has style problems, please review. If any of these errors are false positives, please report them to the maintainer, see CHECKPATCH in MAINTAINERS.

1 0

Failed check master bat_sysfs.c
by postmaster＠open-mesh.org 27 Feb '12

27 Feb '12

CHECK: Alignment should match open parenthesis #324: FILE: bat_sysfs.c:324: + if (strncmp(buff, GW_MODE_CLIENT_NAME, + strlen(GW_MODE_CLIENT_NAME)) == 0) CHECK: Alignment should match open parenthesis #328: FILE: bat_sysfs.c:328: + if (strncmp(buff, GW_MODE_SERVER_NAME, + strlen(GW_MODE_SERVER_NAME)) == 0) total: 0 errors, 0 warnings, 2 checks, 691 lines checked NOTE: Ignored message types: COMPLEX_MACRO bat_sysfs.c has style problems, please review. If any of these errors are false positives, please report them to the maintainer, see CHECKPATCH in MAINTAINERS.

1 0

Failed cppcheck for master
by postmaster＠open-mesh.org 27 Feb '12

27 Feb '12

[soft-interface.c:262]: (style) Variable 'unicast_4addr_packet' is assigned a value that is never used

1 0

Noticed difference in packet.h in master.diff
by postmaster＠open-mesh.org 27 Feb '12

27 Feb '12

--- batman-adv_master.packet.h 2012-02-28 00:15:01.257917466 +0100 +++ batctl_master.packet.h 2012-02-28 00:15:01.261775906 +0100 @@ -25,22 +25,14 @@ #define ETH_P_BATMAN 0x4305 /* unofficial/not registered Ethertype */ enum bat_packettype { - BAT_IV_OGM = 0x01, - BAT_ICMP = 0x02, - BAT_UNICAST = 0x03, - BAT_BCAST = 0x04, - BAT_VIS = 0x05, - BAT_UNICAST_FRAG = 0x06, - BAT_TT_QUERY = 0x07, - BAT_ROAM_ADV = 0x08, - BAT_UNICAST_4ADDR = 0x09 -}; - -enum bat_subtype { - BAT_P_DATA = 0x01, - BAT_P_DAT_DHT_GET = 0x02, - BAT_P_DAT_DHT_PUT = 0x03, - BAT_P_DAT_CACHE_REPLY = 0x04 + BAT_IV_OGM = 0x01, + BAT_ICMP = 0x02, + BAT_UNICAST = 0x03, + BAT_BCAST = 0x04, + BAT_VIS = 0x05, + BAT_UNICAST_FRAG = 0x06, + BAT_TT_QUERY = 0x07, + BAT_ROAM_ADV = 0x08 }; /* this file is included by batctl which needs these defines */ @@ -166,12 +158,6 @@ uint8_t dest[ETH_ALEN]; } __packed; -struct unicast_4addr_packet { - struct unicast_packet u; - uint8_t src[ETH_ALEN]; - uint8_t subtype; -} __packed; - struct unicast_frag_packet { struct batman_header header; uint8_t ttvn; /* destination translation table version number */

1 0

2024

2023

2022

2021

2020

2019

2018

2017

2016

2015

2014

2013

2012

2011

linux-merge February 2012