Repository : ssh://git@open-mesh.org/batman-adv
On branch : master
commit 333d1de903c128f0c33fb532898b3f940139895a Author: Sven Eckelmann sven@narfation.org Date: Fri Jul 15 17:39:16 2016 +0200
batman-adv: Place kref_get for orig_node_vlan near use
It is hard to understand why the refcnt is increased when it isn't done near the actual place the new reference is used. So using kref_get right before the place which requires the reference and in the same function helps to avoid accidental problems causedy incorrect reference counting.
Signed-off-by: Sven Eckelmann sven@narfation.org Signed-off-by: Marek Lindner mareklindner@neomailbox.ch
333d1de903c128f0c33fb532898b3f940139895a net/batman-adv/originator.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/net/batman-adv/originator.c b/net/batman-adv/originator.c index 95c8555..5108af1 100644 --- a/net/batman-adv/originator.c +++ b/net/batman-adv/originator.c @@ -133,9 +133,9 @@ batadv_orig_node_vlan_new(struct batadv_orig_node *orig_node, goto out;
kref_init(&vlan->refcount); - kref_get(&vlan->refcount); vlan->vid = vid;
+ kref_get(&vlan->refcount); hlist_add_head_rcu(&vlan->list, &orig_node->vlan_list);
out: