commits March 2018

commits@lists.open-mesh.org

1 participants
46 discussions

[linux-merge]linux integration; annotated tag, v4.16-rc7, created. v4.16-rc7
by postmaster＠open-mesh.org 26 Mar '18

26 Mar '18

The annotated tag, v4.16-rc7 has been created at a1fbb3e9a14d2073b62404ff87bf3d1c077579ea (tag) tagging 3eb2ce825ea1ad89d20f7a3b5780df850e4be274 (commit) replaces v4.16-rc6 tagged by Linus Torvalds on Sun Mar 25 12:44:46 2018 -1000 - Shortlog ------------------------------------------------------------ Linux 4.16-rc7 -----BEGIN PGP SIGNATURE----- iQEcBAABAgAGBQJauCZfAAoJEHm+PkMAQRiGWGUH/2rhdQDkoJpYWnjaQkolECG8 MxpGE7nmIIHxQcbSDdHTGJ8IhVm6Z5wZ7ym/PwCDTT043Y1y341sJrIwL2/nTG6d HVidk8hFvgN6QzlzVAHT3ZZMII/V9Zt+VV5SUYLGnPAVuJNHo/6uzWlTU5g+NTFo IquFDdQUaGBlkKqby+NoAFnkV1UAIkW0g22cfvPnlO5GMer0gusGyVNvVp7TNj3C sqj4Hvt3RMDLMNe9RZ2pFTiOD096n8FWpYftZneUTxFImhRV3Jg5MaaYZm9SI3HW tXrv/LChT/F1mi5Pkx6tkT5Hr8WvcrwDMJ4It1kom10RqWAgjxIR3CMm448ileY= =YKUG -----END PGP SIGNATURE----- Linus Lüssing (1): batman-adv: Fix multicast packet loss with a single WANT_ALL_IPV4/6 flag Matthias Schiffer (2): batman-adv: update data pointers after skb_cow() batman-adv: fix header size check in batadv_dbg_arp() Sven Eckelmann (2): batman-adv: Add missing include for EPOLL* constants batman-adv: Fix skbuff rcsum on packet reroute ----------------------------------------------------------------------- -- linux integration

1 0

[linux-merge]linux integration; annotated tag, batadv-next-for-davem-20180326, created. batadv-next-for-davem-20180326
by postmaster＠open-mesh.org 26 Mar '18

26 Mar '18

The annotated tag, batadv-next-for-davem-20180326 has been created at cb2aa997bf85703ac7fb40261cb0818550bf11a2 (tag) tagging d5863c47d7255448ec01713cbdb4f94b370d86ad (commit) replaces v4.16-rc1 tagged by Simon Wunderlich on Mon Mar 26 14:51:07 2018 +0200 - Shortlog ------------------------------------------------------------ Here is a regression fix introduced by our last pull request: - do not call batadv_hardif_put with NULL, by Colin Ian King -----BEGIN PGP SIGNATURE----- iQJKBAABCgA0FiEE1ilQI7G+y+fdhnrfoSvjmEKSnqEFAlq47LsWHHN3QHNpbW9u d3VuZGVybGljaC5kZQAKCRChK+OYQpKeofguEAC1EJMOTAlZEWdrX5Ejbb6HSVxm /FRVI2Ln5IgP/KaAMWKYEA3kQDWEqLtbmuly4+u5iLy57mLxqFrmnbl6IcHDOtfF ykg9Zrl6npH1hsvAj4nrmoUUKix7BCXb8+cR2HJfCIdO/XBHh6EZMA8z3/NUmJU1 +EEt/eDCtkqYydwiIQ/N8/FbFE8xCFYyyU8U0XN9OF0bhdR5102Hhr4xAoB8KMYT 5+REEZU1P6phbbaE3nAw8B9WrOvu8DQxEDLf5E8ZyHtFOj0E4mu+JmUnrZLBuKUU tykHi3l8AlmhU9OES3DW+N0jgiBR4jU/G8MGIhT21Rt4nxS28KT0iIDw04Y4aOkv L6fMVahJ86zKwXbbrXXWDqFdDHy8/tOO5CcTeEFIyZ9Sd0A+pV/tDvGt2xPXxPnI vzqVF5IEjKwMljpKpkVgDNAxiBOYp5tmfcbMS46d3dU03Gd1zL7ihOhgXkBp6gar c5ZAEbmqpLLY9qQ3wUbe/8HweHv3CGuqb5hatu5mgVEUevGxm54sjsdFR/msYrh4 NIqpBWjjEsOLVrBKMNN4b02qyDqG7JAyMaZfNPa6wBql/auAkqug27F7uh0Py0Y0 7qM6+nFa3SYbzIfPz1DaimyyRD4DIDJzxfstlIYu2dItmYm3Y69foivnzxx//SG2 +GTVCNV9h30k7fPUxg== =MWVt -----END PGP SIGNATURE----- Colin Ian King (1): batman-adv: don't pass a NULL hard_iface to batadv_hardif_put Linus Lüssing (3): batman-adv: Avoid redundant multicast TT entries batman-adv: add DAT cache netlink support batman-adv: add multicast flags netlink support Simon Wunderlich (1): batman-adv: Start new development cycle Sven Eckelmann (3): batman-adv: Update copyright years for 2018 batman-adv: Fix indentation of batadv_seq_before batman-adv: Avoid relation operator comparison with bool ----------------------------------------------------------------------- -- linux integration

1 0

[linux-merge]linux integration; annotated tag, batadv-net-for-davem-20180326, created. batadv-net-for-davem-20180326
by postmaster＠open-mesh.org 26 Mar '18

26 Mar '18

The annotated tag, batadv-net-for-davem-20180326 has been created at ec5e423ff91779c32f7b1771bc115fef0ea737e1 (tag) tagging a752c0a4524889cdc0765925258fd1fd72344100 (commit) replaces v4.16-rc1 tagged by Simon Wunderlich on Mon Mar 26 14:46:33 2018 +0200 - Shortlog ------------------------------------------------------------ Here are some batman-adv bugfixes: - fix multicast-via-unicast transmissions for AP isolation and gateway extension, by Linus Luessing (2 patches) -----BEGIN PGP SIGNATURE----- iQJKBAABCgA0FiEE1ilQI7G+y+fdhnrfoSvjmEKSnqEFAlq466kWHHN3QHNpbW9u d3VuZGVybGljaC5kZQAKCRChK+OYQpKeobv5EACwz70r21xIUxwq6FWXysTfxxXt H3qcXt2BzCaGYKmYt8xqz9z368v7wpgCsPfZsvW2eBYhcpCkGQm6PR2XNy7WMoBz 6aFO4SDDi5L/S+5O0iXg79niRiTe9lCbOl/r6uv/2FtY22rIfhocFwkBL8cjIC3E hOWuFUbk3mAu8i+WMyhfDEUL33oy9CMvlJqaxqJuTHf3HxjOeGVjusOvSbQu+OGG K+TCAbIjazQ02R9p6lXQoIAjfg+kfsYIdT84MTgjk91qCtp1ztRxr3MNAwTgPvA4 Vi4uZGLbLCMvaAF1wqVBSuOnFFwbUCc8IBIoUvvZSMQTYm3agcg96pFLMYqNzrhY aHco1neJ+a+pGUmByijmYbsrJI2dYqK0V0OZlLG9WKwkrE3Y023LGGdXUbdl4RhS LXqMLGVJ9eqV+m7MCuv/q/PTVOL89loAun0DuIU4IhJuDM2+5yEG5jBiI6ImIym+ KX3F9F9nyefr5aCYsd14izX6WHxTXkJQaVpjVNBP56P6eZMLMx81eozBD9eotFyv A1EgQolLFEKWmtKU2KUK+qrGFNXaLlc9z8ZGkbizi/CTEjN0tr1UjW6B6toOOoZ+ fhF3HwlpgqVOdDodT+eDtxY8YboZBCpAnAOiE1LP3leVY4yab23Q02kskOPTPg1G CfpZwDjXIyZburUvfA== =j2w0 -----END PGP SIGNATURE----- Linus Lüssing (3): batman-adv: Fix multicast packet loss with a single WANT_ALL_IPV4/6 flag batman-adv: fix multicast-via-unicast transmission with AP isolation batman-adv: fix packet loss for broadcasted DHCP packets to a server Matthias Schiffer (4): batman-adv: fix packet checksum in receive path batman-adv: invalidate checksum on fragment reassembly batman-adv: update data pointers after skb_cow() batman-adv: fix header size check in batadv_dbg_arp() Sven Eckelmann (7): batman-adv: Ignore invalid batadv_iv_gw during netlink send batman-adv: Ignore invalid batadv_v_gw during netlink send batman-adv: Fix netlink dumping of BLA claims batman-adv: Fix netlink dumping of BLA backbones batman-adv: Fix internal interface indices types batman-adv: Add missing include for EPOLL* constants batman-adv: Fix skbuff rcsum on packet reroute ----------------------------------------------------------------------- -- linux integration

1 0

[batman-adv] maint's head updated: batman-adv: fix packet loss for broadcasted DHCP packets to a server (49b2132)
by postmaster＠open-mesh.org 24 Mar '18

24 Mar '18

Repository : ssh://git@open-mesh.org/batman-adv Branch 'maint' now includes: 67a50c9 batman-adv: fix multicast-via-unicast transmission with AP isolation 49b2132 batman-adv: fix packet loss for broadcasted DHCP packets to a server

1 0

[batman-adv] master: batman-adv: don't pass a NULL hard_iface to batadv_hardif_put (41111f3)
by postmaster＠open-mesh.org 24 Mar '18

24 Mar '18

Repository : ssh://git@open-mesh.org/batman-adv On branch : master >--------------------------------------------------------------- commit 41111f3638d0302d96c437f22f07b42ed4fa0af5 Author: Colin Ian King <colin.king(a)canonical.com> Date: Fri Mar 23 22:53:50 2018 +0000 batman-adv: don't pass a NULL hard_iface to batadv_hardif_put In the case where hard_iface is NULL, the error path may pass a null pointer to batadv_hardif_put causing a null pointer dereference error. Avoid this by only calling the function if hard_iface not null. Detected by CoverityScan, CID#1466456 ("Explicit null dereferenced") Fixes: 53c58c1e7487 ("batman-adv: add multicast flags netlink support") Signed-off-by: Colin Ian King <colin.king(a)canonical.com> Signed-off-by: Sven Eckelmann <sven(a)narfation.org> >--------------------------------------------------------------- 41111f3638d0302d96c437f22f07b42ed4fa0af5 net/batman-adv/multicast.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/net/batman-adv/multicast.c b/net/batman-adv/multicast.c index a11d3d8..a35f597 100644 --- a/net/batman-adv/multicast.c +++ b/net/batman-adv/multicast.c @@ -1536,7 +1536,7 @@ out: if (!ret && primary_if) *primary_if = hard_iface; - else + else if (hard_iface) batadv_hardif_put(hard_iface); return ret;

1 0

[batman-adv] master: Merge branch 'maint' (cf98aa9)
by postmaster＠open-mesh.org 24 Mar '18

24 Mar '18

Repository : ssh://git@open-mesh.org/batman-adv On branch : master >--------------------------------------------------------------- commit cf98aa9f1806bc194b675032b0ba7bcb99b52c79 Merge: aa58799 49b2132 Author: Sven Eckelmann <sven(a)narfation.org> Date: Sat Mar 24 10:08:13 2018 +0100 Merge branch 'maint' >--------------------------------------------------------------- cf98aa9f1806bc194b675032b0ba7bcb99b52c79 net/batman-adv/gateway_client.c | 5 ++++- net/batman-adv/multicast.c | 4 ++-- 2 files changed, 6 insertions(+), 3 deletions(-)

1 0

[batman-adv] master: batman-adv: fix multicast-via-unicast transmission with AP isolation (67a50c9)
by postmaster＠open-mesh.org 24 Mar '18

24 Mar '18

Repository : ssh://git@open-mesh.org/batman-adv On branch : master >--------------------------------------------------------------- commit 67a50c93bceb534937d6a188eded79272ff6d55d Author: Linus Lüssing <linus.luessing(a)c0d3.blue> Date: Tue Mar 20 03:13:27 2018 +0100 batman-adv: fix multicast-via-unicast transmission with AP isolation For multicast frames AP isolation is only supposed to be checked on the receiving nodes and never on the originating one. Furthermore, the isolation or wifi flag bits should only be intepreted as such for unicast and never multicast TT entries. By injecting flags to the multicast TT entry claimed by a single target node it was verified in tests that this multicast address becomes unreachable, leading to packet loss. Omitting the "src" parameter to the batadv_transtable_search() call successfully skipped the AP isolation check and made the target reachable again. Fixes: 405cc1e5a81e ("batman-adv: Modified forwarding behaviour for multicast packets") Signed-off-by: Linus Lüssing <linus.luessing(a)c0d3.blue> Signed-off-by: Sven Eckelmann <sven(a)narfation.org> >--------------------------------------------------------------- 67a50c93bceb534937d6a188eded79272ff6d55d net/batman-adv/multicast.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/net/batman-adv/multicast.c b/net/batman-adv/multicast.c index 15a7b31..07ac4f6 100644 --- a/net/batman-adv/multicast.c +++ b/net/batman-adv/multicast.c @@ -814,8 +814,8 @@ static struct batadv_orig_node * batadv_mcast_forw_tt_node_get(struct batadv_priv *bat_priv, struct ethhdr *ethhdr) { - return batadv_transtable_search(bat_priv, ethhdr->h_source, - ethhdr->h_dest, BATADV_NO_FLAGS); + return batadv_transtable_search(bat_priv, NULL, ethhdr->h_dest, + BATADV_NO_FLAGS); } /**

1 0

[batman-adv] master: batman-adv: fix packet loss for broadcasted DHCP packets to a server (49b2132)
by postmaster＠open-mesh.org 24 Mar '18

24 Mar '18

Repository : ssh://git@open-mesh.org/batman-adv On branch : master >--------------------------------------------------------------- commit 49b2132f0fe2753a3b46103db9719898c5cd44aa Author: Linus Lüssing <linus.luessing(a)c0d3.blue> Date: Thu Mar 22 00:21:32 2018 +0100 batman-adv: fix packet loss for broadcasted DHCP packets to a server DHCP connectivity issues can currently occur if the following conditions are met: 1) A DHCP packet from a client to a server 2) This packet has a multicast destination 3) This destination has a matching entry in the translation table (FF:FF:FF:FF:FF:FF for IPv4, 33:33:00:01:00:02/33:33:00:01:00:03 for IPv6) 4) The orig-node determined by TT for the multicast destination does not match the orig-node determined by best-gateway-selection In this case the DHCP packet will be dropped. The "gateway-out-of-range" check is supposed to only be applied to unicasted DHCP packets to a specific DHCP server. In that case dropping the the unicasted frame forces the client to retry via a broadcasted one, but now directed to the new best gateway. A DHCP packet with broadcast/multicast destination is already ensured to always be delivered to the best gateway. Dropping a multicasted DHCP packet here will only prevent completing DHCP as there is no other fallback. So far, it seems the unicast check was implicitly performed by expecting the batadv_transtable_search() to return NULL for multicast destinations. However, a multicast address could have always ended up in the translation table and in fact is now common. To fix this potential loss of a DHCP client-to-server packet to a multicast address this patch adds an explicit multicast destination check to reliably bail out of the gateway-out-of-range check for such destinations. The issue and fix were tested in the following three node setup: - Line topology, A-B-C - A: gateway client, DHCP client - B: gateway server, hop-penalty increased: 30->60, DHCP server - C: gateway server, code modifications to announce FF:FF:FF:FF:FF:FF Without this patch, A would never transmit its DHCP Discover packet due to an always "out-of-range" condition. With this patch, a full DHCP handshake between A and B was possible again. Fixes: afae4e42aae6 ("batman-adv: refactoring gateway handling code") Signed-off-by: Linus Lüssing <linus.luessing(a)c0d3.blue> Signed-off-by: Sven Eckelmann <sven(a)narfation.org> >--------------------------------------------------------------- 49b2132f0fe2753a3b46103db9719898c5cd44aa net/batman-adv/gateway_client.c | 5 ++++- 1 file changed, 4 insertions(+), 1 deletion(-) diff --git a/net/batman-adv/gateway_client.c b/net/batman-adv/gateway_client.c index c294f6f..8b198ee 100644 --- a/net/batman-adv/gateway_client.c +++ b/net/batman-adv/gateway_client.c @@ -746,7 +746,7 @@ bool batadv_gw_out_of_range(struct batadv_priv *bat_priv, { struct batadv_neigh_node *neigh_curr = NULL; struct batadv_neigh_node *neigh_old = NULL; - struct batadv_orig_node *orig_dst_node; + struct batadv_orig_node *orig_dst_node = NULL; struct batadv_gw_node *gw_node = NULL; struct batadv_gw_node *curr_gw = NULL; struct batadv_neigh_ifinfo *curr_ifinfo, *old_ifinfo; @@ -757,6 +757,9 @@ bool batadv_gw_out_of_range(struct batadv_priv *bat_priv, vid = batadv_get_vid(skb, 0); + if (is_multicast_ether_addr(ethhdr->h_dest)) + goto out; + orig_dst_node = batadv_transtable_search(bat_priv, ethhdr->h_source, ethhdr->h_dest, vid); if (!orig_dst_node)

1 0

[linux-merge]linux integration; annotated tag, batadv-next-for-davem-20180302, deleted. v4.16-rc1-5-ga163dc22d515
by postmaster＠open-mesh.org 24 Mar '18

24 Mar '18

The annotated tag, batadv-next-for-davem-20180302 has been deleted was 420210dd81ab54ed6dfd1ff040c1fa0fd958ed27 ----------------------------------------------------------------------- tag batadv-next-for-davem-20180302 This cleanup patchset includes the following patches: - bump version strings, by Simon Wunderlich - bump copyright years, by Sven Eckelmann - fix macro indendation for checkpatch, by Sven Eckelmann - fix comparison operator for bool returning functions, by Sven Eckelmann - assume 2-byte packet alignments for all packet types, by Matthias Schiffer -----BEGIN PGP SIGNATURE----- iQJKBAABCgA0FiEE1ilQI7G+y+fdhnrfoSvjmEKSnqEFAlqZkD8WHHN3QHNpbW9u d3VuZGVybGljaC5kZQAKCRChK+OYQpKeoaQeD/0cHQz/x6ZuXF6MDrwOf78oDvjw AksSt2e/055Ommhzplz0Aa0hthK7Xb7+dBD+caAOxBwrXtWsWc6H5fsfeiBCTntH PxDyS68o+iZDonquaOKz+gtILiPbUE0hG3hMizWdF95nDtsJ3rHoL3fU7Wo9eZNq WtlwCCloyEZeGfPtpJXCo7QmGOvTLk+Qt+pkGWKHFIIXNaxa9yfqp7JCFRfyrkl3 7wb4+YaZCCUDSUiDW6SQY0rTx3bxJPfHOnrG7rB6chmGVyyssH+tjhLP52331/oI dloVSz96pilAcKivbhLRENcIcUNuj9mHyV6rFM4/paYeDOGotoA5DCkEi3NSTYdN p2UiDBJZfiA6M40AxmLYK5mLPWYLGpyrZNBNskemrQdlrXDLU/D6UWMUKbFhouPx AjgX+Yk7giqXdxUjCcaFsjDBf2SxC/Xjv39qvPR0P4rW4xD/Y3xqHDJ8yLrPj7Si M1NJv6E+gBkIQg+JuoWeQb3kvbtNQsu49XBbrYlUrdPgkJhVC6DIP5jie/TutAGz 9OU1cdDZNUVkI6+iuGP8B3Aj0Mj+zlpXHvhBa5R9duAumdt0uiqwU98k4h89yix+ GK1K9dPyW/r9qmwtemaZH8RQ6iqoxBPVZ43PoM7W/xe04IwslPJWyZ8GT64Yqekl 9m5HhMLLiJx9pklR9w== =KJdN -----END PGP SIGNATURE----- a163dc22d515d17844435c8217ff66193d35b3fa batman-adv: always assume 2-byte packet alignment ----------------------------------------------------------------------- -- linux integration

1 0

[linux-merge]linux integration; annotated tag, batadv-net-for-davem-20180302, deleted. v4.16-rc1-7-gf22e08932c29
by postmaster＠open-mesh.org 24 Mar '18

24 Mar '18

The annotated tag, batadv-net-for-davem-20180302 has been deleted was 0108f9a647962abc4d53c7c866520a294957228e ----------------------------------------------------------------------- tag batadv-net-for-davem-20180302 Here are some batman-adv bugfixes: - fix skb checksum issues, by Matthias Schiffer (2 patches) - fix exception handling when dumping data objects through netlink, by Sven Eckelmann (4 patches) - fix handling of interface indices, by Sven Eckelmann -----BEGIN PGP SIGNATURE----- iQJKBAABCgA0FiEE1ilQI7G+y+fdhnrfoSvjmEKSnqEFAlqZjskWHHN3QHNpbW9u d3VuZGVybGljaC5kZQAKCRChK+OYQpKeoZgAEADcXmuvwW+QVU0L6N8ZDV7Titdp oIK+w2XDPLa2DcIkJ8ZAGJSK4ZZBrye/jAaRL/1CpBQiGDgP6pGodSihDPNUqCjs aqw8Zrwfg6BAvIeEFp3ThkCB89MADk6tMRXM4wZ3daNJvfCgHEUZeSl/1/PWWQmq yBn+DMeXZPOPJZgTTPMQUQ11kpf7UxtT4T9N8lq0KH6ISTbaZChPFlpPPIivpG+9 JLjH40v8BErpIAsZHT2LJ/JPDRPXXul61p3y2sdnVnqUuSUnsc/ElJGLARXNId8P tkKtOONlZEwnt9ZrXOLqeqxzN+KFs97JSNIuap/hRfpgbG+Qqn4pePiIQVXNHMUC eBUfbGSWNtRDX/JXcwk6O4nMkTX79UDq97npcDv5sTkWLcIeznacqpXJCA8+2E05 3F34XTDr0HY4QTxDQSEOfQ6qwo7qCxhc8u2Mr8RYNtzSiyRYS3Sy8jdFMMK/RgqT ggR8mIdR9MSRYhN0VFVHWWL7NL/OImke9ALvb4KioDbvDTFMFhsa/Pp1+K/NE3fK /E5mwicFFUB0MUmRnZiuN9gXPOy06fWOShouMgqF86Ofx4QpmT/Ph/gGK/HgFFKq SEfU6UunC3r6BISE4Zu5O7xTEH+AQhEZgyeSTTrTr+HLfNkvyqwGIlhG1HXzyCTx KWA50ikvjiKGeOCoMA== =tcl9 -----END PGP SIGNATURE----- f22e08932c2960f29b5e828e745c9f3fb7c1bb86 batman-adv: Fix internal interface indices types ----------------------------------------------------------------------- -- linux integration

1 0

2023

2022

2021

2020

2019

2018

2017

2016

2015

2014

2013

2012

2011

2010

2009

commits March 2018