Repository : ssh://git@diktynna/batman-adv
On branch : master
commit 069402af79d201323a41529020abee54af55c5ca Author: Sven Eckelmann sven@narfation.org Date: Tue Dec 29 09:24:21 2020 +0100
batman-adv: Avoid sizeof on flexible structure
The batadv_dhcp_packet is used to read in parts of the DHCP packet and extract relevant information for the distributed arp table. But the structure contained the flexible member "options" which is no where used in the code.
A sizeof on this kind of type would return the size of everything except the flexible member. But sparse will detect this kind of sizeof and warn with
warning: using sizeof on a flexible structure
This can be avoided by dropping the unused flexible member.
Signed-off-by: Sven Eckelmann sven@narfation.org
069402af79d201323a41529020abee54af55c5ca net/batman-adv/distributed-arp-table.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/net/batman-adv/distributed-arp-table.c b/net/batman-adv/distributed-arp-table.c index 443682a9..61a6cfef 100644 --- a/net/batman-adv/distributed-arp-table.c +++ b/net/batman-adv/distributed-arp-table.c @@ -87,7 +87,7 @@ struct batadv_dhcp_packet { __u8 sname[64]; __u8 file[128]; __be32 magic; - __u8 options[]; + /* __u8 options[]; */ };
#define BATADV_DHCP_YIADDR_LEN sizeof(((struct batadv_dhcp_packet *)0)->yiaddr)