commits April 2020

commits@lists.open-mesh.org

1 participants
53 discussions

[batctl] maint's head updated: batctl: Return EXIT_FAILURE when throughputmeter failed (df8bf51)

by postmaster＠open-mesh.org

Repository : ssh://git@diktynna/batctl Branch 'maint' now includes: df8bf51 batctl: Return EXIT_FAILURE when throughputmeter failed

2 years, 11 months

[batctl] master: batctl: Return EXIT_FAILURE when throughputmeter failed (df8bf51)

by postmaster＠open-mesh.org

Repository : ssh://git@diktynna/batctl On branch : master >--------------------------------------------------------------- commit df8bf5164b6904f61ae0b0db090fb5bb41b4f06d Author: Leonardo Mörlein <me(a)irrelefant.net> Date: Wed Apr 8 23:49:03 2020 +0200 batctl: Return EXIT_FAILURE when throughputmeter failed The command returned a success even an error was shown during the execution. $ (sudo batctl tp 77:77:77:77:77:77 && echo true) || echo false Destination unreachable true Instead it should indicate a failure when the kernel replied with a non-success return_value: $ (sudo ./batctl tp 77:77:77:77:77:77 && echo true) || echo false Destination unreachable false Fixes: f109b3473f86 ("batctl: introduce throughput meter support") Signed-off-by: Leonardo Mörlein <me(a)irrelefant.net> [sven(a)narfation.org: adjusted commit message] Signed-off-by: Sven Eckelmann <sven(a)narfation.org> >--------------------------------------------------------------- df8bf5164b6904f61ae0b0db090fb5bb41b4f06d throughputmeter.c | 1 + 1 file changed, 1 insertion(+) diff --git a/throughputmeter.c b/throughputmeter.c index 27f1346..0ec5c31 100644 --- a/throughputmeter.c +++ b/throughputmeter.c @@ -465,6 +465,7 @@ static int throughputmeter(struct state *state, int argc, char **argv) goto out; } + ret = EXIT_FAILURE; switch (result.return_value) { case BATADV_TP_REASON_DST_UNREACHABLE: fprintf(stderr, "Destination unreachable\n");

2 years, 11 months

[batctl] master: Merge branch 'maint' (2c4980f)

by postmaster＠open-mesh.org

Repository : ssh://git@diktynna/batctl On branch : master >--------------------------------------------------------------- commit 2c4980f2b62102ef0576e9e53bc7e94e312f65a5 Merge: bb6058c df8bf51 Author: Sven Eckelmann <sven(a)narfation.org> Date: Fri Apr 10 09:22:01 2020 +0200 Merge branch 'maint' >--------------------------------------------------------------- 2c4980f2b62102ef0576e9e53bc7e94e312f65a5 throughputmeter.c | 1 + 1 file changed, 1 insertion(+)

2 years, 11 months

2023

2022

2021

2020

2019

2018

2017

2016

2015

2014

2013

2012

2011

2010

2009

commits April 2020