commits April 2020

commits@lists.open-mesh.org

1 participants
53 discussions

[batman-adv] master: Merge branch 'maint' (eaccc9c0)
by postmaster＠open-mesh.org 20 Apr '20

20 Apr '20

Repository : ssh://git@diktynna/batman-adv On branch : master >--------------------------------------------------------------- commit eaccc9c004aa30e2135fcc8088e76a1cfa58f890 Merge: e13bcb6d 4515f5e6 Author: Sven Eckelmann <sven(a)narfation.org> Date: Mon Apr 20 07:54:48 2020 +0200 Merge branch 'maint' >--------------------------------------------------------------- eaccc9c004aa30e2135fcc8088e76a1cfa58f890 net/batman-adv/bat_v_ogm.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)

1 0

[linux-merge]linux integration; annotated tag, v5.7-rc2, created. v5.7-rc2
by postmaster＠open-mesh.org 19 Apr '20

19 Apr '20

The annotated tag, v5.7-rc2 has been created at a288422dfe80c0cd6612c9057f64242c6e0b7511 (tag) tagging ae83d0b416db002fe95601e7f97f64b59514d936 (commit) replaces v5.7-rc1 tagged by Linus Torvalds on Sun Apr 19 14:35:44 2020 -0700 - Shortlog ------------------------------------------------------------ Linux 5.7-rc2 -----BEGIN PGP SIGNATURE----- iQFSBAABCAA8FiEEq68RxlopcLEwq+PEeb4+QwBBGIYFAl6cxDAeHHRvcnZhbGRz QGxpbnV4LWZvdW5kYXRpb24ub3JnAAoJEHm+PkMAQRiGb2YH/3V3yrWOgbZkEWvO IwW5nSjYk+xTBs7Tf5+nycWHpr+e92tX4m/+DZ6qn1sQpjdKEA7EZ/E0mpm0fm5w Po+dzy4PP40CLi/Z0mXl3U3FWmp5l50Q4tEs5fzI6rQPKjX+G5qO8+J7Yu1iNduJ KRbNeKCnUGHf2mRYiOJRNurVm4Yv370AIyvulxX5FkZHN7hTq/Js76sRV1BSnG7k o1Vs4vvFSSdFgVxyuflpV0Uv9bDTxppqiwQ4ktntB8TKmVtXLT25wcO4V5LwRjQt 6o064j343Q+OQ4t/LZVKYUB0Fmw8Ks1YH00OOdH6G41wY6LogaxYIXM1YvUZ4NwQ HjNsASY= =kvEN -----END PGP SIGNATURE----- ----------------------------------------------------------------------- -- linux integration

1 0

[batman-adv] maint's head updated: batman-adv: Fix refcnt leak in batadv_store_throughput_override (b69cd8bd)
by postmaster＠open-mesh.org 15 Apr '20

15 Apr '20

Repository : ssh://git@diktynna/batman-adv Branch 'maint' now includes: f301bfed batman-adv: Fix refcnt leak in batadv_show_throughput_override b69cd8bd batman-adv: Fix refcnt leak in batadv_store_throughput_override

1 0

[batman-adv] master: batman-adv: Fix refcnt leak in batadv_show_throughput_override (f301bfed)
by postmaster＠open-mesh.org 15 Apr '20

15 Apr '20

Repository : ssh://git@diktynna/batman-adv On branch : master >--------------------------------------------------------------- commit f301bfed59b146a63471d0f147b767d7cafede6f Author: Xiyu Yang <xiyuyang19(a)fudan.edu.cn> Date: Wed Apr 15 16:31:50 2020 +0800 batman-adv: Fix refcnt leak in batadv_show_throughput_override batadv_show_throughput_override() invokes batadv_hardif_get_by_netdev(), which gets a batadv_hard_iface object from net_dev with increased refcnt and its reference is assigned to a local pointer 'hard_iface'. When batadv_show_throughput_override() returns, "hard_iface" becomes invalid, so the refcount should be decreased to keep refcount balanced. The issue happens in the normal path of batadv_show_throughput_override(), which forgets to decrease the refcnt increased by batadv_hardif_get_by_netdev() before the function returns, causing a refcnt leak. Fix this issue by calling batadv_hardif_put() before the batadv_show_throughput_override() returns in the normal path. Fixes: c513176e4b7a ("batman-adv: add throughput override attribute to hard_ifaces") Signed-off-by: Xiyu Yang <xiyuyang19(a)fudan.edu.cn> Signed-off-by: Xin Tan <tanxin.ctf(a)gmail.com> Signed-off-by: Sven Eckelmann <sven(a)narfation.org> >--------------------------------------------------------------- f301bfed59b146a63471d0f147b767d7cafede6f net/batman-adv/sysfs.c | 1 + 1 file changed, 1 insertion(+) diff --git a/net/batman-adv/sysfs.c b/net/batman-adv/sysfs.c index c45962d8..c0b00268 100644 --- a/net/batman-adv/sysfs.c +++ b/net/batman-adv/sysfs.c @@ -1190,6 +1190,7 @@ static ssize_t batadv_show_throughput_override(struct kobject *kobj, tp_override = atomic_read(&hard_iface->bat_v.throughput_override); + batadv_hardif_put(hard_iface); return sprintf(buff, "%u.%u MBit\n", tp_override / 10, tp_override % 10); }

1 0

[batman-adv] master: Merge branch 'maint' (e13bcb6d)
by postmaster＠open-mesh.org 15 Apr '20

15 Apr '20

Repository : ssh://git@diktynna/batman-adv On branch : master >--------------------------------------------------------------- commit e13bcb6db03b74e1eb77e7410761db6eca25d48e Merge: 3d186966 b69cd8bd Author: Sven Eckelmann <sven(a)narfation.org> Date: Wed Apr 15 10:57:29 2020 +0200 Merge branch 'maint' >--------------------------------------------------------------- e13bcb6db03b74e1eb77e7410761db6eca25d48e net/batman-adv/sysfs.c | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-)

1 0

[batman-adv] master: batman-adv: Fix refcnt leak in batadv_store_throughput_override (b69cd8bd)
by postmaster＠open-mesh.org 15 Apr '20

15 Apr '20

Repository : ssh://git@diktynna/batman-adv On branch : master >--------------------------------------------------------------- commit b69cd8bdbfd6fa7e61878c2fa9e6637406f40dd9 Author: Xiyu Yang <xiyuyang19(a)fudan.edu.cn> Date: Wed Apr 15 16:35:21 2020 +0800 batman-adv: Fix refcnt leak in batadv_store_throughput_override batadv_show_throughput_override() invokes batadv_hardif_get_by_netdev(), which gets a batadv_hard_iface object from net_dev with increased refcnt and its reference is assigned to a local pointer 'hard_iface'. When batadv_store_throughput_override() returns, "hard_iface" becomes invalid, so the refcount should be decreased to keep refcount balanced. The issue happens in one error path of batadv_store_throughput_override(). When batadv_parse_throughput() returns NULL, the refcnt increased by batadv_hardif_get_by_netdev() is not decreased, causing a refcnt leak. Fix this issue by jumping to "out" label when batadv_parse_throughput() returns NULL. Fixes: c513176e4b7a ("batman-adv: add throughput override attribute to hard_ifaces") Signed-off-by: Xiyu Yang <xiyuyang19(a)fudan.edu.cn> Signed-off-by: Xin Tan <tanxin.ctf(a)gmail.com> Signed-off-by: Sven Eckelmann <sven(a)narfation.org> >--------------------------------------------------------------- b69cd8bdbfd6fa7e61878c2fa9e6637406f40dd9 net/batman-adv/sysfs.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/net/batman-adv/sysfs.c b/net/batman-adv/sysfs.c index c0b00268..0f962dcd 100644 --- a/net/batman-adv/sysfs.c +++ b/net/batman-adv/sysfs.c @@ -1150,7 +1150,7 @@ static ssize_t batadv_store_throughput_override(struct kobject *kobj, ret = batadv_parse_throughput(net_dev, buff, "throughput_override", &tp_override); if (!ret) - return count; + goto out; old_tp_override = atomic_read(&hard_iface->bat_v.throughput_override); if (old_tp_override == tp_override)

1 0

[batman-adv] maint's head updated: batman-adv: Fix refcnt leak in batadv_store_throughput_override (ea7361d6)
by postmaster＠open-mesh.org 15 Apr '20

15 Apr '20

Repository : ssh://git@diktynna/batman-adv Branch 'maint' now includes: 00733808 batman-adv: Start new development cycle 6d67acbb batman-adv: Avoid RCU list-traversal in spinlock b5ccc4b3 batman-adv: Replace zero-length array with flexible-array member 3d186966 Merge branch 'maint' c293e0c4 batman-adv: Fix refcnt leak in batadv_show_throughput_override ea7361d6 batman-adv: Fix refcnt leak in batadv_store_throughput_override

1 0

[batman-adv] master: batman-adv: Fix refcnt leak in batadv_show_throughput_override (c293e0c4)
by postmaster＠open-mesh.org 15 Apr '20

15 Apr '20

Repository : ssh://git@diktynna/batman-adv On branch : master >--------------------------------------------------------------- commit c293e0c4d98b2e24400338bd31be85f660547606 Author: Xiyu Yang <xiyuyang19(a)fudan.edu.cn> Date: Wed Apr 15 16:31:50 2020 +0800 batman-adv: Fix refcnt leak in batadv_show_throughput_override batadv_show_throughput_override() invokes batadv_hardif_get_by_netdev(), which gets a batadv_hard_iface object from net_dev with increased refcnt and its reference is assigned to a local pointer 'hard_iface'. When batadv_show_throughput_override() returns, "hard_iface" becomes invalid, so the refcount should be decreased to keep refcount balanced. The issue happens in the normal path of batadv_show_throughput_override(), which forgets to decrease the refcnt increased by batadv_hardif_get_by_netdev() before the function returns, causing a refcnt leak. Fix this issue by calling batadv_hardif_put() before the batadv_show_throughput_override() returns in the normal path. Fixes: c513176e4b7a ("batman-adv: add throughput override attribute to hard_ifaces") Signed-off-by: Xiyu Yang <xiyuyang19(a)fudan.edu.cn> Signed-off-by: Xin Tan <tanxin.ctf(a)gmail.com> >--------------------------------------------------------------- c293e0c4d98b2e24400338bd31be85f660547606 net/batman-adv/sysfs.c | 1 + 1 file changed, 1 insertion(+) diff --git a/net/batman-adv/sysfs.c b/net/batman-adv/sysfs.c index c45962d8..c0b00268 100644 --- a/net/batman-adv/sysfs.c +++ b/net/batman-adv/sysfs.c @@ -1190,6 +1190,7 @@ static ssize_t batadv_show_throughput_override(struct kobject *kobj, tp_override = atomic_read(&hard_iface->bat_v.throughput_override); + batadv_hardif_put(hard_iface); return sprintf(buff, "%u.%u MBit\n", tp_override / 10, tp_override % 10); }

1 0

[batman-adv] master: batman-adv: Fix refcnt leak in batadv_store_throughput_override (ea7361d6)
by postmaster＠open-mesh.org 15 Apr '20

15 Apr '20

Repository : ssh://git@diktynna/batman-adv On branch : master >--------------------------------------------------------------- commit ea7361d614c70a74a04c63cd9eaebd0e72aa908a Author: Xiyu Yang <xiyuyang19(a)fudan.edu.cn> Date: Wed Apr 15 16:35:21 2020 +0800 batman-adv: Fix refcnt leak in batadv_store_throughput_override batadv_show_throughput_override() invokes batadv_hardif_get_by_netdev(), which gets a batadv_hard_iface object from net_dev with increased refcnt and its reference is assigned to a local pointer 'hard_iface'. When batadv_store_throughput_override() returns, "hard_iface" becomes invalid, so the refcount should be decreased to keep refcount balanced. The issue happens in one error path of batadv_store_throughput_override(). When batadv_parse_throughput() returns NULL, the refcnt increased by batadv_hardif_get_by_netdev() is not decreased, causing a refcnt leak. Fix this issue by jumping to "out" label when batadv_parse_throughput() returns NULL. Fixes: c513176e4b7a ("batman-adv: add throughput override attribute to hard_ifaces") Signed-off-by: Xiyu Yang <xiyuyang19(a)fudan.edu.cn> Signed-off-by: Xin Tan <tanxin.ctf(a)gmail.com> >--------------------------------------------------------------- ea7361d614c70a74a04c63cd9eaebd0e72aa908a net/batman-adv/sysfs.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/net/batman-adv/sysfs.c b/net/batman-adv/sysfs.c index c0b00268..0f962dcd 100644 --- a/net/batman-adv/sysfs.c +++ b/net/batman-adv/sysfs.c @@ -1150,7 +1150,7 @@ static ssize_t batadv_store_throughput_override(struct kobject *kobj, ret = batadv_parse_throughput(net_dev, buff, "throughput_override", &tp_override); if (!ret) - return count; + goto out; old_tp_override = atomic_read(&hard_iface->bat_v.throughput_override); if (old_tp_override == tp_override)

1 0

[batman-adv] maint's head updated: batman-adv: fix batadv_nc_random_weight_tq (db48c60b)
by postmaster＠open-mesh.org 13 Apr '20

13 Apr '20

Repository : ssh://git@diktynna/batman-adv Branch 'maint' now includes: db48c60b batman-adv: fix batadv_nc_random_weight_tq

1 0

2024

2023

2022

2021

2020

2019

2018

2017

2016

2015

2014

2013

2012

2011

2010

2009

commits April 2020