Repository : ssh://git@open-mesh.org/batman-adv

On branch : master

commit 21a288fb1b87d11a48d7605b8e00eddee8ed1cf8 Author: Sven Eckelmann sven@narfation.org Date: Sat Mar 5 16:09:20 2016 +0100

batman-adv: Use kref_get for batadv_tvlv_container_get

batadv_tvlv_container_get requires that tvlv.container_list_lock is held by the caller. It is therefore not possible that an item in tvlv.container_list has an reference counter of 0 and is still in the list

The kref_get function instead WARNs (with debug information) when the reference counter would still be 0. This makes a bug in batman-adv better visible because kref_get_unless_zero would have ignored this problem.

Signed-off-by: Sven Eckelmann sven@narfation.org Signed-off-by: Marek Lindner mareklindner@neomailbox.ch

21a288fb1b87d11a48d7605b8e00eddee8ed1cf8 net/batman-adv/main.c | 4 +--- 1 file changed, 1 insertion(+), 3 deletions(-)

diff --git a/net/batman-adv/main.c b/net/batman-adv/main.c index c8d8bc7..5f2974b 100644 --- a/net/batman-adv/main.c +++ b/net/batman-adv/main.c @@ -748,9 +748,7 @@ batadv_tvlv_container_get(struct batadv_priv *bat_priv, u8 type, u8 version) if (tvlv_tmp->tvlv_hdr.version != version) continue;

- if (!kref_get_unless_zero(&tvlv_tmp->refcount)) - continue; - + kref_get(&tvlv_tmp->refcount); tvlv = tvlv_tmp; break; }