Repository : ssh://git@open-mesh.org/batman-adv

On branch : master

commit 8435e41ee1e2ad9189d4a966b94e0e3af58bf418 Author: Sven Eckelmann sven@narfation.org Date: Sun Mar 1 16:56:26 2015 +0100

batman-adv: Remove unnecessary check for orig_ifinfo not NULL

orig_ifinfo is dereferenced multiple times in batadv_iv_ogm_update_seqnos before the check for NULL is done. The function also exists at the beginning when orig_ifinfo would have been NULL. This makes the check at the end unnecessary and only confuses the reader/code analyzers.

Signed-off-by: Sven Eckelmann sven@narfation.org Signed-off-by: Marek Lindner mareklindner@neomailbox.ch

8435e41ee1e2ad9189d4a966b94e0e3af58bf418 bat_iv_ogm.c | 3 +-- 1 file changed, 1 insertion(+), 2 deletions(-)

diff --git a/bat_iv_ogm.c b/bat_iv_ogm.c index 554e0e0..04bd220 100644 --- a/bat_iv_ogm.c +++ b/bat_iv_ogm.c @@ -1357,8 +1357,7 @@ batadv_iv_ogm_update_seqnos(const struct ethhdr *ethhdr, out: spin_unlock_bh(&orig_node->bat_iv.ogm_cnt_lock); batadv_orig_node_free_ref(orig_node); - if (orig_ifinfo) - batadv_orig_ifinfo_free_ref(orig_ifinfo); + batadv_orig_ifinfo_free_ref(orig_ifinfo); return ret; }