The following commit has been merged in the linux branch: commit cbbfacefcc63b01291c25df03d7c43e8588f7d5f Author: Sven Eckelmann sven.eckelmann@gmx.de Date: Tue Jul 20 21:54:03 2010 +0200
Staging: batman-adv: Add TODO from Ben Hutchings
Ben Hutchings informed that we cannot access the statistics directly to incread the rx_packets and rx_bytes counts. He explains it with commit 3cfde79c6c7c8002375c4a8e5be7f602fbb9675d.
dev_get_stats itself only returns a _const_ struct rtnl_link_stats64 *. So we actually should never try to access it. Instead we must have private variables (maybe cpu variables like in net/bridge/).
Signed-off-by: Sven Eckelmann sven.eckelmann@gmx.de
diff --git a/drivers/staging/batman-adv/TODO b/drivers/staging/batman-adv/TODO index 9c5aea2..e67afc5 100644 --- a/drivers/staging/batman-adv/TODO +++ b/drivers/staging/batman-adv/TODO @@ -1,6 +1,8 @@ * Use hweight* for hamming weight calculation * Save/cache packets direktly as skb instead of using a normal memory region and copying it in a skb using send_raw_packet and similar functions + * don't access stats->rx_packets from dev_get_stats directly when receiving + packet * Request a new review * Process the comments from the review * Move into mainline proper