Repository : ssh://git@open-mesh.org/batman-adv
On branch : master
commit 1cc6cbc51cb985bd1e43aeeaff545b889b9742b1 Author: Antonio Quartulli antonio@open-mesh.com Date: Tue Apr 2 12:16:53 2013 +0200
batman-adv: don't initialise batman_iv private members in hard-interface.c
hard-interface.c has to do not contain any routing algorithm specific code.
Allocate the hard-interface with kzalloc() and remove any useless and algorithm specific member initialisation
Signed-off-by: Antonio Quartulli antonio@open-mesh.com Signed-off-by: Marek Lindner lindner_marek@yahoo.de
1cc6cbc51cb985bd1e43aeeaff545b889b9742b1 hard-interface.c | 8 +------- 1 file changed, 1 insertion(+), 7 deletions(-)
diff --git a/hard-interface.c b/hard-interface.c index 18f4523..dc4ac29 100644 --- a/hard-interface.c +++ b/hard-interface.c @@ -577,7 +577,7 @@ batadv_hardif_add_interface(struct net_device *net_dev)
dev_hold(net_dev);
- hard_iface = kmalloc(sizeof(*hard_iface), GFP_ATOMIC); + hard_iface = kzalloc(sizeof(*hard_iface), GFP_ATOMIC); if (!hard_iface) goto release_dev;
@@ -603,12 +603,6 @@ batadv_hardif_add_interface(struct net_device *net_dev) batadv_check_known_mac_addr(hard_iface->net_dev); list_add_tail_rcu(&hard_iface->list, &batadv_hardif_list);
- /* This can't be called via a bat_priv callback because - * we have no bat_priv yet. - */ - atomic_set(&hard_iface->bat_iv.ogm_seqno, 1); - hard_iface->bat_iv.ogm_buff = NULL; - return hard_iface;
free_if: