Repository : ssh://git@open-mesh.org/batman-adv
On branch : maint
commit aa7d19a5b97fe48657e075e8e4d130bd6916551e Author: Marek Lindner lindner_marek@yahoo.de Date: Sat Apr 27 16:22:28 2013 +0800
batman-adv: check proto length before accessing proto string buffer
batadv_param_set_ra() strips the trailing '\n' from the supplied string buffer without checking the length of the buffer first. This patches avoids random memory access and associated potential crashes.
Reported-by: Sasha Levin sasha.levin@oracle.com Signed-off-by: Marek Lindner lindner_marek@yahoo.de
aa7d19a5b97fe48657e075e8e4d130bd6916551e main.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/main.c b/main.c index 3e30a0f..9c620cd 100644 --- a/main.c +++ b/main.c @@ -475,7 +475,7 @@ static int batadv_param_set_ra(const char *val, const struct kernel_param *kp) char *algo_name = (char *)val; size_t name_len = strlen(algo_name);
- if (algo_name[name_len - 1] == '\n') + if (name_len > 0 && algo_name[name_len - 1] == '\n') algo_name[name_len - 1] = '\0';
bat_algo_ops = batadv_algo_get(algo_name);