commits

commits@lists.open-mesh.org

1 participants
12373 discussions

[doc] backup-redmine,main: doc: batman-adv/batman-adv-multicast-type-decision.png (e68bfb01)
by postmaster＠open-mesh.org 10 May '24

10 May '24

Repository : ssh://git@diktynna/doc On branches: backup-redmine,main >--------------------------------------------------------------- commit e68bfb01b9d6f7406c145c86d8ad486ecec628ce Author: Linus Lüssing <linus.luessing(a)c0d3.blue> Date: Fri Apr 19 01:37:25 2024 +0000 doc: batman-adv/batman-adv-multicast-type-decision.png >--------------------------------------------------------------- e68bfb01b9d6f7406c145c86d8ad486ecec628ce batman-adv/batman-adv-multicast-type-decision.png | Bin 0 -> 161832 bytes 1 file changed, 0 insertions(+), 0 deletions(-) diff --git a/batman-adv/batman-adv-multicast-type-decision.png b/batman-adv/batman-adv-multicast-type-decision.png new file mode 100644 index 00000000..e5868c57 Binary files /dev/null and b/batman-adv/batman-adv-multicast-type-decision.png differ

1 0

[doc] backup-redmine,main: doc: batman-adv/Multicast-optimizations (348bb2d3)
by postmaster＠open-mesh.org 10 May '24

10 May '24

Repository : ssh://git@diktynna/doc On branches: backup-redmine,main >--------------------------------------------------------------- commit 348bb2d322537016b1187ac6e45afc47915920fd Author: Linus Lüssing <linus.luessing(a)c0d3.blue> Date: Fri Apr 19 01:52:56 2024 +0000 doc: batman-adv/Multicast-optimizations >--------------------------------------------------------------- 348bb2d322537016b1187ac6e45afc47915920fd batman-adv/Multicast-optimizations.textile | 16 +++++++++++----- 1 file changed, 11 insertions(+), 5 deletions(-) diff --git a/batman-adv/Multicast-optimizations.textile b/batman-adv/Multicast-optimizations.textile index 640e1487..8864f640 100644 --- a/batman-adv/Multicast-optimizations.textile +++ b/batman-adv/Multicast-optimizations.textile @@ -10,19 +10,25 @@ In the field observations revealed that a typical multicast session is actually h2. Overview -The current multicast optimizations in batman-adv provide a basic infrastructure for multicast awareness. So far, this basic optimization reduces overhead in the following two ways: +The current multicast optimizations in batman-adv provide a basic infrastructure for multicast awareness. So far, this optimization reduces overhead for IPv4/IPv6 packets through the following forwarding decisions: -h3. Discards IPv4/IPv6 packets with no multicast listener +!batman-adv-multicast-type-decision.png! + +h3. 1) No multicast listener/router: Discard !{width: 66%;}basic-multicast-no-receiver.png! -batman-adv detects whether there are any potential IPv4/IPv6 multicast listeners interested in traffic to the given multicast destination address. If not then the packet is never forwarded into the mesh network. +batman-adv detects whether there are any potential IPv4/IPv6 multicast listeners or multicast routers interested in traffic to the given multicast destination address. If not then the packet is never forwarded into the mesh network. + +h3. 2) batman-adv multicast packet + +If all nodes support the [[Multicast-Packet-Type|batman-adv multicast packet]] and encapsulating the IP packet in it, with all its destination node entries included, would fit into a 1280 bytes frame (excluding outer ethernet frame header) then this packet type is chosen for forwarding. -h3. Forwards IPv4/IPv6 packets with a some multicast listeners via unicasts +h3. 3) batman-adv unicast packet(s) !{width: 66%;}basic-multicast-multiple-receivers.png! -If there is an amount of multicast listeners smaller or equal to the (configurable) multicast-fanout parameter (default: 16) then the packet is forwarded via individual unicast transmissions. +If the batman-adv multicast packet type cannot be used and if there is an amount of interested multicast listeners/routers smaller or equal to the (configurable) multicast-fanout parameter (default: 16) then the packet is forwarded via individual unicast transmissions. h3. Limitations

1 0

[doc] backup-redmine,main: doc: batman-adv/Multicast-optimizations (13d65d1c)
by postmaster＠open-mesh.org 10 May '24

10 May '24

Repository : ssh://git@diktynna/doc On branches: backup-redmine,main >--------------------------------------------------------------- commit 13d65d1c3a07ac6d9c602b7a876495a3dadb117a Author: Linus Lüssing <linus.luessing(a)c0d3.blue> Date: Fri Apr 19 01:53:48 2024 +0000 doc: batman-adv/Multicast-optimizations >--------------------------------------------------------------- 13d65d1c3a07ac6d9c602b7a876495a3dadb117a batman-adv/Multicast-optimizations.textile | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/batman-adv/Multicast-optimizations.textile b/batman-adv/Multicast-optimizations.textile index 8864f640..1c9acb82 100644 --- a/batman-adv/Multicast-optimizations.textile +++ b/batman-adv/Multicast-optimizations.textile @@ -10,7 +10,7 @@ In the field observations revealed that a typical multicast session is actually h2. Overview -The current multicast optimizations in batman-adv provide a basic infrastructure for multicast awareness. So far, this optimization reduces overhead for IPv4/IPv6 packets through the following forwarding decisions: +The current multicast optimizations in batman-adv provide a basic infrastructure for multicast awareness. So far, this optimization reduces overhead for IPv4/IPv6 packets through the following forwarding decisions on the initial hop: !batman-adv-multicast-type-decision.png!

1 0

[doc] backup-redmine,main: doc: batman-adv/Multicast-optimizations-tech (06ccdc10)
by postmaster＠open-mesh.org 10 May '24

10 May '24

Repository : ssh://git@diktynna/doc On branches: backup-redmine,main >--------------------------------------------------------------- commit 06ccdc107230820c4d2867159c020842b3b4b171 Author: Linus Lüssing <linus.luessing(a)c0d3.blue> Date: Fri Apr 19 01:56:24 2024 +0000 doc: batman-adv/Multicast-optimizations-tech >--------------------------------------------------------------- 06ccdc107230820c4d2867159c020842b3b4b171 batman-adv/Multicast-optimizations-tech.textile | 9 ++++++++- 1 file changed, 8 insertions(+), 1 deletion(-) diff --git a/batman-adv/Multicast-optimizations-tech.textile b/batman-adv/Multicast-optimizations-tech.textile index d1ddc949..6c4bd9be 100644 --- a/batman-adv/Multicast-optimizations-tech.textile +++ b/batman-adv/Multicast-optimizations-tech.textile @@ -48,7 +48,14 @@ h4. BATADV_MCAST_WANT_NO_RTR6 (Bit 4): Signalizes that we have no IPv6 multicast router and therefore only need routable IPv6 multicast packets we signed up for explicitly. -h4. Bits 5 to 7: +h4. BATADV_MCAST_HAVE_MC_PTYPE_CAPA (Bit 5): + +Signalizes that: + +# This node is capable of receiving, parsing and forwarding a batman-adv multicast packet with a multicast tracker TVLV. +# All hard interfaces of this node have an MTU of at least 1280. + +h4. Bits 6 to 7: reserved for future extensions

1 0

[doc] backup-redmine,main: doc: batman-adv/Multicast-Packet-Type: cleanup: remove "Open Questions" section for multicast packet type (8dbe48c4)
by postmaster＠open-mesh.org 10 May '24

10 May '24

Repository : ssh://git@diktynna/doc On branches: backup-redmine,main >--------------------------------------------------------------- commit 8dbe48c4e1a141213b5d6455fd1aa6515b3c8a0c Author: Linus Lüssing <linus.luessing(a)c0d3.blue> Date: Fri Apr 19 02:03:48 2024 +0000 doc: batman-adv/Multicast-Packet-Type: cleanup: remove "Open Questions" section for multicast packet type >--------------------------------------------------------------- 8dbe48c4e1a141213b5d6455fd1aa6515b3c8a0c batman-adv/Multicast-Packet-Type.textile | 55 -------------------------------- 1 file changed, 55 deletions(-) diff --git a/batman-adv/Multicast-Packet-Type.textile b/batman-adv/Multicast-Packet-Type.textile index b5025d0f..28ab7839 100644 --- a/batman-adv/Multicast-Packet-Type.textile +++ b/batman-adv/Multicast-Packet-Type.textile @@ -116,58 +116,3 @@ h2. Limitations If such a limitation is reached then batman-adv will either fall back to multicast via multiple batman-adv unicast packes. Or if that is not possible either, to classic flooding. * Multicast fanout setting is not considered yet. A multicast payload packet will only use one or no batman-adv multicast packet for now, for reduced complexity. And a batman-adv node would not know how to best split destinations to reduce the number of resplits/retransmissions along the paths / multicast tree. \ No newline at end of file - -h2. Open questions - -h3. -#Num Dests size- - --* 1 or 2 bytes for #Num Dests for Address X?- --** If limit of entries were reached, we could just send another - mcast packet? (~6*256 = 1536). Or do we want to be prepared - for jumbo frames?- - ---- - --> going for 2 bytes / potential jumbo frame support - -h3. -Non ideal splits- - --If a packet with n destinations gets too large for the MTU then batman-adv would/should/could try to split it into m packets with n/3 destinations each. where m <= mcast_fanout.- - --However when splitting like this then such the splitting node does not know the best sorting into these m packets. Another node will likely later need to split again due to different next hops for the destinations in a packet.- - --A batman-adv node currently cannot anticipate this for optimized splitting, as it does not know the full topology. Which would potentially lead to more transmissions than necessary.- - ---- - --> Going for just one multicast packet instead of up to mcast_fanout to start with, for simplicity. - -h3. -Fragmentation / MTUs:- - --On transit a forwarding node might have an interface with a smaller MTU than the node which originated the packet. A node could try to split a packet into multiple packets with less destinations. However if the payload data is larger than the interface MTU already then it would still not fit. And the batman-adv fragmentation code won't be able to look into and split within a multicast packet type header.- - --Workaround A):- - --By default only apply multicast packet type if resulting packet is smaller than 1280 (minimum IPv6 packet size) or even 576 (minimum accepeted IPv4 datagram size?). Maybe add a configuration option, which defaults to 576 bytes? While in practice configuring it to 1280 should usually be fine these days with IPv6 capable networks.- - --Solution B)- - --Later ideally the fragmentation code would be able to split the payload within a multicast packet type, while leaving multicast packet type headers in tact. A node should still forward packets if due to this splitting the mcast-fanout limit were violated, to avoid packet loss.- - ---- - --> Workaround C): We require a 1280 bytes MTU on all hard interfaces and only then set the multicast packet type capability flag. - -h3. -Adding a sequence number? / How to avoid loops with tracker marking later?- - --When later implementing a split control <=> data plane as originally envisioned, by allowing to send a multicast packet with only the tracker TVLV, without data. And caching this information to fill a multicast routing table. And then allowing to send a multicast packet without the tracker TVLV afterwards, there is the following issue:- - --When first a path is marked through the tracker TVLV, then paths change due to OGM updates. And then a tracker packet marks such new paths then the merger of both the old and newly tracker marked paths could create routing loops, as the old path is not automatically invalidated.- - --Solution:- - --Don't mark paths. Instead use the tracker TVLV to fill a cache with the mcast/dests lists and assign a hash to this information. Then later send the multicast data with a TVLV containing only this hash instead of the full mcast/dests list. Therefore a specific list of destinations is still maintained and routing decisions still happen on the go, loopfree, instead of trying to a maintain a loopfree, adjacent multicast routing table.- - ---- - --> Don't add a sequence number, we don't need it now. And a new hashing/caching TVLV described above should work fine later. \ No newline at end of file

1 0

[doc] main: Merge tag 'backup-redmine/2024-05-10' (50cc3735)
by postmaster＠open-mesh.org 10 May '24

10 May '24

Repository : ssh://git@diktynna/doc On branch : main >--------------------------------------------------------------- commit 50cc37359d6467ec8a7b140dcfd0352e74361426 Merge: 8749c351 548ae00b Author: Sven Eckelmann <sven(a)narfation.org> Date: Fri May 10 20:38:18 2024 +0200 Merge tag 'backup-redmine/2024-05-10' >--------------------------------------------------------------- Diff suppressed because of size. To see it, use: git diff-tree --root --patch-with-stat --no-color --ignore-space-at-eol --textconv --ext-diff --cc 50cc37359d6467ec8a7b140dcfd0352e74361426

1 0

[batman-adv] main,main: batman-adv: annotate writes on dev->mtu from ndo_change_mtu() (8f27a9c1)
by postmaster＠open-mesh.org 09 May '24

09 May '24

Repository : ssh://git@diktynna/batman-adv On branches: main,main >--------------------------------------------------------------- commit 8f27a9c14e0a9ba1ba1c8499eb703595646dce8b Author: Eric Dumazet <edumazet(a)google.com> Date: Mon May 6 10:28:12 2024 +0000 batman-adv: annotate writes on dev->mtu from ndo_change_mtu() Simon reported that ndo_change_mtu() methods were never updated to use WRITE_ONCE(dev->mtu, new_mtu) as hinted in commit 501a90c94510 ("inet: protect against too small mtu values.") We read dev->mtu without holding RTNL in many places, with READ_ONCE() annotations. It is time to take care of ndo_change_mtu() methods to use corresponding WRITE_ONCE() Signed-off-by: Eric Dumazet <edumazet(a)google.com> Reported-by: Simon Horman <horms(a)kernel.org> Closes: https://lore.kernel.org/netdev/20240505144608.GB67882@kernel.org/ Reviewed-by: Jacob Keller <jacob.e.keller(a)intel.com> Reviewed-by: Sabrina Dubroca <sd(a)queasysnail.net> Reviewed-by: Simon Horman <horms(a)kernel.org> Acked-by: Shannon Nelson <shannon.nelson(a)amd.com> Link: https://lore.kernel.org/r/20240506102812.3025432-1-edumazet@google.com Signed-off-by: Jakub Kicinski <kuba(a)kernel.org> Signed-off-by: Sven Eckelmann <sven(a)narfation.org> >--------------------------------------------------------------- 8f27a9c14e0a9ba1ba1c8499eb703595646dce8b net/batman-adv/soft-interface.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/net/batman-adv/soft-interface.c b/net/batman-adv/soft-interface.c index 89c51b3c..30ecbc2e 100644 --- a/net/batman-adv/soft-interface.c +++ b/net/batman-adv/soft-interface.c @@ -159,7 +159,7 @@ static int batadv_interface_change_mtu(struct net_device *dev, int new_mtu) if (new_mtu < ETH_MIN_MTU || new_mtu > batadv_hardif_min_mtu(dev)) return -EINVAL; - dev->mtu = new_mtu; + WRITE_ONCE(dev->mtu, new_mtu); bat_priv->mtu_set_by_user = new_mtu; return 0;

1 0

[linux-merge]linux integration; annotated tag, v6.9-rc7, created. v6.9-rc7
by postmaster＠open-mesh.org 05 May '24

05 May '24

The annotated tag, v6.9-rc7 has been created at 74609cb690e2cd9a5e6f20a6564f415ccd0141f7 (tag) tagging dd5a440a31fae6e459c0d6271dddd62825505361 (commit) replaces v6.9-rc6 tagged by Linus Torvalds on Sun May 5 14:06:01 2024 -0700 - Shortlog ------------------------------------------------------------ Linux 6.9-rc7 -----BEGIN PGP SIGNATURE----- iQFSBAABCAA8FiEEq68RxlopcLEwq+PEeb4+QwBBGIYFAmY39LkeHHRvcnZhbGRz QGxpbnV4LWZvdW5kYXRpb24ub3JnAAoJEHm+PkMAQRiGaB8H+wWcwT1O7K2SQx1a sHDYJSXfbjgShS7Wt+gbDNvhGJqG/5FkpHyBmBKUdElZs8QMf21GAbIfJvzcNThA g+FakIMjfhNH/dr6TJXHWbb2NZV67exDbbuaQDyMhNhIZqil4BH/OEPbLYIdquvm /HDGFB/whVoHVC+Ug8esEOL3Uy+rizBDlsT/K4ZgpOC3TuUmlRpptSVACwjcCGXM PFKyyTIr0ZnKcz3+4yTEtpDFm6e/ujxMwM66GBCgmPaZ3lJp5ruY3kGpBTmSyoqV Rh3CQlIhBo8gwlAx/yQXfxEZomhxT6DfRpc6s/1W0J1UZN/j2pYy056OYyckG32c uQ9ujxQ= =M0wP -----END PGP SIGNATURE----- ----------------------------------------------------------------------- -- linux integration

1 0

[linux-merge]linux integration; branch, batadv/net, updated. batadv-net-pullrequest-20240405-1-g7e5fff27b4fae
by postmaster＠open-mesh.org 04 May '24

04 May '24

The following commit has been merged in the batadv/net branch: commit 7e5fff27b4fae535afe598624255c75bc15c1953 Author: Sven Eckelmann <sven(a)narfation.org> Date: Sat May 4 21:57:30 2024 +0200 batman-adv: Don't accept TT entries for out-of-spec VIDs The internal handling of VLAN IDs in batman-adv is only specified for following encodings: * VLAN is used - bit 15 is 1 - bit 11 - bit 0 is the VLAN ID (0-4095) - remaining bits are 0 * No VLAN is used - bit 15 is 0 - remaining bits are 0 batman-adv was only preparing new translation table entries (based on its soft interface information) using this encoding format. But the receive path was never checking if entries in the roam or TT TVLVs were also following this encoding. It was therefore possible to create more than the expected maximum of 4096 + 1 entries in the originator VLAN list. Simply by setting the "remaining bits" to "random" values in corresponding TVLV. Cc: stable(a)vger.kernel.org Fixes: 7ea7b4a14275 ("batman-adv: make the TT CRC logic VLAN specific") Reported-by: Linus Lüssing <linus.luessing(a)c0d3.blue> Signed-off-by: Sven Eckelmann <sven(a)narfation.org> diff --git a/net/batman-adv/originator.c b/net/batman-adv/originator.c index 71c143d4b6d05..828c2bb22d1ce 100644 --- a/net/batman-adv/originator.c +++ b/net/batman-adv/originator.c @@ -12,6 +12,7 @@ #include <linux/errno.h> #include <linux/etherdevice.h> #include <linux/gfp.h> +#include <linux/if_vlan.h> #include <linux/jiffies.h> #include <linux/kref.h> #include <linux/list.h> @@ -131,6 +132,29 @@ batadv_orig_node_vlan_get(struct batadv_orig_node *orig_node, return vlan; } +/** + * batadv_vlan_id_valid() - check if vlan id is in valid batman-adv encoding + * @vid: the VLAN identifier + * + * Return: true when either no vlan is set or if VLAN is in correct range, + * false otherwise + */ +static bool batadv_vlan_id_valid(unsigned short vid) +{ + unsigned short non_vlan = vid & ~(BATADV_VLAN_HAS_TAG | VLAN_VID_MASK); + + if (vid == 0) + return true; + + if (!(vid & BATADV_VLAN_HAS_TAG)) + return false; + + if (non_vlan) + return false; + + return true; +} + /** * batadv_orig_node_vlan_new() - search and possibly create an orig_node_vlan * object @@ -149,6 +173,9 @@ batadv_orig_node_vlan_new(struct batadv_orig_node *orig_node, { struct batadv_orig_node_vlan *vlan; + if (!batadv_vlan_id_valid(vid)) + return NULL; + spin_lock_bh(&orig_node->vlan_list_lock); /* first look if an object for this vid already exists */ -- linux integration

1 0

[linux-merge]linux integration; annotated tag, v6.1.90, created. v6.1.90
by postmaster＠open-mesh.org 04 May '24

04 May '24

The annotated tag, v6.1.90 has been created at cec01788b5f3862eb82f4c0f26b287ee57db3ee0 (tag) tagging 909ba1f1b4146de529469910c1bd0b1248964536 (commit) replaces v6.1.83 tagged by Greg Kroah-Hartman on Thu May 2 16:31:16 2024 +0200 - Shortlog ------------------------------------------------------------ This is the 6.1.90 stable release -----BEGIN PGP SIGNATURE----- iQIzBAABCAAdFiEEZH8oZUiU471FcZm+ONu9yGCSaT4FAmYzo7QACgkQONu9yGCS aT7gag/+L3r2MdLi+ARRUuREouP93MrmcLV4NaI+xo1u15TCdAf7OL1R5bjKcA6g QVI2HJfJqCuPai+DzR6OO1at2MfWNWIEXElg67a/aP8HIPEVHh6co68NmavJE2xn +Wdual1QEdRVs7w/OGWrPd37nseOsMUFrflqxwUy1P9ZkYY0iR4Uuz5kdVWpFJLw qz6oFRh2ScoXgn2SWaWH+Z+7bu/Mx6sj3p98zg5AiBKZ+uDQUoH3YC5CpFmiPda3 TaDizOcYcSlzxduHoHG3WHe64bCCJqyc85lTCKDxKVpoK/C8ybuYMnWPkMub2a/t bu7riv9dEhG4TeWN5rjztsa3sZrHYjG9KJnoyJeXX7SN2QfXT+uOXypEI/sgBDgL KU08H+4mSJPtje90JTeJRW0B5+XH2unRr0PCUf+vwjB0cUnHNor8VZOLmvzc4PXd /kXEaOvNrtFpc8L4CR0MRJoR/vMt+yPTJt+X+ARbYOG+86LTlA+5+T7pyVoGkQKY maTJnM/wAl2Y/lwK4x9yOQpV9kJKhVT+kgNskjRQp9h56D+KLEI7J3rratBffXFp hy1lFr3bpTrUk8mDyRtiCB/DWb+AdXkoDClsttLCBFcMJp/a9c2Gk/CLeyqxz63N hBjjgZ8iyYOAcj4m6TeUFJ/FkFKJ5ufvkzZKT+1R6BITy8PbU68= =e8uH -----END PGP SIGNATURE----- Sven Eckelmann (1): batman-adv: Avoid infinite loop trying to resize local TT ----------------------------------------------------------------------- -- linux integration

1 0

Jump to page:

2024

2023

2022

2021

2020

2019

2018

2017

2016

2015

2014

2013

2012

2011

2010

2009

commits