commits

commits@lists.open-mesh.org

1 participants
12401 discussions

[batman-adv] maint's head updated: batman-adv: fix batadv_nc_random_weight_tq (db48c60b)
by postmaster＠open-mesh.org 13 Apr '20

13 Apr '20

Repository : ssh://git@diktynna/batman-adv Branch 'maint' now includes: db48c60b batman-adv: fix batadv_nc_random_weight_tq

1 0

[batman-adv] master: batman-adv: fix batadv_nc_random_weight_tq (db48c60b)
by postmaster＠open-mesh.org 13 Apr '20

13 Apr '20

Repository : ssh://git@diktynna/batman-adv On branch : master >--------------------------------------------------------------- commit db48c60b0edb995450ee846157364bd09bb23762 Author: George Spelvin <lkml(a)sdf.org> Date: Sun Mar 8 09:44:59 2020 -0400 batman-adv: fix batadv_nc_random_weight_tq and change to pseudorandom numbers, as this is a traffic dithering operation that doesn't need crypto-grade. The previous code operated in 4 steps: 1. Generate a random byte 0 <= rand_tq <= 255 2. Multiply it by BATADV_TQ_MAX_VALUE - tq 3. Divide by 255 (= BATADV_TQ_MAX_VALUE) 4. Return BATADV_TQ_MAX_VALUE - rand_tq This would apperar to scale (BATADV_TQ_MAX_VALUE - tq) by a random value between 0/255 and 255/255. But! The intermediate value between steps 3 and 4 is stored in a u8 variable. So it's truncated, and most of the time, is less than 255, after which the division produces 0. Specifically, if tq is odd, the product is always even, and can never be 255. If tq is even, there's exactly one random byte value that will produce a product byte of 255. Thus, the return value is 255 (511/512 of the time) or 254 (1/512 of the time). If we assume that the truncation is a bug, and the code is meant to scale the input, a simpler way of looking at it is that it's returning a random value between tq and BATADV_TQ_MAX_VALUE, inclusive. Well, we have an optimized function for doing just that. Fixes: c3289f3650d3 ("batman-adv: network coding - code and transmit packets if possible") Signed-off-by: George Spelvin <lkml(a)sdf.org> Signed-off-by: Sven Eckelmann <sven(a)narfation.org> >--------------------------------------------------------------- db48c60b0edb995450ee846157364bd09bb23762 net/batman-adv/network-coding.c | 9 +-------- 1 file changed, 1 insertion(+), 8 deletions(-) diff --git a/net/batman-adv/network-coding.c b/net/batman-adv/network-coding.c index 8f0717c3..b0469d15 100644 --- a/net/batman-adv/network-coding.c +++ b/net/batman-adv/network-coding.c @@ -1009,15 +1009,8 @@ static struct batadv_nc_path *batadv_nc_get_path(struct batadv_priv *bat_priv, */ static u8 batadv_nc_random_weight_tq(u8 tq) { - u8 rand_val, rand_tq; - - get_random_bytes(&rand_val, sizeof(rand_val)); - /* randomize the estimated packet loss (max TQ - estimated TQ) */ - rand_tq = rand_val * (BATADV_TQ_MAX_VALUE - tq); - - /* normalize the randomized packet loss */ - rand_tq /= BATADV_TQ_MAX_VALUE; + u8 rand_tq = prandom_u32_max(BATADV_TQ_MAX_VALUE + 1 - tq); /* convert to (randomized) estimated tq again */ return BATADV_TQ_MAX_VALUE - rand_tq;

1 0

[batman-adv] master: Merge branch 'maint' (3d186966)
by postmaster＠open-mesh.org 13 Apr '20

13 Apr '20

Repository : ssh://git@diktynna/batman-adv On branch : master >--------------------------------------------------------------- commit 3d1869667a2c550764806373630ab86f5b93917a Merge: b5ccc4b3 db48c60b Author: Sven Eckelmann <sven(a)narfation.org> Date: Mon Apr 13 21:11:59 2020 +0200 Merge branch 'maint' >--------------------------------------------------------------- 3d1869667a2c550764806373630ab86f5b93917a net/batman-adv/network-coding.c | 9 +-------- 1 file changed, 1 insertion(+), 8 deletions(-)

1 0

[linux-merge]linux integration; annotated tag, v4.4.219, created. v4.4.219
by postmaster＠open-mesh.org 13 Apr '20

13 Apr '20

The annotated tag, v4.4.219 has been created at d4803ebc93b412c6cae7b7936543260a9b87eb97 (tag) tagging 10d9c6f92756c1b9049e409cd5e7faed40f95294 (commit) replaces v4.4.217 tagged by Greg Kroah-Hartman on Mon Apr 13 10:31:37 2020 +0200 - Shortlog ------------------------------------------------------------ This is the 4.4.219 stable release -----BEGIN PGP SIGNATURE----- iQIzBAABCAAdFiEEZH8oZUiU471FcZm+ONu9yGCSaT4FAl6UI2kACgkQONu9yGCS aT6xyxAAmsF1QOau51c5ZD3Oaar681QA+7QOsu4LLTKSSFU+X9AkCTAnuYmaIxnL 5b+HF6v3g5IWnEjc2p17suaePOO4OYwK1nSqQPFaQC7uzEFNOsWELGKuvUmpk8yp jxO5ZdVQQ1ovrNXaNMA+hH258MuHkjRiq2J0upR95AploQqJv/cVzTy8MwqKOTZz FD5keTLdYwPVR8Mns069Y5ESqIpAmZIN2+p0pDRsXa4KeFPtswAVxjryYKzp7zpL HZsibEk0zMVNHlBjrwxHHrTwJaaTvc6NIU+4Gw/zBpOoCbm/mPK+Im1p980F2tPM msfa1OdZJglr9/mjP63+/bknQg0IZ0vJVHZMyNVydqw+J0Ej1DZ9wHBrgUaFVStx AbXRZ5hnfGI/cPo+fbayfFAN7+ADL5+8Xex5Pz+J0rCIwGmKkXQqKGwyBzXsh99+ ZK78DMeU/ZWZGv7mLUwDvn+6gW+GZuTC3b3GNor9ZJHEsxcILna3IlB6YA1mKqP6 6/+LsIWvgn0a4wVmPGV8f5B2yct7Sko9d3Y5wtKtiuo4bsrvTqhiUlc4cHFizrRv la6XaJLLJ8BmwaYmdeCsZ1xvLtVfOUhz1sfyqCRWS9tq9KfKLc0ZMYSpo4TMyIub YKKdb4rKT+jo5oCANLxiUz9wzpfmZPN/BMVjyFLW3r/gJqII9pk= =bFSJ -----END PGP SIGNATURE----- ----------------------------------------------------------------------- -- linux integration

1 0

[linux-merge]linux integration; annotated tag, v4.9.219, created. v4.9.219
by postmaster＠open-mesh.org 13 Apr '20

13 Apr '20

The annotated tag, v4.9.219 has been created at 65e0446e545c787be45b4e5502d20aa2d83241e8 (tag) tagging 5188957a315f664d46ff58fedecbc0f7503f1b22 (commit) replaces v4.9.217 tagged by Greg Kroah-Hartman on Mon Apr 13 10:32:59 2020 +0200 - Shortlog ------------------------------------------------------------ This is the 4.9.219 stable release -----BEGIN PGP SIGNATURE----- iQIzBAABCAAdFiEEZH8oZUiU471FcZm+ONu9yGCSaT4FAl6UI7sACgkQONu9yGCS aT5png//QOOP2eJhRXJ1fljGpHhS8TizKPG4HsvWYEvbJpiPgap4+K//MHHPQJBH c7C03STaMoFEwb2kmWIWmQWwUlRIRaG0ubuCGYLboncts0jWOnbuN3u51Z31V2/w LjJ3BKAt+EDGxltxV+KFE7Gp5DQ5bvN4PzlkNDpyF90QtjCZSDBpFR0c466lkUsy 26RYU3BG2RbuNDGPqgzhIsTvc4hpmiPM/pvkXbAHqjf7TDeDPZnQntfwvqjtSUVu fDey9pBNSkfam++29t14bYVeRIp1i73ASFZe7IOajb3+U5B+mUGD1efurDAAMjiE hJpw1p2SNidDntUfW53xF6xiSNDmxUpOQexWNgMQZZrLow0EObm4eRkXwJLgch18 BmtgHg2NKHfcosXP+yTzmwiyBOes0/q7EnIR6IeCWdYH+9TXwSy4BL+eMyJUZR7+ A1FEIt3+SuIee88N+b+rn4u94r4vvxzRBZ5flpX8TJDSkQ2FhAf4to7dXHA/BZkg +IKNaW/zvcgTRGROOzODVenbXcGseOseoNMXzp4PciAtZvWfGXo0LU82gD/SivS4 tkA+C/bBu5WBzPr0Pzl+fhlHn5maLpIIukNPOGsSASBh/d11BVE4951GzlhEFjgT km4bfo/85QtD43s68emrJUNoUE7RfKlulhlbN5Aa+Xg/N/DcTo8= =/6B3 -----END PGP SIGNATURE----- ----------------------------------------------------------------------- -- linux integration

1 0

[linux-merge]linux integration; annotated tag, v4.14.176, created. v4.14.176
by postmaster＠open-mesh.org 13 Apr '20

13 Apr '20

The annotated tag, v4.14.176 has been created at 53a681671b862ed7df53f52c1f8793b53b27dd16 (tag) tagging c10b57a567e4333b9fdf60b5ec36de9859263ca2 (commit) replaces v4.14.174 tagged by Greg Kroah-Hartman on Mon Apr 13 10:34:39 2020 +0200 - Shortlog ------------------------------------------------------------ This is the 4.14.176 stable release -----BEGIN PGP SIGNATURE----- iQIzBAABCAAdFiEEZH8oZUiU471FcZm+ONu9yGCSaT4FAl6UJB8ACgkQONu9yGCS aT7Y3w//SzcPCruJztn3Mijf0PTsGQDhGwoZsb3yQe16/f1B4RSqJYU4OpM3ZCWV HPDM6KGyK3O/XdegVf+b/kQqsSMscSuUDsm51THU3oyI1OvZRMFMQKlj78frBcpm ZAHEInt/MkVO35DHd8MUW+L1ljHOKt0NIlNtxRVSwBtRmyYwsGi25SaeZLa6S3FQ Uf50dH2jh7PFixdRv+9SDLy4kCu1c36K4rLEWG+TFNDDc4ORNCTt8aWkMowouC75 IVQ10d9Y/LPuo94M8tcxSEOwAQLNf0iOlhOCWHc5wLBFlGCc5tgkXYjACEKHd4Ma pJtWFvaLJ8d+v3C5qIV41cPBh/uaKFRab3Lq8DTyTwpzyLe3ghvNXcesa+tWzYFE W90i0P/irCXrhlOV41hVp0cbI9YW0xAwdsoPn0qm91g/KfZSCDtvw40qw9ILRTUg Sv9Ex+6L4moSQ0p2XKcgIEn0qUiUXwTeaT75j+ZKk9GJrrr5BbgE8BTDLs6pyi6M BnGYN1PatsNUkAf016nFeoth6xhpyH0asbkUeSLDyPNEV9bkONS3k7eWoiiNJKIK 2D8WetLQf/Jb0x/0pjjIPWW0k62tO6OwARpz7jTiDFY0nJKvh26nVqBfME8QAq5P ktWidSldVOu1d/FokoVr66mGYentYQHUGyFX0FdIDabKKcIMDuc= =iJMT -----END PGP SIGNATURE----- ----------------------------------------------------------------------- -- linux integration

1 0

[linux-merge]linux integration; annotated tag, v4.19.115, created. v4.19.115
by postmaster＠open-mesh.org 13 Apr '20

13 Apr '20

The annotated tag, v4.19.115 has been created at a026986d1ff19c63849706a9eaf477fe995557c2 (tag) tagging 6dd0e32665e591e9debe3edaf73c2f8135bf047e (commit) replaces v4.19.113 tagged by Greg Kroah-Hartman on Mon Apr 13 13:08:05 2020 +0200 - Shortlog ------------------------------------------------------------ This is the 4.19.115 stable release -----BEGIN PGP SIGNATURE----- iQIzBAABCAAdFiEEZH8oZUiU471FcZm+ONu9yGCSaT4FAl6USBUACgkQONu9yGCS aT6dNxAA1BJKHbO1TOMTYi21N8XNbMOOblVxrLDe+Y2nEj2KIqiehlsoreV34F/g IswNAuA3JXp7pU53RIKsTIWvx9CvNit55sJ1eKWTfFZGCotsBWH9Xzeh9Ao1wURG vhE5tX8PUwEzZ/sFphVmVvv5oUkQyHYKpEosyVOqL5eIQe5E430PxB/xvz4I0Vyq HHiXmrNekXi5kY156k1RqLQ/RhKMFPNi7swm1uFKLS1qrcIlQzgq5MFk5l59oEMo xob25EeeddVa/4roNSVk9IZGZjXpRPsvRM8kxjSXn2KVz1aO8TgYXF1RyWeNthsZ VXf6XkasSh3bwMX6imhV1fGmepG3OvSZg0k2EvRTpcY84kFlIrC1l2YuOHrCETgL GkptUtGK0a2FEiyBK/0nxvf2E6iaoT4NeTYlyTkL8iOgJ+xMvuSzCpFfQjfkOjGz h3AD+Twqu7lqY54nOvyAkA94joEFzVuzSoYCABAImFq4kvu4khhWBXTmkqUf47aI 1O3m4bMEMLDBRwiBpRsu5c0C+ghHHQtOWTH/UjyOI1aGEKFZyBe5CHYmRo2W9tDg rrlymg1iVMR1o9pvzzRroCokKCzBSirEWKxyyMIFWko5xQvTvae5fTIaAWlvBGjP oH3eIPDWw1ZD1WxiSGzM2Wx4AyumZ1y3pnOHV3uUnYb3cM0l9g8= =bfll -----END PGP SIGNATURE----- ----------------------------------------------------------------------- -- linux integration

1 0

[linux-merge]linux integration; annotated tag, v5.4.32, created. v5.4.32
by postmaster＠open-mesh.org 13 Apr '20

13 Apr '20

The annotated tag, v5.4.32 has been created at 5a3f3bcc23bf88614e766117ec78f4330b05c691 (tag) tagging bc844d58f697dff3ded4b410094ee89f5cedc04c (commit) replaces v5.4.28 tagged by Greg Kroah-Hartman on Mon Apr 13 10:48:18 2020 +0200 - Shortlog ------------------------------------------------------------ This is the 5.4.32 stable release -----BEGIN PGP SIGNATURE----- iQIzBAABCAAdFiEEZH8oZUiU471FcZm+ONu9yGCSaT4FAl6UJ1IACgkQONu9yGCS aT6i1A//RmLhD1Td+1pGWODgsMtfYD1FMB07D2uyFlX/NJe3jnhR9XGIKjFEtFSt bLXoQZlm07GPS7fsll7rE6Ydq0b1c5z59l+5pFCP4cc0ehM3Gca/V77ui0YBh9Mq /Jvk70qyE4en20qTia16cjozUjMreYPDdbqoR4rB3Lq+ALEEOwS0G4h2Nd4PTYGp YDXBwYn+O/f+CAl1arQeOSwpEThGGA4giSzBGaevq09xl2oIs4hAIWTpZ0WtugjR C4AXSEfl9Y/3OcYJm9KYVx4HqyunDhM3rY5ecCZXqeG4g9i5PZob9KisHuhs4nDD CBHd8ALTk0jo869MpizJ7nlcaGWPzBMSyxQeo1icq340KZjH/zWm7FY72VL+tBI0 DSpPyP7zJmQESuZGRWfjLZkETH3edg6VI9233pB6OSfddYh7asrDVcw1jwMpr6Pf Y71aR7D9cYVyNPAP5AzQzdKUQlEPW1t4GhW6Cwxt7lbMZV18N73vYUxpl7IjSUa6 6J5FHEIylnOFmpObzEC4Rj45Poy5ziI44/jmKMf7jmua9IAmHK2Dd6X5XjCRX40C Urf5it+wC5vkHVS6SW1tN4kbBhDfThHsAG71a3Y7kZeSpT6MrgneLEM9/BNk+csv gKTMukqZrgmR+zYTY78nbwM/XflqIqSwkF97GNvalyvT48Cokco= =Wb3/ -----END PGP SIGNATURE----- ----------------------------------------------------------------------- -- linux integration

1 0

[linux-merge]linux integration; annotated tag, v5.5.17, created. v5.5.17
by postmaster＠open-mesh.org 13 Apr '20

13 Apr '20

The annotated tag, v5.5.17 has been created at e4e067f369a9b64c5c739731c281fb3879f1b362 (tag) tagging e7a89836a274efd5cce216fe6d20a0bbfbdfd456 (commit) replaces v5.5.13 tagged by Greg Kroah-Hartman on Mon Apr 13 13:16:43 2020 +0200 - Shortlog ------------------------------------------------------------ This is the 5.5.17 stable release -----BEGIN PGP SIGNATURE----- iQIzBAABCAAdFiEEZH8oZUiU471FcZm+ONu9yGCSaT4FAl6UShsACgkQONu9yGCS aT61SRAA1S4gjwng75ZPVgQKefS+f8X/lvW/i0U3Z8XWOkS14eNr7LuPNwIXJE+Q gzVZq/j12S0d35IVK710tY4EK3fktxWbWYwXvhxbfVQAivfJnc5sl27duX7CcUhr w1Y2KUwXMH1CDp08oqfyhTqtvvhmpnIzIGlc15m2tQoZ+92zjQiFDV5cFtxV0UoD vqJE/6m0EVEuv/TizsbyFApfMszbKSL4FS2H78hKV59/s/xMaaeZoxwU1EjM+tZs wLkd5e6RtLlWEQavTsHmCuE0RiA/yvi4LkM9rYwYG+b8GBIcmrb4CTTAKcY37Um1 w8WWCS+pn4WfO8F5cCHTk0mIzsQOPBb/1oF9jaSYtGVmOrXKQvVi5atEGfNGtdh5 LdPGd/UDTgPo+5Hq7ojHNrGNqVPdV1U0K+UKfsC7G0qzcTsi/A0SY5mWVWP0ujM7 mn5MszPxIWXMzyLHKnYcsPEI3Fg5tFUu62qhca3GMOQml9/yn42O3osFtlcRJS3t vX7+qnZPyzzybpPVPWN4/MYN0KJtWpTvclHenCSSCDujyicFLiowJONcNV//tJPO 2HB/BeWWjF2jqrrSzBI+xaB8zvC0nHIdbHSmA1TtwKNFcTlYTCslnTmUSpQbpH+0 /Bq0Mpr89WJBRJ+fh3Dl291CjVX5Y1S/kSzsbkjfG+0B1DSCHPA= =7VIj -----END PGP SIGNATURE----- ----------------------------------------------------------------------- -- linux integration

1 0

[linux-merge]linux integration; annotated tag, v5.6.3, created. v5.6.3
by postmaster＠open-mesh.org 13 Apr '20

13 Apr '20

The annotated tag, v5.6.3 has been created at 13733f7ac02512a239731f547e970372aae7735c (tag) tagging f9fb85751506e75ecffaa498896efbb0c886adda (commit) replaces v5.6 tagged by Greg Kroah-Hartman on Wed Apr 8 09:11:10 2020 +0200 - Shortlog ------------------------------------------------------------ This is the 5.6.3 stable release -----BEGIN PGP SIGNATURE----- iQIzBAABCAAdFiEEZH8oZUiU471FcZm+ONu9yGCSaT4FAl6NeQ4ACgkQONu9yGCS aT72Rg//VFPeGjrjiPEO88ESS60lg3J8x3qUIs5x/2OOHaTs9vzTJxNu9/HZ/POh m2zmEb/ealppeMQ1v+ETAd/hXMGgA7VjA8juJ8HcA9f6Al530+ZAUlqV+VLvmh7n PxSZborU4Quv9kAkl9QQ1RyuqLJbXWcLu5V4DmzEhzvob7Cjhgo2hY1WfFy3B4zF si60F03+91FJaQyxSEvoxX5JZdKlEttROiYfEKGDDZaGbNv16Nd0r9+kLe7/9tRc f9gAop4LVWQT3DxeLfBM9tSxGYraTag1iqaV5cwjeyemaTlMtJRbneXOyLQG2OAu 3aauClDaTXXx1FP8LQrdZSXwQXKZm+d9Kd2T2isPvOeqZ3qwSkMw8l0qS7ax47ur w0rzGQbXE6jYjKm9Q7alRz8RbcH4kXfCTROqSTu9LH9/T9dyZTfHOocvK2lggxYv XuAmB8+Hc+P8qDZZ+kq9HSGKIa58bXTEdoD9Xd3mc9vr7a2yEmnV4Oh7G/QetEma yktpeySthZC9MBrbYNf7cm/5+cTzn/JZrr9NxqTTs8zmbH2xwFZtY4vwqXwIfXlj 7o9SCzbJBF0mVtfiH0MmqMRDoUafLgCIoEtkDHLGs/PBu4aZa11e4+1ksz9xSWYF PvnZyEYrsShB8sJzEbfsVhojXbe5wbl0xMjmYSY0JezEPpHD+kU= =zthA -----END PGP SIGNATURE----- ----------------------------------------------------------------------- -- linux integration

1 0

Jump to page:

2025

2024

2023

2022

2021

2020

2019

2018

2017

2016

2015

2014

2013

2012

2011

2010

2009

commits