commits

commits@lists.open-mesh.org

1 participants
12401 discussions

[batman-adv] master: batman-adv: Drop unused header preempt.h (a1d7220e)
by postmaster＠open-mesh.org 24 Mar '21

24 Mar '21

Repository : ssh://git@diktynna/batman-adv On branch : master >--------------------------------------------------------------- commit a1d7220e479b55e12c6c7f8b1bf58aaec4cb8a60 Author: Sven Eckelmann <sven(a)narfation.org> Date: Tue Mar 23 21:57:14 2021 +0100 batman-adv: Drop unused header preempt.h The commit 9fc9079cdc15 ("batman-adv: Use netif_rx_any_context().") removed the last user for a function declaration from linux/preempt.h. The include should therefore be cleaned up. Signed-off-by: Sven Eckelmann <sven(a)narfation.org> >--------------------------------------------------------------- a1d7220e479b55e12c6c7f8b1bf58aaec4cb8a60 net/batman-adv/bridge_loop_avoidance.c | 1 - 1 file changed, 1 deletion(-) diff --git a/net/batman-adv/bridge_loop_avoidance.c b/net/batman-adv/bridge_loop_avoidance.c index bcd543ce..7dc133cf 100644 --- a/net/batman-adv/bridge_loop_avoidance.c +++ b/net/batman-adv/bridge_loop_avoidance.c @@ -25,7 +25,6 @@ #include <linux/lockdep.h> #include <linux/netdevice.h> #include <linux/netlink.h> -#include <linux/preempt.h> #include <linux/rculist.h> #include <linux/rcupdate.h> #include <linux/skbuff.h>

1 0

[linux-merge]linux integration; annotated tag, batadv-next-pullrequest-20210312, deleted. v5.11-rc1-5-gb1de0f01b011
by postmaster＠open-mesh.org 23 Mar '21

23 Mar '21

The annotated tag, batadv-next-pullrequest-20210312 has been deleted was f4fcd301698069974936d0bb65bba2e2fa8bb1c8 ----------------------------------------------------------------------- tag batadv-next-pullrequest-20210312 There is only a single patch this time: - Use netif_rx_any_context(), by Sebastian Andrzej Siewior -----BEGIN PGP SIGNATURE----- iQJKBAABCgA0FiEE1ilQI7G+y+fdhnrfoSvjmEKSnqEFAmBLjJUWHHN3QHNpbW9u d3VuZGVybGljaC5kZQAKCRChK+OYQpKeoSb6EACfWUz38XgTB/qpmwzFLVj5ho7Z NhkULQqwL8iGo/nOEImQP51wTXF4latraAUy2S188ZhOyZyHdpATL0u66/jIWblE zsxxNulKWBycK641F1HMgd2NpgmdCDE7FWEh4IdOdAM8IoY36j2qCwDr1beK5/fN N6OuJeELaXkCjCNzdTMaEO10yFujqNZ/eRGaC30UMBlqjBNsmzUlGNuMcdr54beq lLJ4MRA4pX95v2iIzCECYOciw4kfZLtBgTKjq1dVXdDnUgSkAtbzEFDQDWok/8Ue dwiGqZeyIXZgGdpiqftsaxEiTmSC9XsZNKU5gOhK0fXCW1blXtvEvcd76HkKvsTl QyTZ9I2oPjkgki8x7t5EvBGyIbz+RW9p9LjfWtOjg12+VNzhQM0I+7H5hlVqeE9p 1owK2c5G9p25WwLC9lihAdtG2PStchx4Uv0JIAYyVzBi73nbKf2awArVU1X6iYFK j/mAKNSVjXgbPDrjc9AATe+rtDud4e7qDr9VHJgwuW73LbifWM+d5bC5ile4aTxf rpJzOg+Lo7bdEo3i3Zdzqii1Y1+4jh7diH4rhTr/pIbtrWd+y27c7tEOVsEkvIIn Ty3frqi3ourKvR7rS21CaOn3srRgn8JUzhJrOnEjqYNxtcDmIrV3hMM1hN5aN8c5 nWKODAZQORbi1zAqyQ== =HAr3 -----END PGP SIGNATURE----- b1de0f01b0115575982cf24c88b35106449e9aa7 batman-adv: Use netif_rx_any_context(). ----------------------------------------------------------------------- -- linux integration

1 0

[linux-merge]linux integration; annotated tag, v5.12-rc4, created. v5.12-rc4
by postmaster＠open-mesh.org 21 Mar '21

21 Mar '21

The annotated tag, v5.12-rc4 has been created at ec10c44a332d761d6f30b5ea5f7111ce10cd98d6 (tag) tagging 0d02ec6b3136c73c09e7859f0d0e4e2c4c07b49b (commit) replaces v5.12-rc3 tagged by Linus Torvalds on Sun Mar 21 14:56:43 2021 -0700 - Shortlog ------------------------------------------------------------ Linux 5.12-rc4 -----BEGIN PGP SIGNATURE----- iQFSBAABCAA8FiEEq68RxlopcLEwq+PEeb4+QwBBGIYFAmBXwRseHHRvcnZhbGRz QGxpbnV4LWZvdW5kYXRpb24ub3JnAAoJEHm+PkMAQRiGX80H/2qQ49e2lbOfIqdR CBThtgg89QmN9WPTfVhwB6b4vejB7kIiIpOPyJVkaio6lVe8Ewhl064fnGHwXm39 vPy0ZVAB96oaKaki6qi1k7jhCAMpl/vXf1RDe5PaEKPwp3Lr81BlY6dcTPbjxkFP Uw+uC3iRQnT8msSqA1vnhbDl9w6jfmuxX45Eo9NWGz0hDCpZNOEt2oSo/OcXTH4k c91FiW8Qv9uZX2tV4VSqFQgVPfneA+OWXMpjMg6kfK3jOJ5cZwmFGAa8ByqWACH/ U9OODYQCsyX5ZM11g7MOt7Iv+YSU8OA0We8KDN4cRZobrCHF0Txp3ZTSPjb/xHE3 9nUM50I= =a6Go -----END PGP SIGNATURE----- Leon Romanovsky (1): module: remove never implemented MODULE_SUPPORTED_DEVICE ----------------------------------------------------------------------- -- linux integration

1 0

[linux-merge]linux integration; annotated tag, v5.12-rc3, created. v5.12-rc3
by postmaster＠open-mesh.org 14 Mar '21

14 Mar '21

The annotated tag, v5.12-rc3 has been created at a6d574dee98b6bc676391ba747e348b7705732c0 (tag) tagging 1e28eed17697bcf343c6743f0028cc3b5dd88bf0 (commit) replaces v5.12-rc2 tagged by Linus Torvalds on Sun Mar 14 14:41:02 2021 -0700 - Shortlog ------------------------------------------------------------ Linux 5.12-rc3 -----BEGIN PGP SIGNATURE----- iQFSBAABCAA8FiEEq68RxlopcLEwq+PEeb4+QwBBGIYFAmBOgu4eHHRvcnZhbGRz QGxpbnV4LWZvdW5kYXRpb24ub3JnAAoJEHm+PkMAQRiGUd0H/3Ey8aWjVAig9Pe+ VQVZKwG+LXWH6UmUx5qyaTxophhmGnWLvkigJMn63qIg4eQtfp2gNFHK+T4OJNIP ybnkjFZ337x4J9zD6m8mt4Wmelq9iW2wNOS+3YZAyYiGlXfMGM7SlYRCQRQznTED 2O/JCMsOoP+Z8tr5ah/bzs0dANsXmTZ3QqRP2uzb6irKTgFR3/weOhj+Ht1oJ4Aq V+bgdcwhtk20hJhlvVeqws+o74LR789tTDCknlz/YNMv9e6VPfyIQ5vJAcFmZATE Ezj9yzkZ4IU+Ux6ikAyaFyBU8d1a4Wqye3eHCZBsEo6tcSAhbTZ90eoU86vh6ajS LZjwkNw= =6y1u -----END PGP SIGNATURE----- ----------------------------------------------------------------------- -- linux integration

1 0

[linux-merge]linux integration; annotated tag, batadv-next-pullrequest-20210312, created. batadv-next-pullrequest-20210312
by postmaster＠open-mesh.org 12 Mar '21

12 Mar '21

The annotated tag, batadv-next-pullrequest-20210312 has been created at f4fcd301698069974936d0bb65bba2e2fa8bb1c8 (tag) tagging b1de0f01b0115575982cf24c88b35106449e9aa7 (commit) replaces v5.11-rc1 tagged by Simon Wunderlich on Fri Mar 12 16:45:25 2021 +0100 - Shortlog ------------------------------------------------------------ There is only a single patch this time: - Use netif_rx_any_context(), by Sebastian Andrzej Siewior -----BEGIN PGP SIGNATURE----- iQJKBAABCgA0FiEE1ilQI7G+y+fdhnrfoSvjmEKSnqEFAmBLjJUWHHN3QHNpbW9u d3VuZGVybGljaC5kZQAKCRChK+OYQpKeoSb6EACfWUz38XgTB/qpmwzFLVj5ho7Z NhkULQqwL8iGo/nOEImQP51wTXF4latraAUy2S188ZhOyZyHdpATL0u66/jIWblE zsxxNulKWBycK641F1HMgd2NpgmdCDE7FWEh4IdOdAM8IoY36j2qCwDr1beK5/fN N6OuJeELaXkCjCNzdTMaEO10yFujqNZ/eRGaC30UMBlqjBNsmzUlGNuMcdr54beq lLJ4MRA4pX95v2iIzCECYOciw4kfZLtBgTKjq1dVXdDnUgSkAtbzEFDQDWok/8Ue dwiGqZeyIXZgGdpiqftsaxEiTmSC9XsZNKU5gOhK0fXCW1blXtvEvcd76HkKvsTl QyTZ9I2oPjkgki8x7t5EvBGyIbz+RW9p9LjfWtOjg12+VNzhQM0I+7H5hlVqeE9p 1owK2c5G9p25WwLC9lihAdtG2PStchx4Uv0JIAYyVzBi73nbKf2awArVU1X6iYFK j/mAKNSVjXgbPDrjc9AATe+rtDud4e7qDr9VHJgwuW73LbifWM+d5bC5ile4aTxf rpJzOg+Lo7bdEo3i3Zdzqii1Y1+4jh7diH4rhTr/pIbtrWd+y27c7tEOVsEkvIIn Ty3frqi3ourKvR7rS21CaOn3srRgn8JUzhJrOnEjqYNxtcDmIrV3hMM1hN5aN8c5 nWKODAZQORbi1zAqyQ== =HAr3 -----END PGP SIGNATURE----- Sebastian Andrzej Siewior (1): batman-adv: Use netif_rx_any_context(). Simon Wunderlich (1): batman-adv: Start new development cycle Sven Eckelmann (3): batman-adv: Drop publication years from copyright info batman-adv: Avoid sizeof on flexible structure batman-adv: Fix names for kernel-doc blocks ----------------------------------------------------------------------- -- linux integration

1 0

[batman-adv] master: batman-adv: Use netif_rx_any_context(). (9fc9079c)
by postmaster＠open-mesh.org 11 Mar '21

11 Mar '21

Repository : ssh://git@diktynna/batman-adv On branch : master >--------------------------------------------------------------- commit 9fc9079cdc159be4b89c385a34de2c70b6e9fb8d Author: Sebastian Andrzej Siewior <bigeasy(a)linutronix.de> Date: Sat Feb 13 18:02:04 2021 +0100 batman-adv: Use netif_rx_any_context(). The usage of in_interrupt() in non-core code is phased out. Ideally the information of the calling context should be passed by the callers or the functions be split as appropriate. The attempt to consolidate the code by passing an arguemnt or by distangling it failed due lack of knowledge about this driver and because the call chains are hard to follow. As a stop gap use netif_rx_any_context() which invokes the correct code path depending on context and confines the in_interrupt() usage to core code. Signed-off-by: Sebastian Andrzej Siewior <bigeasy(a)linutronix.de> Signed-off-by: Sven Eckelmann <sven(a)narfation.org> >--------------------------------------------------------------- 9fc9079cdc159be4b89c385a34de2c70b6e9fb8d compat-include/linux/netdevice.h | 13 +++++++++++++ net/batman-adv/bridge_loop_avoidance.c | 5 +---- 2 files changed, 14 insertions(+), 4 deletions(-) diff --git a/compat-include/linux/netdevice.h b/compat-include/linux/netdevice.h index d6342f94..8f01b48f 100644 --- a/compat-include/linux/netdevice.h +++ b/compat-include/linux/netdevice.h @@ -54,4 +54,17 @@ static inline void batadv_netif_trans_update(struct net_device *dev) #endif /* LINUX_VERSION_IS_LESS(4, 11, 9) */ +#if LINUX_VERSION_IS_LESS(5, 10, 0) + +#define netif_rx_any_context batadv_netif_rx_any_context +static inline int batadv_netif_rx_any_context(struct sk_buff *skb) +{ + if (in_interrupt()) + return netif_rx(skb); + else + return netif_rx_ni(skb); +} + +#endif /* LINUX_VERSION_IS_LESS(5, 10, 0) */ + #endif /* _NET_BATMAN_ADV_COMPAT_LINUX_NETDEVICE_H_ */ diff --git a/net/batman-adv/bridge_loop_avoidance.c b/net/batman-adv/bridge_loop_avoidance.c index 360bdbf4..bcd543ce 100644 --- a/net/batman-adv/bridge_loop_avoidance.c +++ b/net/batman-adv/bridge_loop_avoidance.c @@ -438,10 +438,7 @@ static void batadv_bla_send_claim(struct batadv_priv *bat_priv, u8 *mac, batadv_add_counter(bat_priv, BATADV_CNT_RX_BYTES, skb->len + ETH_HLEN); - if (in_interrupt()) - netif_rx(skb); - else - netif_rx_ni(skb); + netif_rx_any_context(skb); out: if (primary_if) batadv_hardif_put(primary_if);

1 0

[linux-merge]linux integration; branch, batadv/net-next-old, created. v5.11-rc1-6-g8b00bf1999c6
by postmaster＠open-mesh.org 11 Mar '21

11 Mar '21

The branch, batadv/net-next-old has been created at 8b00bf1999c65de9c5c20d4a573a1fd615956a73 (commit) - Shortlog ------------------------------------------------------------ commit 8b00bf1999c65de9c5c20d4a573a1fd615956a73 Author: Sebastian Andrzej Siewior <bigeasy(a)linutronix.de> Date: Sat Feb 13 18:02:04 2021 +0100 batman-adv: Use netif_rx_any_context(). The usage of in_interrupt() in non-core code is phased out. Ideally the information of the calling context should be passed by the callers or the functions be split as appropriate. The attempt to consolidate the code by passing an arguemnt or by distangling it failed due lack of knowledge about this driver and because the call chains are hard to follow. As a stop gap use netif_rx_any_context() which invokes the correct code path depending on context and confines the in_interrupt() usage to core code. Signed-off-by: Sebastian Andrzej Siewior <bigeasy(a)linutronix.de> Signed-off-by: Sven Eckelmann <sven(a)narfation.org> Signed-off-by: Simon Wunderlich <sw(a)simonwunderlich.de> commit fc8377df3a05ee25f8f00cb9baa4e5b25d790bd7 Author: Simon Wunderlich <sw(a)simonwunderlich.de> Date: Sat Feb 13 18:07:30 2021 +0100 batman-adv: Start new development cycle This version will contain all the (major or even only minor) changes for Linux 5.13. The version number isn't a semantic version number with major and minor information. It is just encoding the year of the expected publishing as Linux -rc1 and the number of published versions this year (starting at 0). Signed-off-by: Simon Wunderlich <sw(a)simonwunderlich.de> ----------------------------------------------------------------------- -- linux integration

1 0

[linux-merge]linux integration; annotated tag, batadv-next-pullrequest-20210208, deleted. v5.11-rc1-4-g25d81f9307ff
by postmaster＠open-mesh.org 11 Mar '21

11 Mar '21

The annotated tag, batadv-next-pullrequest-20210208 has been deleted was ac27a7b5d51a5329e36a7747ef230ee646dd869a ----------------------------------------------------------------------- tag batadv-next-pullrequest-20210208 This feature/cleanup patchset is an updated version of the pull request of Feb 2nd (batadv-next-pullrequest-20210202) and includes the following patches: - Bump version strings, by Simon Wunderlich (added commit log) - Drop publication years from copyright info, by Sven Eckelmann (replaced the previous patch which updated copyright years, as per our discussion) - Avoid sizeof on flexible structure, by Sven Eckelmann (unchanged) - Fix names for kernel-doc blocks, by Sven Eckelmann (unchanged) -----BEGIN PGP SIGNATURE----- iQJKBAABCgA0FiEE1ilQI7G+y+fdhnrfoSvjmEKSnqEFAmAhbUkWHHN3QHNpbW9u d3VuZGVybGljaC5kZQAKCRChK+OYQpKeoR7yEACMhdCzMoVPJQwOYWe5p6QwgaBz 85QRT56x9gpFhV5dXCyg7DK3Qt2JRfTfBtMOeZQatFxcACYaGunZSS1L6gDVATpT 5vB+5UwQK8AW7cjkwVS6vJWW9Wmll9IwNe0/1DGvSBjEWwmU/wlRzAPa2uAT2uw5 AxrErEuXo5M3U4mDfJckVD4XA+pKkd9ylLEQ7llcZA4rOaTsr5sNAy5mbxO5EXD9 yP1vq9BoXtsf0FyZbQrMnYre6teAkxVxrvkTn6v44vsFKsi69JaxDiKQ4T7vakZR 1rIQq/8XbkH0dQXEu4C2FtWTzrg9P4KNHBPiT06b+KxlROpfYivcWhIqlofmW2FJ 5bWlumyNg3WoUmaM9kLGTFHagAp8M968W8zsI5fLi0meX0pEzFe/E1iBfkQaYyHh R8Xpt7z1ORYUavFhVXqMw8x92WOLWmdFZjSGaW6sNyCxMFIU7qR16gYcXmucrJyU RY6o159D9AKVOdX/GdX50mvyHjn/lC3KUEGQLUVxXMdJHpj7avn7aEiCWHUvgAxQ jIHLOy0CRsUlCFPmzSqwGs3dAJEZeFbvqMwZjFJ/UXlKwBgPVMy76wIUk57+FWKz 3DTcg+6RIiW+bWazn/Hdbn9JXUNZnp5C6oH62GFPw7G6ywfe/yPex4qubF7feyog T9H6ho+KW3SmRsHY5Q== =fX7f -----END PGP SIGNATURE----- 25d81f9307ffc166427d93152498f45178f5936a batman-adv: Fix names for kernel-doc blocks ----------------------------------------------------------------------- -- linux integration

1 0

[linux-merge]linux integration; annotated tag, v5.12-rc2, created. v5.12-rc2
by postmaster＠open-mesh.org 06 Mar '21

06 Mar '21

The annotated tag, v5.12-rc2 has been created at b3c1bf1d9bc8e536db0c8e0572336f534ae7a46b (tag) tagging a38fd8748464831584a19438cbb3082b5a2dab15 (commit) replaces v5.12-rc1 tagged by Linus Torvalds on Fri Mar 5 17:33:41 2021 -0800 - Shortlog ------------------------------------------------------------ Linux 5.12-rc2 -----BEGIN PGP SIGNATURE----- iQFSBAABCAA8FiEEq68RxlopcLEwq+PEeb4+QwBBGIYFAmBC2/UeHHRvcnZhbGRz QGxpbnV4LWZvdW5kYXRpb24ub3JnAAoJEHm+PkMAQRiGJIAIAJS/qPY8Jk8tczjO xvfokb1KmLE9zij6YH8jzpgAjvgpNFrvEMxASedhwFMqL4RtFeI3RJ0cA980vFlZ 5QK+AVCiFvmeQ8poVAekHARcZ6NiRCLj2+7qsC5iGeRonjDPIJ7zHRawj9NYEUku HUQqLWbi7fws5ANrscpZcqkP8DP6SlFLfYJgAdv6ml1DIZw9q8CB+vFS3ueMD3n4 b0Pt8CiJLhrRkR8Z90/Ayw778RLwUGZfWpWbcEsF9jMkG87N85xvHoPt/cgkUp1C 96joiWihjpjPhhpdOCH3z+n6Dst3Tnm9L5C6dDxEk2lJqlDyPLLn84eM+z70JhkU eV0eyy0= =UocC -----END PGP SIGNATURE----- ----------------------------------------------------------------------- -- linux integration

1 0

[doc] master: Merge branch 'backup-redmine/2021-03-06' (5af6ea9)
by postmaster＠open-mesh.org 06 Mar '21

06 Mar '21

Repository : ssh://git@diktynna/doc On branch : master >--------------------------------------------------------------- commit 5af6ea98e3c2053759ae5c351a4bb1f844141ec4 Merge: a985ae6 36caac2 Author: Sven Eckelmann <sven(a)narfation.org> Date: Sat Mar 6 09:31:06 2021 +0100 Merge branch 'backup-redmine/2021-03-06' >--------------------------------------------------------------- 5af6ea98e3c2053759ae5c351a4bb1f844141ec4 batman-adv/Gateway-Selection-Issue.rst | 161 +++++ batman-adv/bcast-3x.dia | Bin 1003 -> 7363 bytes batman-adv/bcast-arp-req-gw.dia | Bin 1478 -> 16476 bytes batman-adv/broadcast.dia | Bin 1677 -> 17059 bytes .../{Bw1.dia => gateway-selection-issue.dia} | 781 ++++++++++----------- batman-adv/gateway-selection-issue.svg | 64 ++ batman-adv/noflood-sign.dia | Bin 995 -> 5866 bytes 7 files changed, 609 insertions(+), 397 deletions(-) diff --cc batman-adv/Gateway-Selection-Issue.rst index 0000000,0000000..60180cf new file mode 100644 --- /dev/null +++ b/batman-adv/Gateway-Selection-Issue.rst @@@ -1,0 -1,0 +1,161 @@@ ++.. SPDX-License-Identifier: GPL-2.0 ++ ++Gateway Selection Issue ++======================= ++ ++Scenario ++-------- ++ ++|image0| ++ ++*A batman-adv gateway client selecting a gateway behind the actual best ++gateway* ++ ++The scenario consists of BATMAN V nodes. GW1, GW2, GW3 and N1 have 1 ++Gbit/s links. While N2 is behind N1 with a considerably lower ++throughput, here 50 Mbit/s. ++ ++While node N1 selects the correct, best gateway it is directly connected ++to, node N1 only selects GW1 with a 33% chance. And by a 66% selects ++either GW2 or GW3. Leading to an unnecessarily long route. ++ ++Issue Description ++----------------- ++ ++On N1, the gateway table looks as follows: ++ ++:: ++ ++ <code> ++ N1$ batctl gw ++ client (selection class: 5.0 MBit) ++ N1$ batctl gwl ++ [B.A.T.M.A.N. adv openwrt-2019.2-10, MainIF/MAC: primary0/<orig-mac> (bat0/<bat0-mac> BATMAN_V)] ++ Router ( throughput) Next Hop [outgoingIf] Bandwidth ++ * GW1 ( 1000.0) GW1 [ mesh-vpn]: 1000.0/1000.0 MBit ++ GW2 ( 941.1) GW1 [ mesh-vpn]: 1000.0/1000.0 MBit ++ GW3 ( 941.1) GW1 [ mesh-vpn]: 1000.0/1000.0 MBit ++ </code> ++ ++Node N1 correctly selects GW1 as its best gateway thanks to the hop ++penalty which reduces the throughput by 230/255 = 5.9%. The difference ++is larger than the configured 5.0 MBit selection class, so node N1 will ++always select GW1 as its gateway for the unicasted DHCP packets. ++ ++On node N2 however the table gateway table looks as follows: ++ ++:: ++ ++ <code> ++ N2$ batctl gw ++ client (selection class: 5.0 MBit) ++ N2$ batctl gwl ++ [B.A.T.M.A.N. adv openwrt-2019.2-10, MainIF/MAC: primary0/<orig-mac> (bat0/<bat0-mac> BATMAN_V)] ++ Router ( throughput) Next Hop [outgoingIf] Bandwidth ++ * GW3 ( 50.0) GW1 [ wlan0]: 1000.0/1000.0 MBit ++ GW1 ( 50.0) GW1 [ wlan0]: 1000.0/1000.0 MBit ++ GW2 ( 50.0) GW1 [ wlan0]: 1000.0/1000.0 MBit ++ </code> ++ ++On node N2 the BATMAN V metric to all gateways is 50 MBit/s because ++BATMAN V calculates the minimum of the received throughput in the OGM ++(to GW1: 1000, to GW2: 941.1, to GW3: 941.1) and the link throughput ++towards the destination (50 Mbit/s). ++ ++This leads to node N2 selecting the gateway which it first heard an OGM ++from. So it "randomly" selects one of the three available gateways. The ++probability to select the correct, best gateway decreases the more ++gateways are behind GW1 for N2. ++ ++Node N1 had more, better information for selecting the best gateway ++which got lost by calculating the minimum. ++ ++In theory this issue could happen with BATMAN IV, too. However it is a ++lot less likely to happen because BATMAN IV multiplies the link quality ++to the received TQ value instead of calculating a minimum. Therefore for ++BATMAN IV the 5.9% lower TQ to GW2/GW3 created by the hop penalty will ++persist (as long as the hop penalty is not reduced / configured to a ++lower value). ++ ++Solution (approaches) ++--------------------- ++ ++Redirecting unicasted DHCP messages ++~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~ ++ ++Node N1 could detect that it knows a better gateway than the one N2 has ++selected: It could check the DHCP messages send by N2 via a batman-adv ++unicast frame and rewrite its destination to GW1. ++ ++Issue: Could probably loop? ++ ++Sinking unicasted DHCP messages. ++~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~ ++ ++A gateway server, here GW1, could check if it is about to forward a ++unicasted DHCP message to another gateway server. And if so, refrain ++from forwarding and deliver it to its own bat0 instead. ++ ++Issue: A DHCP client sends multiple messages to a DHCP server. We might ++break the DHCP handshake if the routes switched in between the ++handshake. ++ ++Filtering Gateway Announcements ++~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~ ++ ++Nodes could filter out gateway announcements from OGMs before forwarding ++them. A gateway server could always filter out gateway announcements ++from other gateways. A non-gateway-server node could filter out gateway ++announcements from OGMs from each gateway server which does **not** have ++the highest path throughput (or TQ for BATMAN IV). ++ ++Issue: The gateway announcement TVLV handler is called with ++BATADV_TVLV_HANDLER_OGM_CIFNOTFND. If a node were receiving OGMs from ++two different neighbors where one would have the gateway announcement ++TVLV and the other one wouldn��t then this would lead to gateway ++selection flapping with each received OGM. The ++BATADV_TVLV_HANDLER_OGM_CIFNOTFND would need to be removed and replaced ++by a timeout. Which however would lead to reduced responsiveness / ++delays if a gateway disabled its gateway server mode. And more ++importantly, it would break compatibility, it��d need yet another ++TVLV/flag to propagate this capability. And only if all nodes were ++announcing this capability nodes could change their behaviour. ++ ++Another issue is that it might render the stickiness client option void ++if for a forwarding node the gateway with the highest path throughput ++switches often. Which would lead to gateway flapping for gateway client ++even if it set a selection class / stickiness. ++ ++Flagging Best Gateway Announcements ++~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~ ++ ++An additional flag could be added to the gateway announcements. Instead ++of filtering gateway announcements a node would unset this flag if it is ++not from its "best" gateway. A gateway server forwarding gateway ++announcements of other gateway servers would always unset this flag. The ++original gateway server would always set the flag in its gateway ++announcements when originating them. ++ ++A gateway is considered "best" for keeping the flag set if: ++ ++- ++ ++Question: Should we re-set the flag when receiving a gateway ++announcement with the flag unset if it is our best gateway via a ++different neighbor? Or would we avoid resending this OGM anyway due to ++how the BATMAN algorithm works? ++ ++Issues: The stickiness would need to be disregarded for the first OGM ++sequence number(s) or would need to be disregarded periodically to be ++able to converge to the best gateway. ++ ++General issues with filtering or flagging: ++^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ ++ ++While currently BATMAN V only takes the announced download bitrate into ++consideration, if a gateway client would want to select the best gateway ++by upload rate in the future that information would not be available ++anymore. In other words, a forwarding node might have other criteria for ++its best gateway than the final gateway clients. ++ ++.. |image0| image:: gateway-selection-issue.svg diff --cc batman-adv/bcast-3x.dia index 6ed7397,6ed7397..765c43f Binary files differ diff --cc batman-adv/bcast-arp-req-gw.dia index 0064923,0064923..036204c Binary files differ diff --cc batman-adv/broadcast.dia index 48131ae,48131ae..c74e2b4 Binary files differ diff --cc batman-adv/gateway-selection-issue.dia index b97b677,540f4a7..cabc5e3 Binary files differ diff --cc batman-adv/gateway-selection-issue.svg index 0000000,0000000..f9cd5a3 new file mode 100644 --- /dev/null +++ b/batman-adv/gateway-selection-issue.svg @@@ -1,0 -1,0 +1,64 @@@ ++<?xml version="1.0" encoding="UTF-8" standalone="no"?> ++<!DOCTYPE svg PUBLIC "-//W3C//DTD SVG 1.0//EN" "http://www.w3.org/TR/2001/PR-SVG-20010719/DTD/svg10.dtd"> ++<svg width="34cm" height="21cm" viewBox="319 229 662 412" xmlns="http://www.w3.org/2000/svg" xmlns:xlink="http://www.w3.org/1999/xlink"> ++ <defs/> ++ <g id="Background"> ++ <ellipse style="fill: #ffa500; fill-opacity: 1; stroke-opacity: 1; stroke-width: 2; stroke: #000000" cx="610" cy="490" rx="30" ry="30"/> ++ <ellipse style="fill: #add8e6; fill-opacity: 1; stroke-opacity: 1; stroke-width: 2; stroke: #000000" cx="770" cy="570" rx="30" ry="30"/> ++ <ellipse style="fill: #ffa500; fill-opacity: 1; stroke-opacity: 1; stroke-width: 2; stroke: #000000" cx="430" cy="490" rx="30" ry="30"/> ++ <ellipse style="fill: #ffa500; fill-opacity: 1; stroke-opacity: 1; stroke-width: 2; stroke: #000000" cx="520" cy="350" rx="30" ry="30"/> ++ <ellipse style="fill: #add8e6; fill-opacity: 1; stroke-opacity: 1; stroke-width: 2; stroke: #000000" cx="950" cy="570" rx="30" ry="30"/> ++ <text font-size="12.8" style="fill: #000000; fill-opacity: 1; stroke: none;text-anchor:start;font-family:sans-serif;font-style:normal;font-weight:normal" x="412" y="492"> ++ <tspan x="412" y="492">GW2</tspan> ++ </text> ++ <text font-size="12.8" style="fill: #000000; fill-opacity: 1; stroke: none;text-anchor:start;font-family:sans-serif;font-style:normal;font-weight:normal" x="592" y="492"> ++ <tspan x="592" y="492">GW1</tspan> ++ </text> ++ <text font-size="12.8" style="fill: #000000; fill-opacity: 1; stroke: none;text-anchor:start;font-family:sans-serif;font-style:normal;font-weight:normal" x="502" y="352"> ++ <tspan x="502" y="352">GW3</tspan> ++ </text> ++ <text font-size="12.8" style="fill: #000000; fill-opacity: 1; stroke: none;text-anchor:start;font-family:sans-serif;font-style:normal;font-weight:normal" x="760" y="572"> ++ <tspan x="760" y="572">N1</tspan> ++ </text> ++ <text font-size="12.8" style="fill: #000000; fill-opacity: 1; stroke: none;text-anchor:start;font-family:sans-serif;font-style:normal;font-weight:normal" x="940" y="572"> ++ <tspan x="940" y="572">N2</tspan> ++ </text> ++ <line style="fill: none; stroke-opacity: 1; stroke-width: 10; stroke: #000000" x1="536.754" y1="376.062" x2="593.246" y2="463.938"/> ++ <line style="fill: none; stroke-opacity: 1; stroke-width: 10; stroke: #000000" x1="503.246" y1="376.062" x2="446.754" y2="463.938"/> ++ <line style="fill: none; stroke-opacity: 1; stroke-width: 10; stroke: #000000" x1="579.008" y1="490" x2="460.992" y2="490"/> ++ <line style="fill: none; stroke-opacity: 1; stroke-width: 10; stroke: #000000" x1="742.305" y1="556.152" x2="637.695" y2="503.848"/> ++ <line style="fill: none; stroke-opacity: 1; stroke-width: 2; stroke-dasharray: 4; stroke: #000000" x1="800.992" y1="570" x2="919.008" y2="570"/> ++ <text font-size="12.8" style="fill: #000000; fill-opacity: 1; stroke: none;text-anchor:start;font-family:sans-serif;font-style:normal;font-weight:normal" x="716" y="340"> ++ <tspan x="716" y="340">GW1, GW2, GW3: Gateway server mode</tspan> ++ </text> ++ <text font-size="12.8" style="fill: #000000; fill-opacity: 1; stroke: none;text-anchor:start;font-family:sans-serif;font-style:normal;font-weight:normal" x="780" y="360"> ++ <tspan x="780" y="360">N1, N2: Gateway client mode</tspan> ++ </text> ++ <line style="fill: none; stroke-opacity: 1; stroke-width: 10; stroke: #000000" x1="764" y1="384" x2="814" y2="384"/> ++ <text font-size="12.8" style="fill: #000000; fill-opacity: 1; stroke: none;text-anchor:start;font-family:sans-serif;font-style:normal;font-weight:normal" x="824" y="388"> ++ <tspan x="824" y="388">: 1000 Mbit/s link</tspan> ++ </text> ++ <text font-size="12.8" style="fill: #000000; fill-opacity: 1; stroke: none;text-anchor:start;font-family:sans-serif;font-style:normal;font-weight:normal" x="824" y="416"> ++ <tspan x="824" y="416">: 50 Mbit/s link</tspan> ++ </text> ++ <line style="fill: none; stroke-opacity: 1; stroke-width: 2; stroke-dasharray: 4; stroke: #000000" x1="764" y1="412" x2="814" y2="412"/> ++ <text font-size="12.8" style="fill: #000000; fill-opacity: 1; stroke: none;text-anchor:start;font-family:sans-serif;font-style:normal;font-weight:normal" x="640" y="630"> ++ <tspan x="640" y="630">Selected GW: GW1</tspan> ++ </text> ++ <g> ++ <path style="fill: none; stroke-opacity: 1; stroke-width: 2; stroke: #90ee90" d="M 748.786,591.214 A 96.8203,96.8203 0 0 1 612.024,529.486"/> ++ <polygon style="fill: #90ee90; fill-opacity: 1; stroke-opacity: 1; stroke-width: 2; stroke: #90ee90" fill-rule="evenodd" points="610.356,522.207 616.886,531.283 611.552,529.612 607.014,532.877 "/> ++ </g> ++ <text font-size="12.8" style="fill: #000000; fill-opacity: 1; stroke: none;text-anchor:start;font-family:sans-serif;font-style:normal;font-weight:normal" x="860" y="520"> ++ <tspan x="860" y="520">Selected GW: GW3</tspan> ++ </text> ++ <g> ++ <path style="fill: none; stroke-opacity: 1; stroke-width: 2; stroke: #ff3f00" d="M 925.2 551.4 C 885.2,521.4 823.334,540 780,530 C 736.666,520 670,480 640,460 C 610,440 661,350 560.736,350"/> ++ <polygon style="fill: #ff3f00; fill-opacity: 1; stroke-opacity: 1; stroke-width: 2; stroke: #ff3f00" fill-rule="evenodd" points="553.236,350 563.236,345 560.736,350 563.236,355 "/> ++ </g> ++ <ellipse style="fill: #ffffff; fill-opacity: 1; stroke-opacity: 1; stroke-width: 2; stroke: #000000" cx="350" cy="610" rx="30" ry="30"/> ++ <ellipse style="fill: #ffffff; fill-opacity: 1; stroke-opacity: 1; stroke-width: 2; stroke: #000000" cx="390" cy="260" rx="30" ry="30"/> ++ <line style="fill: none; stroke-opacity: 1; stroke-width: 10; stroke: #000000" x1="494.506" y1="332.35" x2="415.494" y2="277.65"/> ++ <line style="fill: none; stroke-opacity: 1; stroke-width: 10; stroke: #000000" x1="412.808" y1="515.789" x2="367.192" y2="584.211"/> ++ </g> ++</svg> diff --cc batman-adv/noflood-sign.dia index 1e63ecf,1e63ecf..ab1a0cf Binary files differ

1 0

Jump to page:

2025

2024

2023

2022

2021

2020

2019

2018

2017

2016

2015

2014

2013

2012

2011

2010

2009

commits