commits March 2020

commits@lists.open-mesh.org

1 participants
51 discussions

[batman-adv] master: batman-adv: Replace zero-length array with flexible-array member (b5ccc4b3)

by postmaster＠open-mesh.org

Repository : ssh://git@diktynna/batman-adv On branch : master >--------------------------------------------------------------- commit b5ccc4b348e49095d4f1a4abfdef0e058836b558 Author: Gustavo A. R. Silva <gustavo(a)embeddedor.com> Date: Mon Feb 17 15:43:00 2020 -0600 batman-adv: Replace zero-length array with flexible-array member The current codebase makes use of the zero-length array language extension to the C90 standard, but the preferred mechanism to declare variable-length types such as these ones is a flexible array member[1][2], introduced in C99: struct foo { int stuff; struct boo array[]; }; By making use of the mechanism above, we will get a compiler warning in case the flexible array does not occur last in the structure, which will help us prevent some kind of undefined behavior bugs from being inadvertently introduced[3] to the codebase from now on. Also, notice that, dynamic memory allocations won't be affected by this change: "Flexible array members have incomplete type, and so the sizeof operator may not be applied. As a quirk of the original implementation of zero-length arrays, sizeof evaluates to zero."[1] This issue was found with the help of Coccinelle. [1] https://gcc.gnu.org/onlinedocs/gcc/Zero-Length.html [2] https://github.com/KSPP/linux/issues/21 [3] commit 76497732932f ("cxgb3/l2t: Fix undefined behaviour") Signed-off-by: Gustavo A. R. Silva <gustavo(a)embeddedor.com> Signed-off-by: Sven Eckelman <sven(a)narfation.org> >--------------------------------------------------------------- b5ccc4b348e49095d4f1a4abfdef0e058836b558 net/batman-adv/distributed-arp-table.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/net/batman-adv/distributed-arp-table.c b/net/batman-adv/distributed-arp-table.c index 3d21dd83..b85da4b7 100644 --- a/net/batman-adv/distributed-arp-table.c +++ b/net/batman-adv/distributed-arp-table.c @@ -88,7 +88,7 @@ struct batadv_dhcp_packet { __u8 sname[64]; __u8 file[128]; __be32 magic; - __u8 options[0]; + __u8 options[]; }; #define BATADV_DHCP_YIADDR_LEN sizeof(((struct batadv_dhcp_packet *)0)->yiaddr)

3 years

[batman-adv] tag 'v2020.01' deleted

by postmaster＠open-mesh.org

Repository : ssh://git@diktynna/batman-adv Deleted tag: v2020.01

3 years

[batman-adv] master: batman-adv: Avoid RCU list-traversal in spinlock (6d67acbb)

by postmaster＠open-mesh.org

Repository : ssh://git@diktynna/batman-adv On branch : master >--------------------------------------------------------------- commit 6d67acbb1d911935abf7759c88274b966a2c4564 Author: Sven Eckelmann <sven(a)narfation.org> Date: Sun Feb 16 18:30:12 2020 +0100 batman-adv: Avoid RCU list-traversal in spinlock The new CONFIG_PROVE_RCU_LIST requires a condition statement in (h)list_for_each_entry_rcu when the code might be executed in a non RCU non-reader section with the writer lock. Otherwise lockdep might cause a false positive warning like ============================= WARNING: suspicious RCU usage ----------------------------- translation-table.c:940 RCU-list traversed in non-reader section!! batman-adv is (mostly) following the examples from the RCU documentation and is using the normal list-traversal primitives instead of the RCU list-traversal primitives when the writer (spin)lock is held. The remaining users of RCU list-traversal primitives with writer spinlock have to be converted to the same style as the rest of the code. Reported-by: Madhuparna Bhowmik <madhuparnabhowmik10(a)gmail.com> Signed-off-by: Sven Eckelmann <sven(a)narfation.org> >--------------------------------------------------------------- 6d67acbb1d911935abf7759c88274b966a2c4564 net/batman-adv/translation-table.c | 8 ++++---- 1 file changed, 4 insertions(+), 4 deletions(-) diff --git a/net/batman-adv/translation-table.c b/net/batman-adv/translation-table.c index 85293283..a9635c88 100644 --- a/net/batman-adv/translation-table.c +++ b/net/batman-adv/translation-table.c @@ -862,7 +862,7 @@ batadv_tt_prepare_tvlv_global_data(struct batadv_orig_node *orig_node, u8 *tt_change_ptr; spin_lock_bh(&orig_node->vlan_list_lock); - hlist_for_each_entry_rcu(vlan, &orig_node->vlan_list, list) { + hlist_for_each_entry(vlan, &orig_node->vlan_list, list) { num_vlan++; num_entries += atomic_read(&vlan->tt.num_entries); } @@ -888,7 +888,7 @@ batadv_tt_prepare_tvlv_global_data(struct batadv_orig_node *orig_node, (*tt_data)->num_vlan = htons(num_vlan); tt_vlan = (struct batadv_tvlv_tt_vlan_data *)(*tt_data + 1); - hlist_for_each_entry_rcu(vlan, &orig_node->vlan_list, list) { + hlist_for_each_entry(vlan, &orig_node->vlan_list, list) { tt_vlan->vid = htons(vlan->vid); tt_vlan->crc = htonl(vlan->tt.crc); @@ -937,7 +937,7 @@ batadv_tt_prepare_tvlv_local_data(struct batadv_priv *bat_priv, int change_offset; spin_lock_bh(&bat_priv->softif_vlan_list_lock); - hlist_for_each_entry_rcu(vlan, &bat_priv->softif_vlan_list, list) { + hlist_for_each_entry(vlan, &bat_priv->softif_vlan_list, list) { vlan_entries = atomic_read(&vlan->tt.num_entries); if (vlan_entries < 1) continue; @@ -967,7 +967,7 @@ batadv_tt_prepare_tvlv_local_data(struct batadv_priv *bat_priv, (*tt_data)->num_vlan = htons(num_vlan); tt_vlan = (struct batadv_tvlv_tt_vlan_data *)(*tt_data + 1); - hlist_for_each_entry_rcu(vlan, &bat_priv->softif_vlan_list, list) { + hlist_for_each_entry(vlan, &bat_priv->softif_vlan_list, list) { vlan_entries = atomic_read(&vlan->tt.num_entries); if (vlan_entries < 1) continue;

3 years

[alfred] tag 'v2020.0' created

by postmaster＠open-mesh.org

Repository : ssh://git@diktynna/alfred New tag : v2020.0 Referencing: 1a7b7ef16e6a992c3072a1859e42964fbd5072f3

3 years

[alfred] tag 'v2020.01' deleted

by postmaster＠open-mesh.org

Repository : ssh://git@diktynna/alfred Deleted tag: v2020.01

3 years

[batctl] tag 'v2020.0' created

by postmaster＠open-mesh.org

Repository : ssh://git@diktynna/batctl New tag : v2020.0 Referencing: e2671709576fbdf367defa5b68e44ad3c0c70fd3

3 years

[batctl] tag 'v2020.01' deleted

by postmaster＠open-mesh.org

Repository : ssh://git@diktynna/batctl Deleted tag: v2020.01

3 years

[batman-adv] tag 'v2020.0' created

by postmaster＠open-mesh.org

Repository : ssh://git@diktynna/batman-adv New tag : v2020.0 Referencing: cafbcd3df93842196e16d0685967842b5d34016e

3 years

[alfred] master: alfred: Update CHANGELOG for upcoming release (6123edd)

by postmaster＠open-mesh.org

Repository : ssh://git@diktynna/alfred On branch : master >--------------------------------------------------------------- commit 6123eddc892a4a9f6d112d55971a474dc8259f66 Author: Simon Wunderlich <sw(a)simonwunderlich.de> Date: Wed Mar 4 11:57:13 2020 +0100 alfred: Update CHANGELOG for upcoming release Signed-off-by: Simon Wunderlich <sw(a)simonwunderlich.de> >--------------------------------------------------------------- 6123eddc892a4a9f6d112d55971a474dc8259f66 CHANGELOG.rst | 5 +++++ 1 file changed, 5 insertions(+) diff --git a/CHANGELOG.rst b/CHANGELOG.rst index 997ff0c..854bdc6 100644 --- a/CHANGELOG.rst +++ b/CHANGELOG.rst @@ -1,5 +1,10 @@ .. SPDX-License-Identifier: GPL-2.0 +2020.0 (2020-03-04) +=================== + +* fix build against gpsd API 9.0 + 2019.5 (2019-12-12) ===================

3 years

[alfred] master: alfred: Start new development cycle (a4adede)

by postmaster＠open-mesh.org

Repository : ssh://git@diktynna/alfred On branch : master >--------------------------------------------------------------- commit a4adede297e5d73ecc1816c115b132f67cc98016 Author: Simon Wunderlich <sw(a)simonwunderlich.de> Date: Wed Mar 4 11:57:41 2020 +0100 alfred: Start new development cycle Signed-off-by: Simon Wunderlich <sw(a)simonwunderlich.de> >--------------------------------------------------------------- a4adede297e5d73ecc1816c115b132f67cc98016 alfred.h | 2 +- gpsd/alfred-gpsd.h | 2 +- vis/vis.h | 2 +- 3 files changed, 3 insertions(+), 3 deletions(-) diff --git a/alfred.h b/alfred.h index 38cc27b..8b300e3 100644 --- a/alfred.h +++ b/alfred.h @@ -7,7 +7,7 @@ */ #ifndef SOURCE_VERSION -#define SOURCE_VERSION "2020.0" +#define SOURCE_VERSION "2020.1" #endif #include <net/ethernet.h> diff --git a/gpsd/alfred-gpsd.h b/gpsd/alfred-gpsd.h index 5783eee..a98b45b 100644 --- a/gpsd/alfred-gpsd.h +++ b/gpsd/alfred-gpsd.h @@ -25,7 +25,7 @@ #include "../list.h" #ifndef SOURCE_VERSION -#define SOURCE_VERSION "2020.0" +#define SOURCE_VERSION "2020.1" #endif #define ALFRED_SOCK_PATH_DEFAULT "/var/run/alfred.sock" diff --git a/vis/vis.h b/vis/vis.h index 3e8277a..fcb8a04 100644 --- a/vis/vis.h +++ b/vis/vis.h @@ -14,7 +14,7 @@ #ifndef SOURCE_VERSION -#define SOURCE_VERSION "2020.0" +#define SOURCE_VERSION "2020.1" #endif #define ALFRED_SOCK_PATH_DEFAULT "/var/run/alfred.sock"

3 years

2023

2022

2021

2020

2019

2018

2017

2016

2015

2014

2013

2012

2011

2010

2009

commits March 2020