commits February 2014

commits@lists.open-mesh.org

1 participants
64 discussions

[batman-adv] maint: batman-adv: remove useless assignment (9a91d33)
by postmaster＠open-mesh.org 02 Feb '14

02 Feb '14

Repository : ssh://git@open-mesh.org/batman-adv On branch : maint >--------------------------------------------------------------- commit 9a91d33c0ea234faf59ee7543d5253e6809a6b6f Author: Antonio Quartulli <antonio(a)meshcoding.com> Date: Thu Jan 30 13:57:27 2014 +0100 batman-adv: remove useless assignment Introduced by 41b38727749a94c1a65cf0f4be9bfe1cbaf0adeb ("batman-adv: fix potential kernel paging error for unicast transmissions") Signed-off-by: Antonio Quartulli <antonio(a)meshcoding.com> Signed-off-by: Marek Lindner <mareklindner(a)neomailbox.ch> >--------------------------------------------------------------- 9a91d33c0ea234faf59ee7543d5253e6809a6b6f send.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/send.c b/send.c index 2035bd9..75be770 100644 --- a/send.c +++ b/send.c @@ -256,7 +256,7 @@ static int batadv_send_skb_unicast(struct batadv_priv *bat_priv, struct batadv_orig_node *orig_node, unsigned short vid) { - struct ethhdr *ethhdr = (struct ethhdr *)skb->data; + struct ethhdr *ethhdr; struct batadv_unicast_packet *unicast_packet; int ret = NET_XMIT_DROP;

1 0

[batman-adv] maint: batman-adv: properly check pskb_may_pull return value (eabdc31)
by postmaster＠open-mesh.org 02 Feb '14

02 Feb '14

Repository : ssh://git@open-mesh.org/batman-adv On branch : maint >--------------------------------------------------------------- commit eabdc3175b1d119cd673f36d06264cddb4803ace Author: Antonio Quartulli <antonio(a)meshcoding.com> Date: Thu Jan 30 00:12:24 2014 +0100 batman-adv: properly check pskb_may_pull return value pskb_may_pull() returns 1 on success and 0 in case of failure, therefore checking for the return value being negative does not make sense at all. This way if the function fails we will probably read beyond the current skb data buffer. Fix this by doing the proper check. Signed-off-by: Antonio Quartulli <antonio(a)meshcoding.com> Signed-off-by: Marek Lindner <mareklindner(a)neomailbox.ch> >--------------------------------------------------------------- eabdc3175b1d119cd673f36d06264cddb4803ace routing.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/routing.c b/routing.c index f28920f..f7579d0 100644 --- a/routing.c +++ b/routing.c @@ -833,7 +833,7 @@ static int batadv_check_unicast_ttvn(struct batadv_priv *bat_priv, int is_old_ttvn; /* check if there is enough data before accessing it */ - if (pskb_may_pull(skb, hdr_len + ETH_HLEN) < 0) + if (!pskb_may_pull(skb, hdr_len + ETH_HLEN)) return 0; /* create a copy of the skb (in case of for re-routing) to modify it. */

1 0

[batctl] master's head updated: batctl: switch to net/if.h include to make OpenWrt build happy (abe78a5)
by postmaster＠open-mesh.org 02 Feb '14

02 Feb '14

Repository : ssh://git@open-mesh.org/batctl Branch 'master' now includes: abe78a5 batctl: switch to net/if.h include to make OpenWrt build happy

1 0

[batctl] next: batctl: switch to net/if.h include to make OpenWrt build happy (abe78a5)
by postmaster＠open-mesh.org 02 Feb '14

02 Feb '14

Repository : ssh://git@open-mesh.org/batctl On branch : next >--------------------------------------------------------------- commit abe78a50dd868167121e11f37b166c8193816999 Author: Marek Lindner <mareklindner(a)neomailbox.ch> Date: Wed Jan 29 16:41:30 2014 +0800 batctl: switch to net/if.h include to make OpenWrt build happy Signed-off-by: Sven Eckelmann <sven(a)narfation.org> Signed-off-by: Marek Lindner <mareklindner(a)neomailbox.ch> >--------------------------------------------------------------- abe78a50dd868167121e11f37b166c8193816999 ioctl.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/ioctl.c b/ioctl.c index eccac66..1f827e8 100644 --- a/ioctl.c +++ b/ioctl.c @@ -25,10 +25,10 @@ #include <stdlib.h> #include <string.h> #include <unistd.h> +#include <net/if.h> #include <sys/ioctl.h> #include <sys/types.h> #include <sys/socket.h> -#include <linux/if.h> #include <linux/sockios.h> #include <linux/ethtool.h> #include <stdint.h>

1 0

2024

2023

2022

2021

2020

2019

2018

2017

2016

2015

2014

2013

2012

2011

2010

2009

commits February 2014