[batman-adv] master: batman-adv: checkpatch - Please use a blank line after declarations (55c2fe7)
by postmaster＠open-mesh.org
Repository : ssh://git@open-mesh.org/batman-adv
On branch : master
>---------------------------------------------------------------
commit 55c2fe7a9ec7d5b304c6a1c2ff21d30fad0671fe
Author: Antonio Quartulli <antonio(a)meshcoding.com>
Date: Mon Sep 1 14:37:27 2014 +0200
batman-adv: checkpatch - Please use a blank line after declarations
Signed-off-by: Antonio Quartulli <antonio(a)meshcoding.com>
Signed-off-by: Marek Lindner <mareklindner(a)neomailbox.ch>
>---------------------------------------------------------------
55c2fe7a9ec7d5b304c6a1c2ff21d30fad0671fe
debugfs.c | 1 +
distributed-arp-table.c | 1 +
gateway_client.c | 1 +
packet.h | 1 +
4 files changed, 4 insertions(+)
diff --git a/debugfs.c b/debugfs.c
index a12e25e..d9b9a8e 100644
--- a/debugfs.c
+++ b/debugfs.c
@@ -405,6 +405,7 @@ struct batadv_debuginfo batadv_hardif_debuginfo_##_name = { \
.release = single_release, \
}, \
}
+
static BATADV_HARDIF_DEBUGINFO(originators, S_IRUGO,
batadv_originators_hardif_open);
diff --git a/distributed-arp-table.c b/distributed-arp-table.c
index b598111..aad022d 100644
--- a/distributed-arp-table.c
+++ b/distributed-arp-table.c
@@ -1100,6 +1100,7 @@ void batadv_dat_snoop_outgoing_arp_reply(struct batadv_priv *bat_priv,
batadv_dat_send_data(bat_priv, skb, ip_src, BATADV_P_DAT_DHT_PUT);
batadv_dat_send_data(bat_priv, skb, ip_dst, BATADV_P_DAT_DHT_PUT);
}
+
/**
* batadv_dat_snoop_incoming_arp_reply - snoop the ARP reply and fill the local
* DAT storage only
diff --git a/gateway_client.c b/gateway_client.c
index 90cff58..bcc3e0c 100644
--- a/gateway_client.c
+++ b/gateway_client.c
@@ -775,6 +775,7 @@ batadv_gw_dhcp_recipient_get(struct sk_buff *skb, unsigned int *header_len,
return ret;
}
+
/**
* batadv_gw_out_of_range - check if the dhcp request destination is the best gw
* @bat_priv: the bat priv with all the soft interface information
diff --git a/packet.h b/packet.h
index 34e096d..facd1fe 100644
--- a/packet.h
+++ b/packet.h
@@ -198,6 +198,7 @@ struct batadv_bla_claim_dst {
uint8_t type; /* bla_claimframe */
__be16 group; /* group id */
};
+
#pragma pack()
/**
6 years, 2 months
[batman-adv] master: batman-adv: checkpatch - No space is necessary after a cast (b32044a)
by postmaster＠open-mesh.org
Repository : ssh://git@open-mesh.org/batman-adv
On branch : master
>---------------------------------------------------------------
commit b32044a6283b150feb017b4416be4ce193c74795
Author: Antonio Quartulli <antonio(a)meshcoding.com>
Date: Mon Sep 1 14:37:26 2014 +0200
batman-adv: checkpatch - No space is necessary after a cast
Signed-off-by: Antonio Quartulli <antonio(a)meshcoding.com>
Signed-off-by: Marek Lindner <mareklindner(a)neomailbox.ch>
>---------------------------------------------------------------
b32044a6283b150feb017b4416be4ce193c74795
main.h | 8 ++++----
1 file changed, 4 insertions(+), 4 deletions(-)
diff --git a/main.h b/main.h
index 4c557eb..52cb007 100644
--- a/main.h
+++ b/main.h
@@ -313,10 +313,10 @@ static inline bool batadv_has_timed_out(unsigned long timestamp,
* - when adding 128 - it is neither a predecessor nor a successor,
* - after adding more than 127 to the starting value - it is a successor
*/
-#define batadv_seq_before(x, y) ({typeof(x) _d1 = (x); \
- typeof(y) _d2 = (y); \
- typeof(x) _dummy = (_d1 - _d2); \
- (void) (&_d1 == &_d2); \
+#define batadv_seq_before(x, y) ({typeof(x)_d1 = (x); \
+ typeof(y)_d2 = (y); \
+ typeof(x)_dummy = (_d1 - _d2); \
+ (void)(&_d1 == &_d2); \
_dummy > batadv_smallest_signed_int(_dummy); })
#define batadv_seq_after(x, y) batadv_seq_before(y, x)
6 years, 2 months
[batman-adv] master: batman-adv: checkpatch - else is not generally useful after a break or return (6948dac)
by postmaster＠open-mesh.org
Repository : ssh://git@open-mesh.org/batman-adv
On branch : master
>---------------------------------------------------------------
commit 6948dace1e103b96351512fd79595c6d1ca0f13c
Author: Antonio Quartulli <antonio(a)meshcoding.com>
Date: Mon Sep 1 14:37:25 2014 +0200
batman-adv: checkpatch - else is not generally useful after a break or return
Signed-off-by: Antonio Quartulli <antonio(a)meshcoding.com>
Signed-off-by: Marek Lindner <mareklindner(a)neomailbox.ch>
>---------------------------------------------------------------
6948dace1e103b96351512fd79595c6d1ca0f13c
bitarray.h | 3 +--
fragmentation.h | 3 +--
network-coding.c | 3 +--
translation-table.c | 5 ++---
4 files changed, 5 insertions(+), 9 deletions(-)
diff --git a/bitarray.h b/bitarray.h
index cc24073..2acaafe 100644
--- a/bitarray.h
+++ b/bitarray.h
@@ -29,8 +29,7 @@ static inline int batadv_test_bit(const unsigned long *seq_bits,
diff = last_seqno - curr_seqno;
if (diff < 0 || diff >= BATADV_TQ_LOCAL_WINDOW_SIZE)
return 0;
- else
- return test_bit(diff, seq_bits) != 0;
+ return test_bit(diff, seq_bits) != 0;
}
/* turn corresponding bit on, so we can remember that we got the packet */
diff --git a/fragmentation.h b/fragmentation.h
index 5d7a0e6..d848cf6 100644
--- a/fragmentation.h
+++ b/fragmentation.h
@@ -41,8 +41,7 @@ batadv_frag_check_entry(struct batadv_frag_table_entry *frags_entry)
if (!hlist_empty(&frags_entry->head) &&
batadv_has_timed_out(frags_entry->timestamp, BATADV_FRAG_TIMEOUT))
return true;
- else
- return false;
+ return false;
}
#endif /* _NET_BATMAN_ADV_FRAGMENTATION_H_ */
diff --git a/network-coding.c b/network-coding.c
index 8d04d17..bd33894 100644
--- a/network-coding.c
+++ b/network-coding.c
@@ -1212,8 +1212,7 @@ static bool batadv_nc_skb_coding_possible(struct sk_buff *skb,
{
if (BATADV_SKB_CB(skb)->decoded && !batadv_compare_eth(dst, src))
return false;
- else
- return true;
+ return true;
}
/**
diff --git a/translation-table.c b/translation-table.c
index 5f59e7f..38a804e 100644
--- a/translation-table.c
+++ b/translation-table.c
@@ -2769,9 +2769,8 @@ static bool batadv_send_tt_response(struct batadv_priv *bat_priv,
{
if (batadv_is_my_mac(bat_priv, req_dst))
return batadv_send_my_tt_response(bat_priv, tt_data, req_src);
- else
- return batadv_send_other_tt_response(bat_priv, tt_data,
- req_src, req_dst);
+ return batadv_send_other_tt_response(bat_priv, tt_data, req_src,
+ req_dst);
}
static void _batadv_tt_update_changes(struct batadv_priv *bat_priv,
6 years, 2 months